desrosj
ae5c195d57
Media: Introduce the `has_post_thumbnail` filter.
...
Props rzen, desrosj.
Fixes #44859 .
Built from https://develop.svn.wordpress.org/trunk@44542
git-svn-id: http://core.svn.wordpress.org/trunk@44373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 15:28:50 +00:00
Felix Arntz
f251342de7
I18n: Add missing translator comments in `wp-admin/includes/class-wp-plugins-list-table.php`.
...
Fixes #45898 .
Built from https://develop.svn.wordpress.org/trunk@44541
git-svn-id: http://core.svn.wordpress.org/trunk@44372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 10:46:53 +00:00
desrosj
ca36ed433b
Docs: Correct `since` annotation for `_wp_get_allowed_postdata()`.
...
This function was introduced in 5.0.1, not 4.9.9 as currently indicated. Introduced in [44047].
Built from https://develop.svn.wordpress.org/trunk@44540
git-svn-id: http://core.svn.wordpress.org/trunk@44371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 03:31:49 +00:00
Gary Pendergast
2772e5ec06
Admin: Don't use the `keyup` event in addition to the `input` event.
...
The `keyup` event was used to provide support for IE8, where which doesn't support the `input` event. As we dropped IE8 support some time ago, this was simply adding unnecessary complexity and double-event triggers.
Props dlh, afercia.
Fixes #32882 .
Built from https://develop.svn.wordpress.org/trunk@44539
git-svn-id: http://core.svn.wordpress.org/trunk@44370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:57:50 +00:00
desrosj
8eb90ac374
Docs: Restore `output` annotation in `tags-suggest.js`.
...
This was mistakenly removed in [44537].
See #38922 .
Built from https://develop.svn.wordpress.org/trunk@44538
git-svn-id: http://core.svn.wordpress.org/trunk@44369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:50:51 +00:00
desrosj
6fbf4ceaea
REST API: Restore use of `wp_ajax_ajax_tag_search()` for tag search.
...
This solution does not work with custom taxonomies in the current state.
Reverts [42614,42619,42737].
Props danielbachhuber.
See #38922 .
Built from https://develop.svn.wordpress.org/trunk@44537
git-svn-id: http://core.svn.wordpress.org/trunk@44368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:37:51 +00:00
Gary Pendergast
8441700842
Tests: Add support for a `WP_TESTS_SKIP_INSTALL` environment variable.
...
Defining `WP_TESTS_SKIP_INSTALL=1` when running tests will skip the install step. While this shouldn't be used for full test runs, it's useful for saving time when running small groups of tests.
Props soulseekah.
Fixes #43432 .
Built from https://develop.svn.wordpress.org/trunk@44536
git-svn-id: http://core.svn.wordpress.org/trunk@44367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:19:50 +00:00
desrosj
7855451267
Privacy: Add unit tests for privacy erasure fulfillment notifications.
...
Adds appropriate unit tests for `_wp_privacy_send_erasure_fulfillment_notification()`.
Props birgire, desrosj.
Fixes #44234 .
Built from https://develop.svn.wordpress.org/trunk@44535
git-svn-id: http://core.svn.wordpress.org/trunk@44366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:07:49 +00:00
Gary Pendergast
c219081ce7
Build/Tests: Allow running unit tests from `src`.
...
This is a partial recommit of [44509]: it allows running unit tests from `src` (which is useful), but doesn't make it the default (which Travis is having issues with).
See #45863 .
Built from https://develop.svn.wordpress.org/trunk@44534
git-svn-id: http://core.svn.wordpress.org/trunk@44365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:04:50 +00:00
Gary Pendergast
14c44ad703
Block Editor: Upgrade the `@wordpress/` packages.
...
This brings the block editor in core up to date with the Gutenberg 4.8 plugin release.
Props aduth, gziolo, youknowriad, mkaz, jorgefilipecosta, swissspidy, iseulde, soean, noisysocks, joen, brentswisher, dekervit, dimadin, zebulan, johnny5, nosolosw, netweb, ryelle, etoledom, mzorz, desrosj, mmtr86, tinkerbelly, ocean90, earnjam, ajitbohra, talldanwp, notnownikki, mcsf, afercia, adamsilverstein, gutendev, naoki0h, miyauchi, aldavigdis.
Fixes #45885 .
Built from https://develop.svn.wordpress.org/trunk@44533
git-svn-id: http://core.svn.wordpress.org/trunk@44364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:54:56 +00:00
desrosj
da77cad30f
PHPCS: Fix formatting issues.
...
Fixes formatting issues introduced in [44528].
See #42017 .
Built from https://develop.svn.wordpress.org/trunk@44532
git-svn-id: http://core.svn.wordpress.org/trunk@44363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:52:52 +00:00
desrosj
72098048c6
Docs: Update `since` annotation for `text-transform` support in `safecss_filter_attr()`.
...
Introduced in [42880].
Fixes #42729 .
Built from https://develop.svn.wordpress.org/trunk@44531
git-svn-id: http://core.svn.wordpress.org/trunk@44362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:43:49 +00:00
desrosj
d83d8e1154
Docs: Update `since` annotation for `comments_list_table_query_args`.
...
Introduced in [42420].
Fixes #42997 .
Built from https://develop.svn.wordpress.org/trunk@44530
git-svn-id: http://core.svn.wordpress.org/trunk@44361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:40:51 +00:00
Gary Pendergast
e69c1039eb
Build Tools: Copy unminified JS files to `src`.
...
This allows `SCRIPT_DEBUG` to be set to `true` when running from `src`.
Fixes #45869 .
Built from https://develop.svn.wordpress.org/trunk@44529
git-svn-id: http://core.svn.wordpress.org/trunk@44360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:39:50 +00:00
desrosj
13c66b1b18
Media: Store audio creation date in meta.
...
In [41746], `wp_get_media_creation_timestamp()` was introduced to read the created timestamp for videos from `getID3` in meta whenever possible. This information is useful separately from the dates on the file itself.
This adds the same support audio files by utilizing `wp_get_media_creation_timestamp()` in `wp_read_audio_metadata()`.
Props blob folio, desrosj.
Fixes #42017 .
Built from https://develop.svn.wordpress.org/trunk@44528
git-svn-id: http://core.svn.wordpress.org/trunk@44359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:32:50 +00:00
desrosj
cf1e3b0c40
Docs: Update `since` annotations `WP_Error::has_errors()`
...
Introduced in [42761].
Fixes #42742 .
Built from https://develop.svn.wordpress.org/trunk@44527
git-svn-id: http://core.svn.wordpress.org/trunk@44358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 22:42:51 +00:00
Felix Arntz
5bb4a5aa0e
Upgrade/Install: Add missing call to clear site meta cache in `populate_site_meta()`.
...
See #44896 .
Built from https://develop.svn.wordpress.org/trunk@44526
git-svn-id: http://core.svn.wordpress.org/trunk@44357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 21:29:50 +00:00
Felix Arntz
83603991c6
Bootstrap/Load: Fix missing object argument for singular capability checks and support capability tests overlooked in [44524].
...
See #44458 .
Built from https://develop.svn.wordpress.org/trunk@44525
git-svn-id: http://core.svn.wordpress.org/trunk@44356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 20:44:50 +00:00
Felix Arntz
1e4088fc98
Bootstrap/Load: Introduce fatal error recovery mechanism allowing users to still log in to their admin dashboard.
...
This changeset introduces a `WP_Shutdown_Handler` class that detects fatal errors and which extension (plugin or theme) causes them. Such an error is then recorded, and an error message is displayed. Subsequently, in certain protected areas, for example the admin, the broken extension will be paused, ensuring that the website is still usable in the respective area. The major benefit is that this mechanism allows site owners to still log in to their website, to fix the problem by either disabling the extension or solving the bug and then resuming the extension.
Extensions are only paused in certain designated areas. The frontend for example stays unaffected, as it is impossible to know what pausing the extension would cause to be missing, so it might be preferrable to clearly see that the website is temporarily not accessible instead.
The fatal error recovery is especially important in scope of encouraging the switch to a maintained PHP version, as not necessarily every WordPress extension is compatible with all PHP versions. If problems occur now, non-technical site owners that do not have immediate access to the codebase are not locked out of their site and can at least temporarily solve the problem quickly.
Websites that have custom requirements in that regard can implement their own shutdown handler by adding a `shutdown-handler.php` drop-in that returns the handler instance to use, which must be based on a class that inherits `WP_Shutdown_Handler`. That handler will then be used in place of the default one.
Websites that would like to modify specifically the error template displayed in the frontend can add a `php-error.php` drop-in that works similarly to the existing `db-error.php` drop-in.
Props afragen, bradleyt, flixos90, ocean90, schlessera, SergeyBiryukov, spacedmonkey.
Fixes #44458 .
Built from https://develop.svn.wordpress.org/trunk@44524
git-svn-id: http://core.svn.wordpress.org/trunk@44355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 20:05:49 +00:00
Boone Gorges
811be4779e
Taxonomy: Update `@since` annotations for `meta_box_sanitize_cb` arg.
...
Introduced in [42211].
Fixes #36514 .
Built from https://develop.svn.wordpress.org/trunk@44519
git-svn-id: http://core.svn.wordpress.org/trunk@44350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 15:11:48 +00:00
desrosj
04dff0e2a9
Docs: Update `since` annotations for adding `LIKE` comparisons with meta keys.
...
Previously introduced in [42768].
Fixes #42409 .
Built from https://develop.svn.wordpress.org/trunk@44518
git-svn-id: http://core.svn.wordpress.org/trunk@44349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 14:55:49 +00:00
Pascal Birchler
1224ebd0ac
Build/Test Tools: Update `.gitignore` to exclude `twentynineteen` and `twentysixteen`.
...
Brings the list of bundled themes in `.gitignore` up to date.
Fixes #45474 .
Built from https://develop.svn.wordpress.org/trunk@44517
git-svn-id: http://core.svn.wordpress.org/trunk@44348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 13:45:49 +00:00
Pascal Birchler
9bcdc25145
Build/Test Tools: Fix coding standards issues after [44515] and [44514].
...
See #44494 , #43743 .
Built from https://develop.svn.wordpress.org/trunk@44516
git-svn-id: http://core.svn.wordpress.org/trunk@44347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 12:37:49 +00:00
Pascal Birchler
8f5e0ae06c
Taxonomy: Display term list table in full width if there is no edit form.
...
Makes sure there is no empty space when a user can manage terms but lacks the capability to edit terms.
Props mathieuhays, marcwieland95.
Fixes #43743 .
Built from https://develop.svn.wordpress.org/trunk@44515
git-svn-id: http://core.svn.wordpress.org/trunk@44346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 12:05:50 +00:00
Pascal Birchler
a595f8a525
I18N: Add option to hide en_US locale in `wp_dropdown_languages()`.
...
Props danieltj for initial patch.
Fixes #44494 .
Built from https://develop.svn.wordpress.org/trunk@44514
git-svn-id: http://core.svn.wordpress.org/trunk@44345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 11:46:50 +00:00
Pascal Birchler
d32d061a5e
Upgrade/Install: Prevent possible JavaScript error when updating translations.
...
Props Presskopp.
Fixes #39189 .
Built from https://develop.svn.wordpress.org/trunk@44513
git-svn-id: http://core.svn.wordpress.org/trunk@44344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 11:26:50 +00:00
Gary Pendergast
f57b25f447
Tests: Revert [44509].
...
This commit causes Travis to fail.
See #45863 .
Built from https://develop.svn.wordpress.org/trunk@44512
git-svn-id: http://core.svn.wordpress.org/trunk@44343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 11:14:51 +00:00
Pascal Birchler
3b0b49f900
Embeds: Fix typo introduced in [44484].
...
Props JustinSainton.
Fixes #45036 .
Built from https://develop.svn.wordpress.org/trunk@44511
git-svn-id: http://core.svn.wordpress.org/trunk@44342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:54:51 +00:00
Gary Pendergast
f9208ac14e
Tests: Improve REST API tests for categories and tags.
...
Props birgire, SergeyBiryukov.
See #39122 .
Fixes #45077 .
Built from https://develop.svn.wordpress.org/trunk@44510
git-svn-id: http://core.svn.wordpress.org/trunk@44341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:31:51 +00:00
Gary Pendergast
0062616aa7
Build/Tests: Default to running unit tests from `src`.
...
This is the actual commit, unlike [44508], which was not.
Props atimmer.
See #44492 .
Fixes #45863 .
Built from https://develop.svn.wordpress.org/trunk@44509
git-svn-id: http://core.svn.wordpress.org/trunk@44340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:14:55 +00:00
Gary Pendergast
e0caaf7628
Build/Tests: Default to running unit tests from `src`.
...
This commit also defaults WP-CLI commands to running against `src`, too.
Props atimmer, pento.
See #44492 .
Fixes #45863 .
Built from https://develop.svn.wordpress.org/trunk@44508
git-svn-id: http://core.svn.wordpress.org/trunk@44339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:10:51 +00:00
Dominik Schilling
6503f77539
Build/Tools: Fix typo in `phpcs.xml.dist`.
...
See #44366 .
Built from https://develop.svn.wordpress.org/trunk@44507
git-svn-id: http://core.svn.wordpress.org/trunk@44338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:02:53 +00:00
Gary Pendergast
9f25ea37c7
Filesystem: Improve `wp_is_stream()` performance.
...
Instead of turning the return value of `stream_get_wrappers()` into a regex to match the scheme, we can instead extract the scheme and search the return value of `stream_get_wrappers()`.
Props schlessera, swissspidy.
Fixes #45553 .
Built from https://develop.svn.wordpress.org/trunk@44506
git-svn-id: http://core.svn.wordpress.org/trunk@44337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 09:51:54 +00:00
Peter Wilson
184c501d5c
Cron: Fix undefined variable notice.
...
Restore `$gmt_time` variable removed in error from [44483].
Props afragen.
Fixes #45870 .
Built from https://develop.svn.wordpress.org/trunk@44505
git-svn-id: http://core.svn.wordpress.org/trunk@44336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 08:37:51 +00:00
Gary Pendergast
f88769fc3b
Block Editor: Obey the `AUTOSAVE_INTERVAL` constant.
...
Props youknowriad.
Fixes #45262 .
Built from https://develop.svn.wordpress.org/trunk@44504
git-svn-id: http://core.svn.wordpress.org/trunk@44335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:54:49 +00:00
Gary Pendergast
68f2d8f0af
Docs: Correct the documentation for `wp_list_authors()`.
...
The `exclude_admin` argument defaults to `true`, not `false`.
Props haruharuharuby.
Fixes #45120 .
Built from https://develop.svn.wordpress.org/trunk@44503
git-svn-id: http://core.svn.wordpress.org/trunk@44334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:52:50 +00:00
Gary Pendergast
21ff86cf43
Comments: Add new tests missed in [44499].
...
Props dshanske, birgire.
Fixes #44033 .
Built from https://develop.svn.wordpress.org/trunk@44502
git-svn-id: http://core.svn.wordpress.org/trunk@44333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:20:50 +00:00
Gary Pendergast
f9d879905d
Docs: Document the `$page_hook` action.
...
Props johnbillion.
Fixes #43643 .
Built from https://develop.svn.wordpress.org/trunk@44501
git-svn-id: http://core.svn.wordpress.org/trunk@44332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:14:51 +00:00
Gary Pendergast
be127956e0
Bundled Themes: Run the `pingback_url` through `esc_url()`.
...
Twenties Ten through Seventeen have been updated to properly escape the pingback URL. Twenty Nineteen is already escaping the URL.
Props soulseekah, sharaz.
Fixes #43717 .
Built from https://develop.svn.wordpress.org/trunk@44500
git-svn-id: http://core.svn.wordpress.org/trunk@44331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:11:51 +00:00
Gary Pendergast
eeac928d3b
Comments: Add a new `is_avatar_comment_type()` function.
...
This function splits the `get_avatar_comment_types` filter out of `get_avatar_data()`.
Props dshanske, birgire.
Fixes #44033 .
Built from https://develop.svn.wordpress.org/trunk@44499
git-svn-id: http://core.svn.wordpress.org/trunk@44330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:00:51 +00:00
Gary Pendergast
05c1030151
Docs: Add docblocks to the members of `WP_Widget_Form_Customize_Control`.
...
Props subrataemfluence.
Fixes #44420 .
Built from https://develop.svn.wordpress.org/trunk@44498
git-svn-id: http://core.svn.wordpress.org/trunk@44329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:49:49 +00:00
Gary Pendergast
61dce1d422
Docs: Add docblocks for the PHPUnit factory objects.
...
Props andizer.
Fixes #44521 .
Built from https://develop.svn.wordpress.org/trunk@44497
git-svn-id: http://core.svn.wordpress.org/trunk@44328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:44:49 +00:00
Gary Pendergast
a583725622
Docs: Update Codex references to the `Template_Hierarchy` page.
...
https://codex.wordpress.org/Template_Hierarchy redirects to https://developer.wordpress.org/themes/basics/template-hierarchy/ , so we should link to the correct page.
Props kmeze, pento.
Fixes #45222 .
Built from https://develop.svn.wordpress.org/trunk@44496
git-svn-id: http://core.svn.wordpress.org/trunk@44327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:09:51 +00:00
Gary Pendergast
e357f68667
Docs: Add `@see WP_Session_Tokens` to the `WP_User_Meta_Session_Tokens` docblock.
...
Props utsav72640.
Fixes #45499 .
Built from https://develop.svn.wordpress.org/trunk@44495
git-svn-id: http://core.svn.wordpress.org/trunk@44326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:04:50 +00:00
Gary Pendergast
0b44fae46b
Privacy: Fix a code formatting error introduced in [44491].
...
See #44908 .
Built from https://develop.svn.wordpress.org/trunk@44494
git-svn-id: http://core.svn.wordpress.org/trunk@44325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 04:33:50 +00:00
Gary Pendergast
47e29ccba9
Privacy: Tweak the wording of the success notice when updating the privacy policy page setting.
...
Props garrett-eclipse.
Fixes #44129 .
Built from https://develop.svn.wordpress.org/trunk@44493
git-svn-id: http://core.svn.wordpress.org/trunk@44324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 04:19:49 +00:00
Gary Pendergast
099238e3a3
Privacy: Always show the privacy policy guide.
...
Previously, the link to the privacy policy guide would only be displayed when a privacy policy page had been selected, but the guide is generally useful without that.
Props mukesh27, birgire.
Fixes #44871 .
Built from https://develop.svn.wordpress.org/trunk@44492
git-svn-id: http://core.svn.wordpress.org/trunk@44323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 04:01:50 +00:00
Gary Pendergast
53e40b7fda
Privacy: Remove some unnecessary parameters being passed to `wp_update_post()` by `wp_generate_user_request_key()`.
...
Props garrett-eclipse.
Fixes #44908 .
Built from https://develop.svn.wordpress.org/trunk@44491
git-svn-id: http://core.svn.wordpress.org/trunk@44322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 03:51:48 +00:00
Gary Pendergast
f7d21862e8
Help/About: Add a `lang` attribute to the `<html>` tag in `readme.html`
...
Props audrasjb.
Fixes #44955 .
Built from https://develop.svn.wordpress.org/trunk@44490
git-svn-id: http://core.svn.wordpress.org/trunk@44321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 02:56:51 +00:00
Gary Pendergast
19f9dd29e9
Login: Improve the error message when retrieving a lost password.
...
When an invalid username or email address is entered, the form now displays a better error message.
Props mrtortai, iamfriendly, TomHarrigan, afercia, pento.
Fixes #31788 .
Built from https://develop.svn.wordpress.org/trunk@44489
git-svn-id: http://core.svn.wordpress.org/trunk@44320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 02:06:50 +00:00