1bcda42567
Media: Add an `image_sideload_extensions` filter to the list of allowed file extensions when sideloading an image from a URL.
...
Props paulschreiber, hellofromTonya
Fixes #50695
Built from https://develop.svn.wordpress.org/trunk@49198
git-svn-id: http://core.svn.wordpress.org/trunk@48960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-18 21:06:05 +00:00
727922c8eb
Docs: Further corrections and promotions for docblocks relating to `object` types.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@49197
git-svn-id: http://core.svn.wordpress.org/trunk@48959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-18 20:53:08 +00:00
b2515abd45
Docs: Improve the docs for the globals that are used in the actions and filters API.
...
See #50531 , #50768
Built from https://develop.svn.wordpress.org/trunk@49196
git-svn-id: http://core.svn.wordpress.org/trunk@48958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-18 19:19:06 +00:00
1faa241fb6
Code Modernization: Use `instanceof` instead of a comparison with `get_class()`.
...
Includes adjusting external libraries which are no longer maintained externally.
Props jrf.
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@49194
git-svn-id: http://core.svn.wordpress.org/trunk@48956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-18 17:33:07 +00:00
0e3147c40e
Coding Standards: Replace alias PHP functions with the canonical names.
...
Using the canonical function name for PHP functions is strongly recommended, as aliases may be deprecated or removed without (much) warning.
This replaces all uses of the following:
* `join()` with `implode()`
* `sizeof()` with `count()`
* `is_writeable()` with `is_writable()`
* `doubleval()` with a `(float)` cast
In part, this is a follow-up to #47746 .
Props jrf.
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@49193
git-svn-id: http://core.svn.wordpress.org/trunk@48955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-18 17:27:06 +00:00
b6f0882ddd
Coding Standards: Use `self` when appropriate.
...
* `WP_List_Table::get_default_primary_column_name()` is a protected method, so calling it statically with the class name is bad practice.
* Similarly, this applies when calling a private constructor in `WP_Screen::get()`.
Props jrf.
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@49192
git-svn-id: http://core.svn.wordpress.org/trunk@48954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-18 17:18:07 +00:00
a01f94cad8
Administration: Allow `WP_List_Table::get_bulk_items()` to receive a nested array in order to output optgroups.
...
The allowed format for bulk actions is now an associative array where each element represents either a top level option value and label, or an array representing an optgroup and its options.
For a standard option, the array element key is the field value and the array element value is the field label.
For an optgroup, the array element key is the label and the array element value is an associative array of options as above.
Props goldenapples, mattkeys, valentinbora, davidbaumwald
Fixes #19278
Built from https://develop.svn.wordpress.org/trunk@49190
git-svn-id: http://core.svn.wordpress.org/trunk@48952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-18 16:22:10 +00:00
c16ae60deb
Docs: Fix and upgrade various `object` docblock notations.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@49183
git-svn-id: http://core.svn.wordpress.org/trunk@48945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-17 16:05:09 +00:00
5a573f28f2
Docs: Miscellaneous docblock fixes.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@49181
git-svn-id: http://core.svn.wordpress.org/trunk@48943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-17 14:54:05 +00:00
59c45c41e4
Fix and improve arranging of postboxes/metaboxes:
...
- Enable arranging only when the Screen Options tab is open.
- Prevent accidental/unintended dragging. Seen it happen mostly on laptops when using the mousepad/trackpad.
- Improve discoverability and usefulness by always showing the "drop zones" outline when postboxes are draggable/arrangeable.
- Add some (brief) explanation to the Screen Options tab helping the user understand what options are available and how to change them. This is especially helpful for screen reader users to give an idea how to use the screen options and what to expect.
- Fix/enhance some of the code in `postbox.js` and make it coding standards compliant.
See #50699 .
Built from https://develop.svn.wordpress.org/trunk@49179
git-svn-id: http://core.svn.wordpress.org/trunk@48941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-17 10:00:06 +00:00
32d193f96f
REST API, Posts: Add a hook to fire once a post, its terms and meta update.
...
Introduces the action `wp_after_insert_post` inside a wrapper function of the same name. This hook allows plugin developers to access a posts full data (including its terms and meta data) regardless of the workflow used to save it.
A new parameter is introduced to `wp_insert_post()` to indicate whether the hook should be fired within the function call or will be fired afterward.
Props aristath, Collizo4sky, danielbachhuber, joyously, kadamwhite, kraftbj, markparnell, mikeschroder, noisysocks, peterwilsoncc, SergeyBiryukov, talldanwp, thewebprincess, TimothyBlynJacobs.
Fixes #45114 .
Built from https://develop.svn.wordpress.org/trunk@49172
git-svn-id: http://core.svn.wordpress.org/trunk@48934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-16 03:34:08 +00:00
df51aa9b6f
Upgrade/Install: Check if plugin or theme update results are available before applying the notification filters.
...
This avoids a PHP notice for an undefined index of either `plugin` or `theme` in the `auto_{plugin|theme}_update_send_email` filter hook.
Props afragen, audrasjb.
Fixes #51400 .
Built from https://develop.svn.wordpress.org/trunk@49166
git-svn-id: http://core.svn.wordpress.org/trunk@48928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-15 23:27:03 +00:00
039ce3f16f
Site Health, REST API: Move async tests to REST API endpoints.
...
This provides more flexibility when writing tests and benefits from running in a front-end context which is necessary for some tests like checking that updates are supported. Additionally, this provides a more robust interface for developers who want to integrate with Site Health tests.
Because the `wp/v2` endpoint is reserved for modeling core entities, site health is registered in its own `wp-site-health/v1` namespace.
The existing ajax actions have been maintained for backward compatibility.
Props Clorith, chrisvanpatten, afragen, pokhriyal, TimothyBlynJacobs.
Fixes #48105 .
Built from https://develop.svn.wordpress.org/trunk@49154
git-svn-id: http://core.svn.wordpress.org/trunk@48916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-15 02:00:08 +00:00
8d2beacd45
Community Events: Update timezone-related `@since` tags to `5.5.2`.
...
r49145 and r49146 were originally planned for 5.6 when they were committed, but are now planned for 5.5.2.
See #51130 .
Built from https://develop.svn.wordpress.org/trunk@49152
git-svn-id: http://core.svn.wordpress.org/trunk@48914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-14 21:35:05 +00:00
5bf0005827
Community Events: Display dates and times in the user's time zone.
...
Fixes #51130
Props sippis, hlashbrooke, audrasjb, Rarst, iandunn
Built from https://develop.svn.wordpress.org/trunk@49146
git-svn-id: http://core.svn.wordpress.org/trunk@48908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-14 18:21:06 +00:00
5d42748c18
Community Events: Trim events by Unix timestamp for accuracy.
...
The `date` and `end_date` fields are ''WP'' timestamps representing the venue's local time. As of meta:changeset:10270 (#meta4480), new `start_unix_timestamp` and `end_unix_timestamp` values are available, providing a proper ''Unix'' timestamp in the UTC timezone. Using those is more precise, and removes the time window where the event has expired but still appears in the Events Widget.
To simplify the function, it now only accepts and returns the events themselves, rather than the entire response body.
See #51130
See #meta4480
Related: https://make.wordpress.org/core/2019/09/23/date-time-improvements-wp-5-3/
Built from https://develop.svn.wordpress.org/trunk@49145
git-svn-id: http://core.svn.wordpress.org/trunk@48907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-14 18:19:10 +00:00
7137daec42
Administration: Restore alternative admin menu position for menu items with the same position value as an existing menu item.
...
Reverts parts of [49108].
Props johnjamesjacoby.
Fixes #42918 .
Built from https://develop.svn.wordpress.org/trunk@49138
git-svn-id: http://core.svn.wordpress.org/trunk@48900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-13 19:59:08 +00:00
da04189357
Administration: Allow context and priority to be specified when adding dashboard widgets.
...
Props davidjlaietta, soulseekah, johnbillion
Fixes #42791
Built from https://develop.svn.wordpress.org/trunk@49123
git-svn-id: http://core.svn.wordpress.org/trunk@48885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-10 20:40:05 +00:00
cdd8b2cbfa
Site Health: Remove an unused function that was erroneously added when the site health feature was introduced.
...
This function was and is never used as the `is_in_debug_mode` check is a direct one.
Fixes #50282
Built from https://develop.svn.wordpress.org/trunk@49122
git-svn-id: http://core.svn.wordpress.org/trunk@48884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-10 20:24:03 +00:00
905460bd5e
Docs: Standardise the type name for booleans and integers.
...
This brings these docs inline with the documentation standards.
Props ravipatel, justinahinon
Fixes #51426
Built from https://develop.svn.wordpress.org/trunk@49120
git-svn-id: http://core.svn.wordpress.org/trunk@48882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-10 20:02:05 +00:00
6b7ba33d68
Docs: Fix the types for some properties and parameters that use the generic `object` type.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@49119
git-svn-id: http://core.svn.wordpress.org/trunk@48881 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-10 19:14:04 +00:00
e3d280ffd8
Users: prevent saving empty passwords, trim space from password ends on save.
...
Fix an issue where users could save a password with only spaces, or spaces at the beginning or end of their password, preventing them from logging in.
Props ronakganatra, 1naveengiri, ajensen, oolleegg55, bookdude13, nrqsnchz, aristath.
Fixes #42766 .
Built from https://develop.svn.wordpress.org/trunk@49118
git-svn-id: http://core.svn.wordpress.org/trunk@48880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-10 16:51:07 +00:00
92dacfafaf
Dashboard: Show `2` w.org news items to preserve clustered posts.
...
These days there are often 2 posts published close to each other, like a release announcement and a Month In WordPress post. When that happens, the earlier post is often pushed out of the widget before many people have had a chance to see it.
Ideally, the number of total items would remain at `4`, to reduce visual clutter. Implementing a conditional item would require a significant refactor, though. Increasing the total number of items to `5` is a practical compromise.
Props hlashbrooke, tellyworth.
Fixes #43441 .
Built from https://develop.svn.wordpress.org/trunk@49114
git-svn-id: http://core.svn.wordpress.org/trunk@48876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-09 16:07:07 +00:00
c628344422
Accessibility: Widgets: Add a "Cancel" link when editing a widget in accessibility mode.
...
This allows the user to go back without saving any changes to the widget.
Props garrett-eclipse, audrasjb, afercia.
Fixes #49354 .
Built from https://develop.svn.wordpress.org/trunk@49113
git-svn-id: http://core.svn.wordpress.org/trunk@48875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-09 15:53:08 +00:00
d5ebe12f11
REST API: Introduce Application Passwords for API authentication.
...
In WordPress 4.4 the REST API was first introduced. A few releases later in WordPress 4.7, the Content API endpoints were added, paving the way for Gutenberg and countless in-site experiences. In the intervening years, numerous plugins have built on top of the REST API. Many developers shared a common frustration, the lack of external authentication to the REST API.
This commit introduces Application Passwords to allow users to connect to external applications to their WordPress website. Users can generate individual passwords for each application, allowing for easy revocation and activity monitoring. An authorization flow is introduced to make the connection flow simple for users and application developers.
Application Passwords uses Basic Authentication, and by default is only available over an SSL connection.
Props georgestephanis, kasparsd, timothyblynjacobs, afercia, akkspro, andraganescu, arippberger, aristath, austyfrosty, ayesh, batmoo, bradyvercher, brianhenryie, helen, ipstenu, jeffmatson, jeffpaul, joostdevalk, joshlevinson, kadamwhite, kjbenk, koke, michael-arestad, Otto42, pekz0r, salzano, spacedmonkey, valendesigns.
Fixes #42790 .
Built from https://develop.svn.wordpress.org/trunk@49109
git-svn-id: http://core.svn.wordpress.org/trunk@48871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-08 22:14:06 +00:00
897f004a9c
General: Replace older-style PHP type conversion functions with type casts.
...
This improves performance, readability, and consistency throughout core.
* `intval()` → `(int)`
* `strval()` → `(string)`
* `floatval()` → `(float)`
Props ayeshrajans.
Fixes #42918 .
Built from https://develop.svn.wordpress.org/trunk@49108
git-svn-id: http://core.svn.wordpress.org/trunk@48870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-08 21:15:13 +00:00
aef2b539cd
Docs: Correct `@since` version for `add_allowed_options()`.
...
Follow-up to [48121].
Props coffee2code.
Fixes #51450 .
Built from https://develop.svn.wordpress.org/trunk@49096
git-svn-id: http://core.svn.wordpress.org/trunk@48858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-06 15:55:05 +00:00
bea55db921
Docs: Add missing `@return` tag to `Language_Pack_Upgrader::check_package()`.
...
Synchronize documentation of the `::check_package()` method between `Plugin_Upgrader`, `Theme_Upgrader`, and `Language_Pack_Upgrader`.
Props ankitmaru, mukesh27, desrosj.
Fixes #51448 .
Built from https://develop.svn.wordpress.org/trunk@49091
git-svn-id: http://core.svn.wordpress.org/trunk@48853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-05 13:44:11 +00:00
1651342d2b
Privacy: Improve clarity of privacy error strings.
...
Primarily this adds "user privacy" to the strings for privacy requests, so they are more easily distinguished from other system actions within logs.
Props garrett-eclipse, carike, birgire.
Fixes #51351 .
Built from https://develop.svn.wordpress.org/trunk@49090
git-svn-id: http://core.svn.wordpress.org/trunk@48852 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-10-04 03:23:09 +00:00
b3b8942dfc
Docs: Correct description for `wp_ajax_update_widget()`.
...
Follow-up to [28355].
Props burhandodhy, sabernhardt.
Fixes #44583 .
Built from https://develop.svn.wordpress.org/trunk@49071
git-svn-id: http://core.svn.wordpress.org/trunk@48833 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-30 09:44:09 +00:00
2cbcc5d548
Media: Make the "Copy URL" button implementation more consistent with other instances in core:
...
* Make the "Copied!" text green.
* Make the button verbiage clear that it's copied "to clipboard".
Props garrett-eclipse, mukesh27.
Fixes #51355 .
Built from https://develop.svn.wordpress.org/trunk@49064
git-svn-id: http://core.svn.wordpress.org/trunk@48826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 20:48:05 +00:00
c298458751
Docs: Add missing `@return` tags for some `WP_Automatic_Updater` methods:
...
* `::is_vcs_checkout()`
* `::should_update()`
* `::send_core_update_notification_email()`
Props ankitmaru, mukesh27.
Fixes #51385 .
Built from https://develop.svn.wordpress.org/trunk@49061
git-svn-id: http://core.svn.wordpress.org/trunk@48823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-27 08:36:06 +00:00
eaf325e386
Upgrade/Install: Introduce the `wp_installed_email` filter for filtering the contents of the email sent when WordPress is installed, without needing to override the `wp_new_blog_notification()` pluggable function.
...
Props Dharm1025, nikolam, johnbillion
Fixes #42133
Built from https://develop.svn.wordpress.org/trunk@49048
git-svn-id: http://core.svn.wordpress.org/trunk@48810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-25 22:33:08 +00:00
a16faa6989
Privacy: Ensure bulk action related strings end with periods.
...
Props garrett-eclipse, mukesh27.
Fixes #51371 .
Built from https://develop.svn.wordpress.org/trunk@49035
git-svn-id: http://core.svn.wordpress.org/trunk@48797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-22 18:40:04 +00:00
aef504acfd
Docs: Correct the indentation for some array type docs.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@49028
git-svn-id: http://core.svn.wordpress.org/trunk@48790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-21 16:46:06 +00:00
29c0edfbba
Privacy: Check if the accumulated data in `wp_privacy_process_personal_data_export_page()` is not empty.
...
This avoids an error on PHP 8 caused by passing an empty string to `array_merge()`, instead of an array.
See #50913 .
Built from https://develop.svn.wordpress.org/trunk@49026
git-svn-id: http://core.svn.wordpress.org/trunk@48788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-21 13:51:03 +00:00
aba2165aae
Media: Standardise the description for image size parameters.
...
This brings continuity to all the image related functions and filters which accept or pass a size parameter.
Props dilipbheda, johnbillion
Fixes #47364
Built from https://develop.svn.wordpress.org/trunk@49021
git-svn-id: http://core.svn.wordpress.org/trunk@48783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-20 16:23:07 +00:00
0b2e31a7f8
Docs: Inline documentation improvements for media related functions and hooks.
...
See #47364 , #50768
Built from https://develop.svn.wordpress.org/trunk@49020
git-svn-id: http://core.svn.wordpress.org/trunk@48782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-20 15:55:10 +00:00
43b11121de
Media: Correct some types for attachment ID parameters passed to functions and filters.
...
See #47364 , #50768
Built from https://develop.svn.wordpress.org/trunk@49017
git-svn-id: http://core.svn.wordpress.org/trunk@48779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-20 14:05:05 +00:00
123806ff28
Themes: Remove the ability to delete themes from the single site Appearance screen on Multisite installations.
...
This brings theme deletion inline with plugin deletion and theme and plugin editing, which can only be performed from within Network Admin.
Props Mista-Flo, williampatton, johnbillion
Fixes #41441
Built from https://develop.svn.wordpress.org/trunk@49011
git-svn-id: http://core.svn.wordpress.org/trunk@48773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-20 12:03:05 +00:00
d5b8d282e8
Docs: Update the URL for PHP date formats table in translator comments.
...
Props hareesh-pillai, iandunn.
Fixes #51332 .
Built from https://develop.svn.wordpress.org/trunk@48991
git-svn-id: http://core.svn.wordpress.org/trunk@48753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-18 10:37:08 +00:00
282c813259
Coding Standards: Explicitly declare the `$wp_version` global used in some core files.
...
Props jaydeep-rami, sabernhardt.
Fixes #44932 .
Built from https://develop.svn.wordpress.org/trunk@48971
git-svn-id: http://core.svn.wordpress.org/trunk@48733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-12 00:12:08 +00:00
f29d62012d
Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-plugin-install-list-table.php`.
...
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@48970
git-svn-id: http://core.svn.wordpress.org/trunk@48732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-11 01:05:08 +00:00
e36c7f0ba0
Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-plugins-list-table.php`.
...
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@48968
git-svn-id: http://core.svn.wordpress.org/trunk@48730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-10 14:23:08 +00:00
7dada5df2f
Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-ms-themes-list-table.php`.
...
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@48967
git-svn-id: http://core.svn.wordpress.org/trunk@48729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-10 14:21:09 +00:00
93b8183327
Media: In `wp_ajax_image_editor()`, check if the `error` property exists before accessing it.
...
This avoids a PHP notice when editing an image.
Follow-up to [48375].
Props Mista-Flo.
Fixes #51251 .
Built from https://develop.svn.wordpress.org/trunk@48946
git-svn-id: http://core.svn.wordpress.org/trunk@48708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-05 18:12:08 +00:00
e05edbcd53
Comments: Rename `WP_Comments_List_Table::comment_status_dropdown()` to `::comment_type_dropdown()`.
...
This better reflects the purpose of the method, which doesn't have anything to do with a comment status.
Follow-up to [48521].
Props davidbaumwald, johnbillion, SergeyBiryukov.
Fixes #51248 .
Built from https://develop.svn.wordpress.org/trunk@48943
git-svn-id: http://core.svn.wordpress.org/trunk@48705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-05 00:33:05 +00:00
d0a32c5111
Docs: Various docblock corrections and improvements.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@48941
git-svn-id: http://core.svn.wordpress.org/trunk@48703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-04 20:41:07 +00:00
d4d3e23ad0
Themes: Normalize the installed theme path in `Theme_Installer_Skin::do_overwrite()` before comparing with the uploaded theme.
...
This ensures that the data for the currently installed theme is picked up properly when uploading a theme update on Windows.
Follow-up to [48390].
Props bobbingwide, wpamitkumar, mukesh27.
Fixes #51182 .
Built from https://develop.svn.wordpress.org/trunk@48913
git-svn-id: http://core.svn.wordpress.org/trunk@48675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-31 17:11:04 +00:00
ee33a7b019
Docs: Add a `@since` note to the `display_post_states` filter to clarify that it is now also applied in the Customizer context.
...
If any admin functions are used within the filter, their existence should be checked with `function_exists()` before being used.
Follow-up to [47763], [48620].
Props audrasjb, garrett-eclipse, Howdy_McGee, dlh, khag7, SergeyBiryukov.
Fixes #51081 .
Built from https://develop.svn.wordpress.org/trunk@48910
git-svn-id: http://core.svn.wordpress.org/trunk@48672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-31 13:32:04 +00:00
94555079eb
Docs: Clarify the usage of `null` for `auto_update_{$type}` filter.
...
The value is internally used to detect whether nothing has hooked into this filter.
Props audrasjb, pbiron, johnbillion, SergeyBiryukov.
Fixes #50848 .
Built from https://develop.svn.wordpress.org/trunk@48909
git-svn-id: http://core.svn.wordpress.org/trunk@48671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-31 13:20:07 +00:00
af523447f4
Media: Make the `is_gd_image()` function available on front end.
...
This avoids a fatal error if a plugin calls image creation or editing functions like `wp_imagecreatetruecolor()` outside of the admin.
Follow-up to [48798]
Props BackuPs.
Fixes #51174 . See #50833 .
Built from https://develop.svn.wordpress.org/trunk@48905
git-svn-id: http://core.svn.wordpress.org/trunk@48667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-28 16:45:06 +00:00
71ffaac835
Docs: Correct formatting of the `auto_theme_update_send_email` filter DocBlock.
...
Synchronize description of the `$enabled` parameter with the `auto_plugin_update_send_email` filter.
Follow-up to [48889].
See #50768 , #50988 .
Built from https://develop.svn.wordpress.org/trunk@48903
git-svn-id: http://core.svn.wordpress.org/trunk@48665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-28 02:38:05 +00:00
308f752596
Upgrade/Install: Only display the auto-update links on the Network Admin > Themes screen for themes that support the feature.
...
Follow-up to [48669], [48688].
Props afragen, pbiron, audrasjb, desrosj, SergeyBiryukov.
Fixes #51129 .
Built from https://develop.svn.wordpress.org/trunk@48899
git-svn-id: http://core.svn.wordpress.org/trunk@48661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 22:24:07 +00:00
2aba7550c4
Upgrade/Install: Pass details about the specific plugin and theme updates attempted to filters.
...
This adds an additional parameter to the `auto_plugin_update_send_email` and `auto_theme_update_send_email` filters to provide the additional context of which updates were attempted and their outcome. This will help plugin and theme auto-update emails to be better tailored to a site owner’s liking.
Props audrasjb, Paddy Landau, desrosj.
Fixes #50988 .
Built from https://develop.svn.wordpress.org/trunk@48888
git-svn-id: http://core.svn.wordpress.org/trunk@48650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 19:27:03 +00:00
604b273c0f
Taxonomy: Make sure `wp_terms_checklist()` and `Walker_Category_Checklist::start_el()` properly handle an array of strings as `selected_cats` or `popular_cats` values.
...
Even with these values documented as an array of integers, they can technically also accept an array of strings, e.g. as form results.
Add a unit test.
Props brianhogg, TimothyBlynJacobs, SergeyBiryukov.
Fixes #51137 .
Built from https://develop.svn.wordpress.org/trunk@48880
git-svn-id: http://core.svn.wordpress.org/trunk@48642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-27 02:48:06 +00:00
aa803be1ec
Upgrade/Install: Make the check for empty `home` option in `__get_option()` more resilient.
...
This addresses a regression in [47808], where the `home` check expected an empty string to use `siteurl` as a fallback, but `wpdb::get_var()` returns `null` if the option is empty.
Props fjarrett.
Fixes #51011 .
Built from https://develop.svn.wordpress.org/trunk@48868
git-svn-id: http://core.svn.wordpress.org/trunk@48630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 16:57:16 +00:00
9700ca0f55
Quick/Bulk Edit: Revert [48134] to address the bottom "Bulk actions" dropdown not functioning properly on Posts and Users list tables.
...
A better solution for the original issue will be explored in a future release.
Props audrasjb, garrett-eclipse, webzunft, Krstarica, chunkysteveo, SergeyBiryukov.
Fixes #50882 , #50998 . See #46872 .
Built from https://develop.svn.wordpress.org/trunk@48866
git-svn-id: http://core.svn.wordpress.org/trunk@48628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-26 14:18:04 +00:00
5918f7e11d
Taxonomy: Allow for `wp_count_terms( $args )` signature, making passing a taxonomy optional.
...
This brings `wp_count_terms()` in line with other taxonomy functions such as `get_terms()` which technically no longer require a taxonomy. Similar to the previously modified functions, no deprecation warning is triggered when using the legacy signature.
Fixes #36399 .
Built from https://develop.svn.wordpress.org/trunk@48840
git-svn-id: http://core.svn.wordpress.org/trunk@48602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-21 22:32:06 +00:00
0c0e39d8bf
Privacy: Avoid a PHP 7.4 notice in `WP_Privacy_Policy_Content::text_change_check()`.
...
When iterating over the items stored in '_wp_suggested_privacy_policy_content` meta value for the Privacy Policy page, make sure the item is an array before accessing its properties.
Props treibstoff.
Fixes #51084 .
Built from https://develop.svn.wordpress.org/trunk@48836
git-svn-id: http://core.svn.wordpress.org/trunk@48598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-21 01:13:05 +00:00
25b0783629
Docs: Correct references to `WP_Filesystem_Base` methods in various DocBlocks.
...
Props pbiron.
Fixes #51087 .
Built from https://develop.svn.wordpress.org/trunk@48835
git-svn-id: http://core.svn.wordpress.org/trunk@48597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-21 00:43:05 +00:00
c66d70f2a5
Comments: Revert unintended changes from [48822].
...
See #51044 .
Built from https://develop.svn.wordpress.org/trunk@48823
git-svn-id: http://core.svn.wordpress.org/trunk@48585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-19 01:59:04 +00:00
3e16f7510a
Comments: Make sure the comment data passed to the `preprocess_comment` filter includes the `comment_agent` and `comment_author_IP` values.
...
Props zodiac1978, SergeyBiryukov.
Fixes #51044 .
Built from https://develop.svn.wordpress.org/trunk@48822
git-svn-id: http://core.svn.wordpress.org/trunk@48584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-19 01:57:08 +00:00
8b3a813e1a
Plugins: Avoid a PHP notice if the `update-supported` key in plugin data is not set.
...
Props sanzeeb3.
Fixes #51052 .
Built from https://develop.svn.wordpress.org/trunk@48820
git-svn-id: http://core.svn.wordpress.org/trunk@48582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-18 20:38:09 +00:00
e50ac120a3
Site Health: Ensure that the tests returned by `WP_Site_Health::get_tests()` always have the required array keys: `direct` and `async`.
...
This avoids PHP notices if these keys were accidentally removed using the `site_status_tests` filter.
Props khag7, Ov3rfly, desrosj, Clorith.
Fixes #50858 .
Built from https://develop.svn.wordpress.org/trunk@48808
git-svn-id: http://core.svn.wordpress.org/trunk@48570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-17 02:03:04 +00:00
d9135ad9d0
Site Health: Add site environment type to the debug information.
...
Follow-up to [47919], [48188], [48372].
Props joostdevalk, Clorith.
Fixes #50887 .
Built from https://develop.svn.wordpress.org/trunk@48802
git-svn-id: http://core.svn.wordpress.org/trunk@48564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-16 18:27:04 +00:00
7cb2ca73a2
Site Health: Rename the `$upload_max_size` variable to `$upload_max_filesize`, for consistency with the PHP setting name.
...
Follow-up to [48535], [48538], [48539], [48544], [48800].
See #50945 .
Built from https://develop.svn.wordpress.org/trunk@48801
git-svn-id: http://core.svn.wordpress.org/trunk@48563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-16 17:54:05 +00:00
88e668d8e6
Site Health: Only display the warning about the `post_max_size` PHP value when it's lower than `upload_max_filesize`.
...
Previously, the warning was displayed even if the value was higher than `upload_max_filesize`, which made the report inaccurate, as these values don't necessarily have to match.
Props oakesjosh, jeroenrotty, desrosj, Clorith.
Fixes #50945 .
Built from https://develop.svn.wordpress.org/trunk@48800
git-svn-id: http://core.svn.wordpress.org/trunk@48562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-16 17:48:08 +00:00
54184bf872
Docs: Fix typo in the `$image` parameter description in `is_gd_image()`.
...
Follow-up to [48798].
See #50833 .
Built from https://develop.svn.wordpress.org/trunk@48799
git-svn-id: http://core.svn.wordpress.org/trunk@48561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-16 14:02:03 +00:00
12c8f0e678
Code Modernization: Introduce `is_gd_image()` to check for PHP 8 `GdImage` object instances.
...
In PHP 8, the GD extension uses `GdImage` objects instead of resources for its underlying data structures.
This updates the existing `is_resource()` calls for image resources in core to accomodate for `GdImage` instances as well.
Props ayeshrajans, jrf.
Fixes #50833 .
Built from https://develop.svn.wordpress.org/trunk@48798
git-svn-id: http://core.svn.wordpress.org/trunk@48560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-16 13:33:09 +00:00
a5edb2a8a1
Filesystem API: Use correct variable when closing the file handle in `WP_Filesystem_FTPext::get_contents()`.
...
Props gothick@gothick.org.uk .
Fixes #51029 .
Built from https://develop.svn.wordpress.org/trunk@48797
git-svn-id: http://core.svn.wordpress.org/trunk@48559 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-15 20:56:02 +00:00
440eb31bb7
Site Health: Recognize `define( 'WP_AUTO_UPDATE_CORE', 'minor' )` as an acceptable value.
...
Previously, it was only incidentally recognized as valid due to a loose comparison with `true`.
With the strict comparison added to `WP_Site_Health_Auto_Updates::test_constants()`, this was no longer the case.
Follow-up to [47841].
Props sterndata, mukesh27, avixansa, desrosj, SergeyBiryukov.
Fixes #50912 .
Built from https://develop.svn.wordpress.org/trunk@48792
git-svn-id: http://core.svn.wordpress.org/trunk@48554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-14 20:39:08 +00:00
1f85e7484f
Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@48782
git-svn-id: http://core.svn.wordpress.org/trunk@48544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 00:34:08 +00:00
5c0361aeb1
Coding Standards: Remove a few more extra brackets from some conditions in `wp-admin/includes/plugin.php`.
...
Follow-up to [48764].
See #50767 .
Built from https://develop.svn.wordpress.org/trunk@48766
git-svn-id: http://core.svn.wordpress.org/trunk@48528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-09 01:56:05 +00:00
004e3f897f
Coding Standards: Fix WPCS issues in `wp-admin/includes/plugin.php`.
...
Includes minor code layout fixes for better readability.
Props rnaby for initial patch.
See #50767 , #43848 .
Built from https://develop.svn.wordpress.org/trunk@48764
git-svn-id: http://core.svn.wordpress.org/trunk@48526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-08 21:04:04 +00:00
f5a4ac614e
Coding Standards: Simplify some parts of `user_can_access_admin_page()` for better readability.
...
Props rnaby, valentinbora, khag7.
Fixes #43848 .
Built from https://develop.svn.wordpress.org/trunk@48762
git-svn-id: http://core.svn.wordpress.org/trunk@48524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-08 20:24:05 +00:00
132942b9fa
Docs: Document the return value of `get_settings_errors()` using hash notation.
...
Props stevenlinx, webdevmattcrom, atachibana.
Fixes #42786 .
Built from https://develop.svn.wordpress.org/trunk@48760
git-svn-id: http://core.svn.wordpress.org/trunk@48522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-08 12:39:06 +00:00
961f455a00
Comments: Update DB version number used to trigger the upgrade routine for changing the `comment_type` DB field value in comments table.
...
Follow-up to [47597], [47626], [48225], [48227], [48748].
Props desrosj.
See #49236 .
Built from https://develop.svn.wordpress.org/trunk@48751
git-svn-id: http://core.svn.wordpress.org/trunk@48513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 16:32:03 +00:00
6b5e748dee
Docs: Correct usage of the dynamic `auto_update_{$type}` filter.
...
This ensures that the canonical name of the filter is used in Site Health debug data, as well as on plugin and theme screens, so the developer reference site remains correct.
Props johnbillion.
Fixes #50868 .
Built from https://develop.svn.wordpress.org/trunk@48750
git-svn-id: http://core.svn.wordpress.org/trunk@48512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 16:14:03 +00:00
5221a27593
Site Health: Consistently pass an object to the `auto_update_{$type}` filter in Site Health debug data.
...
Previously, some instances of the filter received an array from a plugin or theme update response, potentially triggering PHP notices.
Props bpayton, pbiron.
Fixes #50852 .
Built from https://develop.svn.wordpress.org/trunk@48745
git-svn-id: http://core.svn.wordpress.org/trunk@48507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-07 13:28:05 +00:00
3a32284b26
Posts, Post Types: Use a consistent wording in messages about a locked post.
...
Props ramiy.
Fixes #50859 .
Built from https://develop.svn.wordpress.org/trunk@48743
git-svn-id: http://core.svn.wordpress.org/trunk@48505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-06 13:14:08 +00:00
7e1e4f379a
Site Health: Check if `session_status()` exists before calling it.
...
Props bgermann.
Fixes #50862 .
Built from https://develop.svn.wordpress.org/trunk@48742
git-svn-id: http://core.svn.wordpress.org/trunk@48504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-06 00:25:07 +00:00
ee213e333b
Comments: Remove a few more unnecessary instances of `esc_html()` in `WP_Comments_List_Table::comment_status_dropdown()`.
...
Core translations are considered safe, and these labels are not escaped in any other instances.
Follow-up to [48521], [48722], [48724].
See #40188 , #50815 .
Built from https://develop.svn.wordpress.org/trunk@48741
git-svn-id: http://core.svn.wordpress.org/trunk@48503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-05 13:53:06 +00:00
aaf49752b2
Plugins: Move the "Successfully installed the plugin" string to the correct `Plugin_Upgrader` method.
...
The string refers to the installation, and belongs in the `::install_strings()` method, not in `::upgrade_strings()`.
Props sswebster, nateinaction, SergeyBiryukov.
Fixes #50837 .
Built from https://develop.svn.wordpress.org/trunk@48734
git-svn-id: http://core.svn.wordpress.org/trunk@48496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 17:54:04 +00:00
b84d7f1fd3
Site Health: Display auto-update properly for plugins that don't support auto-updates.
...
Properly filter `auto_update_plugin` when displaying the table.
Fixes #50822 .
Props Gwendydd, pbiron, audrasjb, SergeyBiryukov, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48731
git-svn-id: http://core.svn.wordpress.org/trunk@48493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 17:37:02 +00:00
315db55458
Comments: Restore the `::has_items()` call in `WP_Comments_List_Table::extra_tablenav()` for now, until unit tests are updated accordingly.
...
Follow-up to [48722].
Fixes #40188 . See #50815 .
Built from https://develop.svn.wordpress.org/trunk@48724
git-svn-id: http://core.svn.wordpress.org/trunk@48486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 16:26:03 +00:00
b615c45103
Comments: Use the existing static variable instead of calling `::has_items()` again in `WP_Comments_List_Table::extra_tablenav()`.
...
Additionally, removed unnecessary `esc_html()` on the Filter button label. Core translations are considered safe, and this label is not escaped in any other instance.
Props whyisjake, SergeyBiryukov.
Fixes #40188 .
Built from https://develop.svn.wordpress.org/trunk@48722
git-svn-id: http://core.svn.wordpress.org/trunk@48484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-04 15:58:06 +00:00
e2c8e2fa5a
Administration: Allow `wp_credits()` to accept `$version` and `$locale` parameters.
...
This can be helpful for plugin developers to get credits information for older versions or different locales.
Props ramiy.
Fixes #35910 .
Built from https://develop.svn.wordpress.org/trunk@48715
git-svn-id: http://core.svn.wordpress.org/trunk@48477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-03 12:53:08 +00:00
224fdb27b8
Upgrade/Install: Ensure the proper count of plugins that have auto-update enabled.
...
As certain plugins may not support updates, this count needs to accurately reflect that in the navbar.
Fixes 50808.
Props knutsp, audrasjb, pbiron, dd32, apedog, afragen, chriscct7, garyc40, whyisjake, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@48703
git-svn-id: http://core.svn.wordpress.org/trunk@48465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-31 17:21:04 +00:00
b4497ef13f
Upgrade/Install: Allow for WordPress.org to remotely disable auto-updates for plugins/themes
...
As auto-updates are rolled out across WordPress.org, the API response can modulate the response, ensuring that a rolled out could be stalled or staggered if needed for security or performance reasons.
Fixes #50824 .
Props dd32, whyisjake, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@48701
git-svn-id: http://core.svn.wordpress.org/trunk@48463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-31 17:03:05 +00:00
078db63c4b
Upgrade/Install: Pass the plugin file path into the `plugin_auto_update_debug_string` filter.
...
Adds better tooling for when user specific plugins can be updated, but platform specific ones cannot.
Fixes #50821 .
Props bpayton, pbiron, audrasjb, SergeyBiryukov, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48696
git-svn-id: http://core.svn.wordpress.org/trunk@48458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-30 21:50:02 +00:00
cf137e7c1b
Comments: Pass the `$which` parameter to the `manage_comments_nav` action.
...
This brings some consistency with the `manage_users_extra_tablenav` and `manage_users_extra_tablenav` actions.
Props Tkama, wpgurudev.
Fixes #50736 .
Built from https://develop.svn.wordpress.org/trunk@48693
git-svn-id: http://core.svn.wordpress.org/trunk@48455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-30 13:27:04 +00:00
72b87b3d74
Themes: Pass correct variable to `is_php_version_compatible()` in `wp_theme_update_row()`.
...
This applies to the Themes screen in Multisite network admin.
Follow-up to [48660].
Props pbiron, afragen.
Fixes #48507 . See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48689
git-svn-id: http://core.svn.wordpress.org/trunk@48451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-29 21:08:02 +00:00
e6bfdde581
Upgrade/Install: Only show auto-update for themes that support the feature.
...
Similar to the changes for plugins in [48669], let's only show the UI for themes when updates are supported for that theme.
See #50280 .
Props dd32.
Built from https://develop.svn.wordpress.org/trunk@48688
git-svn-id: http://core.svn.wordpress.org/trunk@48450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-29 20:01:08 +00:00
d351100eba
Upgrade/Install: Pass correct argument to `clear_destination` in `Theme_Upgrader::install()`.
...
Follow-up to [48390].
Props afragen, sabernhardt.
Fixes #9757 .
Built from https://develop.svn.wordpress.org/trunk@48685
git-svn-id: http://core.svn.wordpress.org/trunk@48447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-29 13:09:04 +00:00
c5ef3b7976
Media: Pass the `$rel` parameter to `image_send_to_editor` filter.
...
Props mihdan, pputzer.
Fixes #50765 .
Built from https://develop.svn.wordpress.org/trunk@48684
git-svn-id: http://core.svn.wordpress.org/trunk@48446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 21:21:05 +00:00
d8fd6d05a3
Upgrade/Install: Swap `auto-update-supported` to `update-supported` in update checks.
...
Ensures backwards compatability with external updaters.
See #50280 .
Props everyone-in-the-core-updates-channel.
Built from https://develop.svn.wordpress.org/trunk@48678
git-svn-id: http://core.svn.wordpress.org/trunk@48440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 18:28:06 +00:00
6209a40fd9
Upgrade/Install: Clarify the descriptions for `install_(plugin|theme)_overwrite_actions`.
...
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48677
git-svn-id: http://core.svn.wordpress.org/trunk@48439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 18:16:07 +00:00
1aa48c68f5
Upgrade/Install: Correct spelling of “overwrite” in new hooks and array indexes.
...
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48676
git-svn-id: http://core.svn.wordpress.org/trunk@48438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 17:56:04 +00:00
e4b2ad02b6
Administration: Don't override the `$mode` global in `WP_Screen::render_view_mode()` if it's already set.
...
Follow-up to [48398], [48423], [48424], [48450].
See #49715 .
Built from https://develop.svn.wordpress.org/trunk@48670
git-svn-id: http://core.svn.wordpress.org/trunk@48432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:55:04 +00:00
0f1f9bdb03
Upgrade/Install: Enhance auto-updates to be disabled for plugins that don't suport updates.
...
This removes the toggle UI when updates aren't available. When plugins use the filter, the UI is updated to show that they are being controlled via code. And then removed entirely when not available.
See #50798 .
Fixes #50280 .
Props elrae, pbiron, SergeyBiryukov, audrasjb, azaozz, StephenCronin, whyisjake, dd32, TimothyBlynJacobs, desrosj.
Built from https://develop.svn.wordpress.org/trunk@48669
git-svn-id: http://core.svn.wordpress.org/trunk@48431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:32:01 +00:00
2bf5b5749f
Administration: Pull the `table_view_mode` filter for now.
...
The extensibility of list table view modes will be explored in a future release.
Props audrasjb.
See #49715 .
Built from https://develop.svn.wordpress.org/trunk@48668
git-svn-id: http://core.svn.wordpress.org/trunk@48430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:19:03 +00:00
3db534a988
Upgrade/Install: Disable the plugin/theme auto-updates UI if `AUTOMATIC_UPDATER_DISABLED` is defined and set as `true`.
...
Props pbiron, dd32.
Fixes #50798 . See #50280 .
Built from https://develop.svn.wordpress.org/trunk@48667
git-svn-id: http://core.svn.wordpress.org/trunk@48429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:15:03 +00:00
4cfc383544
Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file.
...
Props mariovalney, desrosj.
See #50593 .
Built from https://develop.svn.wordpress.org/trunk@48666
git-svn-id: http://core.svn.wordpress.org/trunk@48428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:07:02 +00:00
0dd2f9f5c5
Docs: Add missing documentation for various upgrade/install class properties and methods.
...
Props ramiy.
Fixes #42923 .
Built from https://develop.svn.wordpress.org/trunk@48661
git-svn-id: http://core.svn.wordpress.org/trunk@48423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:57:03 +00:00
a745f035ab
Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress.
...
This applies to the Themes screen in Multisite network admin.
Props afragen, SergeyBiryukov.
Fixes #48507 . See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48660
git-svn-id: http://core.svn.wordpress.org/trunk@48422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:34:04 +00:00
e349d92b53
Themes: Include theme name in available update messages, for better accessibility and consistency with other similar messages.
...
Follow-up to [48652-48654].
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48659
git-svn-id: http://core.svn.wordpress.org/trunk@48421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:31:01 +00:00
8c3d56919e
Upgrade/Install: Improve `wp_opcache_invalidate()` performance.
...
Changes from using `preg_match()` based `.php` extension checking to using `substr()` in `wp_opcache_invalidate()`.
Props jnylen0, aaroncampbell, SergeyBiryukov, desrosj, mikeschroder.
Fixes #50784 .
Built from https://develop.svn.wordpress.org/trunk@48657
git-svn-id: http://core.svn.wordpress.org/trunk@48419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 08:09:05 +00:00
26b706e27f
Site Health: Incorrect file path in `require_once`.
...
Ensure that background updater can be loaded for testing to see if auto-updates can enable automatic updates.
Fixes #50793 .
Props dd32.
Built from https://develop.svn.wordpress.org/trunk@48655
git-svn-id: http://core.svn.wordpress.org/trunk@48417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 02:21:06 +00:00
0122e035b0
Themes: Display a message in theme grid and Theme Details modal if a theme update requires a higher version of PHP or WordPress.
...
This applies to the Themes screen and the Customizer theme browser.
Props afragen, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48652
git-svn-id: http://core.svn.wordpress.org/trunk@48414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 00:09:02 +00:00
1f89186a3d
Themes: Display a message in Theme Details modal if a theme requires a higher version of PHP or WordPress.
...
Props afragen, desrosj, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48636
git-svn-id: http://core.svn.wordpress.org/trunk@48398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 13:12:04 +00:00
9ec7f2febd
Docs: Correct `wp_opcache_invalidate_file` filter docs.
...
Changes incorrectly named `$filename` variable to `$filepath` and adjusts wording to align with PHP docs.
See #36455 .
Built from https://develop.svn.wordpress.org/trunk@48632
git-svn-id: http://core.svn.wordpress.org/trunk@48394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 09:08:05 +00:00
d8c62b5647
Posts, Post Types: Move `get_post_states()` back to the admin for now, require the file in `WP_Customize_Nav_Menus::customize_register()` instead.
...
This provides a minor performance improvement by only running the function in contexts where it's needed.
Follow-up to [47211], [47213], [47763], [48619].
See #46829 , #49374 .
Built from https://develop.svn.wordpress.org/trunk@48620
git-svn-id: http://core.svn.wordpress.org/trunk@48382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-26 10:51:06 +00:00
aab535a576
Posts, Post Types: Make `get_post_states()` available on frontend.
...
This allows special pages to be denoted as such when editing a menu in the Customizer.
This applies to the Front Page, Posts Page, and Privacy Policy Page.
Follow-up to [47211], [47213], [47763].
Props dlh, whyisjake, SergeyBiryukov.
Fixes #46829 . See #49374 .
Built from https://develop.svn.wordpress.org/trunk@48619
git-svn-id: http://core.svn.wordpress.org/trunk@48381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-26 01:14:06 +00:00
609acd89ed
I18N: Merge duplicate "List view" and "Grid view" strings.
...
Props ramiy.
Fixes #50757 .
Built from https://develop.svn.wordpress.org/trunk@48618
git-svn-id: http://core.svn.wordpress.org/trunk@48380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 21:32:05 +00:00
c40a645510
Docs: Correct `@see` references for privacy hooks:
...
* `wp_privacy_personal_data_export_page`
* `wp_privacy_personal_data_erasure_page`
Hooks should be single-quoted when referenced.
Props pbiron, coffee2code.
See #49572 , #meta5318.
Built from https://develop.svn.wordpress.org/trunk@48616
git-svn-id: http://core.svn.wordpress.org/trunk@48378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 19:14:03 +00:00
7d305c8ff9
Docs: Correct `@since` tags for some `WP_List_Table` hooks:
...
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
Follow-up to [15491], [15578], [26401].
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48615
git-svn-id: http://core.svn.wordpress.org/trunk@48377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 18:55:03 +00:00
0ef0a1905b
Docs: Remove outdated statement in `bulk_actions-{$this->screen->id}` filter description.
...
As of WordPress 4.7, developers can register their own bulk actions on list table screens.
Follow-up to [17297], [38647].
Props joyously, pbiron.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48614
git-svn-id: http://core.svn.wordpress.org/trunk@48376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 18:13:02 +00:00
ef382e6aaf
Site Health: Escape the displayed result of the request in REST API availability test.
...
Props siliconforks, gisselfeldt.
Fixes #50588 .
Built from https://develop.svn.wordpress.org/trunk@48608
git-svn-id: http://core.svn.wordpress.org/trunk@48370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 15:38:06 +00:00
b6f52721ed
Administration: Use sentence case for "Mark as spam" bulk action links for sites and users, for consistency with comments.
...
Follow-up to [48352].
See #40244 .
Built from https://develop.svn.wordpress.org/trunk@48595
git-svn-id: http://core.svn.wordpress.org/trunk@48357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-24 00:27:03 +00:00
703a978a77
Administration: Capitalize `Trash` consistently in various messages.
...
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.
Follow-up to [47233], [48352].
See #45317 , #40244 .
Built from https://develop.svn.wordpress.org/trunk@48594
git-svn-id: http://core.svn.wordpress.org/trunk@48356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-24 00:21:03 +00:00
9bc7d0a776
Docs: Another pass at some inline docs fixes mostly made by PHPCBF.
...
See #49572 , #50744
Built from https://develop.svn.wordpress.org/trunk@48590
git-svn-id: http://core.svn.wordpress.org/trunk@48352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 21:11:05 +00:00
3f04e3bf5c
I18N: Further adjust some update/install strings for consistency.
...
Follow-up to [48568], [48569].
See #50708 , #50714 .
Built from https://develop.svn.wordpress.org/trunk@48589
git-svn-id: http://core.svn.wordpress.org/trunk@48351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 21:08:01 +00:00
5950e15042
I18N: Merge two "Return to top" strings.
...
Props ramiy, carike, whyisjake.
Fixes #50743 .
Built from https://develop.svn.wordpress.org/trunk@48588
git-svn-id: http://core.svn.wordpress.org/trunk@48350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 20:21:07 +00:00
161821d155
Site Health: Correct the quotes for the `tested` value of mock plugin data in auto-updates test.
...
Follow-up to [48584].
See #50662 .
Built from https://develop.svn.wordpress.org/trunk@48587
git-svn-id: http://core.svn.wordpress.org/trunk@48349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 20:13:05 +00:00
57a3f803ae
Docs: First pass at some inline docs fixes mostly made by PHPCBF.
...
See #49572 , #50744
Built from https://develop.svn.wordpress.org/trunk@48586
git-svn-id: http://core.svn.wordpress.org/trunk@48348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 20:01:04 +00:00
7f898dd9c4
Docs: Use more appropriate variable names in the inline docs for action and filter parameters.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48585
git-svn-id: http://core.svn.wordpress.org/trunk@48347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 19:06:03 +00:00
231d21ebcd
Site Health: Pass all expected parameters to `auto_update_{$type}`.
...
This prevents fatal errors when other hooked functions are expecting both parameters.
Props dd32, desrosj, audrasjb, pbiron.
Fixes #50662 .
Built from https://develop.svn.wordpress.org/trunk@48584
git-svn-id: http://core.svn.wordpress.org/trunk@48346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 19:03:04 +00:00
0eb1b2a447
I18N: Update "Default Template" string to match the sentence case used in the block editor.
...
Props ramiy.
Fixes #50742 .
Built from https://develop.svn.wordpress.org/trunk@48583
git-svn-id: http://core.svn.wordpress.org/trunk@48345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 18:55:01 +00:00
2c2508f98c
General: Ensure the database upgrades from [48575] are run.
...
This corrects the database version to match the commit number the upgrade changes were made.
See #50413 .
Built from https://develop.svn.wordpress.org/trunk@48582
git-svn-id: http://core.svn.wordpress.org/trunk@48344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 18:43:04 +00:00
124972f2c6
Docs: Further corrections and improvements to various inline docblocks.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48576
git-svn-id: http://core.svn.wordpress.org/trunk@48338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 07:39:02 +00:00
6cab8cce22
General: Update code for readability and inclusion
...
There are two pieces in here:
1) The update to change blacklist to blocklist is moved to disallowed_list. "Block" has a meaning in our code, and there could be ambiguity between this code and code related to blocks.
2) This improves backwards compatibility for code that was accessing the now deprecated code.
Previously: [48477], [48405], [48400], [48121], [48122], [48124], [48142], [48566]
Props: desrosj, SergeyBiryukov, johnjamesjacoby
Fixes : #50413
Built from https://develop.svn.wordpress.org/trunk@48575
git-svn-id: http://core.svn.wordpress.org/trunk@48337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 03:14:06 +00:00
0bf9b04c53
Docs: Various formatting improvements to inline docblocks.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48574
git-svn-id: http://core.svn.wordpress.org/trunk@48336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 00:52:05 +00:00
1fbcdb2213
Docs: Various corrections to inline docblocks.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48573
git-svn-id: http://core.svn.wordpress.org/trunk@48335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 00:48:06 +00:00
dd642e7b00
i18n: Merge similar translation strings to "Update failed".
...
Fixes #50714 .
Props ramiy, ocean90.
Built from https://develop.svn.wordpress.org/trunk@48569
git-svn-id: http://core.svn.wordpress.org/trunk@48331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 22:10:02 +00:00
921ddab889
I18N: Merge similar "Installation failed" strings
...
Fixes #50708 .
Props ramiy, ocean90, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@48568
git-svn-id: http://core.svn.wordpress.org/trunk@48330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 21:59:05 +00:00
2cebcb6144
General: Rename `remove_option_allowed_list()` to `remove_allowed_options()`.
...
This was missed in [48142] which renamed `add_option_allowed_list()` to `add_allowed_options()` for better readability. The two functions should have consistent names.
See #50413 .
Built from https://develop.svn.wordpress.org/trunk@48566
git-svn-id: http://core.svn.wordpress.org/trunk@48328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 18:52:02 +00:00
1373b2056d
Docs: Correct type for the `$theme` parameter of `theme_auto_update_debug_string` filter.
...
Follow-up to [48546], [48549], [48552].
See #50663 .
Built from https://develop.svn.wordpress.org/trunk@48561
git-svn-id: http://core.svn.wordpress.org/trunk@48323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 00:29:03 +00:00
88e046f1e8
Site Health: Fix some typos in the test for plugin and theme auto-updates.
...
Follow-up to [48548], [48558], [48559].
See #50662 .
Built from https://develop.svn.wordpress.org/trunk@48560
git-svn-id: http://core.svn.wordpress.org/trunk@48322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 00:17:04 +00:00
c6034be779
Site Health: Correct inverted logic for themes in the test for plugin and theme auto-updates.
...
Follow-up to [48548], [48558].
See #50662 .
Built from https://develop.svn.wordpress.org/trunk@48559
git-svn-id: http://core.svn.wordpress.org/trunk@48321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 00:15:02 +00:00
93bf0c3b83
Site Health: Add the test for plugin and theme auto-updates to `WP_Site_Health::get_tests()`.
...
This ensures that the test actually runs.
Follow-up to [48548].
See #50662 .
Built from https://develop.svn.wordpress.org/trunk@48558
git-svn-id: http://core.svn.wordpress.org/trunk@48320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 00:07:02 +00:00
a68d462439
Site Health: Use a consistent label for theme auto-updates in debug data.
...
Props audrasjb.
Fixes #50728 .
Built from https://develop.svn.wordpress.org/trunk@48554
git-svn-id: http://core.svn.wordpress.org/trunk@48316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 21:06:02 +00:00
94d4561906
Site Health: Simplify the logic for displaying whether auto-updates are enabled for plugins and themes.
...
Remove some extra variables.
Follow-up to [48546], [48549].
See #50663 .
Built from https://develop.svn.wordpress.org/trunk@48552
git-svn-id: http://core.svn.wordpress.org/trunk@48314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 18:44:04 +00:00
8a58ab36cc
Site Health: Rename the filters added in [48546] for clarity.
...
See #50663 .
Built from https://develop.svn.wordpress.org/trunk@48549
git-svn-id: http://core.svn.wordpress.org/trunk@48311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 17:09:03 +00:00
9d2b92be26
Site Health: Add tests to check for potential issues with plugin and theme auto-updates.
...
Fixes #50662 .
Props desrosj, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@48548
git-svn-id: http://core.svn.wordpress.org/trunk@48310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 17:07:05 +00:00
32f791da49
Site Health: Add auto-update information to for plugins and themes.
...
New filters:
* `plugin_auto_update_debug_str`
* `theme_auto_update_debug_str`
Fixes #50663 .
Props pbiron, audrasjb, davidbaumwald.
Built from https://develop.svn.wordpress.org/trunk@48546
git-svn-id: http://core.svn.wordpress.org/trunk@48308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 16:54:02 +00:00
548df4e3e6
I18N: Add context to some theme strings for consistency.
...
Props ramiy, ocean90.
Fixes #50709 .
Built from https://develop.svn.wordpress.org/trunk@48545
git-svn-id: http://core.svn.wordpress.org/trunk@48307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 16:33:05 +00:00
48841f9ab3
Site Health: Rename `upload_max` array key in file upload checks to `max_effective_size` for clarity.
...
Follow-up to [48535].
See #50038 .
Built from https://develop.svn.wordpress.org/trunk@48544
git-svn-id: http://core.svn.wordpress.org/trunk@48306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 16:20:03 +00:00
1c52ad8d3f
Site Health: Move `post_max_size` and `upload_max_filesize` out of a translatable string in file upload checks.
...
Simplify some other strings, use a consistent format for translator comments.
Follow-up to [48535].
See #50038 .
Built from https://develop.svn.wordpress.org/trunk@48539
git-svn-id: http://core.svn.wordpress.org/trunk@48301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 15:53:04 +00:00
bec9fa5010
Site Health: Remove `parse_ini_size()`, use the existing `wp_convert_hr_to_bytes()` function instead.
...
Follow-up to [48535].
See #50038 .
Built from https://develop.svn.wordpress.org/trunk@48538
git-svn-id: http://core.svn.wordpress.org/trunk@48300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 15:40:03 +00:00
73a8fb4cc3
Site Health: Include new tests to check for the ability to upload files.
...
Several new checks:
* `max_file_uploads`
* `file_uploads`
* `post_max_size`
* `upload_max_filesize`
* `upload_max`
* `max_file_uploads`
In addition, new function `parse_ini_size()` that converts shorthand byte strings to bytes. Useful for size comparisons.
Fixes #50038 .
Props dd32, donmhico, JavierCasares, SergeyBiryukov, ayeshrajans, Clorith, ipstenu, sabernhardt, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48535
git-svn-id: http://core.svn.wordpress.org/trunk@48297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 15:21:02 +00:00
d1822e81ba
Site Health: Use consistent error messages when switching plugin or theme auto-updates on or off.
...
Props ramiy.
Fixes #50721 .
Built from https://develop.svn.wordpress.org/trunk@48534
git-svn-id: http://core.svn.wordpress.org/trunk@48296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 14:42:05 +00:00
9ce7bd633b
Docs: Improve description for `edit_post()`.
...
Props stevenlinx.
Fixes #50713 .
Built from https://develop.svn.wordpress.org/trunk@48529
git-svn-id: http://core.svn.wordpress.org/trunk@48291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 12:49:03 +00:00
5c836585d1
Comments: Don't show the filter/pagination actions if there are no comments to list.
...
It doesn't make sense to be able to filter the comments list table when there are are no (trashed/spam) comments available.
Fixes #40188 .
Props swissspidy, Jim_Panse, menakas, akbarhusen429, dinhtungdu, birgire, SergeyBiryukov, davidbaumwald, rebasaurus, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48521
git-svn-id: http://core.svn.wordpress.org/trunk@48283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 00:29:02 +00:00
e4ce35dd11
I18N: Add context to some plugin and theme strings for consistency.
...
Props ramiy, audrasjb.
Fixes #50710 .
Built from https://develop.svn.wordpress.org/trunk@48520
git-svn-id: http://core.svn.wordpress.org/trunk@48282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-20 23:14:05 +00:00
82ce41ff51
I18N: Mark the strings with plugin and theme names in email notifications for translation.
...
Follow-up to [48517].
See #50350 .
Built from https://develop.svn.wordpress.org/trunk@48519
git-svn-id: http://core.svn.wordpress.org/trunk@48281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-20 21:25:06 +00:00
02f200df1d
Administration: Include the new plugin and theme versions in email notifications.
...
This helps administrators keep track of which versions of plugins and themes are running on their site when auto-updates occur.
Props audrasjb, pbiron.
Fixes #50350 .
Built from https://develop.svn.wordpress.org/trunk@48517
git-svn-id: http://core.svn.wordpress.org/trunk@48279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-20 18:28:03 +00:00
efb77b4a65
Upgrade/install: Fix/clarify the "Upload in a zip format" string.
...
Props greenshady, mariovalney.
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48509
git-svn-id: http://core.svn.wordpress.org/trunk@48271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-19 17:11:02 +00:00
c3f787b8ff
Docs: Miscellaneous docblock corrections.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48508
git-svn-id: http://core.svn.wordpress.org/trunk@48270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-18 22:11:02 +00:00
da7a54d206
Administration: Fix an index inconsistency in `get_admin_page_title()` function.
...
Ensure that `get_admin_page_title()` returns a value from pages registered using `add_menu_page()`.
Fixes #46081 .
Props grapestain, valentinbora, SergeyBiryukov, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@48500
git-svn-id: http://core.svn.wordpress.org/trunk@48262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-16 22:15:07 +00:00
a53b741359
Coding Standards: Update the docblock to remove superflous `since`.
...
The `@deprecated` DocBlock tag should start with the version followed by the description of what to use instead.
Fixes #44959 .
Props keesiemeijer, sabernhardt.
Built from https://develop.svn.wordpress.org/trunk@48495
git-svn-id: http://core.svn.wordpress.org/trunk@48257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-16 21:12:08 +00:00
64a4066874
Upgrade/Install: Check if the theme installer skin's `overwrite` property exists in `Theme_Upgrader::install_strings()`.
...
This ensures consistency with `Plugin_Upgrader::install_strings()` and resolves an issue caused by the property not existing in other upgrader implementations.
Props schlessera, azaozz.
See #50670 .
Built from https://develop.svn.wordpress.org/trunk@48493
git-svn-id: http://core.svn.wordpress.org/trunk@48255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-16 13:19:03 +00:00
fdd88e24ed
General: Rename the `$new_whitelist_options` global variable.
...
This change renames `$new_whitelist_options` to `$new_allowed_options`. This makes the variable’s purpose more clear, and promotes using more inclusive language.
For backwards compatibility, the new variable is passed by reference to the old one.
Follow up to [48121].
Props ayeshrajans, desrosj, jorbin, SergeyBiryukov.
See #50413 .
Fixes #50434 .
Built from https://develop.svn.wordpress.org/trunk@48477
git-svn-id: http://core.svn.wordpress.org/trunk@48246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-14 12:33:02 +00:00
5eb3f0ffcb
Docs: Improve docs for arguments that accept a numerically indexed array of associative arrays.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48475
git-svn-id: http://core.svn.wordpress.org/trunk@48244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-14 12:10:05 +00:00
4ff1233e75
Docs: Correct and improve inline docs for parameters that accept a callback function.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48473
git-svn-id: http://core.svn.wordpress.org/trunk@48242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-14 11:56:04 +00:00
6b21db7fb9
Docs: Miscellaneous docblock corrections and improvements.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48462
git-svn-id: http://core.svn.wordpress.org/trunk@48231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-13 22:10:07 +00:00
7c09c153d5
Upgrade/Install: Simplify compatibility checks for uploaded plugins and themes for better readability.
...
Use `$new_plugin_data` and `$new_theme_data` as a shorthand for the corresponding `$this->upgrader` properties.
Follow-up to [48390], [48448].
Props afragen.
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48455
git-svn-id: http://core.svn.wordpress.org/trunk@48224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-13 13:35:05 +00:00
63a2cb3060
Upgrade/Install: Use `wp_strip_all_tags()` for the fields in the compare table on the "Update theme/plugin from uploaded zip" screen. Some may contain HTML.
...
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48453
git-svn-id: http://core.svn.wordpress.org/trunk@48222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 20:00:03 +00:00
9848b6b3e9
Plugins: Make delete plugin message less scary.
...
This adds a check if the plugin actually has an uninstall routine before saying that its data will be deleted too.
Props samful, joostdevalk, joyously, Chouby, SergeyBiryukov.
Fixes #50346 .
Built from https://develop.svn.wordpress.org/trunk@48451
git-svn-id: http://core.svn.wordpress.org/trunk@48220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 13:22:04 +00:00
c4543704e2
Administration: Restore the `excerpt` key for the Extended view mode for backward compatibility for now.
...
Props Offereins.
See #49715 .
Built from https://develop.svn.wordpress.org/trunk@48450
git-svn-id: http://core.svn.wordpress.org/trunk@48219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 11:36:04 +00:00
1556ecc000
Docs: Add a `@since` entry for the `$hook_extra` parameter added to `WP_Upgrader::download_package()`.
...
Follow-up to [48399].
See #49686 .
Built from https://develop.svn.wordpress.org/trunk@48449
git-svn-id: http://core.svn.wordpress.org/trunk@48218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 11:02:03 +00:00
707534c2d8
Upgrade/Install: Use `is_php_version_compatible()` and `is_wp_version_compatible()` in plugin and theme requirement checks.
...
Follow-up to [48390].
Props afragen.
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48448
git-svn-id: http://core.svn.wordpress.org/trunk@48217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 10:55:03 +00:00
f83b8775b3
I18N: Move the "WordPress Backups" support URL to its own translatable string.
...
Follow-up to [48390].
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48447
git-svn-id: http://core.svn.wordpress.org/trunk@48216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 10:34:05 +00:00
3f1650122a
Docs: Miscellaneous DocBlock corrections for plugin and theme updates.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48446
git-svn-id: http://core.svn.wordpress.org/trunk@48215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 01:19:03 +00:00
cecf7b9823
Administration: Handle the result of `Plugin_Upgrader::bulk_upgrade()` for a plugin that is already at the latest version in the same way it is handled for themes.
...
This corrects a fragile check of the result in `wp_ajax_update_plugin()` that depended on the internal array pointer, and brings some consistency with `wp_ajax_update_theme()`.
Follow-up to [37714], [48401].
See #50448 .
Built from https://develop.svn.wordpress.org/trunk@48445
git-svn-id: http://core.svn.wordpress.org/trunk@48214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 01:16:05 +00:00
7b61df725e
Revisions: Replace `array_shift()` with `reset()` in `register_and_do_post_meta_boxes()` for better performance.
...
Follow-up to [31829], [48422].
See #34560 .
Built from https://develop.svn.wordpress.org/trunk@48436
git-svn-id: http://core.svn.wordpress.org/trunk@48205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-11 12:30:02 +00:00
51856d435b
Administration: Bring some consistency to handling list table view modes.
...
* Remove duplicate variables and DocBlocks.
* Add missing description for the `$mode` global.
* Use sentence case for "Compact view" and "Extended view" labels.
Follow-up to [48398], [48423].
Props afercia, Offereins, SergeyBiryukov.
See #49715 .
Built from https://develop.svn.wordpress.org/trunk@48424
git-svn-id: http://core.svn.wordpress.org/trunk@48193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 16:04:05 +00:00
0f92086ca0
Administration: Make some adjustments to `WP_Screen::render_view_mode()`:
...
* Restore the `$mode` global for backward compatibility.
* Remove redundant check, as `$mode` is already set at this point, and already defaults to `list` via `get_user_setting()`'s second argument.
* Use sentence case for "View mode" and "Extended view" labels.
Follow-up to [48398].
See #49715 .
Built from https://develop.svn.wordpress.org/trunk@48423
git-svn-id: http://core.svn.wordpress.org/trunk@48192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 16:02:05 +00:00
7d0162bc2e
Revisions: optimize performance when post has large number of revisions.
...
Improve speed and reduce the memory footprint when loading posts with many revisions.
* Use a direct query in `wp_get_post_autosave` to avoid loading all revisions.
* Query for IDs vs full objects in `register_and_do_post_meta_boxes`.
Props pdfernhout, johnnyb, miqrogroove, ocean90, senatorman, DBrumbaugh10Up, martijn-van-der-kooij, pavelevap, mackensen, mikeyarce, whyisjake.
Fixes #34560 .
Built from https://develop.svn.wordpress.org/trunk@48422
git-svn-id: http://core.svn.wordpress.org/trunk@48191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 15:13:07 +00:00
b03053eb2a
Docs: Correct documentation for `customize_controls_head` hook and `_customizer_mobile_viewport_meta()` function.
...
Follow-up to [48412].
See #47369 .
Built from https://develop.svn.wordpress.org/trunk@48420
git-svn-id: http://core.svn.wordpress.org/trunk@48189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 11:36:07 +00:00
28a390c2b2
Upgrade/Install: Use ARIA button class on plugin and theme auto-updates action links
...
According to the [accesability guidelines](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/accessibility/#semantics-for-controls ), the control should be a link when JavaScript is not available and a button the rest of the time.
In addition, handlers were added for spacebar usage, and some changes to the a11y speak verbiage.
Fixes #50516 .
Props ryokuhi, audrasjb, afercia, whyisjake/
Built from https://develop.svn.wordpress.org/trunk@48418
git-svn-id: http://core.svn.wordpress.org/trunk@48187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 06:18:04 +00:00
836ad98276
Upgrade/Install: Ensure cleanup after canceled update.
...
Ensure that the uploaded zip is hidden from the media library, where a task will remove failed installs after two hours.
Fixes #50612 .
Props psykro, desrosj, joyously, azaozz, noisysocks, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48417
git-svn-id: http://core.svn.wordpress.org/trunk@48186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 06:08:06 +00:00
9397ad46ba
Coding Standards: Some missed code formatting.
...
Unprops: whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48415
git-svn-id: http://core.svn.wordpress.org/trunk@48184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 01:01:03 +00:00
1158166d9c
Administration: Remove multiple viewport meta tags from mobile pages.
...
In addition, add the `wp_admin_viewport_meta()` function, paired to the `admin_viewport_meta` filter to control attributes of the meta tag.
Fixes #47369 .
Props BettyJJ, mukesh27, SergeyBiryukov, ajayghaghretiya1, msaggiorato, talldanwp, davidbaumwald, donmhico, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@48412
git-svn-id: http://core.svn.wordpress.org/trunk@48181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-09 23:29:08 +00:00
6bf6bc451f
Docs: Miscellaneous DocBlock corrections.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48408
git-svn-id: http://core.svn.wordpress.org/trunk@48177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-08 13:15:03 +00:00
c358ba7112
Upgrade/Install: Prevent the upgrade routine for updating the `comment_type` field in the comments table from running twice.
...
Follow-up to [47597], [48400].
See #50413 , #49236 .
Built from https://develop.svn.wordpress.org/trunk@48405
git-svn-id: http://core.svn.wordpress.org/trunk@48174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-08 10:58:05 +00:00
500508884e
Administration: Fix failing tests as a result of [48397].
...
Because of changes to how PHP handles arrays used in `foreach()` loops in PHP >= 7.0, [48397] resulted in a failing test for PHP 5.6.
This calls `reset()` after using the `$results` array in the `foreach()` to ensure the array is treated the same and as expected.
Props azaozz, desrosj, SergeyBiryukov, xknown.
See #50448 .
Built from https://develop.svn.wordpress.org/trunk@48401
git-svn-id: http://core.svn.wordpress.org/trunk@48170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 20:38:03 +00:00
a8521d48ac
Upgrade/Install: Prevent some 5.5.0 upgrade routines from running twice.
...
This will prevent the options renamed for 5.5.0 from being converted twice. If a new update routine is added before 5.5 is released, the option values would be erased for anyone running `trunk` or nightlies without this change.
Props azaozz, desrosj, SergeyBiryukov, whyisjake.
Fixes #50413 .
Built from https://develop.svn.wordpress.org/trunk@48400
git-svn-id: http://core.svn.wordpress.org/trunk@48169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 19:21:06 +00:00
8381fad76e
Upgrade/Install: Add `hook_extra` parameter to the `upgrader_pre_download` filter.
...
This provides additional context to code running on this hook, including which plugin or theme update will be downloaded. It also brings consistency to this filter with others throughout the upgrade process.
Props obliviousharmony, desrosj.
Fixes #49686 .
Built from https://develop.svn.wordpress.org/trunk@48399
git-svn-id: http://core.svn.wordpress.org/trunk@48168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 19:15:06 +00:00
dcdabb5bb3
Administration: Introduce extensibility to posts and comments list table views, for accessibility purposes.
...
At default, expands the excerpt view to become an extended view. Includes a new `table_view_mode` filter to allow further configuration.
Fixes #49715 .
Props joedolson, audrasjb, afercia, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48398
git-svn-id: http://core.svn.wordpress.org/trunk@48167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 19:12:03 +00:00
48da753ff0
Administration: Prevent repeat emails for identical plugin or theme auto-update attempt failures.
...
This change adds a throttle mechanism to plugin and theme auto-update failure emails using similar logic to the email sent for a Core auto-update.
The first time a plugin or theme auto-update fails, the package and `new_version` will be tracked in the `auto_plugin_theme_update_emails` option. An email for this specific update attempt will not be resent.
However, if this update fails again and non-repeat failures or successful updates are also present, then the failure information will be included in that email (an email needs to be sent for the new events regardless).
Props johnbillion, arpitgshah, desrosj, audrasjb, pbiron, earnjam.
Fixes #50448 .
Built from https://develop.svn.wordpress.org/trunk@48397
git-svn-id: http://core.svn.wordpress.org/trunk@48166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 19:00:02 +00:00
49bbff551b
Upgrade/install: Allow plugin and theme updates from a uploaded .zip file.
...
Props mariovalney, cyberhobo, imath, shaunandrews, mariovalney, earnjam, desrosj, dd32, folletto, swissspidy, melchoyce, pento, joshuawold, psykro, clorith, ahortin, galbaras, pingram3541, joyously, doobeedoo, karmatosed, poena, whyisjake, earnjam, sergeybiryukov, audrasjb, azaozz.
Fixes #9757 .
Built from https://develop.svn.wordpress.org/trunk@48390
git-svn-id: http://core.svn.wordpress.org/trunk@48159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 17:49:05 +00:00
3c41801c5c
Administration: Reinstate the description for the `admin_xml_ns` hook which was accidentally removed in [47771].
...
See #46015 .
Built from https://develop.svn.wordpress.org/trunk@48380
git-svn-id: http://core.svn.wordpress.org/trunk@48149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 14:57:02 +00:00
913f5aaab9
Docs: Correct some `@since` entries added in 5.5.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48377
git-svn-id: http://core.svn.wordpress.org/trunk@48146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 14:14:04 +00:00
aee4324b9e
Accessibility: Media: Improve accessibility of the status and error messages in the Image Editor.
...
- improves focus management by moving focus to the notices, if any, or to the first "tabbable" element
- this avoids a focus loss and helps Braille-only and screen magnification users to be aware of the messages
- adds an ARIA role `alert` to all the notices
- uses `wp.a11y.speak()` to announce messages to assistive technology
- this way, all visual users will see the messages while assistive technology users will get an audible message
- uses `wp.i18n` for translatable strings in `wp-admin/js/image-edit.js`
Props anevins, ryanshoover, antpb, SergeyBiryukov, afercia.
See #20491 .
Fixes #47147 .
Built from https://develop.svn.wordpress.org/trunk@48375
git-svn-id: http://core.svn.wordpress.org/trunk@48144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 13:45:02 +00:00
181717c9ab
Plugins: Make sure the HTML ID attributes in plugin action links are unique.
...
Follow-up to [47588].
Props mukesh27, roytanck, SergeyBiryukov.
Fixes #49916 .
Built from https://develop.svn.wordpress.org/trunk@48374
git-svn-id: http://core.svn.wordpress.org/trunk@48143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 13:43:02 +00:00
22d0cd6c96
Accessibility: Allow post boxes on the Dashboard and Classic Editor pages to be reordered by using the keyboard.
...
So far, it has been possible to rearrange into a new order the post boxes (also known as "widgets" on the Dashboard and "meta boxes" on the Edit post page) only by using a pointing device, for example a mouse.
This change adds new controls and functionality to allow the boxes to be rearranged also with the keyboard. Additionally, audible messages are sent to the admin ARIA live region to notify screen reader users of the reorder action result.
Props joedolson, anevins, antpb, audrasjb, xkon, MarcoZ, karmatosed, afercia.
Fixes #39074 .
Built from https://develop.svn.wordpress.org/trunk@48373
git-svn-id: http://core.svn.wordpress.org/trunk@48142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 13:00:02 +00:00
81b809e3d6
Administration: Move more table strings to sentence casing.
...
WordPress as a project has moved largely to sentence casing for UI elements in the admin. This commit moves several string$
* Move to trash
* Mark as spam
* Permanently delete comment
* Approve comment
* In response to
* Bulk actions
* Not spam
* Sumitted on
* Delete permanently
* Add media
* Upload files
* Upload images
* Add media
* Bulk select
* Restore from trash
* Search media
* Attachment details
* Create gallery
* Edit gallery
* Cancel gallery
* Add to gallery
* Image details
* Replace image
* Cancel edit
* Edit image
* Choose image
* Select and crop
* Skip cropping
* Crop image
* Audio details
* Replace audio
* Add audio source
* Video details
* Replace video
* Add video source
* Select poster image
* Add subtitles
* Create audio playlist
* Edit audio playlist.
* Cancel audio playlist
* Create video playlist
* Edit video playlist
* Add to video playlist
* Filter media
Fixes #40244 .
Props afercia, bhargavbhandari90, rcutmore, webzunft, manojlovic, jeremyfelt, desrosj, lschuyler, SergeyBiryukov, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48352
git-svn-id: http://core.svn.wordpress.org/trunk@48121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 21:52:21 +00:00
bc7de32645
Coding Standards: Correct two coding standards issues introduced in [48277] and [48334].
...
See #50504 , #50550 .
Built from https://develop.svn.wordpress.org/trunk@48345
git-svn-id: http://core.svn.wordpress.org/trunk@48114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 19:23:02 +00:00
77af0e5982
Docs: Correct instances of “auto update” with “auto-update” for consistency.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48344
git-svn-id: http://core.svn.wordpress.org/trunk@48113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 19:15:03 +00:00
John Blackbourn
Sergey Biryukov
Andrew Ozz
Peter Wilson
TimothyBlynJacobs
iandunn
Dominik Schilling
Adam Silverstein
desrosj
Felix Arntz
whyisjake
Mike Schroder
Aaron Jorbin
Andrea Fercia