Commit Graph

1533 Commits

Author SHA1 Message Date
Drew Jaynes cd8cedc40d First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

Built from https://develop.svn.wordpress.org/trunk@26868


git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-24 18:57:12 +00:00
Ryan Boren 07c16fd23c The Pinking Shears stir from their slumber, awakened by what may seem, to those
innocent in the ways of The Shears, a triviality, a nothing-of-consequence. But there are consequences indeed for recklessly trailing your whitespace. Naturally, they a dire!

One, two! One, two! And through and through
The Pinking Shears went snicker-snack!
They plucked your tail and with your space
They went sniksnuking back.

Let me tell you, that can be uncomfortable, so always pre-sniksnuk your trailing whites. May The Shears be with you.

Built from https://develop.svn.wordpress.org/trunk@26851


git-svn-id: http://core.svn.wordpress.org/trunk@26738 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-11 19:49:11 +00:00
Andrew Ozz 4f44dc74b1 Themes: fix overlays and buttons in responsive mode, props matveb, fixes #26481.
Built from https://develop.svn.wordpress.org/trunk@26838


git-svn-id: http://core.svn.wordpress.org/trunk@26725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 19:38:10 +00:00
Andrew Nacin 87265a374b Themes: use explicit 'search installed themes' label and placeholder.
fixes #26496.

Built from https://develop.svn.wordpress.org/trunk@26827


git-svn-id: http://core.svn.wordpress.org/trunk@26714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 07:41:10 +00:00
Andrew Nacin 2530fbbfba Themes: Avoid a JS error in the keyup event handler when the overlay is not yet initialized.
fixes #26497.

Built from https://develop.svn.wordpress.org/trunk@26826


git-svn-id: http://core.svn.wordpress.org/trunk@26713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 07:07:10 +00:00
Andrew Ozz 3bdfaafaa0 Fix error in postbox.js attempting to change screen columns on mobile devices orientation changes, fixes #26493.
Built from https://develop.svn.wordpress.org/trunk@26822


git-svn-id: http://core.svn.wordpress.org/trunk@26709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 04:21:10 +00:00
Andrew Nacin 6d226fb454 Don't set the theme overlay active state in the Theme view, as it overwrites the same work in the Details view.
fixes #26481.

Built from https://develop.svn.wordpress.org/trunk@26815


git-svn-id: http://core.svn.wordpress.org/trunk@26702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 01:27:10 +00:00
Matt Thomas cd465575f1 Expand the Quick Draft section by default. Fixes #26463, props bassgang.
Built from https://develop.svn.wordpress.org/trunk@26813


git-svn-id: http://core.svn.wordpress.org/trunk@26700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-09 00:43:11 +00:00
Andrew Ozz 95a02fbe43 Fake a "non-responsive" window width for IE < 9 when folding/unfolding the menu (old IE doesn't support @media), fixes #26458.
Built from https://develop.svn.wordpress.org/trunk@26785


git-svn-id: http://core.svn.wordpress.org/trunk@26672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 18:46:11 +00:00
Andrew Nacin 71fa7d8e6c Fix JSHint errors and remove unreachable code. props adamsilverstein. see #25963.
Built from https://develop.svn.wordpress.org/trunk@26778


git-svn-id: http://core.svn.wordpress.org/trunk@26665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 07:52:11 +00:00
Andrew Nacin c09252b950 Core updates for the new color schemes.
* Update about page, there's now 8.
 * Display them four wide, not three, and ensure adequate spacing.
 * Use a dedicated nonce.
 * Push Light to the front in addition to Default.
 * Use user-profile.js on about.php. A few extra things are initialized but they are harmless.

see #26468, #26387.

Built from https://develop.svn.wordpress.org/trunk@26776


git-svn-id: http://core.svn.wordpress.org/trunk@26663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 07:46:21 +00:00
Ryan Boren b07b8d4fe8 Make the Backbone routes pushSTate capable with ?theme=themename type urls instead of hashes. Same applies to search queries.
Props adamsilverstein, nacin
fixes #25963

Built from https://develop.svn.wordpress.org/trunk@26767


git-svn-id: http://core.svn.wordpress.org/trunk@26655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 03:11:10 +00:00
Andrew Nacin 51a89c8ae6 Themes: Ensure the image returns a width before checking that it is less than 300px.
see #26459.

Built from https://develop.svn.wordpress.org/trunk@26765


git-svn-id: http://core.svn.wordpress.org/trunk@26653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 01:59:10 +00:00
Matt Thomas e0957c8eb7 Adding autosave for color schemes and removing RTL handling. See #26387, props ryelle.
Built from https://develop.svn.wordpress.org/trunk@26746


git-svn-id: http://core.svn.wordpress.org/trunk@26634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 21:26:10 +00:00
Andrew Ozz 2da2559d26 Responsive menu: fix calculation of the responsive trigger width from JS. It is affected by a vertical scrollbar width in some browsers. See #26458.
Built from https://develop.svn.wordpress.org/trunk@26743


git-svn-id: http://core.svn.wordpress.org/trunk@26632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 20:50:10 +00:00
Andrew Nacin 3964c1f132 Themes: If a theme only has a very-old-school 300px-wide screenshot (or narrower), don't stretch it.
props matveb.
fixes #26459.

Built from https://develop.svn.wordpress.org/trunk@26738


git-svn-id: http://core.svn.wordpress.org/trunk@26627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 19:42:11 +00:00
Matt Thomas 41b8584cd2 Updates to the About page:
* A live color scheme preview
* Replace the hard-coded version number
* Copy edits
* New screenshots
* Size adjustments to the header and WP badge
* Capitalize 'Open Sans'

See #26387, props markoheijnen, ryelle, siobhan, melchoyce.


Built from https://develop.svn.wordpress.org/trunk@26737


git-svn-id: http://core.svn.wordpress.org/trunk@26626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 19:36:11 +00:00
Andrew Nacin 32736c45ff Remove screenshotGallery. see #25948.
Built from https://develop.svn.wordpress.org/trunk@26728


git-svn-id: http://core.svn.wordpress.org/trunk@26617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 17:11:10 +00:00
Andrew Nacin df48cebeb4 No-JavaScript and no-Customizer support for the new Themes screen.
JavaScript is rarely disabled, but graceful degradation is still important. For example, syntax errors can occur, usually with major WP updates that overhaul entire experiences and update external libraries combined with themes or plugins doing weird or old things. If this error is due to their current theme, a user needs to be able to access the themes screen to switch away from the theme. A more subtle issue could make things painful to diagnose.

This commit renders the grid in PHP (the template is duplicated, but it lightweight, fairly mundane, and easy to sync). On Backbone render, the grid is then re-rendered from JavaScript so searches can occur. Customize and Live Preview is disabled if JS fails to kick in. If JS is disabled, old-school "Preview" links are displayed.

No-Customizer support: The customizer is only supported when the browser supports postMessage (IE8+), and if the frontend is a different domain, CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-customize "Preview" links should use .hide-if-customize.

The .load-customize class should be used to declare a link that opens the customizer. This enables customize-loader.js to intercept this link and load the customizer on top of the current window, making for a smoother experience.

fixes #25964.

Built from https://develop.svn.wordpress.org/trunk@26726


git-svn-id: http://core.svn.wordpress.org/trunk@26615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 16:11:10 +00:00
Andrew Ozz 765b617a8c Widgets: jshint cleanup of widgets.js, see #25821.
Built from https://develop.svn.wordpress.org/trunk@26703


git-svn-id: http://core.svn.wordpress.org/trunk@26593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 23:14:09 +00:00
Andrew Nacin d0e4753aef Widgets: Add click-to-add widgets to the bottom (not top) of the target sidebar.
fixes #25821.

Built from https://develop.svn.wordpress.org/trunk@26696


git-svn-id: http://core.svn.wordpress.org/trunk@26586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 22:27:11 +00:00
Andrew Nacin b8882b3511 Widgets: Only scroll to the newly clicked-and-added widget if it is out of the viewport.
props shaunandrews.
see #25821.

Built from https://develop.svn.wordpress.org/trunk@26695


git-svn-id: http://core.svn.wordpress.org/trunk@26585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 22:22:11 +00:00
Andrew Nacin 0617feaa30 Final SVG painter fixes.
* wp.svgPainter and now moved to wp-admin.
 * Restore !important background-image handling.
 * Delay executing the IE9-specific base64 code if we don't need it.
 * Make painted icons lose their color after hover at the same speed as dashicons (100ms).

props azaozz.
fixes #26333.

Built from https://develop.svn.wordpress.org/trunk@26693


git-svn-id: http://core.svn.wordpress.org/trunk@26583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 22:01:10 +00:00
Andrew Nacin e509a66071 Themes: Only show author names during a search if it matches 3 or more characters.
props matveb.
fixes #26422.

Built from https://develop.svn.wordpress.org/trunk@26686


git-svn-id: http://core.svn.wordpress.org/trunk@26576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 19:57:11 +00:00
Andrew Nacin 462d342de1 Themes: when initiating a search, avoid triggering a reset event when it's not necessary.
props matveb.
fixes #26434.

Built from https://develop.svn.wordpress.org/trunk@26685


git-svn-id: http://core.svn.wordpress.org/trunk@26575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 19:15:11 +00:00
Andrew Nacin 21d946cf52 Define globals and add semicolons to wp-fullscreen.js.
`grunt jshint` now runs clean for WordPress core!

props mattwiebe.
fixes #26029.

Built from https://develop.svn.wordpress.org/trunk@26667


git-svn-id: http://core.svn.wordpress.org/trunk@26557 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 16:05:11 +00:00
Andrew Nacin 11715a29b8 Themes: Disable collapse actions when showing only a single theme; improve the responsive layout.
props matveb.
fixes #25962.

Built from https://develop.svn.wordpress.org/trunk@26660


git-svn-id: http://core.svn.wordpress.org/trunk@26550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 04:57:10 +00:00
Andrew Nacin a56aa77d67 Themes: When only one theme is available, show just the details view.
Only one theme may be available when no other themes are allowed (multisite), no other themes are installed, or when the user is denied the switch_themes capability but still has edit_theme_options.

props matveb, markjaquith.
see #25962.

Built from https://develop.svn.wordpress.org/trunk@26652


git-svn-id: http://core.svn.wordpress.org/trunk@26542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 00:16:10 +00:00
Andrew Ozz b0a9fb217a Widgets: on clicking Add, don't move the chooser out of the widget early as that makes is visible at the bottom of the screen. Remove the cloned copy of it instead. Part-props jeremyfelt, fixes #26417.
Built from https://develop.svn.wordpress.org/trunk@26651


git-svn-id: http://core.svn.wordpress.org/trunk@26541 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-05 00:02:11 +00:00
Andrew Ozz 1ae48b7644 DFW: don't block the "keyup" event, fixes toggling the checkbox in the Link dialog with the spacebar. Fixes #25934.
Built from https://develop.svn.wordpress.org/trunk@26649


git-svn-id: http://core.svn.wordpress.org/trunk@26539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 23:51:10 +00:00
Andrew Nacin e6f229c29b Pinking shears. see #26086 props atimmer.
Built from https://develop.svn.wordpress.org/trunk@26627


git-svn-id: http://core.svn.wordpress.org/trunk@26517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 19:34:09 +00:00
Andrew Nacin 7ac1f7916f Return some semicolons. fixes #25594.
Built from https://develop.svn.wordpress.org/trunk@26623


git-svn-id: http://core.svn.wordpress.org/trunk@26513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 19:08:10 +00:00
Andrew Nacin bfc16271ca Nav Menus: Delegate click events for move links.
props ankit.gade.
fixes #25594.

Built from https://develop.svn.wordpress.org/trunk@26613


git-svn-id: http://core.svn.wordpress.org/trunk@26503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 17:10:11 +00:00
Andrew Ozz e6dd5fbf48 Svg-painter:
- Clean up the JS, better names, etc.
- Convert the base64 encode/decode code from jQuery plugin to local use.
- Add missing icon colors for the default theme.
- Make it more error-proof.
Fixes #26333.
Built from https://develop.svn.wordpress.org/trunk@26601


git-svn-id: http://core.svn.wordpress.org/trunk@26491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 04:13:11 +00:00
Helen Hou-Sandí 1a3a45dcef Auto-resize the Quick Draft textarea. props lessbloat, markjaquith, helen. fixes #26053.
Built from https://develop.svn.wordpress.org/trunk@26564


git-svn-id: http://core.svn.wordpress.org/trunk@26455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:35:09 +00:00
Andrew Ozz fda55bd33b Comments moderation screen:
- Don't resize the textarea when replying to long comments.
- Limit the resizing of the textarea when quick-editing long comments to 500px.
Props SergeyBiryukov, fixes #25746.
Built from https://develop.svn.wordpress.org/trunk@26550


git-svn-id: http://core.svn.wordpress.org/trunk@26442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 00:55:10 +00:00
Andrew Ozz 0f20e57329 Heartbeat:
- Bring back heartbeat.interval().
- Rename wp_disable_heartbeat_suspend() to wp_heartbeat_set_suspension().
- Rename the option for disabling suspension from options.suspend to options.suspension.
Fixes #25073.
Built from https://develop.svn.wordpress.org/trunk@26549


git-svn-id: http://core.svn.wordpress.org/trunk@26441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 00:45:10 +00:00
Andrew Nacin 710803793b Simplify the color scheme profile saving JS. see #25858.
Built from https://develop.svn.wordpress.org/trunk@26535


git-svn-id: http://core.svn.wordpress.org/trunk@26427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 19:45:10 +00:00
Dion Hulse c054cdad32 Themes: Bail if the search term matches the currently rendered themes, Fixes the events being clobbered. Props jblz. Fixes #26347
Built from https://develop.svn.wordpress.org/trunk@26521


git-svn-id: http://core.svn.wordpress.org/trunk@26414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 07:16:10 +00:00
Dion Hulse 4829e81966 Themes: Make the Theme Detail view div use more of the available viewport, Fix the Header and Footer in the viewport and only scroll the theme details, Prefix some more theme CSS classes. Props shaunandrews for the initial viewport patch. Fixes #25961, #26192
Built from https://develop.svn.wordpress.org/trunk@26519


git-svn-id: http://core.svn.wordpress.org/trunk@26412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 07:12:09 +00:00
Andrew Ozz 830bcf9957 Make the responsive menu usable with a mouse, fix non-folded and :focus styles, toggle the submenus on touchend/click. Fixes #26086.
Built from https://develop.svn.wordpress.org/trunk@26516


git-svn-id: http://core.svn.wordpress.org/trunk@26409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:19:11 +00:00
Dion Hulse f1f6cec5e8 Themes: For searches, replace the document hash, don't add a new history event for each keypress. See #25948
Built from https://develop.svn.wordpress.org/trunk@26515


git-svn-id: http://core.svn.wordpress.org/trunk@26408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 01:51:09 +00:00
Dion Hulse 527efd828c Themes: We no longer have a delete link on the multi-grid view. See #25948
Built from https://develop.svn.wordpress.org/trunk@26514


git-svn-id: http://core.svn.wordpress.org/trunk@26407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 00:55:09 +00:00
Dion Hulse 707eca46ab Themes: Fix the routing for Themes in a sub-directory (/wp-content/themes/prefix/theme-name/style.css) and navigate to hash-url's for searches. See #25948
Built from https://develop.svn.wordpress.org/trunk@26513


git-svn-id: http://core.svn.wordpress.org/trunk@26406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 00:48:09 +00:00
Andrew Ozz a6ac0bea23 Improve the admin color scheme picker:
- Easier to extend.
- Remove the "drop-down" look, show all choices inline.
- Some PHP and JS cleanup.
Props ryelle, fixes #26336.
Built from https://develop.svn.wordpress.org/trunk@26506


git-svn-id: http://core.svn.wordpress.org/trunk@26400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 19:50:09 +00:00
Dion Hulse d37d97c9c0 Themes: In the detailed view, disable the next/previous buttons when there are no more items. Fixes #26314
Built from https://develop.svn.wordpress.org/trunk@26498


git-svn-id: http://core.svn.wordpress.org/trunk@26392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 05:59:11 +00:00
Dominik Schilling 4d3fd06160 Themes: Add type="search" to search. fixes #26331.
Built from https://develop.svn.wordpress.org/trunk@26481


git-svn-id: http://core.svn.wordpress.org/trunk@26378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 22:20:10 +00:00
Dominik Schilling 326bb3dfea Themes: Search the description too.
props dd32.
fixes #26309.
Built from https://develop.svn.wordpress.org/trunk@26480


git-svn-id: http://core.svn.wordpress.org/trunk@26377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 22:18:10 +00:00
Andrew Ozz 04d8ac5830 Widgets: highlight all drop zones (open and closed sidebars) on starting to drag a widget to indicate "droppability", fixes #26168.
Built from https://develop.svn.wordpress.org/trunk@26474


git-svn-id: http://core.svn.wordpress.org/trunk@26372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 17:58:10 +00:00
Dion Hulse 1a8b4dfced Themes: Add a clearing <br/> to the end of .theme-browser.
This is needed to cause the browser to render .theme-browser's height as it's true height, previously the reported height was 1*.theme which caused the Theme scroller to kick in immediately (as the threshold was less than 0).
See #25981 See #25948

Built from https://develop.svn.wordpress.org/trunk@26468


git-svn-id: http://core.svn.wordpress.org/trunk@26366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 05:17:11 +00:00