c075eec24f
Editor: Ensure latest comments can only be viewed from public posts.
...
Props: poena, xknown.
Built from https://develop.svn.wordpress.org/trunk@47984
git-svn-id: http://core.svn.wordpress.org/trunk@47752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 19:20:11 +00:00
9524b335c7
Bundled Themes: Twenty Twenty and Twenty Nineteen version bump.
...
We are releasing new versions of Twenty Twenty & Twenty Nineteen today thus we need to bump the version.
Props ianbelanger.
Fixes #50359 .
Built from https://develop.svn.wordpress.org/trunk@47952
git-svn-id: http://core.svn.wordpress.org/trunk@47724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:32:06 +00:00
dda0ccdd18
Administration: Add a new filter to extend `set-screen-option`.
...
Props: xknown, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@47951
git-svn-id: http://core.svn.wordpress.org/trunk@47723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:24:51 +00:00
ffc4869c9c
Themes: Ensure a broken theme name is returned properly.
...
Props: sstoqnov.
Built from https://develop.svn.wordpress.org/trunk@47950
git-svn-id: http://core.svn.wordpress.org/trunk@47722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:23:36 +00:00
10e2a50c52
Formatting: Ensure that `wp_validate_redirect()` sanitizes a wider variety of characters.
...
Props: xknow, vortfu.
Built from https://develop.svn.wordpress.org/trunk@47949
git-svn-id: http://core.svn.wordpress.org/trunk@47721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:22:28 +00:00
7e9267567f
Editor: Prevent HTML decoding on by setting the proper editor context.
...
Props: sstoqnov.
Built from https://develop.svn.wordpress.org/trunk@47948
git-svn-id: http://core.svn.wordpress.org/trunk@47720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:21:20 +00:00
2ae3b3b801
Embeds: Ensure that the title attribute is set correctly on embeds.
...
Props xknown.
Built from https://develop.svn.wordpress.org/trunk@47947
git-svn-id: http://core.svn.wordpress.org/trunk@47719 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:20:10 +00:00
1d95eb63a7
Docs: Add missing documentation for the `$group` parameter of `WP_Object_Cache::get_multiple()`.
...
Synchronize documentation between `wp_cache_get_multiple()`, its compat version, and the class method.
See #20875 .
Built from https://develop.svn.wordpress.org/trunk@47944
git-svn-id: http://core.svn.wordpress.org/trunk@47717 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 09:57:09 +00:00
941a31318c
REST API: Fix updating "multiple" meta keys with non-string values.
...
Previously, the REST API would end up deleting each row of metadata and recreating it unnecessarily. This was caused by a type mismatch where the metadata API would always return a string value, and the REST API operated on a typed value.
The REST API now applies the same sanitization and type casting for "multiple" meta keys and "single" meta keys.
Fixes #49339 .
Props renathoc.
Built from https://develop.svn.wordpress.org/trunk@47943
git-svn-id: http://core.svn.wordpress.org/trunk@47716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 02:22:13 +00:00
38352d2c7a
Coding Standards: Cleans up some PHPCS issues introduced in [47938].
...
See #20875 .
Built from https://develop.svn.wordpress.org/trunk@47942
git-svn-id: http://core.svn.wordpress.org/trunk@47715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 22:42:12 +00:00
4e61c5fb0f
Bundled Themes: Twenty Twenty number of replies not translatable.
...
Fixes the issue by removing the single quote from around the `1` in the elseif conditional of the comments template.
Props Parvand, SergeyBiryukov, desrosj, juliobox, Mista-Flo, benjamingosset, audrasjb, opurockey.
Fixes #49058 .
Built from https://develop.svn.wordpress.org/trunk@47941
git-svn-id: http://core.svn.wordpress.org/trunk@47714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 20:02:08 +00:00
32116649cf
Bundled Themes: Twenty Twenty HTML in featured image caption is being escaped.
...
Fixes the issue by replacing `esc_html` with `wp_kses_post` in the caption in featured images.
Props pierlo, JavierCasares, audrasjb.
Fixes #49833 .
Built from https://develop.svn.wordpress.org/trunk@47940
git-svn-id: http://core.svn.wordpress.org/trunk@47713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 19:52:07 +00:00
ae76b79f85
Cache API: Include the `cache-compat` file.
...
This was missed during the prior commit.
See [47938].
Built from https://develop.svn.wordpress.org/trunk@47939
git-svn-id: http://core.svn.wordpress.org/trunk@47712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 19:50:09 +00:00
3e2b649351
Cache API: Introduce `wp_cache_get_multi()`.
...
Many caching backend have support for multiple gets in a single request. This brings that support to core, with a compatability fallback that will loop over requests if needed.
Fixes : #20875 .
Props: nacin, tollmanz, wonderboymusic, ryan, jeremyfelt, spacedmonkey, boonebgorges, dd32, rmccue, ocean90, jipmoors, johnjamesjacoby, tillkruess, donmhico, davidbaumwald, SergeyBiryukov, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47938
git-svn-id: http://core.svn.wordpress.org/trunk@47711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 19:47:13 +00:00
c65334d820
Canonical: Ensure a redirect for posts missing `postname` in a query with an ID.
...
If a site is using `/%post_id%/%postname%/` as permalink structure, and is missing the `postname`, the site won't redirect to the appropriate URL. This change ensure that the redirect happens.
Fixes : #12456 .
Props: Frank.Prendergast, dd32, Otto42, hlanggo, wonderboymusic, atimmer, seth17, calvin_ngan, Niresh12495, anbumz, SergeyBiryukov, donmhico.
Built from https://develop.svn.wordpress.org/trunk@47937
git-svn-id: http://core.svn.wordpress.org/trunk@47710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 19:26:12 +00:00
f5d5b76f6e
Docs: Fix typo in `WP_Widget::__construct()` and `::WP_Widget()` DocBlocks.
...
Props SUM1.
Fixes #50348 .
Built from https://develop.svn.wordpress.org/trunk@47936
git-svn-id: http://core.svn.wordpress.org/trunk@47709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 15:37:10 +00:00
c227ed2322
Docs: Improve documentation for `is_active_sidebar()`.
...
The function determines whether the sidebar contains widgets, not that it is loaded on the page.
Props SUM1.
Fixes #50347 .
Built from https://develop.svn.wordpress.org/trunk@47935
git-svn-id: http://core.svn.wordpress.org/trunk@47708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 15:31:09 +00:00
c681e37da7
Bundled Themes: Twenty Fifteen bulleted list block appears too far to the left in the editor.
...
Fixes the issue by removing unnecessary margin rules for bulleted lists in the editor.
Props kjellr.
Fixes #50029 .
Built from https://develop.svn.wordpress.org/trunk@47934
git-svn-id: http://core.svn.wordpress.org/trunk@47707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 14:10:09 +00:00
644fb1b931
Bundled Themes: Twenty Twenty uses overly specific selector for button background.
...
Fixes the issue by removing `:not(.toogle)` from the `button` selector, as it is not needed.
Props flixos90.
Fixes #50271 .
Built from https://develop.svn.wordpress.org/trunk@47933
git-svn-id: http://core.svn.wordpress.org/trunk@47706 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 13:52:08 +00:00
bbdfffdaa1
Networks and Sites: Ensure the site ID in `wp_insert_site()` is still correct after calling `clean_blog_cache()`.
...
By saving `$wpdb->insert_id` to a variable, we make sure the ID does not change if another database insert is performed on the `clean_site_cache` action.
Props trepmal.
Fixes #50324 .
Built from https://develop.svn.wordpress.org/trunk@47932
git-svn-id: http://core.svn.wordpress.org/trunk@47705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 12:41:09 +00:00
40584118d9
Docs: Document that `get_tags()` returns a `WP_Error` object if any of the specified taxonomies do not exist.
...
Props coffee2code.
Fixes #50344 .
Built from https://develop.svn.wordpress.org/trunk@47930
git-svn-id: http://core.svn.wordpress.org/trunk@47703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-09 11:14:12 +00:00
784908ae5f
Coding Standards: PHP short ternary operator syntax is not allowed.
...
WPCS 2.2.0 added a sniff for detecting short ternary operator syntax, which is not allowed per the Core handbook.
Follow up of [47927].
Fixes #50258 .
Built from https://develop.svn.wordpress.org/trunk@47929
git-svn-id: http://core.svn.wordpress.org/trunk@47702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 21:27:10 +00:00
d1015f46b5
Build/Test Tools: Update the `wp-coding-standards/wpcs` package.
...
This updates the version from 2.1.1 to 2.3.0, the latest version at this time.
Fixes #50258 .
Built from https://develop.svn.wordpress.org/trunk@47927
git-svn-id: http://core.svn.wordpress.org/trunk@47701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 20:11:10 +00:00
c591d94cc5
General: Remove or add inline comments to `$HTTP_RAW_POST_DATA` occurrences.
...
The `$HTTP_RAW_POST_DATA` global was deprecated in PHP 5.6 and removed completely in PHP 7.0. In general, `php://input` should be used instead of `$HTTP_RAW_POST_DATA`.
Because WordPress Core still supports PHP 5.6, some plugins or sites may still rely on this variable being present and populated with the expected data. For that reason, occurrences of the variable will remain with updated inline documentation until support for PHP 5.6 is officially dropped in WordPress.
Props skoskie, jrf, desrosj, TimothyBlynJacobs.
See #49922 .
Fixes #49810 .
Built from https://develop.svn.wordpress.org/trunk@47926
git-svn-id: http://core.svn.wordpress.org/trunk@47700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 19:55:10 +00:00
9e9be350e2
Bundled Themes: Update several package versions in Twenty Twenty and Twenty Nineteen.
...
The following packages received version bumps:
Twenty Twenty
- `concurrently`
- `postcss-cli`
- `rtlcss`
- `stylelint-a11y`
Twenty Nineteen
- `node-sass`
- `postcss-cli`
- `rtlcss`
See #49768 .
Built from https://develop.svn.wordpress.org/trunk@47925
git-svn-id: http://core.svn.wordpress.org/trunk@47699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 18:47:08 +00:00
4adfd75159
Themes: Show a disabled "Activated" button instead of "Activate" for the active theme on Add Themes screen.
...
Additionally, switch the "Live Preview" label for the active theme to "Customize", for consistency with the Themes screen.
Props afercia, SergeyBiryukov.
Fixes #50334 .
Built from https://develop.svn.wordpress.org/trunk@47924
git-svn-id: http://core.svn.wordpress.org/trunk@47698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 18:16:10 +00:00
5efaf888a5
REST API: Support the (min|max)Items JSON Schema keywords.
...
A future commit will add support for the uniqueItems keyword.
Props sorenbronsted.
See #48821 .
Built from https://develop.svn.wordpress.org/trunk@47923
git-svn-id: http://core.svn.wordpress.org/trunk@47697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-07 22:42:13 +00:00
18a9359c06
Posts, Post Types: Display a more specific error message when an attachment could not be inserted into the database.
...
Props shital-patel, Presskopp, ocean90.
Fixes #50325 .
Built from https://develop.svn.wordpress.org/trunk@47922
git-svn-id: http://core.svn.wordpress.org/trunk@47696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-07 09:24:11 +00:00
171356a890
REST API: Add additional fields to the themes controller.
...
When the themes controller was introduced it only returned a theme's supported features. This adds the majority of a theme's header information to the response.
Props ockham, spacedmonkey.
Fixes #49906 .
Built from https://develop.svn.wordpress.org/trunk@47921
git-svn-id: http://core.svn.wordpress.org/trunk@47695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-07 06:46:10 +00:00
6459c0f2ee
Block Editor: Update `wp-includes/assets/script-loader-packages.php`.
...
Follow-up to [47765], [47766].
See #50094 .
Built from https://develop.svn.wordpress.org/trunk@47920
git-svn-id: http://core.svn.wordpress.org/trunk@47694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-07 01:29:12 +00:00
b19c1627e5
Bootstrap/Load: Introduce `wp_get_environment_type()` to retrieve the current environment type.
...
The type can be set via the `WP_ENVIRONMENT_TYPE` global system variable, a constant of the same name, or the `wp_get_environment_type` filter.
Possible values include `development`, `stage`, `production'. If not set, the type defaults to `production`.
Props Clorith, krogsgard, joostdevalk, frank-klein, Maelacuna, nathanrice, grierson, jchristopher, davidvee, jackfungi, johnbillion, tabrisrp, knutsp, ev3rywh3re, Rastaban, danielbachhuber, pfefferle, audrasjb, SergeyBiryukov.
Fixes #33161 .
Built from https://develop.svn.wordpress.org/trunk@47919
git-svn-id: http://core.svn.wordpress.org/trunk@47693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-06 11:07:12 +00:00
0b9a800512
Media: remove any `attachment-filter` query param when switching views.
...
Fix an issue where the media attachment filter no longer worked after switching to list view, filtering by a media type then switching back to the grid view.
Props itzmekhokan, netsurfer2705, zodiac1978.
Fixes #43656 .
Built from https://develop.svn.wordpress.org/trunk@47915
git-svn-id: http://core.svn.wordpress.org/trunk@47689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 21:13:10 +00:00
f546fe5aa5
Networks and Sites: Update the link text for "Debugging a WordPress Network" support article in `ms_not_installed()`.
...
Props Presskopp.
Fixes #50326 .
Built from https://develop.svn.wordpress.org/trunk@47914
git-svn-id: http://core.svn.wordpress.org/trunk@47688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 09:13:08 +00:00
4bbb7fb852
Docs: Update the DocBlock for the `wp_media_attach_action` hook per the documentation standards.
...
Rename the `$att_id` variable to `$attachment_id` for clarity.
Follow-up to [47909].
See #49614 .
Built from https://develop.svn.wordpress.org/trunk@47913
git-svn-id: http://core.svn.wordpress.org/trunk@47687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 08:30:10 +00:00
07a3972bc3
Docs: Fix a typo in the Docker compose file.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47912
git-svn-id: http://core.svn.wordpress.org/trunk@47686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 16:53:09 +00:00
00df557404
REST API: Ensure that all properties of `get_endpoint_args_for_item_schema` are listed.
...
* Add new var $valid_schema_properties to match rest_validate_value_from_schema()
* Unit test to ensure all valid properties exists, and non-valid properties are ignored
Fixes : #50301 .
Props: pentatonicfunk, TimothyBlynJacobs.
Built from https://develop.svn.wordpress.org/trunk@47911
git-svn-id: http://core.svn.wordpress.org/trunk@47685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 16:43:08 +00:00
b013a15d43
Accessibility: Add the `aria-hidden` attribute to the auto-update related icons.
...
`<span>` elements used for displaying icons should use the `aria-hidden` attribute as they are purely decorative.
Props audrasjb, ryokuhi.
Fixes #50293 .
Built from https://develop.svn.wordpress.org/trunk@47910
git-svn-id: http://core.svn.wordpress.org/trunk@47684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 15:47:09 +00:00
00d3696923
Media: Add an action for `wp_media_attach_action`.
...
This action fires when media is attached/detached from a post.
Fixes : #49614 .
Props: jonoaldersonwp, antpb, rebasaurus, donmhico.
Built from https://develop.svn.wordpress.org/trunk@47909
git-svn-id: http://core.svn.wordpress.org/trunk@47683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 15:00:09 +00:00
0eaae8ebbf
Docs: Update type for `WP_Block_Type::$style` property.
...
Follow-up to [47907].
See #48529 .
Built from https://develop.svn.wordpress.org/trunk@47908
git-svn-id: http://core.svn.wordpress.org/trunk@47682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 10:44:10 +00:00
eec4c743fa
Blocks: Update default value for some fields in WP_Block_Type
...
Related to the issue with default values for the blocks registered on the server. By using null for some fields we can treat them as undefined on the client.
See: WordPress/gutenberg#22849.
Props aduth.
Fixes #48529 .
Built from https://develop.svn.wordpress.org/trunk@47907
git-svn-id: http://core.svn.wordpress.org/trunk@47681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 06:07:13 +00:00
b50e87d52b
Docs: Add missing `@global` reference for the `$post_id` global in `wp_admin_bar_edit_menu()`.
...
Follow-up to [47903].
Props davidbaumwald.
See #50312 .
Built from https://develop.svn.wordpress.org/trunk@47906
git-svn-id: http://core.svn.wordpress.org/trunk@47680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:27:09 +00:00
2ef561db67
Build/Test Tools: Revert [47901].
...
This is not matching branches as desired.
Unrops desrosj, jorbin, ocean90, TimothyBlynJacobs.
Fixes #50307 .
Built from https://develop.svn.wordpress.org/trunk@47905
git-svn-id: http://core.svn.wordpress.org/trunk@47679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:14:09 +00:00
df343d59f2
Build/Test: Die with an error if populate_network fails
...
If you are missing WP_TESTS_EMAIL, populate_network will fail and it can be hard to debug. As populate_network can return a wp_error object, we can detect that and display the error to a user.
See: https://github.com/WordPress/gutenberg/pull/22613
Fixes : #50251
Props: TimothyBlynJacobs
Built from https://develop.svn.wordpress.org/trunk@47904
git-svn-id: http://core.svn.wordpress.org/trunk@47678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:04:10 +00:00
524f188982
Toolbar: Display a "View Post" link when viewing comments for a single post on Comments screen.
...
Props Otto42, matt, SergeyBiryukov.
Fixes #50312 .
Built from https://develop.svn.wordpress.org/trunk@47903
git-svn-id: http://core.svn.wordpress.org/trunk@47677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 19:57:10 +00:00
27485fd7aa
General: Continuing to work towards a passing PHP Compatibility scan.
...
This is a final pass to fix PHP compatibiilty issues in the codebase with code changes or adding `phpcs:ignore` comments.
With this change, all PHP compatibility warnings and errors without specific tickets have been addressed (see #49810 and #41750 ).
Props desrosj, johnbillion, jrf.
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47902
git-svn-id: http://core.svn.wordpress.org/trunk@47676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 17:40:12 +00:00
e2790b4e63
Build/Test Tools: Disable Travis CI build Slack notifications for non-official branches.
...
When branches are unintentionally pushed to the GitHub `wordpress-develop` mirror by committers, a build is triggered in Travis and the result is reported in Slack if the criteria defined is met.
Though this is not the desired workflow (any modifications made to the mirror are erased when the repository is synced from SVN), this can cause a lot of noise if several pushes are made and raise false alarms.
This change limits builds only to the `master` branch, and branches meeting the `X.X` pattern to match each branched version.
Props desrosj, jorbin, ocean90, TimothyBlynJacobs.
Fixes #50307 .
Built from https://develop.svn.wordpress.org/trunk@47901
git-svn-id: http://core.svn.wordpress.org/trunk@47675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 17:03:12 +00:00
353def14e2
Docs: Document the `term_order` value for the `orderby` parameter of `WP_Term_Query::__construct()`.
...
Props pbiron.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47898
git-svn-id: http://core.svn.wordpress.org/trunk@47672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 14:41:06 +00:00
5636fb886b
Docs: Reformat the `orderby` section of `WP_Term_Query::__construct()` for better readability.
...
This makes it more consistent with the `fields` section.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47897
git-svn-id: http://core.svn.wordpress.org/trunk@47671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 14:37:09 +00:00
f22e113e95
File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors.
...
Previously, verification was disabled for the loopback request to the admin URL, but not to the home URL.
Follow-up to [46230].
Props munyagu.
Fixes #50309 . See #47957 .
Built from https://develop.svn.wordpress.org/trunk@47896
git-svn-id: http://core.svn.wordpress.org/trunk@47670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 11:43:15 +00:00
683507fe14
External Libraries: Update clipboard.js to 2.0.6.
...
This change includes some bug fixes and removal of the PhantomJS dependency.
Changelog: https://github.com/zenorocha/clipboard.js/compare/v2.0.4...v2.0.6
Props hareesh-pillai.
Fixes #50306 .
Built from https://develop.svn.wordpress.org/trunk@47895
git-svn-id: http://core.svn.wordpress.org/trunk@47669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 11:12:33 +00:00
whyisjake
ianbelanger
Sergey Biryukov
TimothyBlynJacobs
desrosj
Peter Wilson
Adam Silverstein
gziolo
Aaron Jorbin