Commit Graph

69 Commits

Author SHA1 Message Date
John Blackbourn a9e5cfddc7 Implement `wp_login_url()` and `wp_registration_url()` in places where `wp-login.php` is currently hard-coded.
See #31495
Props GregLone

Built from https://develop.svn.wordpress.org/trunk@34213


git-svn-id: http://core.svn.wordpress.org/trunk@34177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 17:11:35 +00:00
Scott Taylor d7d5789088 TwentyFifteen|Sixteen themes have a `<div id="content">` in the header. Change the `<div>` IDs in `wp-activate.php` and `wp-signup.php` to be unique to each page.
Props jfarthing84.
Fixes #33843.

Built from https://develop.svn.wordpress.org/trunk@34162


git-svn-id: http://core.svn.wordpress.org/trunk@34130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 02:09:24 +00:00
Scott Taylor a0e373ef80 For doc block types, favor `bool` over the few remaining `boolean`s
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32964


git-svn-id: http://core.svn.wordpress.org/trunk@32935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-27 01:03:25 +00:00
Scott Taylor f888767c73 `$status` shouldn't be loosely compared to `true` in `wp_xmlrpc_server::wp_deleteComment()`.
`$initial` shouldn't be loosely compared to `true` in `get_calendar()`.
`current_user_can()` shouldn't be loosely compared to `false` in `kses_init()`
`$get_all` shouldn't be loosely compared to `true` in `get_blog_details()`.
`is_array()` and `in_array()` shouldn't be loosely compared in `wpmu_validate_user_signup()`.
`$result` should by strictly compared in `check_ajax_referer()`.
`wp_verify_nonce()` should by strictly compared in `_show_post_preview()`.
`is_user_logged_in()` should not be loosly compared against `false` in `wp-signup.php`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32733


git-svn-id: http://core.svn.wordpress.org/trunk@32704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:48:26 +00:00
Scott Taylor 616c5515ce Improve the `@param` docs for `trackback_response()` and `validate_another_blog_signup()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30662


git-svn-id: http://core.svn.wordpress.org/trunk@30652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 21:23:23 +00:00
Drew Jaynes 4b6abbaff4 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape code snippets in the description for `get_object_taxonomies()`
* Backtick-escape inline code in a markdown-formatted unordered list in the description for `get_taxonomy_labels()`
* Remove an HTML tag from the summary for the `Walker_Category_Checklist` class
* Remove an HTML tag from the summary for `wp_category_checklist()`, various formatting
* Remove an HTML tag from the summary for `wp_terms_checklist()`
* Backtick-escape an HTML tag in the description for `wp_popular_terms_checklist()`
* Remove HTML tags from the summaries for `page_template_dropdown()`, `parent_dropdown()`, and `wp_dropdown_roles()`
* Backtick-escape HTML tags in a parameter description for `add_settings_error()`
* Various formatting in the description and summary for `settings_errors()`
* Markdown-indent code snippets in the descriptions for `wpdb::prepare()`, `wpdb::insert()`, `wpdb::replace()`, `wpdb::update()`, and `wpdb::delete()`
* Backtick-escape an HTML tag in a parameter description for `login_header()`
* Remove HTML tags from the summaries for the `lostpassword_form` and `signup_header` hooks

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30546


git-svn-id: http://core.svn.wordpress.org/trunk@30535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 06:31:21 +00:00
Drew Jaynes f8657d5890 Remove redundant and erroneous `@uses` tag from most core inline documentation.
Per our inline documentation standards, no further use of the `@uses` tag is recommended as used and used-by relationships can be derived through other means. This removes most uses of the tag in core documentation, with remaining tags to be converted to `@global` or `@see` as they apply.

Fixes #30191.

Built from https://develop.svn.wordpress.org/trunk@30105


git-svn-id: http://core.svn.wordpress.org/trunk@30105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-30 01:05:24 +00:00
Drew Jaynes e731028303 Fix syntax for single- and multi-line comments in root-directory files.
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29205


git-svn-id: http://core.svn.wordpress.org/trunk@28989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:12:16 +00:00
John Blackbourn be12ea968a Implement email and url input types where appropriate. Props Kau-Boy. Fixes #22183.
Built from https://develop.svn.wordpress.org/trunk@29030


git-svn-id: http://core.svn.wordpress.org/trunk@28818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-08 17:52:14 +00:00
Scott Taylor 82d6b94cfe Eliminate use of `extract()` in `validate_blog_signup()`:
* `$orig_username` does not need to be pulled from `wpmu_validate_user_signup()` as it is not used in this function.
* `$user` does not need to be pulled from `wpmu_validate_blog_signup()` as it is not used in this function.
* For the `wpmu_validate_user_signup()` portion, rename `$result` and `$errors` to $user_result` and `$user_errors` for disambiguation with the blog values below.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28447


git-svn-id: http://core.svn.wordpress.org/trunk@28274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 14:53:15 +00:00
Scott Taylor bb810c5352 Eliminate use of `extract()` in `validate_user_signup()`.
`$orig_username` does not need to be pulled from `validate_user_form()` as it is not used in this function.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28446


git-svn-id: http://core.svn.wordpress.org/trunk@28273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 14:47:14 +00:00
Scott Taylor ac93f6742e Eliminate use of `extract()` in `validate_another_blog_signup()`.
The extracted variables set/overwrite globals. `$user` does not need to be pulled from `validate_blog_form()` as it is not used in this function.

See #22400.

Built from https://develop.svn.wordpress.org/trunk@28445


git-svn-id: http://core.svn.wordpress.org/trunk@28272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-16 14:43:25 +00:00
Sergey Biryukov 74f77b85a6 Use get_current_site() instead of the $current_site global when possible.
props jeremyfelt.
fixes #25158.
Built from https://develop.svn.wordpress.org/trunk@26120


git-svn-id: http://core.svn.wordpress.org/trunk@26032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 03:23:10 +00:00
Andrew Nacin 5361a8abca Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:59:20 +00:00
Andrew Nacin de7977d66c Move upgrader_process_complete for core to its proper place in Core_Upgrader.
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.

props dd32.
fixes #25659.

Built from https://develop.svn.wordpress.org/trunk@25861


git-svn-id: http://core.svn.wordpress.org/trunk@25861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:23 +00:00
Drew Jaynes 4d1482cd0d Inline documentation for the `WP_Date_Query` class in wp-includes/date.php.
- Adds a complete hash notation for the `WP_Date_Query` arguments array.
- Adds missing documentation for the `date_query_valid_columns` and `get_date_sql` filter hooks.

Props aeg0125 for the incremental patches.
Fixes #25552.

Built from https://develop.svn.wordpress.org/trunk@25860


git-svn-id: http://core.svn.wordpress.org/trunk@25860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:58:12 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Andrew Nacin 74488bdcb0 Spell out duplicate hook locations.
props DrewAPicture.
fixes #25658.

Built from https://develop.svn.wordpress.org/trunk@25868


git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Drew Jaynes 4128a1a170 Inline documentation for hooks in wp-signup.php.
Props kpdesign, miyauchi.

Fixes #25381.

Built from https://develop.svn.wordpress.org/trunk@25645


git-svn-id: http://core.svn.wordpress.org/trunk@25562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-28 23:42:09 +00:00
Andrew Nacin fd57b239d2 Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Andrew Nacin 26193b684b Context for the signup_hidden_fields hooks.
props jeremyfelt, Cimmo.
fixes #19451.

Built from https://develop.svn.wordpress.org/trunk@25600


git-svn-id: http://core.svn.wordpress.org/trunk@25517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 15:51:10 +00:00
Andrew Nacin 656139c09e Have wp-signup.php match the proper default for the 'registration' network option.
props wpmuguru.
fixes #18186.

Built from https://develop.svn.wordpress.org/trunk@25112


git-svn-id: http://core.svn.wordpress.org/trunk@25093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-23 23:00:09 +00:00
Sergey Biryukov 3be755f28b Correct default value and inline description for $meta argument. see #22187.
git-svn-id: http://core.svn.wordpress.org/trunk@24262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-15 17:54:02 +00:00
Andrew Nacin 92b4636e17 Required arguments can't follow optional arguments.
Make required arguments optional in confirm_blog_signup().

Mark arguments as required in _future_post_hook(), the walker method display_element(), get_author_link() (deprecated), and the WP_Widget constructor.

props rlerdorf.
see #24210.



git-svn-id: http://core.svn.wordpress.org/trunk@24126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-29 13:26:31 +00:00
Andrew Nacin c7458f78f8 Adjust some strings in wp-signup.php.
* Remove double space.
 * Remove outer HTML.

props pavelevap, SergeyBiryukov.
fixes #22306.



git-svn-id: http://core.svn.wordpress.org/trunk@24058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-04-22 20:49:24 +00:00
Sergey Biryukov 491f4268b1 Add inline documentation for wp-signup.php. props DrewAPicture. fixes #22187.
git-svn-id: http://core.svn.wordpress.org/trunk@23362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-01-31 03:13:22 +00:00
Andrew Nacin 87c947a987 Use network_site_url() for wp-signup.php. props markjaquith. see #19796.
git-svn-id: http://core.svn.wordpress.org/trunk@21813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 12:27:25 +00:00
Ryan Boren c55cf716da Use set_url_scheme(). Props johnbillion, MarcusPope. see #19037 #20759
git-svn-id: http://core.svn.wordpress.org/trunk@21664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-30 13:33:00 +00:00
nacin 30a15b7c87 Combine two strings. props jiehanzheng. fixes #20500.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-21 06:40:31 +00:00
ryan 1438d03330 Fix notices. Simplify checkbox logic. Props SergeyBiryukov. fixes #19670
git-svn-id: http://svn.automattic.com/wordpress/trunk@19850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-07 17:12:46 +00:00
ryan 81b39f50fb Remove references to specific search engines. fixes #18605
git-svn-id: http://svn.automattic.com/wordpress/trunk@19794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-30 20:51:00 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
ryan 45ddf08e07 Introduce wp_no_robots(). Call it for pages that should never be indexed, regardless of blog privacy settings. Props nacin. fixes #19251
git-svn-id: http://svn.automattic.com/wordpress/trunk@19304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-15 20:44:48 +00:00
ryan 6c81d023bb Add magic get/set/isset methods to WP_User to avoid data duplication. Standardize on WP_User::ID. Props scribu. see #15458
git-svn-id: http://svn.automattic.com/wordpress/trunk@18504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-04 03:09:27 +00:00
nacin fad60afa23 Code readability improvements. props niallkennedy, fixes #17166, #17182, #17231, #16474.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-22 22:30:05 +00:00
nacin 05f5c807ab s/ms-options/settings/. props koke, fixes #15708.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-06 19:26:26 +00:00
ryan b28a8c0061 Markup and gettext fixes. Props sorich87. fixes #14731
git-svn-id: http://svn.automattic.com/wordpress/trunk@16653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 17:31:24 +00:00
nacin 0552424317 Revert submit_button() for wp-includes, setup-config, install, login, signup. see [16061], see #15064, fixes #15247.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-29 00:31:27 +00:00
markjaquith fc6e89da45 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 21:56:43 +00:00
nacin 05fde90357 Move registration.php functions to user.php. Deprecate registration.php, everything is now included by default. fixes #13761.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-27 10:46:24 +00:00
dd32 4f3b9f7b7f Use Absolute URL's & API's in header redirects in more locations. See #14062
git-svn-id: http://svn.automattic.com/wordpress/trunk@16008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-27 10:43:43 +00:00
ryan 81e213c211 Use get_current_user() and get_current_user_id() instead of global . Props filofo. see #13934 for trunk
git-svn-id: http://svn.automattic.com/wordpress/trunk@15315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-24 15:01:29 +00:00
ryan 5ecd1f31f2 Trim trailing whitespace.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-11 20:19:35 +00:00
wpmuguru 4c94266ca0 signup username length consistent with user_login field, props niallkennedy, fixes #13842
git-svn-id: http://svn.automattic.com/wordpress/trunk@15217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-11 15:26:11 +00:00
nacin c7600ab27b Valid HTML for wp-signup. fixes #13369, props ocean90, snumb130.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-10 20:44:54 +00:00
wpmuguru 1c6f95023b strip www before adding subdomain when creating new site
git-svn-id: http://svn.automattic.com/wordpress/trunk@15050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-29 00:32:10 +00:00
nacin c7587d8d1b Fix some typos. props xibe, fixes #13537.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-25 17:53:34 +00:00
westi 574defbee1 Make the signup type in the message for super admins translatable. Fixes #13506.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-23 21:05:04 +00:00
wpmuguru 3c97397d03 use get_blogaddress_by_name in wp-signup, see #12735
git-svn-id: http://svn.automattic.com/wordpress/trunk@14704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 22:36:58 +00:00
wpmuguru 21b2be8975 signup cleanup, props ocean90, fixes #13087
git-svn-id: http://svn.automattic.com/wordpress/trunk@14575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-12 00:45:01 +00:00