2bf5b5749f
Administration: Pull the `table_view_mode` filter for now.
...
The extensibility of list table view modes will be explored in a future release.
Props audrasjb.
See #49715 .
Built from https://develop.svn.wordpress.org/trunk@48668
git-svn-id: http://core.svn.wordpress.org/trunk@48430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:19:03 +00:00
3db534a988
Upgrade/Install: Disable the plugin/theme auto-updates UI if `AUTOMATIC_UPDATER_DISABLED` is defined and set as `true`.
...
Props pbiron, dd32.
Fixes #50798 . See #50280 .
Built from https://develop.svn.wordpress.org/trunk@48667
git-svn-id: http://core.svn.wordpress.org/trunk@48429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:15:03 +00:00
4cfc383544
Upgrade/Install: Check WordPress and PHP version requirements when uploading a plugin or theme from ZIP file.
...
Props mariovalney, desrosj.
See #50593 .
Built from https://develop.svn.wordpress.org/trunk@48666
git-svn-id: http://core.svn.wordpress.org/trunk@48428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 16:07:02 +00:00
0dd2f9f5c5
Docs: Add missing documentation for various upgrade/install class properties and methods.
...
Props ramiy.
Fixes #42923 .
Built from https://develop.svn.wordpress.org/trunk@48661
git-svn-id: http://core.svn.wordpress.org/trunk@48423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:57:03 +00:00
a745f035ab
Themes: Display a message on Themes list table if a theme update requires a higher version of PHP or WordPress.
...
This applies to the Themes screen in Multisite network admin.
Props afragen, SergeyBiryukov.
Fixes #48507 . See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48660
git-svn-id: http://core.svn.wordpress.org/trunk@48422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:34:04 +00:00
e349d92b53
Themes: Include theme name in available update messages, for better accessibility and consistency with other similar messages.
...
Follow-up to [48652-48654].
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48659
git-svn-id: http://core.svn.wordpress.org/trunk@48421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 11:31:01 +00:00
8c3d56919e
Upgrade/Install: Improve `wp_opcache_invalidate()` performance.
...
Changes from using `preg_match()` based `.php` extension checking to using `substr()` in `wp_opcache_invalidate()`.
Props jnylen0, aaroncampbell, SergeyBiryukov, desrosj, mikeschroder.
Fixes #50784 .
Built from https://develop.svn.wordpress.org/trunk@48657
git-svn-id: http://core.svn.wordpress.org/trunk@48419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 08:09:05 +00:00
26b706e27f
Site Health: Incorrect file path in `require_once`.
...
Ensure that background updater can be loaded for testing to see if auto-updates can enable automatic updates.
Fixes #50793 .
Props dd32.
Built from https://develop.svn.wordpress.org/trunk@48655
git-svn-id: http://core.svn.wordpress.org/trunk@48417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 02:21:06 +00:00
db175a9868
Themes: Display a message in theme updates list if an update requires a higher version of PHP or WordPress.
...
This applies to the WordPress Updates screen.
Props afragen, SergeyBiryukov.
Fixes #48491 .
Built from https://develop.svn.wordpress.org/trunk@48654
git-svn-id: http://core.svn.wordpress.org/trunk@48416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 01:02:04 +00:00
ab6c396531
Themes: Correct the logic for displaying a message in theme grid if a theme update requires a higher version of PHP or WordPress.
...
This applies to the Themes screen fallback used when JS is turned off.
Follow-up to [48652].
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48653
git-svn-id: http://core.svn.wordpress.org/trunk@48415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 00:43:02 +00:00
0122e035b0
Themes: Display a message in theme grid and Theme Details modal if a theme update requires a higher version of PHP or WordPress.
...
This applies to the Themes screen and the Customizer theme browser.
Props afragen, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48652
git-svn-id: http://core.svn.wordpress.org/trunk@48414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 00:09:02 +00:00
6307a7c41c
Docs: Correct alignment for some parameters in JS documentation.
...
Follow-up to [48650].
See #43828 .
Built from https://develop.svn.wordpress.org/trunk@48651
git-svn-id: http://core.svn.wordpress.org/trunk@48413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-28 00:07:03 +00:00
3dd9628aae
Build/Test Tools: Enable JSDocs to be linted with ESLint.
...
As part of the [Javascript Inline Docs Initiative](https://make.wordpress.org/core/handbook/docs/inline/js/ ) this add some tooling to lint Javascript docblocks. Two new commands:
* `npm run lint:jsdoc`
* `npm run lint:jsdoc:fix`
The latter will run the linter and try to fix an possible issues automatically.
Fixes #43828 .
Props netweb, atimmer, kamataryo, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48650
git-svn-id: http://core.svn.wordpress.org/trunk@48412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 23:35:02 +00:00
bb54ebcd0d
Administration: Fix the red links on the Media Modal.
...
The custom link colors for admin scheme colors were overriding the danger color.
Props kebbet, dlh.
Fixes #50547 .
Built from https://develop.svn.wordpress.org/trunk@48643
git-svn-id: http://core.svn.wordpress.org/trunk@48405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 19:17:05 +00:00
e071ace6c4
Themes: Display a message in theme grid if a theme requires a higher version of PHP or WordPress.
...
This applies to the Themes screen fallback used when JS is turned off.
Props afragen, desrosj, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48640
git-svn-id: http://core.svn.wordpress.org/trunk@48402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 15:21:02 +00:00
4336a2b9a7
Themes: Display a message in theme grid if a theme requires a higher version of PHP or WordPress.
...
This applies to the Themes screen, Add Themes screen, and the Customizer theme browser.
Props afragen, desrosj, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48638
git-svn-id: http://core.svn.wordpress.org/trunk@48400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 15:04:03 +00:00
39147698d9
Themes: Display a message in Details & Preview modal on Add Themes screen if a theme requires a higher version of PHP or WordPress.
...
Props afragen, desrosj, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48637
git-svn-id: http://core.svn.wordpress.org/trunk@48399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 14:26:07 +00:00
1f89186a3d
Themes: Display a message in Theme Details modal if a theme requires a higher version of PHP or WordPress.
...
Props afragen, desrosj, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@48636
git-svn-id: http://core.svn.wordpress.org/trunk@48398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 13:12:04 +00:00
9ec7f2febd
Docs: Correct `wp_opcache_invalidate_file` filter docs.
...
Changes incorrectly named `$filename` variable to `$filepath` and adjusts wording to align with PHP docs.
See #36455 .
Built from https://develop.svn.wordpress.org/trunk@48632
git-svn-id: http://core.svn.wordpress.org/trunk@48394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-27 09:08:05 +00:00
df74d8f10d
Revisions: Ensure the global `$post` remains the same after revision is restored.
...
Because `wp_insert_post()` and `wp_transition_post_status()` are called during the process, plugins can unexpectedly modify `$post`.
Props markparnell, tofandel, archon810, SergeyBiryukov.
Fixes #46671 .
Built from https://develop.svn.wordpress.org/trunk@48625
git-svn-id: http://core.svn.wordpress.org/trunk@48387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-26 21:25:02 +00:00
a6cf8df9d1
Docs: Synchronize some comments in `wp-admin/revision.php`.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48624
git-svn-id: http://core.svn.wordpress.org/trunk@48386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-26 20:43:02 +00:00
d8c62b5647
Posts, Post Types: Move `get_post_states()` back to the admin for now, require the file in `WP_Customize_Nav_Menus::customize_register()` instead.
...
This provides a minor performance improvement by only running the function in contexts where it's needed.
Follow-up to [47211], [47213], [47763], [48619].
See #46829 , #49374 .
Built from https://develop.svn.wordpress.org/trunk@48620
git-svn-id: http://core.svn.wordpress.org/trunk@48382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-26 10:51:06 +00:00
aab535a576
Posts, Post Types: Make `get_post_states()` available on frontend.
...
This allows special pages to be denoted as such when editing a menu in the Customizer.
This applies to the Front Page, Posts Page, and Privacy Policy Page.
Follow-up to [47211], [47213], [47763].
Props dlh, whyisjake, SergeyBiryukov.
Fixes #46829 . See #49374 .
Built from https://develop.svn.wordpress.org/trunk@48619
git-svn-id: http://core.svn.wordpress.org/trunk@48381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-26 01:14:06 +00:00
609acd89ed
I18N: Merge duplicate "List view" and "Grid view" strings.
...
Props ramiy.
Fixes #50757 .
Built from https://develop.svn.wordpress.org/trunk@48618
git-svn-id: http://core.svn.wordpress.org/trunk@48380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 21:32:05 +00:00
c40a645510
Docs: Correct `@see` references for privacy hooks:
...
* `wp_privacy_personal_data_export_page`
* `wp_privacy_personal_data_erasure_page`
Hooks should be single-quoted when referenced.
Props pbiron, coffee2code.
See #49572 , #meta5318.
Built from https://develop.svn.wordpress.org/trunk@48616
git-svn-id: http://core.svn.wordpress.org/trunk@48378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 19:14:03 +00:00
7d305c8ff9
Docs: Correct `@since` tags for some `WP_List_Table` hooks:
...
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
Follow-up to [15491], [15578], [26401].
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48615
git-svn-id: http://core.svn.wordpress.org/trunk@48377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 18:55:03 +00:00
0ef0a1905b
Docs: Remove outdated statement in `bulk_actions-{$this->screen->id}` filter description.
...
As of WordPress 4.7, developers can register their own bulk actions on list table screens.
Follow-up to [17297], [38647].
Props joyously, pbiron.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48614
git-svn-id: http://core.svn.wordpress.org/trunk@48376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 18:13:02 +00:00
ef382e6aaf
Site Health: Escape the displayed result of the request in REST API availability test.
...
Props siliconforks, gisselfeldt.
Fixes #50588 .
Built from https://develop.svn.wordpress.org/trunk@48608
git-svn-id: http://core.svn.wordpress.org/trunk@48370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-25 15:38:06 +00:00
b6f52721ed
Administration: Use sentence case for "Mark as spam" bulk action links for sites and users, for consistency with comments.
...
Follow-up to [48352].
See #40244 .
Built from https://develop.svn.wordpress.org/trunk@48595
git-svn-id: http://core.svn.wordpress.org/trunk@48357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-24 00:27:03 +00:00
703a978a77
Administration: Capitalize `Trash` consistently in various messages.
...
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.
Follow-up to [47233], [48352].
See #45317 , #40244 .
Built from https://develop.svn.wordpress.org/trunk@48594
git-svn-id: http://core.svn.wordpress.org/trunk@48356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-24 00:21:03 +00:00
9bc7d0a776
Docs: Another pass at some inline docs fixes mostly made by PHPCBF.
...
See #49572 , #50744
Built from https://develop.svn.wordpress.org/trunk@48590
git-svn-id: http://core.svn.wordpress.org/trunk@48352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 21:11:05 +00:00
3f04e3bf5c
I18N: Further adjust some update/install strings for consistency.
...
Follow-up to [48568], [48569].
See #50708 , #50714 .
Built from https://develop.svn.wordpress.org/trunk@48589
git-svn-id: http://core.svn.wordpress.org/trunk@48351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 21:08:01 +00:00
5950e15042
I18N: Merge two "Return to top" strings.
...
Props ramiy, carike, whyisjake.
Fixes #50743 .
Built from https://develop.svn.wordpress.org/trunk@48588
git-svn-id: http://core.svn.wordpress.org/trunk@48350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 20:21:07 +00:00
161821d155
Site Health: Correct the quotes for the `tested` value of mock plugin data in auto-updates test.
...
Follow-up to [48584].
See #50662 .
Built from https://develop.svn.wordpress.org/trunk@48587
git-svn-id: http://core.svn.wordpress.org/trunk@48349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 20:13:05 +00:00
57a3f803ae
Docs: First pass at some inline docs fixes mostly made by PHPCBF.
...
See #49572 , #50744
Built from https://develop.svn.wordpress.org/trunk@48586
git-svn-id: http://core.svn.wordpress.org/trunk@48348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 20:01:04 +00:00
7f898dd9c4
Docs: Use more appropriate variable names in the inline docs for action and filter parameters.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48585
git-svn-id: http://core.svn.wordpress.org/trunk@48347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 19:06:03 +00:00
231d21ebcd
Site Health: Pass all expected parameters to `auto_update_{$type}`.
...
This prevents fatal errors when other hooked functions are expecting both parameters.
Props dd32, desrosj, audrasjb, pbiron.
Fixes #50662 .
Built from https://develop.svn.wordpress.org/trunk@48584
git-svn-id: http://core.svn.wordpress.org/trunk@48346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 19:03:04 +00:00
0eb1b2a447
I18N: Update "Default Template" string to match the sentence case used in the block editor.
...
Props ramiy.
Fixes #50742 .
Built from https://develop.svn.wordpress.org/trunk@48583
git-svn-id: http://core.svn.wordpress.org/trunk@48345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 18:55:01 +00:00
2c2508f98c
General: Ensure the database upgrades from [48575] are run.
...
This corrects the database version to match the commit number the upgrade changes were made.
See #50413 .
Built from https://develop.svn.wordpress.org/trunk@48582
git-svn-id: http://core.svn.wordpress.org/trunk@48344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 18:43:04 +00:00
124972f2c6
Docs: Further corrections and improvements to various inline docblocks.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48576
git-svn-id: http://core.svn.wordpress.org/trunk@48338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 07:39:02 +00:00
6cab8cce22
General: Update code for readability and inclusion
...
There are two pieces in here:
1) The update to change blacklist to blocklist is moved to disallowed_list. "Block" has a meaning in our code, and there could be ambiguity between this code and code related to blocks.
2) This improves backwards compatibility for code that was accessing the now deprecated code.
Previously: [48477], [48405], [48400], [48121], [48122], [48124], [48142], [48566]
Props: desrosj, SergeyBiryukov, johnjamesjacoby
Fixes : #50413
Built from https://develop.svn.wordpress.org/trunk@48575
git-svn-id: http://core.svn.wordpress.org/trunk@48337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 03:14:06 +00:00
0bf9b04c53
Docs: Various formatting improvements to inline docblocks.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48574
git-svn-id: http://core.svn.wordpress.org/trunk@48336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 00:52:05 +00:00
1fbcdb2213
Docs: Various corrections to inline docblocks.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48573
git-svn-id: http://core.svn.wordpress.org/trunk@48335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-23 00:48:06 +00:00
413fae70e8
i18n: Merge similar translation strings in wp-admin/options.php
...
WARNING! is now Warning:
You have been warned.
Fixes #50715 .
Props: ramiy, audrasjb, ocean90.
Built from https://develop.svn.wordpress.org/trunk@48570
git-svn-id: http://core.svn.wordpress.org/trunk@48332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 22:21:03 +00:00
dd642e7b00
i18n: Merge similar translation strings to "Update failed".
...
Fixes #50714 .
Props ramiy, ocean90.
Built from https://develop.svn.wordpress.org/trunk@48569
git-svn-id: http://core.svn.wordpress.org/trunk@48331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 22:10:02 +00:00
921ddab889
I18N: Merge similar "Installation failed" strings
...
Fixes #50708 .
Props ramiy, ocean90, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@48568
git-svn-id: http://core.svn.wordpress.org/trunk@48330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 21:59:05 +00:00
d1517a1ad4
I18N: Update some strings to have periods.
...
Fixes #50707 .
Props ramiy, afercia, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@48567
git-svn-id: http://core.svn.wordpress.org/trunk@48329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 21:55:06 +00:00
2cebcb6144
General: Rename `remove_option_allowed_list()` to `remove_allowed_options()`.
...
This was missed in [48142] which renamed `add_option_allowed_list()` to `add_allowed_options()` for better readability. The two functions should have consistent names.
See #50413 .
Built from https://develop.svn.wordpress.org/trunk@48566
git-svn-id: http://core.svn.wordpress.org/trunk@48328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 18:52:02 +00:00
3db2c3afd4
Upgrade/Install: Don't trigger database upgrade on Ajax requests via `wp-admin/async-upload.php`.
...
Props schlessera, jgrodel, elrae, davidbaumwald, hareesh-pillai, adamsilverstein, SergeyBiryukov.
Fixes #39459 .
Built from https://develop.svn.wordpress.org/trunk@48565
git-svn-id: http://core.svn.wordpress.org/trunk@48327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 12:56:04 +00:00
6f0b8e2b2b
Accessibility: Themes: Consistently use an underline for "Enable auto-updates" link and theme author link in theme overlay.
...
Props chetan200891, sabernhardt, afercia.
Fixes #50697 .
Built from https://develop.svn.wordpress.org/trunk@48564
git-svn-id: http://core.svn.wordpress.org/trunk@48326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 12:19:05 +00:00
1373b2056d
Docs: Correct type for the `$theme` parameter of `theme_auto_update_debug_string` filter.
...
Follow-up to [48546], [48549], [48552].
See #50663 .
Built from https://develop.svn.wordpress.org/trunk@48561
git-svn-id: http://core.svn.wordpress.org/trunk@48323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 00:29:03 +00:00
88e046f1e8
Site Health: Fix some typos in the test for plugin and theme auto-updates.
...
Follow-up to [48548], [48558], [48559].
See #50662 .
Built from https://develop.svn.wordpress.org/trunk@48560
git-svn-id: http://core.svn.wordpress.org/trunk@48322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 00:17:04 +00:00
c6034be779
Site Health: Correct inverted logic for themes in the test for plugin and theme auto-updates.
...
Follow-up to [48548], [48558].
See #50662 .
Built from https://develop.svn.wordpress.org/trunk@48559
git-svn-id: http://core.svn.wordpress.org/trunk@48321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 00:15:02 +00:00
93bf0c3b83
Site Health: Add the test for plugin and theme auto-updates to `WP_Site_Health::get_tests()`.
...
This ensures that the test actually runs.
Follow-up to [48548].
See #50662 .
Built from https://develop.svn.wordpress.org/trunk@48558
git-svn-id: http://core.svn.wordpress.org/trunk@48320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-22 00:07:02 +00:00
a68d462439
Site Health: Use a consistent label for theme auto-updates in debug data.
...
Props audrasjb.
Fixes #50728 .
Built from https://develop.svn.wordpress.org/trunk@48554
git-svn-id: http://core.svn.wordpress.org/trunk@48316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 21:06:02 +00:00
94d4561906
Site Health: Simplify the logic for displaying whether auto-updates are enabled for plugins and themes.
...
Remove some extra variables.
Follow-up to [48546], [48549].
See #50663 .
Built from https://develop.svn.wordpress.org/trunk@48552
git-svn-id: http://core.svn.wordpress.org/trunk@48314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 18:44:04 +00:00
8a58ab36cc
Site Health: Rename the filters added in [48546] for clarity.
...
See #50663 .
Built from https://develop.svn.wordpress.org/trunk@48549
git-svn-id: http://core.svn.wordpress.org/trunk@48311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 17:09:03 +00:00
9d2b92be26
Site Health: Add tests to check for potential issues with plugin and theme auto-updates.
...
Fixes #50662 .
Props desrosj, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@48548
git-svn-id: http://core.svn.wordpress.org/trunk@48310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 17:07:05 +00:00
32f791da49
Site Health: Add auto-update information to for plugins and themes.
...
New filters:
* `plugin_auto_update_debug_str`
* `theme_auto_update_debug_str`
Fixes #50663 .
Props pbiron, audrasjb, davidbaumwald.
Built from https://develop.svn.wordpress.org/trunk@48546
git-svn-id: http://core.svn.wordpress.org/trunk@48308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 16:54:02 +00:00
548df4e3e6
I18N: Add context to some theme strings for consistency.
...
Props ramiy, ocean90.
Fixes #50709 .
Built from https://develop.svn.wordpress.org/trunk@48545
git-svn-id: http://core.svn.wordpress.org/trunk@48307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 16:33:05 +00:00
48841f9ab3
Site Health: Rename `upload_max` array key in file upload checks to `max_effective_size` for clarity.
...
Follow-up to [48535].
See #50038 .
Built from https://develop.svn.wordpress.org/trunk@48544
git-svn-id: http://core.svn.wordpress.org/trunk@48306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 16:20:03 +00:00
1c52ad8d3f
Site Health: Move `post_max_size` and `upload_max_filesize` out of a translatable string in file upload checks.
...
Simplify some other strings, use a consistent format for translator comments.
Follow-up to [48535].
See #50038 .
Built from https://develop.svn.wordpress.org/trunk@48539
git-svn-id: http://core.svn.wordpress.org/trunk@48301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 15:53:04 +00:00
bec9fa5010
Site Health: Remove `parse_ini_size()`, use the existing `wp_convert_hr_to_bytes()` function instead.
...
Follow-up to [48535].
See #50038 .
Built from https://develop.svn.wordpress.org/trunk@48538
git-svn-id: http://core.svn.wordpress.org/trunk@48300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 15:40:03 +00:00
3dda74c337
Editor: Ensure the required assets for the block directory are enqueued.
...
This fixes an issue where the block directory appears unstyled due to the stylesheets not being enqueued.
Props ryelle, timothyblynjacobs, earnjam.
Fixes #50661 .
Built from https://develop.svn.wordpress.org/trunk@48537
git-svn-id: http://core.svn.wordpress.org/trunk@48299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 15:38:03 +00:00
73a8fb4cc3
Site Health: Include new tests to check for the ability to upload files.
...
Several new checks:
* `max_file_uploads`
* `file_uploads`
* `post_max_size`
* `upload_max_filesize`
* `upload_max`
* `max_file_uploads`
In addition, new function `parse_ini_size()` that converts shorthand byte strings to bytes. Useful for size comparisons.
Fixes #50038 .
Props dd32, donmhico, JavierCasares, SergeyBiryukov, ayeshrajans, Clorith, ipstenu, sabernhardt, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48535
git-svn-id: http://core.svn.wordpress.org/trunk@48297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 15:21:02 +00:00
d1822e81ba
Site Health: Use consistent error messages when switching plugin or theme auto-updates on or off.
...
Props ramiy.
Fixes #50721 .
Built from https://develop.svn.wordpress.org/trunk@48534
git-svn-id: http://core.svn.wordpress.org/trunk@48296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 14:42:05 +00:00
9ce7bd633b
Docs: Improve description for `edit_post()`.
...
Props stevenlinx.
Fixes #50713 .
Built from https://develop.svn.wordpress.org/trunk@48529
git-svn-id: http://core.svn.wordpress.org/trunk@48291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 12:49:03 +00:00
de462d2c20
Site Health: Correct the message for snoozed email verifications.
...
Follow-up to [48522].
Fixes #48333 .
Built from https://develop.svn.wordpress.org/trunk@48528
git-svn-id: http://core.svn.wordpress.org/trunk@48290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 12:37:07 +00:00
ec05ee2f5d
Editor: update packages for Beta 3
...
Fixes #50712 .
Built from https://develop.svn.wordpress.org/trunk@48527
git-svn-id: http://core.svn.wordpress.org/trunk@48289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 12:14:37 +00:00
7112440881
Site Health: Ensure that there is a human readable time for snoozed email verifications.
...
This will be the time the was proposed, added to the reminder interval.
Fixes #48333 .
Props SergeyBiryukov, desrosj.
Built from https://develop.svn.wordpress.org/trunk@48522
git-svn-id: http://core.svn.wordpress.org/trunk@48284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 00:43:02 +00:00
5c836585d1
Comments: Don't show the filter/pagination actions if there are no comments to list.
...
It doesn't make sense to be able to filter the comments list table when there are are no (trashed/spam) comments available.
Fixes #40188 .
Props swissspidy, Jim_Panse, menakas, akbarhusen429, dinhtungdu, birgire, SergeyBiryukov, davidbaumwald, rebasaurus, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48521
git-svn-id: http://core.svn.wordpress.org/trunk@48283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-21 00:29:02 +00:00
e4ce35dd11
I18N: Add context to some plugin and theme strings for consistency.
...
Props ramiy, audrasjb.
Fixes #50710 .
Built from https://develop.svn.wordpress.org/trunk@48520
git-svn-id: http://core.svn.wordpress.org/trunk@48282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-20 23:14:05 +00:00
82ce41ff51
I18N: Mark the strings with plugin and theme names in email notifications for translation.
...
Follow-up to [48517].
See #50350 .
Built from https://develop.svn.wordpress.org/trunk@48519
git-svn-id: http://core.svn.wordpress.org/trunk@48281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-20 21:25:06 +00:00
02f200df1d
Administration: Include the new plugin and theme versions in email notifications.
...
This helps administrators keep track of which versions of plugins and themes are running on their site when auto-updates occur.
Props audrasjb, pbiron.
Fixes #50350 .
Built from https://develop.svn.wordpress.org/trunk@48517
git-svn-id: http://core.svn.wordpress.org/trunk@48279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-20 18:28:03 +00:00
efb77b4a65
Upgrade/install: Fix/clarify the "Upload in a zip format" string.
...
Props greenshady, mariovalney.
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48509
git-svn-id: http://core.svn.wordpress.org/trunk@48271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-19 17:11:02 +00:00
c3f787b8ff
Docs: Miscellaneous docblock corrections.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48508
git-svn-id: http://core.svn.wordpress.org/trunk@48270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-18 22:11:02 +00:00
59ee72969d
Plugins: Update the height of the Install Now button for new plugins.
...
Due to Thickbox shenanigans, the buttons height needed to be shrunk a little to center properly in the iframe.
Fixes #49828 .
Props ibachal, Otto42, afercia.
Built from https://develop.svn.wordpress.org/trunk@48503
git-svn-id: http://core.svn.wordpress.org/trunk@48265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-17 06:29:06 +00:00
da7a54d206
Administration: Fix an index inconsistency in `get_admin_page_title()` function.
...
Ensure that `get_admin_page_title()` returns a value from pages registered using `add_menu_page()`.
Fixes #46081 .
Props grapestain, valentinbora, SergeyBiryukov, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@48500
git-svn-id: http://core.svn.wordpress.org/trunk@48262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-16 22:15:07 +00:00
a53b741359
Coding Standards: Update the docblock to remove superflous `since`.
...
The `@deprecated` DocBlock tag should start with the version followed by the description of what to use instead.
Fixes #44959 .
Props keesiemeijer, sabernhardt.
Built from https://develop.svn.wordpress.org/trunk@48495
git-svn-id: http://core.svn.wordpress.org/trunk@48257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-16 21:12:08 +00:00
64a4066874
Upgrade/Install: Check if the theme installer skin's `overwrite` property exists in `Theme_Upgrader::install_strings()`.
...
This ensures consistency with `Plugin_Upgrader::install_strings()` and resolves an issue caused by the property not existing in other upgrader implementations.
Props schlessera, azaozz.
See #50670 .
Built from https://develop.svn.wordpress.org/trunk@48493
git-svn-id: http://core.svn.wordpress.org/trunk@48255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-16 13:19:03 +00:00
9e8d1b1a68
Accessibility: Security: Improves the accessible audible messages for Plugins & Themes Auto-Updates.
...
- changes the politeness level of the two error messages introduced in [47835] to `assertive`
- remove unnecessary `polite` parameters as that's the default value
See #50512 , #50052 .
Built from https://develop.svn.wordpress.org/trunk@48479
git-svn-id: http://core.svn.wordpress.org/trunk@48248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-14 15:46:02 +00:00
fdd88e24ed
General: Rename the `$new_whitelist_options` global variable.
...
This change renames `$new_whitelist_options` to `$new_allowed_options`. This makes the variable’s purpose more clear, and promotes using more inclusive language.
For backwards compatibility, the new variable is passed by reference to the old one.
Follow up to [48121].
Props ayeshrajans, desrosj, jorbin, SergeyBiryukov.
See #50413 .
Fixes #50434 .
Built from https://develop.svn.wordpress.org/trunk@48477
git-svn-id: http://core.svn.wordpress.org/trunk@48246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-14 12:33:02 +00:00
5eb3f0ffcb
Docs: Improve docs for arguments that accept a numerically indexed array of associative arrays.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48475
git-svn-id: http://core.svn.wordpress.org/trunk@48244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-14 12:10:05 +00:00
4ff1233e75
Docs: Correct and improve inline docs for parameters that accept a callback function.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48473
git-svn-id: http://core.svn.wordpress.org/trunk@48242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-14 11:56:04 +00:00
b40e44dd69
Privacy: Set the direction for the "Username or email address" field on privacy screens to LTR.
...
This is consistent with other email inputs across the admin.
Follow-up to [27743], [42967].
Props man4toman, sushyant.
Fixes #50625 .
Built from https://develop.svn.wordpress.org/trunk@48468
git-svn-id: http://core.svn.wordpress.org/trunk@48237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-14 11:17:04 +00:00
02d1cc0fea
Administration: Attempt to even-out the new Up/Down arrows in metabox headings and make them look a bit better. Also group them a little closer together in an attempt to reduce confusion of having two down arrows next to one another. Move the focus outline to the button instead of only the icon.
...
Fixes #39074 .
Built from https://develop.svn.wordpress.org/trunk@48465
git-svn-id: http://core.svn.wordpress.org/trunk@48234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-14 01:37:02 +00:00
6b21db7fb9
Docs: Miscellaneous docblock corrections and improvements.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48462
git-svn-id: http://core.svn.wordpress.org/trunk@48231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-13 22:10:07 +00:00
ac2a1c341d
Customize: Ensure that widgets and nav-menus can be closed after entering content.
...
Previously, the ⌧ button would close the search panel, or remove the results. This restores that, in addition pressing escape will do the same.
Fixes #48198 .
Props garrett-eclipse, tobifjellner, afercia, JavierCasares.
Built from https://develop.svn.wordpress.org/trunk@48461
git-svn-id: http://core.svn.wordpress.org/trunk@48230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-13 20:15:06 +00:00
c7617838b1
Accessibility: Improve reordering of the post boxes in the block editor meta boxes area.
...
Follow-up to [48373].
- ignores hidden "sortables" areas
- hides the reorder buttons when there's only one post box
- makes the reorder buttons slightly bigger to match the side of the toggle button
Fixes #39074 .
Built from https://develop.svn.wordpress.org/trunk@48460
git-svn-id: http://core.svn.wordpress.org/trunk@48229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-13 18:03:05 +00:00
7c09c153d5
Upgrade/Install: Simplify compatibility checks for uploaded plugins and themes for better readability.
...
Use `$new_plugin_data` and `$new_theme_data` as a shorthand for the corresponding `$this->upgrader` properties.
Follow-up to [48390], [48448].
Props afragen.
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48455
git-svn-id: http://core.svn.wordpress.org/trunk@48224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-13 13:35:05 +00:00
63a2cb3060
Upgrade/Install: Use `wp_strip_all_tags()` for the fields in the compare table on the "Update theme/plugin from uploaded zip" screen. Some may contain HTML.
...
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48453
git-svn-id: http://core.svn.wordpress.org/trunk@48222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 20:00:03 +00:00
9848b6b3e9
Plugins: Make delete plugin message less scary.
...
This adds a check if the plugin actually has an uninstall routine before saying that its data will be deleted too.
Props samful, joostdevalk, joyously, Chouby, SergeyBiryukov.
Fixes #50346 .
Built from https://develop.svn.wordpress.org/trunk@48451
git-svn-id: http://core.svn.wordpress.org/trunk@48220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 13:22:04 +00:00
c4543704e2
Administration: Restore the `excerpt` key for the Extended view mode for backward compatibility for now.
...
Props Offereins.
See #49715 .
Built from https://develop.svn.wordpress.org/trunk@48450
git-svn-id: http://core.svn.wordpress.org/trunk@48219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 11:36:04 +00:00
1556ecc000
Docs: Add a `@since` entry for the `$hook_extra` parameter added to `WP_Upgrader::download_package()`.
...
Follow-up to [48399].
See #49686 .
Built from https://develop.svn.wordpress.org/trunk@48449
git-svn-id: http://core.svn.wordpress.org/trunk@48218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 11:02:03 +00:00
707534c2d8
Upgrade/Install: Use `is_php_version_compatible()` and `is_wp_version_compatible()` in plugin and theme requirement checks.
...
Follow-up to [48390].
Props afragen.
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48448
git-svn-id: http://core.svn.wordpress.org/trunk@48217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 10:55:03 +00:00
f83b8775b3
I18N: Move the "WordPress Backups" support URL to its own translatable string.
...
Follow-up to [48390].
See #9757 .
Built from https://develop.svn.wordpress.org/trunk@48447
git-svn-id: http://core.svn.wordpress.org/trunk@48216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 10:34:05 +00:00
3f1650122a
Docs: Miscellaneous DocBlock corrections for plugin and theme updates.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48446
git-svn-id: http://core.svn.wordpress.org/trunk@48215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 01:19:03 +00:00
cecf7b9823
Administration: Handle the result of `Plugin_Upgrader::bulk_upgrade()` for a plugin that is already at the latest version in the same way it is handled for themes.
...
This corrects a fragile check of the result in `wp_ajax_update_plugin()` that depended on the internal array pointer, and brings some consistency with `wp_ajax_update_theme()`.
Follow-up to [37714], [48401].
See #50448 .
Built from https://develop.svn.wordpress.org/trunk@48445
git-svn-id: http://core.svn.wordpress.org/trunk@48214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-12 01:16:05 +00:00
7b61df725e
Revisions: Replace `array_shift()` with `reset()` in `register_and_do_post_meta_boxes()` for better performance.
...
Follow-up to [31829], [48422].
See #34560 .
Built from https://develop.svn.wordpress.org/trunk@48436
git-svn-id: http://core.svn.wordpress.org/trunk@48205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-11 12:30:02 +00:00
a6fed0173d
Themes: Correct closing tag for the "Enable auto-updates" button in the JS template for theme auto-update setting.
...
Follow-up to [48418].
See #50516 .
Built from https://develop.svn.wordpress.org/trunk@48428
git-svn-id: http://core.svn.wordpress.org/trunk@48197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 22:03:04 +00:00
4645084c09
Docs: Improve description for the JS function that hides the update button for expired plugin or theme uploads.
...
Add missing `@since` tag.
Follow-up to [48417].
See #50612 .
Built from https://develop.svn.wordpress.org/trunk@48427
git-svn-id: http://core.svn.wordpress.org/trunk@48196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 21:15:03 +00:00
51856d435b
Administration: Bring some consistency to handling list table view modes.
...
* Remove duplicate variables and DocBlocks.
* Add missing description for the `$mode` global.
* Use sentence case for "Compact view" and "Extended view" labels.
Follow-up to [48398], [48423].
Props afercia, Offereins, SergeyBiryukov.
See #49715 .
Built from https://develop.svn.wordpress.org/trunk@48424
git-svn-id: http://core.svn.wordpress.org/trunk@48193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 16:04:05 +00:00
0f92086ca0
Administration: Make some adjustments to `WP_Screen::render_view_mode()`:
...
* Restore the `$mode` global for backward compatibility.
* Remove redundant check, as `$mode` is already set at this point, and already defaults to `list` via `get_user_setting()`'s second argument.
* Use sentence case for "View mode" and "Extended view" labels.
Follow-up to [48398].
See #49715 .
Built from https://develop.svn.wordpress.org/trunk@48423
git-svn-id: http://core.svn.wordpress.org/trunk@48192 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 16:02:05 +00:00
7d0162bc2e
Revisions: optimize performance when post has large number of revisions.
...
Improve speed and reduce the memory footprint when loading posts with many revisions.
* Use a direct query in `wp_get_post_autosave` to avoid loading all revisions.
* Query for IDs vs full objects in `register_and_do_post_meta_boxes`.
Props pdfernhout, johnnyb, miqrogroove, ocean90, senatorman, DBrumbaugh10Up, martijn-van-der-kooij, pavelevap, mackensen, mikeyarce, whyisjake.
Fixes #34560 .
Built from https://develop.svn.wordpress.org/trunk@48422
git-svn-id: http://core.svn.wordpress.org/trunk@48191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 15:13:07 +00:00
b03053eb2a
Docs: Correct documentation for `customize_controls_head` hook and `_customizer_mobile_viewport_meta()` function.
...
Follow-up to [48412].
See #47369 .
Built from https://develop.svn.wordpress.org/trunk@48420
git-svn-id: http://core.svn.wordpress.org/trunk@48189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 11:36:07 +00:00
edb4943a9d
Administration: Better align labels on the discussion options page.
...
The labels for Comment Moderation, and Comment Blocklist are now aligned properly with the adjacent text.
Fixes #37384 .
Props ankit-k-gupta, karmatosed, FolioVision, desrosj, valentinbora, samful, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48419
git-svn-id: http://core.svn.wordpress.org/trunk@48188 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 06:48:06 +00:00
28a390c2b2
Upgrade/Install: Use ARIA button class on plugin and theme auto-updates action links
...
According to the [accesability guidelines](https://developer.wordpress.org/coding-standards/wordpress-coding-standards/accessibility/#semantics-for-controls ), the control should be a link when JavaScript is not available and a button the rest of the time.
In addition, handlers were added for spacebar usage, and some changes to the a11y speak verbiage.
Fixes #50516 .
Props ryokuhi, audrasjb, afercia, whyisjake/
Built from https://develop.svn.wordpress.org/trunk@48418
git-svn-id: http://core.svn.wordpress.org/trunk@48187 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 06:18:04 +00:00
836ad98276
Upgrade/Install: Ensure cleanup after canceled update.
...
Ensure that the uploaded zip is hidden from the media library, where a task will remove failed installs after two hours.
Fixes #50612 .
Props psykro, desrosj, joyously, azaozz, noisysocks, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48417
git-svn-id: http://core.svn.wordpress.org/trunk@48186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 06:08:06 +00:00
9397ad46ba
Coding Standards: Some missed code formatting.
...
Unprops: whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48415
git-svn-id: http://core.svn.wordpress.org/trunk@48184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-10 01:01:03 +00:00
1158166d9c
Administration: Remove multiple viewport meta tags from mobile pages.
...
In addition, add the `wp_admin_viewport_meta()` function, paired to the `admin_viewport_meta` filter to control attributes of the meta tag.
Fixes #47369 .
Props BettyJJ, mukesh27, SergeyBiryukov, ajayghaghretiya1, msaggiorato, talldanwp, davidbaumwald, donmhico, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@48412
git-svn-id: http://core.svn.wordpress.org/trunk@48181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-09 23:29:08 +00:00
6bf6bc451f
Docs: Miscellaneous DocBlock corrections.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48408
git-svn-id: http://core.svn.wordpress.org/trunk@48177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-08 13:15:03 +00:00
c358ba7112
Upgrade/Install: Prevent the upgrade routine for updating the `comment_type` field in the comments table from running twice.
...
Follow-up to [47597], [48400].
See #50413 , #49236 .
Built from https://develop.svn.wordpress.org/trunk@48405
git-svn-id: http://core.svn.wordpress.org/trunk@48174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-08 10:58:05 +00:00
500508884e
Administration: Fix failing tests as a result of [48397].
...
Because of changes to how PHP handles arrays used in `foreach()` loops in PHP >= 7.0, [48397] resulted in a failing test for PHP 5.6.
This calls `reset()` after using the `$results` array in the `foreach()` to ensure the array is treated the same and as expected.
Props azaozz, desrosj, SergeyBiryukov, xknown.
See #50448 .
Built from https://develop.svn.wordpress.org/trunk@48401
git-svn-id: http://core.svn.wordpress.org/trunk@48170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 20:38:03 +00:00
a8521d48ac
Upgrade/Install: Prevent some 5.5.0 upgrade routines from running twice.
...
This will prevent the options renamed for 5.5.0 from being converted twice. If a new update routine is added before 5.5 is released, the option values would be erased for anyone running `trunk` or nightlies without this change.
Props azaozz, desrosj, SergeyBiryukov, whyisjake.
Fixes #50413 .
Built from https://develop.svn.wordpress.org/trunk@48400
git-svn-id: http://core.svn.wordpress.org/trunk@48169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 19:21:06 +00:00
8381fad76e
Upgrade/Install: Add `hook_extra` parameter to the `upgrader_pre_download` filter.
...
This provides additional context to code running on this hook, including which plugin or theme update will be downloaded. It also brings consistency to this filter with others throughout the upgrade process.
Props obliviousharmony, desrosj.
Fixes #49686 .
Built from https://develop.svn.wordpress.org/trunk@48399
git-svn-id: http://core.svn.wordpress.org/trunk@48168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 19:15:06 +00:00
dcdabb5bb3
Administration: Introduce extensibility to posts and comments list table views, for accessibility purposes.
...
At default, expands the excerpt view to become an extended view. Includes a new `table_view_mode` filter to allow further configuration.
Fixes #49715 .
Props joedolson, audrasjb, afercia, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48398
git-svn-id: http://core.svn.wordpress.org/trunk@48167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 19:12:03 +00:00
48da753ff0
Administration: Prevent repeat emails for identical plugin or theme auto-update attempt failures.
...
This change adds a throttle mechanism to plugin and theme auto-update failure emails using similar logic to the email sent for a Core auto-update.
The first time a plugin or theme auto-update fails, the package and `new_version` will be tracked in the `auto_plugin_theme_update_emails` option. An email for this specific update attempt will not be resent.
However, if this update fails again and non-repeat failures or successful updates are also present, then the failure information will be included in that email (an email needs to be sent for the new events regardless).
Props johnbillion, arpitgshah, desrosj, audrasjb, pbiron, earnjam.
Fixes #50448 .
Built from https://develop.svn.wordpress.org/trunk@48397
git-svn-id: http://core.svn.wordpress.org/trunk@48166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 19:00:02 +00:00
4377e9a44e
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/set-post-thumbnail.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50605 .
Built from https://develop.svn.wordpress.org/trunk@48396
git-svn-id: http://core.svn.wordpress.org/trunk@48165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 18:55:04 +00:00
0dc81cc24f
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/comment.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50604 .
Built from https://develop.svn.wordpress.org/trunk@48395
git-svn-id: http://core.svn.wordpress.org/trunk@48164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 18:40:05 +00:00
291f3d76ec
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/nav-menu.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50603 .
Built from https://develop.svn.wordpress.org/trunk@48394
git-svn-id: http://core.svn.wordpress.org/trunk@48163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 18:31:05 +00:00
ac4f93a5be
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/plugin-install.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50602 .
Built from https://develop.svn.wordpress.org/trunk@48392
git-svn-id: http://core.svn.wordpress.org/trunk@48161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 18:15:03 +00:00
daf060bbd2
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/inline-edit-post.js` and `wp-admin/js/inline-edit-tax.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the scripts and instead adds the translatable strings in the scripts directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50601 .
Built from https://develop.svn.wordpress.org/trunk@48391
git-svn-id: http://core.svn.wordpress.org/trunk@48160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 18:02:05 +00:00
49bbff551b
Upgrade/install: Allow plugin and theme updates from a uploaded .zip file.
...
Props mariovalney, cyberhobo, imath, shaunandrews, mariovalney, earnjam, desrosj, dd32, folletto, swissspidy, melchoyce, pento, joshuawold, psykro, clorith, ahortin, galbaras, pingram3541, joyously, doobeedoo, karmatosed, poena, whyisjake, earnjam, sergeybiryukov, audrasjb, azaozz.
Fixes #9757 .
Built from https://develop.svn.wordpress.org/trunk@48390
git-svn-id: http://core.svn.wordpress.org/trunk@48159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 17:49:05 +00:00
bc15db7b97
Accessibility: Widgets: Further improve spacing between Widgets checkboxes and radio buttons in the admin interface.
...
Follow-up to [47598]:
- further improves the spacing after [47598] by better scoping the CSS to avoid layout glitches for custom widgets
- changes the RSS widget form to wrap the checkboxes in one single paragraph
Ideally, multiple related checkboxes and radio buttons should be grouped within a fieldset element with a legend. This will be addressed in a new Trac ticket.
Props mukesh27, SergeyBiryukov, sabernhardt.
Fixes #49228 .
Built from https://develop.svn.wordpress.org/trunk@48389
git-svn-id: http://core.svn.wordpress.org/trunk@48158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 17:29:04 +00:00
4a21cda313
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/widgets.js`.
...
This removes the usage of `$scripts->add_inline_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Fixes #50600 .
Built from https://develop.svn.wordpress.org/trunk@48387
git-svn-id: http://core.svn.wordpress.org/trunk@48156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 17:01:06 +00:00
2b32883f8b
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/post.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50599 .
Built from https://develop.svn.wordpress.org/trunk@48385
git-svn-id: http://core.svn.wordpress.org/trunk@48154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 16:49:05 +00:00
964c506fb3
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/media.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50597 .
Built from https://develop.svn.wordpress.org/trunk@48384
git-svn-id: http://core.svn.wordpress.org/trunk@48153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 16:14:06 +00:00
7e7b70cd1a
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/color-picker.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50596 .
Built from https://develop.svn.wordpress.org/trunk@48383
git-svn-id: http://core.svn.wordpress.org/trunk@48152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 16:10:05 +00:00
3c41801c5c
Administration: Reinstate the description for the `admin_xml_ns` hook which was accidentally removed in [47771].
...
See #46015 .
Built from https://develop.svn.wordpress.org/trunk@48380
git-svn-id: http://core.svn.wordpress.org/trunk@48149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 14:57:02 +00:00
913f5aaab9
Docs: Correct some `@since` entries added in 5.5.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@48377
git-svn-id: http://core.svn.wordpress.org/trunk@48146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 14:14:04 +00:00
b3f1fa4edc
Administration: Fix remove links color.
...
Fix regression introduced in [48332] where the specificity
of the admin scheme link colors was higher than the remove link colors.
Props afercia.
Fixes #50536 .
Built from https://develop.svn.wordpress.org/trunk@48376
git-svn-id: http://core.svn.wordpress.org/trunk@48145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 13:47:02 +00:00
aee4324b9e
Accessibility: Media: Improve accessibility of the status and error messages in the Image Editor.
...
- improves focus management by moving focus to the notices, if any, or to the first "tabbable" element
- this avoids a focus loss and helps Braille-only and screen magnification users to be aware of the messages
- adds an ARIA role `alert` to all the notices
- uses `wp.a11y.speak()` to announce messages to assistive technology
- this way, all visual users will see the messages while assistive technology users will get an audible message
- uses `wp.i18n` for translatable strings in `wp-admin/js/image-edit.js`
Props anevins, ryanshoover, antpb, SergeyBiryukov, afercia.
See #20491 .
Fixes #47147 .
Built from https://develop.svn.wordpress.org/trunk@48375
git-svn-id: http://core.svn.wordpress.org/trunk@48144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 13:45:02 +00:00
181717c9ab
Plugins: Make sure the HTML ID attributes in plugin action links are unique.
...
Follow-up to [47588].
Props mukesh27, roytanck, SergeyBiryukov.
Fixes #49916 .
Built from https://develop.svn.wordpress.org/trunk@48374
git-svn-id: http://core.svn.wordpress.org/trunk@48143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 13:43:02 +00:00
22d0cd6c96
Accessibility: Allow post boxes on the Dashboard and Classic Editor pages to be reordered by using the keyboard.
...
So far, it has been possible to rearrange into a new order the post boxes (also known as "widgets" on the Dashboard and "meta boxes" on the Edit post page) only by using a pointing device, for example a mouse.
This change adds new controls and functionality to allow the boxes to be rearranged also with the keyboard. Additionally, audible messages are sent to the admin ARIA live region to notify screen reader users of the reorder action result.
Props joedolson, anevins, antpb, audrasjb, xkon, MarcoZ, karmatosed, afercia.
Fixes #39074 .
Built from https://develop.svn.wordpress.org/trunk@48373
git-svn-id: http://core.svn.wordpress.org/trunk@48142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 13:00:02 +00:00
4fbd235b25
Customizer: Adapt the colors to the selected admin scheme colors.
...
Uses the $highlight-color variable to override the hardcoded colors used in the customizer UI.
Props dlh, joen.
Fixes #50547 .
Built from https://develop.svn.wordpress.org/trunk@48371
git-svn-id: http://core.svn.wordpress.org/trunk@48140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 11:30:01 +00:00
afa6bb4f1a
Accessibility: Improve color contrast for the blue links `:hover` state.
...
For a number of years, WordPress has been using a `#00a0d2` blue shade for the links `:hover` state. This blue shade doesn't have a sufficient color contrast with the various (too many) background colors used in the admin interface.
The new `#006799` blue shade is part of the official WordPress color palette and does have a sufficient color contrast with most of the admin backgrounds.
Props ryokuhi, audrasjb, joedolson, mapk.
See #47682 .
Built from https://develop.svn.wordpress.org/trunk@48368
git-svn-id: http://core.svn.wordpress.org/trunk@48137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 10:11:05 +00:00
adb9f003ed
Site Health: Correct translator comment for the message displayed after clicking "remind me later" on the admin email confirmation.
...
Adjust the logic for displaying the message for better readability.
Follow-up to [48359].
See #48333 .
Built from https://develop.svn.wordpress.org/trunk@48363
git-svn-id: http://core.svn.wordpress.org/trunk@48132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 09:20:02 +00:00
b7ed7cb184
Administration: Fix typo in `forms.css` after [46866].
...
A stray `e` made browsers ignore a CSS ruleset preventing select elements from changing color on hover.
Props ryokuhi.
See #48420 .
Fixes #50580 .
Built from https://develop.svn.wordpress.org/trunk@48362
git-svn-id: http://core.svn.wordpress.org/trunk@48131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 07:05:03 +00:00
93b69e27d4
Administration: Ensure that disabled buttons look disabled.
...
This change removes the disabled state from the admin scheme specific styles.
Fixes #48709 .
Props drw158, SergeyBiryukov, afercia, kennethroberson5556, melchoyce, joedolson, valentinbora, audrasjb, larrach, nrqsnchz, youknowriad.
Built from https://develop.svn.wordpress.org/trunk@48360
git-svn-id: http://core.svn.wordpress.org/trunk@48129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 04:21:07 +00:00
aad1fa48ea
Site Health: Ensure that the user will be notified after a successful snooze action.
...
After clicking remind me later, the user is shown an admin notification.
Fixes #48333 .
Props desrosj, sathyapulse, Clorith, azaozz, audrasjb, afragen, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48359
git-svn-id: http://core.svn.wordpress.org/trunk@48128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-07 03:59:02 +00:00
81b809e3d6
Administration: Move more table strings to sentence casing.
...
WordPress as a project has moved largely to sentence casing for UI elements in the admin. This commit moves several string$
* Move to trash
* Mark as spam
* Permanently delete comment
* Approve comment
* In response to
* Bulk actions
* Not spam
* Sumitted on
* Delete permanently
* Add media
* Upload files
* Upload images
* Add media
* Bulk select
* Restore from trash
* Search media
* Attachment details
* Create gallery
* Edit gallery
* Cancel gallery
* Add to gallery
* Image details
* Replace image
* Cancel edit
* Edit image
* Choose image
* Select and crop
* Skip cropping
* Crop image
* Audio details
* Replace audio
* Add audio source
* Video details
* Replace video
* Add video source
* Select poster image
* Add subtitles
* Create audio playlist
* Edit audio playlist.
* Cancel audio playlist
* Create video playlist
* Edit video playlist
* Add to video playlist
* Filter media
Fixes #40244 .
Props afercia, bhargavbhandari90, rcutmore, webzunft, manojlovic, jeremyfelt, desrosj, lschuyler, SergeyBiryukov, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48352
git-svn-id: http://core.svn.wordpress.org/trunk@48121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 21:52:21 +00:00
93662e1d32
I18N: Fix typo in [48348].
...
Props swizzzpidy.
See #50578 .
Built from https://develop.svn.wordpress.org/trunk@48351
git-svn-id: http://core.svn.wordpress.org/trunk@48120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 21:34:04 +00:00
3d95a45675
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/tags-box.js` and `wp-admin/js/tags-suggest.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50579 .
Built from https://develop.svn.wordpress.org/trunk@48350
git-svn-id: http://core.svn.wordpress.org/trunk@48119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 21:00:03 +00:00
1145607a85
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/edit-comments.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50578 .
Built from https://develop.svn.wordpress.org/trunk@48348
git-svn-id: http://core.svn.wordpress.org/trunk@48117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 20:17:02 +00:00
31d93c553a
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/tags.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50577 .
Built from https://develop.svn.wordpress.org/trunk@48347
git-svn-id: http://core.svn.wordpress.org/trunk@48116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 19:47:03 +00:00
163e0ac228
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/theme-plugin-editor.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Fixes #50576 .
Built from https://develop.svn.wordpress.org/trunk@48346
git-svn-id: http://core.svn.wordpress.org/trunk@48115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 19:35:07 +00:00
bc7de32645
Coding Standards: Correct two coding standards issues introduced in [48277] and [48334].
...
See #50504 , #50550 .
Built from https://develop.svn.wordpress.org/trunk@48345
git-svn-id: http://core.svn.wordpress.org/trunk@48114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 19:23:02 +00:00
77af0e5982
Docs: Correct instances of “auto update” with “auto-update” for consistency.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48344
git-svn-id: http://core.svn.wordpress.org/trunk@48113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 19:15:03 +00:00
1fd50f7b2d
Administration: Adapts the secondary buttons colors to the admin schemes.
...
The admin schemes that don't meet the contrast guidelines are excluded from this change.
Props mapk, michaelarestad, mcsf, ocean90.
Closes #50537 .
Built from https://develop.svn.wordpress.org/trunk@48342
git-svn-id: http://core.svn.wordpress.org/trunk@48111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 19:00:04 +00:00
454dab13c1
Accessibility: Administration: Improve the sortable postboxes areas on the Dashboard and Classic Editor pages.
...
- makes the postboxes areas in the Dashboard visible also on large screens
- uses a more meaningful text when all postboxes areas are empty instead of "Drag boxes here"
- restores the ability to drag boxes to the "advanced" area in the Classic Editor page
- makes the postboxes areas in the Classic Editor page visible while dragging so that users have a clue what the available areas are
- improves the color contrast of the postboxes areas while dragging
- uses `wp.i18n` for translatable strings in `wp-admin/js/postbox.js`
Props xkon, karmatosed, audrasjb, ocean90, joedolson, afercia, azaozz.
See #20491 .
Fixes #49288 , #47541 .
Built from https://develop.svn.wordpress.org/trunk@48340
git-svn-id: http://core.svn.wordpress.org/trunk@48109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 18:03:02 +00:00
82487d4b29
Administration: Fix link colors for admin schemes that personalize it using the $link SASS variable.
...
The new "moderne" admin scheme color personalizes the link color using the $link SASS variable.
The link color doesn't apply consistently in the admin to all links, especiall button links.
Fixes #50536 .
Built from https://develop.svn.wordpress.org/trunk@48332
git-svn-id: http://core.svn.wordpress.org/trunk@48101 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 09:25:02 +00:00
8a815f22e7
Privacy: Simplify the logic for updating the meta values for personal data export requests from absolute to relative paths.
...
Follow-up to [48127].
See #44038 .
Built from https://develop.svn.wordpress.org/trunk@48330
git-svn-id: http://core.svn.wordpress.org/trunk@48099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-06 00:34:04 +00:00
87f464c283
Plugins: Use `include_once` instead of `include` in `uninstall_plugin()`, in case the plugin file is already included.
...
Props valchovski, pcfreak30.
Fixes #47796 .
Built from https://develop.svn.wordpress.org/trunk@48326
git-svn-id: http://core.svn.wordpress.org/trunk@48095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-05 20:32:03 +00:00
f14f0c1ddf
XML-RPC: Explicitly unset the reference to the parser resource after calling `xml_parser_free()` to avoid memory leaks in PHP 7.0.0 or higher.
...
Props procifer, ayeshrajans.
Fixes #49700 .
Built from https://develop.svn.wordpress.org/trunk@48322
git-svn-id: http://core.svn.wordpress.org/trunk@48091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-05 15:22:01 +00:00
56afcf2d68
Posts: Provide a HiDPI version for the avatar used in post locked dialogs.
...
Props wpdesk, audrasjb, ocean90.
Fixes #39633 .
Built from https://develop.svn.wordpress.org/trunk@48318
git-svn-id: http://core.svn.wordpress.org/trunk@48087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-05 13:00:07 +00:00
201c7fbf97
Administration: Bring the update nag in line with other admin notices.
...
In addition to more consistent display, this gives it a visible border on the About page.
Props desrosj, nikhilbhansi, afercia, SergeyBiryukov.
Fixes #50372 .
Built from https://develop.svn.wordpress.org/trunk@48316
git-svn-id: http://core.svn.wordpress.org/trunk@48085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-05 11:57:04 +00:00
5b7774722e
Users: Pass the `WP_User` object to the `wpmu_delete_user`, `delete_user`, and `deleted_user` actions.
...
See #43232 .
Built from https://develop.svn.wordpress.org/trunk@48313
git-svn-id: http://core.svn.wordpress.org/trunk@48082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-05 10:57:01 +00:00
e0be0aef8b
Posts, Post Types: Clarify some "Error in deleting" messages, use more specific strings for attachments.
...
Props dingo_d.
See #50546 .
Built from https://develop.svn.wordpress.org/trunk@48312
git-svn-id: http://core.svn.wordpress.org/trunk@48081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-05 10:41:10 +00:00
6adad022e2
Docs: Correct spelling of "backward compatibility" per the Core Contributor Handbook glossary.
...
Follow-up to [45232].
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48302
git-svn-id: http://core.svn.wordpress.org/trunk@48071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 20:42:06 +00:00
db0e0ca245
Coding Standards: Wrap some long lines in `wp-admin/js/site-health.js` per the JS coding standards for better readability.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48301
git-svn-id: http://core.svn.wordpress.org/trunk@48070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 19:56:07 +00:00
d90213bf18
Docs: Replace `@returns` tag in `wp-admin/js/post.js` with `@return`.
...
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead.
Follow-up to [46800], [48232].
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48298
git-svn-id: http://core.svn.wordpress.org/trunk@48067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 19:10:10 +00:00
c65f40956e
Coding Standards: Rename functions in `wp-admin/js/site-health.js` per the JS coding standards.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48297
git-svn-id: http://core.svn.wordpress.org/trunk@48066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 19:09:07 +00:00
2e992505ac
Accessibility: Improve the focus style for Windows High Contrast mode in various parts of the admin interface.
...
Continues the introduction in core of new focus styles dedicated to Windows High Contrast mode. The new styles use a transparent CSS outline.
This change covers some parts of the interface for the meta boxes, Widgets, and the Customizer.
Props joedolson, kjellr, antpb, mikeschroder, Hareesh Pillai.
See #41286 , #45910 .
Fixes #47117 .
Built from https://develop.svn.wordpress.org/trunk@48293
git-svn-id: http://core.svn.wordpress.org/trunk@48062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 10:44:03 +00:00
43cbe21a3e
Administration: Use HTTPS for XHTML Friends Network URL.
...
Props raajtram, jrf, passoniate, bookdude13, sabernhardt, audrasjb.
Fixes #48002 .
Built from https://develop.svn.wordpress.org/trunk@48292
git-svn-id: http://core.svn.wordpress.org/trunk@48061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-04 09:33:01 +00:00
07bce8970a
General: Use HTTPS for the Web Address field example on Edit Link screen.
...
Props raajtram, jrf, passoniate, bookdude13, sabernhardt, audrasjb.
See #48002 .
Built from https://develop.svn.wordpress.org/trunk@48289
git-svn-id: http://core.svn.wordpress.org/trunk@48058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 23:36:03 +00:00
86317e3e85
Media: Show an error message when a `.heic` file is uploaded that this type of files cannot be displayed in a web browser and suggesting to convert to JPEG. The message is shown by using filters, plugins that want to handle uploading of `.heic` files can remove it.
...
Props mattheweppelsheimer, mikeschroder, jeffr0, andraganescu, desrosj, azaozz.
Fixes #42775 .
Built from https://develop.svn.wordpress.org/trunk@48288
git-svn-id: http://core.svn.wordpress.org/trunk@48057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 23:15:03 +00:00
054610e276
Text Changes: Remove use of "normal" in user-facing output.
...
This clarifies some messages referring to Site Health checks and maintenance mode, and makes them more accurate.
Props dartiss.
Fixes #50549 .
Built from https://develop.svn.wordpress.org/trunk@48287
git-svn-id: http://core.svn.wordpress.org/trunk@48056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 21:59:03 +00:00
8e43a329d4
Privacy: Hide views that have a count of 0 on privacy request tables, for consistency with other list tables.
...
Props pbiron, garrett-eclipse, mapk, melchoyce, estelaris.
Fixes #47495 .
Built from https://develop.svn.wordpress.org/trunk@48284
git-svn-id: http://core.svn.wordpress.org/trunk@48053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 16:28:04 +00:00
b8e3d63fdd
Accessibility: Plugins: Accessibility and CSS improvements for the Plugins pages.
...
- improves checkboxes alignment on the "Plugins" page table in the responsive view
- improves spacing between form controls on the "Add Plugins" page in the responsive view
- the layout of the "filter bar" on the "Add Plugins" page is now based on CSS Flexbox
- removes italic type from a paragraph in the "Favorites" page
Props passoniate, garethgillman, maxpertici, audrasjb, sabernhardt, afercia.
See #47327 .
Fixes #49231 .
Built from https://develop.svn.wordpress.org/trunk@48281
git-svn-id: http://core.svn.wordpress.org/trunk@48050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-03 08:51:05 +00:00
bbe8f41de2
Color schemes: Add new modern color scheme option.
...
This PR adds a new color scheme option, which uses a high luminosity blue spot color, almost-black menu, and pure white for menu items.
This helps increase contrast, and bring more consistency with some of the higher contrast colors used in the block editor.
Props joen, ibdz, shaunandrews.
Fixes #50504 .
Built from https://develop.svn.wordpress.org/trunk@48277
git-svn-id: http://core.svn.wordpress.org/trunk@48046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-02 14:55:05 +00:00
07d2c8a4e9
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/privacy-tools.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90, afercia.
See #20491 .
Fixes #50535 .
Built from https://develop.svn.wordpress.org/trunk@48274
git-svn-id: http://core.svn.wordpress.org/trunk@48043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-02 11:11:06 +00:00
2fab13ae3e
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/user-profile.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50527 .
Built from https://develop.svn.wordpress.org/trunk@48270
git-svn-id: http://core.svn.wordpress.org/trunk@48039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 20:38:01 +00:00
77b2440f9f
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/common.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50526 .
Built from https://develop.svn.wordpress.org/trunk@48267
git-svn-id: http://core.svn.wordpress.org/trunk@48036 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 19:50:02 +00:00
45d19872fc
Accessibility: Media: Fix the Image Editor mismatching keyboard focus order and visual reading order.
...
Swaps the DOM order of the two main columns within the admin Image Editor.
When the sequence in which content is presented affects its meaning and the navigation sequences affect meaning or operation, visual order and DOM order must match. See WCAG 2.1 Success Criterion 1.3.2 Meaningful Sequence and Success Criterion 2.4.3 Focus Order.
Props sabernhardt, anevins, audrasjb, afercia.
Fixes #47136 .
Built from https://develop.svn.wordpress.org/trunk@48265
git-svn-id: http://core.svn.wordpress.org/trunk@48034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 14:29:01 +00:00
083134f694
REST API: Introduce plugin management and block directory endpoints.
...
These endpoints facilitate the Block Directory Inserter feature in Gutenberg. Users can now install, activate, deactivate, and delete plugins over the REST API. The block directoryendpoint allows searching for available blocks from the WordPress.org block directory.
Props cklee, talldanwp, noisysocks, joen, soean, youknowriad, dufresnesteven, gziolo, dd32, tellyworth, ryelle, spacedmonkey, TimothyBlynJacobs.
Fixes #50321 .
Built from https://develop.svn.wordpress.org/trunk@48242
git-svn-id: http://core.svn.wordpress.org/trunk@48011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-07-01 04:24:03 +00:00
7ac100615f
Administration: Pass the result of `set-screen-option` filter to the new `set_screen_option_{$option}` filter to ensure backward compatibility.
...
Rename the `$keep` parameter of both filters to `$screen_option` for clarity, update the documentation to better reflect its purpose.
Props Chouby, sswells, SergeyBiryukov.
Fixes #50392 .
Built from https://develop.svn.wordpress.org/trunk@48241
git-svn-id: http://core.svn.wordpress.org/trunk@48010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-30 21:53:03 +00:00
e61075ad2a
Administration: Always show the filters on media and post list tables.
...
Previously, the filters were hidden for single posts or attachments, which could only be achieved by editing the URL manually.
The `is_singular()` check was added long before the list tables were introduced, and appears to no longer serve any purpose in the current code.
As a side effect, this resolves an issue where a non-existing attachment ID in the URL would block further search in Media Library.
Props afercia, tomdude, audrasjb, bencroskery, desrosj, SergeyBiryukov.
Fixes #38221 .
Built from https://develop.svn.wordpress.org/trunk@48240
git-svn-id: http://core.svn.wordpress.org/trunk@48009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-30 20:36:05 +00:00
c4f6669d69
Accessibility: Privacy: Accessibility improvements for the Privacy Policy Guide page.
...
Improves accessibility of the "Copy this section" button and "Return to Top" link:
- uses `setTimeout()` and `clearTimeout()` to properly handle the "Copied!" text
- simplifies the button text by removing the redundant visually hidden text
- fixes the mismatching visual and DOM order of the Copy button and the "Return to Top" link
- improves the "Return to Top" links by providing real page fragment identifiers, when possible
- hides the "Return to Top" up arrow from assistive technologies
- minor coding standards
Props afercia, garrett-eclipse.
See #48463 , #50322 .
Fixes #50335 .
Built from https://develop.svn.wordpress.org/trunk@48234
git-svn-id: http://core.svn.wordpress.org/trunk@48003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-30 13:56:03 +00:00
7a785704c0
Accessibility: Site Health: Improve the "Copy site info" button accessibility.
...
- avoids a focus loss when clicking the "Copy site info" button
- uses `setTimeout()` and `clearTimeout()` to properly handle the "Copied!" text
- minor JavaScript coding standards
Props audrasjb, Clorith, afercia.
See #48463 , #50335 .
Fixes #50322 .
Built from https://develop.svn.wordpress.org/trunk@48233
git-svn-id: http://core.svn.wordpress.org/trunk@48002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-30 13:26:03 +00:00
eebf187963
Accessibility: Media: Add a "Copy URL" button to the attachment File URL fields.
...
For a number of years, various screens in the WordPress admin provided users with a readonly input field to copy the attachment file URL. Manually copying from a readonly field is an annoying task at best even for mouser users. It's a usability and accessibility issue at the same time.
These fields now have a new "Copy URL" button that is easy to use and accessible to everyone.
Props theolg, markdubois, vabrashev, sajjad67, xkon, nrqsnchz, melchoyce, audrasjb, afercia.
See #41612 , #50322 , #50335 .
Fixes #48463 .
Built from https://develop.svn.wordpress.org/trunk@48232
git-svn-id: http://core.svn.wordpress.org/trunk@48001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-30 13:16:04 +00:00
0a805dbee6
Docs: Add a `@since` note to `edit_comment()` about the new return value.
...
Follow-up to [48154].
See #39732 .
Built from https://develop.svn.wordpress.org/trunk@48223
git-svn-id: http://core.svn.wordpress.org/trunk@47992 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-30 01:04:03 +00:00
71244fc29e
Customize: Ensure the default message in `LockedNotification` is set to a string instead of `null`.
...
This avoids a JS error when passing the message to `wp.a11y.speak()` when showing the "changeset is locked" overlay to prevent two users from editing the same changeset simultaneously.
Props dlh.
Fixes #50500 .
Built from https://develop.svn.wordpress.org/trunk@48210
git-svn-id: http://core.svn.wordpress.org/trunk@47979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-29 09:49:05 +00:00
3a6eeef571
Posts, Post Types: Return early from `WP_Posts_List_Table::formats_dropdown()` if the post type does not support post formats.
...
This avoids an unnecessary database query for the `post_format` taxonomy.
Props Chouby.
Fixes #50496 .
Built from https://develop.svn.wordpress.org/trunk@48203
git-svn-id: http://core.svn.wordpress.org/trunk@47972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-28 14:30:07 +00:00
42f06389c0
Security: Improve the wording of messages in `wp_get_auto_update_message()`.
...
Props burhandodhy, johnbillion, apedog.
Fixes #50489 .
Built from https://develop.svn.wordpress.org/trunk@48202
git-svn-id: http://core.svn.wordpress.org/trunk@47971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-28 14:18:03 +00:00
83d20390c6
Networks and Sites: Use a consistent wording when referring to site deletion on Delete Site screen.
...
Props burhandodhy, dartiss.
Fixes #50494 .
Built from https://develop.svn.wordpress.org/trunk@48201
git-svn-id: http://core.svn.wordpress.org/trunk@47970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-28 14:12:02 +00:00
00a40b1ef2
Docs: Capitalize "ID", when referring to a user ID, term ID, etc. in a more consistent way.
...
Follow-up to [48104]
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48200
git-svn-id: http://core.svn.wordpress.org/trunk@47969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-28 14:09:04 +00:00
3336009e34
Docs: Replace "html" and "xhtml" instances in DocBlocks and comments with "HTML" and "XHTML".
...
This ensures consistent capitalization where appropriate.
Props navidos, desrosj.
Fixes #50473 .
Built from https://develop.svn.wordpress.org/trunk@48199
git-svn-id: http://core.svn.wordpress.org/trunk@47968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-28 14:02:06 +00:00
c892c420b7
Docs: Miscellaneous DocBlock corrections.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48198
git-svn-id: http://core.svn.wordpress.org/trunk@47967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-28 11:53:04 +00:00
58ad216087
Docs: Improve documentation for optional parameters per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48197
git-svn-id: http://core.svn.wordpress.org/trunk@47966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-28 11:49:02 +00:00
5c4290f999
I18N: Remove `<kbd>` tag from a translatable string on Edit Post screen.
...
Props ramiy, tobifjellner.
Fixes #48874 .
Built from https://develop.svn.wordpress.org/trunk@48194
git-svn-id: http://core.svn.wordpress.org/trunk@47963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-27 23:02:03 +00:00
abe112c750
Administration: Correct the URL for "Learn more about getting started" link in "Welcome to WordPress" panel.
...
Props hareesh-pillai, johnbillion.
Fixes #50484 .
Built from https://develop.svn.wordpress.org/trunk@48191
git-svn-id: http://core.svn.wordpress.org/trunk@47960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-27 12:45:04 +00:00
3079ab76dc
Administration: Add missing comma to the message in "Post via email" section.
...
Props kinjaldalwadi, sabernhardt.
Fixes #49238 .
Built from https://develop.svn.wordpress.org/trunk@48186
git-svn-id: http://core.svn.wordpress.org/trunk@47955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-26 19:38:06 +00:00
40c389c95e
Docs: Standardize on "Returning a value from the filter" vs. "Passing a value to the filter".
...
The filter is the callback function added with `add_filter()`, therefore the hook passes a value to the filter, and the filter returns a value to change its behaviour.
The documentation is referring to the latter.
Props johnbillion.
See #49572 , #16557 .
Built from https://develop.svn.wordpress.org/trunk@48185
git-svn-id: http://core.svn.wordpress.org/trunk@47954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-26 18:49:09 +00:00
eb9a6c9690
Docs: Miscellaneous docblock improvements.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48184
git-svn-id: http://core.svn.wordpress.org/trunk@47953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-26 18:40:04 +00:00
c0db9a2f3d
Editor: update JavaScript packages
...
Also update default block categories
Props youknowriad, gziolo, aduth.
Fixes #50420 , #50278 .
Built from https://develop.svn.wordpress.org/trunk@48177
git-svn-id: http://core.svn.wordpress.org/trunk@47946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-26 13:33:47 +00:00
16b35340f4
Site Health: Improve the error message displayed when activating a plugin that requires a higher version of PHP or WordPress.
...
This adds some extra details to the message:
* The current PHP or WordPress version.
* The plugin's minimum required PHP or WordPress version.
* A link to the support documentation on how to update PHP.
Props stuffradio, johnbillion, garrett-eclipse, sabernhardt, williampatton, SergeyBiryukov.
Fixes #48245 .
Built from https://develop.svn.wordpress.org/trunk@48172
git-svn-id: http://core.svn.wordpress.org/trunk@47941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-26 00:27:09 +00:00
56342b8e8f
Docs: Replace "AJAX" with "Ajax" in DocBlocks and comments, per the spelling glossary.
...
Props mukesh27, sabernhardt, SergeyBiryukov.
Fixes #50064 .
Built from https://develop.svn.wordpress.org/trunk@48168
git-svn-id: http://core.svn.wordpress.org/trunk@47937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 12:43:07 +00:00
d38a32bfac
Coding Standards: Reformat some long `apply_filters_deprecated()` and `do_action_deprecated()` calls for better readability.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48167
git-svn-id: http://core.svn.wordpress.org/trunk@47936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 12:06:07 +00:00
bfafc0aecb
Administration: Correct and simplify the logic for `asc` and `desc` arguments in `WP_List_Table::get_sortable_columns()`.
...
Setting the initial order didn't work as expected due to reversed logic.
Follow-up to [48151].
See #45089 .
Built from https://develop.svn.wordpress.org/trunk@48165
git-svn-id: http://core.svn.wordpress.org/trunk@47934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 11:35:13 +00:00
178059c1cb
Docs: Improve DocBlocks in `wp-admin/includes/file.php` per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48164
git-svn-id: http://core.svn.wordpress.org/trunk@47933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 09:39:13 +00:00
f8c59f3152
Docs: Synchronize documentation and variable names in `wp_get_(plugin|theme)_file_editable_extensions()` for consistency.
...
Add missing `@since` tag to `wp_get_theme_file_editable_extensions()`.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48163
git-svn-id: http://core.svn.wordpress.org/trunk@47932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 09:31:15 +00:00
5162a10959
Docs: Improve DocBlocks in `wp-admin/includes/class-wp-list-table.php` per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48162
git-svn-id: http://core.svn.wordpress.org/trunk@47931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 08:56:16 +00:00
0792fb37db
Upgrade/Install: Fix Yoda condition in `wp_opcache_invalidate()`.
...
Fixes linting failure due to Yoda condition in `wp_opcache_invalidate()` following [48160].
See #36455 .
Built from https://develop.svn.wordpress.org/trunk@48161
git-svn-id: http://core.svn.wordpress.org/trunk@47930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 07:55:12 +00:00
dd11076dc7
Upgrade/Install: Invalidate OPcache for PHP files during updates.
...
When files are copied into place, check whether opcode invalidation is available and attempt to invalidate to avoid unintended behavior or fatal errors from themes, plugins, or core.
Introduces `wp_opcache_invalidate()` to allow safe invalidation of PHP files from opcode cache, and a filter, `wp_opcache_invalidate_file` to override the behavior.
Replaces the existing calls to `opcache_invalidate()` in the plugin and theme editors to use the new function.
Thanks to jnylen0 for porting over a patch from ClassicPress that provided much of the approach for what is being committed.
Props nigro.simone, dd32, JasWSInc, szepe.viktor, swissspidy, JanR, asalce, Garavani, pavelevap, pputzer, GregLone, benoitchantre, jadonn, doc987, kraftbj, Krstarica, jnylen0, nextendweb, williampatton, ayeshrajans, joostdevalk, stevenkussmaul, boogah, jorbin, mikeschroder.
Fixes #36455 , #50354 .
Built from https://develop.svn.wordpress.org/trunk@48160
git-svn-id: http://core.svn.wordpress.org/trunk@47929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-25 07:15:12 +00:00
6d927e494c
Block Editor: Add the Block Patterns API.
...
Backport WP_Block_Pattern_Categories_Registry, WP_Block_Patterns_Registry
and block patterns registration functions from the Gutenberg repository.
Props ocean90, ellatrix
Fixes #50445 .
Built from https://develop.svn.wordpress.org/trunk@48156
git-svn-id: http://core.svn.wordpress.org/trunk@47925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-24 12:59:11 +00:00
bb7601f6d0
Comments: Allow `wp_update_comment()` to return `WP_Error()`.
...
The `wp_update_comment_data` filter introduced in 4.7 allows comment data to be filtered before it is updated in the database.
The patch aims to handle `WP_Error` as the filter above return value in a similar manner as is done for `wp_new_comment()`.
Fixes #39732 .
Props: enricosorcinelli, swissspidy, gkloveweb, jnylen0, jbpaul17, afercia, SergeyBiryukov, audrasjb, imath, davidbaumwald.
Built from https://develop.svn.wordpress.org/trunk@48154
git-svn-id: http://core.svn.wordpress.org/trunk@47923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-24 00:05:12 +00:00
4f69c150b7
Cache API: Cache the results of `get_uploaded_header_images()`.
...
Fixes #49446 .
Props pbiron, SergeyBiryukov, desrosj.
Built from https://develop.svn.wordpress.org/trunk@48152
git-svn-id: http://core.svn.wordpress.org/trunk@47921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 23:34:06 +00:00
cb553e4747
Administration: Update `WP_List_Table::get_sortable_columns()` to support `asc` and `desc` arguments.
...
This makes the API a little more clear, whereas setting `false` used to mean `asc` and `true` meant `desc`, you can now use those directly, while maintaining back-compat.
Fixes #45089 .
Props Tkama, SergeyBiryukov, shital-patel, desrosj, birgire, davidbaumwald.
Built from https://develop.svn.wordpress.org/trunk@48151
git-svn-id: http://core.svn.wordpress.org/trunk@47920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 23:15:10 +00:00
517f6501df
Security: Don't display the plugin auto-update options for mu-plugins or dropins.
...
They can't be updated, so we shouldn't be showing the buttons.
Fixes #50459 .
Props Chouby, audrasjb, pbiron.
Built from https://develop.svn.wordpress.org/trunk@48149
git-svn-id: http://core.svn.wordpress.org/trunk@47918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 22:58:09 +00:00
ce784f7ad4
I18N: Include placeholder in translator comments in `wp_get_auto_update_message()`.
...
See #50436 , #50052 .
Built from https://develop.svn.wordpress.org/trunk@48148
git-svn-id: http://core.svn.wordpress.org/trunk@47917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 22:30:09 +00:00
8dad73a5b6
Security: Remove unnecessary `DISABLE_WP_CRON` check in plugin and theme automatic updates.
...
Fixes #50436 .
Props johnbillion, audrasjb, bookdude13, pbiron, arpitgshah.
Built from https://develop.svn.wordpress.org/trunk@48147
git-svn-id: http://core.svn.wordpress.org/trunk@47916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 22:24:09 +00:00
840d1c796b
Accessibility: Administration: Give the link to meetup organizer handbook in the WordPress Events and News dashboard widget a more meaningful label.
...
This ensures that the link still makes sense when read out of context by assistive technologies.
Additionally, underline the link per the accessibility coding standards.
Props samful, afercia, williampatton, audrasjb.
Fixes #50338 .
Built from https://develop.svn.wordpress.org/trunk@48146
git-svn-id: http://core.svn.wordpress.org/trunk@47915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 21:53:09 +00:00
a86cfefecb
Accessibility: Privacy: Improve the readability of the removed text in Privacy Policy Guide.
...
Per WCAG 2.0 guidelines, big chunks of italic text should be avoided for better accessibility.
Additionally, replace the legacy `.error` class for "You deactivated this plugin and may no longer need this policy" message with `.notice-info`.
Follow-up to [47147], [48116].
Props afercia, audrasjb.
See #47327 , #44621 .
Built from https://develop.svn.wordpress.org/trunk@48145
git-svn-id: http://core.svn.wordpress.org/trunk@47914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 20:57:11 +00:00
dee326a5e4
Accessibility: Site Health: Make the heading text for site health check issues easier to select in Firefox.
...
Props afercia, sabernhardt, johnbillion, Clorith, audrasjb.
Fixes #50281 .
Built from https://develop.svn.wordpress.org/trunk@48144
git-svn-id: http://core.svn.wordpress.org/trunk@47913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 20:48:10 +00:00
af0df40f6b
Themes: Ensure the Activate button in theme preview overlay on Add Themes screen has a consistent height.
...
Props afercia, pravinparmar2404, Toru, mukesh27.
Fixes #50316 .
Built from https://develop.svn.wordpress.org/trunk@48143
git-svn-id: http://core.svn.wordpress.org/trunk@47912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 20:13:10 +00:00
c5b1a12a55
General: Rename `(add|remove)_option_allowed_list()` to `(add|remove)_allowed_option()`.
...
The new names make the purpose more clear. It also adds consistency with the `$allowed_options` global variable.
Also in this change, the `wp-deprecated` dependency has been removed from the password strength meter in favor of a `window.console.log()` call to avoid adding 3 dependencies for one deprecated notice.
Props SergeyBiryukov, ocean90, desrosj
Fixes #50413 .
Built from https://develop.svn.wordpress.org/trunk@48142
git-svn-id: http://core.svn.wordpress.org/trunk@47911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 18:54:16 +00:00
a918d853aa
Quick/Bulk Edit: Ensure the proper actions is triggered when using the bulk updater.
...
If a user selects the top option, then chooses a different option, the top selection takes precedence. This update gives a new name to the bottom action, ensuring the proper update is carried out.
Fixes 46872.
Props clayray, garrett-eclipse, subrataemfluence.
Built from https://develop.svn.wordpress.org/trunk@48134
git-svn-id: http://core.svn.wordpress.org/trunk@47903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 05:56:08 +00:00
e7f9aca8dd
Editor: Revert [48119].
...
This commit caused the majority of blocks in the block editor to no longer
register as they reference the old category names.
See #50278 .
Built from https://develop.svn.wordpress.org/trunk@48130
git-svn-id: http://core.svn.wordpress.org/trunk@47899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 00:15:11 +00:00
9edf42f215
Administration: Remove unnecessary !important CSS rules from common.css
...
Fixes #47569 .
Props foack, SergeyBiryukov, davidbaumwald, sabernhardt, isabel_brison, audrasjb.
Built from https://develop.svn.wordpress.org/trunk@48129
git-svn-id: http://core.svn.wordpress.org/trunk@47898 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-23 00:01:07 +00:00
f51cb0a7c5
Media: Ensure that uploaded images get a success notification by users with `upload_files` capability.
...
There was an early `wp_die` that was preventing the success notification from being sent in the upload process.
Fixes #44581 .
Props pbiron, mikeschroder, joemcgill, rebasaurus, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48128
git-svn-id: http://core.svn.wordpress.org/trunk@47897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 23:53:09 +00:00
84f39df101
Privacy: Use relative paths for exported personal data.
...
Ensures back-compat while moving to paths off of the /exports directory.
Fixes : #44038 .
Props: allendav, mrTall, desrosj, garrett-eclipse, cameronamcintyre, nmenescardi, xkon, whyisjake, davidbaumwald.
Built from https://develop.svn.wordpress.org/trunk@48127
git-svn-id: http://core.svn.wordpress.org/trunk@47896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 22:40:11 +00:00
f27cb65e1e
Administration: Remove the `xmlns` attribute on the `<html>` tag.
...
The attribute is specific to XHTML and is not needed in HTML5.
Props audrasjb, diddledan, hommealone, joyously, mukesh27, valentinbora, peterwilsoncc, SergeyBiryukov.
Fixes #49126 .
Built from https://develop.svn.wordpress.org/trunk@48126
git-svn-id: http://core.svn.wordpress.org/trunk@47895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 21:26:16 +00:00
89e99f57a2
Site Health: Correct the check of whether the theme directory is writable when the current theme is symlinked into the theme directory.
...
This ensures that the check is done on a sub-directory within `WP_CONTENT_DIR`, rather than outside of `ABSPATH`.
Props pbiron, Clorith.
Fixes #48199 .
Built from https://develop.svn.wordpress.org/trunk@48125
git-svn-id: http://core.svn.wordpress.org/trunk@47894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 20:15:14 +00:00
d0d8ce1adb
Docs: Small inline documentation corrections following [48121].
...
Also, remove the `version` argument from the `wp.deprecated()` call in `password-strength-meter.js`. This argument is for specifying the version a feature will be removed, not when the feature was removed.
Props hareesh-pillai.
Fixes #50413 .
Built from https://develop.svn.wordpress.org/trunk@48124
git-svn-id: http://core.svn.wordpress.org/trunk@47893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 19:09:11 +00:00
35545bee43
Administration: Improve the plugin and theme auto-update emails.
...
This makes several improvements to the emails sent to site admins when plugin and theme auto-updates are attempted.
- Emails are now specifically tailored to the three results (success, failed, or mixed).
- Subject lines and body copy for mixed and failed results now correctly convey the importance of double checking the site in question.
- The site’s URL is now included in all emails.
- When failures occur, links to the Plugins and/or Themes pages in the admin are now included so that site owners can easily take action.
Props audrasjb, desrosj, azaozz, garrett-eclipse, paaljoachim, johnbillion, marybaum, pbiron.
Follow up to [47835].
See #50052 .
Fixes #50268 .
Built from https://develop.svn.wordpress.org/trunk@48123
git-svn-id: http://core.svn.wordpress.org/trunk@47892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 18:18:08 +00:00
acc97eae32
General: Reference the correct database version for 5.5.0 upgrades.
...
Follow up to [48121].
See #50413 .
Built from https://develop.svn.wordpress.org/trunk@48122
git-svn-id: http://core.svn.wordpress.org/trunk@47891 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 17:33:08 +00:00
4b60af1a6a
General: Remove “whitelist” and “blacklist” in favor of more clear and inclusive language.
...
“The WordPress open source community cares about diversity. We strive to maintain a welcoming environment where everyone can feel included.”
With this commit, all occurrences of “whitelist” and “blacklist” (with the single exception of the `$new_whitelist_options` global variable) are removed. A new ticket has been opened to explore renaming the `$new_whitelist_options` variable (#50434 ).
Changing to more specific names or rewording sentences containing these terms not only makes the code more inclusive, but also helps provide clarity. These terms are often ambiguous. What is being blocked or allowed is not always immediately clear. This can make it more difficult for non-native English speakers to read through the codebase.
Words matter. If one contributor feels more welcome because these terms are removed, this was worth the effort.
Props strangerstudios, jorbin, desrosj, joemcgill, timothyblynjacobs, ocean90, ayeshrajans, davidbaumwald, earnjam.
See #48900 , #50434 .
Fixes #50413 .
Built from https://develop.svn.wordpress.org/trunk@48121
git-svn-id: http://core.svn.wordpress.org/trunk@47890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 17:26:13 +00:00
7dbc898342
Plugins: Make the appearance of plugin action links on Add Plugins screen more consistent.
...
This ensures that the "More Details" link does not randomly wrap to a second line depending on the length of the button label above.
Props sabernhardt, kharisblank, Otto42, paresh07.
Fixes #48648 .
Built from https://develop.svn.wordpress.org/trunk@48120
git-svn-id: http://core.svn.wordpress.org/trunk@47889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 15:30:18 +00:00
2349d1f999
Editor: Update default block categories
...
See https://github.com/WordPress/gutenberg/pull/19279 .
Props aduth, gziolo.
Fixes #50278 .
Built from https://develop.svn.wordpress.org/trunk@48119
git-svn-id: http://core.svn.wordpress.org/trunk@47888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 14:07:10 +00:00
29ffb31cb3
Blocks: Add context fields to WP_Block_Type
...
New block context related fields were added as part of https://github.com/WordPress/gutenberg/pull/22686 . This changest backports them to WP_Block_Type class.
Props aduth, spacedmonkey, mcsf, epiqueras.
Fixes #47656 .
Built from https://develop.svn.wordpress.org/trunk@48117
git-svn-id: http://core.svn.wordpress.org/trunk@47886 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-22 10:26:14 +00:00
aa98d37cad
Accessibility: Improve readability by removing unnecessary italic font style.
...
Continues the removal of italic text where unnecessary or where used on whole lines and big chunks of text.
Removes italic type from:
- all the `howto` text e.g. the "Tags" meta box, the "Featured image" meta box, the "Insert/edit link" modal dialog in the Classic Editor
- the Taxonomies list pages
- the edit Taxonomies pages
- the Menus page
- the Settings pages
Props audrasjb.
See #47327 .
Built from https://develop.svn.wordpress.org/trunk@48116
git-svn-id: http://core.svn.wordpress.org/trunk@47885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-21 18:03:10 +00:00
ae447adaf4
I18N: Restore the "Error:" prefix for error messages.
...
Partially reverts [48059] as there's no full consensus on the removal of the text prefix. Further actions should be taken to improve consistency and accessibility of the admin notices. Keeps some improvements to the translatable strings from [48059].
Fixes #47656 .
Built from https://develop.svn.wordpress.org/trunk@48115
git-svn-id: http://core.svn.wordpress.org/trunk@47884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-21 14:00:09 +00:00
19bca10d79
Coding Standards: Replace `echo sprintf()` with `printf()`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48111
git-svn-id: http://core.svn.wordpress.org/trunk@47880 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 13:18:11 +00:00
be16bb9fba
Docs: Remove extra spaces from `@param` tags.
...
Per the documentation standards, `@param` tags should be aligned with each other, but not with the `@return` tag.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48110
git-svn-id: http://core.svn.wordpress.org/trunk@47879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:58:10 +00:00
b16368c268
Docs: Remove `@staticvar` tags from core.
...
The tag was supported in phpDocumentor 1.x, but is no longer supported in 2.x and 3.x.
Usage of static variables is considered an internal implementation detail and has no information value for someone reading the docs.
Props alishanvr, jrf.
Fixes #50426 .
Built from https://develop.svn.wordpress.org/trunk@48109
git-svn-id: http://core.svn.wordpress.org/trunk@47878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:40:12 +00:00
65724cf380
Docs: Correct DocBlock placement for `allow_subdirectory_install` filter.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48108
git-svn-id: http://core.svn.wordpress.org/trunk@47877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:24:08 +00:00
3fb623cf76
Docs: Use a hyphen with the "non" prefix in a more consistent way.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48106
git-svn-id: http://core.svn.wordpress.org/trunk@47875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:16:10 +00:00
26621b3b44
Docs: Miscellaneous DocBlock corrections for plugin and theme installation and updates.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48105
git-svn-id: http://core.svn.wordpress.org/trunk@47874 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:14:09 +00:00
e13c363b17
Docs: Capitalize "ID", when referring to a post ID, term ID, etc. in a more consistent way.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48104
git-svn-id: http://core.svn.wordpress.org/trunk@47873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 12:02:12 +00:00
a576a13246
Docs: Remove an empty line between `@param` and `@return` tags, per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48102
git-svn-id: http://core.svn.wordpress.org/trunk@47871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-20 11:18:09 +00:00
1a77bb81d8
Docs: Remove unnecessary variables names from `@return` tags.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48100
git-svn-id: http://core.svn.wordpress.org/trunk@47869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 22:55:12 +00:00
acb8983ac1
Docs: Corrections and improvements to inline docs related to plugin and theme auto-updates.
...
See #50052 , #49572
Built from https://develop.svn.wordpress.org/trunk@48097
git-svn-id: http://core.svn.wordpress.org/trunk@47866 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 22:17:07 +00:00
82a5d41d9b
Help/About: Move "Learn more: Auto-updates documentation" link about "Support", for consistency with other screens.
...
Follow-up to [48062].
See #50215 .
Built from https://develop.svn.wordpress.org/trunk@48095
git-svn-id: http://core.svn.wordpress.org/trunk@47864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 21:14:08 +00:00
aca919f007
Plugins and Themes Auto-Updates:
...
- Fix displaying of errors on the Themes screen.
- Correct the classes used for the error messages, and use `notice-alt` as notices are mostly shown on a white background.
Props afercia, azaozz.
Fixes #50405 .
Built from https://develop.svn.wordpress.org/trunk@48092
git-svn-id: http://core.svn.wordpress.org/trunk@47859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 16:51:14 +00:00
0050998801
Filesystem API: Expicitly set directory permissions in `WP_Filesystem_SSH2::mkdir()`.
...
This ensures the permissions are correct after a directory is created with `ssh2_sftp_mkdir()`, which appears to be affected by system `umask` settings.
Props bbrdaric.
Fixes #49218 .
Built from https://develop.svn.wordpress.org/trunk@48090
git-svn-id: http://core.svn.wordpress.org/trunk@47857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 10:38:08 +00:00
527696af3b
Coding Standards: Add some space around control structures in `WP_Filesystem_*` classes for consistency and better readability.
...
Additionally, synchronize `$tempfile` and `$temphandle` variable names in `WP_Filesystem_FTPext` and `WP_Filesystem_ftpsockets`.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48089
git-svn-id: http://core.svn.wordpress.org/trunk@47856 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-19 10:36:12 +00:00
1e3d4921fb
Privacy: Revert use relative paths for exported personal data.
...
Tests need to be updated to pass.
See: #44038 .
Unprops: whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48088
git-svn-id: http://core.svn.wordpress.org/trunk@47855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 23:02:10 +00:00
2d514c83d5
Privacy: Use relative paths for exported personal data.
...
Ensures back-compat while moving to paths off of the `/exports` directory.
Fixes : #44038 .
Props: allendav, mrTall, desrosj, garrett-eclipse, cameronamcintyre, nmenescardi, xkon, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48087
git-svn-id: http://core.svn.wordpress.org/trunk@47854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 21:40:14 +00:00
05e28b4d7c
Coding Standards: Use strict comparison for JS fragment in `wp-admin/admin-header.php`.
...
Props subrataemfluence.
Fixes #45810 .
Built from https://develop.svn.wordpress.org/trunk@48083
git-svn-id: http://core.svn.wordpress.org/trunk@47850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 20:08:09 +00:00
8d3075952e
Administration: Combine the styles for `<p>` and `.wp-die-message`, instead of duplicating.
...
This brings some consistency with `_default_wp_die_handler()`, where they are already combined.
Follow-up to [45909].
See #47580 .
Built from https://develop.svn.wordpress.org/trunk@48082
git-svn-id: http://core.svn.wordpress.org/trunk@47849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 15:07:11 +00:00
d61790f9dc
Fix empty line phpcs error.
...
See #50280 .
Built from https://develop.svn.wordpress.org/trunk@48078
git-svn-id: http://core.svn.wordpress.org/trunk@47845 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 00:46:09 +00:00
7757ad5e94
Plugins and Themes Auto-Updates: allow overriding of the HTML for the auto-update setting link. This will let plugins show better/specific information when they are overriding the auto-update settings, for example "Updates are managed by ... plugin".
...
Introduces: `theme_auto_update_setting_html`, `plugin_auto_update_setting_html`, and `theme_auto_update_setting_template` filters.
Props audrasjb, pbiron, azaozz.
Fixes #50280 .
Built from https://develop.svn.wordpress.org/trunk@48077
git-svn-id: http://core.svn.wordpress.org/trunk@47844 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-18 00:00:13 +00:00
cb72d22d67
Menus: Check the correct variable in `Walker_Nav_Menu_Edit::start_el()` when menu item is a taxonomy term.
...
Follow-up to [45891].
Props ashour.
Fixes #50415 .
Built from https://develop.svn.wordpress.org/trunk@48076
git-svn-id: http://core.svn.wordpress.org/trunk@47843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-17 19:47:14 +00:00
689fdc6319
Site Health: Verify PHP version requirements when auto-updating themes.
...
Follow up of [47819].
See #49653 .
Fixes #50411 .
Built from https://develop.svn.wordpress.org/trunk@48071
git-svn-id: http://core.svn.wordpress.org/trunk@47838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-17 14:48:07 +00:00
de59ad23a4
Docs: Consistently include an empty line between `@since` tag and `@see`, `@link`, or `@global`, per the documentation standards.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@48067
git-svn-id: http://core.svn.wordpress.org/trunk@47834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 21:07:14 +00:00
49edaea6f1
Coding Standards: Fix WPCS issues in `wp-admin/nav-menus.php`.
...
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48063
git-svn-id: http://core.svn.wordpress.org/trunk@47830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 18:38:08 +00:00
97e2b94f84
Help/About: Add help tabs to provide informations about plugin & themes auto-updates.
...
Adds language around how the feature works and includes links to the WordPress HelpHub pages.
Fixes : #50215 .
Props: audrasjb, garrett-eclipse, paaljoachim, marybaum, pbiron, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@48062
git-svn-id: http://core.svn.wordpress.org/trunk@47829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 17:29:07 +00:00
f83c504b88
I18N: Remove the "Error:" prefix from error messages.
...
For a number of years, most of the WordPress error messages have been prefixed with "Error:". However, these messages appear in a context where it's already clear an error occurred. Whether it's an error, a warning, or any other classification, that's not so relevant for users. The content of the message is the relevant part. The "Error:" prefix doesn't add great value while it does add unnecessary complexity for the message readability.
Also, revises some of these messages to improve clarity and removes HTML from translatable strings.
Props garrett-eclipse, ramiy, SergeyBiryukov, afercia, sabernhardt, quadthemes, audrasjb.
See #47003 , #43037 , #42945 , #15887 .
Fixes #47656 .
Built from https://develop.svn.wordpress.org/trunk@48059
git-svn-id: http://core.svn.wordpress.org/trunk@47826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 15:35:13 +00:00
ccf534dc48
Code Standards: Cleanup some code spacing.
...
See: #37826 and #44286 .
Built from https://develop.svn.wordpress.org/trunk@48052
git-svn-id: http://core.svn.wordpress.org/trunk@47819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-16 00:56:08 +00:00
d3c44a690d
Menus: Provide menu settings when creating a new menu.
...
This simplifies the steps in the process of adding new menus.
Props: garrett-eclipse, audrasjb, ianjvr.
Built from https://develop.svn.wordpress.org/trunk@48051
git-svn-id: http://core.svn.wordpress.org/trunk@47818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 23:22:06 +00:00
28d29b35f7
Comments: Don't display edit links to trashed post comments.
...
If a post is in the trash, the comments bubble won't link to the comments list.
Fixes : #37826 .
Props: swissspidy, helen, FolioVision, DrewAPicture, stevenlinx, donmhico, birgire, garrett-eclipse, andraganescu, johnbillion.
Built from https://develop.svn.wordpress.org/trunk@48050
git-svn-id: http://core.svn.wordpress.org/trunk@47817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 23:06:08 +00:00
6aa5788189
Text Changes: Replace "Webmaster" in output messages with more appropriate terms:
...
* "All at `###SITENAME###`" in `wp-admin/ms-delete-site.php`, for consistency with other Multisite emails.
* "Site admin" in `register_new_user()`, for clarity.
Props Presskopp, marybaum.
Fixes #50394 .
Built from https://develop.svn.wordpress.org/trunk@48049
git-svn-id: http://core.svn.wordpress.org/trunk@47816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-15 19:41:11 +00:00
893c580831
Users: On the 'Add New User' screen, don't show the roles dropdown if the current user can't promote other users.
...
Fixes #50345 .
Built from https://develop.svn.wordpress.org/trunk@48042
git-svn-id: http://core.svn.wordpress.org/trunk@47809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-14 17:03:10 +00:00
9f7a7f8d57
Coding Standards: Fix code indentation in `post_submit_meta_box()` to improve readability.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@48041
git-svn-id: http://core.svn.wordpress.org/trunk@47808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-14 16:31:08 +00:00
04200b39ce
Themes: Ensure the theme slug is set before checking if the theme is installed or active.
...
This fixes an issue with every installed theme being marked as active on Themes screen.
The slug is set on Add Themes screen, but not on Themes.
Follow-up to [47924].
Props BackuPs, mukesh27, SergeyBiryukov.
Fixes #50381 . See #50334 .
Built from https://develop.svn.wordpress.org/trunk@48037
git-svn-id: http://core.svn.wordpress.org/trunk@47804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-13 14:26:07 +00:00
4cc11cdbdd
Filesystem API: Avoid a PHP notice in `WP_Filesystem_Direct::owner()` and `::group()` methods and their `WP_Filesystem_SSH2` counterparts.
...
Although not officially documented in the PHP manual, `posix_getpwuid()` and `posix_getgrgid()` can return `false` in some circumstances.
Props logig.
Fixes #50373 .
Built from https://develop.svn.wordpress.org/trunk@48031
git-svn-id: http://core.svn.wordpress.org/trunk@47798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-12 12:35:09 +00:00
dda0ccdd18
Administration: Add a new filter to extend `set-screen-option`.
...
Props: xknown, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@47951
git-svn-id: http://core.svn.wordpress.org/trunk@47723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:24:51 +00:00
ffc4869c9c
Themes: Ensure a broken theme name is returned properly.
...
Props: sstoqnov.
Built from https://develop.svn.wordpress.org/trunk@47950
git-svn-id: http://core.svn.wordpress.org/trunk@47722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:23:36 +00:00
7e9267567f
Editor: Prevent HTML decoding on by setting the proper editor context.
...
Props: sstoqnov.
Built from https://develop.svn.wordpress.org/trunk@47948
git-svn-id: http://core.svn.wordpress.org/trunk@47720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-10 17:21:20 +00:00
784908ae5f
Coding Standards: PHP short ternary operator syntax is not allowed.
...
WPCS 2.2.0 added a sniff for detecting short ternary operator syntax, which is not allowed per the Core handbook.
Follow up of [47927].
Fixes #50258 .
Built from https://develop.svn.wordpress.org/trunk@47929
git-svn-id: http://core.svn.wordpress.org/trunk@47702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 21:27:10 +00:00
4adfd75159
Themes: Show a disabled "Activated" button instead of "Activate" for the active theme on Add Themes screen.
...
Additionally, switch the "Live Preview" label for the active theme to "Customize", for consistency with the Themes screen.
Props afercia, SergeyBiryukov.
Fixes #50334 .
Built from https://develop.svn.wordpress.org/trunk@47924
git-svn-id: http://core.svn.wordpress.org/trunk@47698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-08 18:16:10 +00:00
18a9359c06
Posts, Post Types: Display a more specific error message when an attachment could not be inserted into the database.
...
Props shital-patel, Presskopp, ocean90.
Fixes #50325 .
Built from https://develop.svn.wordpress.org/trunk@47922
git-svn-id: http://core.svn.wordpress.org/trunk@47696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-07 09:24:11 +00:00
0b9a800512
Media: remove any `attachment-filter` query param when switching views.
...
Fix an issue where the media attachment filter no longer worked after switching to list view, filtering by a media type then switching back to the grid view.
Props itzmekhokan, netsurfer2705, zodiac1978.
Fixes #43656 .
Built from https://develop.svn.wordpress.org/trunk@47915
git-svn-id: http://core.svn.wordpress.org/trunk@47689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 21:13:10 +00:00
4bbb7fb852
Docs: Update the DocBlock for the `wp_media_attach_action` hook per the documentation standards.
...
Rename the `$att_id` variable to `$attachment_id` for clarity.
Follow-up to [47909].
See #49614 .
Built from https://develop.svn.wordpress.org/trunk@47913
git-svn-id: http://core.svn.wordpress.org/trunk@47687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-05 08:30:10 +00:00
b013a15d43
Accessibility: Add the `aria-hidden` attribute to the auto-update related icons.
...
`<span>` elements used for displaying icons should use the `aria-hidden` attribute as they are purely decorative.
Props audrasjb, ryokuhi.
Fixes #50293 .
Built from https://develop.svn.wordpress.org/trunk@47910
git-svn-id: http://core.svn.wordpress.org/trunk@47684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 15:47:09 +00:00
00d3696923
Media: Add an action for `wp_media_attach_action`.
...
This action fires when media is attached/detached from a post.
Fixes : #49614 .
Props: jonoaldersonwp, antpb, rebasaurus, donmhico.
Built from https://develop.svn.wordpress.org/trunk@47909
git-svn-id: http://core.svn.wordpress.org/trunk@47683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-04 15:00:09 +00:00
b50e87d52b
Docs: Add missing `@global` reference for the `$post_id` global in `wp_admin_bar_edit_menu()`.
...
Follow-up to [47903].
Props davidbaumwald.
See #50312 .
Built from https://develop.svn.wordpress.org/trunk@47906
git-svn-id: http://core.svn.wordpress.org/trunk@47680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 21:27:09 +00:00
27485fd7aa
General: Continuing to work towards a passing PHP Compatibility scan.
...
This is a final pass to fix PHP compatibiilty issues in the codebase with code changes or adding `phpcs:ignore` comments.
With this change, all PHP compatibility warnings and errors without specific tickets have been addressed (see #49810 and #41750 ).
Props desrosj, johnbillion, jrf.
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47902
git-svn-id: http://core.svn.wordpress.org/trunk@47676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 17:40:12 +00:00
f22e113e95
File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors.
...
Previously, verification was disabled for the loopback request to the admin URL, but not to the home URL.
Follow-up to [46230].
Props munyagu.
Fixes #50309 . See #47957 .
Built from https://develop.svn.wordpress.org/trunk@47896
git-svn-id: http://core.svn.wordpress.org/trunk@47670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 11:43:15 +00:00
cf597dcf7c
Plugins: Make the message displayed when no plugins are installed more concise.
...
Props johnjamesjacoby, Presskopp.
Fixes #42336 .
Built from https://develop.svn.wordpress.org/trunk@47894
git-svn-id: http://core.svn.wordpress.org/trunk@47668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:51:13 +00:00
b247cafd91
Docs: Correct `@since` version for `available_permalink_structure_tags` filter.
...
Follow-up to [41182].
Props tiagohillebrandt, sabernhardt.
Fixes #42624 .
Built from https://develop.svn.wordpress.org/trunk@47893
git-svn-id: http://core.svn.wordpress.org/trunk@47667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-03 10:38:09 +00:00
ba92ed7615
I18N: Use `wp.i18n` for translatable strings in `wp-admin/js/updates.js`.
...
This removes the usage of `wp_localize_script()` for passing translations to the script and instead adds the translatable strings in the script directly through the use of `wp.i18n` and its utilities.
Props swissspidy, ocean90.
See #20491 .
Fixes #50235 .
Built from https://develop.svn.wordpress.org/trunk@47884
git-svn-id: http://core.svn.wordpress.org/trunk@47658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 21:41:09 +00:00
0318a92948
Plugins and Themes Auto-Updates: update the state of the auto-update link on the themes screen after successfully saving the setting.
...
Props desrosj, pbiron, azaozz.
Fixes #50291 .
Built from https://develop.svn.wordpress.org/trunk@47883
git-svn-id: http://core.svn.wordpress.org/trunk@47657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 20:53:15 +00:00
69a866a1a9
Administration: Unify the date structure in list view and excerpt view.
...
Both views now show a full date string. Something like `Published 2020/05/27 at 10:25 pm`.
Fixes : #35391 .
Props: afercia, ocean90, TimothyBlynJacobs, audrasjb, SergeyBiryukov, joedolson.
Built from https://develop.svn.wordpress.org/trunk@47879
git-svn-id: http://core.svn.wordpress.org/trunk@47653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 19:15:08 +00:00
c704057e0d
Add fields to WP_Block_Type
...
As part of #47620 and the RFC for block registeration. Server registered blocks are missing some fields. These changeset includes them.
Props spacedmonkey, aduth.
Fixes #48529 .
Built from https://develop.svn.wordpress.org/trunk@47875
git-svn-id: http://core.svn.wordpress.org/trunk@47649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 12:27:08 +00:00
1c176ffb1e
Docs: Correct and clarify an inline comment about the `upload_url_path` and `upload_path` options in `wp-admin/options-media.php`.
...
Synchronize it with a similar comment in `wp-admin/options.php`.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47874
git-svn-id: http://core.svn.wordpress.org/trunk@47648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-06-01 11:22:13 +00:00
9859bf6204
Build/Test Tools: Revert some devDependency changes for 5.5.
...
After bumping some major updates, tests on Travis are failing.
See: https://travis-ci.com/WordPress/wordpress-develop/builds/168839259 ##49768.
Unprops: whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47869
git-svn-id: http://core.svn.wordpress.org/trunk@47644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-31 19:51:42 +00:00
8924832842
Coding Standards: Use strict comparison in `wp-admin/_index.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47862
git-svn-id: http://core.svn.wordpress.org/trunk@47638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-28 10:02:12 +00:00
38b7495af7
Administration and Site Health: Make information on Search engine visibility more prominent.
...
- makes the "Search engines discouraged" message on the Dashboard more prominent
- adds "Search engine visibility" information under Site Health > Info > WordPress
- removes title case in favor of sentence case in all the related strings
Props audrasjb, swissspidy, emanuel_blagonic, Presskopp, karmatosed, valentinbora, melchoyce.
Fixes #35288 .
Built from https://develop.svn.wordpress.org/trunk@47859
git-svn-id: http://core.svn.wordpress.org/trunk@47635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-27 14:33:11 +00:00
57fb3c6cf0
Coding Standards: Change auto-update filters to be more consistent.
...
* send_theme_auto_update_email 👉 auto_theme_update_send_email
* wp_plugins_auto_update_enabled 👉 plugins_auto_update_enabled
* wp_themes_auto_update_enabled 👉 themes_auto_update_enabled
Want to make sure that @ronalfy gets props for his work in #50052 too.
See #50052 .
Props: ronalfy, pbiron, azaozz, audrasjb, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@47857
git-svn-id: http://core.svn.wordpress.org/trunk@47633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-26 18:03:08 +00:00
7b192d406a
Coding Standards: Fix instances of `Generic.WhiteSpace.ArbitraryParenthesesSpacing.FoundEmpty`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47855
git-svn-id: http://core.svn.wordpress.org/trunk@47631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-26 09:37:10 +00:00
786ac48c84
Coding Standards: Use strict comparison in `wp-admin/network` where static strings are involved.
...
Includes minor code layout fixes for better readability.
Follow-up to [47808].
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47853
git-svn-id: http://core.svn.wordpress.org/trunk@47629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-24 09:17:09 +00:00
5899bf0f32
Coding Standards: Use strict comparison for `$wp_db_version` check in `wp-admin/network/upgrade.php`.
...
Follow-up to [47787], [47788].
See #50155 , #49542 .
Built from https://develop.svn.wordpress.org/trunk@47852
git-svn-id: http://core.svn.wordpress.org/trunk@47628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-24 09:15:07 +00:00
5b4174e409
Coding Standards: Use strict comparison for more `count()` calls.
...
Follow-up to [47848].
Props mukesh27.
Fixes #50232 . See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47851
git-svn-id: http://core.svn.wordpress.org/trunk@47627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 16:22:07 +00:00
b9751d4efe
Coding Standards: Use strict comparison for `count()` calls.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47848
git-svn-id: http://core.svn.wordpress.org/trunk@47624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 11:38:08 +00:00
f1114d4507
Coding Standards: Fix WPCS issues in `wp-admin/plugin-editor.php` and `wp-admin/theme-editor.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47845
git-svn-id: http://core.svn.wordpress.org/trunk@47621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-23 00:01:10 +00:00
c0bec847d1
Theme Editor: Remove unused `$has_templates` boolean.
...
The variable is a remnant from when the Theme Editor still had the "Templates" heading and is unused in the current logic.
The condition it was a part of would always evaluate to true for a child theme, regardless of the `$has_templates` value.
Props dboy1988.
Fixes #50199 .
Built from https://develop.svn.wordpress.org/trunk@47844
git-svn-id: http://core.svn.wordpress.org/trunk@47620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-22 23:20:08 +00:00
5850f5f6ef
Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-site-health-auto-updates.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47841
git-svn-id: http://core.svn.wordpress.org/trunk@47617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-22 17:56:08 +00:00
64ed8a7355
Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-debug-data.php`.
...
Follow-up to [47550], [47557], [47835].
See #50052 .
Built from https://develop.svn.wordpress.org/trunk@47840
git-svn-id: http://core.svn.wordpress.org/trunk@47616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-22 17:26:07 +00:00
443dd105d4
Customize: Move the WordPress logo with a white background to the `wp-includes` directory.
...
This ensures that the image used as a default site icon looks good on a dark background.
The image was previously changed in the `wp-admin` directory, but the site icon is now loaded from `wp-includes`.
Follow-up to [36635], [47018], [47564], [47832].
Props ocean90.
Fixes #49798 .
Built from https://develop.svn.wordpress.org/trunk@47838
git-svn-id: http://core.svn.wordpress.org/trunk@47614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-21 09:10:12 +00:00
ba03c426db
Docs: Add missing `@since` tag for `auto_plugin_theme_update_email` filter.
...
See #50052 .
Built from https://develop.svn.wordpress.org/trunk@47836
git-svn-id: http://core.svn.wordpress.org/trunk@47612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-20 19:33:10 +00:00
661b929e1e
Security: Add user interface to auto-update themes and plugins.
...
Building on core update mechanisms, this adds the ability to enable automatic updates for themes and plugins to the WordPress admin.
Fixes : #50052 .
Props: afercia, afragen, audrasjb, azaozz, bookdude13, davidperonne, desrosj, gmays, gmays, javiercasares, karmatosed, knutsp, mapk, mukesh27, netweb, nicolaskulka, nielsdeblaauw, paaljoachim, passoniate, pbiron, pedromendonca, whodunitagency, whyisjake, wpamitkumar, and xkon.
Built from https://develop.svn.wordpress.org/trunk@47835
git-svn-id: http://core.svn.wordpress.org/trunk@47611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-20 18:49:09 +00:00
307725883a
Themes: Prevent installation of themes that require a higher version of PHP or WordPress.
...
Props afragen.
Fixes #49653 . See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47819
git-svn-id: http://core.svn.wordpress.org/trunk@47595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 16:03:09 +00:00
54cdfaef59
Themes: Remove extra whitespace from `wp-admin/includes/ajax-actions.php` and `wp-admin/includes/theme.php`.
...
Follow-up to [47816].
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47818
git-svn-id: http://core.svn.wordpress.org/trunk@47594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 12:55:06 +00:00
e445642243
Themes: Remove debug call from `wp-admin/theme-install.php`.
...
Follow-up to [47816].
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47817
git-svn-id: http://core.svn.wordpress.org/trunk@47593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 12:49:08 +00:00
b73bbd8139
Themes: Prevent activation and live preview of themes that require a higher version of PHP or WordPress.
...
Props afragen, jorbin, TimothyBlynJacobs, SergeyBiryukov.
See #48491 .
Built from https://develop.svn.wordpress.org/trunk@47816
git-svn-id: http://core.svn.wordpress.org/trunk@47592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 12:32:10 +00:00
d528d7a044
Site Health: Use `WP_Theme::parent()` in the inactive themes test as a more reliable check that the parent theme exists.
...
This is also more consistent with the other instances of directly referencing `WP_Theme::parent()` properties or methods in core.
Props mukesh27, juanlopez4691, davidbaumwald, afragen, SergeyBiryukov.
Fixes #49934 .
Built from https://develop.svn.wordpress.org/trunk@47815
git-svn-id: http://core.svn.wordpress.org/trunk@47591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-18 04:38:10 +00:00
91936df3d1
Coding Standards: Fix WPCS issues in plugin and theme upgrader classes.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47814
git-svn-id: http://core.svn.wordpress.org/trunk@47590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-17 09:39:11 +00:00
f9b60d3334
Accessibility: Login and Registration: Respect the `prefers-reduced-motion` media query for "shake" CSS animation on login failure.
...
This shake should not occur when the user has opted to reduce motion, for example by selecting the "Reduce motion" option in macOS' preferences or unselecting "Show animations in Windows" in Windows' preferences.
Follow-up to [47226].
Props eddystile, johnbillion, sabernhardt, afercia, audrasjb.
Fixes #49723 .
Built from https://develop.svn.wordpress.org/trunk@47813
git-svn-id: http://core.svn.wordpress.org/trunk@47589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 20:25:19 +00:00
7932193708
Coding Standards: Use strict comparison where static strings are involved.
...
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47808
git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
45f7e68d54
Media: Expose media grid frame via `wp-media-grid-ready` trigger for easier customization.
...
Props soulseekah.
Fixes #50185 .
Built from https://develop.svn.wordpress.org/trunk@47807
git-svn-id: http://core.svn.wordpress.org/trunk@47583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 17:25:11 +00:00
16a8128765
Coding Standards: Fix WPCS issues in `wp-admin/includes/class-wp-screen.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47802
git-svn-id: http://core.svn.wordpress.org/trunk@47578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-15 18:13:09 +00:00
69adb593a2
Themes: Add "Block Editor Patterns" and "Full Site Editing" to the list of WordPress theme features.
...
Follow-up to [meta9876].
Props dingo_d.
Fixes #50164 . See #meta5212.
Built from https://develop.svn.wordpress.org/trunk@47797
git-svn-id: http://core.svn.wordpress.org/trunk@47573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 14:43:08 +00:00
fb0e6531ab
Docs: Add `@since` notes for theme features added or removed in `get_theme_feature_list()` after its introduction in WordPress 3.1.
...
See #50165 .
Built from https://develop.svn.wordpress.org/trunk@47794
git-svn-id: http://core.svn.wordpress.org/trunk@47570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 12:50:08 +00:00
04e3fd6995
Themes: Add "Block Editor Styles" and "Wide Blocks" to the list of WordPress theme features.
...
These were added to Theme Directory API in anticipation of being committed to core for WordPress 5.2+, which has not happened until now.
Follow-up to [meta8273].
See #46272 .
Built from https://develop.svn.wordpress.org/trunk@47790
git-svn-id: http://core.svn.wordpress.org/trunk@47566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 09:18:08 +00:00
5e42a6c9e5
Export: Use correct escaping function for term IDs in `<wp:term>` nodes.
...
Follow-up to [34333].
Props DrLightman, marcio-zebedeu.
Fixes #50113 .
Built from https://develop.svn.wordpress.org/trunk@47789
git-svn-id: http://core.svn.wordpress.org/trunk@47565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-14 07:55:12 +00:00
9e343ccb33
Coding Standards: Use strict comparison in `wp-admin/upgrade.php`.
...
Props mukesh27.
Fixes #50155 .
Built from https://develop.svn.wordpress.org/trunk@47788
git-svn-id: http://core.svn.wordpress.org/trunk@47564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-13 10:10:08 +00:00
1e813b0275
Coding Standards: Correct `db_version` check in `wp-admin/admin.php`.
...
Follow-up to [47785].
See #49239 .
Built from https://develop.svn.wordpress.org/trunk@47787
git-svn-id: http://core.svn.wordpress.org/trunk@47563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-12 20:59:08 +00:00
bfba3fc458
Docs: Improve documentation for functions in `wp-admin/install-helper.php` per the documentation standards.
...
Synchronize descriptions with the functions' counterparts from `wp-admin/includes/upgrade.php`.
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47786
git-svn-id: http://core.svn.wordpress.org/trunk@47562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-12 18:40:07 +00:00
aa69c25d5f
Coding Standards: Use strict comparison in some `wp-admin` files.
...
Props pikamander2, mukesh27, SergeyBiryukov.
Fixes #49239 .
Built from https://develop.svn.wordpress.org/trunk@47785
git-svn-id: http://core.svn.wordpress.org/trunk@47561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-12 18:32:08 +00:00
3fc1b33d53
Docs: Use 3-digit, x.x.x style semantic versioning for inline comments in `populate_options()`.
...
See #49572 .
Built from https://develop.svn.wordpress.org/trunk@47782
git-svn-id: http://core.svn.wordpress.org/trunk@47558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-11 17:26:08 +00:00
5511b43e2c
Administration: Avoid a PHP 7.4 notice in `add_meta_box()` when attempting to re-add a previously removed box.
...
The logic for skipping previously removed meta boxes with the `core` priority should also apply to the `sorted` priority that is used when the boxes were manually reordered.
Add a unit test.
Props coolmann, franzarmas, SergeyBiryukov.
Fixes #50019 .
Built from https://develop.svn.wordpress.org/trunk@47777
git-svn-id: http://core.svn.wordpress.org/trunk@47553 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-09 12:26:12 +00:00
1cde7d86f9
Coding Standards: Fix WPCS issues in `wp-admin/includes/template.php`.
...
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47775
git-svn-id: http://core.svn.wordpress.org/trunk@47551 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-08 16:36:18 +00:00
33194d29c2
Site Health: Improve the appearance of administration email verification box.
...
Add `max-width` on desktop view and some padding on smaller screens.
Props chetan200891, azaozz, Clorith, afragen.
Fixes #48607 .
Built from https://develop.svn.wordpress.org/trunk@47772
git-svn-id: http://core.svn.wordpress.org/trunk@47548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-07 21:42:11 +00:00
7ded6c2d2a
Administration: Remove any CSS related to Internet Explorer versions 6 – 10.
...
In WordPress 3.2 support for IE6 was dropped, IE7 followed a few versions later. With the 4.8 release, WordPress officially ended support for Internet Explorer versions 8, 9, and 10. Yet, we still have shipped CSS for the unsupported IE versions....until now! Goodbye to ie.css and star hacks!
* Removes ie.css and `ie` style handle.
* Removes IE specific class names and any related CSS.
* Drops support for IE8 and older in `wp_customize_support_script()`.
* Updates compatibility mode for CSS minification to `ie11`.
Props ayeshrajans, isabel_brison, afercia, netweb, peterwilsoncc, ocean90.
Fixes #17232 , #46015 .
Built from https://develop.svn.wordpress.org/trunk@47771
git-svn-id: http://core.svn.wordpress.org/trunk@47547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-06 20:15:07 +00:00
a0224a579d
Menus: Add a Cancel link to the screen for creating a new menu.
...
The use case this helps the most is when there's only one menu and you click "create a new menu". In this case the Cancel link allows you to go back to the single existing menu.
Props garrett-eclipse, audrasjb.
Fixes #46367 .
Built from https://develop.svn.wordpress.org/trunk@47770
git-svn-id: http://core.svn.wordpress.org/trunk@47546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-06 19:35:11 +00:00
9782eb82ad
Site Health: Display the original PHP memory limit on Site Health Info screen.
...
This ensures that if the limit has been modified for admin screens by `wp_raise_memory_limit()`, the original value is displayed along with the current value.
Props Clorith, espiat, zodiac1978, SergeyBiryukov.
Fixes #49329 .
Built from https://develop.svn.wordpress.org/trunk@47762
git-svn-id: http://core.svn.wordpress.org/trunk@47538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-05 18:58:09 +00:00
36524e1e25
File Editor: Remove CSS exceptions for the "Select plugin/theme to edit" and documentation "Look Up" buttons.
...
Buttons should use the default buttons styles, no exceptions.
Props passoniate, garethgillman.
See #49197 .
Fixes #49353 .
Built from https://develop.svn.wordpress.org/trunk@47751
git-svn-id: http://core.svn.wordpress.org/trunk@47527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 14:21:08 +00:00
bc3cee1d5b
Upload: Improve file input and button alignment in plugin/theme upload form.
...
Resets flexbox on smaller screens. Improves vertical alignment on large screens.
Follow-up to [47599] and [47271].
Props mukesh27, DarkoG.
See #48859 , #49914 .
Fixes #49951 .
Built from https://develop.svn.wordpress.org/trunk@47750
git-svn-id: http://core.svn.wordpress.org/trunk@47526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-03 13:36:12 +00:00
1a27d51b48
Menus: Allow empty taxonomy terms to be surfaced when searching for items.
...
This brings the behaviour inline with that of browsing terms or using the All Items tab, which correctly shows empty terms.
Props birgire, audrasjb
Fixes #45298
Built from https://develop.svn.wordpress.org/trunk@47747
git-svn-id: http://core.svn.wordpress.org/trunk@47523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 22:36:07 +00:00
cc4e27142e
Upgrade/Install: Unlink the logo on the installation and config setup screens.
...
This allows for a natural tab order during installation, without negatively impacting users who use the keyboard for navigation, those who use a screen reader, or those who use neither.
Props lwill, afercia, audrasjb.
Fixes #47759
Built from https://develop.svn.wordpress.org/trunk@47746
git-svn-id: http://core.svn.wordpress.org/trunk@47522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 21:46:08 +00:00
5641afd43b
Administration: Reduce the chance that a PHP error message that occurs before the admin menu gets output is covered by the admin menu.
...
Props EmpireOfLight, afercia, Mte90, audrasjb, sunnyratilal
Fixes #35155
Built from https://develop.svn.wordpress.org/trunk@47745
git-svn-id: http://core.svn.wordpress.org/trunk@47521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 21:01:05 +00:00
a6f3ad2d21
Users: Don't reset user language preference on user update.
...
Props johnbillion.
Fixes #38665 .
Built from https://develop.svn.wordpress.org/trunk@47739
git-svn-id: http://core.svn.wordpress.org/trunk@47515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-02 16:29:06 +00:00
89ddd19884
General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset.
...
As part of the continued effort to improve PHP compatibility, the following improvments are being made:
- Removing deprecated PHP `safe_mode` checks not found in bundled external libraries.
- Change the remaining `while` loops using `each()` to `foreach` loops.
- Prevent false positives from being flagged for the `sodium_compat` library being caused by loading this in a non-standard way.
- Add inline comments to not flag deprecated PHP directives in the getID3 library.
Props desrosj, earnjam, dryanpress.
See #49922 .
Built from https://develop.svn.wordpress.org/trunk@47735
git-svn-id: http://core.svn.wordpress.org/trunk@47511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 19:07:09 +00:00
10945d2f3d
Taxonomy: Restore (un-deprecate) the `tag_row_actions` filter.
...
The filter provides a simple way for plugin authors to add actions generically for all taxonomy list tables without looping through each taxonomy individually.
Props joemcgill, delowardev.
Fixes #49808 .
Built from https://develop.svn.wordpress.org/trunk@47734
git-svn-id: http://core.svn.wordpress.org/trunk@47510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 16:45:09 +00:00
8ca76cabfc
Help/About: Revert [47699] from trunk.
...
Built from https://develop.svn.wordpress.org/trunk@47706
git-svn-id: http://core.svn.wordpress.org/trunk@47483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 18:44:11 +00:00
cf8bd373fe
Update the about page for WordPress 5.4.1
...
Built from https://develop.svn.wordpress.org/trunk@47699
git-svn-id: http://core.svn.wordpress.org/trunk@47476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 18:37:05 +00:00
3dc1e33fb5
Networks and Sites: Link to Nginx documentation on Network Setup screen when Nginx is in use.
...
Props lipathor, audrasjb, johnbillion, flixos90.
Fixes #41166 .
Built from https://develop.svn.wordpress.org/trunk@47632
git-svn-id: http://core.svn.wordpress.org/trunk@47407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-29 14:43:09 +00:00
5371e3fd62
Site Health: Avoid a PHP notice in `WP_Site_Health::wp_cron_scheduled_check()` if async test response does not contain the expected result.
...
Additionally, avoid a PHP notice in `::get_test_php_version()` if the minimum recommended version of PHP could not be determined.
Props schlessera, oakesjosh.
Fixes #49943 .
Built from https://develop.svn.wordpress.org/trunk@47628
git-svn-id: http://core.svn.wordpress.org/trunk@47403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-27 22:01:08 +00:00
43cfa7ee60
Administration: Remove right padding on form tables on smaller screens so that the spacing is equal on both sides.
...
Additionally, reduce the right margin on screen meta links (Help and Screen Options) to align with the tables.
Props jainnidhi, garrett-eclipse, ibdz, SergeyBiryukov.
Fixes #43279 .
Built from https://develop.svn.wordpress.org/trunk@47622
git-svn-id: http://core.svn.wordpress.org/trunk@47397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-25 12:27:11 +00:00
0dc461c72e
Networks and Sites: Don't display an empty Menu Settings section in network admin if there are no items.
...
This accounts for returning an empty array from the `mu_menu_items` filter.
Props dlh.
Fixes #49977 .
Built from https://develop.svn.wordpress.org/trunk@47616
git-svn-id: http://core.svn.wordpress.org/trunk@47391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-23 18:58:05 +00:00
6c243b4b0a
Networks and Sites: Display the Site Address field on Add Site screen in left-to-right text direction.
...
Props ramiy.
Fixes #49949 .
Built from https://develop.svn.wordpress.org/trunk@47606
git-svn-id: http://core.svn.wordpress.org/trunk@47381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-21 11:26:07 +00:00
b4373fafe9
Menus: Remove unused commented out code in `wp-admin/nav-menus.php`.
...
Props garrett-eclipse, audrasjb.
Fixes #49967 .
Built from https://develop.svn.wordpress.org/trunk@47605
git-svn-id: http://core.svn.wordpress.org/trunk@47380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-21 09:02:08 +00:00
71dea21c5f
Users: Change "Your Profile" and "My Profile" links in admin menu and toolbar to just "Profile" for consistency.
...
Props donmhico, bcworkz, seanchayes, mikeschroder, garrett-eclipse, akhileshsabharwal, ScottSmith, nacin, jenmylo, afercia, swissspidy, felix-edelmann, helen, melchoyce, karmatosed.
Fixes #26769 .
Built from https://develop.svn.wordpress.org/trunk@47600
git-svn-id: http://core.svn.wordpress.org/trunk@47375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-20 08:39:06 +00:00
30a35a4806
Upload: Better align file input and buttons in plugin/theme upload form.
...
Follow-up to [47271].
Props seedsca, piyushmca.
Fixes #49914 .
Built from https://develop.svn.wordpress.org/trunk@47599
git-svn-id: http://core.svn.wordpress.org/trunk@47374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-19 09:47:08 +00:00
ee387b9181
Accessibility: Widgets: Prevent checkboxes in widget control forms from overlapping on smaller screens.
...
Props jaz_on, milindmore22, passoniate, audrasjb, carriganvb, afercia, SergeyBiryukov.
Fixes #49228 .
Built from https://develop.svn.wordpress.org/trunk@47598
git-svn-id: http://core.svn.wordpress.org/trunk@47373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-18 07:03:09 +00:00
61a2f62ffd
Comments: Use `comment` instead of an empty string for the `comment_type` DB field value in comments table.
...
This is the first step to bring support for custom comment types into WordPress.
Add a scheduled upgrade routine to update the type value for existing comments, in batches of 100 at a time.
Props imath, aaroncampbell, jeremyfelt, dshanske.
Fixes #49236 .
Built from https://develop.svn.wordpress.org/trunk@47597
git-svn-id: http://core.svn.wordpress.org/trunk@47372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-17 19:35:06 +00:00
012b134b23
Coding Standards: Fix WPCS indentation issue in `wp-admin/nav-menus.php`.
...
This was causing a `PEAR.Functions.FunctionCallSignature.Indent` error if PHP_CodeSniffer 3.5.3 or newer is installed locally, despite the task passing on Travis.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47596
git-svn-id: http://core.svn.wordpress.org/trunk@47371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-17 18:55:09 +00:00
af1a737b48
Coding Standards: Fix WPCS indentation issue in `wp-admin/includes/class-wp-links-list-table.php`.
...
This was causing a `Generic.WhiteSpace.ScopeIndent.IncorrectExact` error if PHP_CodeSniffer 3.4.1 or newer is installed locally, despite the task passing on Travis.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47595
git-svn-id: http://core.svn.wordpress.org/trunk@47370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-17 18:31:07 +00:00
900cfc4816
Administration: Remove the smiley from overly happy "No activity yet!" message on Dashboard.
...
Props francoist, karmatosed, ibdz, estelaris, nrqsnchz, Presskopp.
Fixes #48387 .
Built from https://develop.svn.wordpress.org/trunk@47592
git-svn-id: http://core.svn.wordpress.org/trunk@47367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-17 07:57:10 +00:00
4fbfbf5f61
Plugins: Add HTML ID attributes to plugin action links for easier targeting in browser-based testing.
...
Props roytanck, shooper.
Fixes #49916 .
Built from https://develop.svn.wordpress.org/trunk@47588
git-svn-id: http://core.svn.wordpress.org/trunk@47363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-16 17:02:08 +00:00
92538d89ee
Site Health: Detect an active PHP session as a possible reason for HTTP requests timing out.
...
PHP sessions created by a `session_start()` function call may interfere with REST API and loopback requests.
An active session should be closed by `session_write_close()` before making any HTTP requests.
Props matthieumota, netweblogic, Clorith, afragen, vjik, SergeyBiryukov.
Fixes #47320 .
Built from https://develop.svn.wordpress.org/trunk@47585
git-svn-id: http://core.svn.wordpress.org/trunk@47360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-16 08:20:09 +00:00
4e13efaf96
Code Modernization: Remove conditional use of `stream_get_contents()` PHP function.
...
The function was introduced in PHP 5.0.0. Now that the minimum version of PHP required by WordPress is 5.6.20, these conditions are no longer needed.
Props jrf.
Fixes #48091 .
Built from https://develop.svn.wordpress.org/trunk@47584
git-svn-id: http://core.svn.wordpress.org/trunk@47359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-15 11:54:08 +00:00
bb2c0198ab
Comments: Clarify that "Comment Moderation" and "Comment Blocklist" options in Discussion Settings also apply to browser's user agent string for submitted comments.
...
Props zodiac1978.
Fixes #49902 .
Built from https://develop.svn.wordpress.org/trunk@47583
git-svn-id: http://core.svn.wordpress.org/trunk@47358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-15 06:40:05 +00:00
ae59482c80
Plugins: Simplify the logic of `validate_plugin_requirements()`, update documentation.
...
This updates the function for consistency with `validate_theme_requirements()`.
Follow-up to [44978], [45546], [47573].
Fixes #43992 .
Built from https://develop.svn.wordpress.org/trunk@47574
git-svn-id: http://core.svn.wordpress.org/trunk@47349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-13 15:31:05 +00:00
87b3b38242
Privacy: Add an indication when the Copy action in Privacy Policy Guide is complete.
...
This adds a "Copied!" text near the "Copy this section to clipboard" button to provide direct feedback that the action was completed.
Props garrett-eclipse, nickylimjj, xkon, desrosj, birgire.
Fixes #44588 .
Built from https://develop.svn.wordpress.org/trunk@47572
git-svn-id: http://core.svn.wordpress.org/trunk@47347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-12 14:26:11 +00:00
48225beffb
Rewrite Rules: Use double quotes instead of backticks in `.htaccess` instructions about `# BEGIN/END` markers.
...
Previously, the backticks resulted in extra markup being added when posted on support forums.
Props mayankmajeji, knutsp.
Fixes #49868 .
Built from https://develop.svn.wordpress.org/trunk@47571
git-svn-id: http://core.svn.wordpress.org/trunk@47346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-11 15:09:11 +00:00
9f379bb930
Docs: Fix typo in `WP_Upgrader::__construct()` DocBlock.
...
Props mattrad.
Fixes #49856 .
Built from https://develop.svn.wordpress.org/trunk@47570
git-svn-id: http://core.svn.wordpress.org/trunk@47345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-10 09:48:17 +00:00
e42f45e667
Customize: Give the WordPress logo a white background for dark mode browsers.
...
The favicon is transparent, which would normally look fine, but on a dark background it washes out.
Props DhrRob, audrasjb.
Fixes 49798.
Built from https://develop.svn.wordpress.org/trunk@47564
git-svn-id: http://core.svn.wordpress.org/trunk@47339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-10 02:50:07 +00:00
a1bf993892
Privacy: Support additional elements (table, ol, ul) in privacy policy guide new styling
...
The privacy policy guide supports a lot of HTML, include rules for lists, and ensure proper styling for the rest.
Props garrett-eclipse.
Fixes #49772 .
Built from https://develop.svn.wordpress.org/trunk@47560
git-svn-id: http://core.svn.wordpress.org/trunk@47335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-09 22:34:05 +00:00
f927fdedb4
Accessibility: Fix the headings hierarchy on the Freedoms page.
...
Props ryelle, afercia.
Fixes #49838 .
Built from https://develop.svn.wordpress.org/trunk@47558
git-svn-id: http://core.svn.wordpress.org/trunk@47333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-09 16:09:11 +00:00
856e1a27b8
Coding Standards: Use strict type check for `in_array()` and `array_search()`.
...
This addresses all the remaining `WordPress.PHP.StrictInArray.MissingTrueStrict` issues in core.
Includes minor code layout fixes for better readability.
Follow-up to [47550].
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47557
git-svn-id: http://core.svn.wordpress.org/trunk@47332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-09 15:43:10 +00:00
c18e44d6b1
Privacy: Make the deprecated `wp_get_user_request_data()` function available on front end.
...
Previously, it was accidentally made available only in admin context.
Follow-up to [44606], [47245].
Props garrett-eclipse, johnjamesjacoby, r-a-y, Dono12.
Fixes #49802 .
Built from https://develop.svn.wordpress.org/trunk@47555
git-svn-id: http://core.svn.wordpress.org/trunk@47330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-08 18:33:08 +00:00
38676936ba
Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved.
...
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47550
git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-05 03:02:11 +00:00
441001f29f
Docs: Add documentation for the `$parent` parameter of `get_admin_page_parent()`.
...
Props subrataemfluence.
Fixes #45849 .
Built from https://develop.svn.wordpress.org/trunk@47546
git-svn-id: http://core.svn.wordpress.org/trunk@47321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-03 17:23:11 +00:00
042bf6dbd9
Administration: Make the height of dashboard widget headings consistent with that of post meta boxes on smaller screens.
...
This also ensures that the toggle arrow for dashboard widgets is properly aligned.
Props chetan200891.
Fixes #49727 .
Built from https://develop.svn.wordpress.org/trunk@47535
git-svn-id: http://core.svn.wordpress.org/trunk@47310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-31 02:52:07 +00:00
e38a57db0c
Help/About: Use CDN URLs for 5.4 About page header images.
...
See #49295 .
Built from https://develop.svn.wordpress.org/trunk@47532
git-svn-id: http://core.svn.wordpress.org/trunk@47307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-30 17:49:07 +00:00
49d7b8c51f
Filesystem API: Correct punctuation in `request_filesystem_credentials()` error message.
...
Props mayankmajeji, kharisblank.
Fixes #49724 .
Built from https://develop.svn.wordpress.org/trunk@47530
git-svn-id: http://core.svn.wordpress.org/trunk@47305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-30 01:32:07 +00:00
c83710ccee
Site Health: Remove paragraph tag from the actions container in issue template.
...
Most of the tests pass content that is already wrapped in a paragraph or list tags, thus producing nested paragraphs or invalid markup.
Additionally, don't output an empty `<div>` tag if the test does not provide any actions.
Props maxpertici, afercia.
Fixes #48948 .
Built from https://develop.svn.wordpress.org/trunk@47529
git-svn-id: http://core.svn.wordpress.org/trunk@47304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-30 01:25:11 +00:00
764a1761aa
Site Health: Correct markup in `::get_test_php_extensions()` and `::get_test_background_updates()` description.
...
These tests output an unordered list, which doesn't need to be wrapped in a paragraph tag.
Additionally, pass an empty string as an `actions` parameter in `::get_test_php_default_timezone()`, for consistency with other tests.
Props afercia.
See #48948 .
Built from https://develop.svn.wordpress.org/trunk@47528
git-svn-id: http://core.svn.wordpress.org/trunk@47303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-29 03:46:06 +00:00
d552e475fd
Site Health: Add pretty links support information to debug data.
...
Props valentinbora, afragen.
Fixes #49422 .
Built from https://develop.svn.wordpress.org/trunk@47527
git-svn-id: http://core.svn.wordpress.org/trunk@47302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-28 21:20:06 +00:00
ce2dea9ef6
Help/About: Improve accessibility of the 5.4 About page:
...
* Remove vertical text and unnecessary italics.
* Update H1 headings on About, Credits, Freedoms, Privacy pages to be unique to each page.
Props sabernhardt, ryelle, melchoyce, karmatosed, audrasjb, afercia, davidbaumwald, SergeyBiryukov.
See #49295 .
Built from https://develop.svn.wordpress.org/trunk@47521
git-svn-id: http://core.svn.wordpress.org/trunk@47296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 23:41:06 +00:00
a546a9c35c
Coding Standards: Remove some extra tabs in `wp-admin/user-new.php`.
...
Follow-up to [47516], [47519].
See #38665 .
Built from https://develop.svn.wordpress.org/trunk@47520
git-svn-id: http://core.svn.wordpress.org/trunk@47295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 22:30:09 +00:00
ee1bf5a911
Coding Standards: Fix WPCS issues in [47516].
...
See #38665 .
Built from https://develop.svn.wordpress.org/trunk@47519
git-svn-id: http://core.svn.wordpress.org/trunk@47294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 22:25:08 +00:00
41ae74f7b4
Users: Add a user language preference option to the "Add New User" form.
...
This uses the same language selection control as the user editing screen and allows new users to be invited to a site in their own language.
Props barryceelen, johnbillion
Fixes #38665
Built from https://develop.svn.wordpress.org/trunk@47516
git-svn-id: http://core.svn.wordpress.org/trunk@47291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-27 21:58:05 +00:00
7dbad241cb
Themes: Always list broken themes even if the user cannot take a corresponding action within the admin area.
...
This prevents broken themes being hidden when the `DISALLOW_FILE_MODS` constant is in use.
Props rebasaurus
Fixes #49268
Built from https://develop.svn.wordpress.org/trunk@47510
git-svn-id: http://core.svn.wordpress.org/trunk@47285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-26 17:50:15 +00:00
2b030a1647
Docs: Add documentation for `WP_Comments_List_Table::floated_admin_avatar()`.
...
Props akbarhusen, ayeshrajans, Soean, ajayghaghretiya1, netweb, SergeyBiryukov.
Fixes #41491 .
Built from https://develop.svn.wordpress.org/trunk@47507
git-svn-id: http://core.svn.wordpress.org/trunk@47282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-25 14:43:11 +00:00
26cc999d64
Help/About: Fix a typo on the about page and fix a link.
...
The text "on your" appeared two times. This commit fixes the issue and removes the duplication. It also updates the field guide permalink.
Props garrett-eclipse, ixkaito, karmatosed, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@47500
git-svn-id: http://core.svn.wordpress.org/trunk@47275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-24 15:03:08 +00:00
5ce4cc4930
Administration: Add `/` character to `<img>` tag in `WP_Plugin_Install_List_Table::display_rows()`.
...
While this has no effect on void elements in HTML5, it fixes a minor inconsistency with the rest of core.
Props adnan.limdi, Soean.
Fixes #41904 .
Built from https://develop.svn.wordpress.org/trunk@47493
git-svn-id: http://core.svn.wordpress.org/trunk@47268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-23 03:03:07 +00:00
248a115c2b
Upgrade/Install: Return a more appropriate HTTP response status code (`409 Conflict`) if the `wp-config.php` file already exists.
...
Props linyows, ocean90.
Fixes #42466 .
Built from https://develop.svn.wordpress.org/trunk@47478
git-svn-id: http://core.svn.wordpress.org/trunk@47267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-21 15:44:15 +00:00
77e32cff47
Coding Standards: Fix WPCS issue in [47475].
...
See #49295 .
Built from https://develop.svn.wordpress.org/trunk@47476
git-svn-id: http://core.svn.wordpress.org/trunk@47265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-20 17:33:07 +00:00
8f31a95982
Help/About: Add design for 5.4 About page.
...
Props melchoyce, marybaum, marktimemedia, elmastudio, ryelle, karmatosed, audrasjb, afercia, francina, sabernhardt.
See #49295 .
Built from https://develop.svn.wordpress.org/trunk@47475
git-svn-id: http://core.svn.wordpress.org/trunk@47264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-20 17:13:10 +00:00
2fd80efe13
Administration: Escape admin title on output after the `admin_title` filter runs, not before.
...
Props lalitpendhare, adnan.limdi, subrataemfluence, andraganescu.
Fixes #41921 .
Built from https://develop.svn.wordpress.org/trunk@47474
git-svn-id: http://core.svn.wordpress.org/trunk@47261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-20 02:20:08 +00:00
ed01dbb89b
Privacy: Correct bottom padding for table of contents on Privacy Policy Guide on smaller screens.
...
Props jagirbahesh, birgire, garrett-eclipse.
Fixes #49570 .
Built from https://develop.svn.wordpress.org/trunk@47473
git-svn-id: http://core.svn.wordpress.org/trunk@47260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-19 20:45:10 +00:00
c6c8862b87
Post Formats: Pass post type to the `disable_formats_dropdown` filter in `WP_Posts_List_Table::formats_dropdown()`.
...
Props MatheusFD, birgire.
Fixes #47959 .
Built from https://develop.svn.wordpress.org/trunk@47472
git-svn-id: http://core.svn.wordpress.org/trunk@47259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-18 19:13:10 +00:00
7004afe4f4
Docs: Various docblock corrections and improvements.
...
See #49572
Built from https://develop.svn.wordpress.org/trunk@47461
git-svn-id: http://core.svn.wordpress.org/trunk@47248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-16 18:40:07 +00:00
73ef224e64
Administration: When editing a plugin or theme file, close any active PHP session.
...
This prevents HTTP requests from timing out when attempting to connect back to the site.
Props bruandet, vjik, donmhico, SergeyBiryukov.
Fixes #43358 .
Built from https://develop.svn.wordpress.org/trunk@47457
git-svn-id: http://core.svn.wordpress.org/trunk@47244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-15 19:45:07 +00:00
cf75b95197
Site Health: Run the first scheduled site health check a day after the initial site setup.
...
This reduces the chance of displaying incorrect results due to running the check too early in first time setup scenarios.
Props Clorith, garrett-eclipse, roytanck, joostdevalk.
Fixes #49577 .
Built from https://develop.svn.wordpress.org/trunk@47456
git-svn-id: http://core.svn.wordpress.org/trunk@47243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-14 16:36:07 +00:00
70def7fc4a
Help/About: Use consistent vertical whitespace between sections on Freedoms page.
...
Props chetan200891.
Fixes #49619 .
Built from https://develop.svn.wordpress.org/trunk@47443
git-svn-id: http://core.svn.wordpress.org/trunk@47230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-10 20:39:16 +00:00
d8a0b6ef2c
Help/About: Update and correct some strings for 5.4 About page.
...
Props garrett-eclipse, Ipstenu, ocean90, tobifjellner, la-geek.
Reviewed by ocean90, SergeyBiryukov.
See #49295 .
Built from https://develop.svn.wordpress.org/trunk@47436
git-svn-id: http://core.svn.wordpress.org/trunk@47223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-09 00:11:04 +00:00
9448f5c95e
Themes: Prevent tags in Theme Details modal from being partially hidden behind action buttons on smaller screens.
...
Props sagarjadhav, valentinbora.
Fixes #31783 .
Built from https://develop.svn.wordpress.org/trunk@47435
git-svn-id: http://core.svn.wordpress.org/trunk@47222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-08 01:52:05 +00:00
cb5308b0ab
Administration: Add missing description for "Page title" element of the admin menu array.
...
Props ajoah, valentinbora, kaitlin414.
Fixes #42911 .
Built from https://develop.svn.wordpress.org/trunk@47434
git-svn-id: http://core.svn.wordpress.org/trunk@47221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-08 00:18:05 +00:00
9fbd842eb2
Customize: Ensure color picker's Clear button is aligned properly.
...
Props Cybr.
Fixes #49543 .
Built from https://develop.svn.wordpress.org/trunk@47433
git-svn-id: http://core.svn.wordpress.org/trunk@47220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-07 01:13:06 +00:00
293bc81bf6
Help/About: Add strings for 5.4 About page.
...
Props elmastudio, chanthaboune, francina, marybaum, audrasjb.
See #49295 .
Built from https://develop.svn.wordpress.org/trunk@47422
git-svn-id: http://core.svn.wordpress.org/trunk@47209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 21:22:07 +00:00
18e3aa433c
Privacy: Prevent unexpected scrolling when clicking the "Copy this section to clipboard" button on Privacy Policy Guide screen.
...
Props garrett-eclipse, birgire, davidbaumwald, pbiron.
Fixes #49540 .
Built from https://develop.svn.wordpress.org/trunk@47420
git-svn-id: http://core.svn.wordpress.org/trunk@47207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 17:51:05 +00:00
c30fd0b54d
Media: Improve the appearance of image editor on small and medium screens.
...
This prevents the main area of Edit Media screen from being pushed down too far.
Props sabernhardt, afercia, fierevere, sathyapulse, mikeschroder, johnbillion.
Fixes #48780 . See #47136 .
Built from https://develop.svn.wordpress.org/trunk@47418
git-svn-id: http://core.svn.wordpress.org/trunk@47205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 17:21:05 +00:00
62ef2d6719
Site Health: Fix typo in Site Health Status dashboard widget.
...
Follow-up to [47063], [47413].
Props Clorith, dlh.
See #49562 .
Built from https://develop.svn.wordpress.org/trunk@47415
git-svn-id: http://core.svn.wordpress.org/trunk@47202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 12:22:07 +00:00
a9479f31d1
Docs: Correct formatting of some DocBlocks in `Plugin_Upgrader` and `Theme_Upgrader` per the documentation standards.
...
See #49400 .
Built from https://develop.svn.wordpress.org/trunk@47414
git-svn-id: http://core.svn.wordpress.org/trunk@47201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 11:39:08 +00:00
ab854ce518
Site Health: Improve the strings in Site Health Status dashboard widget.
...
Follow-up to [47063].
Props dlh.
Fixes #49562 .
Built from https://develop.svn.wordpress.org/trunk@47413
git-svn-id: http://core.svn.wordpress.org/trunk@47200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 11:21:07 +00:00
24567bf775
Privacy: Fix the URLs and legacy redirects for the personal data export and erasure screens.
...
Props Jurgen Oldenburg, garrett-eclipse
Fixes #49476
Built from https://develop.svn.wordpress.org/trunk@47412
git-svn-id: http://core.svn.wordpress.org/trunk@47199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 00:50:06 +00:00
e12cca1ce8
Privacy: Reintroduce consistency to the styling of suggested privacy text from core and plugins.
...
Props garrett-eclipse
Fixes #49282
Built from https://develop.svn.wordpress.org/trunk@47411
git-svn-id: http://core.svn.wordpress.org/trunk@47198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 00:42:06 +00:00
da52485cf1
Editor: Revert a fix for incorrect usage of ID attributes on custom fields.
...
This reverts [47222] due to compatibility issues with plugins which are using the `#poststuff` selector.
See #46964
Built from https://develop.svn.wordpress.org/trunk@47410
git-svn-id: http://core.svn.wordpress.org/trunk@47197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 00:37:06 +00:00
9860470360
Upgrade/Install: Improved inline docs for the plugin and theme updater maintenance mode functionality.
...
Props bookdude13
See #49400
Built from https://develop.svn.wordpress.org/trunk@47409
git-svn-id: http://core.svn.wordpress.org/trunk@47196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-03 00:29:06 +00:00
251d77e1a1
Docs: Miscellaneous docs fixes and improvements.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47398
git-svn-id: http://core.svn.wordpress.org/trunk@47185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-01 10:40:07 +00:00
056dad9c2c
Docs: Use more specific types in parameter descriptions in place of `mixed`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47397
git-svn-id: http://core.svn.wordpress.org/trunk@47184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-01 10:38:07 +00:00
bf8c4ee5c6
Docs: Correct the parameter documentation of the `request_filesystem_credentials` filter.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@47396
git-svn-id: http://core.svn.wordpress.org/trunk@47183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-03-01 10:33:04 +00:00
fcff974c33
Privacy: Make the progress indicator for export and erasure visible even if not hovered over.
...
Follow-up to [47246].
Props pbiron, garrett-eclipse.
Fixes #44264 .
Built from https://develop.svn.wordpress.org/trunk@47395
git-svn-id: http://core.svn.wordpress.org/trunk@47182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-29 23:45:07 +00:00
ab0cf0aa51
Privacy: Switch buttons in Next Steps column of privacy request tables to `break-word` for better legibility on various screen sizes.
...
Props garrett-eclipse, afercia, nrqsnchz.
Fixes #46304 .
Built from https://develop.svn.wordpress.org/trunk@47376
git-svn-id: http://core.svn.wordpress.org/trunk@47163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 21:01:06 +00:00
3a333ef030
Coding Standards: Use strict comparison for `normalize_whitespace()` checks when comparing revisions or autosaves.
...
Props dkarfa, itowhid06, TimothyBlynJacobs.
Fixes #47965 .
Built from https://develop.svn.wordpress.org/trunk@47372
git-svn-id: http://core.svn.wordpress.org/trunk@47159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 19:35:09 +00:00
b7c69ce058
Widgets: Avoid an overflow issue in widget controls that include `<select>` form fields.
...
Props alexischenal, audrasjb, dkarfa.
Fixes #49401 .
Built from https://develop.svn.wordpress.org/trunk@47365
git-svn-id: http://core.svn.wordpress.org/trunk@47152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 17:04:07 +00:00
1a090b3385
Customize: When a menu item is removed from the menu, uncheck its source item on the available items panel.
...
Props donmhico, garrett-eclipse, audrasjb.
Fixes #46830 .
Built from https://develop.svn.wordpress.org/trunk@47356
git-svn-id: http://core.svn.wordpress.org/trunk@47143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-25 11:14:08 +00:00
e0a2660719
I18N: Replace `.htaccess` with placeholders in the strings for Site Health custom rules check.
...
Props ramiy.
Fixes #48864 .
Built from https://develop.svn.wordpress.org/trunk@47345
git-svn-id: http://core.svn.wordpress.org/trunk@47132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-22 18:56:06 +00:00
b4cea6ae93
I18N: Use a consistent wording for "Unable to write to file" strings.
...
Props ramiy.
Fixes #48862 .
Built from https://develop.svn.wordpress.org/trunk@47344
git-svn-id: http://core.svn.wordpress.org/trunk@47131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-22 18:33:08 +00:00
2c5ebcee68
Comments: improve styling on mobile for comments marked as spam.
...
Correct an issue where comments marked as spam in a mobile view displayed incorrectly, filling a narrow and very tall column with the notice that a comment was marked as spam.
Props jeremyfelt, lorenzof, mukesh27, razamalik, xkon.
Fixes #48814 .
Built from https://develop.svn.wordpress.org/trunk@47340
git-svn-id: http://core.svn.wordpress.org/trunk@47127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-21 17:04:08 +00:00
f0dfe42216
I18N: Replace `upload_max_filesize`, `php.ini`, `MAX_FILE_SIZE` with placeholders in upload error strings.
...
Props ramiy.
Fixes #48869 .
Built from https://develop.svn.wordpress.org/trunk@47330
git-svn-id: http://core.svn.wordpress.org/trunk@47123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-20 17:18:06 +00:00
447536a0e6
Site Health: Display the REST API test error codes correctly.
...
This change fixes an issue where the error codes associated with failed REST API tests are not being printed to the screen. In addition, the square brackets have been replaced with parentheses for consistency, and the error code (which is much less useful to end-users than the error message itself) has been moved to the end of the line.
This also clarifies the associated translator comments.
Props afercia, desrosj.
Fixes #49426 .
Built from https://develop.svn.wordpress.org/trunk@47306
git-svn-id: http://core.svn.wordpress.org/trunk@47106 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-18 16:48:06 +00:00
d1054fcb48
Accessibility: Improve readability by removing unnecessary italic font style.
...
Per Web Content Accessibility Guidelines 2.0, big chunks of italic text should be avoided.
Same applies to UI controls, since they're meant to be comfortably readable by the largest possible audience, e.g.: label elements.
Removes italic font style from:
- the Quick Edit / Bulk Edit forms
- the Recovery Mode plugin error details
- the Image Editor inline help
Props birgire, audrasjb, SergeyBiryukov, melchoyce, estelaris, sabernhardt, xkon, nrqsnchz, afercia.
See #47327 .
Built from https://develop.svn.wordpress.org/trunk@47304
git-svn-id: http://core.svn.wordpress.org/trunk@47104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-18 15:32:09 +00:00
9de7b1c35e
Site Health: Prevent the Site Health Status dashboard widget from loading on network admin screen for now.
...
Props Clorith, pbiron.
See #47606 , #47085 .
Built from https://develop.svn.wordpress.org/trunk@47300
git-svn-id: http://core.svn.wordpress.org/trunk@47100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-17 09:59:04 +00:00
5875ad981b
Menus: Restore the title of the currently active/expanded menu item when clicking "Cancel" after editing.
...
Other inputs are already restored to their previous values in that case.
Props Girishpanchal, nilamacharya, JoshuaWold, welcher, SergeyBiryukov.
Fixes #43031 .
Built from https://develop.svn.wordpress.org/trunk@47294
git-svn-id: http://core.svn.wordpress.org/trunk@47094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-16 06:27:08 +00:00
74b90a6b45
Themes: Correct the height of theme actions button container on various screen sizes.
...
Props aftabmuni, alexischenal, ideaboxcreations, audrasjb, SergeyBiryukov.
Fixes #49302 .
Built from https://develop.svn.wordpress.org/trunk@47293
git-svn-id: http://core.svn.wordpress.org/trunk@47093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-15 05:08:05 +00:00
f147a4003e
Widgets: Hide the "Align" legend in Image Widget display settings, since the associated controls are also hidden.
...
Props audrasjb, fotisps, marcelo2605.
Fixes #48931 .
Built from https://develop.svn.wordpress.org/trunk@47292
git-svn-id: http://core.svn.wordpress.org/trunk@47092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-15 02:50:08 +00:00
a2b2f63b78
Administration: Allow `wp_update_link()` to update the `link_owner` field, for consistency with other link fields.
...
Props pbiron, valentinbora, nikhilgupte.
Fixes #41687 .
Built from https://develop.svn.wordpress.org/trunk@47291
git-svn-id: http://core.svn.wordpress.org/trunk@47091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-15 01:55:06 +00:00
19fd7a0da9
Administration: Correct alignment of form controls inside custom meta boxes.
...
Props audrasjb, dontdream, valentinbora.
Fixes #49013 .
Built from https://develop.svn.wordpress.org/trunk@47289
git-svn-id: http://core.svn.wordpress.org/trunk@47089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-14 00:52:06 +00:00
6b2c63031c
Coding Standards: Rename `$d` parameter in various date/time functions to `$format` for clarity.
...
See #49222 .
Built from https://develop.svn.wordpress.org/trunk@47287
git-svn-id: http://core.svn.wordpress.org/trunk@47087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-14 00:07:07 +00:00
534fcd7b0e
Privacy: Only show the Privacy Policy page notice when editing the page, not on drafts list.
...
Props chetan200891, xkon, garrett-eclipse.
Fixes #48431 .
Built from https://develop.svn.wordpress.org/trunk@47284
git-svn-id: http://core.svn.wordpress.org/trunk@47084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-12 11:44:08 +00:00
b2ecf2c2bc
Privacy: Improve the appearance of privacy request email inputs on mobile.
...
Props garrett-eclipse, xkon.
Fixes #48189 .
Built from https://develop.svn.wordpress.org/trunk@47283
git-svn-id: http://core.svn.wordpress.org/trunk@47083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-12 11:29:10 +00:00
63ed0401a0
Privacy: Revert [47269] for now to address side effects on Multisite installations.
...
See #44176 .
Built from https://develop.svn.wordpress.org/trunk@47280
git-svn-id: http://core.svn.wordpress.org/trunk@47080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 21:48:06 +00:00
652966a2a5
Privacy: Introduce filters for the headers of all the privacy-related e-mails:
...
* `wp_privacy_personal_data_email_headers`
* `user_request_confirmed_email_headers`
* `user_erasure_complete_email_headers`
* `user_request_action_email_headers`
Props xkon, garrett-eclipse, zaffarn, desrosj.
Fixes #44501 .
Built from https://develop.svn.wordpress.org/trunk@47279
git-svn-id: http://core.svn.wordpress.org/trunk@47079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 21:43:07 +00:00
e6d01e007c
Privacy: Add a table of contents to Personal Data Export report for easier navigation.
...
Props xkon, garrett-eclipse, birgire, karmatosed.
Fixes #46894 .
Built from https://develop.svn.wordpress.org/trunk@47278
git-svn-id: http://core.svn.wordpress.org/trunk@47078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 21:28:05 +00:00
be2ec734f2
Upgrade/Install: Enable maintenance mode when plugins are auto-updated.
...
When an attempt is made to update an active plugin automatically, there is the potential currently for two negative scenarios:
- The plugin can be deactivated if the Plugins admin screen is loaded when the plugin update is incomplete, causing a PHP error.
- The WSOD protection could be triggered, sending a false alarm email to the site administrator.
By enabling maintenance mode before an active plugin update is attempted, these scenarios can be avoided.
This change implements the same approach as the `Theme_Upgrader` class of using the `upgrader_pre_install` and `upgrader_post_install` hooks to toggle maintenance mode.
Props desrosj, SergeyBiryukov.
Fixes #49400 .
Built from https://develop.svn.wordpress.org/trunk@47275
git-svn-id: http://core.svn.wordpress.org/trunk@47075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 20:14:05 +00:00
ae102b2487
Export: Use correct context for the `Posts` label on the Export screen.
...
The string refers to the post type name specifically, not to a generic term to identify a publication on WordPress.
Props audrasjb, jdy68.
Fixes #49306 .
Built from https://develop.svn.wordpress.org/trunk@47272
git-svn-id: http://core.svn.wordpress.org/trunk@47072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 19:35:06 +00:00
40046869f3
Upload: Fix Plugin and Theme upload form are misaligned.
...
This commit makes sure that when uploading a plugin or theme file, the Install Now button is correctly aligned, and the button does not drops to the next line if filename is long.
Props seedsca, SergeyBiryukov, audrasjb.
Fixes #48859 .
Built from https://develop.svn.wordpress.org/trunk@47271
git-svn-id: http://core.svn.wordpress.org/trunk@47071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 19:18:09 +00:00
30c7bb621c
Privacy: Un-map privacy capabilities to make them available to be assigned for custom roles:
...
* `erase_others_personal_data`
* `export_others_personal_data`
* `manage_privacy_options`
Previously mapped to `manage_options` or `manage_network` (on Multisite), these are now added to the Administrator role separately.
Additionally, `manage_privacy_options` is added to the Editor role.
Props garrett-eclipse, xkon, pbiron, desrosj, johnbillion, flixos90, juliobox, lakenh, Ov3rfly, ianatkins.
Fixes #44176 .
Built from https://develop.svn.wordpress.org/trunk@47269
git-svn-id: http://core.svn.wordpress.org/trunk@47069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 18:36:06 +00:00
bf29d14a69
Site Health: Adjust "Database username" and "Table prefix" strings for consistency with the same strings in `wp-admin/setup-config.php`.
...
Props ramiy.
Fixes #47043 .
Built from https://develop.svn.wordpress.org/trunk@47268
git-svn-id: http://core.svn.wordpress.org/trunk@47068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 16:48:05 +00:00
76718fbea3
Widgets: Prevent currently active wide widget controls from being partially covered by another widget's controls.
...
The currently active widget controls should always be displayed on top.
Props audrasjb, fervillz, rinkuyadav999, jaydeep23290, ashokrd2013, melchoyce, pento, westonruter, SergeyBiryukov.
Fixes #42001 .
Built from https://develop.svn.wordpress.org/trunk@47263
git-svn-id: http://core.svn.wordpress.org/trunk@47063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 15:26:09 +00:00
036eca242a
Media: Reset aspect ratio constraints when width and height fields fail numeric validation.
...
Props TBschen, valentinbora.
Fixes #49073 .
Built from https://develop.svn.wordpress.org/trunk@47262
git-svn-id: http://core.svn.wordpress.org/trunk@47062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 04:40:10 +00:00
9614434049
Media: Improve the preview of transparent images in Image widget by using CSS3 to show a checkered background.
...
Props bahia0019.
Fixes #49237 .
Built from https://develop.svn.wordpress.org/trunk@47257
git-svn-id: http://core.svn.wordpress.org/trunk@47057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 01:47:06 +00:00
5d00e8f78b
Administration: Move `.has-row-actions` class in Recent Comments dashboard widget next to `.dashboard-comment-wrap`, for consistency.
...
Follow-up to [47255].
See #42938 .
Built from https://develop.svn.wordpress.org/trunk@47256
git-svn-id: http://core.svn.wordpress.org/trunk@47056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 01:21:05 +00:00
8c2fb2148b
Administration: Remove a blank space in the Recent Comments dashboard widget if avatars are disabled on Discussion Settings screen.
...
Props Marius84, shital-patel, GaryJ, ianbelanger, sgastard, lgrev01, donmhico, garrett-eclipse, audrasjb, SergeyBiryukov.
Fixes #42938 .
Built from https://develop.svn.wordpress.org/trunk@47255
git-svn-id: http://core.svn.wordpress.org/trunk@47055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 01:17:06 +00:00
055af2b506
Site Health: Improve the wording for PHP update recommendations.
...
Props Clorith, grafruessel, sathyapulse, wpgurudev, garrett-eclipse, marybaum, xkon, SergeyBiryukov.
Fixes #48716 .
Built from https://develop.svn.wordpress.org/trunk@47254
git-svn-id: http://core.svn.wordpress.org/trunk@47054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 00:41:05 +00:00
984d1c60b5
Comments: Improve the appearance of the Status box on Edit Comment screen.
...
This makes the box more consistent with the Publish meta box in classic editor.
Props birgire, nfmohit, melchoyce, afercia.
Fixes #43587 .
Built from https://develop.svn.wordpress.org/trunk@47252
git-svn-id: http://core.svn.wordpress.org/trunk@47052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-11 00:06:04 +00:00
507d056b7e
Media: In `media_sideload_image()`, store the original attachment URL in the `_source_url` post meta value.
...
Props dshanske, joemcgill, antpb.
Fixes #48164 .
Built from https://develop.svn.wordpress.org/trunk@47251
git-svn-id: http://core.svn.wordpress.org/trunk@47051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 23:47:04 +00:00
f8f24b49e6
Coding Standards: Fix JSHint issues in [47246].
...
See #44264 .
Built from https://develop.svn.wordpress.org/trunk@47248
git-svn-id: http://core.svn.wordpress.org/trunk@47048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 21:38:08 +00:00
13922a3210
Privacy: Convert buttons to links visually in Privacy Export/Erasure "Next Steps" column.
...
With a lot of export or erasure requests, the secondary buttons were becoming overwhelming when stacked on top of each other.
Props xkon, karmatosed.
Fixes #49323 .
Built from https://develop.svn.wordpress.org/trunk@47247
git-svn-id: http://core.svn.wordpress.org/trunk@47047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 21:15:05 +00:00
5ddf97e142
Privacy: Give progress indication for export and erasure.
...
This adds a progress indicator for "Download Personal Data" and "Erase Personal Data" row actions, which can take a while with a lot of data.
Props garrett-eclipse, allendav, dominic_ks, xkon, karmatosed, birgire.
Fixes #44264 .
Built from https://develop.svn.wordpress.org/trunk@47246
git-svn-id: http://core.svn.wordpress.org/trunk@47046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 20:19:05 +00:00
3342aafe5e
Privacy: Rename `wp_get_user_request_data()` to `wp_get_user_request()` for clarity; deprecate the old function.
...
The function returns an instance of the `WP_User_Request` object itself, not its `$request_data` property.
Follow-up to [44606].
Props garrett-eclipse.
Fixes #46302 .
Built from https://develop.svn.wordpress.org/trunk@47245
git-svn-id: http://core.svn.wordpress.org/trunk@47045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 19:57:05 +00:00
76e375434b
Block Editor: Backport inclusion of new editor settings to the core.
...
This commit includes in the core settings for the gradients theme API stabilized in https://github.com/WordPress/gutenberg/pull/20107 , and for the image sizes required for the latest posts feature image https://github.com/WordPress/gutenberg/pull/17151/ .
Props: youknowriad, ryelle.
Fixes #49389 .
Built from https://develop.svn.wordpress.org/trunk@47240
git-svn-id: http://core.svn.wordpress.org/trunk@47040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 17:52:15 +00:00
d98fe66044
Site Health: Move the warning about `WP_DEBUG_LOG` being publicly accessible from "critical issues" to "recommended improvements" if the error log is outside of the WordPress directory.
...
Props afragen, Clorith, miss_jwo, mikeschroder, kubiq, xkon.
Fixes #47985 .
Built from https://develop.svn.wordpress.org/trunk@47235
git-svn-id: http://core.svn.wordpress.org/trunk@47035 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 05:16:07 +00:00
4f151b577e
Administration: Standardize "found in Trash" messages.
...
Props Presskopp, audrasjb.
Fixes #38669 .
Built from https://develop.svn.wordpress.org/trunk@47234
git-svn-id: http://core.svn.wordpress.org/trunk@47034 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 04:57:06 +00:00
a6949956d1
Administration: Capitalize `Trash` consistently in various messages and comments.
...
When used as a noun referring to the "virtual" place, `Trash` should be capitalized.
Props garrett-eclipse, aandrewdixon, Presskopp.
Fixes #45317 .
Built from https://develop.svn.wordpress.org/trunk@47233
git-svn-id: http://core.svn.wordpress.org/trunk@47033 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 04:12:07 +00:00
32edd58e4c
Docs: Add descriptions for some globals:
...
* `$wp_version`
* `$wp_local_package`
* `$required_php_version`
* `$required_mysql_version`
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47230
git-svn-id: http://core.svn.wordpress.org/trunk@47030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 03:30:06 +00:00
e4f36258f9
Media: Ensure imgareaselect.js is not initialized twice for the same image. May happen when uploading an image into a post and then clicking on Edit Image.
...
Fixes #49262 .
Built from https://develop.svn.wordpress.org/trunk@47229
git-svn-id: http://core.svn.wordpress.org/trunk@47029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 02:54:05 +00:00
f13044b031
Editor: Add unique classes to `.post-attributes-label-wrapper` paragraphs for easier JS or CSS targeting.
...
Props sathyapulse, sabernhardt, garrett-eclipse, noisysocks.
Fixes #44408 .
Built from https://develop.svn.wordpress.org/trunk@47228
git-svn-id: http://core.svn.wordpress.org/trunk@47028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 02:29:06 +00:00
ddc8ddb294
Import: Remove "Blogroll" import option (for links in OPML format) from the list of popular importer plugins.
...
Link Manager is disabled for new installations since WordPress 3.5, so core should not encourage importing links.
See #meta4706 for the corresponding WordPress.org API change.
Props Ipstenu, hareesh-pillai, DrewAPicture, nacin, karmatosed, dd32, garrett-eclipse.
Fixes #22994 . See #21307 .
Built from https://develop.svn.wordpress.org/trunk@47227
git-svn-id: http://core.svn.wordpress.org/trunk@47027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 02:12:06 +00:00
95edb66e53
Login and Registration: Use CSS animation instead of old JavaScript code for "shake" animation on login failure.
...
Props markjaquith, valentinbora.
Fixes #48490 .
Built from https://develop.svn.wordpress.org/trunk@47226
git-svn-id: http://core.svn.wordpress.org/trunk@47026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-10 01:52:04 +00:00
61ce35440c
Editor: Fix incorrect usage of ID attributes on custom fields.
...
Repeated containers used for custom fields have duplicate ID attributes. Duplicate IDs are incorrect HTML, and will also cause unexpected results when trying to manipulate using JS. Duplicate IDs are changed to matching classes; CSS & JS updated to match.
Props jankimoradiya, audrasjb, donmhico, afercia.
Fixes #46964 .
Built from https://develop.svn.wordpress.org/trunk@47222
git-svn-id: http://core.svn.wordpress.org/trunk@47022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 19:41:07 +00:00
9429c8436d
Coding Standards: Correct the `get_plugin_page_hook()` check in `wp-admin/admin.php`.
...
The condition is meant to check for a non-empty string, however `get_plugin_page_hook()` can return null, in which case the strict check doesn't work as expected.
Follow-up to [47218].
See #48455 , #49222 .
Built from https://develop.svn.wordpress.org/trunk@47220
git-svn-id: http://core.svn.wordpress.org/trunk@47020 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 17:08:03 +00:00
641c632b0c
Coding Standards: Use Yoda conditions where appropriate.
...
See #49222 .
Built from https://develop.svn.wordpress.org/trunk@47219
git-svn-id: http://core.svn.wordpress.org/trunk@47019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 16:55:09 +00:00
5e6c949861
Coding Standards: Use Yoda conditions in some `wp-admin` files.
...
Props subrataemfluence, marcio-zebedeu, bookdude13, 1naveengiri, alishankhan.
Fixes #44365 , #48455 .
Built from https://develop.svn.wordpress.org/trunk@47218
git-svn-id: http://core.svn.wordpress.org/trunk@47018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 16:53:06 +00:00
e713bf9a88
Site Health: Only get MySQL server information in tests where it's actually needed.
...
This resolves an issue with plugins like HyperDB, which doesn't have a database connection until a query is made.
Props xkon, Otto42, Clorith.
See #47606 .
Built from https://develop.svn.wordpress.org/trunk@47215
git-svn-id: http://core.svn.wordpress.org/trunk@47015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-08 20:10:05 +00:00
01f133ee28
Accessibility: Menus: Make tab panels in `Add menu items` section more accessible for keyboard users.
...
Props audrasjb, afercia.
Fixes #49211 .
Built from https://develop.svn.wordpress.org/trunk@47209
git-svn-id: http://core.svn.wordpress.org/trunk@47009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 21:38:06 +00:00
052b8ebdbe
Accessibility: Customize: Improve focus styles for color picker and media upload button in Customizer.
...
Props audrasjb, timhavinga, afercia, karmatosed.
Fixes #48694 .
Built from https://develop.svn.wordpress.org/trunk@47208
git-svn-id: http://core.svn.wordpress.org/trunk@47008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 21:11:05 +00:00
b2a1146380
Coding Standards: Adjust coding standards to always omit parentheses for `include`/`require` statements.
...
These are language constructs, not function calls, so the parentheses are unnecessary.
This updates the PHPCS configuration file the enforce the sniff until it is moved from the `WordPress-Extra` ruleset to the `WordPress-Core` ruleset upstream.
Follow-up to [47198].
Props desrosj, jrf, GaryJ.
Fixes #49376 .
Built from https://develop.svn.wordpress.org/trunk@47207
git-svn-id: http://core.svn.wordpress.org/trunk@47007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 19:16:06 +00:00
1f1fd617f5
Posts, Post Types: Add a parameter to the `post_locked_dialog` action which contains a reference to the user who holds the lock.
...
Fixes #48443
Built from https://develop.svn.wordpress.org/trunk@47206
git-svn-id: http://core.svn.wordpress.org/trunk@47006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 17:53:06 +00:00
aea25de893
Media: Add link to the original image in the image properties if it was scaled or rotated after uploading.
...
Fixes #49290 .
Built from https://develop.svn.wordpress.org/trunk@47202
git-svn-id: http://core.svn.wordpress.org/trunk@47002 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-07 05:13:05 +00:00
47ed56f38f
Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant.
...
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.
This commit also includes:
* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
* `wp-admin/admin-header.php`
* `wp-admin/admin-footer.php`
* `wp-includes/version.php`
Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082 .
Built from https://develop.svn.wordpress.org/trunk@47198
git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 06:33:11 +00:00
9ed35cf902
Posts, Post Types: Change "Featured Image" post label to use sentence case: "Featured image".
...
This makes it more consistent with other UI elements in the block editor.
Props mcsf.
Fixes #49371 .
Built from https://develop.svn.wordpress.org/trunk@47194
git-svn-id: http://core.svn.wordpress.org/trunk@46994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 19:09:05 +00:00
0544629460
Posts, Post Types: Wrap text submitted via Quick Draft dashboard widget in the Paragraph block.
...
Props audrasjb, jeroenrotty.
Fixes #48120 .
Built from https://develop.svn.wordpress.org/trunk@47191
git-svn-id: http://core.svn.wordpress.org/trunk@46991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 08:10:05 +00:00
44288356e2
Menus: Introduce `wp_nav_menu_item_custom_fields` action that fires just before the move buttons of a nav menu item in the menu editor.
...
Props MikeSchinkel, birgire, sebastian.pisula, desrosj, helgatheviking.
Fixes #47056 . See #38904 , #18584 .
Built from https://develop.svn.wordpress.org/trunk@47190
git-svn-id: http://core.svn.wordpress.org/trunk@46990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 07:43:05 +00:00
84c43d1863
Docs: Correct type for `$item` and $args` parameters in `Walker_Nav_Menu_Checklist` and `Walker_Nav_Menu_Edit` to match the parent `Walker_Nav_Menu` class.
...
Follow-up to [38559], [45537].
See #24587 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@47189
git-svn-id: http://core.svn.wordpress.org/trunk@46989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 07:25:05 +00:00
c32e05f308
Site Health: Improve focus style for accordion items on Site Health screens.
...
The new style is more consistent with other elements like `.wp-core-ui` buttons.
Props audrasjb, mensmaximus, afercia, melchoyce, Clorith.
Fixes #48578 .
Built from https://develop.svn.wordpress.org/trunk@47188
git-svn-id: http://core.svn.wordpress.org/trunk@46988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 06:43:04 +00:00
be057c4a1c
Users: In `remove_user_from_blog()`:
...
* Change default value of the `$blog_id` parameter to match the documented type.
* Change the type of the `$reassign` parameter for consistency with `$user_id` and `$blog_id`.
* Add documentation for the return value.
See #49361 .
Built from https://develop.svn.wordpress.org/trunk@47173
git-svn-id: http://core.svn.wordpress.org/trunk@46973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 19:36:04 +00:00
8163215dc4
Plugins: Remove obsolete `plugin_slugs` transient from `WP_Plugins_List_Table::prepare_items()`.
...
The transient is only used in the `wp_dashboard_plugins_output()` function, which is deprecated and unused since [40607].
The function itself also sets the same transient, so it can be removed from `WP_Plugins_List_Table`.
Props aftabmuni.
Fixes #49340 .
Built from https://develop.svn.wordpress.org/trunk@47167
git-svn-id: http://core.svn.wordpress.org/trunk@46967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 15:50:04 +00:00
11fb46d4c6
Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode.
...
The original script was deprecated in [30338] and removed in [32677].
Props Presskopp, ketuchetan.
Fixes #39448 .
Built from https://develop.svn.wordpress.org/trunk@47164
git-svn-id: http://core.svn.wordpress.org/trunk@46964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 04:15:03 +00:00
c94722d9bc
Docs: Improve inline comments in `wp-admin/options.php` per the documentation standards.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47159
git-svn-id: http://core.svn.wordpress.org/trunk@46959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 02:42:04 +00:00
a0f8b7003b
Administration: Include options page name in the "Options page not found" error message to provide better context for plugin developers.
...
Props tdlewis77, williampatton.
Fixes #42941 .
Built from https://develop.svn.wordpress.org/trunk@47158
git-svn-id: http://core.svn.wordpress.org/trunk@46958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 22:42:06 +00:00
8e37999368
Docs: Correct DocBlock formatting for `register_setting()`.
...
Document the full list of whitelisted option key names.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47157
git-svn-id: http://core.svn.wordpress.org/trunk@46957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 22:01:07 +00:00
deb1886078
Accessibility: Text Changes: Use sentence case for the word `Error` in various error messages, instead of all caps.
...
Using all caps should be avoided for better readability and because screen readers may pronounce all-caps words as abbreviations.
Props afercia, ryokuhi, sabernhardt, garrett-eclipse.
See #47656 , #43037 , #42945 .
Built from https://develop.svn.wordpress.org/trunk@47156
git-svn-id: http://core.svn.wordpress.org/trunk@46956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 21:38:04 +00:00
2fe7c95153
Text Changes: Capitalize error messages consistently.
...
Props Presskopp.
Fixes #42945 .
Built from https://develop.svn.wordpress.org/trunk@47154
git-svn-id: http://core.svn.wordpress.org/trunk@46954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:55:05 +00:00
12a6907123
Text Changes: Add missing periods to some error messages, for consistency.
...
Props Presskopp.
Fixes #42735 .
Built from https://develop.svn.wordpress.org/trunk@47153
git-svn-id: http://core.svn.wordpress.org/trunk@46953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:32:05 +00:00
21548ad0de
Text Changes: Add missing periods to comment status update notices, for consistency.
...
Props Presskopp.
See #42735 .
Built from https://develop.svn.wordpress.org/trunk@47152
git-svn-id: http://core.svn.wordpress.org/trunk@46952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:29:05 +00:00
f65bc1401a
Networks and Sites: Reduce `max-width` for user and site search inputs on Dashboard screen in Network Admin.
...
This ensures that the inputs don't push the buttons to the next line.
Props williampatton, bordoni.
Fixes #49043 .
Built from https://develop.svn.wordpress.org/trunk@47151
git-svn-id: http://core.svn.wordpress.org/trunk@46951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 17:38:03 +00:00
06979c6597
Docs: Document the addition of `$json_report_pathname` parameter to the `wp_privacy_personal_data_export_file_created` action.
...
Follow-up to [47146].
Props xkon.
Fixes #49029 .
Built from https://develop.svn.wordpress.org/trunk@47150
git-svn-id: http://core.svn.wordpress.org/trunk@46950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 04:17:05 +00:00
0aff1cf6bd
Site Health: Rename `WP_Site_Health::initialize()` introduced in [47063] to `::get_instance()`, for clarity and consistency with other core classes.
...
Use `WP_Site_Health::get_instance()` where it's needed, instead of creating multiple instances of the class.
Props afercia, xkon, Clorith, SergeyBiryukov.
See #47606 .
Built from https://develop.svn.wordpress.org/trunk@47149
git-svn-id: http://core.svn.wordpress.org/trunk@46949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 00:39:09 +00:00
3cd1514b91
Privacy: Clarify bulk action labels for personal data export and removal requests.
...
Props garrett-eclipse, xkon, shariqkhan2012, websupporter, desrosj, JoshuaWold.
Fixes #44674 .
Built from https://develop.svn.wordpress.org/trunk@47148
git-svn-id: http://core.svn.wordpress.org/trunk@46948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 03:43:05 +00:00
aef48b433b
Accessibility: Privacy: Improve the readability of the suggested text in Privacy Policy Guide.
...
Per WCAG 2.0 guidelines, big chunks of italic text should be avoided for better accessibility.
Props birgire, sabernhardt, xkon, garrett-eclipse, melchoyce, karmatosed, afercia, jepperask, SergeyBiryukov.
Fixes #44621 . See #47327 .
Built from https://develop.svn.wordpress.org/trunk@47147
git-svn-id: http://core.svn.wordpress.org/trunk@46947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 03:25:05 +00:00
39cef6947a
Privacy: Introduce a JSON file into the personal data export.
...
The produced ZIP archive will now include an `export.json` file along with the current `index.html`.
Props xkon.
Fixes #49029 . See #46424 .
Built from https://develop.svn.wordpress.org/trunk@47146
git-svn-id: http://core.svn.wordpress.org/trunk@46946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 01:36:05 +00:00
eafc40be6d
Privacy: Remove user's email address from personal data export filename.
...
Use `wp_unique_filename()` to avoid potential collisions instead.
Props xkon, garrett-eclipse, donmhico, Ov3rfly, Clorith, allendav.
Fixes #44197 .
Built from https://develop.svn.wordpress.org/trunk@47144
git-svn-id: http://core.svn.wordpress.org/trunk@46944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 00:58:06 +00:00
4f67024da6
Administration: Add punctuation to "If you change this, we will send you an email" message on General Settings, Network Settings, and Profile screens.
...
Props kinjaldalwadi, donmhico.
Fixes #49235 .
Built from https://develop.svn.wordpress.org/trunk@47143
git-svn-id: http://core.svn.wordpress.org/trunk@46943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 00:28:04 +00:00
d3c032bc35
Dashboard: Improve the appearance of "WordPress Events and News" dashboard widget for multi-day events.
...
If an upcoming event spans over several days, this information is now properly reflected in the widget.
Props imath, casiepa, iandunn, hareesh-pillai, melchoyce, mapk, desrosj, audrasjb, SergeyBiryukov.
Fixes #47798 .
Built from https://develop.svn.wordpress.org/trunk@47124
git-svn-id: http://core.svn.wordpress.org/trunk@46924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 02:19:08 +00:00
b2ffea836b
Docs: Fix typos in `wp-admin/includes/class-pclzip.php`.
...
With the upstream library not updated in 10 years since the last time it was merged, it should be safe to treat it as "adopted" rather than external, and make these fixes.
Props passoniate, ottok.
Fixes #49163 . See #38464 .
Built from https://develop.svn.wordpress.org/trunk@47123
git-svn-id: http://core.svn.wordpress.org/trunk@46923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:56:04 +00:00
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
395ee12145
Docs: Improve comments in `js/_enqueues/wp/revisions.js` per the documentation standards.
...
Props passoniate.
Fixes #49177 .
Built from https://develop.svn.wordpress.org/trunk@47120
git-svn-id: http://core.svn.wordpress.org/trunk@46920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:37:04 +00:00
037a736757
Docs: Improve comments in some `wp-admin` files per the documentation standards.
...
Follow-up to [47084].
Props passoniate, apedog.
Fixes #49223 , #49227 .
Built from https://develop.svn.wordpress.org/trunk@47119
git-svn-id: http://core.svn.wordpress.org/trunk@46919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:35:08 +00:00
e65032ff6b
Coding Standards: Use strict comparison in `wp-admin/user/admin.php`.
...
Apply the case-insensitive network-site comparisons added in [27725] for `wp-admin/network/admin.php` to `wp-admin/user/admin.php` too, for consistency.
Props rimadoshi.
Fixes #49300 .
Built from https://develop.svn.wordpress.org/trunk@47115
git-svn-id: http://core.svn.wordpress.org/trunk@46915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-27 14:30:05 +00:00
b79e042b00
Docs: Remove extra trailing spaces from `wp_add_privacy_policy_content()` DocBlock to fix WPCS issues, apply minor formatting changes for consistency.
...
Follow-up to [47112].
See #49282 .
Built from https://develop.svn.wordpress.org/trunk@47113
git-svn-id: http://core.svn.wordpress.org/trunk@46913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-27 01:06:04 +00:00
516629964c
Privacy: Cleanup `.wp-policy-help` CSS remnants and add back-compat when hiding the tutorial content before copying.
...
Props garrett-eclipse.
Fixes #49282 .
Built from https://develop.svn.wordpress.org/trunk@47112
git-svn-id: http://core.svn.wordpress.org/trunk@46912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-26 23:02:03 +00:00
cfa3dc8ee8
Docs: Correct `@return` value for `parent_dropdown()`.
...
Follow-up to [47100].
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47102
git-svn-id: http://core.svn.wordpress.org/trunk@46902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-22 00:33:04 +00:00
eb513c5ac8
Docs: Adjust `@return` value of `parent_dropdown()` for consistency with other dropdown functions.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47100
git-svn-id: http://core.svn.wordpress.org/trunk@46900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-22 00:22:03 +00:00
381df97419
Docs: Correct `@return` value for `update_core()` and `Core_Upgrader::upgrade()`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47099
git-svn-id: http://core.svn.wordpress.org/trunk@46899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-22 00:19:04 +00:00
60c651ad6a
I18N: Add missing placeholders to some translators comments in `wp-admin`.
...
Props ramiy.
Fixes #49248 .
Built from https://develop.svn.wordpress.org/trunk@47093
git-svn-id: http://core.svn.wordpress.org/trunk@46893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-20 15:43:04 +00:00
c946a71d9d
I18N: Correct translator comment in `wp-admin/options-permalink.php`.
...
Props ramiy.
Fixes #49247 .
Built from https://develop.svn.wordpress.org/trunk@47092
git-svn-id: http://core.svn.wordpress.org/trunk@46892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-20 15:10:04 +00:00
1adca958e3
I18N: Remove unnecessary HTML from "Active:" strings in `wp-admin/themes.php`.
...
Follow-up to [45435].
Props ramiy.
Fixes #49243 .
Built from https://develop.svn.wordpress.org/trunk@47090
git-svn-id: http://core.svn.wordpress.org/trunk@46890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-20 14:27:04 +00:00
d5be8f0635
I18N: Correct translator comments in `WP_Users_List_Table::get_views()` to provide information about each placeholder.
...
Props ramiy.
Fixes #49242 .
Built from https://develop.svn.wordpress.org/trunk@47089
git-svn-id: http://core.svn.wordpress.org/trunk@46889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-20 14:08:05 +00:00
2900bb8ea7
Docs: Update links to https://secure.php.net/ , they now redirect to https://www.php.net/ .
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47088
git-svn-id: http://core.svn.wordpress.org/trunk@46888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-20 03:14:06 +00:00
89f5d3dd0c
Networks and Sites: Clarify the recommendation to remove the `www` prefix from the site domain before creating a network.
...
The `siteurl` option reference was not quite clear, and the string actually refers to the domain name, not the full URL.
Props kharisblank, tobifjellner, ramiy.
Fixes #49214 .
Built from https://develop.svn.wordpress.org/trunk@47085
git-svn-id: http://core.svn.wordpress.org/trunk@46885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-18 01:15:04 +00:00
053a9cd5b8
Docs: Improve comments in some `wp-admin` files per the documentation standards.
...
Props passoniate.
Fixes #49215 , #49216 .
Built from https://develop.svn.wordpress.org/trunk@47084
git-svn-id: http://core.svn.wordpress.org/trunk@46884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-18 00:54:04 +00:00
1cfc32af58
Coding Standards: Remove unnecessary `// phpcs:ignore` instances in `WP_Debug_Data`.
...
`WP_Theme::__get()` accepts `Name`, `Version`, and `Author` theme properties in lower case too.
Additionally, remove one short ternary instance, not allowed per the coding standards.
See #49222 .
Built from https://develop.svn.wordpress.org/trunk@47083
git-svn-id: http://core.svn.wordpress.org/trunk@46883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-18 00:26:06 +00:00
0f47f2b9e5
Widgets: Remove extra padding from number inputs in Recent Posts and Recent Comments widgets.
...
Props marcio-zebedeu, audrasjb, SergeyBiryukov.
Fixes #49195 .
Built from https://develop.svn.wordpress.org/trunk@47082
git-svn-id: http://core.svn.wordpress.org/trunk@46882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-17 13:57:03 +00:00
691adde1e6
Date/Time: Use `wp_date()` to display the correct time of the next DST transition in Timezone setting on General Settings screen.
...
Props Rarst, autotutorial.
Fixes #49038 .
Built from https://develop.svn.wordpress.org/trunk@47073
git-svn-id: http://core.svn.wordpress.org/trunk@46873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-16 00:28:06 +00:00
3e68a63e6a
Editor: Correct vertical alignment for "Published on" month dropdown in Classic Editor.
...
Props pratik-jain, justinahinon, audrasjb.
Fixes #49115 .
Built from https://develop.svn.wordpress.org/trunk@47072
git-svn-id: http://core.svn.wordpress.org/trunk@46872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-15 18:31:07 +00:00
57fbd3c847
File Editor: Remove extra padding on submit button for "Select plugin/theme to edit" dropdown on smaller screens.
...
Props passoniate.
Fixes #49197 .
Built from https://develop.svn.wordpress.org/trunk@47071
git-svn-id: http://core.svn.wordpress.org/trunk@46871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-15 00:23:07 +00:00
569ff9dd27
Upgrade/Install: Correct vertical alignment for "Continue" button on language selection during the install process.
...
Props garrett-eclipse, audrasjb.
Fixes #49018 .
Built from https://develop.svn.wordpress.org/trunk@47070
git-svn-id: http://core.svn.wordpress.org/trunk@46870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-14 01:11:03 +00:00
10ae398727
Site Health: Avoid "Undefined property" PHP notices in `wp_dashboard_site_health()` when the status result transient does not exist yet.
...
Props dlh for initial patch.
See #47606 .
Built from https://develop.svn.wordpress.org/trunk@47069
git-svn-id: http://core.svn.wordpress.org/trunk@46869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-13 17:27:06 +00:00
f18b173674
Networks and Sites: Use `warning` styles for 'Caution' and 'Warning' messages during Multisite installation.
...
Props dlh.
Fixes #49186 .
Built from https://develop.svn.wordpress.org/trunk@47067
git-svn-id: http://core.svn.wordpress.org/trunk@46867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-13 17:00:06 +00:00
fa2f6e0644
Docs: Improve documentation for `wp_save_image_file()` and related functions.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47065
git-svn-id: http://core.svn.wordpress.org/trunk@46865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-12 16:56:05 +00:00
2c4480958b
Site Health: Introduce Site Health Status dashboard widget.
...
The widget informs administrators of any potential issues that should be addressed to improve the performance or security of their website, and directs them to the Site Health screen for more details.
Props Clorith, hedgefield, guddu1315.
See #47606 .
Built from https://develop.svn.wordpress.org/trunk@47063
git-svn-id: http://core.svn.wordpress.org/trunk@46863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-12 13:33:05 +00:00
f8a5ae6b93
Upgrade/Install: Remove the suggestion for users to skip a minor update to keep their current translation.
...
With the introduction of asynchronous translation updates in WordPress 3.7+, the suggestion is no longer relevant.
Props casiepa, danieltj, tobifjellner, netweb.
Fixes #43242 .
Built from https://develop.svn.wordpress.org/trunk@47061
git-svn-id: http://core.svn.wordpress.org/trunk@46861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-12 02:24:03 +00:00
dd4d98a368
Docs: In various `@return` tags, list the expected type first, instead of `false`.
...
Follow-up to [46696].
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47060
git-svn-id: http://core.svn.wordpress.org/trunk@46860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 18:32:05 +00:00
2294d65753
Docs: Synchronize `@return` descriptions for `::handle_row_actions()` methods in list tables.
...
Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes.
See #49170 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@47059
git-svn-id: http://core.svn.wordpress.org/trunk@46859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 17:59:04 +00:00
d469aa8162
Docs: Correct `@return` description for `WP_List_Table::handle_row_actions()`.
...
Props pbiron.
Fixes #49170 .
Built from https://develop.svn.wordpress.org/trunk@47058
git-svn-id: http://core.svn.wordpress.org/trunk@46858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 17:57:03 +00:00
6a3deacf86
Docs: Correct `@return` type for `Theme_Upgrader::check_parent_theme_filter()`.
...
Props diddledan.
Fixes #48570 .
Built from https://develop.svn.wordpress.org/trunk@47057
git-svn-id: http://core.svn.wordpress.org/trunk@46857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 02:46:05 +00:00
d3d630c98a
Site Health: Make sure the "Copied!" text is vertically centered to the "Copy site info to clipboard" button.
...
Props garrett-eclipse.
Fixes #49139 .
Built from https://develop.svn.wordpress.org/trunk@47047
git-svn-id: http://core.svn.wordpress.org/trunk@46847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-07 00:09:04 +00:00
667f26b3af
I18N: Replace `php.ini`, `post_max_size`, and `upload_max_filesize` with placeholders in "File is empty" error message.
...
Props ramiy.
Fixes #48868 .
Built from https://develop.svn.wordpress.org/trunk@47043
git-svn-id: http://core.svn.wordpress.org/trunk@46843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-06 16:16:03 +00:00
6a3a0b519c
Docs: Fix typo in `media_post_single_attachment_fields_to_edit()` description.
...
Props mukesh27.
Fixes #49131 .
Built from https://develop.svn.wordpress.org/trunk@47039
git-svn-id: http://core.svn.wordpress.org/trunk@46839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-04 18:00:06 +00:00
8ec3da8a25
Site Health: Fix typo in a variable name in `js/_enqueues/admin/site-health.js`.
...
Props nickylimjj.
Fixes #49112 .
Built from https://develop.svn.wordpress.org/trunk@47031
git-svn-id: http://core.svn.wordpress.org/trunk@46831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-02 12:11:02 +00:00
6357cae029
Docs: Fix typo in `_crop_image_resource()` DocBlock.
...
Props mukesh27.
Fixes #49103 .
Built from https://develop.svn.wordpress.org/trunk@47024
git-svn-id: http://core.svn.wordpress.org/trunk@46824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-31 12:34:01 +00:00
7970e62c06
Coding Standards: Fix WPCS issue in [47015].
...
See #49082 .
Built from https://develop.svn.wordpress.org/trunk@47016
git-svn-id: http://core.svn.wordpress.org/trunk@46816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-26 15:53:02 +00:00
7c2275dfe4
Docs: Fix typo in `wp_dashboard_cached_rss_widget()` documentation.
...
Props mukesh27.
Fixes #49082 .
Built from https://develop.svn.wordpress.org/trunk@47015
git-svn-id: http://core.svn.wordpress.org/trunk@46815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-26 14:42:03 +00:00
bb70f4e530
Docs: Correct the note about the `CORE_UPGRADE_SKIP_NEW_BUNDLED` constant in `$_new_bundled_files` global description.
...
In order to tell WordPress not to install new bundled themes on update, `CORE_UPGRADE_SKIP_NEW_BUNDLED` should be set to `true`, as the name suggests, not `false`.
Follow-up to [39064].
Props tomgreer, knutsp, crdunst.
See #49056 .
Built from https://develop.svn.wordpress.org/trunk@47007
git-svn-id: http://core.svn.wordpress.org/trunk@46807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-23 18:00:02 +00:00
246a035d99
Docs: Improve documentation for admin menu functions:
...
* `get_admin_page_parent()`
* `get_admin_page_title()`
* `get_plugin_page_hook()`
* `get_plugin_page_hookname()`
* `user_can_access_admin_page()`
Add missing descriptions and `@since` tags.
Props subrataemfluence, kennithnichol, stevenlinx, SergeyBiryukov.
Fixes #44253 , #49067 .
Built from https://develop.svn.wordpress.org/trunk@47006
git-svn-id: http://core.svn.wordpress.org/trunk@46806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-23 14:36:04 +00:00
f501814eac
Upgrade/Install: When creating the `.htaccess` file in `insert_with_markers()`, make sure it has `0644` as a minimum set of permissions.
...
Props rcutmore, dd32, i3anaan.
Fixes #40572 .
Built from https://develop.svn.wordpress.org/trunk@47005
git-svn-id: http://core.svn.wordpress.org/trunk@46805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-22 02:45:03 +00:00
4edec193bc
Users: When creating the first user on installation, populate the Website profile field with the site URL.
...
Skip setting the field if the user already exists, which is the case when the user tables are being shared among multiple sites.
Props EFAREM, eclare, darrenlambert, zachflauaus, viralsampat.
Fixes #35778 .
Built from https://develop.svn.wordpress.org/trunk@46989
git-svn-id: http://core.svn.wordpress.org/trunk@46789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-18 02:26:03 +00:00
bbd898b1dd
Upgrade/Install: Remove unused global in `upgrade_430_fix_comments()`.
...
Props adnan.limdi.
Fixes #41970 .
Built from https://develop.svn.wordpress.org/trunk@46972
git-svn-id: http://core.svn.wordpress.org/trunk@46772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 16:45:03 +00:00
c67c3ee6a0
Fix the colors in all color schemes for the `.active` class for buttons.
...
Props ryelle, audrasjb.
Fixes #49003 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46967
git-svn-id: http://core.svn.wordpress.org/trunk@46767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 00:15:03 +00:00
8894c0f1a2
Coding Standards: Use strict comparison in `wp-admin/widgets.php`.
...
Props jenilk.
Fixes #49000 .
Built from https://develop.svn.wordpress.org/trunk@46964
git-svn-id: http://core.svn.wordpress.org/trunk@46764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-16 12:55:03 +00:00
5b9fd2d7e7
Coding Standards: Use strict comparison in `wp-admin/includes/network.php`.
...
Props ataurr.
Fixes #48994 .
Built from https://develop.svn.wordpress.org/trunk@46963
git-svn-id: http://core.svn.wordpress.org/trunk@46763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-16 12:37:06 +00:00
6d40400756
Coding Standards: Use strict comparison in `wp-admin/edit-tags.php`.
...
Props passoniate.
Fixes #48985 .
Built from https://develop.svn.wordpress.org/trunk@46962
git-svn-id: http://core.svn.wordpress.org/trunk@46762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-15 10:46:02 +00:00
087282e810
Coding Standards: Use strict comparison in `wp-admin/term.php`.
...
Props vinita29.
Fixes #48983 .
Built from https://develop.svn.wordpress.org/trunk@46961
git-svn-id: http://core.svn.wordpress.org/trunk@46761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-15 09:45:01 +00:00
0b8438a6d2
I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders.
...
Props ramiy.
Fixes #48863 .
Built from https://develop.svn.wordpress.org/trunk@46957
git-svn-id: http://core.svn.wordpress.org/trunk@46756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-13 21:27:05 +00:00
db18e7d50b
Upgrade/Install: Improve the appearance of language selection on install:
...
* Remove a stray chevron.
* Improve focus and hover styles.
Props garrett-eclipse, audrasjb.
Fixes #48927 .
Built from https://develop.svn.wordpress.org/trunk@46887
git-svn-id: http://core.svn.wordpress.org/trunk@46687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 23:03:03 +00:00
9b91ffde04
Docs: Improve documentation for `wp_dashboard_browser_nag()` and `dashboard_browser_nag_class()`.
...
Props grapplerulrich.
Fixes #48932 .
Built from https://develop.svn.wordpress.org/trunk@46880
git-svn-id: http://core.svn.wordpress.org/trunk@46680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 10:59:05 +00:00
6ddf02b188
Menus: Avoid a PHP warning in `add_submenu_page()` when the same value is passed for both `$parent_slug` and `$menu_slug` parameters.
...
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Fixes #48599 .
Built from https://develop.svn.wordpress.org/trunk@46868
git-svn-id: http://core.svn.wordpress.org/trunk@46668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 21:03:02 +00:00
a209908501
Administration: Standardize form control height and alignment across the admin.
...
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.
Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Fixes #48420 .
Built from https://develop.svn.wordpress.org/trunk@46866
git-svn-id: http://core.svn.wordpress.org/trunk@46666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 20:26:03 +00:00
dd47d5aa81
Media: Use consistent width for Scale and Crop inputs.
...
Follow-up to [46359].
Props sabernhardt, audrasjb.
Fixes #48907 .
Built from https://develop.svn.wordpress.org/trunk@46856
git-svn-id: http://core.svn.wordpress.org/trunk@46656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 16:23:02 +00:00
9648c368f0
Help/About: Add a hover effect for links on About pages.
...
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.
Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Fixes #48582 .
Built from https://develop.svn.wordpress.org/trunk@46852
git-svn-id: http://core.svn.wordpress.org/trunk@46652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 15:31:05 +00:00
dcf0cb68a2
Administration: Correct checkbox width in list tables on smaller screens.
...
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.
Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Fixes #48815 .
Built from https://develop.svn.wordpress.org/trunk@46845
git-svn-id: http://core.svn.wordpress.org/trunk@46645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 14:26:02 +00:00
ac690426eb
Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created.
...
This ensures that the actual UI controls state matches the visually conveyed state.
Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Fixes #48409 .
Built from https://develop.svn.wordpress.org/trunk@46842
git-svn-id: http://core.svn.wordpress.org/trunk@46642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:49:03 +00:00
d53103ed62
Docs: Further docblock corrections and improvements.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46826
git-svn-id: http://core.svn.wordpress.org/trunk@46626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-07 13:23:01 +00:00
f93ee2ca76
Docs: Increase the specificity of various docblock parameter types and return types.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46823
git-svn-id: http://core.svn.wordpress.org/trunk@46623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 22:43:04 +00:00
aa1fdcbd52
Docs: Correct various docblocks documentation.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46821
git-svn-id: http://core.svn.wordpress.org/trunk@46621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 22:23:04 +00:00
7d84502589
Text Changes: Rename Comment Blacklist option to be more inclusive
...
This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive.
Props dartiss, jeremyfelt, aaronjorbin.
Fixes #48900 .
Built from https://develop.svn.wordpress.org/trunk@46820
git-svn-id: http://core.svn.wordpress.org/trunk@46620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 18:12:02 +00:00
2165eef44c
Accessibility: Administration: Correct active button color for the alternative color schemes.
...
Follow-up to [46815].
Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598 .
Built from https://develop.svn.wordpress.org/trunk@46817
git-svn-id: http://core.svn.wordpress.org/trunk@46617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 22:12:03 +00:00
20e18613d0
Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.
...
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.
Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585 .
Built from https://develop.svn.wordpress.org/trunk@46815
git-svn-id: http://core.svn.wordpress.org/trunk@46615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 21:32:03 +00:00
38ad319fdf
I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings.
...
Props ramiy.
Fixes #48875 .
Built from https://develop.svn.wordpress.org/trunk@46812
git-svn-id: http://core.svn.wordpress.org/trunk@46612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-04 10:36:01 +00:00
a5e52e04ee
Docs: Move the canonical DocBlock for `handle_bulk_actions-{$screen}` action to `wp-admin/edit.php`.
...
* Document accepted values for the `$items` parameter.
* Use interpolated syntax for the filter name.
Props dilipbheda, johnbillion, SergeyBiryukov.
Fixes #48857 .
Built from https://develop.svn.wordpress.org/trunk@46811
git-svn-id: http://core.svn.wordpress.org/trunk@46611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-03 13:58:05 +00:00
135e608b46
Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original.
...
Fixes #48736 .
Built from https://develop.svn.wordpress.org/trunk@46809
git-svn-id: http://core.svn.wordpress.org/trunk@46609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-01 18:26:05 +00:00
0221a593b9
Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile.
...
Props donmhico, jeremyfelt.
Fixes #48799 .
Built from https://develop.svn.wordpress.org/trunk@46807
git-svn-id: http://core.svn.wordpress.org/trunk@46607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-30 00:42:01 +00:00
1d1c74385f
REST API: Use strict `in_array()` checks for the list of usernames blacklisted via `illegal_user_logins` filter.
...
See #48839 .
Built from https://develop.svn.wordpress.org/trunk@46804
git-svn-id: http://core.svn.wordpress.org/trunk@46604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 22:04:02 +00:00
2a0489ec49
Docs: Replace `@returns` tags in JS docs with `@return`.
...
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46800
git-svn-id: http://core.svn.wordpress.org/trunk@46600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 18:01:03 +00:00
4a4afbd68c
Docs: Add missing full stops to `@returns` tags in JS docs, per the documentation standards.
...
Props shital-patel, kalpshit.
Fixes #48305 .
Built from https://develop.svn.wordpress.org/trunk@46799
git-svn-id: http://core.svn.wordpress.org/trunk@46599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 16:56:02 +00:00
acd0a3ca99
Site Health: Add a test for PHP default timezone.
...
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.
WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.
Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692 .
Built from https://develop.svn.wordpress.org/trunk@46797
git-svn-id: http://core.svn.wordpress.org/trunk@46597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 15:48:03 +00:00
6f86cedb09
Menus: Improve the wording of instructions for dragging the items into the preferred order.
...
Props amolv, equin0x80, dlh.
Fixes #48184 .
Built from https://develop.svn.wordpress.org/trunk@46791
git-svn-id: http://core.svn.wordpress.org/trunk@46591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 19:51:01 +00:00
d8b251f0af
Administration: Properly wrap long titles in list tables on smaller screens.
...
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805 .
Built from https://develop.svn.wordpress.org/trunk@46790
git-svn-id: http://core.svn.wordpress.org/trunk@46590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 16:52:02 +00:00
f4165a697d
Upgrade/Install: Provide a default label for "Continue" button in language selection form.
...
Prevents an empty continue button if a translation isn't yet available.
Props sathyapulse.
Fixes #48776 .
Built from https://develop.svn.wordpress.org/trunk@46784
git-svn-id: http://core.svn.wordpress.org/trunk@46584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-26 15:19:04 +00:00
63fefb540a
Users: Use correct variable when displaying the Additional Capabilities list in user profile.
...
Addresses a regression in [45926].
Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725 .
Built from https://develop.svn.wordpress.org/trunk@46782
git-svn-id: http://core.svn.wordpress.org/trunk@46582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 14:01:03 +00:00
2a85fe21d8
Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined:
...
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box
Split "Manage widgets or menus" into separate items for consistency with other links.
For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.
Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone
Props afercia, audrasjb, karmatosed.
Fixes #48406 .
Built from https://develop.svn.wordpress.org/trunk@46770
git-svn-id: http://core.svn.wordpress.org/trunk@46570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 19:57:05 +00:00
c786eaa1df
Coding Standards: Fix WPCS issue in [46763].
...
See #48777 .
Built from https://develop.svn.wordpress.org/trunk@46764
git-svn-id: http://core.svn.wordpress.org/trunk@46564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 19:21:03 +00:00
26a750e162
Docs: Add missing `@since` tags for functions in `wp-admin/includes/update.php`.
...
Props sathyapulse, zodiac1978.
Fixes #48777 .
Built from https://develop.svn.wordpress.org/trunk@46763
git-svn-id: http://core.svn.wordpress.org/trunk@46563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 18:51:01 +00:00
56af5db74f
Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.
...
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592 .
Built from https://develop.svn.wordpress.org/trunk@46758
git-svn-id: http://core.svn.wordpress.org/trunk@46558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-22 00:04:02 +00:00
44d5372825
I18N: Correct translator comment for `By %s` string in Plugins list table.
...
Follow-up to [44541].
See #45898 .
Built from https://develop.svn.wordpress.org/trunk@46755
git-svn-id: http://core.svn.wordpress.org/trunk@46555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-21 00:08:02 +00:00
71725aeb95
Accessibility: Add an `aria-current` attribute to the Media Library switch links.
...
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.
Props mayanksonawat, afercia.
Fixes #48271 .
Built from https://develop.svn.wordpress.org/trunk@46746
git-svn-id: http://core.svn.wordpress.org/trunk@46546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 16:51:02 +00:00
eec579dd86
Widgets: Avoid to move focus to the Image Widget "Insert from URL" field.
...
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169 .
Props dufresnesteven.
See #43169 .
Fixes #48588 .
Built from https://develop.svn.wordpress.org/trunk@46745
git-svn-id: http://core.svn.wordpress.org/trunk@46545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 16:23:02 +00:00
306045277e
Administration: Switch `rgb()` CSS property for paused plugin error message in Plugins list table to `rgba()`.
...
While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.
Props manikmist09.
Fixes #48629 .
Built from https://develop.svn.wordpress.org/trunk@46744
git-svn-id: http://core.svn.wordpress.org/trunk@46544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 13:18:03 +00:00
5aa3a51264
Docs: Update broken source code link in `WP_Filesystem_SSH2` class.
...
Props mryoga, finchps.
Fixes #48467 .
Built from https://develop.svn.wordpress.org/trunk@46742
git-svn-id: http://core.svn.wordpress.org/trunk@46542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 16:16:02 +00:00
418db0297e
Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages.
...
Props garrett-eclipse.
Fixes #48676 .
Built from https://develop.svn.wordpress.org/trunk@46739
git-svn-id: http://core.svn.wordpress.org/trunk@46539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 07:43:01 +00:00
927aa4b44c
Docs: Fix typo in `wp_credits_section_title()` description.
...
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.
Props hareesh-pillai.
Fixes #48674 .
Built from https://develop.svn.wordpress.org/trunk@46738
git-svn-id: http://core.svn.wordpress.org/trunk@46538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-16 21:04:01 +00:00
4ec53dc54c
Docs: Remove incorrect `@return` tags.
...
Props diddledan.
Fixes #48613 , #48614 .
Built from https://develop.svn.wordpress.org/trunk@46732
git-svn-id: http://core.svn.wordpress.org/trunk@46532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-14 09:57:03 +00:00
6ceb0279af
Help/About: Move images to the CDN.
...
Props ryelle.
Fixes #47708 .
Built from https://develop.svn.wordpress.org/trunk@46724
git-svn-id: http://core.svn.wordpress.org/trunk@46524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 18:30:03 +00:00
2265c36568
Help/About: Update the 5.3 About page.
...
* Remove extra padding on the Credits tab.
Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46709
git-svn-id: http://core.svn.wordpress.org/trunk@46509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 20:45:04 +00:00
ba249d8951
Help/About: Update the 5.3 About page.
...
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.
Previously [46556], [46572], [46616].
Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46705
git-svn-id: http://core.svn.wordpress.org/trunk@46505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 16:07:03 +00:00
3d623995a8
Docs: In various `@return` tags, list the expected type first, instead of `WP_Error`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46696
git-svn-id: http://core.svn.wordpress.org/trunk@46496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 02:43:03 +00:00
82dfb2d151
Docs: Miscellaneous docblock corrections in `wp-admin/includes/plugin.php`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46695
git-svn-id: http://core.svn.wordpress.org/trunk@46495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 00:05:01 +00:00
2af39e45cb
Docs: Improve documentation for `deactivate_plugins()` and `activate_plugins()`.
...
Props marekdedic, spenserhale, SergeyBiryukov.
Fixes #48352 .
Built from https://develop.svn.wordpress.org/trunk@46694
git-svn-id: http://core.svn.wordpress.org/trunk@46494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-10 23:05:03 +00:00
0e79d4d101
Coding Standards: Fix WPCS issue in [46684].
...
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46687
git-svn-id: http://core.svn.wordpress.org/trunk@46487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 13:33:02 +00:00
1f816ad18d
Docs: Use the `{@see ...}` tag for the replacement in `@deprecated` tags, so that Developer Reference could automatically link to the replacement.
...
Props jrf.
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46685
git-svn-id: http://core.svn.wordpress.org/trunk@46485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 13:05:02 +00:00
f60094679f
Coding Standards: Consistently use `do_action_deprecated()` and `apply_filters_deprecated()` for deprecated hooks.
...
Props jrf.
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46684
git-svn-id: http://core.svn.wordpress.org/trunk@46484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 12:59:03 +00:00
ba21b391f6
Docs: Correct some inconsistencies in comments with Dashicon class references in `wp-admin/css/customize-widgets.css`.
...
Prepend all class name references with `dashicons-` for clarity.
Props 1naveengiri, marcio-zebedeu, hareesh-pillai, SergeyBiryukov.
Fixes #48417 .
Built from https://develop.svn.wordpress.org/trunk@46681
git-svn-id: http://core.svn.wordpress.org/trunk@46481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 00:03:02 +00:00
15a4289c8d
Docs: Correct description for `$recursive` parameter of `::chmod()` and `::delete()` methods in `WP_Filesystem` implementations.
...
Props skithund.
Fixes #48422 .
Built from https://develop.svn.wordpress.org/trunk@46679
git-svn-id: http://core.svn.wordpress.org/trunk@46479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-08 22:56:02 +00:00
60c2966222
Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in `wp_get_missing_image_subsizes()`. Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold.
...
Props desrosj, azaozz.
Fixes #48518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46677
git-svn-id: http://core.svn.wordpress.org/trunk@46477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-07 18:51:02 +00:00
eda6a9e111
Docs: Docs on docs. Further improve documentation of known return types, plus other docs fixes.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46662
git-svn-id: http://core.svn.wordpress.org/trunk@46462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 21:30:03 +00:00
f9e81c83d5
Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image.
...
Props ianmjones, azaozz.
Fixes #48453 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46658
git-svn-id: http://core.svn.wordpress.org/trunk@46458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 20:53:03 +00:00
43ed67661a
Upload: Ensure the new image meta is always saved before starting post-processing of an uploaded image, even if there was an error while scaling or rotating it.
...
See #48472 .
Built from https://develop.svn.wordpress.org/trunk@46651
git-svn-id: http://core.svn.wordpress.org/trunk@46451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 17:07:03 +00:00
8b76312eb3
Docs: Correct some array hash notations added in [46644].
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46647
git-svn-id: http://core.svn.wordpress.org/trunk@46447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 09:37:02 +00:00
b3d6acd6a4
Docs: Fix some incorrect return tags in docblocks.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46644
git-svn-id: http://core.svn.wordpress.org/trunk@46444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:23:01 +00:00
a87271af60
Login and Registration: Allow email logins to be more flexible.
...
Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen.
Fixes #38744
Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@46640
git-svn-id: http://core.svn.wordpress.org/trunk@46440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 20:12:02 +00:00
583e49d95f
Customize: Formally deprecate unused Customizer classes.
...
The `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` PHP classes and `wp.customize.Menus.NewMenuControl` JS class were deprecated in 4.9 through [42034] with the intention of removing them in 5.0. Since more time has passed than originally intended, this change leaves `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` to prevent any potential backwards compatibility issues, and formally deprecates them. The `wp.customize.Menus.NewMenuControl` JS class is removed.
Props weston.ruter, matthias-reuter, jrf.
Fixes #42364 .
Built from https://develop.svn.wordpress.org/trunk@46637
git-svn-id: http://core.svn.wordpress.org/trunk@46437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 16:48:00 +00:00
2651ff3ae8
Docs: Update URLs in some `@link` tags and switch them to HTTPS.
...
Props tsuyoring.
Fixes #48479 .
Built from https://develop.svn.wordpress.org/trunk@46626
git-svn-id: http://core.svn.wordpress.org/trunk@46423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-01 14:57:02 +00:00
d1b23193dd
Docs: Correct some incorrect docblock tags.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46623
git-svn-id: http://core.svn.wordpress.org/trunk@46420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-31 17:51:01 +00:00
3d76b537d6
Docs: Add `@since` tag for the `$context` parameter added to `wp_generate_attachment_metadata` filter in [46621].
...
See #48472 .
Built from https://develop.svn.wordpress.org/trunk@46622
git-svn-id: http://core.svn.wordpress.org/trunk@46419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-31 00:13:01 +00:00
ed651b17a4
Upload:
...
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting post-processing.
Fixes #48472 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46621
git-svn-id: http://core.svn.wordpress.org/trunk@46418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-30 21:10:04 +00:00
0b94025ba9
Help/About: Update the 5.3 About page for RC3.
...
Previously [46556], [46572].
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46616
git-svn-id: http://core.svn.wordpress.org/trunk@46413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-29 20:10:04 +00:00
057f661ce3
Docs: Miscellaneous docblock corrections.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46610
git-svn-id: http://core.svn.wordpress.org/trunk@46407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 19:48:01 +00:00
c8f91f77ac
Docs: Correct invalid hook docblocks.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46603
git-svn-id: http://core.svn.wordpress.org/trunk@46400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 19:11:02 +00:00
9e2b6902b3
Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46597
git-svn-id: http://core.svn.wordpress.org/trunk@46394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 23:16:04 +00:00
3caaa40fc6
Docs: Switch more docs over to typed array notation, plus some fixes.
...
See #48303 , #41756
Built from https://develop.svn.wordpress.org/trunk@46596
git-svn-id: http://core.svn.wordpress.org/trunk@46393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 21:09:04 +00:00
7c2b9f2a2e
Docs: Miscellaneous docblock fixes and improvements.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46594
git-svn-id: http://core.svn.wordpress.org/trunk@46391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 20:43:04 +00:00
67ce1885db
Docs: Improve formatting of various `WP_Screen` DocBlocks.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46591
git-svn-id: http://core.svn.wordpress.org/trunk@46388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 00:36:05 +00:00
67c73ea3ea
Docs: Improve documentation for `WP_Screen::add_help_tab()`.
...
Props atachibana.
Fixes #48395 .
Built from https://develop.svn.wordpress.org/trunk@46590
git-svn-id: http://core.svn.wordpress.org/trunk@46387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 00:34:07 +00:00
49007e52bc
Build/Test Tools: Add banner to RTL CSS and minified JS files.
...
Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto-generated.
This is a follow-up to [41271], which added the banner to minified CSS files.
Fixes #48424 . See #30666 .
Built from https://develop.svn.wordpress.org/trunk@46589
git-svn-id: http://core.svn.wordpress.org/trunk@46386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 00:17:07 +00:00
7e11e9d732
Posts, Post Types: Remove unintended change from [46578].
...
See #48384 .
Built from https://develop.svn.wordpress.org/trunk@46579
git-svn-id: http://core.svn.wordpress.org/trunk@46376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 12:54:03 +00:00
0b83bffd45
Date/Time: Correct the logic in `WP_Posts_List_Table::column_date()` and `WP_Media_List_Table::column_date()` to check for a valid post timestamp.
...
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384 .
Built from https://develop.svn.wordpress.org/trunk@46578
git-svn-id: http://core.svn.wordpress.org/trunk@46375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 12:51:03 +00:00
5b85aa1936
Accessibility: Restore the primary buttons original background color for alternate color schemes after [46241].
...
Props david.binda, audrasjb, azaozz.
See #34904 .
Fixes #48396 .
Built from https://develop.svn.wordpress.org/trunk@46575
git-svn-id: http://core.svn.wordpress.org/trunk@46372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-23 20:57:05 +00:00
27994975f9
Help/About: Update the 5.3 About page for RC2.
...
This includes numerous improvements:
- Removes the jazzer name.
- Ensures `WordPress` is translatable for consistency with other occurrences in Core.
- Changes all instances of `Block Editor` to `block editor` to match the spelling best practices.
- Updates the PHP 7.4 compatibility section with more suitable text.
- Introduction in `credits.php`, `freedoms.php`, and `privacy.php` have been updated to be consistent with the About page.
- Fixes the `aria-current` attribute in tab navigation.
Reviewed by SergeyBiryukov, desrosj.
Props SergeyBiryukov, audrasjb, desrosj, ryelle, afercia.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46572
git-svn-id: http://core.svn.wordpress.org/trunk@46369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 19:19:07 +00:00
0609e04266
Administration: Relax the default value check for the `$position` argument added to `add_submenu_page()` and related functions in [46197].
...
Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues.
A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type.
Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249 .
Built from https://develop.svn.wordpress.org/trunk@46570
git-svn-id: http://core.svn.wordpress.org/trunk@46367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 17:52:04 +00:00
e1560cd1e0
Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append `scaled-` to the file names of the scaled images to make them easier to recognize.
...
Props kraftbj, azaozz.
Fixes #48304 .
Built from https://develop.svn.wordpress.org/trunk@46565
git-svn-id: http://core.svn.wordpress.org/trunk@46362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-21 21:43:04 +00:00
67104bb3f4
Administration: Revert changes to the admin menu styles for long line lengths.
...
This reverts [46555], [46453], and [46332].
See #42201
Built from https://develop.svn.wordpress.org/trunk@46561
git-svn-id: http://core.svn.wordpress.org/trunk@46358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-17 18:38:03 +00:00
1d6bd71ce4
Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing.
...
This allows update failures caused when the native PHP JSON extension is missing to be distinguished from updates that fail because the site does not meet the minimum PHP requirements.
Follow up of [46455].
Reviewed by desrosj, jorbin, johnbillion.
Fixes #47699 .
Built from https://develop.svn.wordpress.org/trunk@46560
git-svn-id: http://core.svn.wordpress.org/trunk@46357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-16 21:03:02 +00:00
44de60e8da
Script Loader: Partially revert [46550] as it brought in unrelated CSS changes.
...
[46550] was meant to revert [46440] but it also merged some unrelated CSS changes.
See #47069 .
Built from https://develop.svn.wordpress.org/trunk@46559
git-svn-id: http://core.svn.wordpress.org/trunk@46356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-16 17:49:03 +00:00
2ab1e4dcd8
Help/About: Let's tell the world about 5.3.
...
Props karmatosed, melchoyce, pierlo, ryelle, afercia, audrasjb, davidbaumwald
Thanks to everyone who provided feedback for this page for 5.3.
See #47708
Built from https://develop.svn.wordpress.org/trunk@46556
git-svn-id: http://core.svn.wordpress.org/trunk@46353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-15 20:42:03 +00:00
7cdb93a374
Administration: Fix the appearance of update bubbles in submenus and when the admin menu is collapsed.
...
Props afercia, amolv, sabernhardt
Fixes #42201 , #48294
Built from https://develop.svn.wordpress.org/trunk@46555
git-svn-id: http://core.svn.wordpress.org/trunk@46352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-15 19:39:01 +00:00
02810533c4
Accessibility: Script Loader: Remove jQuery as dependency of `admin-bar` after [46440].
...
A better approach needs to be explored, as there are valid concerns for potential conflicts between different jQuery versions added by themes or plugins.
See #47069 .
Built from https://develop.svn.wordpress.org/trunk@46550
git-svn-id: http://core.svn.wordpress.org/trunk@46347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-15 17:23:04 +00:00
1940cf7d54
Media: Do not store error messages in the image meta. The initial idea was to (be able to) display these errors in the UI but it wasn't implemented as these errors are mostly helpful for low-level bedugging.
...
Fixes #40439 .
Built from https://develop.svn.wordpress.org/trunk@46507
git-svn-id: http://core.svn.wordpress.org/trunk@46304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 20:05:01 +00:00
b0e0f69b2e
I18N: Don't capitalize "Extension" in `update_core()`, for consistency with other strings.
...
Follow-up to [46455].
See #47699 .
Built from https://develop.svn.wordpress.org/trunk@46464
git-svn-id: http://core.svn.wordpress.org/trunk@46262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-12 02:42:01 +00:00
e19329bad0
Docs: Add `requires_php` to the list of fields returned by `plugins_api()`.
...
Props ediamin.
Fixes #48291 .
Built from https://develop.svn.wordpress.org/trunk@46463
git-svn-id: http://core.svn.wordpress.org/trunk@46261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-12 02:35:04 +00:00
ebd52ce048
Administration: Prevents horizontal scroll jumping around while admin menu is open.
...
This sets the `#adminmenuback` `position` CSS property to `fixed`.
Props promz, man4toman.
Fixes #47010 .
Built from https://develop.svn.wordpress.org/trunk@46460
git-svn-id: http://core.svn.wordpress.org/trunk@46258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-11 19:22:02 +00:00
66c8085fc4
Media: Update fallback previews to support `_wp_make_subsizes()`
...
Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.
Props azaozz, antpb, progremzion, mikeschroder.
See #48111 .
Built from https://develop.svn.wordpress.org/trunk@46459
git-svn-id: http://core.svn.wordpress.org/trunk@46257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-11 07:54:03 +00:00
c6d3987b08
Upgrade/Install: Detect the presence of the native PHP JSON extension before updating.
...
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]).
However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues.
Props jrf, jorbin, dd32, desrosj.
Fixes #47699 .
Built from https://develop.svn.wordpress.org/trunk@46455
git-svn-id: http://core.svn.wordpress.org/trunk@46253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-09 22:22:04 +00:00
ec02d199f4
Administration: Ensure visual consistency with large titles in the sidebar.
...
Custom posts, and other menu titles that are long aren't wrapping correctly.
Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald.
Fixes #42201
Built from https://develop.svn.wordpress.org/trunk@46453
git-svn-id: http://core.svn.wordpress.org/trunk@46251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-09 04:58:02 +00:00
8d1e51e9c7
Docs: Add a `@since` note about new parameters with the spread operator added to function signatures.
...
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46451
git-svn-id: http://core.svn.wordpress.org/trunk@46249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-09 04:28:02 +00:00
843c39b9bc
Themes: Properly align Close/Previous/Next icons in theme preview overlay.
...
Props chetan200891.
Fixes #48248 .
Built from https://develop.svn.wordpress.org/trunk@46444
git-svn-id: http://core.svn.wordpress.org/trunk@46242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-08 19:07:04 +00:00
93279742c1
Themes: Adjust CSS media query for theme overlay to match the breakpoint for a folded admin menu.
...
Props chetan200891.
Fixes #48250 .
Built from https://develop.svn.wordpress.org/trunk@46443
git-svn-id: http://core.svn.wordpress.org/trunk@46241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-08 18:49:03 +00:00
477f0ffd71
Network Admin: Improve Site States in List Table rows.
...
This commit switches a comparison to a Yoda condition, performs a more strict `intval()` check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.)
Fixes #37684 . Props pbiron.
Built from https://develop.svn.wordpress.org/trunk@46441
git-svn-id: http://core.svn.wordpress.org/trunk@46239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-08 17:46:02 +00:00
760a55b310
Docs: Add missing `@deprecated` tags in the file docblock of some deprecated files.
...
Props jrf.
Fixes #48254 .
Built from https://develop.svn.wordpress.org/trunk@46439
git-svn-id: http://core.svn.wordpress.org/trunk@46237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-08 17:19:04 +00:00
92f09c0496
Accessibility: Improve and modernize user interface controls: Revert the new links focus style.
...
Thew new dotted outline for the links focus style introduced in [46241] doesn't appear to be ready to guarantee a good indication of focus.
It was agreed to restore the previous links focus style and postpone exploration for a new style to the next release cycle.
Partially reverts [46241] and [46293].
See #34904 , #47153 .
Built from https://develop.svn.wordpress.org/trunk@46425
git-svn-id: http://core.svn.wordpress.org/trunk@46223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-07 19:57:02 +00:00
3a27f92158
Accessibility: Improve and modernize user interface controls: Improve the buttons active CSS class.
...
- improves the buttons `.active` CSS class for buttons that need to be styled as "pressed"
- update the alternate color schemes `.active` CSS class accordingly
- improves a few icons colors in the alternate color schemes
See #34904 .
Built from https://develop.svn.wordpress.org/trunk@46423
git-svn-id: http://core.svn.wordpress.org/trunk@46221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-07 18:47:05 +00:00
f793398e4f
Upload: Set custom header with the attachment ID for all uploads from `media_handle_upload()`. Let the REST API endpoint set it separately.
...
Props timothyblynjacobs.
Fixes #48200 .
Built from https://develop.svn.wordpress.org/trunk@46421
git-svn-id: http://core.svn.wordpress.org/trunk@46219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-07 15:30:02 +00:00
e9065659f4
Accessibility: Improve and modernize user interface controls for better contrast: Further improvements to input heights and alignments.
...
- improves input fields height in the customizer
- improves input fields height for Internet Explorer 11
- improves input fields height in the Image Editor
- improves alignment of selects and buttons in the privacy policy pages
- makes the search themes fields font-size consistent
Props garrett-eclipse, afercia.
See #47477 .
Built from https://develop.svn.wordpress.org/trunk@46419
git-svn-id: http://core.svn.wordpress.org/trunk@46217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-07 13:20:03 +00:00
1f3d583825
Accessibility: Media: Improve the search media field labelling.
...
Visible `<label>` elements benefit all users. The `placeholder` attribute should not be used as a replacement for visible labels.
Instead, it's supposed to be used only for a short hint to aid users with data entry e.g. a sample value or a brief description of the expected format.
Screen readers may not announce a `placeholder` attribute at all. Other users may suffer from the lack of a visible label and a placeholder used as replacement, for example:
- users with cognitive disabilities may have trouble remembering what the filled field does
- speech recognition users cannot see the name they can speak to set focus on the field
- low-vision users with high text-size may not be able to see the whole placeholder even when it's visible, if its value is clipped by the edge of the input
Props anevins, audrasjb, karmatosed, azaozz, SergeyBiryukov, afercia.
See #40331 .
Fixes #47138 .
Built from https://develop.svn.wordpress.org/trunk@46418
git-svn-id: http://core.svn.wordpress.org/trunk@46216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-07 12:43:03 +00:00
ea5d76fbb2
Privacy: Ensure that sending email, and remove data follow the same user experience.
...
Both personal data request processes should follow the same convention.
Fixes : #43974 .
Props: garrett-eclipse, kjellr, Kerfred, birgire, marybaum, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@46412
git-svn-id: http://core.svn.wordpress.org/trunk@46210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-06 06:56:02 +00:00
4269998771
Administration: Add a max-width to the Privacy Policy Page dropdown.
...
If there's a page with an extra long title, the Privacy Policy page dropdown in Privacy Settings overflows the page width.
Fixes #47366
Props garrett-eclipse, SergeyBiryukov, mukesh27, desrosj, adhitya03, jalpa1984, nrqsnchz, paresh07.
Built from https://develop.svn.wordpress.org/trunk@46411
git-svn-id: http://core.svn.wordpress.org/trunk@46209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-06 06:42:02 +00:00
554b60da76
Docs: Format comments in `wp-admin/includes/plugin.php` as per the documentation standards.
...
Props dkarfa.
Fixes #48191 .
Built from https://develop.svn.wordpress.org/trunk@46410
git-svn-id: http://core.svn.wordpress.org/trunk@46208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-06 02:23:03 +00:00
ebd841790b
Build/Test: Update Grunt Uglify options
...
Follow up to [46408]
Sometimes you need to take documentation literally. And sometimes you need to take it seriously. Deprecations and replacements in uglify are a case where I took them literally and should have taken them seriously.
See #48203 .
Built from https://develop.svn.wordpress.org/trunk@46409
git-svn-id: http://core.svn.wordpress.org/trunk@46207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 22:01:04 +00:00
0e21d32900
Build/Test: Bump devDependencies for WordPress 5.3
...
This upgrades a number of devDependencies. Some of these include changes to how the tasks are configured.
Uglify: There are deprecated options from 2.x to 4.x, see: https://github.com/gruntjs/grunt-contrib-uglify#options
Autoprefixer: Browserslist now warns when passing in the browser list, so that is put into package.json
As with most changes to uglify, this changes every minified JS file.
Fixes #48203 .
Built from https://develop.svn.wordpress.org/trunk@46408
git-svn-id: http://core.svn.wordpress.org/trunk@46206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 19:49:10 +00:00
3520f5234b
Taxonomy: Prevent Parent Category dropdown and field descriptions on Categories and Edit Category screens from extending beyond the other fields.
...
Props garrett-eclipse, dkarfa.
Fixes #48188 .
Built from https://develop.svn.wordpress.org/trunk@46405
git-svn-id: http://core.svn.wordpress.org/trunk@46204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 15:41:57 +00:00
a92b23ee61
Build/Test tools: Update grunt-contrib-imagemin and run it
...
Smaller images are good, so is not having npm vulnerabilities.
See #48203 .
Fixes #48206 .
Props whyisjake, netweb.
Built from https://develop.svn.wordpress.org/trunk@46404
git-svn-id: http://core.svn.wordpress.org/trunk@46203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 14:20:59 +00:00
f1b5f2aa94
Site Health: Improve the wording for `UTF8MB4` test description.
...
Props garrett-eclipse, chetan200891, johnjamesjacoby, ayeshrajans.
Fixes #48044 .
Built from https://develop.svn.wordpress.org/trunk@46402
git-svn-id: http://core.svn.wordpress.org/trunk@46201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 02:39:58 +00:00
2237306c2b
Customize: Remove duplicate `attr_title` assignment in `api.Menus.MenuItemControl.renderContent()`.
...
See #47838 .
Built from https://develop.svn.wordpress.org/trunk@46401
git-svn-id: http://core.svn.wordpress.org/trunk@46200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 02:32:58 +00:00
f19ecd19de
Filesystem API: Use strict type check in the `in_array()` call for the `$skip_list` parameter in `copy_dir()` and `_copy_dir()`.
...
This ensures that parent folders with a numeric name are not accidentally skipped when only a subfolder is intended to be skipped.
Props codex-m.
Fixes #46581 .
Built from https://develop.svn.wordpress.org/trunk@46400
git-svn-id: http://core.svn.wordpress.org/trunk@46199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 02:16:56 +00:00
30913bc9a2
Docs: Correct formatting of the `@return` value description in `_wp_handle_upload()`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46399
git-svn-id: http://core.svn.wordpress.org/trunk@46198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 02:09:57 +00:00
60617d471b
Docs: Add missing documentation for the first parameter of the `big_image_size_threshold` filter.
...
Props dkarfa, desrosj, earnjam.
Fixes #48214 .
Built from https://develop.svn.wordpress.org/trunk@46398
git-svn-id: http://core.svn.wordpress.org/trunk@46197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 01:30:58 +00:00
d2a48496d2
Docs: Add missing description for `$comment` global.
...
Props immeet94, mukesh27.
Fixes #46928 . See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46391
git-svn-id: http://core.svn.wordpress.org/trunk@46190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 22:19:57 +00:00
f34db2aa7e
I18N: Add missing comma in a translator comment.
...
See #47515 .
Built from https://develop.svn.wordpress.org/trunk@46390
git-svn-id: http://core.svn.wordpress.org/trunk@46189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 22:09:57 +00:00
d38d1c2c35
I18N: Fix translator comment for a themes list table string with numbered placeholders.
...
Props garrett-eclipse.
Fixes #47515 .
Built from https://develop.svn.wordpress.org/trunk@46387
git-svn-id: http://core.svn.wordpress.org/trunk@46186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 20:20:58 +00:00
6f38c7fb81
Docs: Convert 'Block Editor' to lowercase.
...
Props garrett-eclipse.
Fixes #45634 .
Built from https://develop.svn.wordpress.org/trunk@46386
git-svn-id: http://core.svn.wordpress.org/trunk@46185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 20:12:58 +00:00
cd6110782e
Networks and Sites: Improve newly added strings for i18n.
...
* Remove unnecessary numbered placeholders.
* Add context to "All" and "Spam" status.
* Add translator comments.
Props pedromendonca.
Fixes #48210 .
Built from https://develop.svn.wordpress.org/trunk@46385
git-svn-id: http://core.svn.wordpress.org/trunk@46184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 19:58:55 +00:00
143b5fd080
Networks and Sites: Fix issues processing additional fields displayed for the Sites list table.
...
This prevents a `The link you followed has expired.` error when using a filter and now uses `$_POST` instead of `$_GET` to capture all form values.
Props pbiron.
Fixes #45954 .
Built from https://develop.svn.wordpress.org/trunk@46384
git-svn-id: http://core.svn.wordpress.org/trunk@46183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 14:32:56 +00:00
ff225c8bfc
Upload: Fix the method used to create image sub-sizes when uploading fails with a PHP fatal error. Use a custom header to send the new attachment post ID even in HTTP 500 responses instead of an upload reference sent by the client. Also add another cap check and remove the action when deleting an attachment post during a failed upload cleanup.
...
Props timothyblynjacobs, clorith, azaozz.
Fixes #48200 .
Built from https://develop.svn.wordpress.org/trunk@46382
git-svn-id: http://core.svn.wordpress.org/trunk@46181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-03 21:02:00 +00:00
efa9da7446
Docs: Fix code example for removing internal pointers.
...
Props daleharrison, swissspidy, garrett-eclipse, luciano-croce, jrf, desrosj.
Fixes #45529 .
Built from https://develop.svn.wordpress.org/trunk@46381
git-svn-id: http://core.svn.wordpress.org/trunk@46180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-03 20:39:58 +00:00
6a0f3ddae3
Menus: Fix typo in the class attribute for the hidden `title` field in `Walker_Nav_Menu_Checklist`.
...
Each item that `Walker_Nav_Menu_Checklist` displays is accompanied by several hidden `<input/>` fields that specify default values for each item when added to a menu. These values are passed in JavaScript to the AJAX call triggered when an item is added to a menu.
The hidden field for the title attribute field incorrectly had an underscore instead of a hyphen. Because of this, it was impossible to supply a default value for the Title Attribute field of a nav menu item.
Props yanngarcia, davidbaumwald.
See #47838 .
Built from https://develop.svn.wordpress.org/trunk@46380
git-svn-id: http://core.svn.wordpress.org/trunk@46179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-03 20:03:56 +00:00
3e40f12574
Privacy: Remove unused `$wpdb` global in `WP_Privacy_Requests_Table::prepare_items()`.
...
Props david.binda.
Fixes #48178 .
Built from https://develop.svn.wordpress.org/trunk@46374
git-svn-id: http://core.svn.wordpress.org/trunk@46173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-02 23:22:58 +00:00
4b939d5a93
Login and Registration: Hide the Edge browser "Reveal password" native button.
...
Props Clorith.
Fixes #42888 .
Built from https://develop.svn.wordpress.org/trunk@46372
git-svn-id: http://core.svn.wordpress.org/trunk@46171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-01 18:01:01 +00:00
da00051294
Accessibility: Improve and modernize user interface controls for better contrast: Login screen improvements.
...
- allows the login input fields to better scale with text
- improves the input fields layout on Internet Explorer 11
- uses the new focus style on the "Show password" button
- adjusts the CSS for the interim login
See #47153 .
See #42888 .
Built from https://develop.svn.wordpress.org/trunk@46371
git-svn-id: http://core.svn.wordpress.org/trunk@46170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-01 15:55:57 +00:00
44c3cefb24
Docs: Fix typo in `wp_get_missing_image_subsizes()` DocBlock.
...
Props david.binda.
Fixes #48179 .
Built from https://develop.svn.wordpress.org/trunk@46368
git-svn-id: http://core.svn.wordpress.org/trunk@46167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-01 01:19:57 +00:00
f86d225d26
Accessibility: Improve and modernize user interface controls: Improve new styles for the color picker.
...
Props audrasjb, garrett-eclipse.
Fixes #48131 .
Built from https://develop.svn.wordpress.org/trunk@46360
git-svn-id: http://core.svn.wordpress.org/trunk@46159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 18:05:59 +00:00
6531c237e7
Media: Prevents clipping of text when scaling image edit screen.
...
This reapplies [46354] clean as the previous commit had remnants of an unrelated patch.
Props sabernhardt, audrasjb, afercia.
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46359
git-svn-id: http://core.svn.wordpress.org/trunk@46158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:56:57 +00:00
ae29987a17
Site Health: Improve the message displayed to sites not utilizing HTTPS.
...
The new message better illustrates that there are many potential benefits of using HTTPS, not just a few.
Props garrett-eclipse, dkarfa, ocean90, afragen, desrosj.
Fixes #48118 .
Built from https://develop.svn.wordpress.org/trunk@46358
git-svn-id: http://core.svn.wordpress.org/trunk@46157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:54:58 +00:00
6566808e8a
Accessibility: Improve and modernize user interface controls: Improve the new form controls styles and heights.
...
Improves cross-browsers rendering and addresses most of the reported edge cases.
See #47477 .
Built from https://develop.svn.wordpress.org/trunk@46356
git-svn-id: http://core.svn.wordpress.org/trunk@46155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:24:59 +00:00
247e7eb7d5
Media: Revert [46354] preventing bad clipping of text in image details page.
...
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46355
git-svn-id: http://core.svn.wordpress.org/trunk@46154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:12:59 +00:00
7c8028febf
Media: Prevents clipping of text when scaling image edit screen.
...
Props sabernhardt, audrasjb, afercia.
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46354
git-svn-id: http://core.svn.wordpress.org/trunk@46153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 16:34:58 +00:00
38e6958698
Media: Move `wp_get_original_image_path()` to `wp-content/post.php` to make it easier to access from plugins.
...
Props pbiron.
See #47873 .
Built from https://develop.svn.wordpress.org/trunk@46353
git-svn-id: http://core.svn.wordpress.org/trunk@46152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 16:28:59 +00:00
20e781f44d
Accessibility: Improve and modernize user interface controls: Remove the CSS transform 1 pixel shift from the buttons active state.
...
Props Joen.
See #34904 .
Built from https://develop.svn.wordpress.org/trunk@46350
git-svn-id: http://core.svn.wordpress.org/trunk@46149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 10:53:57 +00:00
8cb7c5c764
Upgrade/Install: Fix the Install Now button in the plugin overlay when running WordPress on a specific port.
...
Props garrett-eclipse, pierlo, afragen.
Fixes #48077 .
Built from https://develop.svn.wordpress.org/trunk@46348
git-svn-id: http://core.svn.wordpress.org/trunk@46147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 00:05:57 +00:00
dfcdb40c8f
Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment.
...
Props desrosj, garrett-eclipse, afercia.
See #47498 .
Built from https://develop.svn.wordpress.org/trunk@46345
git-svn-id: http://core.svn.wordpress.org/trunk@46144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 21:56:56 +00:00
8ef586a897
Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue.
...
Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb.
See #34904 .
Built from https://develop.svn.wordpress.org/trunk@46344
git-svn-id: http://core.svn.wordpress.org/trunk@46143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 21:53:57 +00:00
5f2c7142a1
Docs: Improve documentation for `::display()` methods in various list tables.
...
Props itowhid06.
Fixes #47947 .
Built from https://develop.svn.wordpress.org/trunk@46341
git-svn-id: http://core.svn.wordpress.org/trunk@46140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 11:04:58 +00:00
55b1dc642e
Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states.
...
See #47477 .
See #48128 .
Built from https://develop.svn.wordpress.org/trunk@46340
git-svn-id: http://core.svn.wordpress.org/trunk@46139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:45:57 +00:00
7d769a9234
Accessibility: Improve and modernize user interface controls. Style the select elements disabled state.
...
Props adhitya03, MarcosAlexandre, kjellr.
See #47477 .
Fixes #48129 .
Built from https://develop.svn.wordpress.org/trunk@46339
git-svn-id: http://core.svn.wordpress.org/trunk@46138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:35:59 +00:00
dd44ab5a58
Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen.
...
Props masummdar, audrasjb, afercia.
Fixes #47318 .
Built from https://develop.svn.wordpress.org/trunk@46338
git-svn-id: http://core.svn.wordpress.org/trunk@46137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:20:57 +00:00
becc682bcf
Accessibility: Improve and modernize user interface controls. Make the select elements background white.
...
Props adhitya03.
See #47477 .
Fixes #48128 .
Built from https://develop.svn.wordpress.org/trunk@46337
git-svn-id: http://core.svn.wordpress.org/trunk@46136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:15:59 +00:00
07a753cb35
Docs: Add documentation for `WP_Comments_List_Table::display()`.
...
Props itowhid06, dinhtungdu.
Fixes #47929 .
Built from https://develop.svn.wordpress.org/trunk@46336
git-svn-id: http://core.svn.wordpress.org/trunk@46135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-27 23:03:58 +00:00
b6f7c0cbc4
Administration: Ensure visual consistency with large titles in the sidebar.
...
Custom posts, and other menu titles that are long aren't wrapping correctly.
Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb
Fixes #42201
Built from https://develop.svn.wordpress.org/trunk@46332
git-svn-id: http://core.svn.wordpress.org/trunk@46131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 21:51:57 +00:00
66dd6814e7
Media: Restore the original Image Editor columns layout after [46326].
...
Fixes #47116 .
Built from https://develop.svn.wordpress.org/trunk@46331
git-svn-id: http://core.svn.wordpress.org/trunk@46130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:37:57 +00:00
c034f5b4c3
Menus: Replace http with https in placeholders.
...
Encourage the use of https with the placeholder text in menus.
Fixes #46312
Props aksl95, audrasjb, celloexpressions, SergeyBiryukov, jorbin.
Built from https://develop.svn.wordpress.org/trunk@46330
git-svn-id: http://core.svn.wordpress.org/trunk@46129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:32:55 +00:00
93dd6d907a
Accessibility: Media: Make the Image Editor buttons text visible.
...
User interface controls that use only icons aren't ideal for many users.
Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background.
Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them.
- shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal
- moves the Undo and Redo buttons underneath the main buttons group
Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder.
Fixes #47116 .
Built from https://develop.svn.wordpress.org/trunk@46326
git-svn-id: http://core.svn.wordpress.org/trunk@46125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 17:16:57 +00:00
6e8f550770
General: Correct strict comparison in `WP_Links_List_Table::column_categories()` introduced in [46313].
...
`$cat_id` is a string, `$category` is an integer.
See #48142 .
Built from https://develop.svn.wordpress.org/trunk@46316
git-svn-id: http://core.svn.wordpress.org/trunk@46115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 01:24:56 +00:00
148322a970
Docs: Improve documentation for `_post_states()` and `get_post_states()`.
...
Add documentation for `_media_states()`.
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46315
git-svn-id: http://core.svn.wordpress.org/trunk@46114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 00:57:58 +00:00
a351243928
General: Further phpcs cleanup.
...
In [46312] and [46313] we attempted to do some phpcs cleanup. This commit cleans up three issues that were introduced in [46309].
Fixes #48142 .
Props: whyisjake, garrett-eclipse, desrosj
Built from https://develop.svn.wordpress.org/trunk@46314
git-svn-id: http://core.svn.wordpress.org/trunk@46113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 00:37:58 +00:00
d53b773a47
General: Further phpcs cleanup.
...
In [46312] we attempted to do some `phpcs` cleanup. This commit cleans up three issues that were introduced in [46309].
Fixes #48142 .
Props whyisjake, garrett-eclipse.
Built from https://develop.svn.wordpress.org/trunk@46313
git-svn-id: http://core.svn.wordpress.org/trunk@46112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 23:38:57 +00:00
38dc032e66
General: Linter cleanup
...
`phpcbf` was able to clean up a few files. Tests were breaking as a result of code formatting.
Fixes #48142
Props whyisjake
Built from https://develop.svn.wordpress.org/trunk@46312
git-svn-id: http://core.svn.wordpress.org/trunk@46111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 22:53:58 +00:00
b4ab6b7e14
Menus: Duplicate Page Entry in View All Pages when generating a Menu
...
Simplifies the interface in menu creation.
Fixes [37782]
Props garrett-eclipse, mdgl, birgire, xkon, audrasjb, pento, girlieworks
Built from https://develop.svn.wordpress.org/trunk@46309
git-svn-id: http://core.svn.wordpress.org/trunk@46108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 21:51:58 +00:00
f8a25a89c9
Accessibility: Implement the new focus styles on the login screen after [46247].
...
Props @kjellr.
See #47153 .
Built from https://develop.svn.wordpress.org/trunk@46293
git-svn-id: http://core.svn.wordpress.org/trunk@46105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 16:40:00 +00:00
894e133d0c
Build/Test Tools: Introduce automated PHP compatibility checking.
...
This change introduces a new Composer script, `compat` that will scan the codebase for (detectable) potential PHP compatibility issues using the `PHP_CodeSniffer` and a custom ruleset based off of the `PHPCompayibilityWP` ruleset (`phpcompat.xml.dist`).
The command will be run as a separate job within each Travis build. While many compatibility issues and false positives have already been corrected in this commit and other Trac tickets, there are still some remaining. For that reason, the job is allowed to fail while the remainder of the potential compatibility issues are investigated and addressed. After those are resolved, the job should be set as required to pass to help prevent new compatibility issues from being introduced.
Props desrosj, jrf, all PHPCompatibilityWP and PHPCompatibility contributors.
Fixes #46152 .
Built from https://develop.svn.wordpress.org/trunk@46290
git-svn-id: http://core.svn.wordpress.org/trunk@46102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 13:47:58 +00:00
c7f4cbc62c
Docs: Improve consistency in `@since` tags for parameters that were made optional.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46288
git-svn-id: http://core.svn.wordpress.org/trunk@46100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-24 12:54:57 +00:00
a943fd64bc
Coding Standards: Fix WPCS issue in [46283].
...
See #48110 .
Built from https://develop.svn.wordpress.org/trunk@46284
git-svn-id: http://core.svn.wordpress.org/trunk@46096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 23:24:57 +00:00
75ca249558
Twenty Twenty: Rename widget areas to `sidebar-1` and `sidebar-2`.
...
This ensures that widgets are mapped correctly and is consistent with the previous default themes.
See https://github.com/WordPress/twentytwenty/issues/481 .
Reverts [46282].
Props ocean90, garrett-eclipse, desrosj, SergeyBiryukov.
See #48110 .
Built from https://develop.svn.wordpress.org/trunk@46283
git-svn-id: http://core.svn.wordpress.org/trunk@46095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 23:17:58 +00:00
b95b6f2c73
Site Health: Move "The folder ... was detected as being under version control" message from failure to warning.
...
Props afragen, davidbaumwald.
Fixes #47982 .
Built from https://develop.svn.wordpress.org/trunk@46281
git-svn-id: http://core.svn.wordpress.org/trunk@46093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 21:24:56 +00:00
098455b06f
Bundled Themes: Make Twenty Twenty the new default theme.
...
After being imported in [46271], Twenty Twenty can now be set as the default theme in WordPress.
See #48110 .
Props desrosj, ocean90.
Built from https://develop.svn.wordpress.org/trunk@46278
git-svn-id: http://core.svn.wordpress.org/trunk@46090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 21:00:58 +00:00
c117b9957f
Site Health: Use `WP_Automatic_Updater::is_disabled()` to check whether automatic updates are disabled.
...
The previous check for `DISALLOW_FILE_MODS` and `AUTOMATIC_UPDATER_DISABLED` constants didn't always provide accurate results.
Props Clorith, kraftner, afragen.
Fixes #47869 .
Built from https://develop.svn.wordpress.org/trunk@46276
git-svn-id: http://core.svn.wordpress.org/trunk@46088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 20:52:56 +00:00
371f83cfd1
Site Health: Introduce `site_status_test_result` filter for the output of a finished Site Health test.
...
Props Clorith.
Fixes #47864 .
Built from https://develop.svn.wordpress.org/trunk@46269
git-svn-id: http://core.svn.wordpress.org/trunk@46081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 20:04:58 +00:00
db5f9f7a3a
Site Health: Update PHP extension tests to reflect the current state of the Hosting Teams handbook recommendations.
...
Props Clorith, bronsonquick, jrf, johnbillion, galbaras, mikeschroder, jorbin.
Fixes #47454 .
Built from https://develop.svn.wordpress.org/trunk@46268
git-svn-id: http://core.svn.wordpress.org/trunk@46080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:50:56 +00:00
9510aaecde
Site Health: Improve wording for PHP update warning.
...
Props danieltj, garrett-eclipse, marybaum, afragen, chetan200891.
Fixes #47644 .
Built from https://develop.svn.wordpress.org/trunk@46267
git-svn-id: http://core.svn.wordpress.org/trunk@46079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:39:58 +00:00
5955f0938b
Privacy: Introduce `wp_privacy_personal_data_email_to` and `wp_privacy_personal_data_email_subject` filters.
...
Pass email data to the `wp_privacy_personal_data_email_content` filter.
Props garrett-eclipse, thakkarhardik, birgire.
Fixes #46303 .
Built from https://develop.svn.wordpress.org/trunk@46265
git-svn-id: http://core.svn.wordpress.org/trunk@46077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:25:57 +00:00
255b1d6e3f
Privacy: Show a success message for personal data erasure.
...
Props garrett-eclipse, allendav, birgire, JoshuaWold, karmatosed, pputzer.
Fixes #44135 .
Built from https://develop.svn.wordpress.org/trunk@46264
git-svn-id: http://core.svn.wordpress.org/trunk@46076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:13:58 +00:00
f14fc1392c
Taxonomy: Redirect to the correct URL after deleting a taxonomy term attached to a post type other than Post.
...
Props donmhico, mukesh27
Fixes #47858
Built from https://develop.svn.wordpress.org/trunk@46263
git-svn-id: http://core.svn.wordpress.org/trunk@46075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:10:58 +00:00
bcbedd7f55
Coding Standards: Fix a coding standards issue introduced in [46254].
...
See #37392 .
Built from https://develop.svn.wordpress.org/trunk@46261
git-svn-id: http://core.svn.wordpress.org/trunk@46073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 18:35:00 +00:00
0d75495612
Login and Registration: Add a "Show password" button on the login page.
...
The ability for users to see the password they're typing improves usability and accessibility of the login users flow.
- brings the login screen in line with the same feature already used in the New User, Edit User, and Reset Password pages
- improves association of labels and input fields by using explicit association with `for` / `id` attributes
- slightly increases the "Remember me" label font size
Props johnbillion, Iceable, audrasjb, joyously, adamsilverstein, boemedia, DrewAPicture, shadyvb, birgire, peterwilsoncc, pento, anevins, davidbaumwald, whyisjake, afercia.
Fixes #42888 .
Built from https://develop.svn.wordpress.org/trunk@46256
git-svn-id: http://core.svn.wordpress.org/trunk@46068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 18:06:57 +00:00
e5302dff26
Multisite/Sites: supplemental commit to r46251.
...
This commit adds the links to the list-table class itself (that were missed in r46251.)
See #37392 . Props pbiron, thomaswm.
Built from https://develop.svn.wordpress.org/trunk@46254
git-svn-id: http://core.svn.wordpress.org/trunk@46066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:51:58 +00:00
22ae908ede
Editor: Add Nonce Endpoint
...
This is a follow up to #47843 , implementing a PHP endpoint and inline scripts
after the editor package updates. The action was originally added in
https://github.com/WordPress/gutenberg/pull/16683 .
Fixes #48076 .
Built from https://develop.svn.wordpress.org/trunk@46253
git-svn-id: http://core.svn.wordpress.org/trunk@46065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:47:56 +00:00
b65ea119bb
Multisite/Sites: Add links to filter websites by status.
...
This commit brings the Network-Admin Sites list page up-to-speed with other similar list-table powered pages, by adding links to filter the results by Site Status.
Includes a single unit test for the newly introduced `wp_count_sites()` multisite function, named to match the `wp_count_` function pattern from other list tables.
Fixes #37392 . Props mnelson4, spacedmonkey, pbiron.
Built from https://develop.svn.wordpress.org/trunk@46251
git-svn-id: http://core.svn.wordpress.org/trunk@46063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:35:59 +00:00
956725990f
Accessibility: Make sortable meta boxes non sortable when there are no locations they can be dragged to.
...
Depending on the amount of meta boxes and the layout settings under Screen Options, sortable meta boxes may not be actually sortable.
In these cases, jQuery UI sortable needs to be disabled and the user interface shouldn't use a CSS `cursor: move`.
The use of consistent and relevant cursors may be important for users who have a cognitive disability, since cursors give a visual clue as to an element's functionality. Using the move cursor for elements which cannot be moved may be confusing or counter-intuitive for users.
Props adamsilverstein, antpb, anevins.
Fixes #47131 .
Built from https://develop.svn.wordpress.org/trunk@46250
git-svn-id: http://core.svn.wordpress.org/trunk@46062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:30:58 +00:00
6cb8e14790
Accessibility: Improve and modernize user interface controls. Sixth part: allow checkboxes and radio buttons to scale with text.
...
- uses a SVG icon for checkboxes
- uses CSS `rem` relative units
Props kjellr, afercia, audrasjb.
Fixes #47498 .
Built from https://develop.svn.wordpress.org/trunk@46248
git-svn-id: http://core.svn.wordpress.org/trunk@46060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 16:51:57 +00:00
165ac34260
Accessibility: Improve and modernize user interface controls for better contrast. Fifth part: Common form controls.
...
Props anevins, melchoyce, audrasjb, kjellr.
Fixes #47153 .
Built from https://develop.svn.wordpress.org/trunk@46247
git-svn-id: http://core.svn.wordpress.org/trunk@46059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 16:21:58 +00:00
46892ffb12
Media: Sets `post_id` optional in `media_sideload_image()` and `media_handle_sideload()`.
...
Props SergeyBiryukov, donmhico, mikeschroder, sebastian.pisula.
Fixes #43579 .
Built from https://develop.svn.wordpress.org/trunk@46245
git-svn-id: http://core.svn.wordpress.org/trunk@46057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 16:03:56 +00:00
38be855367
Accessibility: Improve and modernize user interface controls. Third part: allow buttons and form controls to scale with text.
...
Props kjellr, abrightclearweb, audrasjb.
Fixes #47477 .
Built from https://develop.svn.wordpress.org/trunk@46243
git-svn-id: http://core.svn.wordpress.org/trunk@46055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 15:27:57 +00:00
271f45072d
Accessibility: Improve and modernize user interface controls for better contrast. Second part: tables, meta boxes, and other user interface elements.
...
Introduces better contrast for borders of the following user interface elements:
- Tables
- Screen Options and Help
- Admin notices
- Welcome panel
- Meta boxes (post boxes)
- Cards
- Health Check accordions and headings
- Theme and Plugin upload forms
Props kjellr, melchoyce, karmatosed, audrasjb.
Fixes #48101 .
Built from https://develop.svn.wordpress.org/trunk@46242
git-svn-id: http://core.svn.wordpress.org/trunk@46054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 15:10:59 +00:00
618883f6f4
Accessibility: Improve and modernize user interface controls for better contrast. First part: buttons and links.
...
- Introduces new styles for the buttons, with better contrast for borders and better focus style.
- Introduces a new focus style for links.
- The new styles improve consistency with the ones used in the new Block Editor (Gutenberg).
Props michaelarestad, truchot, mor10, kellychoffman, adamsoucie, paaljoachim, Joen, kjellr, melchoyce, karmatosed, audrasjb, afercia.
Fixes #34904 .
Built from https://develop.svn.wordpress.org/trunk@46241
git-svn-id: http://core.svn.wordpress.org/trunk@46053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 14:43:58 +00:00
e43633b7d0
Accessibility: Menus: Improve the menu items "Select All".
...
- changes "Select All" from a link to a checkbox
- the new checkbox is available only when JavaScript support is on
- semantically and for accessibility, a checkbox is a better user interface control because the available action is clear to all users and the selected state is communicated natively
- it's consistent with the existing pattern for the admin tables
Props birgire, audrasjb, afercia.
Fixes #47048 .
Built from https://develop.svn.wordpress.org/trunk@46240
git-svn-id: http://core.svn.wordpress.org/trunk@46052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 12:42:58 +00:00
e36d1bcbd8
Docs: Docblock corrections and improvements, mostly related to various `pre_*` filters.
...
See #47110
Built from https://develop.svn.wordpress.org/trunk@46232
git-svn-id: http://core.svn.wordpress.org/trunk@46044 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-21 17:41:57 +00:00
123b4475b0
Site Health: Don't verify SSL certificate when testing the local site.
...
The SSL certificate may be self-signed which prevents various tests from returning proper results. Since the Cron API and file editors don't verify the certificate the tests shouldn't either.
Props Clorith, ocean90.
Fixes #47957 .
Built from https://develop.svn.wordpress.org/trunk@46231
git-svn-id: http://core.svn.wordpress.org/trunk@46043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-21 16:06:57 +00:00
4d9c482e79
File Editor: Don't verify SSL certificate when doing loopback requests for checking for fatal errors.
...
Props Clorith.
See #47957 .
Built from https://develop.svn.wordpress.org/trunk@46230
git-svn-id: http://core.svn.wordpress.org/trunk@46042 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-21 15:59:56 +00:00
01b6bd9f38
Site Health: Replace `wp_get_upload_dir()` with `wp_upload_dir()`.
...
`wp_get_upload_dir()` returns the theoretical path of the uploads directory. When there was no upload yet the test returns an incorrect result (not writeable) because the directory doesn't exist. Switching to `wp_upload_dir()`, which creates the directory on the fly, ensures a proper test result.
Fixes #47958 .
Built from https://develop.svn.wordpress.org/trunk@46228
git-svn-id: http://core.svn.wordpress.org/trunk@46040 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-21 15:49:57 +00:00
a879bcb1c6
Code Modernization: Remove a workaround for `IMAGETYPE_ICO` in `file_is_displayable_image()`.
...
The `IMAGETYPE_ICO` constant was introduced in PHP 5.3, so no longer needs a workaround.
Props jrf.
See #48074 .
Built from https://develop.svn.wordpress.org/trunk@46217
git-svn-id: http://core.svn.wordpress.org/trunk@46029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 22:18:59 +00:00
594f77dbae
Docs: Add missing `$which` parameter descriptions.
...
Follow up of [46211].
See #45954 .
Built from https://develop.svn.wordpress.org/trunk@46212
git-svn-id: http://core.svn.wordpress.org/trunk@46024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:57:57 +00:00
ba2700068d
Networks and Sites: Add support for the `extra_tablenav()` method in `WP_MS_Sites_List_Table`.
...
This method allows additional filters or other UI components to be added to the top and bottom of the `WP_List_Table` between the bulk actions dropdown and search input field.
Fixes #45954 .
Props pbiron, desrosj.
Built from https://develop.svn.wordpress.org/trunk@46211
git-svn-id: http://core.svn.wordpress.org/trunk@46023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:53:58 +00:00
a9aefc83bc
Code Modernization: Remove conditional use of PHP `realpath()`.
...
The `realpath()` function was introduced in PHP 4.0.0. There's no point in checking if the function exists in PHP 5.6+, in only 2 instances out of 29.
Props jrf.
Fixes #48075 .
Built from https://develop.svn.wordpress.org/trunk@46210
git-svn-id: http://core.svn.wordpress.org/trunk@46022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:46:56 +00:00
d2ebf7d0e4
Privacy: Display group items count in the personal data export file if there's more than one item in the group.
...
Props birgire, garrett-eclipse, pputzer.
Fixes #46895 .
Built from https://develop.svn.wordpress.org/trunk@46209
git-svn-id: http://core.svn.wordpress.org/trunk@46021 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:30:58 +00:00
a2f45dc9eb
Media: make search input full width on mobile. Take two.
...
Props m1tk00.
Fixes #40130 .
Built from https://develop.svn.wordpress.org/trunk@46207
git-svn-id: http://core.svn.wordpress.org/trunk@46019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:09:54 +00:00
3cf6276ed0
Code Modernization: Remove JSON extension workarounds for PHP < 5.6.
...
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), JSON extension related polyfills and backwards compatibility code can now be removed.
This change removes code that supported JSON related functionality on older versions of PHP. This includes (but is not limited to) checks that `json_last_error()` exists, checking and setting the `JSON_UNESCAPED_SLASHES` and `JSON_PRETTY_PRINT` constants if not previously defined, and deprecating the `_wp_json_prepare_data()` function (which was 100% workaround code).
Follow up of [46205].
See #47699 .
Props jrf, Clorith, pento.
Built from https://develop.svn.wordpress.org/trunk@46206
git-svn-id: http://core.svn.wordpress.org/trunk@46018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 20:08:57 +00:00
0628245170
Admin email verification:
...
- Fix wording of the HTML title.
- Add hidden `(opens in a new tab)` to links that need it.
- Add the `screen-reader-text` CSS class to login.css.
- Add another translator comment.
Props afercia.
See #46349 .
Built from https://develop.svn.wordpress.org/trunk@46203
git-svn-id: http://core.svn.wordpress.org/trunk@46015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 18:51:56 +00:00
29ea4c6a4c
Media/Upload: rotate images on upload according to EXIF Orientation.
...
Props msaggiorato, wpdavis, markoheijnen, dhuyvetter, msaggiorato, n7studios, triplejumper12, pbiron, mikeschroder, joemcgill, azaozz.
Fixes #14459 .
Built from https://develop.svn.wordpress.org/trunk@46202
git-svn-id: http://core.svn.wordpress.org/trunk@46014 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 18:21:57 +00:00
38254bdc6f
Site Health: Use sentence casing consistently in header tags.
...
Props SergeyBiryukov, ajayghaghretiya1, ronakganatra, mukesh27, Clorith.
Fixes #47298 .
Built from https://develop.svn.wordpress.org/trunk@46199
git-svn-id: http://core.svn.wordpress.org/trunk@46011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 17:26:57 +00:00
d968a74e2a
Docs: Add `@since` tag for the new `$position` argument added to `add_submenu_page()` and related functions in [46197].
...
See #39776 .
Built from https://develop.svn.wordpress.org/trunk@46198
git-svn-id: http://core.svn.wordpress.org/trunk@46010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 17:06:57 +00:00
6ca808129c
Menus: add a position argument to `add_submenu_page` and the helper functions that use it.
...
Add a position argument to the `add_submenu_page` function similar to the one already in `add_menu_page`. When adding sub menus enables setting the position in the sub menu where the item should appear.
In addition, add the position argument to functions that call `add_submenu_page` under the hood: `add_management_page`, `add_options_page`, `add_theme_page`, `add_plugins_page`, `add_users_page`, `add_dashboard_page`, `add_posts_page`, `add_media_page`, `add_links_page`, `add_pages_page` and `add_comments_page`.
Props welcher, birgire, alexvorn2.
Fixes #39776 .
Built from https://develop.svn.wordpress.org/trunk@46197
git-svn-id: http://core.svn.wordpress.org/trunk@46009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-20 15:00:59 +00:00
a014bd21c1
Multisite: Remove the redundant `blog_versions` table.
...
As part of the Multisite installation process, a `blog_versions` table is created. This table is never read from (except immediately prior to updating it), it's only ever inserted into or updated. It is not used to determine which blogs need to be upgraded.
This table was introduced in 3.0 when the WPMU schema was merged #11644 and it appears the table has never been used in core and is therefore redundant and may as well be removed.
Props johnbillion, nacin, ryan, johnjamesjacoby, whyisjake.
Fixes #19755 . See #41685 .
Built from https://develop.svn.wordpress.org/trunk@46194
git-svn-id: http://core.svn.wordpress.org/trunk@46006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-19 22:07:57 +00:00
250eb42802
Networks and Sites: Save database version in site meta (Multisite)
...
Currently there is there a table in multisite called blog_versions. All this table stores is the database version as number and the date updated. With plans to add site meta in #37923 this new table should be used. This has a number of benefits, including functions to CRUD these values in the database. Once this data is in the blogmeta, table, the blog_versions table can be removed all together. If require a SQL view can be used blog_versions from data stored in blogmeta.
Props spacedmonkey, leogermani.
Fixes #41685 . See #19755 .
Built from https://develop.svn.wordpress.org/trunk@46193
git-svn-id: http://core.svn.wordpress.org/trunk@46005 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-19 21:42:58 +00:00
3d06de26a3
PHP 7.4: Fix another instance of array access on a datatype that cannot be accessed as an array.
...
PHP 7.4 adds a warning when trying access a null/bool/int/float/resource (everything but array, string and object) as if it were an array.
Follow up of [45639].
Props desrosj, jrf.
See #47704 .
Built from https://develop.svn.wordpress.org/trunk@46185
git-svn-id: http://core.svn.wordpress.org/trunk@45997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-19 14:30:56 +00:00
463e050b25
Uploads: add helper functions for setting, getting, and deleting the temp upload reference used to the attachment_id when retrying to make image sub-sizes.
...
See #47872 .
Built from https://develop.svn.wordpress.org/trunk@46174
git-svn-id: http://core.svn.wordpress.org/trunk@45986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-19 01:26:55 +00:00
08a077658d
Accessibility: Replace wp-a11y.js with @wordpress/a11y package
...
We've extracted wp-includes/wp-a11y.js to a reusable package wordpress/a11y which is published on NPM. Let's make sure this package is also used in WordPress core. Once all the JavaScript is built using webpack, we can also import this package wherever it is used and configure webpack to load is an external.
Props omarreiss, herregroen, desrosj, ocean90, afercia, sstoqnov
Built from https://develop.svn.wordpress.org/trunk@46167
git-svn-id: http://core.svn.wordpress.org/trunk@45979 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-18 17:41:55 +00:00
5a477b5715
Docs: Add missing descriptions for functions in `wp-admin/update-core.php`.
...
Also, fix the `@since` annotation added in [45480] to include the correct version.
Props SergeyBiryukov, ajayghaghretiya1.
Fixes #47424 .
Built from https://develop.svn.wordpress.org/trunk@46161
git-svn-id: http://core.svn.wordpress.org/trunk@45973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-17 20:43:56 +00:00
5329411f6d
General: Ensure the arguments passed to `implode()` are in the correct order.
...
The `implode()` function accepts two. parameters, `$glue` and `$pieces`. For historical reasons, these parameters have been accepted in any order, though it was recommended that the documented order of `$glue, $pieces` be used.
Starting in PHP 7.4, specifying the parameters in the reverse order will trigger a deprecation notice with the plan to remove this tolerance in PHP 8.0.
This change fixes the occurrences of reversed arguments in Core with the exception of those contained in included external libraries. These will be handled separately.
Props jrf, jorbin.
See #47746 .
Built from https://develop.svn.wordpress.org/trunk@46155
git-svn-id: http://core.svn.wordpress.org/trunk@45967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-17 13:40:57 +00:00
757d077669
Network Admin: Allow Sites to have filterable States in List Table rows.
...
This change introduces a new `site_states()` method to the Sites List Table class (with a new `display_site_states` filter inside of it) following the pattern popularized in other List Table classes before it (Posts, Media, etc...)
Fixes #37684 . Props mnelson4, pbiron, jeremyfelt, johnjamesjacoby.
Built from https://develop.svn.wordpress.org/trunk@46153
git-svn-id: http://core.svn.wordpress.org/trunk@45965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-16 23:34:55 +00:00
e6bbff13c5
Code Modernisation: Replace `call_user_func_array()` in various `__call()` methods with dynamic function calls.
...
The callback in these functions is always checked against a limited list of valid callbacks that can be safely changed to dynamic function calls.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46144
git-svn-id: http://core.svn.wordpress.org/trunk@45956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:53:56 +00:00
8ee3790851
Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/widgets.php` and associated unit tests with a direct function call.
...
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46138
git-svn-id: http://core.svn.wordpress.org/trunk@45950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:41:55 +00:00
f166554882
Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/template.php` with a dynamic function call.
...
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46137
git-svn-id: http://core.svn.wordpress.org/trunk@45949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:35:56 +00:00
7c370fa9d0
Code Modernisation: Replace `call_user_func_array()` in `wp-admin/includes/ajax-actions.php` with a dynamic function call.
...
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46136
git-svn-id: http://core.svn.wordpress.org/trunk@45948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:34:57 +00:00
30fe3f5d4f
Code Modernisation: Introduce the spread operator in `wp-admin/includes/media.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46131
git-svn-id: http://core.svn.wordpress.org/trunk@45943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:12:55 +00:00
7093392099
Code Modernisation: Introduce the spread operator in `wp-admin/includes/dashboard.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46130
git-svn-id: http://core.svn.wordpress.org/trunk@45942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 11:11:56 +00:00
340b7b53c8
Code Modernisation: Introduce the spread operator in `wp-admin/includes/class-*-upgrader-skin.php`.
...
Rather than relying `func_get_args()` to retrieve arbitrary function arguments, we can now use the spread operator to assign them directly to a variable.
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46125
git-svn-id: http://core.svn.wordpress.org/trunk@45937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-15 10:42:54 +00:00
099eb0578e
Block Editor: Add preloading of autosaves.
...
With the introduction of https://github.com/WordPress/gutenberg/pull/7945 , the block editor requests autosave data when the editor is loaded. This can be optimized by preloading the request server-side and then passing the request data to the client using the preloading mechanism in editor-form-blocks.php.
Props: talldanwp, aduth.
Built from https://develop.svn.wordpress.org/trunk@46110
git-svn-id: http://core.svn.wordpress.org/trunk@45922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-14 16:47:54 +00:00
Sergey Biryukov
Mike Schroder
whyisjake
youknowriad
John Blackbourn
desrosj
Aaron Jorbin
ellatrix
Andrew Ozz
Andrea Fercia
Adam Silverstein
Dominik Schilling
TimothyBlynJacobs
noisysocks
gziolo
jorgefilipecosta
antpb
joedolson
johnjamesjacoby
Ella Iseulde Van Dorpe