Commit Graph

17400 Commits

Author SHA1 Message Date
Scott Taylor f888767c73 `$status` shouldn't be loosely compared to `true` in `wp_xmlrpc_server::wp_deleteComment()`.
`$initial` shouldn't be loosely compared to `true` in `get_calendar()`.
`current_user_can()` shouldn't be loosely compared to `false` in `kses_init()`
`$get_all` shouldn't be loosely compared to `true` in `get_blog_details()`.
`is_array()` and `in_array()` shouldn't be loosely compared in `wpmu_validate_user_signup()`.
`$result` should by strictly compared in `check_ajax_referer()`.
`wp_verify_nonce()` should by strictly compared in `_show_post_preview()`.
`is_user_logged_in()` should not be loosly compared against `false` in `wp-signup.php`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32733


git-svn-id: http://core.svn.wordpress.org/trunk@32704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:48:26 +00:00
Scott Taylor 740b92853d `WP_Customize_Setting::is_current_blog_previewed()` should only return `false`, not `false` or `void`. The one invocation of the method only loosely checks the return value.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32732


git-svn-id: http://core.svn.wordpress.org/trunk@32703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:29:26 +00:00
Scott Taylor 3b1e434c3b Add the proper access modifier to `_init_caps()` in `WP_User`. Add `__call()` for BC.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32731


git-svn-id: http://core.svn.wordpress.org/trunk@32702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:26:25 +00:00
Scott Taylor d2a00338f6 Don't loosely compare functions that return `bool` against a literal `bool`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32730


git-svn-id: http://core.svn.wordpress.org/trunk@32701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:19:27 +00:00
Scott Taylor 107d5b088d `page_template` should be annotated as `@property`, not `@property-read` in `WP_Post`. The property is set on an instance in `wp_insert_post()`
Props morganestes.
Fixes #32515.

Built from https://develop.svn.wordpress.org/trunk@32729


git-svn-id: http://core.svn.wordpress.org/trunk@32700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 17:01:24 +00:00
Scott Taylor 05682bdaa8 After [32596] and [32597], ensure that `wp_scripts|styles()` is called to ensure an instance is created of `WP_Scripts|Styles()` before calling `->do_items()`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32728


git-svn-id: http://core.svn.wordpress.org/trunk@32699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 16:54:24 +00:00
Boone Gorges 2459cbd20f Introduce `class` argument to `wp_dropdown_pages()`.
This new argument allows devs to specify the 'class' attribute of the select
element.

Props ramiy, voldemortensen.
Fixes #30082.
Built from https://develop.svn.wordpress.org/trunk@32727


git-svn-id: http://core.svn.wordpress.org/trunk@32698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 13:05:27 +00:00
Dion Hulse c445d60a00 SSH2 Upgrade transport: Use ssh2_sftp_realpath() instead of shell commands to determine the current directory on the remote server. This should allow it to be used on chrooted SSH sessions.
See #32345

Built from https://develop.svn.wordpress.org/trunk@32726


git-svn-id: http://core.svn.wordpress.org/trunk@32696 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-12 06:31:28 +00:00
Konstantin Obenland cb39d03501 Improve non-visual feedback for list table items without terms.
Props karpstrucking, afercia.
Fixes #32150.


Built from https://develop.svn.wordpress.org/trunk@32725


git-svn-id: http://core.svn.wordpress.org/trunk@32695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-11 09:28:31 +00:00
Helen Hou-Sandí c87224eaf6 List tables: Use a class instead of inline styles for hidden columns.
fixes #32608.

Built from https://develop.svn.wordpress.org/trunk@32724


git-svn-id: http://core.svn.wordpress.org/trunk@32694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:47:27 +00:00
Helen Hou-Sandí 06ebd0a2aa List tables:
Since the primary column is not going to be alterable for plugins and MS themes, we don't need to check in on it.

see #25408.

Built from https://develop.svn.wordpress.org/trunk@32723


git-svn-id: http://core.svn.wordpress.org/trunk@32693 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 19:31:25 +00:00
Helen Hou-Sandí 51b5ed9fa4 List tables: Better primary column back-compat.
Why are people manually setting `$_column_headers` other than because somebody else told them to? Maybe time will tell.

props kovshenin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32722


git-svn-id: http://core.svn.wordpress.org/trunk@32692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 14:59:30 +00:00
Helen Hou-Sandí 3562ac028d List tables: Consolidate `<td>` output for posts.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32721


git-svn-id: http://core.svn.wordpress.org/trunk@32691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 14:01:28 +00:00
Konstantin Obenland ce16fd8dca More semantic markup for the post formats metabox.
Screen readers will now introduce the group of radio buttons.
Also brings the meta box to parity with Press This.

Props joedolson, afercia.
Fixes #26160.


Built from https://develop.svn.wordpress.org/trunk@32720


git-svn-id: http://core.svn.wordpress.org/trunk@32690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 09:09:25 +00:00
Jeremy Felt 0e76a2c570 Additional improvement to sites list table display
* Build `$blogname` identically when creating action link messaging.
* Remove the trailing slash from URLs for a better UI.

See #32434.

Built from https://develop.svn.wordpress.org/trunk@32719


git-svn-id: http://core.svn.wordpress.org/trunk@32689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 07:28:26 +00:00
Jeremy Felt 93ff65e677 Improve information displayed in a network's sites list table
* Better support for arbitrary domain/path combinations by displaying the URL in the primary column rather than Path or Domain.
* Show a cached count of total users per site as a more useful data point rather than the first 5 users.
* Clear that cached count of users for a site when a user is added to the site via `add_user_to_blog()`.

Props @ocean90.
Fixes #32434.

Built from https://develop.svn.wordpress.org/trunk@32718


git-svn-id: http://core.svn.wordpress.org/trunk@32688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 06:50:25 +00:00
Helen Hou-Sandí 005d937ce2 List tables:
* Avoid notices in custom list tables that manually set `$_column_headers`. Any plugins using this for a specific purpose should update.
* Restore a special class name in the users list table.

props georgestephanis, stephdau.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32717


git-svn-id: http://core.svn.wordpress.org/trunk@32687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-10 01:46:27 +00:00
Konstantin Obenland bafb008be1 When inline editing a post, reset password field to be editable by default.
The Quick Edit form is cloned and then populated with post-specific data. If the 
previous post was private, the password field would continue to be disabled for
the next post.

Props afercia.
Fixes #32259.


Built from https://develop.svn.wordpress.org/trunk@32716


git-svn-id: http://core.svn.wordpress.org/trunk@32686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 22:02:27 +00:00
Aaron Jorbin 82e8acd70b Remove Truthy check from DO_NOT_UPGRADE_GLOBAL_TABLES
Some, but not all, of the checks for DO_NOT_UPGRADE_GLOBAL_TABLES just check if it is defined, so checking for truthiness could cause the issue to not be fully fixed.

In the words of Colonel Jessep: You can't handle the truth!

Introduced in [32714]

Fixes #32011


Built from https://develop.svn.wordpress.org/trunk@32715


git-svn-id: http://core.svn.wordpress.org/trunk@32685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 22:00:28 +00:00
Aaron Jorbin d1586725d1 Add error if a user attempts to install WordPress with DO_NOT_UPGRADE_GLOBAL_TABLES defined
The install process runs through migrations to global tables, therefore we cannot install WordPress with this constant defined. This error message prevents a false success screen from being seen.

Fixes #32011.
Props Oxymoron.


Built from https://develop.svn.wordpress.org/trunk@32714


git-svn-id: http://core.svn.wordpress.org/trunk@32684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 17:59:24 +00:00
Boone Gorges 5dfd6a02a7 Avoid returning duplicate matches when using a meta query in `WP_User_Query`.
A meta_query containing an `OR` relation can result in the same record matching
multiple clauses, leading to duplicate results. The previous prevention against
duplicates [18178] #17582 became unreliable in 4.1 when `WP_Meta_Query`
introduced support for nested clauses. The current changeset adds a new method
`WP_Meta_Query::has_or_relation()` for checking whether an `OR` relation
appears anywhere in the query, and uses the new method in `WP_User_Query` to
enforce distinct results as necessary.

Props maxxsnake.
Fixes #32592.
Built from https://develop.svn.wordpress.org/trunk@32713


git-svn-id: http://core.svn.wordpress.org/trunk@32683 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 17:42:28 +00:00
Dion Hulse 6657e42c7d WP_HTTP: ensure that the temporary file is created within the temporary directly when `stream` is specified without a `filename` parameter.
Fixes #32549

Built from https://develop.svn.wordpress.org/trunk@32712


git-svn-id: http://core.svn.wordpress.org/trunk@32682 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-09 03:55:27 +00:00
Ella Iseulde Van Dorpe 00e4f35300 TinyMCE: wpviews: cache iframe heights
Cache iframe heights per instance so it can be reused. This will prevent to content from moving in the editor when undoing or redoing changes.

Fixes #32593.

Built from https://develop.svn.wordpress.org/trunk@32711


git-svn-id: http://core.svn.wordpress.org/trunk@32681 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-08 21:32:27 +00:00
Ella Iseulde Van Dorpe e9ac7f5164 TinyMCE: views: fix typo in createInstance
This prevented instances from being reused.

Fixes #32591.

Built from https://develop.svn.wordpress.org/trunk@32710


git-svn-id: http://core.svn.wordpress.org/trunk@32680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-08 19:54:25 +00:00
Boone Gorges e8ad0ff400 Filter out empty object_types in `register_taxonomy_for_object_type()`.
This prevents weird edge bugs when registering an existing taxonomy with an
object type when the taxonomy was previously associated with no object types.

Fixes #32590.
Built from https://develop.svn.wordpress.org/trunk@32709


git-svn-id: http://core.svn.wordpress.org/trunk@32679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-08 19:45:31 +00:00
Dominik Schilling 0549150843 Parse request: Quote regular expression characters in home path.
Adds unit tests.

props akirk.
fixes #30438.
Built from https://develop.svn.wordpress.org/trunk@32708


git-svn-id: http://core.svn.wordpress.org/trunk@32678 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-08 13:29:26 +00:00
Konstantin Obenland 6d56231da3 Sort screen options for meta boxes according to the meta box's priority.
Props swissspidy.
Fixes #32582.


Built from https://develop.svn.wordpress.org/trunk@32707


git-svn-id: http://core.svn.wordpress.org/trunk@32677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-08 12:35:26 +00:00
Ella Iseulde Van Dorpe ab1c4329b6 TinyMCE: wptextpattern: make tests ~2x faster
* Reuse the same instance for all tests in the module.
* Run without CSS (skin).
* Less typing.

See #31441.

Built from https://develop.svn.wordpress.org/trunk@32706


git-svn-id: http://core.svn.wordpress.org/trunk@32676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-07 22:16:24 +00:00
Ella Iseulde Van Dorpe c12af009c2 Editor: link modal: use link as fallback for text
If there is no link text provided, use the link as the text. This is better than silently failing.

Props bcole808.
Fixes #32323.

Built from https://develop.svn.wordpress.org/trunk@32705


git-svn-id: http://core.svn.wordpress.org/trunk@32675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-07 21:11:24 +00:00
Ella Iseulde Van Dorpe 8acda26129 Autoprefixer after autoprefixer-core 5.2 update
grunt-autoprefixer requires ^5.1.7, so this was automatically updated.

See #31700.

Built from https://develop.svn.wordpress.org/trunk@32704


git-svn-id: http://core.svn.wordpress.org/trunk@32674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-07 20:08:24 +00:00
Ella Iseulde Van Dorpe d74a115e21 TinyMCE: wptextpattern: add docs
Props DrewAPicture and iseulde.
See #31441.

Built from https://develop.svn.wordpress.org/trunk@32703


git-svn-id: http://core.svn.wordpress.org/trunk@32673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-07 20:00:28 +00:00
Sergey Biryukov c9dd28908a In `get_avatar()`, avoid a second `get_avatar_data()` call to get the 2x URL.
props ravinderk.
fixes #32572.
Built from https://develop.svn.wordpress.org/trunk@32702


git-svn-id: http://core.svn.wordpress.org/trunk@32672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-07 14:58:26 +00:00
Ella Iseulde Van Dorpe cf31f32475 Customizer: hide controls on test page
Introduced in [30919].
See #32577 and #30701.

Built from https://develop.svn.wordpress.org/trunk@32701


git-svn-id: http://core.svn.wordpress.org/trunk@32671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-07 09:04:32 +00:00
Ella Iseulde Van Dorpe 6926314730 TinyMCE: wptextpattern: disable for IE 8 and lower
Props azaozz, iseulde.
See #31441.

Built from https://develop.svn.wordpress.org/trunk@32700


git-svn-id: http://core.svn.wordpress.org/trunk@32670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-06 22:38:28 +00:00
Ella Iseulde Van Dorpe 356fd0ff81 TinyMCE: add wptextpattern plugin
This plugin can automatically format text patterns as you type. It includes two patterns: unordered (`* ` and `- `) and ordered list (`1. ` and `1) `). If the transformation in unwanted, the user can undo the change by pressing backspace, using the undo shortcut, or the undo button in the toolbar.

This is the first TinyMCE plugin that has unit tests and there's some good groundwork for adding tests to existing plugins in the future.

First run. See #31441.

Built from https://develop.svn.wordpress.org/trunk@32699


git-svn-id: http://core.svn.wordpress.org/trunk@32669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-06 20:07:24 +00:00
Ella Iseulde Van Dorpe ff17bd95fe QUnit: test minified files
Fixes #32574.

Built from https://develop.svn.wordpress.org/trunk@32698


git-svn-id: http://core.svn.wordpress.org/trunk@32668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-06 19:58:24 +00:00
Ella Iseulde Van Dorpe 521de0130b Browserify after [32677]
See #30949.

Built from https://develop.svn.wordpress.org/trunk@32697


git-svn-id: http://core.svn.wordpress.org/trunk@32667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-06 19:50:29 +00:00
Sergey Biryukov 50369e1c98 Add `@since` for `check_password_reset_key()`, `reset_password()`, and `register_new_user()`.
see #20279.
Built from https://develop.svn.wordpress.org/trunk@32696


git-svn-id: http://core.svn.wordpress.org/trunk@32666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 20:39:26 +00:00
Helen Hou-Sandí 93b5a9a7fa Nav menus: Hidden inputs do not need an ID, especially one that's already in use.
props sagarjadhav.
fixes #31816.

Built from https://develop.svn.wordpress.org/trunk@32695


git-svn-id: http://core.svn.wordpress.org/trunk@32665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 15:36:27 +00:00
Konstantin Obenland c20edc4df5 Remove title attributes in user list tables.
They don't add valuable information and are redundant.
Reduces annoyance for screen reader users.

Props afercia.
Fixes #32535.


Built from https://develop.svn.wordpress.org/trunk@32694


git-svn-id: http://core.svn.wordpress.org/trunk@32664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 08:40:26 +00:00
Konstantin Obenland 5daf12dba4 Text improvements for screen readers in list table paginations.
Removes title attributes where reasonable and uses accessible hidden text.
Screen readers will now correctly read out all available information.

Props afercia, rianrietveld.
Fixes #32028.


Built from https://develop.svn.wordpress.org/trunk@32693


git-svn-id: http://core.svn.wordpress.org/trunk@32663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-05 05:01:25 +00:00
Boone Gorges f88996bed7 In `wp_notify_moderator()`, don't throw notice when comment belongs to a post with no author.
Props Oxymoron.
Fixes #32566.
Built from https://develop.svn.wordpress.org/trunk@32692


git-svn-id: http://core.svn.wordpress.org/trunk@32662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-04 17:29:25 +00:00
Helen Hou-Sandí 0e77b693ac Nav menus: hide the title attribute field by default for new users and installs.
It is still available in screen options. This also gives the "Navigation Label", a crucial field, the room it really deserves.

props paulwilde.
fixes #32218.

Built from https://develop.svn.wordpress.org/trunk@32691


git-svn-id: http://core.svn.wordpress.org/trunk@32661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-04 04:38:25 +00:00
Helen Hou-Sandí 9d0ab29bc4 Nav menus: Provide visual feedback when attempting to add an empty custom link.
props pragunbhutani for the initial patch.
fixes #18517.

Built from https://develop.svn.wordpress.org/trunk@32690


git-svn-id: http://core.svn.wordpress.org/trunk@32660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-04 04:31:26 +00:00
John Blackbourn acec5066f6 Switch to pointer tolerance for improved drag and drop behaviour when reordering widgets.
Props jkudish, MikeHansenMe.
Fixes #20791

Built from https://develop.svn.wordpress.org/trunk@32689


git-svn-id: http://core.svn.wordpress.org/trunk@32659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 22:59:25 +00:00
Helen Hou-Sandí 6f6788c4af Media list view: ensure thumbnails are appropriately sized and constrained.
see #29993.

Built from https://develop.svn.wordpress.org/trunk@32688


git-svn-id: http://core.svn.wordpress.org/trunk@32658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:23:25 +00:00
Helen Hou-Sandí 40fca44c89 Media: move the thumbnail into the title column in list view.
This gives us more space for the title and row actions, and will make a responsive list table enhancement significantly easier.

props bradt for the initial patch.
fixes #29993 and #32255. see #32509 and #32395.

Built from https://develop.svn.wordpress.org/trunk@32687


git-svn-id: http://core.svn.wordpress.org/trunk@32657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:13:25 +00:00
Helen Hou-Sandí 2d3a637598 List tables: tighten up primary column handling for plugins and multisite themes.
These shouldn't be able to have their primary column reassigned by default. Also removes the `has-row-actions` class as these list tables always have row actions visible and the JS for visual toggling conflicts. The `column-primary` class remains.

props stephdau.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32686


git-svn-id: http://core.svn.wordpress.org/trunk@32656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-03 15:08:28 +00:00
Boone Gorges 2c9a2850b4 Add `@since` entry for 'has_published_post' argument of `WP_User_Query`.
Mega-props DrewAPicture.
Fixes #32250.
Built from https://develop.svn.wordpress.org/trunk@32685


git-svn-id: http://core.svn.wordpress.org/trunk@32655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-02 18:21:26 +00:00
Boone Gorges 0471408596 Normalize whitespace in docblock for `WP_User_Query::prepare_query()`.
Built from https://develop.svn.wordpress.org/trunk@32684


git-svn-id: http://core.svn.wordpress.org/trunk@32654 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-02 13:35:26 +00:00
Boone Gorges 6db02371ec Introduce `'has_published_posts'` parameter for `WP_User_Query`.
This allows user query results to be limited to those users who have published
posts in at least one of the specified post types.

Props joehoyle, boonebgorges.
Fixes #32250.
Built from https://develop.svn.wordpress.org/trunk@32683


git-svn-id: http://core.svn.wordpress.org/trunk@32653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-02 13:30:26 +00:00
Konstantin Obenland 5e787a900a Use WordPress' default focus styles for links on login screens.
Props afercia.
Fixes #31712.


Built from https://develop.svn.wordpress.org/trunk@32682


git-svn-id: http://core.svn.wordpress.org/trunk@32652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-02 05:51:27 +00:00
Dominik Schilling 974ca19e36 Customizer: Improve JS templates for Panels and Sections added in [32658].
* Always fall back to using the default template if no custom template exists.
* Provide a set of default params when constructing new `Section` and `Panel` objects.

Includes QUnit tests.

Props celloexpressions, westonruter, ocean90.
Fixes #30737.
Built from https://develop.svn.wordpress.org/trunk@32681


git-svn-id: http://core.svn.wordpress.org/trunk@32651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 22:47:25 +00:00
Andrew Ozz 02f5020d52 Editor: run autosave when pressing Ctrl or Command + S in the Text editor, same as the Visual editor.
Fixes #31655.
Built from https://develop.svn.wordpress.org/trunk@32680


git-svn-id: http://core.svn.wordpress.org/trunk@32650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 19:02:25 +00:00
Andrew Ozz 1c0419071f Emoji: make sure we parse only strings or DOM nodes that have children.
Props peterwilsoncc. Fixes #32300.
Built from https://develop.svn.wordpress.org/trunk@32679


git-svn-id: http://core.svn.wordpress.org/trunk@32649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 18:25:25 +00:00
Andrew Ozz 4f9682f39e TinyMCE wpView: preserve HTML wrapped in shortcodes.
Fixes #32078.
Built from https://develop.svn.wordpress.org/trunk@32678


git-svn-id: http://core.svn.wordpress.org/trunk@32648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 18:09:26 +00:00
Andrew Ozz b3d04247b7 Editor:
- Remove the old DFW.
- Add back-compat stub for wp-fullscreen.js.
- Keep wp_ajax_wp_fullscreen_save_post() for now.
See #30949.
Built from https://develop.svn.wordpress.org/trunk@32677


git-svn-id: http://core.svn.wordpress.org/trunk@32647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 17:38:29 +00:00
Sergey Biryukov ecf0bcc9fc Revert a part of [32673] that caused a fatal error with `SCRIPT_DEBUG` disabled.
see #19257.
Built from https://develop.svn.wordpress.org/trunk@32676


git-svn-id: http://core.svn.wordpress.org/trunk@32646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-01 04:14:25 +00:00
Sergey Biryukov 3fc78a1109 Avoid a PHP notice in `wp_enqueue_media()` if `$post` is null.
see #19257.
Built from https://develop.svn.wordpress.org/trunk@32675


git-svn-id: http://core.svn.wordpress.org/trunk@32645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 21:54:25 +00:00
John Blackbourn ff3f2ac243 Remove an embed handler accidentally introduced in r32673.
Built from https://develop.svn.wordpress.org/trunk@32674


git-svn-id: http://core.svn.wordpress.org/trunk@32644 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 16:56:26 +00:00
John Blackbourn 02192cb53f Introduce `featured_image`, `set_featured_image`, `remove_featured_image`, and `use_featured_image` post type labels when registering a post type in order to override the 'Featured Image' text and its related phrases.
Props johnbillion, mordauk, valendesigns.
Fixes #19257.

Built from https://develop.svn.wordpress.org/trunk@32673


git-svn-id: http://core.svn.wordpress.org/trunk@32643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 16:54:27 +00:00
Scott Taylor 42d51a4f89 Add doc blocks to functions that are missing them.
If the function has no need for `@param` or `@return`, do an archeaological dig to find `@since`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32672


git-svn-id: http://core.svn.wordpress.org/trunk@32642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 03:18:25 +00:00
Drew Jaynes 9cb1017b3c Fix inline documentation formatting in wp-admin/includes/admin-filters.php, introduced in [32653].
See #32529.

Built from https://develop.svn.wordpress.org/trunk@32671


git-svn-id: http://core.svn.wordpress.org/trunk@32641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 02:00:26 +00:00
Drew Jaynes 0df0e0bf36 Fix syntax and add a missing return description for inline documentation introduced in [32644] for `WP_Users_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32670


git-svn-id: http://core.svn.wordpress.org/trunk@32640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:45:27 +00:00
Drew Jaynes 65f31bc52e Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for `WP_Terms_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32669


git-svn-id: http://core.svn.wordpress.org/trunk@32639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:44:26 +00:00
Drew Jaynes a69f867738 Fix syntax and add missing return descriptions for inline documentation introduced in [32644] for `WP_Posts_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32668


git-svn-id: http://core.svn.wordpress.org/trunk@32638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:42:25 +00:00
Drew Jaynes 5e2983a77e Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Plugins_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32667


git-svn-id: http://core.svn.wordpress.org/trunk@32637 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:40:29 +00:00
Drew Jaynes d7428fc35d Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for `WP_MS_Users_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32666


git-svn-id: http://core.svn.wordpress.org/trunk@32636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:38:26 +00:00
Drew Jaynes 5e84c7004d Fix syntax and add a missing return description for inline documentation introduced in [32644] for `WP_MS_Themes_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32665


git-svn-id: http://core.svn.wordpress.org/trunk@32635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:36:27 +00:00
Drew Jaynes 88569734d8 Fix formatting and add missing return descriptions for inline documentation introduced in [32644] for `WP_MS_Sites_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32664


git-svn-id: http://core.svn.wordpress.org/trunk@32634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:34:25 +00:00
Drew Jaynes 42afe1d373 Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Media_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32663


git-svn-id: http://core.svn.wordpress.org/trunk@32633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:32:26 +00:00
Drew Jaynes 8bcf53cc68 Fix formatting and add missing return descriptions for inline documenation introduced in [32644] for `WP_List_Table`.
Also fixes an error introduced in [32661] for `WP_Links_List_Table`.

See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32662


git-svn-id: http://core.svn.wordpress.org/trunk@32632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:29:26 +00:00
Drew Jaynes 2a0048b1fb Fix formatting and add a missing return description for inline documentation introduced in [32644] for `WP_Links_List_Table`.
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32661


git-svn-id: http://core.svn.wordpress.org/trunk@32631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:23:26 +00:00
Drew Jaynes 5457eb4933 Add missing return descriptions and fix formatting of inline documentation introduced in [32644].
See #25408. See #32246.

Built from https://develop.svn.wordpress.org/trunk@32660


git-svn-id: http://core.svn.wordpress.org/trunk@32630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-31 01:18:26 +00:00
Boone Gorges 4b546044d8 Term unit test factory class should override `create_and_get()` method.
The override is necessary because the `get_term()` call, which fetches the
term object, needs the `'taxonomy'` argument passed to the factory method.

Props dlh.
Fixes #32536.
Built from https://develop.svn.wordpress.org/trunk@32659


git-svn-id: http://core.svn.wordpress.org/trunk@32629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-30 13:04:25 +00:00
Weston Ruter 98b03d376e Add JS templates for Customizer Panels and Sections.
This extends the approach taken for Customizer Controls in #29572.

Props celloexpressions, westonruter, ocean90.
See #30737.

Built from https://develop.svn.wordpress.org/trunk@32658


git-svn-id: http://core.svn.wordpress.org/trunk@32628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-30 00:03:30 +00:00
Scott Taylor c502a281bb After [32656], add `@access` annotations to methods that have no doc block in `wp-includes/*`.
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32657


git-svn-id: http://core.svn.wordpress.org/trunk@32627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:37:24 +00:00
Scott Taylor 6a08b00632 Add `@access` annotations to methods that have no doc block in `wp-admin/includes/*`.
Makes it easier to search for no doc blocks via `}[\n\t\r ]+(protected|private|public)`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32656


git-svn-id: http://core.svn.wordpress.org/trunk@32626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:32:24 +00:00
Scott Taylor b3e0cfd25d Add (more) missing doc blocks to `wp-admin/includes/*`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32655


git-svn-id: http://core.svn.wordpress.org/trunk@32625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 21:17:27 +00:00
Scott Taylor c6a4512b1b Add missing doc blocks to `wp-admin/includes/*`.
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 20:17:26 +00:00
Scott Taylor a51dfa3971 In the style of #30947 and `default-filters.php`, add 2 new files to `wp-admin/includes`:
`admin-filters.php`
`ms-admin-filters.php`

There are random actions and filters littered among files like `misc.php`. These files contain functions that won't work outside of admin context and are typically only loaded in files that have already loaded the admin bootstrap.

See #32529.

Built from https://develop.svn.wordpress.org/trunk@32653


git-svn-id: http://core.svn.wordpress.org/trunk@32623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 17:04:26 +00:00
Scott Taylor 9a29d8ac7b Add missing` annotations to `ajax-actions.php`
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32652


git-svn-id: http://core.svn.wordpress.org/trunk@32622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 16:01:27 +00:00
Helen Hou-Sandí f5646cd9e5 Define a primary column for `WP_Post_Comments_List_Table`.
props boonebgorges.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32651


git-svn-id: http://core.svn.wordpress.org/trunk@32621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 15:52:25 +00:00
Scott Taylor 19a3aacc94 Add `@static*` annotations where they are missing.
Initialize all static vars that are not, most to `null`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32650


git-svn-id: http://core.svn.wordpress.org/trunk@32620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 15:43:29 +00:00
Dominik Schilling fccc19b510 Customizer: Replace accordion behavior of sections with a slide-in navigation.
This allows users to focus on the contents of the active section more easily and separating the navigation from the content/controls in the Customizer.

props valendesigns, celloexpressions.
see #31336.
Built from https://develop.svn.wordpress.org/trunk@32649


git-svn-id: http://core.svn.wordpress.org/trunk@32619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 13:57:26 +00:00
Boone Gorges ebac76facc When parsing what appears to be a date archive request, check for a post with a clashing permalink before resolving to the archive.
A URL like `example.com/2015/05/15/` generally resolves to the May 15, 2015 date
archive. But in certain cases, it could also be the permalink of a post with
the slug `'2015'`. When a conflict of this sort is detected, resolve to the post
instead of the archive.

URL conflicts of this sort should no longer occur for new posts; see [32647].

Props valendesigns, boonebgorges, Denis-de-Bernardy.
Fixes #5305.
Built from https://develop.svn.wordpress.org/trunk@32648


git-svn-id: http://core.svn.wordpress.org/trunk@32618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 13:10:24 +00:00
Boone Gorges 9f0c6cbf8c Disallow post slugs that will result in permalinks that conflict with date archive URLs.
On certain permalink structures, a numeric post slug will result in a post
permalink that conflicts with a date archive URL. For example, with permastruct
`/%year%/%monthnum%/%postname%/`, a post published in May 2015 with slug
`'15'` will result in a URL (`/2015/05/15/`) that conflicts with the archive
for May 15, 2015.

To avoid this problem, `wp_unique_post_slug()` rejects a requested slug when it
would generate a conflict of this type. Thus, in our example, `'15'` would
become `'15-2'`.

Props valendesigns, boonebgorges, Denis-de-Bernardy, loushou.
See #5305.
Built from https://develop.svn.wordpress.org/trunk@32647


git-svn-id: http://core.svn.wordpress.org/trunk@32617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 12:53:24 +00:00
Boone Gorges 66d76318b8 `is_email_address_unsafe()` tests should only be run on multisite.
See [32638].
Built from https://develop.svn.wordpress.org/trunk@32646


git-svn-id: http://core.svn.wordpress.org/trunk@32616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 12:38:30 +00:00
Helen Hou-Sandí fbb83441cb After [32644], sanity for a pile of selectors.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32645


git-svn-id: http://core.svn.wordpress.org/trunk@32615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 03:00:26 +00:00
Helen Hou-Sandí 4c0c7fd7ba List tables: introduce the concept of a "primary" column.
This becomes the column that contains the row actions, and allows for a more flexibility, particularly with custom post types and list tables. To (re)define the primary column, use the `list_table_primary_column` filter, which receives the column name and the screen ID as arguments.

props stephdau, DaveAl, jesin.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@32644


git-svn-id: http://core.svn.wordpress.org/trunk@32614 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 02:41:25 +00:00
Scott Taylor 282e28ad81 Add `@global` annotations to (the rest of the?) `wp-admin/*` files.
Does not include list table file changes.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32643


git-svn-id: http://core.svn.wordpress.org/trunk@32613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 02:06:31 +00:00
Scott Taylor b56b9b3e5c Add `@global` annotations for `wp-admin/*`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32642


git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Scott Taylor 6ab487dde6 Add missing/alter existing doc blocks for `wp-db.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32641


git-svn-id: http://core.svn.wordpress.org/trunk@32611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 20:10:29 +00:00
Scott Taylor 2f3e567f44 Alter visibility of some properties in `wpdb`:
`num_queries` is accessed publicly in core.
`num_rows` is accessed publicly in `ms-settings.php`.
`insert_id` is accessed publicly in core.
`prefix` is accessed publicly in `upgrade.php` and `capabilities.php`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32640


git-svn-id: http://core.svn.wordpress.org/trunk@32610 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 16:34:25 +00:00
Scott Taylor bece996d45 Add missing doc blocks to `widgets.php`.
Cleanup `@return` values.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32639


git-svn-id: http://core.svn.wordpress.org/trunk@32609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 16:20:25 +00:00
Boone Gorges b1c2305aa1 Improve tests for `is_email_address_unsafe()`.
* Move to a separate file for better organization and method names.
* Use a `dataProvider` when appropriate, for better readability.
* Add a test for splitting the banned domain list on line breaks.

See #20459, #21730.
Built from https://develop.svn.wordpress.org/trunk@32638


git-svn-id: http://core.svn.wordpress.org/trunk@32608 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 16:06:27 +00:00
Scott Taylor d38fed6449 Add missing doc blocks to `user.php`.
`username_exists()` should return `false` instead of `null`, just like `email_exists()` does, which is right under it.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32637


git-svn-id: http://core.svn.wordpress.org/trunk@32607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 15:51:25 +00:00
Helen Hou-Sandí abfece527b About: Give bottom navigation links the full width.
This will prevent longer strings from wrapping needlessly, and is more semantically correct markup.

props tyxla.
fixes #32391.

Built from https://develop.svn.wordpress.org/trunk@32636


git-svn-id: http://core.svn.wordpress.org/trunk@32606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 15:39:24 +00:00
Scott Taylor 66a9c83284 Add missing doc blocks to `update.php`:
* `wp_version_check()`, `wp_update_plugins()`, and `wp_update_themes()` do not return meaningful responses, and their responses are never handled by core. As such, they shouldn't alternately return `void` or `false`. "Returning" in those functions is just "bailing"
* In the same functions, `version.php` doesn't need to load if `WP_INSTALLING` is defined - the function will immediately bail, the values will never be read, and the globals won't be reset. I have unified the approach in all 3 functions.
* When returning filtered `$locale`, there is no need to set the variable twice.
* In `_maybe_update_core()`, `isset()` can take multiple values to bail before the call to `time()`, if necessary. This is a micro-optimization to prevent PHP from hitting the OS unnecessarily.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32635


git-svn-id: http://core.svn.wordpress.org/trunk@32605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 15:29:28 +00:00
Jeremy Felt f1ff34e547 Use a dataProvider for network option sanitization tests.
Cleans up tests for sanitization of `illegal_names`, `illegal_email_domains`, and `banned_email_domains` network options.

Fixes #32517.

Built from https://develop.svn.wordpress.org/trunk@32634


git-svn-id: http://core.svn.wordpress.org/trunk@32604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 06:38:25 +00:00
Andrew Nacin 6df83c542b Revert change to default-filters.php in [32632]. see #32516.
Built from https://develop.svn.wordpress.org/trunk@32633


git-svn-id: http://core.svn.wordpress.org/trunk@32603 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 05:52:25 +00:00
Andrew Nacin 65c382d550 Fix `return` error in get_theme_mods() from [32629].
Split a line with both an assignment and a conditional, not to mention an interpolated variable. Lots going on, easy mistake to make.

props BrianLayman.
fixes #32516.

Built from https://develop.svn.wordpress.org/trunk@32632


git-svn-id: http://core.svn.wordpress.org/trunk@32602 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 05:51:25 +00:00
Andrew Nacin e9551d2d43 Add unit test asserting that serializable objects will never pass is_serialized(). see #17375.
Built from https://develop.svn.wordpress.org/trunk@32631


git-svn-id: http://core.svn.wordpress.org/trunk@32601 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 05:23:27 +00:00
Jeremy Felt a5c688e817 Use site objects rather than get_blog_status() in MS list tables.
Removes several repetitive calls to `get_blog_status()` that are not needed, as the data is already available as part of each site's object.

Fixes #32512.

Built from https://develop.svn.wordpress.org/trunk@32630


git-svn-id: http://core.svn.wordpress.org/trunk@32600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 23:14:29 +00:00
Scott Taylor b4eccbd5a0 Add missing doc blocks to `theme.php`.
Correct some `@return` values.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32629


git-svn-id: http://core.svn.wordpress.org/trunk@32599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 22:21:25 +00:00
Scott Taylor 0c1b765a6f Add missing doc blocks to `template.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32628


git-svn-id: http://core.svn.wordpress.org/trunk@32598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 22:04:26 +00:00
Scott Taylor 4777433584 Add missing doc blocks to `taxonomy.php`.
Correct some `@return` values.
Some functions can `return new WP_Error` without setting it to a variable.
Some functions can return their `apply_filters(...)` call without first setting it to a variable.
`is_object_in_taxonomy()` can return its conditional instead of if/else true/false.
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32627


git-svn-id: http://core.svn.wordpress.org/trunk@32597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 22:00:25 +00:00
Jeremy Felt 45ad4808d9 Provide all site flag data in objects returned by `get_blogs_of_user()`
Previously, `archived`, `spam`, and `deleted` properties were forced to `0` when returned by `get_blogs_of_user()`. This was originally introduced in [21794] as a way to prevent notices when properties were expected.

Instead, we can properly fill these properties with those retrieved from `get_blog_details()`.

Props realloc.
Fixes #32281.

Built from https://develop.svn.wordpress.org/trunk@32626


git-svn-id: http://core.svn.wordpress.org/trunk@32596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 21:23:26 +00:00
Mark Jaquith 0a70901c50 Insert temporary password field hook for feature development in a plugin.
Built from https://develop.svn.wordpress.org/trunk@32625


git-svn-id: http://core.svn.wordpress.org/trunk@32595 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 19:59:25 +00:00
Scott Taylor 2bac335bdc Add missing doc blocks to `shortcodes.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32624


git-svn-id: http://core.svn.wordpress.org/trunk@32594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 19:39:25 +00:00
Scott Taylor e4a574fc87 Add missing doc blocks to `script-loader.php`.
Use `wp_styles()` and `wp_scripts()` where appropriate. 
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32623


git-svn-id: http://core.svn.wordpress.org/trunk@32593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 19:34:27 +00:00
Scott Taylor 274daa059a Add missing doc blocks to `rewrite.php`.
Clarify `@return` values where necessary.
`add_permastruct()` doesn't need to return.
`->using_index_permalinks()` and `->using_mod_rewrite_permalinks()` can just return their conditions, instead of if/else true/false.
`->mod_rewrite_rules()` and `->iis7_url_rewrite_rules()` don't need to set a variable that is immediately returned.
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32622


git-svn-id: http://core.svn.wordpress.org/trunk@32592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 19:23:26 +00:00
Scott Taylor 5ee54c05ac Add missing doc blocks to `revision.php`.
Clarify `@return` values where necessary.
In `wp_delete_post_revision()`, `wp_delete_post()` doesn't return `WP_Error`, so that check can be removed.
`wp_revisions_to_keep()` always returns an `int`, so `wp_revisions_enabled()` can use strict comparison.
 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32621


git-svn-id: http://core.svn.wordpress.org/trunk@32591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 18:38:24 +00:00
Scott Taylor 1ef11d7789 Add missing doc blocks to `query.php`.
Clarify `@return` values where necessary.
Some wrapper functions don't need to return if the function they wrap doesn't return.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32620


git-svn-id: http://core.svn.wordpress.org/trunk@32590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 18:15:25 +00:00
Scott Taylor 2ebce023df Add missing doc blocks to `post.php`.
Clarify some existing values for `@param` and `@return`.
Some functions do not need to set a variable before immediately returning it.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32619


git-svn-id: http://core.svn.wordpress.org/trunk@32589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 17:05:26 +00:00
Scott Taylor 2f75a74b3e Add missing doc blocks to `post-thumbnail-template.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32618


git-svn-id: http://core.svn.wordpress.org/trunk@32588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 16:29:28 +00:00
Scott Taylor bba3f1785c Add missing doc blocks to `post-template.php`.
Correct some types for `@param` and `@return`.
`is_page_template()` can return the conditional instead of if/else true/false.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32617


git-svn-id: http://core.svn.wordpress.org/trunk@32587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 16:26:25 +00:00
Scott Taylor 4c6d8467e2 Add missing doc blocks to `post-formats.php`.
Correct some types for `@param` and `@return`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32616


git-svn-id: http://core.svn.wordpress.org/trunk@32586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 16:06:25 +00:00
Scott Taylor fd04235a04 Add missing doc blocks to `plugin.php`.
`has_filter()` can use strict comparison when checking `$has` internally.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32615


git-svn-id: http://core.svn.wordpress.org/trunk@32585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 15:56:26 +00:00
Scott Taylor 26554549c7 Add missing doc blocks for `pluggable.php`.
Correct some `@return` values.
`is_user_logged_in()` can simply return the `->exists()` call instead of if/else'ing true/false.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32614


git-svn-id: http://core.svn.wordpress.org/trunk@32584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-27 15:32:26 +00:00
Scott Taylor ea89aeee0b Fix doc blocks for `option.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32613


git-svn-id: http://core.svn.wordpress.org/trunk@32583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 22:17:25 +00:00
Scott Taylor cb0b0b109d Fix doc blocks for `nav-menu*.php` files.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32612


git-svn-id: http://core.svn.wordpress.org/trunk@32582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 22:10:25 +00:00
Scott Taylor 4d26d999ce Fix doc blocks for `ms-*.php` files.
A few functions can return a conditional instead of an `if`/`else` of `true`/`false`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32611


git-svn-id: http://core.svn.wordpress.org/trunk@32581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 21:51:31 +00:00
Scott Taylor cae2415562 Fix doc blocks for `meta.php`
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32610


git-svn-id: http://core.svn.wordpress.org/trunk@32580 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 19:33:25 +00:00
Scott Taylor 4bf8e158ec Fix doc blocks for `media*.php`
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32609


git-svn-id: http://core.svn.wordpress.org/trunk@32579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 19:23:25 +00:00
Scott Taylor 5845a0c372 Add missing doc blocks to `locale.php`
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32608


git-svn-id: http://core.svn.wordpress.org/trunk@32578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 18:59:25 +00:00
Scott Taylor 0ba1025d66 Add missing doc blocks to `load.php`
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32607


git-svn-id: http://core.svn.wordpress.org/trunk@32577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 18:53:27 +00:00
Scott Taylor bf16064448 Fix doc blocks to `link-template.php`
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32606


git-svn-id: http://core.svn.wordpress.org/trunk@32576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 18:44:25 +00:00
Scott Taylor 2787e0080a Add missing doc blocks to `l10n.php`
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32605


git-svn-id: http://core.svn.wordpress.org/trunk@32575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 18:13:25 +00:00
Boone Gorges 8f9a7c4f83 Improve unit tests for `wp_unique_post_slug()`.
See #5305.
Built from https://develop.svn.wordpress.org/trunk@32604


git-svn-id: http://core.svn.wordpress.org/trunk@32574 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 18:08:24 +00:00
Scott Taylor 4b24007353 Add missing doc blocks to `kses.php` - also fix some unfortunate whitespace issues in related funcs.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32603


git-svn-id: http://core.svn.wordpress.org/trunk@32573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 18:06:24 +00:00
Weston Ruter 7792b5c942 Add support for `WP_Widget::get_settings()` returning `ArrayIterator`/`ArrayObject` instances.
Plugins can use `pre_option_widget_{$id_base}` filters to return `ArrayIterator`/`ArrayObject` instances instead of primitive arrays. This makes possible for widget instance data to be drawn from somewhere else than `wp_options`, such as a custom post type.

Add unit tests for widgets.

Fixes #32474.


Built from https://develop.svn.wordpress.org/trunk@32602


git-svn-id: http://core.svn.wordpress.org/trunk@32572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-26 16:51:27 +00:00
Weston Ruter 0f5e6d2825 Fix wp_send_json_error() response for update-widget Ajax request, to return error code instead of error message, as the WP_Error objects are instantiated with codes and the messages are empty.
Fixes #32496.


Built from https://develop.svn.wordpress.org/trunk@32601


git-svn-id: http://core.svn.wordpress.org/trunk@32571 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 22:09:25 +00:00
Scott Taylor 19b8ef0c92 `get_comments()` can return `int`, so a few places need to check if the return value is traversable before passing what is assumed to be an `array`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32600


git-svn-id: http://core.svn.wordpress.org/trunk@32570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 17:59:25 +00:00
Scott Taylor 053790537f Cleanup doc blocks in `http.php`.
In the few functions that used `$objFetchSite` instead of `$http`: use the `$http` naming, which is more civilized.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32599


git-svn-id: http://core.svn.wordpress.org/trunk@32569 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 17:32:27 +00:00
Scott Taylor 82f5d2e9b5 Cleanup doc blocks in `general-template.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32598


git-svn-id: http://core.svn.wordpress.org/trunk@32568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 17:18:26 +00:00
Scott Taylor bbe2301960 Cleanup the use of `$wp_styles` global in `functions.wp-styles.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32597


git-svn-id: http://core.svn.wordpress.org/trunk@32567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 16:35:24 +00:00
Scott Taylor ebd7fe8a2f Cleanup the use of `$wp_scripts` global in `functions.wp-scripts.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32596


git-svn-id: http://core.svn.wordpress.org/trunk@32566 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 16:24:25 +00:00
Scott Taylor 89a6ace623 Add missing doc blocks to `wp-includes/functions.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32595


git-svn-id: http://core.svn.wordpress.org/trunk@32565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 16:11:25 +00:00
Boone Gorges 51a892f975 Pass the original `$user_id` variable to the filter in `get_the_author_meta()`.
Props dlh, chriscct7.
Fixes #32481.
Built from https://develop.svn.wordpress.org/trunk@32594


git-svn-id: http://core.svn.wordpress.org/trunk@32564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 13:06:25 +00:00
Ella Iseulde Van Dorpe 677c3e53bb Link modal: reset search results appropriately
Reset the search results when the input field is emptied with the
browser's "clear" button inside that field.

Fixes #32174.

Built from https://develop.svn.wordpress.org/trunk@32593


git-svn-id: http://core.svn.wordpress.org/trunk@32563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:41:25 +00:00
Ella Iseulde Van Dorpe 6e0e924de9 TinyMCE: wpeditimage: trim class
Don't add extra spaces to classes. It causes some tests in the TinyMCE QUnit test suite to fail.

Fixes #31764.

Built from https://develop.svn.wordpress.org/trunk@32592


git-svn-id: http://core.svn.wordpress.org/trunk@32562 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:35:28 +00:00
Drew Jaynes 4c37f68b79 Fix inline documentation syntax in `wp_xmlrpc_server`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32591


git-svn-id: http://core.svn.wordpress.org/trunk@32561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-25 06:25:25 +00:00
Scott Taylor bd8fafea54 Use `void` instead of `null` where appropriate when pipe-delimiting `@return` types. If a `@return` only contains `void`, remove it.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32568


git-svn-id: http://core.svn.wordpress.org/trunk@32538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-24 05:40:25 +00:00
Scott Taylor 876918dc53 Add missing doc blocks to `comment-template.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32567


git-svn-id: http://core.svn.wordpress.org/trunk@32537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-24 05:19:24 +00:00
Scott Taylor 451914addb Add missing doc blocks to `class.wp-(scripts|styles).php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32566


git-svn-id: http://core.svn.wordpress.org/trunk@32536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-24 05:05:26 +00:00
Drew Jaynes 459ccb0d8b Add missing or incomplete argument and return descriptions for `wp_xmlrpc_server->wp_editPost()`.
Also includes many small syntax fixes for inline documentation throughout the file.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@32565


git-svn-id: http://core.svn.wordpress.org/trunk@32535 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:47:25 +00:00
Drew Jaynes 2bebcf4c39 Add missing parameter and return descriptions to the DocBlock for `wp_xmlrpc_server->_convert_date_gmt()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32564


git-svn-id: http://core.svn.wordpress.org/trunk@32534 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:41:24 +00:00
Drew Jaynes d94d97eab6 Add missing parameter and return descriptions to the DocBlock for `wp_xmlrpc_server->_convert_date()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32563


git-svn-id: http://core.svn.wordpress.org/trunk@32533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:40:24 +00:00
Drew Jaynes 9f73a3351f Fix inline documentation syntax in the DocBlock for `wp_xmlrpc_server->_prepare_taxonomy()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32562


git-svn-id: http://core.svn.wordpress.org/trunk@32532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:38:25 +00:00
Drew Jaynes 8aa163e65a Fix some inline documentation syntax in the DocBlock for `wp_xmlrpc_server->minimum_args()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32561


git-svn-id: http://core.svn.wordpress.org/trunk@32531 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:37:26 +00:00
Drew Jaynes ebe60d1fc4 Use a valid parameter type of string for the `$name` parameter in the `xmlrpc_call` hook docs.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32560


git-svn-id: http://core.svn.wordpress.org/trunk@32530 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:36:26 +00:00
Drew Jaynes 18066945ae Add missing argument descriptions for the `$args` hash notation in `wp_xmlrpc_server->wp_getUsersBlogs()`.
See #32246.

Built from https://develop.svn.wordpress.org/trunk@32559


git-svn-id: http://core.svn.wordpress.org/trunk@32529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:33:27 +00:00
Drew Jaynes c76493d29b Properly notate the inline link to the `xmlrpc_blog_options` filter in the description for `wp_xmlrpc_server->initialise_blog_option_info()`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@32558


git-svn-id: http://core.svn.wordpress.org/trunk@32528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:30:26 +00:00
Drew Jaynes ed0421e7de Add a proper return description for the `wp_xmlrpc_server->addTwoNumbers()` method.
See [30181]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32557


git-svn-id: http://core.svn.wordpress.org/trunk@32527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:26:26 +00:00
Drew Jaynes 7a93dda2d2 Add proper descriptions for the `$methods`, `$blog_options`, and `$error` properties in `wp_xmlrpc_server`.
See [30181]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32556


git-svn-id: http://core.svn.wordpress.org/trunk@32526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:23:25 +00:00
Drew Jaynes 7a7df47087 Add a proper description comment for the `WP_Image_Editor_Imagick->$image` property.
See [30180]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32555


git-svn-id: http://core.svn.wordpress.org/trunk@32525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:20:24 +00:00
Drew Jaynes a94c16f334 Add a proper description comment for the `WP_Image_Editor_GD->$image` property.
See [30180]. See #30224.

Built from https://develop.svn.wordpress.org/trunk@32554


git-svn-id: http://core.svn.wordpress.org/trunk@32524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 19:10:28 +00:00
Boone Gorges 10dd80cc61 Introduced `$field` argument to `get_term_link()`.
This new argument allows developers to specify which term field should be
matched by the value of the `$term` parameter (in particular, 'name' and
'term_taxonomy_id' are now supported).

Props sudar, mordauk.
Fixes #14156.
Built from https://develop.svn.wordpress.org/trunk@32553


git-svn-id: http://core.svn.wordpress.org/trunk@32523 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 18:29:26 +00:00
Boone Gorges 0fa7bf9cb4 Unit tests for `get_term_link()`.
See #14156.
Built from https://develop.svn.wordpress.org/trunk@32552


git-svn-id: http://core.svn.wordpress.org/trunk@32522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-23 18:13:24 +00:00
Scott Taylor f217f8c5d2 Add missing doc blockss in `class-wp.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32551


git-svn-id: http://core.svn.wordpress.org/trunk@32521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 20:05:25 +00:00
Scott Taylor ecf4c668b3 Upgrade the doc blocks in `class-wp-xmlrpc-server.php`. Rehabilitate some unfortunate use of tabbing.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32550


git-svn-id: http://core.svn.wordpress.org/trunk@32520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 19:37:24 +00:00
Scott Taylor c8a224c48e Cleanup missing doc blocks for `class-wp-walker.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32549


git-svn-id: http://core.svn.wordpress.org/trunk@32519 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 17:59:25 +00:00
Drew Jaynes e90a327694 Add a missing `@since` version to a function introduced in [32541].
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32548


git-svn-id: http://core.svn.wordpress.org/trunk@32518 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 17:38:25 +00:00
Scott Taylor 1b960d56b6 Add missing doc blocks to `class-wp-theme.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32547


git-svn-id: http://core.svn.wordpress.org/trunk@32517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 17:31:27 +00:00
Scott Taylor bf43be3e9e Add missing doc blocks to `wp-image-editor*.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32546


git-svn-id: http://core.svn.wordpress.org/trunk@32516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 06:18:25 +00:00
Scott Taylor af7a017f46 When calling `unset()`, it is unnecessary to immediately precede it with a call to `isset()`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32545


git-svn-id: http://core.svn.wordpress.org/trunk@32515 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:47:25 +00:00
Scott Taylor 1fa7958fe8 Clean up doc blocks for `class-wp-embed.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32544


git-svn-id: http://core.svn.wordpress.org/trunk@32514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:15:26 +00:00
Scott Taylor 94f29f27a1 Clean up `@global` doc blocks/imports for `class-wp-editor.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32543


git-svn-id: http://core.svn.wordpress.org/trunk@32513 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:10:24 +00:00
Scott Taylor 082bfab426 Clean up `@global` doc blocks/imports for `class-wp-customizer-*.php` and friends.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32542


git-svn-id: http://core.svn.wordpress.org/trunk@32512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 05:06:25 +00:00
Scott Taylor 1b52916239 Create a function, `wp_roles()`, to DRY the inline instantiation of the `$wp_roles` global.
Add missing doc blocks for `capabilities.php`.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32541


git-svn-id: http://core.svn.wordpress.org/trunk@32511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 04:47:24 +00:00
Scott Taylor 3d130ba909 Add missing doc blocks for `canonical.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32540


git-svn-id: http://core.svn.wordpress.org/trunk@32510 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 04:26:26 +00:00
Scott Taylor ebd3201268 Add/standardize missing doc blocks for `cache.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32539


git-svn-id: http://core.svn.wordpress.org/trunk@32509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 04:24:26 +00:00
Scott Taylor 5c6ffc4dd6 Add missing doc blocks to `author-template.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32538


git-svn-id: http://core.svn.wordpress.org/trunk@32508 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 04:14:24 +00:00
Scott Taylor 83dd461b2f Add missing doc blocks to `admin-bar.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32537


git-svn-id: http://core.svn.wordpress.org/trunk@32507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 04:00:26 +00:00
Scott Taylor 3a5f584109 Add missing doc blocks to `class-wp-editor.php`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32536


git-svn-id: http://core.svn.wordpress.org/trunk@32506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-22 03:52:27 +00:00
Scott Taylor b2bbbf9759 In `class-wp-customize-*`, clarify/add some `@param`/`@return` blocks. Disambiguate some functions that are trying to return the `void` response of another function they call internally.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32535


git-svn-id: http://core.svn.wordpress.org/trunk@32505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 22:05:24 +00:00
Scott Taylor f7098c8c2e In `class-wp-admin-bar.php`, clarify/add some doc blocks.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32534


git-svn-id: http://core.svn.wordpress.org/trunk@32504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 21:39:24 +00:00
Scott Taylor 3c24a2b32b In `class-oembed.php`, clarify/add some `return` docs.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32533


git-svn-id: http://core.svn.wordpress.org/trunk@32503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 21:31:27 +00:00
Scott Taylor ed4aafa692 In `category.php`:
* Clarify some `return` docs.
* In `_make_cat_compat()`, ensure that `WP_Error` is not decorated

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32532


git-svn-id: http://core.svn.wordpress.org/trunk@32502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 21:18:24 +00:00
Scott Taylor 27522d1c00 In `category-template.php`:
* Clarify/add some `return` docs.
* In `walk_category_tree()` and `walk_category_dropdown_tree()`, make behavior consistent and don't pass `$walker` by-reference - it is no longer necessary to do that with object instances.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32531


git-svn-id: http://core.svn.wordpress.org/trunk@32501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 21:05:24 +00:00
Scott Taylor e724ed2b04 In `capabilities.php`, clarify/add some `return` docs.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32530


git-svn-id: http://core.svn.wordpress.org/trunk@32500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:47:26 +00:00
Scott Taylor 3f32bf7bc0 In `canonical.php`:
* Clarify some docs
* `redirect_canonical()` inconsistently returns `null` or `false` when bailing - can simply return.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32529


git-svn-id: http://core.svn.wordpress.org/trunk@32499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:30:25 +00:00
Scott Taylor 9b3271f635 In `cache.php`, clarify some `return` docs. Some `WP_Object_Cache` methods return `void`, so those wrapper functions don't need to return at all.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32528


git-svn-id: http://core.svn.wordpress.org/trunk@32498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:22:24 +00:00
Scott Taylor e4c19c591f In `bookmark.php`, clarify some `return` docs.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32527


git-svn-id: http://core.svn.wordpress.org/trunk@32497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:13:25 +00:00
Scott Taylor 04554bc30d In `author-template.php`, clarify/add some `return` docs.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32526


git-svn-id: http://core.svn.wordpress.org/trunk@32496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:10:26 +00:00
Scott Taylor c92608aebd In `admin-bar.php`, most functions simply return when a conditional is not met. `wp_admin_bar_render()` shouldn't explicitly return `false`.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32525


git-svn-id: http://core.svn.wordpress.org/trunk@32495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 20:09:24 +00:00
Boone Gorges 9d54232e39 Streamline support for multiple post types in `get_posts_by_author_sql()`.
* Don't accept a comma-separated list, only a single post type or an array of post types. This is easier to document.
* Add changelog entries to all calling functions.

Props DrewAPicture.
Fixes #32243.
Built from https://develop.svn.wordpress.org/trunk@32524


git-svn-id: http://core.svn.wordpress.org/trunk@32494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 19:49:29 +00:00
Boone Gorges 67c935ad9c Support multiple post types in `count_user_posts()` and other functions that use `get_posts_by_author_sql()`.
Props nikonratm.
Fixes #32243.
Built from https://develop.svn.wordpress.org/trunk@32523


git-svn-id: http://core.svn.wordpress.org/trunk@32493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 18:43:27 +00:00
Helen Hou-Sandí 248a49c930 Updates: Use the warning color for the backup notice, as it's not a success message.
props paulwilde.
fixes #32241.

Built from https://develop.svn.wordpress.org/trunk@32522


git-svn-id: http://core.svn.wordpress.org/trunk@32492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 18:10:25 +00:00
Aaron Jorbin 2dff825af7 In List Tables, ensure sorting indicator is visible on focus
In all List Tables, when tabbing through the sortable headers links, the "sorting-indicator" arrows are not displayed. Keyboard users are missing important feedback about the links purpose. 

Happy #GAAD

Props afercia
Fixes #32189


Built from https://develop.svn.wordpress.org/trunk@32521


git-svn-id: http://core.svn.wordpress.org/trunk@32491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 18:05:26 +00:00
Boone Gorges 33b99991a8 In `sanitize_option()`, pass the unsanitized `$value` to the filter.
Props simonwheatley, MikeHansenMe.
Fixes #26199.
Built from https://develop.svn.wordpress.org/trunk@32520


git-svn-id: http://core.svn.wordpress.org/trunk@32490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-21 18:00:26 +00:00
Boone Gorges 33b61a9244 Add tests for `check_comment()`.
Props CalEvans, rachelbaker.
Fixes #31108.
Built from https://develop.svn.wordpress.org/trunk@32519


git-svn-id: http://core.svn.wordpress.org/trunk@32489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-20 19:09:25 +00:00
John Blackbourn cde30a03aa Use the available user and blog factories in the `Tests_Multisite_Option::test_with_another_site()` test.
Fixes #32404

Built from https://develop.svn.wordpress.org/trunk@32518


git-svn-id: http://core.svn.wordpress.org/trunk@32488 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-20 19:03:26 +00:00
Scott Taylor a69b8b3b91 In `WP_Media_List_Table::get_views()`, declare `$num_posts` explicitly before looping.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32517


git-svn-id: http://core.svn.wordpress.org/trunk@32487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:50:27 +00:00
Scott Taylor 5a3dc2a371 In `WP_Comments_List_Table::column_comment()`, all of the nonced URLs can be defined in the same conditional block in which they are used. Not doing this causes ambiguity, and local vars are set that are not available to all execution paths.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32516


git-svn-id: http://core.svn.wordpress.org/trunk@32486 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:46:25 +00:00
Scott Taylor 45d897d0e7 In `wpdb::load_col_info()`, don't fetch the number of fields in the result row on each iteration of the `for` loop. It can be stored in a var and referenced.
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32515


git-svn-id: http://core.svn.wordpress.org/trunk@32485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 20:30:27 +00:00
Jeremy Felt 2a2e976501 Move network update submenu items to the Network Dashboard menu item
Provides parity with the placement of the "Updates" submenu item in single site.

props Ipstenu.
fixes #32431.

Built from https://develop.svn.wordpress.org/trunk@32514


git-svn-id: http://core.svn.wordpress.org/trunk@32484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 17:00:29 +00:00
Jeremy Felt 3471545942 s/anbled/enabled/ in `global_terms_enabled` filter documentation.
Fixes #32436.

Built from https://develop.svn.wordpress.org/trunk@32513


git-svn-id: http://core.svn.wordpress.org/trunk@32483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 06:35:25 +00:00
Jeremy Felt de7074efab Use `WP_TESTS_DOMAIN` in `test_get_blogaddress_by_id_with_valid_id()`
A hard coded `example.org` would break the test if a custom `WP_TESTS_DOMAIN` was specified. We should defer to the configured default.

Fixes #32026.

Built from https://develop.svn.wordpress.org/trunk@32512


git-svn-id: http://core.svn.wordpress.org/trunk@32482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 05:46:28 +00:00
Sergey Biryukov 96f787260f In `comment_form()`, ensure that filtered arguments contain all required default values.
props boonebgorges.
fixes #32312 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32511


git-svn-id: http://core.svn.wordpress.org/trunk@32481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 01:04:25 +00:00
Sergey Biryukov d40fe7d80b Allow `wp_dropdown_languages()` to return the markup instead of displaying.
props leewillis77, juliobox.
fixes #32432.
Built from https://develop.svn.wordpress.org/trunk@32510


git-svn-id: http://core.svn.wordpress.org/trunk@32480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-19 00:33:26 +00:00
Helen Hou-Sandí 348ec03052 Accessibility: Ensure screen reader text is read as words and not affected by word-wrap.
props afercia.
fixes #31962.

Built from https://develop.svn.wordpress.org/trunk@32509


git-svn-id: http://core.svn.wordpress.org/trunk@32479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-18 18:37:29 +00:00
Helen Hou-Sandí 7381d50904 Autoprefixer for [32506]. see #31874.
Built from https://develop.svn.wordpress.org/trunk@32508


git-svn-id: http://core.svn.wordpress.org/trunk@32478 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-15 20:44:25 +00:00
Boone Gorges 0949d6492f Improve unit tests for `wp_unique_term_slug()`.
See #20783.
Built from https://develop.svn.wordpress.org/trunk@32507


git-svn-id: http://core.svn.wordpress.org/trunk@32477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-15 20:38:27 +00:00
Helen Hou-Sandí 1e8a787aa1 Media: Visually align upload errors with other admin notices.
props sagarjadhav.
fixes #31874.

Built from https://develop.svn.wordpress.org/trunk@32506


git-svn-id: http://core.svn.wordpress.org/trunk@32476 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-15 16:19:26 +00:00
Andrew Ozz 8cbfdfa51b Fix dragging to the bottom of the screen on the Dashboard.
Props eltobiano. See #32094.
Built from https://develop.svn.wordpress.org/trunk@32505


git-svn-id: http://core.svn.wordpress.org/trunk@32475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-14 23:50:28 +00:00
Dion Hulse 2ba7f3da75 Allow plugins to activate other plugins within their Activation hook. Fixes #32368
Built from https://develop.svn.wordpress.org/trunk@32504


git-svn-id: http://core.svn.wordpress.org/trunk@32474 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-14 06:58:27 +00:00
Scott Taylor 1c0fa5f73a In `tb_show()` in `thickbox`, when loading content into `#TB_ajaxContent`, make sure a URL with no `?` doesn't break when `&random=` is appended to it.
Thickbox hasn't been updated since 2007, just FYI.

Fixes #31726.

Built from https://develop.svn.wordpress.org/trunk@32503


git-svn-id: http://core.svn.wordpress.org/trunk@32473 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 21:42:24 +00:00
Scott Taylor 2f82bbb60d In `views/button/select-mode-toggle`, don't hide the spinner with JS. This oversight is a symptom of the too-aggressive outside DOM handling that is happening in this view's `toggleBulkEditHandler` method.
Props afercia.
Fixes #32324.

Built from https://develop.svn.wordpress.org/trunk@32502


git-svn-id: http://core.svn.wordpress.org/trunk@32472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 21:27:27 +00:00
John Blackbourn 1c40b495a1 Add a viewport meta tag to `wp_die()`.
Props leogopal

Fixes #29336

Built from https://develop.svn.wordpress.org/trunk@32501


git-svn-id: http://core.svn.wordpress.org/trunk@32471 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 04:08:25 +00:00
Drew Jaynes 2aa620b76a Update the DocBlock for `wp_new_comment()` to reference the `wp_insert_comment()` documentation for argument information.
Fixes #31747.

Built from https://develop.svn.wordpress.org/trunk@32500


git-svn-id: http://core.svn.wordpress.org/trunk@32470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 02:54:26 +00:00
Drew Jaynes 4769bd2a4f Document the default arguments for `wp_insert_comment()` as a hash notation.
Props lamosty, rachelbaker.
See #31747.

Built from https://develop.svn.wordpress.org/trunk@32499


git-svn-id: http://core.svn.wordpress.org/trunk@32469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-13 02:51:28 +00:00
Boone Gorges 63eb910445 Respect `$_wp_suspend_cache_invalidation` in `clean_term_cache()`.
Props tollmanz, rmccue.
Fixes #28743.
Built from https://develop.svn.wordpress.org/trunk@32498


git-svn-id: http://core.svn.wordpress.org/trunk@32468 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-12 20:14:26 +00:00
Lance Willett 4633e1eb79 Twenty Fifteen: add missing social link Genericons styles for Skype and Path.
Fixes #32332, props philiparthurmoore.
Built from https://develop.svn.wordpress.org/trunk@32497


git-svn-id: http://core.svn.wordpress.org/trunk@32467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-12 18:15:27 +00:00
John Blackbourn da99450d30 Add a sanity check to `theme-compat/header.php` to avoid outputting CSS which could reference a non-existant file.
Props Mte90

Fixes 32240

Built from https://develop.svn.wordpress.org/trunk@32496


git-svn-id: http://core.svn.wordpress.org/trunk@32466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-12 10:47:29 +00:00
Andrew Ozz fe427017a5 Fix comments postbox:
- Add comment button text.
- Positioning of the Author, Email, URL fields.
Fixes #32349.
Built from https://develop.svn.wordpress.org/trunk@32495


git-svn-id: http://core.svn.wordpress.org/trunk@32465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-12 01:22:25 +00:00
Lance Willett ede6d64e7b Twenty Twelve: fix typo in readme.txt file.
See #31814, props TomasM.

Built from https://develop.svn.wordpress.org/trunk@32494


git-svn-id: http://core.svn.wordpress.org/trunk@32464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 23:32:26 +00:00
Lance Willett a170135a7c Twenty Fifteen: fix typo in readme file, props obenland. Format the release dates as per other bundled themes readme.txt file format.
See #31814.
Built from https://develop.svn.wordpress.org/trunk@32493


git-svn-id: http://core.svn.wordpress.org/trunk@32463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 21:56:25 +00:00
Lance Willett c4f78c9c29 Twenty Ten: add readme file to explain basic theme usage, link to changelog on Codex, and include license information.
Closes #31814, props mercime.
Built from https://develop.svn.wordpress.org/trunk@32492


git-svn-id: http://core.svn.wordpress.org/trunk@32462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 21:53:25 +00:00
Lance Willett daae491af9 Twenty Eleven: add readme file to explain basic theme usage, link to changelog on Codex, and include license information.
See #31814, props mercime.
Built from https://develop.svn.wordpress.org/trunk@32491


git-svn-id: http://core.svn.wordpress.org/trunk@32461 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 21:52:25 +00:00
Lance Willett d3dc56d6bd Twenty Twelve: add readme file to explain basic theme usage, link to changelog on Codex, and include license information.
See #31814, props mercime.
Built from https://develop.svn.wordpress.org/trunk@32490


git-svn-id: http://core.svn.wordpress.org/trunk@32460 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 21:49:26 +00:00
Lance Willett 0dce6cb21d Twenty Thirteen: add readme file to explain basic theme usage, link to changelog on Codex, and include license information.
See #31814, props mercime.
Built from https://develop.svn.wordpress.org/trunk@32489


git-svn-id: http://core.svn.wordpress.org/trunk@32459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 21:48:26 +00:00
Lance Willett 3d2ff11479 Twenty Fourteen: add readme file to explain basic theme usage, link to changelog on Codex, and include license information.
See #31814, props mercime.
Built from https://develop.svn.wordpress.org/trunk@32488


git-svn-id: http://core.svn.wordpress.org/trunk@32458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 21:46:25 +00:00
Lance Willett 7053929095 Twenty Fifteen: update readme file.
Props mercime, lancewillett. See #31814.
Built from https://develop.svn.wordpress.org/trunk@32487


git-svn-id: http://core.svn.wordpress.org/trunk@32457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 21:42:27 +00:00
Lance Willett 86c5b28894 Twenty Twelve: fix content skip link appearance.
Props davidakennedy, fixes #32232.

Built from https://develop.svn.wordpress.org/trunk@32486


git-svn-id: http://core.svn.wordpress.org/trunk@32456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 21:01:28 +00:00
Dominik Schilling a42b5dc78e Improve focus styles for the Switch View links in Posts listings and Media Library.
props afercia.
fixes #32294.
Built from https://develop.svn.wordpress.org/trunk@32485


git-svn-id: http://core.svn.wordpress.org/trunk@32455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 19:34:27 +00:00
Boone Gorges 7314a0f3df In category dropdown, 'selected' should match against 'value_field'.
Props tlexcellent.
Fixes #32330.
Built from https://develop.svn.wordpress.org/trunk@32484


git-svn-id: http://core.svn.wordpress.org/trunk@32454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-11 13:11:31 +00:00
John Blackbourn 987716720f Add a return value to `wp_register_script()` and `wp_register_style()` which matches the return value of `WP_Dependencies::add()`.
Props katzwebdesign, pareshradadiya, DrewAPicture.

Fixes #31126

Built from https://develop.svn.wordpress.org/trunk@32483


git-svn-id: http://core.svn.wordpress.org/trunk@32453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-10 19:57:25 +00:00
Andrew Ozz 9ecaba2688 Check if running from /src or SCRIPT_DEBUG is defined in `print_emoji_detection_script()`.
See #32118.
Built from https://develop.svn.wordpress.org/trunk@32482


git-svn-id: http://core.svn.wordpress.org/trunk@32452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-10 18:24:30 +00:00
Drew Jaynes 73892c112c Update the DocBlock description for `update_option()` to account for the ability to define the `$autoload` parameter, added in 4.2.
Props Clorith for the initial patch.
Fixes #32331.

Built from https://develop.svn.wordpress.org/trunk@32481


git-svn-id: http://core.svn.wordpress.org/trunk@32451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-10 16:58:27 +00:00
Andrew Ozz 999ae33a2e Widgets:
- Fix dragging to the bottom of the screen.
- Fix hiding of the dragged widget when dragging over a closed sidebar.
- Fix the admin menu position and scrolling when all widget containers are folded.
Fixes #32094 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32480


git-svn-id: http://core.svn.wordpress.org/trunk@32450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-10 00:32:31 +00:00
Drew Jaynes 59fe6b2368 Lightly clean up and improve inline documentation in wp-config-sample.php.
* Fixes some grammatical and wrapping issues in the file header, and breaks the contents list up into, well, a list.
* Adds a note and Codex link to the DocBlock for the `WP_DEBUG` constant definition on where to find more information about constants used for debugging.

Fixes #28551.

Built from https://develop.svn.wordpress.org/trunk@32479


git-svn-id: http://core.svn.wordpress.org/trunk@32449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-10 00:06:31 +00:00
Andrew Ozz 7ad60f3154 Emoji: do not try to replace emoji chars inside dynamic SVGs.
Fixes #32305 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32478


git-svn-id: http://core.svn.wordpress.org/trunk@32448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 23:44:27 +00:00
Dominik Schilling 60c9fdf9fd Merge similar error strings for invalid data.
props pavelevap.
fixes #32329.
Built from https://develop.svn.wordpress.org/trunk@32477


git-svn-id: http://core.svn.wordpress.org/trunk@32447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 21:09:25 +00:00
Dominik Schilling 42cd948544 Improve focus styles for:
* Quick Draft links
* Media Library list mode thumbnails 

props afercia.
fixes #32284, #32291.
Built from https://develop.svn.wordpress.org/trunk@32476


git-svn-id: http://core.svn.wordpress.org/trunk@32446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 21:05:25 +00:00
Dominik Schilling bbcdcc084d Improve focus styles for:
* Welcome Panel dismiss link
* Welcome Panel assembled links
* At a Glance links
* Recently Published/Publishing Soon and latest Comments links in the Dashboard Activity box 

props afercia.
fixes #32287, #32288, #32289, #32292.
Built from https://develop.svn.wordpress.org/trunk@32475


git-svn-id: http://core.svn.wordpress.org/trunk@32445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 20:35:27 +00:00
Dominik Schilling e44d2f7289 Merge a help tab string for pages.
fixes #32328.
Built from https://develop.svn.wordpress.org/trunk@32474


git-svn-id: http://core.svn.wordpress.org/trunk@32444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 20:07:26 +00:00
Dominik Schilling f9e1c18698 List Table: Add placeholder to a plural string.
props SergeyBiryukov.
fixes #32034.
Built from https://develop.svn.wordpress.org/trunk@32473


git-svn-id: http://core.svn.wordpress.org/trunk@32443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 19:22:24 +00:00
Dominik Schilling 5268a77a80 Sites List Table: Replace context with a translators comment for the site name and tagline.
props ramiy.
fixes #31849.
Built from https://develop.svn.wordpress.org/trunk@32472


git-svn-id: http://core.svn.wordpress.org/trunk@32442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 19:18:27 +00:00
Dominik Schilling c37bdc3c9e Merge similar error strings.
props pavelevap.
fixes #32327.
Built from https://develop.svn.wordpress.org/trunk@32471


git-svn-id: http://core.svn.wordpress.org/trunk@32441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 18:27:26 +00:00
Scott Taylor a6428fe295 In `fetch_feed()`, call `->set_output_encoding()` on the `SimplePie` instance to ensure the feed is served with encoding specified by the `blog_charset` option.
Props chriscct7.
Fixes #10713.

Built from https://develop.svn.wordpress.org/trunk@32469


git-svn-id: http://core.svn.wordpress.org/trunk@32439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 06:49:24 +00:00
Scott Taylor 3ec1d3bf9d Serve RSS feeds with the proper mime-type: `application/rss+xml`. The reason for hacking around browsers by using `text/xml` appears to no longer be relevant.
Props @chriscct7.
Reverts [11334] and [11358]
Fixes #15110.

Built from https://develop.svn.wordpress.org/trunk@32468


git-svn-id: http://core.svn.wordpress.org/trunk@32438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 06:39:24 +00:00
Scott Taylor 2251a28f1d In `media-template.php`, change a few `<a href="#" class="button">`s to `<button type="button" class="button" ...>`.
See #26550.

Built from https://develop.svn.wordpress.org/trunk@32467


git-svn-id: http://core.svn.wordpress.org/trunk@32437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 06:07:25 +00:00
Scott Taylor 4af6d6f305 Media Grid: clean up our flawed `Backbone.Router` implementation so that the browser forward/back buttons work the same way as the left/right keys when the Edit Attachment frame is open.
Fixes #31846.

Built from https://develop.svn.wordpress.org/trunk@32466


git-svn-id: http://core.svn.wordpress.org/trunk@32436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 05:42:28 +00:00
John Blackbourn bb02256966 Introduce a `$token` argument to `wp_set_auth_cookie()` so session tokens can be reused by custom authentication implementations.
Props rmccue

Fixes 30247

Built from https://develop.svn.wordpress.org/trunk@32465


git-svn-id: http://core.svn.wordpress.org/trunk@32435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-09 00:28:27 +00:00
Scott Taylor 2c42a665a2 `wp.media.view.Button` should create `<button>`s, not `<a href="#">`s.
Props afercia.
See #32236.

Built from https://develop.svn.wordpress.org/trunk@32464


git-svn-id: http://core.svn.wordpress.org/trunk@32434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 20:39:27 +00:00
Scott Taylor a417b2cf1a In `EmbedLink`, a URL needs to be at least 11 chars to be useful.
Fixes #32059.

Built from https://develop.svn.wordpress.org/trunk@32463


git-svn-id: http://core.svn.wordpress.org/trunk@32433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 20:30:26 +00:00
Scott Taylor b7d4685f3d When creating an `EmbedLink` view, don't add a spinner - it already exists in `Embed`.
Use the value of `wp.media.controller.Embed.sensitivity` as the sensitivity value for the debounced method in `EmbedLink` to ensure that the spinner toggles don't stutter or overlap.

Fixes #32036.

Built from https://develop.svn.wordpress.org/trunk@32462


git-svn-id: http://core.svn.wordpress.org/trunk@32432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 20:10:26 +00:00
Boone Gorges 3f642ba717 Use table prefix for `comment__in` and `comment__not_in` SQL clauses of `WP_Comment_Query`.
The prefix prevents ambiguity when joining against other tables.

Props willgladstone.
Fixes #32081.
Built from https://develop.svn.wordpress.org/trunk@32461


git-svn-id: http://core.svn.wordpress.org/trunk@32431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-08 19:45:26 +00:00