Andrea Fercia
6b449abadc
Accessibility: bump headings one level up on the Appearance > Widgets screen for a better headings hierarchy.
...
Props mrahmadawais, afercia.
Fixes #33659 .
Built from https://develop.svn.wordpress.org/trunk@35015
git-svn-id: http://core.svn.wordpress.org/trunk@34980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-10 16:34:25 +00:00
Drew Jaynes
aa6fbdaa92
Docs: Add a missing DocBlock summary for `wp_list_widget_controls_dynamic_sidebar()`.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@34827
git-svn-id: http://core.svn.wordpress.org/trunk@34792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-05 03:06:24 +00:00
Weston Ruter
208330f2dc
Customizer: Defer embedding widget controls to improve DOM performance and initial load time.
...
The Menu Customizer feature includes a performance technique whereby the controls for nav menu items are only embedded into the DOM once the containing menu section is expanded. This commit implements the same DOM deferral for widgets but goes a step further than just embedding the controls once the widget area's Customizer section is expanded: it also defers the embedding of the widget control's form until the widget is expanded, at which point the `widget-added` event also fires to allow any additional widget initialization to be done. The deferred DOM embedding can speed up initial load time by 10x or more. This DOM deferral also yields a reduction in overall memory usage in the browser process.
Includes changes to `wp_widget_control()` to facilitate separating out the widget form from the surrounding accordion container; also includes unit tests for this previously-untested function. Also included are initial QUnit tests (finally) for widgets in the Customizer.
Fixes #33901 .
Built from https://develop.svn.wordpress.org/trunk@34563
git-svn-id: http://core.svn.wordpress.org/trunk@34527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 21:02:27 +00:00
Scott Taylor
f8d7a43920
Move `wp_widgets_access_body_class()` (a hook callback) from `wp-admin/widgets.php` to `wp-admin/includes/widgets.php`.
...
See #33813 .
Built from https://develop.svn.wordpress.org/trunk@34017
git-svn-id: http://core.svn.wordpress.org/trunk@33986 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 21:22:23 +00:00
Sergey Biryukov
a3f82f92f1
Widgets: Don't display sidebar description container if it's empty.
...
Props paulwilde.
Fixes #32448 .
Built from https://develop.svn.wordpress.org/trunk@33934
git-svn-id: http://core.svn.wordpress.org/trunk@33903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-06 07:59:24 +00:00
Sergey Biryukov
4b5ef333a0
Correct the docblock for `wp_list_widget_controls()`.
...
Props swissspidy.
Fixes #33751 .
Built from https://develop.svn.wordpress.org/trunk@33930
git-svn-id: http://core.svn.wordpress.org/trunk@33899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-05 23:38:25 +00:00
Scott Taylor
c6a4512b1b
Add missing doc blocks to `wp-admin/includes/*`.
...
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32654
git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 20:17:26 +00:00
Scott Taylor
19a3aacc94
Add `@static*` annotations where they are missing.
...
Initialize all static vars that are not, most to `null`.
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32650
git-svn-id: http://core.svn.wordpress.org/trunk@32620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-29 15:43:29 +00:00
Scott Taylor
b56b9b3e5c
Add `@global` annotations for `wp-admin/*`.
...
See #32444 .
Built from https://develop.svn.wordpress.org/trunk@32642
git-svn-id: http://core.svn.wordpress.org/trunk@32612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-28 21:41:30 +00:00
Scott Taylor
7f8b548df1
In HTML5, the `action` attribute is no longer required. Remove this attribute when empty.
...
The admin HTML is served with the HTML5 doctype.
"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces."
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action
Props voldemortensen.
Fixes #30126 .
Built from https://develop.svn.wordpress.org/trunk@31200
git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 04:16:24 +00:00
Drew Jaynes
097dc8ee15
Fix syntax for single- and multi-line comments in wp-admin-directory files.
...
See #28931 .
Built from https://develop.svn.wordpress.org/trunk@29206
git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Scott Taylor
2f513d3320
Fix some `hackificator` odds and ends in `wp-admin`:
...
* `wp-activate.php` and `wp-admin/themes.php` don't need the closing PHP tag
* Switch single quotes for HTML attribute values to double in a few places
* Convert `include_once file.php` syntax to `include_once( 'file.php' )`
* Add access modifiers to methods/members in: `_WP_List_Table_Compat`, `Walker_Nav_Menu_Edit`, `Walker_Nav_Menu_Checklist`, `WP_Screen`, `Walker_Category_Checklist`
* `edit_user()` doesn't need to import the `$wpdb` global
* `wp_list_widgets()` doesn't need to import the `$sidebars_widgets` global
* switch/endswitch syntax is not supported in Hack
* A `<ul>` in `wp-admin/users.php` is unclosed
See #27881 .
Built from https://develop.svn.wordpress.org/trunk@28500
git-svn-id: http://core.svn.wordpress.org/trunk@28326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 05:04:16 +00:00
Sergey Biryukov
e7467f9b44
Remove temporary hooks added in [26865].
...
fixes #26661 .
Built from https://develop.svn.wordpress.org/trunk@27324
git-svn-id: http://core.svn.wordpress.org/trunk@27176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-28 00:45:16 +00:00
Sergey Biryukov
cce9d251a4
Add comments for temporary hooks. see #26661 .
...
Built from https://develop.svn.wordpress.org/trunk@26866
git-svn-id: http://core.svn.wordpress.org/trunk@26752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-23 00:48:11 +00:00
Sergey Biryukov
507b595c2b
Add temporary hooks for the widgets feature team to wp_widget_control().
...
props westonruter.
see #26661 .
Built from https://develop.svn.wordpress.org/trunk@26865
git-svn-id: http://core.svn.wordpress.org/trunk@26751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-23 00:45:11 +00:00
Matt Thomas
baefdf5bf8
Revert r26593 so Available and Inactive widgets are once again collapsible. Make the arrows only appear on hover when uncollapsed. Fixes #26327 , props nacin.
...
Built from https://develop.svn.wordpress.org/trunk@26608
git-svn-id: http://core.svn.wordpress.org/trunk@26498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 16:31:10 +00:00
Matt Thomas
26a22db98e
Set Available and Inactive Widget areas to not collapse, since they don't look like collapsing elements. Fixes #26327 , props MikeHansenMe.
...
Built from https://develop.svn.wordpress.org/trunk@26593
git-svn-id: http://core.svn.wordpress.org/trunk@26483 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 21:32:10 +00:00
Andrew Ozz
f46e743343
Widgets: drop onto closed sidebars.
...
- Make dropping a widget easier by preventing the source sidebar from resizing while the widget is being dragged.
- Move widgets dropped on closed sidebars to the top. UI Sortable places them randomly near the bottom.
- Fix possible regression in wp_list_widget_controls(), add an optional argument to output the sidebar name inside the sortable container.
- Updated styles for sidebar description and widget-hover class.
Part props shaunandrews, fixes #25952 .
Built from https://develop.svn.wordpress.org/trunk@26426
git-svn-id: http://core.svn.wordpress.org/trunk@26326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-27 01:30:10 +00:00
Matt Thomas
87ce6cc5c3
Bring in the widgets component of MP6. See #25858 .
...
* A cleaner UI, with a simpler design for available and inactive widgets, and more emphasis on your sidebars.
* Available widgets and sidebars expand to two columns at larger screen sizes making it easier to manage sites with lots of sidebars.
* New dropzone indicator for empty sidebars.
Props shaunandrews, joen, iammattthomas.
Built from https://develop.svn.wordpress.org/trunk@26140
git-svn-id: http://core.svn.wordpress.org/trunk@26051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 20:06:06 +00:00
Sergey Biryukov
74638ccb5a
Fix typos in phpdoc. props TheLastCicada. fixes #24302 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@24229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-10 01:39:30 +00:00
Andrew Nacin
9e2d46819e
Revert [22387]. see #14466 . see #22374 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 22:36:24 +00:00
Andrew Nacin
bc93c0fdc5
Prefix sidebar IDs on the widgets screen with "sidebar-". props batmoo. fixes #14466 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-05 23:17:25 +00:00
Andrew Nacin
1acd8b556f
New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
...
Be on the lookout for weirdness.
props lessbloat. see #21456 .
git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin
c1b0670c2d
Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 19:34:23 +00:00
azaozz
99496fb30c
Widgets: add localization context for 'Add' and 'Edit', props nacin, fixes #21338
...
git-svn-id: http://core.svn.wordpress.org/trunk@21356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-27 03:56:27 +00:00
azaozz
93979aa0ef
Widgets: Add the name of the widget to the Add and Edit buttons on the Accessible Widget Management Screen, props cannona, fixes #21338
...
git-svn-id: http://core.svn.wordpress.org/trunk@21355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-27 03:33:38 +00:00
ryan
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
duck_
c1d1590171
Fix typos in documentation (wp-admin/). See #18560 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 14:18:10 +00:00
ryan
8192d0dae8
Validation fixes. Props ocean90, peaceablewhale. see #17364
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-23 23:33:30 +00:00
ryan
3f72e340d6
Update since phpdoc. Props demetris. fixes #15445
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 19:24:38 +00:00
scribu
03dd41a0d2
Improve hook readability via curly brackets. Props jjj for initial patch. Fixes #15422
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-14 15:50:02 +00:00
nacin
5f4a583fb1
Remove more create_function calls. props huichen, see #14424 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-11 22:50:36 +00:00
nacin
5560332a2c
Update phpdoc for wp_list_widgets(). fixes #15373 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-10 12:28:03 +00:00
markjaquith
fc6e89da45
Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 21:56:43 +00:00
ryan
172aa06718
Revert [14347] and [14372]. It broke more than we expected. Try again in 3.1. see #13051
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-03 18:16:22 +00:00
ryan
91354eefee
Escape links by default. Props alexkingorg. see #13051
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@14347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-02 22:53:59 +00:00
nacin
00706d68ce
Use admin_url() for images in wp-admin, to allow for filtering. Props mdawaffe, see #12300
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@13256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-02-20 21:09:49 +00:00
ryan
6da55f7792
Trailing whitespace cleanup
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@12733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-15 22:11:12 +00:00
markjaquith
14f6764df9
Change 'Remove' link on widgets to 'Delete' because it doesn't just remove it, it deletes the settings for that widget instance. props Denis-de-Bernardy. fixes #10379
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@12360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-10 08:51:36 +00:00
azaozz
c3f7df6b24
Fix notices and phpdoc, props hakre, fixes #10758
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@12284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-11-26 11:29:54 +00:00
azaozz
f2dc806c22
Add sidebar descriptions to sidebar settings and widget admin screen, props jeremyclarke scribu, fixes #11157
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@12213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-11-19 09:12:16 +00:00
azaozz
fe813ce063
Do not reuse deleted widget instances IDs, fixes #10092 for trunk
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-06-15 23:57:52 +00:00
azaozz
84ff783414
Using css to hide the Save button in widgets without settings, props Denis-de-Bernardy, fixes #10020
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11516 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-06-04 00:52:31 +00:00
azaozz
b7bc0faa73
Reload the widget form with the ajax response after save, add Close link to the widgets, don't auto-close on save to show possible errors returned from validation
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11498 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-31 11:34:08 +00:00
azaozz
13c7249671
Delete widgets when dragged back to Available Widgets, add ui.droppable.js and ui.selectable.js, see #9511
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-24 15:46:09 +00:00
markjaquith
3ebf837ced
Deprecate sanitize_url() and clean_url() in favor of esc_url_raw() and esc_url()
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-18 16:00:33 +00:00
markjaquith
119b39cec2
deprecate wp_specialchars() in favor of esc_html(). Encode quotes for esc_html() as in esc_attr(), to improve plugin security.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-18 15:11:07 +00:00
azaozz
12be75ed58
Fix notice in wp-admin/includes/widgets.php
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-12 19:12:50 +00:00
azaozz
aea091d87d
Sort widgets by name case insensitive, fixes #9766
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-10 06:56:27 +00:00
azaozz
ad6e4d1a41
Append the widget's title to the header, adjust sidebar height after changing widgets, see #9511
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@11246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-10 00:49:48 +00:00