Commit Graph

17186 Commits

Author SHA1 Message Date
Sergey Biryukov d5a6a1ab44 Taxonomy: Use a consistent check for the `$rewrite['hierarchical']` parameter.
This avoids a "Trying to access array offset on value of type bool" PHP warning in `get_term_link()` if the `$rewrite` parameter of `register_taxonomy()` is set as `false`.

Props Tkama, SergeyBiryukov.
Fixes #52882.
Built from https://develop.svn.wordpress.org/trunk@50565


git-svn-id: http://core.svn.wordpress.org/trunk@50178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-23 13:55:03 +00:00
gziolo 3bd08d3bd4 Editor: Add new theme category for block types
Related: https://github.com/WordPress/gutenberg/pull/30020.

Introduces a new "theme" category to the default set to use with template-parts and other FSE blocks.

Props matveb.
Fixes #52883. 


Built from https://develop.svn.wordpress.org/trunk@50564


git-svn-id: http://core.svn.wordpress.org/trunk@50177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-23 09:02:06 +00:00
Sergey Biryukov 0ee244739a Code Modernization: Correct expected data type for `WP_User_Search::$page` property.
This fixes erroneous parentheses placement and applies the type cast to the variable it was intended for.

Follow-up to [3864].

Props hellofromTonya, jrf, xknown.
See #51423.
Built from https://develop.svn.wordpress.org/trunk@50563


git-svn-id: http://core.svn.wordpress.org/trunk@50176 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-22 22:42:04 +00:00
Sergey Biryukov 63fba77ec7 Docs: Fix typo in `pre_term_link` filter description.
See #52628.
Built from https://develop.svn.wordpress.org/trunk@50562


git-svn-id: http://core.svn.wordpress.org/trunk@50175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-22 19:19:09 +00:00
Sergey Biryukov 590d59e92f Coding Standards: Move some translator comments to the correct place.
Follow-up to [48172].

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50561


git-svn-id: http://core.svn.wordpress.org/trunk@50174 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 13:13:03 +00:00
Sergey Biryukov a885f914e4 Coding Standards: Add missing semicolon to some `endif` keywords.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50560


git-svn-id: http://core.svn.wordpress.org/trunk@50173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 13:05:04 +00:00
Sergey Biryukov 63191bd646 Tests: Move the `get_current_commenter()` method next to the test it's used in.
Follow-up to [48133].

See #52625.
Built from https://develop.svn.wordpress.org/trunk@50559


git-svn-id: http://core.svn.wordpress.org/trunk@50172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 12:55:04 +00:00
Sergey Biryukov 5e10227d76 Coding Standards: Use strict comparison for return type checks in a few functions:
* `get_bookmark()`
* `get_comment()`
* `get_post()`
* `get_children()`
* `wp_get_recent_posts()`
* `wp_get_post_revision()`
* `wp_get_nav_menu_items()`

Follow-up to [45710] for `get_term()`, [48507] for `wpdb::get_row()` and `wpdb::get_results()`.

See #52627.
Built from https://develop.svn.wordpress.org/trunk@50558


git-svn-id: http://core.svn.wordpress.org/trunk@50171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 12:41:04 +00:00
Sergey Biryukov d72f4e0e48 Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-upgrader.php`.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50557


git-svn-id: http://core.svn.wordpress.org/trunk@50170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-21 12:12:07 +00:00
Sergey Biryukov d3d78e755b Coding Standards: Add a space before `/` character in some self-closing HTML tags.
While this has no effect on the code, it fixes a minor inconsistency with the rest of core.

Props laxman-prajapati.
Fixes #52870.
Built from https://develop.svn.wordpress.org/trunk@50556


git-svn-id: http://core.svn.wordpress.org/trunk@50169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-20 18:30:08 +00:00
Sergey Biryukov 643888dfc6 I18N: Update list of continents and cities for the timezone selection.
Props wangql, mukesh27.
Fixes #52861.
Built from https://develop.svn.wordpress.org/trunk@50555


git-svn-id: http://core.svn.wordpress.org/trunk@50168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 15:42:04 +00:00
Sergey Biryukov b4c09beba8 I18N: Remove duplicate entries from the list of continents and cities.
Follow-up to [37554].

See #52861.
Built from https://develop.svn.wordpress.org/trunk@50554


git-svn-id: http://core.svn.wordpress.org/trunk@50167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 15:21:08 +00:00
whyisjake 471fc1e913 Media: Pass the appropriate reference into `wp_getimagesize`.
With changes that were introduced in [49889] the second parameter for getimagesize() function is expecting a a reference.

Previously, most calls did not pass the 2nd param, and as a result, we are getting unexpected results.

This was only a problem with applications that are using a custom stream wrapper, and the image contained EXIF data.

For more see:

* https://github.com/humanmade/S3-Uploads/issues/496
* https://github.com/aws/aws-sdk-php/issues/1923

Fixes #52826.
Props terriann, SergeyBiryukov, Mista-Flo, hellofromTonya, rinatkhaziev, whyisjake.


Built from https://develop.svn.wordpress.org/trunk@50552


git-svn-id: http://core.svn.wordpress.org/trunk@50165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-19 00:01:03 +00:00
ryelle 3363e22f80 Pointers: Make pointer border darker to match arrow tip.
Props johnjamesjacoby, melchoyce, SergeyBiryukov.
Fixes #52670.


Built from https://develop.svn.wordpress.org/trunk@50551


git-svn-id: http://core.svn.wordpress.org/trunk@50164 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 23:26:05 +00:00
Peter Wilson c7fac4a9ea External libraries: Update generated script loader version hashes.
Update the generated file `src/wp-includes/assets/script-loader-packages.php` following the clipboard.js update in [50544].

See #52850.

Built from https://develop.svn.wordpress.org/trunk@50550


git-svn-id: http://core.svn.wordpress.org/trunk@50163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 22:45:04 +00:00
ryelle 0bfb5f043b Administration: Make focus states consistent in admin menu when collapsed.
When collapsed or on a small screen, these styles would override the color schemes, causing a dark background to appear regardless of the color scheme's settings. This change also uses `focus-within` to show or hide the menu item's arrow, consistent with how the arrow behaves on hover.

Props afercia, Bueltge.
Fixes #32579.


Built from https://develop.svn.wordpress.org/trunk@50549


git-svn-id: http://core.svn.wordpress.org/trunk@50162 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 21:44:09 +00:00
desrosj 707b80c194 Emoji: Update the Twemoji library to version 13.0.2.
This point release does not add any new Emoji and only slightly modifies 14 existing Emoji without changing their meanings.

Because of this, the same CDN location (currently `/images/core/emoji/13.0.1`) can be updated with the new versions and sites running WordPress 5.6 or higher will start using the updated versions once their cache expires.

See #52852.
Built from https://develop.svn.wordpress.org/trunk@50548


git-svn-id: http://core.svn.wordpress.org/trunk@50161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 19:20:19 +00:00
Sergey Biryukov 87db5b833d External Libraries: Further fix jQuery deprecations in WordPress core.
Follow-up to [50001], [50270], [50367], [50383], [50410], [50420], [50429].

Props Clorith.
See #51812.
Built from https://develop.svn.wordpress.org/trunk@50547


git-svn-id: http://core.svn.wordpress.org/trunk@50160 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 19:01:03 +00:00
desrosj cd3e85fe23 External Libraries: Update the jQuery Form library.
This updates the `jquery-form` library from version `4.2.1` to `4.3.0`.

A full list of changes can be found on GitHub: https://github.com/jquery-form/form/compare/v4.2.1...v4.3.0.

Fixes #52685.
Built from https://develop.svn.wordpress.org/trunk@50546


git-svn-id: http://core.svn.wordpress.org/trunk@50159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 17:53:19 +00:00
desrosj 235b19b3b0 Build/Test Tools: Update some `devDependencies`.
This updates a handful of dependencies to their latest versions.

- `qunit` from `2.14.0` to `2.14.1`.
- `uglify-js` from `3.13.0` to `3.13.1`.
- `wait-on` from `5.2.1` to `5.3.0`.

See #52624.
Built from https://develop.svn.wordpress.org/trunk@50545


git-svn-id: http://core.svn.wordpress.org/trunk@50158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 17:48:23 +00:00
desrosj 456973fa26 External Libraries: Update Clipboard.js library to version `2.0.8`.
This updates the `clipboard` library from version `2.0.6` to `2.0.8`.

A full list of changes can be found on GitHub: https://github.com/zenorocha/clipboard.js/compare/v2.0.6...v2.0.8.

Fixes #52850.
Built from https://develop.svn.wordpress.org/trunk@50544


git-svn-id: http://core.svn.wordpress.org/trunk@50157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 15:54:18 +00:00
desrosj 3a92b15f93 External Libraries: Update jQuery Color library to version `2.2.0`.
This updates the `jquery-color` library from version `2.1.2` to `2.2.0`.

This also switches back to installing the dependency from NPM instead of GitHub. The maintainers have resumed publishing to NPM with the 2.2.0 release.

A full list of changes can be found on GitHub: https://github.com/jquery/jquery-color/compare/2.1.2...2.2.0.

Props hareesh-pillai, desrosj.
Fixes #51405.
Built from https://develop.svn.wordpress.org/trunk@50543


git-svn-id: http://core.svn.wordpress.org/trunk@50156 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 15:50:18 +00:00
desrosj 0baa695906 Build/Test Tools: Revert [50540].
The E2E workflow is failing after this change. Reverting to to investigate further.

Unprops desrosj.
See #52843.
Built from https://develop.svn.wordpress.org/trunk@50542


git-svn-id: http://core.svn.wordpress.org/trunk@50155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 14:35:22 +00:00
Sergey Biryukov bf29bb4441 Coding Standards: Use strict comparison for JS fragment in some admin files.
Follow-up to [48083].

Props nayanchamp7, rnaby.
Fixes #52845, #41988.
Built from https://develop.svn.wordpress.org/trunk@50541


git-svn-id: http://core.svn.wordpress.org/trunk@50154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 14:13:08 +00:00
desrosj 357e77789c Build/Test Tools: Remove explicit puppeteer dependency.
This was added in [48177] to fix an issue where Puppeteer was not being installed correctly as a dependency of `@wordpress/wp-scripts`. This has been fixed, so this explicit dependency can be removed.

Props isabel_brison.
Fixes #52843.
Built from https://develop.svn.wordpress.org/trunk@50540


git-svn-id: http://core.svn.wordpress.org/trunk@50153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-18 12:44:23 +00:00
Sergey Biryukov 6ad5c0c553 Docs: Correct formatting for the description of some `register_post_type()` parameters.
Props audrasjb.
Fixes #52836.
Built from https://develop.svn.wordpress.org/trunk@50538


git-svn-id: http://core.svn.wordpress.org/trunk@50151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-17 17:33:10 +00:00
Sergey Biryukov 4d514bb6ad Tests: Correct some newly introduced `@covers` tags.
Follow-up to [50289], [50344].

Props jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50537


git-svn-id: http://core.svn.wordpress.org/trunk@50150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-16 18:46:07 +00:00
ryelle 5d983ec85b Help/About: Run image comparison script after all assets have loaded.
If the callback is called before the images are loaded, the comparison doesn't work. `wp.domReady` uses `DOMContentLoaded`, which does not guarantee that the images are loaded. This switches to use the `load` event, which waits for all resources to load.

Props vladytimy, joyously, sergeybiryukov.
Fixes #52758.


Built from https://develop.svn.wordpress.org/trunk@50535


git-svn-id: http://core.svn.wordpress.org/trunk@50148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-15 19:51:09 +00:00
Sergey Biryukov f9cc35ebad Twenty Seventeen: Remove extra space around post editor.
The editor uses the full height of its container, so the added margins cause the visual editor to break out of the container. This removes the top & bottom margins, and makes the left & right margins consistent with the meta box area.

Follow-up to [50465].

Props joseeyoast, audrasjb.
Fixes #52816.
Built from https://develop.svn.wordpress.org/trunk@50534


git-svn-id: http://core.svn.wordpress.org/trunk@50147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-15 13:26:06 +00:00
Sergey Biryukov 7720afe9a7 Coding Standards: Remove some extra whitespace in `sanitize_comment_cookies()`.
See #52627.
Built from https://develop.svn.wordpress.org/trunk@50533


git-svn-id: http://core.svn.wordpress.org/trunk@50146 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-14 17:01:12 +00:00
Sergey Biryukov dc68fb8278 Docs: Synchronize `$category_name` description in `WP_Block_Pattern_Categories_Registry` methods.
Follow-up to [48156].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@50532


git-svn-id: http://core.svn.wordpress.org/trunk@50145 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-13 11:17:03 +00:00
Sergey Biryukov 0a3794a0de Docs: Correct DocBlock formatting for `register_block_style_handle()`.
Follow-up to [48141].

See #52628.
Built from https://develop.svn.wordpress.org/trunk@50531


git-svn-id: http://core.svn.wordpress.org/trunk@50144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-13 11:15:04 +00:00
Sergey Biryukov 3f03bb352e Site Health: Use a singular string in dashboard widget if there is only one critical issue or recommendation.
Props Presskopp, hareesh-pillai.
Fixes #52521.
Built from https://develop.svn.wordpress.org/trunk@50530


git-svn-id: http://core.svn.wordpress.org/trunk@50143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-13 10:59:02 +00:00
Sergey Biryukov cb55990e50 Docs: Add missing `@since` tags for `item_link` and `item_link_description` post type and taxonomy labels.
Follow-up to [50527].

See #52688.
Built from https://develop.svn.wordpress.org/trunk@50529


git-svn-id: http://core.svn.wordpress.org/trunk@50142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-13 10:25:06 +00:00
davidbaumwald fb8c18e541 Docs: Correct `unregister_block_style` @param for `$block_name`.
In `unregister_block_style`, the `$block_name` parameter was documented as an array.  This change corrects the type to `string`, as that's what is expected in `WP_Block_Styles_Registry->unregister`. 

Props kraftner.
Fixes #52795.
Built from https://develop.svn.wordpress.org/trunk@50528


git-svn-id: http://core.svn.wordpress.org/trunk@50141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-12 20:05:08 +00:00
gziolo f27c179afc Editor: Make block type aware of variations
Currently block variations are only defined on the client. In some cases, creating block variations on the server can be very useful, especially when needed data is not exposed in the REST APIs.

Related to https://github.com/WordPress/gutenberg/pull/29095.

Props: gwwar, timothyblynjacobs.
Fixes: #52688.


Built from https://develop.svn.wordpress.org/trunk@50527


git-svn-id: http://core.svn.wordpress.org/trunk@50140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-12 13:35:09 +00:00
Sergey Biryukov 96377c956f Accessibility: Administration: Use a darker color for post dates in the Activity and Quick Draft dashboard widgets.
This ensures that the color meets the WCAG 2.0 AA recommended contrast ratio.

Follow-up to [50025].

Props sabernhardt, Otshelnik-Fm, audrasjb.
Fixes #52760.
Built from https://develop.svn.wordpress.org/trunk@50525


git-svn-id: http://core.svn.wordpress.org/trunk@50138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-12 12:06:13 +00:00
ryelle 9808fad416 Help/About: Use absolute URLs for inline images on About pages.
This ensures the images are loaded correctly from both single site and network About pages.

Props TobiasBg, audrasjb.
Fixes #52743.


Built from https://develop.svn.wordpress.org/trunk@50523


git-svn-id: http://core.svn.wordpress.org/trunk@50136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-11 21:38:08 +00:00
Sergey Biryukov 88df1ef431 Coding Standards: Consistently format `opendir()` calls in `get_plugins()`.
Props sabernhardt, subrataemfluence.
Fixes #44250.
Built from https://develop.svn.wordpress.org/trunk@50522


git-svn-id: http://core.svn.wordpress.org/trunk@50135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-11 15:19:08 +00:00
desrosj efaa79d347 External Libraries: Update jQuery hoverIntent to version 1.10.1.
This updates the `jquery-hoverintent` dependency from 1.8.3 to 1.10.1.

For a full list of changes, see https://github.com/briancherne/jquery-hoverIntent/compare/v1.8.3...v1.10.1.

Fixes #52686.
Built from https://develop.svn.wordpress.org/trunk@50521


git-svn-id: http://core.svn.wordpress.org/trunk@50134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-10 15:25:20 +00:00
desrosj de074081d1 External Libraries: Update jQuery to version 3.6.0.
This updates the jQuery dependency from 3.5.1 to 3.6.0.

For a full list of changes, see https://github.com/jquery/jquery/compare/3.5.1...3.6.0.

Fixes #52707. See #51812.
Built from https://develop.svn.wordpress.org/trunk@50520


git-svn-id: http://core.svn.wordpress.org/trunk@50133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-10 15:07:24 +00:00
Sergey Biryukov a292585ea4 Help/About: Correct the WebM video URL on About page.
Props mihdan, audrasjb.
Fixes #52756.
Built from https://develop.svn.wordpress.org/trunk@50518


git-svn-id: http://core.svn.wordpress.org/trunk@50131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-10 10:28:11 +00:00
Peter Wilson 0b75f9557e Docs: Improve spelling in [50516].
Props jeremyfelt.
See #52628, #34564.

Built from https://develop.svn.wordpress.org/trunk@50517


git-svn-id: http://core.svn.wordpress.org/trunk@50130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 23:22:06 +00:00
Peter Wilson fb1857def8 Docs: Improve compatibility comment in `WP_List_Table`.
Improve comment explaining backward compatibility check for the primary column in `WP_List_Table::get_column_info()`.

Unprops helen, markjaquith.
See #52628, #34564.


Built from https://develop.svn.wordpress.org/trunk@50516


git-svn-id: http://core.svn.wordpress.org/trunk@50129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 22:35:06 +00:00
Sergey Biryukov ebee7d0ab9 Classic Editor: Make sure word count is hidden if JavaScript is disabled.
Removing `display: block` from the element allows the `.hide-if-no-js` class to have the intended effect.

Follow-up to [34275].

Props sabernhardt, mukesh27.
Fixes #52662.
Built from https://develop.svn.wordpress.org/trunk@50512


git-svn-id: http://core.svn.wordpress.org/trunk@50125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-09 10:13:08 +00:00
desrosj a8b7cd17e0 Update `$_old_files` for 5.7.
Follow up to [50066].

See #52334.
Built from https://develop.svn.wordpress.org/trunk@50510


git-svn-id: http://core.svn.wordpress.org/trunk@50123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 18:30:07 +00:00
desrosj e2a19b5352 Bundled Themes: Bump theme version numbers for WordPres 5.7.
This updates all new default themes to new versions, which will be released shortly after WordPress 5.7. The new versions are:

- Twenty Twenty-One: 1.2
- Twenty Twenty: 1.7
- Twenty Nineteen: 2.0
- Twenty Seventeen: 2.6
- Twenty Sixteen: 2.4
- Twenty Fifteen: 2.9
- Twenty Fourteen: 3.1
- Twenty Thirteen: 3.3
- Twenty Twelve: 3.4
- Twenty Eleven: 3.7
- Twenty Ten: 3.3

Fixes #52704.
Built from https://develop.svn.wordpress.org/trunk@50507


git-svn-id: http://core.svn.wordpress.org/trunk@50120 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 14:17:08 +00:00
Sergey Biryukov fa5a9d5e92 Upgrade/Install: Display version number on the "Update now" button on WordPress Updates screen.
Additionally, adjust the "Update to latest nightly" button to include the major version number of the nightly build.

This makes the button labels more accurate and provides more clear understanding of what the update will be.

Follow-up to [49984].

Props afragen, pbiron, SergeyBiryukov.
Fixes #52513.
Built from https://develop.svn.wordpress.org/trunk@50506


git-svn-id: http://core.svn.wordpress.org/trunk@50119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-08 11:31:09 +00:00
John Blackbourn 52679edbff Docs: Add examples of possible names for various hooks whose name contains a dynamic portion.
This provides greater discoverability of such hooks in search results on the Code Reference site as well as increased clarity when reading the source.

See #50734, #52628

Built from https://develop.svn.wordpress.org/trunk@50505


git-svn-id: http://core.svn.wordpress.org/trunk@50118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-07 12:32:09 +00:00
Sergey Biryukov f4f826d74d Docs: Add a `@since` note to `wp_admin_bar_edit_menu()` about the "View Post" link on Comments screen for a single post.
Follow-up to [47903].

Props sabernhardt, janak007, munyagu.
Fixes #42366.
Built from https://develop.svn.wordpress.org/trunk@50504


git-svn-id: http://core.svn.wordpress.org/trunk@50117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-03-07 11:56:07 +00:00