Commit Graph

29611 Commits

Author SHA1 Message Date
Boone Gorges 5b9c7c412a Unit tests for `wpmu_validate_user_signup()`.
See #17904, #26784.
Built from https://develop.svn.wordpress.org/trunk@31970


git-svn-id: http://core.svn.wordpress.org/trunk@31949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 21:38:27 +00:00
Aaron Jorbin 786083fd8e Fix colors for activated and updated plugins
If we don't have the updated class on the TR for he update message, then the message is red and red is scary and they just updated, they should be happy and celebrating, not scared. 

See #31608



Built from https://develop.svn.wordpress.org/trunk@31969


git-svn-id: http://core.svn.wordpress.org/trunk@31948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 21:31:26 +00:00
Dominik Schilling 57fce2e593 Customizer Theme Switcher: Remove "Add New" references.
The current iteration takes you out of the customizer context, which isn't great UX and doesn't really fit into the flows targeted by this particular UI.

fixes #31837.
Built from https://develop.svn.wordpress.org/trunk@31968


git-svn-id: http://core.svn.wordpress.org/trunk@31947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 19:50:29 +00:00
Boone Gorges 481352bd2e Avoid the use of `array_replace()` in `add_query_arg()`.
`array_replace()` was introduced PHP 5.3+. Instead, we walk the array manually.

See [31966].

Fixes #31306.
Built from https://develop.svn.wordpress.org/trunk@31967


git-svn-id: http://core.svn.wordpress.org/trunk@31946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 19:40:26 +00:00
Scott Taylor c113cb5130 Respect numerical keys in `add_query_arg()`, use `array_replace()` instead of `array_merge()`.
Adds unit test.

Props tyxla.
Fixes #31306.

Built from https://develop.svn.wordpress.org/trunk@31966


git-svn-id: http://core.svn.wordpress.org/trunk@31945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 19:15:31 +00:00
Scott Taylor 8ec192ce1f Alter the regex in `wptexturize()` to properly handle input like: `<> "Hello world" <>`.
Updates unit test data.

Props miqrogroove.
Fixes #30344.

Built from https://develop.svn.wordpress.org/trunk@31965


git-svn-id: http://core.svn.wordpress.org/trunk@31944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 19:09:28 +00:00
Sergey Biryukov 66e483d3e7 When shifting `WP_Rewrite::flush_rules()` to a later action if it was called too early, make sure to do a hard flush if requested.
props Denis-de-Bernardy, mordauk for initial patch.
fixes #30501.
Built from https://develop.svn.wordpress.org/trunk@31964


git-svn-id: http://core.svn.wordpress.org/trunk@31943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 19:06:29 +00:00
Scott Taylor 0fccadaa35 When updating the email address for an existing user, make sure the email address is not already in use.
Adds unit tests.

Props rittesh.patel, DrewAPicture.
Fixes #30647.

Built from https://develop.svn.wordpress.org/trunk@31963


git-svn-id: http://core.svn.wordpress.org/trunk@31942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 18:23:28 +00:00
Sergey Biryukov d013c703e4 Merge title strings on Edit Site screens.
props ramiy.
fixes #31844.
Built from https://develop.svn.wordpress.org/trunk@31962


git-svn-id: http://core.svn.wordpress.org/trunk@31941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 18:00:28 +00:00
Sergey Biryukov 72bddcc1d5 Remove unused `printf()` on network setup screen.
props ramiy.
fixes #31841.
Built from https://develop.svn.wordpress.org/trunk@31961


git-svn-id: http://core.svn.wordpress.org/trunk@31940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 17:01:26 +00:00
Scott Taylor 3630732523 Remove the JS part of [31619].
Fixes #6820.

Built from https://develop.svn.wordpress.org/trunk@31960


git-svn-id: http://core.svn.wordpress.org/trunk@31939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 16:34:27 +00:00
Scott Taylor 62279ae07d In `WP_Posts_List_Table::get_views()`, don't add the `current` class to the `all` status link if `->user_posts_count` has a value, which triggers the additional `mine` status.
See [31828].
Fixes #24869.

Built from https://develop.svn.wordpress.org/trunk@31959


git-svn-id: http://core.svn.wordpress.org/trunk@31938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 16:17:28 +00:00
Scott Taylor 5855cb0e60 When editing an image from the editor, and the image has a value for alignment (but not for `width` or `caption`), don't bail without first checking that the alignment's value is not `alignnone`. If so, add the `class` to the `<a>` before bailing.
See #21848.

Built from https://develop.svn.wordpress.org/trunk@31958


git-svn-id: http://core.svn.wordpress.org/trunk@31937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 16:04:27 +00:00
Helen Hou-Sandí af79adbdd4 wpLink: Enable smooth scrolling on iOS devices.
fixes #31612.

Built from https://develop.svn.wordpress.org/trunk@31957


git-svn-id: http://core.svn.wordpress.org/trunk@31936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 15:34:26 +00:00
Sergey Biryukov 29cddbeda9 Add translator comments for placeholders in network-related strings.
props ramiy.
fixes #31834.
Built from https://develop.svn.wordpress.org/trunk@31956


git-svn-id: http://core.svn.wordpress.org/trunk@31935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 13:26:28 +00:00
Dominik Schilling a7ba89b027 Accessibility: Add landmark roles to WordPress admin areas.
props afercia, joedolson.
fixes #31450.
Built from https://develop.svn.wordpress.org/trunk@31955


git-svn-id: http://core.svn.wordpress.org/trunk@31934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 13:17:27 +00:00
Dominik Schilling 8ab7c076d6 Customizer Theme Switcher: Switch the details/live preview buttons.
props celloexpressions, ocean90.
fixes #31791.
Built from https://develop.svn.wordpress.org/trunk@31954


git-svn-id: http://core.svn.wordpress.org/trunk@31933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 12:36:26 +00:00
Gary Pendergast a3bbadbbea WPDB: Due to PHP 5.2's internal string handling, strings in Windows are encoded using UTF-16, instead of UTF-8. With the addition of the many character set tests in [30345], a couple of them were tripping up in PHP 5.2 under Windows, because of this behaviour.
This marks those tests as skipped.

See #31262 for more discussion.


Built from https://develop.svn.wordpress.org/trunk@31953


git-svn-id: http://core.svn.wordpress.org/trunk@31932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 12:34:27 +00:00
Dominik Schilling 43352a0759 Themes: Improve focus styling of add-new-theme link.
props celloexpressions, mrahmadawais.
fixes #31203.
Built from https://develop.svn.wordpress.org/trunk@31952


git-svn-id: http://core.svn.wordpress.org/trunk@31931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 12:22:27 +00:00
Sergey Biryukov 6a297b848a After [31941], use the decoupled strings from `WP_Customize_Manager::register_controls()` on the Menus screen.
see #28502.
Built from https://develop.svn.wordpress.org/trunk@31951


git-svn-id: http://core.svn.wordpress.org/trunk@31930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 11:37:26 +00:00
Dominik Schilling b95a8227d8 Customizer Theme Switcher: Fix invalid HTML markup when New Theme control is added.
see #31203.
Built from https://develop.svn.wordpress.org/trunk@31950


git-svn-id: http://core.svn.wordpress.org/trunk@31929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 11:35:26 +00:00
Aaron Jorbin 8f99fbeb8d Refine UI for FTP modal and shiny updates
Numerous changes to make the FTP modal experience a good one.  These include:
 * Update HTML used by both the form here and the form on the standalone screen
 * Allow users to cancel FTP install
 * Focus locking in the modal
 * Focus on modal form on load
 * ARIA Attributes
 * Style Enhancements
 * Add low screen height (such as phone and some tablets) friendly experience for entering credentials

Props ericlewis, afercia 
Fixes #31608


Built from https://develop.svn.wordpress.org/trunk@31949


git-svn-id: http://core.svn.wordpress.org/trunk@31928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 02:48:28 +00:00
Andrew Ozz e053979219 Emoji:
- Enhance twemoji.js to support passing of additional attributes for the replacement images.
- Use that to add the needed attributes when replacing emoji inside the editor.
Fixes #31627.
Built from https://develop.svn.wordpress.org/trunk@31948


git-svn-id: http://core.svn.wordpress.org/trunk@31927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 02:39:28 +00:00
Gary Pendergast 6a9d744b42 WPDB: When we check the character set of a column, and find that it's `utf8mb4`, we should also check that the current connection supports `utf8mb4`. It's possible that the environment may have changed since upgrading the DB, so we can fall back to `utf8` when that happens.
Fixes #31771.


Built from https://develop.svn.wordpress.org/trunk@31947


git-svn-id: http://core.svn.wordpress.org/trunk@31926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 02:22:31 +00:00
Andrew Ozz 5fe7be9757 TinyMCE emoji: fix caret position after replacing emoji in Chrome on Windows 8.
See #31627.
Built from https://develop.svn.wordpress.org/trunk@31946


git-svn-id: http://core.svn.wordpress.org/trunk@31925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 23:35:26 +00:00
Dominik Schilling d775c933c7 Disable body scrolling when session expired log in modal is open.
Fixes also the missing close icon if screen width is less than 380px.

props adamsilverstein, ocean90.
fixes #31610.
Built from https://develop.svn.wordpress.org/trunk@31945


git-svn-id: http://core.svn.wordpress.org/trunk@31924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 22:55:26 +00:00
Dominik Schilling 79a29b077e Customizer: Defer rendering theme controls until the section is displayed.
see #31793.
Built from https://develop.svn.wordpress.org/trunk@31944


git-svn-id: http://core.svn.wordpress.org/trunk@31923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 22:21:25 +00:00
Sergey Biryukov efb2740e88 Themes: Add a filter to short-circuit `wp_prepare_themes_for_js()`.
props mattwiebe, DrewAPicture.
fixes #31789.
Built from https://develop.svn.wordpress.org/trunk@31943


git-svn-id: http://core.svn.wordpress.org/trunk@31922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 20:04:25 +00:00
Sergey Biryukov 5fae37471a Media Library: Add a label for attachment type select in list mode.
props afercia.
fixes #31795.
Built from https://develop.svn.wordpress.org/trunk@31942


git-svn-id: http://core.svn.wordpress.org/trunk@31921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 19:57:26 +00:00
Sergey Biryukov 36643388ef Decouple strings where the singular and plural form are not just the same string with different numbers, but essentially two different strings.
This allows for using proper plural forms in languages with more than two forms, and also resolves string conflicts when the same string is present in both singular and plural form.

fixes #28502.
Built from https://develop.svn.wordpress.org/trunk@31941


git-svn-id: http://core.svn.wordpress.org/trunk@31920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 18:45:28 +00:00
Gary Pendergast 563344c643 Emoji: Fix a unit test which was incorrectly failing after [31926] fixed emoji being incorrectly encoded.
Built from https://develop.svn.wordpress.org/trunk@31940


git-svn-id: http://core.svn.wordpress.org/trunk@31919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 09:37:26 +00:00
Gary Pendergast 2a8a5c963a WPDB: When we're checking to see if the MySQL client library supports `utf8mb4`, we need a separate check for `mysqlnd` versions, which using different version numbering to `libmysqlclient`.
Props MattyRob.

Fixes #31644.


Built from https://develop.svn.wordpress.org/trunk@31939


git-svn-id: http://core.svn.wordpress.org/trunk@31918 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 09:18:27 +00:00
Gary Pendergast 486e80bdf5 Emoji: Change the emoji CDN to w.org, from wp.com.
See #31651.


Built from https://develop.svn.wordpress.org/trunk@31938


git-svn-id: http://core.svn.wordpress.org/trunk@31917 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 04:31:29 +00:00
Dion Hulse 47356fc7fc Tests: Clean up the resulting /tmp/foo* files from the `tempnam` call.
Built from https://develop.svn.wordpress.org/trunk@31937


git-svn-id: http://core.svn.wordpress.org/trunk@31916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 02:11:52 +00:00
Dion Hulse 7e1e32909e Add some logic into `wp_tempnam` to prevent it creating 'falsey' directory names that might get used elsewhere within WordPress.
Although this logic looks a little strange at this low level, it's the best location within the Upgrades code for it to happen.
Fixes #31811

Built from https://develop.svn.wordpress.org/trunk@31936


git-svn-id: http://core.svn.wordpress.org/trunk@31915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 02:11:26 +00:00
Scott Taylor a5478d7adb Let us pray to the gods of backwards compatibility:
* The way that the JS modules for media are currently set up turns the existing global `wp.media` namespace into a read-only API, this is bad.
* For the existing module implementation to work with plugins, those looking to override or extend a class would have to modify their own plugin to use `browserify` - we can't expect this to happen
* Because the general way that plugins override media classes is via machete (resetting them to something else), we cannot use `require( 'module' )` in the internal code for media modules

We CAN continue to use `require( 'fun/js' )` in the manifests for media. 

Future code/projects should carefully consider what is made to be public API. In 3.5, EVERYTHING was made public, so everything shall remain public.

See #31684, #28510.

Built from https://develop.svn.wordpress.org/trunk@31935


git-svn-id: http://core.svn.wordpress.org/trunk@31914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-31 02:03:29 +00:00
Lance Willett 57918dfc8f Twenty Fifteen: adjust scroll behavior to make sure sidebar height is calculated during scroll events, not just resize events.
Fixes #31734. Props jartes, lancewillett.
Built from https://develop.svn.wordpress.org/trunk@31934


git-svn-id: http://core.svn.wordpress.org/trunk@31913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 22:49:27 +00:00
Dominik Schilling 289db2d37b Customizer: Revert [31911]. We want to preserve `url` and `return` URL parameters to make the experience smoother.
see #31782.
Built from https://develop.svn.wordpress.org/trunk@31933


git-svn-id: http://core.svn.wordpress.org/trunk@31912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 19:22:26 +00:00
Lance Willett b8e58b3352 Twenty Thirteen: make sure submenu links work correctly on small screens with touch events.
Fixes #31762, props davidhamiltron.
Built from https://develop.svn.wordpress.org/trunk@31932


git-svn-id: http://core.svn.wordpress.org/trunk@31911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 19:20:27 +00:00
Andrew Ozz b5643f9a13 TinyMCE wpView: add back the removal of selected views on inserting new content. Was removed when reverting the first fix for embedding of pasted URLs.
Props mattheu. Fixes #31796.
Built from https://develop.svn.wordpress.org/trunk@31931


git-svn-id: http://core.svn.wordpress.org/trunk@31910 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 18:22:27 +00:00
Sergey Biryukov e70e4e74fa Press This: Use the error message returned by `wp_update_post()` instead of a generic one.
props stephdau.
fixes #31808.
Built from https://develop.svn.wordpress.org/trunk@31930


git-svn-id: http://core.svn.wordpress.org/trunk@31909 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 14:39:26 +00:00
Sergey Biryukov cd2e63700e Use a more specific selector for comment moderation hotkeys after [31513].
props afercia.
fixes #31545.
Built from https://develop.svn.wordpress.org/trunk@31929


git-svn-id: http://core.svn.wordpress.org/trunk@31908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 13:54:26 +00:00
Sergey Biryukov 43a99e0f1b Make sure the update button in "At a Glance" dashboard widget does not overlap with long strings.
props SergeyBiryukov, afercia, tyxla.
fixes #30766.
Built from https://develop.svn.wordpress.org/trunk@31928


git-svn-id: http://core.svn.wordpress.org/trunk@31907 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 12:50:29 +00:00
Sergey Biryukov a1dbd97adb Fix duplicate ID for Save Menu button on Menus screen.
props sagarjadhav.
fixes #31803.
Built from https://develop.svn.wordpress.org/trunk@31927


git-svn-id: http://core.svn.wordpress.org/trunk@31906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 09:49:26 +00:00
Gary Pendergast 3ddbef69e3 Emoji: When encoding emoji into HTML entities, 0 was being incorrectly trimmed from the right side of the hex string, causing some characters to be encoded incorrectly.
Built from https://develop.svn.wordpress.org/trunk@31926


git-svn-id: http://core.svn.wordpress.org/trunk@31905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:27:31 +00:00
Andrew Ozz 6cd9c9645e Press This: fix accessibility for the post options "sidebar". Fix size of the Add Category button.
Part props afercis, joedolson. Fixes #31575.
Built from https://develop.svn.wordpress.org/trunk@31925


git-svn-id: http://core.svn.wordpress.org/trunk@31904 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:09:51 +00:00
Gary Pendergast 31db5d08fe Emoji: When staticizing emoji into `<img>` tags, include an `alt` attribute of the original Emoji, to match both Smiley and Twemoji `<img>` tags.
Built from https://develop.svn.wordpress.org/trunk@31924


git-svn-id: http://core.svn.wordpress.org/trunk@31903 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 03:09:26 +00:00
Andrew Ozz 8ff664171d Remove unused vars. See #31627.
Built from https://develop.svn.wordpress.org/trunk@31923


git-svn-id: http://core.svn.wordpress.org/trunk@31902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 02:50:27 +00:00
Andrew Ozz f128f08c2c TinyMCE emoji: catch the inserting of emoji chars with the Windows 8 onscreen keyboard and replace if needed.
Fixes #31627.
Built from https://develop.svn.wordpress.org/trunk@31922


git-svn-id: http://core.svn.wordpress.org/trunk@31901 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 02:39:28 +00:00
Dominik Schilling 7bc60fed4a Customizer: Increase initial-scale viewport specification to 1.0.
see #31794, #28784.
Built from https://develop.svn.wordpress.org/trunk@31921


git-svn-id: http://core.svn.wordpress.org/trunk@31900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-29 12:23:27 +00:00