Sergey Biryukov
3e40f12574
Privacy: Remove unused `$wpdb` global in `WP_Privacy_Requests_Table::prepare_items()`.
...
Props david.binda.
Fixes #48178 .
Built from https://develop.svn.wordpress.org/trunk@46374
git-svn-id: http://core.svn.wordpress.org/trunk@46173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-02 23:22:58 +00:00
Andrea Fercia
4b939d5a93
Login and Registration: Hide the Edge browser "Reveal password" native button.
...
Props Clorith.
Fixes #42888 .
Built from https://develop.svn.wordpress.org/trunk@46372
git-svn-id: http://core.svn.wordpress.org/trunk@46171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-01 18:01:01 +00:00
Andrea Fercia
da00051294
Accessibility: Improve and modernize user interface controls for better contrast: Login screen improvements.
...
- allows the login input fields to better scale with text
- improves the input fields layout on Internet Explorer 11
- uses the new focus style on the "Show password" button
- adjusts the CSS for the interim login
See #47153 .
See #42888 .
Built from https://develop.svn.wordpress.org/trunk@46371
git-svn-id: http://core.svn.wordpress.org/trunk@46170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-01 15:55:57 +00:00
Sergey Biryukov
44c3cefb24
Docs: Fix typo in `wp_get_missing_image_subsizes()` DocBlock.
...
Props david.binda.
Fixes #48179 .
Built from https://develop.svn.wordpress.org/trunk@46368
git-svn-id: http://core.svn.wordpress.org/trunk@46167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-01 01:19:57 +00:00
Andrea Fercia
f86d225d26
Accessibility: Improve and modernize user interface controls: Improve new styles for the color picker.
...
Props audrasjb, garrett-eclipse.
Fixes #48131 .
Built from https://develop.svn.wordpress.org/trunk@46360
git-svn-id: http://core.svn.wordpress.org/trunk@46159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 18:05:59 +00:00
antpb
6531c237e7
Media: Prevents clipping of text when scaling image edit screen.
...
This reapplies [46354] clean as the previous commit had remnants of an unrelated patch.
Props sabernhardt, audrasjb, afercia.
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46359
git-svn-id: http://core.svn.wordpress.org/trunk@46158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:56:57 +00:00
desrosj
ae29987a17
Site Health: Improve the message displayed to sites not utilizing HTTPS.
...
The new message better illustrates that there are many potential benefits of using HTTPS, not just a few.
Props garrett-eclipse, dkarfa, ocean90, afragen, desrosj.
Fixes #48118 .
Built from https://develop.svn.wordpress.org/trunk@46358
git-svn-id: http://core.svn.wordpress.org/trunk@46157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:54:58 +00:00
Andrea Fercia
6566808e8a
Accessibility: Improve and modernize user interface controls: Improve the new form controls styles and heights.
...
Improves cross-browsers rendering and addresses most of the reported edge cases.
See #47477 .
Built from https://develop.svn.wordpress.org/trunk@46356
git-svn-id: http://core.svn.wordpress.org/trunk@46155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:24:59 +00:00
antpb
247e7eb7d5
Media: Revert [46354] preventing bad clipping of text in image details page.
...
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46355
git-svn-id: http://core.svn.wordpress.org/trunk@46154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:12:59 +00:00
antpb
7c8028febf
Media: Prevents clipping of text when scaling image edit screen.
...
Props sabernhardt, audrasjb, afercia.
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46354
git-svn-id: http://core.svn.wordpress.org/trunk@46153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 16:34:58 +00:00
Andrew Ozz
38e6958698
Media: Move `wp_get_original_image_path()` to `wp-content/post.php` to make it easier to access from plugins.
...
Props pbiron.
See #47873 .
Built from https://develop.svn.wordpress.org/trunk@46353
git-svn-id: http://core.svn.wordpress.org/trunk@46152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 16:28:59 +00:00
Andrea Fercia
20e781f44d
Accessibility: Improve and modernize user interface controls: Remove the CSS transform 1 pixel shift from the buttons active state.
...
Props Joen.
See #34904 .
Built from https://develop.svn.wordpress.org/trunk@46350
git-svn-id: http://core.svn.wordpress.org/trunk@46149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 10:53:57 +00:00
desrosj
8cb7c5c764
Upgrade/Install: Fix the Install Now button in the plugin overlay when running WordPress on a specific port.
...
Props garrett-eclipse, pierlo, afragen.
Fixes #48077 .
Built from https://develop.svn.wordpress.org/trunk@46348
git-svn-id: http://core.svn.wordpress.org/trunk@46147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 00:05:57 +00:00
Andrea Fercia
dfcdb40c8f
Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment.
...
Props desrosj, garrett-eclipse, afercia.
See #47498 .
Built from https://develop.svn.wordpress.org/trunk@46345
git-svn-id: http://core.svn.wordpress.org/trunk@46144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 21:56:56 +00:00
Andrea Fercia
8ef586a897
Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue.
...
Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb.
See #34904 .
Built from https://develop.svn.wordpress.org/trunk@46344
git-svn-id: http://core.svn.wordpress.org/trunk@46143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 21:53:57 +00:00
Sergey Biryukov
5f2c7142a1
Docs: Improve documentation for `::display()` methods in various list tables.
...
Props itowhid06.
Fixes #47947 .
Built from https://develop.svn.wordpress.org/trunk@46341
git-svn-id: http://core.svn.wordpress.org/trunk@46140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 11:04:58 +00:00
Andrea Fercia
55b1dc642e
Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states.
...
See #47477 .
See #48128 .
Built from https://develop.svn.wordpress.org/trunk@46340
git-svn-id: http://core.svn.wordpress.org/trunk@46139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:45:57 +00:00
Andrea Fercia
7d769a9234
Accessibility: Improve and modernize user interface controls. Style the select elements disabled state.
...
Props adhitya03, MarcosAlexandre, kjellr.
See #47477 .
Fixes #48129 .
Built from https://develop.svn.wordpress.org/trunk@46339
git-svn-id: http://core.svn.wordpress.org/trunk@46138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:35:59 +00:00
Andrew Ozz
dd44ab5a58
Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen.
...
Props masummdar, audrasjb, afercia.
Fixes #47318 .
Built from https://develop.svn.wordpress.org/trunk@46338
git-svn-id: http://core.svn.wordpress.org/trunk@46137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:20:57 +00:00
Andrea Fercia
becc682bcf
Accessibility: Improve and modernize user interface controls. Make the select elements background white.
...
Props adhitya03.
See #47477 .
Fixes #48128 .
Built from https://develop.svn.wordpress.org/trunk@46337
git-svn-id: http://core.svn.wordpress.org/trunk@46136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:15:59 +00:00
Sergey Biryukov
07a753cb35
Docs: Add documentation for `WP_Comments_List_Table::display()`.
...
Props itowhid06, dinhtungdu.
Fixes #47929 .
Built from https://develop.svn.wordpress.org/trunk@46336
git-svn-id: http://core.svn.wordpress.org/trunk@46135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-27 23:03:58 +00:00
whyisjake
b6f7c0cbc4
Administration: Ensure visual consistency with large titles in the sidebar.
...
Custom posts, and other menu titles that are long aren't wrapping correctly.
Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb
Fixes #42201
Built from https://develop.svn.wordpress.org/trunk@46332
git-svn-id: http://core.svn.wordpress.org/trunk@46131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 21:51:57 +00:00
Andrea Fercia
66dd6814e7
Media: Restore the original Image Editor columns layout after [46326].
...
Fixes #47116 .
Built from https://develop.svn.wordpress.org/trunk@46331
git-svn-id: http://core.svn.wordpress.org/trunk@46130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:37:57 +00:00
whyisjake
c034f5b4c3
Menus: Replace http with https in placeholders.
...
Encourage the use of https with the placeholder text in menus.
Fixes #46312
Props aksl95, audrasjb, celloexpressions, SergeyBiryukov, jorbin.
Built from https://develop.svn.wordpress.org/trunk@46330
git-svn-id: http://core.svn.wordpress.org/trunk@46129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:32:55 +00:00
Andrea Fercia
93dd6d907a
Accessibility: Media: Make the Image Editor buttons text visible.
...
User interface controls that use only icons aren't ideal for many users.
Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background.
Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them.
- shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal
- moves the Undo and Redo buttons underneath the main buttons group
Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder.
Fixes #47116 .
Built from https://develop.svn.wordpress.org/trunk@46326
git-svn-id: http://core.svn.wordpress.org/trunk@46125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 17:16:57 +00:00
Sergey Biryukov
6e8f550770
General: Correct strict comparison in `WP_Links_List_Table::column_categories()` introduced in [46313].
...
`$cat_id` is a string, `$category` is an integer.
See #48142 .
Built from https://develop.svn.wordpress.org/trunk@46316
git-svn-id: http://core.svn.wordpress.org/trunk@46115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 01:24:56 +00:00
Sergey Biryukov
148322a970
Docs: Improve documentation for `_post_states()` and `get_post_states()`.
...
Add documentation for `_media_states()`.
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46315
git-svn-id: http://core.svn.wordpress.org/trunk@46114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 00:57:58 +00:00
whyisjake
a351243928
General: Further phpcs cleanup.
...
In [46312] and [46313] we attempted to do some phpcs cleanup. This commit cleans up three issues that were introduced in [46309].
Fixes #48142 .
Props: whyisjake, garrett-eclipse, desrosj
Built from https://develop.svn.wordpress.org/trunk@46314
git-svn-id: http://core.svn.wordpress.org/trunk@46113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 00:37:58 +00:00
whyisjake
d53b773a47
General: Further phpcs cleanup.
...
In [46312] we attempted to do some `phpcs` cleanup. This commit cleans up three issues that were introduced in [46309].
Fixes #48142 .
Props whyisjake, garrett-eclipse.
Built from https://develop.svn.wordpress.org/trunk@46313
git-svn-id: http://core.svn.wordpress.org/trunk@46112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 23:38:57 +00:00
whyisjake
38dc032e66
General: Linter cleanup
...
`phpcbf` was able to clean up a few files. Tests were breaking as a result of code formatting.
Fixes #48142
Props whyisjake
Built from https://develop.svn.wordpress.org/trunk@46312
git-svn-id: http://core.svn.wordpress.org/trunk@46111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 22:53:58 +00:00
whyisjake
b4ab6b7e14
Menus: Duplicate Page Entry in View All Pages when generating a Menu
...
Simplifies the interface in menu creation.
Fixes [37782]
Props garrett-eclipse, mdgl, birgire, xkon, audrasjb, pento, girlieworks
Built from https://develop.svn.wordpress.org/trunk@46309
git-svn-id: http://core.svn.wordpress.org/trunk@46108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 21:51:58 +00:00
Andrea Fercia
f8a25a89c9
Accessibility: Implement the new focus styles on the login screen after [46247].
...
Props @kjellr.
See #47153 .
Built from https://develop.svn.wordpress.org/trunk@46293
git-svn-id: http://core.svn.wordpress.org/trunk@46105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 16:40:00 +00:00
desrosj
894e133d0c
Build/Test Tools: Introduce automated PHP compatibility checking.
...
This change introduces a new Composer script, `compat` that will scan the codebase for (detectable) potential PHP compatibility issues using the `PHP_CodeSniffer` and a custom ruleset based off of the `PHPCompayibilityWP` ruleset (`phpcompat.xml.dist`).
The command will be run as a separate job within each Travis build. While many compatibility issues and false positives have already been corrected in this commit and other Trac tickets, there are still some remaining. For that reason, the job is allowed to fail while the remainder of the potential compatibility issues are investigated and addressed. After those are resolved, the job should be set as required to pass to help prevent new compatibility issues from being introduced.
Props desrosj, jrf, all PHPCompatibilityWP and PHPCompatibility contributors.
Fixes #46152 .
Built from https://develop.svn.wordpress.org/trunk@46290
git-svn-id: http://core.svn.wordpress.org/trunk@46102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 13:47:58 +00:00
Sergey Biryukov
c7f4cbc62c
Docs: Improve consistency in `@since` tags for parameters that were made optional.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46288
git-svn-id: http://core.svn.wordpress.org/trunk@46100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-24 12:54:57 +00:00
Sergey Biryukov
a943fd64bc
Coding Standards: Fix WPCS issue in [46283].
...
See #48110 .
Built from https://develop.svn.wordpress.org/trunk@46284
git-svn-id: http://core.svn.wordpress.org/trunk@46096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 23:24:57 +00:00
Sergey Biryukov
75ca249558
Twenty Twenty: Rename widget areas to `sidebar-1` and `sidebar-2`.
...
This ensures that widgets are mapped correctly and is consistent with the previous default themes.
See https://github.com/WordPress/twentytwenty/issues/481 .
Reverts [46282].
Props ocean90, garrett-eclipse, desrosj, SergeyBiryukov.
See #48110 .
Built from https://develop.svn.wordpress.org/trunk@46283
git-svn-id: http://core.svn.wordpress.org/trunk@46095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 23:17:58 +00:00
Sergey Biryukov
b95b6f2c73
Site Health: Move "The folder ... was detected as being under version control" message from failure to warning.
...
Props afragen, davidbaumwald.
Fixes #47982 .
Built from https://develop.svn.wordpress.org/trunk@46281
git-svn-id: http://core.svn.wordpress.org/trunk@46093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 21:24:56 +00:00
desrosj
098455b06f
Bundled Themes: Make Twenty Twenty the new default theme.
...
After being imported in [46271], Twenty Twenty can now be set as the default theme in WordPress.
See #48110 .
Props desrosj, ocean90.
Built from https://develop.svn.wordpress.org/trunk@46278
git-svn-id: http://core.svn.wordpress.org/trunk@46090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 21:00:58 +00:00
Sergey Biryukov
c117b9957f
Site Health: Use `WP_Automatic_Updater::is_disabled()` to check whether automatic updates are disabled.
...
The previous check for `DISALLOW_FILE_MODS` and `AUTOMATIC_UPDATER_DISABLED` constants didn't always provide accurate results.
Props Clorith, kraftner, afragen.
Fixes #47869 .
Built from https://develop.svn.wordpress.org/trunk@46276
git-svn-id: http://core.svn.wordpress.org/trunk@46088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 20:52:56 +00:00
Sergey Biryukov
371f83cfd1
Site Health: Introduce `site_status_test_result` filter for the output of a finished Site Health test.
...
Props Clorith.
Fixes #47864 .
Built from https://develop.svn.wordpress.org/trunk@46269
git-svn-id: http://core.svn.wordpress.org/trunk@46081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 20:04:58 +00:00
Sergey Biryukov
db5f9f7a3a
Site Health: Update PHP extension tests to reflect the current state of the Hosting Teams handbook recommendations.
...
Props Clorith, bronsonquick, jrf, johnbillion, galbaras, mikeschroder, jorbin.
Fixes #47454 .
Built from https://develop.svn.wordpress.org/trunk@46268
git-svn-id: http://core.svn.wordpress.org/trunk@46080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:50:56 +00:00
Sergey Biryukov
9510aaecde
Site Health: Improve wording for PHP update warning.
...
Props danieltj, garrett-eclipse, marybaum, afragen, chetan200891.
Fixes #47644 .
Built from https://develop.svn.wordpress.org/trunk@46267
git-svn-id: http://core.svn.wordpress.org/trunk@46079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:39:58 +00:00
Sergey Biryukov
5955f0938b
Privacy: Introduce `wp_privacy_personal_data_email_to` and `wp_privacy_personal_data_email_subject` filters.
...
Pass email data to the `wp_privacy_personal_data_email_content` filter.
Props garrett-eclipse, thakkarhardik, birgire.
Fixes #46303 .
Built from https://develop.svn.wordpress.org/trunk@46265
git-svn-id: http://core.svn.wordpress.org/trunk@46077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:25:57 +00:00
Sergey Biryukov
255b1d6e3f
Privacy: Show a success message for personal data erasure.
...
Props garrett-eclipse, allendav, birgire, JoshuaWold, karmatosed, pputzer.
Fixes #44135 .
Built from https://develop.svn.wordpress.org/trunk@46264
git-svn-id: http://core.svn.wordpress.org/trunk@46076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:13:58 +00:00
John Blackbourn
f14fc1392c
Taxonomy: Redirect to the correct URL after deleting a taxonomy term attached to a post type other than Post.
...
Props donmhico, mukesh27
Fixes #47858
Built from https://develop.svn.wordpress.org/trunk@46263
git-svn-id: http://core.svn.wordpress.org/trunk@46075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:10:58 +00:00
desrosj
bcbedd7f55
Coding Standards: Fix a coding standards issue introduced in [46254].
...
See #37392 .
Built from https://develop.svn.wordpress.org/trunk@46261
git-svn-id: http://core.svn.wordpress.org/trunk@46073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 18:35:00 +00:00
Andrea Fercia
0d75495612
Login and Registration: Add a "Show password" button on the login page.
...
The ability for users to see the password they're typing improves usability and accessibility of the login users flow.
- brings the login screen in line with the same feature already used in the New User, Edit User, and Reset Password pages
- improves association of labels and input fields by using explicit association with `for` / `id` attributes
- slightly increases the "Remember me" label font size
Props johnbillion, Iceable, audrasjb, joyously, adamsilverstein, boemedia, DrewAPicture, shadyvb, birgire, peterwilsoncc, pento, anevins, davidbaumwald, whyisjake, afercia.
Fixes #42888 .
Built from https://develop.svn.wordpress.org/trunk@46256
git-svn-id: http://core.svn.wordpress.org/trunk@46068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 18:06:57 +00:00
johnjamesjacoby
e5302dff26
Multisite/Sites: supplemental commit to r46251.
...
This commit adds the links to the list-table class itself (that were missed in r46251.)
See #37392 . Props pbiron, thomaswm.
Built from https://develop.svn.wordpress.org/trunk@46254
git-svn-id: http://core.svn.wordpress.org/trunk@46066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:51:58 +00:00
Ella Iseulde Van Dorpe
22ae908ede
Editor: Add Nonce Endpoint
...
This is a follow up to #47843 , implementing a PHP endpoint and inline scripts
after the editor package updates. The action was originally added in
https://github.com/WordPress/gutenberg/pull/16683 .
Fixes #48076 .
Built from https://develop.svn.wordpress.org/trunk@46253
git-svn-id: http://core.svn.wordpress.org/trunk@46065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:47:56 +00:00
johnjamesjacoby
b65ea119bb
Multisite/Sites: Add links to filter websites by status.
...
This commit brings the Network-Admin Sites list page up-to-speed with other similar list-table powered pages, by adding links to filter the results by Site Status.
Includes a single unit test for the newly introduced `wp_count_sites()` multisite function, named to match the `wp_count_` function pattern from other list tables.
Fixes #37392 . Props mnelson4, spacedmonkey, pbiron.
Built from https://develop.svn.wordpress.org/trunk@46251
git-svn-id: http://core.svn.wordpress.org/trunk@46063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:35:59 +00:00