Commit Graph

557 Commits

Author SHA1 Message Date
Drew Jaynes 6ccba88ea5 Add proper descriptions for the `@global` and `@param` tags in the `wp_media_attach_action()` DocBlock.
See [31619]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32018


git-svn-id: http://core.svn.wordpress.org/trunk@31997 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-04 21:35:25 +00:00
Scott Taylor bce851dcf2 Replace `array_shift()` with `reset()` where appropriate for performance.
Props SergeyBiryukov.
Fixes #31259.

Built from https://develop.svn.wordpress.org/trunk@31829


git-svn-id: http://core.svn.wordpress.org/trunk@31811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-19 03:56:27 +00:00
Andrew Ozz 9e1d17ad36 Press This:
- Strip slashes while running side_load_images(), add slashes after.
- Simplify and clean up side_load_images().
- Add another arg to media_sideload_image() to return the uploaded image src only, and fix it to always return WP_Error on errors.
Fixes #31660.
Built from https://develop.svn.wordpress.org/trunk@31799


git-svn-id: http://core.svn.wordpress.org/trunk@31781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-17 00:47:28 +00:00
Sergey Biryukov 19f1d4f402 EXIF/IPTC captions should populate Caption (`post_excerpt`) on upload, not Description (`post_content`).
Make sure the caption is always set if found. Previously, if the caption was less than 80 characters, only the Title field would be set.

props beaulebens, ericlewis, bendoh, SergeyBiryukov.
fixes #22768.
Built from https://develop.svn.wordpress.org/trunk@31694


git-svn-id: http://core.svn.wordpress.org/trunk@31675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-10 05:07:28 +00:00
Scott Taylor 8f0b626d13 Introduce a function, `wp_attachment_is( $type, $post = 0 )`, to collapse the logic for determining whether an attachment is an `image`, `audio`, or `video`.
This is admittedly a first pass. There needs to be a generic handler for when any other type is passed, but for now it accepts the whitelist.

See #25275.

Built from https://develop.svn.wordpress.org/trunk@31645


git-svn-id: http://core.svn.wordpress.org/trunk@31626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-06 20:26:26 +00:00
Scott Taylor f9c138b4c4 `detached` affects the `wp()` call for the media list table, so switch our new `$_GET` key to `detach`.
See #6820.

Built from https://develop.svn.wordpress.org/trunk@31624


git-svn-id: http://core.svn.wordpress.org/trunk@31605 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 15:59:27 +00:00
Scott Taylor d3471e9850 Allow attachments to be Detached from their parent in media grid and list modes.
See #6820.

Built from https://develop.svn.wordpress.org/trunk@31619


git-svn-id: http://core.svn.wordpress.org/trunk@31600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-05 05:35:28 +00:00
Sergey Biryukov 43583a1b9e Terminate JS statements in two admin files.
props ipm-frommen.
fixes #31311.
Built from https://develop.svn.wordpress.org/trunk@31440


git-svn-id: http://core.svn.wordpress.org/trunk@31421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-13 04:09:27 +00:00
Scott Taylor 7f8b548df1 In HTML5, the `action` attribute is no longer required. Remove this attribute when empty.
The admin HTML is served with the HTML5 doctype.

"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces." 
http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-action

Props voldemortensen.
Fixes #30126.

Built from https://develop.svn.wordpress.org/trunk@31200


git-svn-id: http://core.svn.wordpress.org/trunk@31181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 04:16:24 +00:00
Scott Taylor 6704875855 Replace the 3 remaining occurrences of `wpspin` GIF with `spinner`.
Props avryl.
Fixes #27482.

Built from https://develop.svn.wordpress.org/trunk@31187


git-svn-id: http://core.svn.wordpress.org/trunk@31168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-16 00:33:22 +00:00
Sergey Biryukov d5d0b367ab Improve documentation for media_handle_upload().
props ericlewis.
fixes #30962.
Built from https://develop.svn.wordpress.org/trunk@31109


git-svn-id: http://core.svn.wordpress.org/trunk@31090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-09 05:05:23 +00:00
Scott Taylor 60b0cd7943 The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-08 07:05:25 +00:00
Scott Taylor af0e5cc851 Inline `<script>`s that are only printed in the admin for pages that are served with the HTML5 doctype absolutely do not need `CDATA` comments.
Props tw2113 for the initial patch.
See #18788.

Built from https://develop.svn.wordpress.org/trunk@31034


git-svn-id: http://core.svn.wordpress.org/trunk@31015 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-03 05:46:25 +00:00
Scott Taylor 2dbd0d0a8f In `image_size_input_fields()`:
* Declare `$out` as an empty array - this is not a strict PHP requirement, but is a good practice before loops
* Most of this function was tabbed twice, instead of once

See #30799.

Built from https://develop.svn.wordpress.org/trunk@30981


git-svn-id: http://core.svn.wordpress.org/trunk@30967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-20 22:19:24 +00:00
Scott Taylor 2c32752abd Improve various `@param` docs for `src/wp-admin/*`.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30680


git-svn-id: http://core.svn.wordpress.org/trunk@30670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-01 01:00:22 +00:00
Drew Jaynes 78bb3e5ff5 Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/includes/*.
Also adds a few inline `@see` cross-references as they apply.

Affects DocBlocks for the following hooks:
* `views_{$this->screen->id}`
* `bulk_actions-{$this->screen->id}`
* `manage_{$this->screen->id}_sortable_columns`
* `theme_action_links_$stylesheet`
* `after_theme_row_$stylesheet`
* `install_plugins_table_api_args_$tab`
* `$prefix . plugin_action_links`
* `after_plugin_row_$plugin_file`
* `manage_taxonomies_for_{$post_type}_columns`
* `manage_{$post_type}_posts_columns`
* `manage_{$post->post_type}_posts_custom_column`
* `{$taxonomy}_row_actions`
* `manage_{$this->screen->taxonomy}_custom_column`
* `install_themes_table_api_args_' . $tab`
* `auto_update_ . $type`
* `{$action}_prefilter`
* `admin_head_{$content_func}`
* `nav_menu_items_{$post_type_name}`
* `activate_ . $plugin`
* `deactivate_ . $plugin`
* `edit_{$post_type}_per_page`
* `postbox_classes_{$page}_{$id}`
* `_wp_post_revision_field_$field`
* `manage_{$screen->id}_columns`
* `in_plugin_update_message-{$file}`
* `in_theme_update_message-{$theme_key}`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30648


git-svn-id: http://core.svn.wordpress.org/trunk@30638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:28:24 +00:00
Drew Jaynes 5212725fbe 4.1 Docs Audit: Convert a hook reference to an inline `@see` tag in the hook docs for the `image_add_caption_text` filter.
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30600


git-svn-id: http://core.svn.wordpress.org/trunk@30590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-28 08:56:24 +00:00
Drew Jaynes 9955384dbe Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented.
Affects DocBlocks for the following core elements:
* Backtick-escape an HTML tag in the description for the `media_upload_mime_type_links()` hook
* Backtick-escape inline code in the description for `wp_get_active_network_plugins()`
* Remove HTML tags from the summaries for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks
* Backtick-escape HTML tags, add inline `@see` tags to parameter descriptions for the `nav_menu_css_class`, `nav_menu_item_id`, and `nav_menu_link_attributes` hooks

Props rarst.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30543


git-svn-id: http://core.svn.wordpress.org/trunk@30532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-24 05:53:22 +00:00
Scott Taylor 5e3a64e83d Correct some types in `wp-admin/*`-location files' doc blocks.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30203


git-svn-id: http://core.svn.wordpress.org/trunk@30203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 07:09:23 +00:00
Scott Taylor 7d7a8aa0eb Correct all `@return unknown` instances.
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30202


git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:17:22 +00:00
Scott Taylor bd2521d5ee Fill in the `@param` types for the args for functions missing them in `wp-admin/includes/deprecated.php` (pour one out).
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30201


git-svn-id: http://core.svn.wordpress.org/trunk@30201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-03 06:08:22 +00:00
Gary Pendergast 007ec52958 Add `wp_json_encode()`, a wrapper for `json_encode()` that ensures everything is converted to UTF-8.
Change all core calls from `json_encode()` to `wp_json_encode()`.

Fixes #28786.


Built from https://develop.svn.wordpress.org/trunk@30055


git-svn-id: http://core.svn.wordpress.org/trunk@30055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-28 18:35:19 +00:00
Andrew Ozz 7a55ab9164 Media: disable multi-file uploading in iOS 7.x Safari as it prevents uploading of videos. Fixes #29602 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29776


git-svn-id: http://core.svn.wordpress.org/trunk@29548 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-29 00:14:18 +00:00
Sergey Biryukov 26124b9aad Pass the attachment ID to the 'image_add_caption_text' filter.
fixes #29607.
Built from https://develop.svn.wordpress.org/trunk@29754


git-svn-id: http://core.svn.wordpress.org/trunk@29526 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-21 10:11:16 +00:00
Sergey Biryukov 79d017a024 Add 'image_add_caption_text' filter for changing the pre-parse caption text before output to the editor.
props collinsinternet, DrewAPicture.
fixes #29607.
Built from https://develop.svn.wordpress.org/trunk@29753


git-svn-id: http://core.svn.wordpress.org/trunk@29525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-21 09:56:17 +00:00
Scott Taylor 69998d452b In `media_handle_upload()`, don't call `wp_read_image_metadata()` on things that aren't images (like videos). We never caught this error, because we are suppressing it by calling `@wp_read_image_metadata()`.
Props jrf for the initial patch.
Fixes #28907.

Built from https://develop.svn.wordpress.org/trunk@29737


git-svn-id: http://core.svn.wordpress.org/trunk@29511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-11 20:15:17 +00:00
Andrew Ozz 69e7171f41 Media: revert enabling of multi-file uploading for mobile devices. Currently only iOS Safari supports it but has a bug that prevents uploading of videos. Fixes #29602
Built from https://develop.svn.wordpress.org/trunk@29729


git-svn-id: http://core.svn.wordpress.org/trunk@29503 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-10 22:40:16 +00:00
Scott Taylor fa0acbe3bb Don't overwrite the `length` property unnecessarily when generating metadata for audio and video files.
Props jrf, wonderboymusic.
Fixes #29176.

Built from https://develop.svn.wordpress.org/trunk@29728


git-svn-id: http://core.svn.wordpress.org/trunk@29502 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-10 21:57:15 +00:00
Sergey Biryukov 1eb26d3ff3 Use https for apps.wordpress.org links.
props pento.
fixes #29595 for trunk.
Built from https://develop.svn.wordpress.org/trunk@29721


git-svn-id: http://core.svn.wordpress.org/trunk@29495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-09 06:29:15 +00:00
Andrew Nacin 00fac0639d Link to apps.wordpress.org instead of wordpress.org/mobile.
props pento.
fixes #29496.

Built from https://develop.svn.wordpress.org/trunk@29703


git-svn-id: http://core.svn.wordpress.org/trunk@29477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-04 14:22:15 +00:00
Sergey Biryukov 5faf09a261 Restore 'insert-media-button' as an ID attribute for the first instance of media_buttons(). Remove IDs for subsequent instances.
props nacin.
fixes #28090.
Built from https://develop.svn.wordpress.org/trunk@29671


git-svn-id: http://core.svn.wordpress.org/trunk@29445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 09:08:16 +00:00
Dominik Schilling 8ea68677f3 Media Upload: Improve styling of error messages.
props afercia, michalzuber.
fixes #29047.
Built from https://develop.svn.wordpress.org/trunk@29355


git-svn-id: http://core.svn.wordpress.org/trunk@29131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-02 14:14:19 +00:00
Sergey Biryukov be718ee860 Declare the variable before using it.
props danielbachhuber.
fixes #28932.
Built from https://develop.svn.wordpress.org/trunk@29215


git-svn-id: http://core.svn.wordpress.org/trunk@28999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 22:01:14 +00:00
Drew Jaynes 097dc8ee15 Fix syntax for single- and multi-line comments in wp-admin-directory files.
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29206


git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Scott Taylor 57dbc55e6e When setting the poster image for a video shortcode, set that image as the featured image for that attachment (if found) in the background. This AJAX functionality could be used for audio as well.
Introduces `attachment_url_to_postid()` to attempt to turn URLs into post IDs.

Fixes #27891.

Built from https://develop.svn.wordpress.org/trunk@29029


git-svn-id: http://core.svn.wordpress.org/trunk@28817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-08 17:48:17 +00:00
Scott Taylor 650261b549 In deprecated media iframe code, `attachment_fields_to_save` filter should not be called twice after initial image upload in post.
Props SergeyBiryukov.
Fixes #20720.

Built from https://develop.svn.wordpress.org/trunk@28871


git-svn-id: http://core.svn.wordpress.org/trunk@28671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-27 21:32:16 +00:00
Andrew Ozz b9fd9db83b Uploader: enable selecting multiple files on mobile devices (still doesn't work on Android). See #28640.
Built from https://develop.svn.wordpress.org/trunk@28847


git-svn-id: http://core.svn.wordpress.org/trunk@28651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-26 04:15:15 +00:00
Scott Taylor 41ab39f42c In `media_buttons()`, add a static var `$instance` to increment the `id` attribute of `insert-media-button-%d` on each call.
Props ericlewis.
Fixes #28090.

Built from https://develop.svn.wordpress.org/trunk@28837


git-svn-id: http://core.svn.wordpress.org/trunk@28641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-26 01:05:14 +00:00
Drew Jaynes 1868c1fc4b Remove unnecessary "not used" notation for filter parameters in wp-admin/includes/media.php.
Also add `@param` and `@return` descriptions.

See #28408.

Built from https://develop.svn.wordpress.org/trunk@28632


git-svn-id: http://core.svn.wordpress.org/trunk@28451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-30 17:38:14 +00:00
Scott Taylor 8b7b72d75e In `media_sideload_image()`, check the returned value of `download_url()` earlier to avoid attempting to `unlink()` an instance of `WP_Error`.
Props georgestephanis. 
Fixes #28204.

Built from https://develop.svn.wordpress.org/trunk@28567


git-svn-id: http://core.svn.wordpress.org/trunk@28392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-23 21:33:14 +00:00
Scott Taylor 130771a383 `hackificator` doesn't like mixed quote styles in some generated HTML. The switch from single to double allows these files to be parsed.
See #27881.

Built from https://develop.svn.wordpress.org/trunk@28497


git-svn-id: http://core.svn.wordpress.org/trunk@28323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-19 01:59:15 +00:00
Scott Taylor 54321f4c6e Eliminate use of `extract()` in `get_media_item()`.
To test, fire open the old media in the console: `tb_show('Old Media is Weird', 'media-upload.php?type=image&TB_iframe=true&post_id=0');`	
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28407


git-svn-id: http://core.svn.wordpress.org/trunk@28234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-15 02:45:15 +00:00
Scott Taylor 2bea9fcc0b In `media_upload_gallery_form()`'s inline JavaScript, remove unnecessary comment tags.
Fixes #25637.


Built from https://develop.svn.wordpress.org/trunk@28368


git-svn-id: http://core.svn.wordpress.org/trunk@28196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-11 06:12:15 +00:00
Scott Taylor 1daa7d6723 Leverage `size_format()` when displaying `max_upload_size`:
* In `media_upload_form()` 
* The `uploader-inline` Underscore template in the media modal. 

Replaces 2 buggy inline implementations that could display size units off by one, or size values off by one.

Fixes #25643.


Built from https://develop.svn.wordpress.org/trunk@28343


git-svn-id: http://core.svn.wordpress.org/trunk@28171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 18:25:14 +00:00
Scott Taylor 71ac0f21c2 In `get_media_item()`, `$tags` and `$_tags` are set and never used.
See #27882.

Built from https://develop.svn.wordpress.org/trunk@28297


git-svn-id: http://core.svn.wordpress.org/trunk@28125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 16:41:17 +00:00
Scott Taylor dd73ad4299 In `edit_form_image_editor()`, `$filename` and `$title` are set and then unused. They shall be removed.
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28271


git-svn-id: http://core.svn.wordpress.org/trunk@28099 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 04:45:16 +00:00
Andrew Ozz c9f5ed0801 Plupload: restore the settings in media_upload_form(), see #27763
Built from https://develop.svn.wordpress.org/trunk@28110


git-svn-id: http://core.svn.wordpress.org/trunk@27941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 00:41:15 +00:00
Drew Jaynes 4af2840a47 Clarify PHPDoc return description for `media_handle_upload()`.
Props jdgrimes.
Fixes #27519.

Built from https://develop.svn.wordpress.org/trunk@27880


git-svn-id: http://core.svn.wordpress.org/trunk@27711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 22:33:15 +00:00
Scott Taylor 01d2062af3 Cleanup up the display, escaping, and handling of ID3 data for media. Rename `wp_get_relevant_id3_keys()` to `wp_get_attachment_id3_keys()`.
Props nacin.
See #27574.


Built from https://develop.svn.wordpress.org/trunk@27869


git-svn-id: http://core.svn.wordpress.org/trunk@27700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-31 05:16:16 +00:00
Andrew Nacin c95f232727 Cleanups for audio/video metadata, see [27862].
see #27574.

Built from https://develop.svn.wordpress.org/trunk@27864


git-svn-id: http://core.svn.wordpress.org/trunk@27695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-30 21:08:14 +00:00