Drew Jaynes
5c075e5af7
Docs: Remove a few more superfluous `@package WordPress` and `@subpackage` notations outside of file headers missed in [40988].
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40989
git-svn-id: http://core.svn.wordpress.org/trunk@40839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 17:11:41 +00:00
Drew Jaynes
1d95dcfa2c
Docs: Remove superfluous `@package WordPress` and `@subpackage` notations used outside of file headers in a variety of core files.
...
Per the inline documentation standards for PHP, there should only be one `@package` and/or `@subpackage` notation per file, and only in the file header.
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40988
git-svn-id: http://core.svn.wordpress.org/trunk@40838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 16:58:42 +00:00
Drew Jaynes
ae017f435a
Docs: Convert an `@uses` tag in the class DocBlock for `Walker_Nav_Menu_Edit` to `@see`.
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40987
git-svn-id: http://core.svn.wordpress.org/trunk@40837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 16:49:40 +00:00
Drew Jaynes
bd2173f42c
Docs: Remove an unnecessary `@package` tag from the DocBlock for `post_preview()`.
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40986
git-svn-id: http://core.svn.wordpress.org/trunk@40836 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 16:39:41 +00:00
Drew Jaynes
ba40430e89
Docs: Add a valid return type for `post_preview()` and improve the DocBlock summary.
...
See #41017 .
Built from https://develop.svn.wordpress.org/trunk@40985
git-svn-id: http://core.svn.wordpress.org/trunk@40835 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 16:37:42 +00:00
Boone Gorges
26fcea496d
Introduce `most_used` taxonomy label, for text on 'Most Used' metabox tab.
...
Props mdifelice, jlambe.
Fixes #41150 .
Built from https://develop.svn.wordpress.org/trunk@40984
git-svn-id: http://core.svn.wordpress.org/trunk@40834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 14:46:41 +00:00
Drew Jaynes
903d23be34
Users: Introduce the `manage_users_extra_tablenav` action, fired immediately outside the closing "actions" div in the Users list table tablenav.
...
A similar `manage_posts_extra_tablenav` hook fires in the same location and context in the Posts list table tablenav.
Props GunGeekATX, adamsilverstein.
Fixes #36990 .
Built from https://develop.svn.wordpress.org/trunk@40974
git-svn-id: http://core.svn.wordpress.org/trunk@40824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-07-01 03:02:41 +00:00
Drew Jaynes
d829ec4cf2
Docs: Provide best practice guidance for achieving parity between `$menu_slug` values supplied when adding menu and submenu pages, and later trying to compare those initial values against sanitized screen IDs derived from `$menu_slug`.
...
At the heart of the matter, the `$menu_slug` parameter in `add_menu_page()` and `add_submenu_page()` is not sanitized with `sanitize_key()`. When the screen object is later built for the admin page, the screen ID is derived from that `$menu_slug` value, though passed through `sanitize_key()`, which can produce unexpected results in comparison check.
Changing the sanitization code to provide actual parity is out of the question at this juncture, so updating the docs to describe how to avoid this edge case is the next best option.
Props GregRoss.
Fixes #35305 .
Built from https://develop.svn.wordpress.org/trunk@40967
git-svn-id: http://core.svn.wordpress.org/trunk@40817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-30 04:18:43 +00:00
Sergey Biryukov
165807d39f
Administration: In `WP_List_Table::comments_bubble()`, replace the mdash with its HTML entity for consistency with the similar code in other list tables.
...
Props afercia.
See #40659 , #32152 .
Built from https://develop.svn.wordpress.org/trunk@40960
git-svn-id: http://core.svn.wordpress.org/trunk@40810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-29 00:04:43 +00:00
Sergey Biryukov
c6289b7440
Docs: Add missing backtick character in `export_wp()` DocBlock.
...
Props pbiron.
Fixes #41178 .
Built from https://develop.svn.wordpress.org/trunk@40958
git-svn-id: http://core.svn.wordpress.org/trunk@40808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-27 00:58:41 +00:00
Sergey Biryukov
01a6f4d38e
Administration: In taxonomy list tables, display a dash instead of a blank space and add "No description" as a screen reader text when the term description is blank.
...
Props pratikgandhi, yahil.
Fixes #40659 .
Built from https://develop.svn.wordpress.org/trunk@40957
git-svn-id: http://core.svn.wordpress.org/trunk@40807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-27 00:34:41 +00:00
Sergey Biryukov
25e94961b4
Administration: In user list tables, display a dash instead of a blank space and add "Unknown" as a screen reader text when the user's first name and last name are blank.
...
Props Girishpanchal, yahil.
Fixes #40628 .
Built from https://develop.svn.wordpress.org/trunk@40956
git-svn-id: http://core.svn.wordpress.org/trunk@40806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-27 00:27:39 +00:00
Drew Jaynes
07f01a2e10
Docs: Replace a variety of http links referenced in inline docs with their https counterparts (where possible).
...
Props johnpgreen.
Fixes #40732 .
Built from https://develop.svn.wordpress.org/trunk@40948
git-svn-id: http://core.svn.wordpress.org/trunk@40798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-25 22:06:41 +00:00
John Blackbourn
a507248146
Users: Use more appropriate HTTP status codes for errors relating to user management.
...
Also re-uses one error message string.
Props tuanmh
Fixes #40230
Built from https://develop.svn.wordpress.org/trunk@40940
git-svn-id: http://core.svn.wordpress.org/trunk@40790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-25 18:46:44 +00:00
Drew Jaynes
3a6985de96
Docs: Standardize and add missing deprecation notations in DocBlocks for the following functions:
...
* `post_form_autocomplete_off()`
* `_rotate_image_resource()`
* `_flip_image_resource()`
* `wp_get_sites()`
* `deactivate_sitewide_plugin()`
Props jrf.
See #41121 .
Built from https://develop.svn.wordpress.org/trunk@40922
git-svn-id: http://core.svn.wordpress.org/trunk@40772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-22 17:48:45 +00:00
Sergey Biryukov
f1740f3702
I18N: Correct translator comment for response error message in `WP_Community_Events::get_events()`.
...
Props Soean, tfirdaus.
Fixes #40939 .
Built from https://develop.svn.wordpress.org/trunk@40909
git-svn-id: http://core.svn.wordpress.org/trunk@40759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-15 12:07:41 +00:00
Sergey Biryukov
4398862f3d
I18N: Add context for News blog URL in 'WordPress Events and News' dashboard widget.
...
Props zodiac1978.
Fixes #40929 .
Built from https://develop.svn.wordpress.org/trunk@40905
git-svn-id: http://core.svn.wordpress.org/trunk@40755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-15 11:52:43 +00:00
Andrea Fercia
f28f4fc637
Accessibility: Avoid a keyboard trap on the permalink custom structure setting.
...
Using the `focus` event on the permalink custom structure field made impossible
to navigate through all the form fields using only the keyboard without actually
selecting the custom structure setting. Instead, using click and input preserves
the original functionality when using any kind of pointing or input device.
Also changes `attr()` to `prop()`` as recommended for a `checked` property.
Fixes #40982 .
Built from https://develop.svn.wordpress.org/trunk@40897
git-svn-id: http://core.svn.wordpress.org/trunk@40747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-12 14:09:43 +00:00
Sergey Biryukov
5041510529
Docs: Remove duplicate `@return` keyword in `WP_Community_Events::get_request_args`.
...
Props ketuchetan.
Fixes #40973 .
Built from https://develop.svn.wordpress.org/trunk@40895
git-svn-id: http://core.svn.wordpress.org/trunk@40745 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-11 11:10:43 +00:00
Sergey Biryukov
04c688ad52
Docs: Add missing closing quote for 'Restore' in `post_row_actions` and `page_row_actions` filters documentation.
...
See #26397 .
Built from https://develop.svn.wordpress.org/trunk@40882
git-svn-id: http://core.svn.wordpress.org/trunk@40732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-07 23:11:43 +00:00
Dominik Schilling
ec0918a6a7
Upgrade: Add `wp-includes/js/tinymce/plugins/wpembed` to `$_old_files`.
...
See #39513 .
Fixes #40942 .
Built from https://develop.svn.wordpress.org/trunk@40879
git-svn-id: http://core.svn.wordpress.org/trunk@40729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-07 21:32:44 +00:00
Andrea Fercia
1d34043e8c
Dashboard: Better titles for the Recent Drafts widget.
...
- changes "Drafts" to "Your Recent Drafts" to clarify displayed drafts are the ones from the current user
- clarifies and simplifies the "View all" link
Props soniakash, sudar, bhargavbhandari90, zachwtx, johnroper100, rcutmore.
Fixes #37595 .
Built from https://develop.svn.wordpress.org/trunk@40877
git-svn-id: http://core.svn.wordpress.org/trunk@40727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-05 12:00:43 +00:00
Dominik Schilling
55497ccfd1
I18N: Improve translator comments for strings in the community events widget.
...
Props dimadin, iandunn.
Fixes #40865 .
Built from https://develop.svn.wordpress.org/trunk@40866
git-svn-id: http://core.svn.wordpress.org/trunk@40716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-01 09:49:42 +00:00
Dominik Schilling
0e82284d87
Multisite: Revert indentation of the sample page content added in [40296].
...
Props swissspidy.
Fixes #40895 .
Built from https://develop.svn.wordpress.org/trunk@40864
git-svn-id: http://core.svn.wordpress.org/trunk@40714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-06-01 09:16:40 +00:00
Andrea Fercia
3aabc09e9c
Administration: Fix some HTML validation errors.
...
Fixes some minor HTML issues in the admin and, most notably, changes the rel
attribute used in the List Tables from `rel="permalink"` to `rel="bookmark"`.
Props mihai2u, pento, arena, topher1kenobe, michalzuber, stubgo.
Fixes #37004 .
Built from https://develop.svn.wordpress.org/trunk@40823
git-svn-id: http://core.svn.wordpress.org/trunk@40680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-23 17:58:43 +00:00
Sergey Biryukov
da0a505497
Administration: Update the docs for `wp_check_browser_version()`.
...
Correct `update_url` key name, add missing `platform` key.
Props coffee2code.
Fixes #40839 .
Built from https://develop.svn.wordpress.org/trunk@40822
git-svn-id: http://core.svn.wordpress.org/trunk@40679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-23 00:17:42 +00:00
Sergey Biryukov
2c5e9a34b2
Dashboard: Change the cache key for dashboard RSS widget; remove the unnecessary database upgrade routine.
...
Props iandunn, ocean90.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40803
git-svn-id: http://core.svn.wordpress.org/trunk@40661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 19:14:42 +00:00
Sergey Biryukov
a2788b09d5
Dashboard: Append the current locale to dashboard RSS widget cache key in `wp_dashboard_rss_control()`, for consistency with the changes to `wp_dashboard_cached_rss_widget()` in [33183] and [33192].
...
See #32804 , #40702 .
Built from https://develop.svn.wordpress.org/trunk@40802
git-svn-id: http://core.svn.wordpress.org/trunk@40660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 19:00:44 +00:00
Joe McGill
7d43d71800
Media: Ensure WP_Screen sets post type on wp-admin/upload.php.
...
The post type property is set to 'attachment' when on the upload screen.
Props postpostmodern.
Fixes #39509 .
Built from https://develop.svn.wordpress.org/trunk@40800
git-svn-id: http://core.svn.wordpress.org/trunk@40658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 18:29:42 +00:00
Dominik Schilling
97e98a80f6
Dashboard: Use `get_user_locale()` for the news feed cache key.
...
Since the feed URL can be localized the cache key has to be built with the same locale as the current user is using.
Props iandunn.
Fixes #40417 .
Built from https://develop.svn.wordpress.org/trunk@40793
git-svn-id: http://core.svn.wordpress.org/trunk@40651 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 14:36:42 +00:00
Andrew Ozz
7a9ce6d03f
Dashboard: Improve the handling of locations determined by geolocating the IP address and by entering a city name. Fix couple of edge cases, and some names.
...
Props iandunn coreymckrill.
Fixes #40702 .
Built from https://develop.svn.wordpress.org/trunk@40790
git-svn-id: http://core.svn.wordpress.org/trunk@40648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 05:48:42 +00:00
Andrew Ozz
daab579a88
Dashboard:
...
- Close the form after obtaining a valid location.
- Fix focusing the toggle button after closing the form.
- Fix aria attribute values.
- Fix positions in IE11.
- Some JS and CSS cleanup.
Props afercia, coreymckrill.
Fixes #40735 .
Built from https://develop.svn.wordpress.org/trunk@40789
git-svn-id: http://core.svn.wordpress.org/trunk@40647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-19 04:01:41 +00:00
Konstantin Obenland
8ef02e5ec7
Dashboard: Combine methods to retreive IP
...
They're only used in one place, no reason to be so verbose about it.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40781
git-svn-id: http://core.svn.wordpress.org/trunk@40639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 17:34:42 +00:00
Konstantin Obenland
83187e8ea0
Dashboard: Document request proxy for events.
...
Documents the reason why the request is proxied through WP, instead of being
made directly to api.wordpress.org.
Props iandunn, michelleweber.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40777
git-svn-id: http://core.svn.wordpress.org/trunk@40635 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 14:44:43 +00:00
Konstantin Obenland
9bbbc719d4
Dashboard: Properly localize data for events
...
Moves localization to script-loader and removes dependency for two strings.
Props dd32, iandunn.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40776
git-svn-id: http://core.svn.wordpress.org/trunk@40634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 14:34:43 +00:00
Konstantin Obenland
7cae389acc
Dashboard: Always pass the IP when getting events
...
Allows the API to determine event locations more accurately.
Props iandunn.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40774
git-svn-id: http://core.svn.wordpress.org/trunk@40632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-18 07:31:43 +00:00
Konstantin Obenland
71adf97a35
Upgrade: Use correct commit no. to trigger upgrade
...
Props iandunn.
See [40607], #40702 .
Built from https://develop.svn.wordpress.org/trunk@40773
git-svn-id: http://core.svn.wordpress.org/trunk@40631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-17 22:03:46 +00:00
Aaron Campbell
38347d7c58
Add nonce for updating file system credentials.
...
Built from https://develop.svn.wordpress.org/trunk@40723
git-svn-id: http://core.svn.wordpress.org/trunk@40581 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-16 14:48:44 +00:00
Konstantin Obenland
68588821c3
Dashboard: Community events formatting improvements
...
Props Soean.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40669
git-svn-id: http://core.svn.wordpress.org/trunk@40532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-15 09:44:43 +00:00
Konstantin Obenland
7328d561b1
Dashboard: Persist location for community events
...
Fixes a bug where cached events & location data was not accessible because the
cache key could not be regenerated without latitude and longitude information.
Discovered and fixed during #wcber contributor day.
Props soean, kubik-rubik, obenland.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40651
git-svn-id: http://core.svn.wordpress.org/trunk@40514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-12 15:53:46 +00:00
Andrea Fercia
bab7eb143e
Accessibility: Change the "Show details" links in the update core screen to buttons.
...
These controls toggle the visibility of the update progress: they perform an action
therefore they should be buttons. Also:
- uses `aria-expanded` to communicate the toggle button state
- removes some inline JavaScript
- when clicking the toggle buttons, the progress details get moved with JavaScript after the button: this helps users of assistive technologies in finding them and makes the UI a bit more intuitive
Props Cheffheid, afercia.
See #26504 .
Fixes #40453 .
Built from https://develop.svn.wordpress.org/trunk@40646
git-svn-id: http://core.svn.wordpress.org/trunk@40507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 23:50:41 +00:00
Andrea Fercia
274596b8ef
Accessibility: Add "(opens in a new window)" screen reader text to the "News-Nearby Events" dashboard widget footer links.
...
- standardizes similar messages in core to always use `(opens in a new window)`
- adds translators comments
- hides the dashicons with `aria-hidden="true"`, see #40428
Fixes #40733 .
Built from https://develop.svn.wordpress.org/trunk@40643
git-svn-id: http://core.svn.wordpress.org/trunk@40504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 22:47:41 +00:00
Pascal Birchler
33047ba14e
Upgrade/Install: After [40394], rename `wp_disallow_file_mods()` to `wp_is_file_mod_allowed()`.
...
This makes it more clear what this function is about.
Props Mte90.
Fixes #38673 .
Built from https://develop.svn.wordpress.org/trunk@40638
git-svn-id: http://core.svn.wordpress.org/trunk@40499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 19:24:41 +00:00
Dominik Schilling
0cd74a6d6e
Plugins: Don't strip line breaks and blockquote elements in the plugin information modal.
...
Fixes #40679 .
Built from https://develop.svn.wordpress.org/trunk@40633
git-svn-id: http://core.svn.wordpress.org/trunk@40494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 19:16:42 +00:00
Pascal Birchler
c000e99d6f
Mail: Ensure entities are decoded in email change notifications on Multisite.
...
Adds new tests to ensure this bug does not pop up again.
Props stephenharris.
Fixes #40015 .
Built from https://develop.svn.wordpress.org/trunk@40632
git-svn-id: http://core.svn.wordpress.org/trunk@40493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-11 19:15:44 +00:00
Andrew Ozz
b952bf4eae
Dashboard: Update the existing WordPress News dashboard widget to also include upcoming meetup events and WordCamps near the current user’s location.
...
Props @afercia, @andreamiddleton, @azaozz, @camikaos, @coreymckrill, @chanthaboune, @courtneypk, @dd32, @iandunn, @iseulde, @mapk, @mayukojpn, @melchoyce, @nao, @obenland, @pento, @samuelsidler, @stephdau, @tellyworth.
See #40702 .
Built from https://develop.svn.wordpress.org/trunk@40607
git-svn-id: http://core.svn.wordpress.org/trunk@40477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-10 20:04:42 +00:00
Mike Schroder
391145df30
Media: Optionally return attachment id from `media_sideload_image()`.
...
Introduces option to `$return` parameter to return the attachment id created after a successful image sideload.
Props slbmeh, kawauso, alexkingorg, SergeyBiryukov, georgestephanis, DrewAPicture, nacin, trepmal, mattheu, kraftbj, whyisjake, dotancohen, MrGregWaugh, danielbachhuber.
Fixes #19629 .
Built from https://develop.svn.wordpress.org/trunk@40597
git-svn-id: http://core.svn.wordpress.org/trunk@40467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-09 23:26:42 +00:00
Andrew Ozz
dd0d110520
TinyMCE: update to 4.6.0. Has many new features and bug fixes, changelog: https://www.tinymce.com/docs/changelog/#version460-may42017 .
...
Fixes #40690 .
Built from https://develop.svn.wordpress.org/trunk@40583
git-svn-id: http://core.svn.wordpress.org/trunk@40453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-08 05:32:46 +00:00
Andrea Fercia
98402b7c15
Administration: Restore missing spinner when installing a new language.
...
Fixes #40478 .
Built from https://develop.svn.wordpress.org/trunk@40579
git-svn-id: http://core.svn.wordpress.org/trunk@40449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-07 12:01:42 +00:00
Pascal Birchler
064e62cbea
Cron API: Add a new `wp_doing_cron()` helper function.
...
This replaces `DOING_CRON` checks via the constant.
Props tfrommen.
Fixes #39591 .
Built from https://develop.svn.wordpress.org/trunk@40575
git-svn-id: http://core.svn.wordpress.org/trunk@40445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-05-06 14:30:40 +00:00