WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
49,820 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

522 Commits

Author SHA1 Message Date
Boone Gorges 32887d3dfb Lazy-load comment meta on single post pages. 
[34268] introduced cache priming for commentmeta, enabled by default. To
ensure performance on single post pages - where commentmeta is most likely
to cause performance issues - we disable up-front cache-priming. Instead, we
prime commentmeta caches for all comments in the loop the first time
`get_comment_meta()` is called on the page.

Props bradt, dd32, wonderboymusic, boonebgorges.
Fixes #16894.
Built from https://develop.svn.wordpress.org/trunk@34270


git-svn-id: http://core.svn.wordpress.org/trunk@34234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-17 20:01:24 +00:00
Scott Taylor af593128a7 Revert [33925], by-reference array manipulation is breaking comments in some themes. 
This implementation is losing its shine.

See #16894.

Built from https://develop.svn.wordpress.org/trunk@34245


git-svn-id: http://core.svn.wordpress.org/trunk@34209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-16 18:14:25 +00:00
Drew Jaynes b1f176582c Docs: Add changelog entries for parameters where `WP_Comment` object support was added in [33961]. 
See #33638. See #32246.

Built from https://develop.svn.wordpress.org/trunk@34237


git-svn-id: http://core.svn.wordpress.org/trunk@34201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-16 13:52:25 +00:00
Scott Taylor 4139daea5e Apply the new `'respond_link'` filter in `comments_popup_link()` if `$number` is `0` before outputting the URL. 
Props joedolson.
Fixes #29454.

Built from https://develop.svn.wordpress.org/trunk@34216


git-svn-id: http://core.svn.wordpress.org/trunk@34180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-15 20:46:35 +00:00
Scott Taylor 41c5bfb493 Comments: `get_comments_link()` should return a link with `#respond` as the hash instead of `#comments` if `get_comments_number()` returns `0`. 
Props cgrymala, wonderboymusic.
Fixes #19893.

Built from https://develop.svn.wordpress.org/trunk@34075


git-svn-id: http://core.svn.wordpress.org/trunk@34043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-12 07:36:25 +00:00
Scott Taylor b453af5718 When clicking "Show More Comments" in the Comments meta box on the Edit Post screen, change the click behavior to call a new class method on `commentsBox`, `->load()`, that resets `st` (cool name) to the number of visible `<tr>`s before calling `->get()`. This will account for spam'd and trash'd comments when returning comments at the proper offset. 
Props utkarshpatel.
Fixes #33829.

Built from https://develop.svn.wordpress.org/trunk@34069


git-svn-id: http://core.svn.wordpress.org/trunk@34037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-12 02:28:26 +00:00
Scott Taylor fc328f5484 After [33961], pass `$comment` to `get_comment_author_link()` where possible to avoid extra cache/db lookups. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@34039


git-svn-id: http://core.svn.wordpress.org/trunk@34007 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 06:05:24 +00:00
Scott Taylor 592f3d9c6c After [33961], ensure that comment filters that expect a comment ID are receiving one. 
Props dimadin.
Fixes #33809.

Built from https://develop.svn.wordpress.org/trunk@34008


git-svn-id: http://core.svn.wordpress.org/trunk@33977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-10 18:10:25 +00:00
Scott Taylor d973339738 After [33891], `get_comment()` returns `global $comment` if no args are passed and the global is set (after setting the default to `null` here). This allows us to ditch global comment imports. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33963


git-svn-id: http://core.svn.wordpress.org/trunk@33932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 02:51:24 +00:00
Scott Taylor 67f90df6a4 `Walker_Comment` should be in its own file. Loaded now via `wp-includes/comment.php`, which makes it 100% BC. 
See #33413.

Built from https://develop.svn.wordpress.org/trunk@33962


git-svn-id: http://core.svn.wordpress.org/trunk@33931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 02:41:24 +00:00
Scott Taylor 433c786bde After [33891], a lot of comment functions can take `WP_Comment` instead of only accepting `comment_ID`. Update the `@param` docs to reflect this. 
See #33638.

Built from https://develop.svn.wordpress.org/trunk@33961


git-svn-id: http://core.svn.wordpress.org/trunk@33930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-09 02:34:24 +00:00
Scott Taylor c231add9fe In `wp_list_comments()`, update the comment meta cache when the comments derive from `WP_Query` and the new `->comment_meta_cached` prop is `false`. 
There are no uses of `wp_list_comments()` in Core where `$comments` are passed as the 2nd argument.

Adds unit tests.

Props wonderboymusic, bradt.
Fixes #16894.

Built from https://develop.svn.wordpress.org/trunk@33925


git-svn-id: http://core.svn.wordpress.org/trunk@33894 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 22:25:24 +00:00
Sergey Biryukov 695d3ee98b Merge two strings in `Walker_Comment::comment()` and `Walker_Comment::html5_comment()`. 
Props pavelevap.
Fixes #33744.
Built from https://develop.svn.wordpress.org/trunk@33919


git-svn-id: http://core.svn.wordpress.org/trunk@33888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-05 20:46:24 +00:00
Scott Taylor e73ee5ac98 Introduce `WP_Comment` class to model/strongly-type rows from the comments database table. Inclusion of this class is a pre-req for some more general comment cleanup and sanity. 
* Takes inspiration from `WP_Post` and adds sanity to comment caching. 
* Clarifies when the current global value for `$comment` is returned. The current implementation in `get_comment()` introduces side effects and an occasion stale global value for `$comment` when comment caches are cleaned.
* Strongly-types `@param` docs
* This class is marked `final` for now

Props wonderboymusic, nacin.

See #32619.

Built from https://develop.svn.wordpress.org/trunk@33891


git-svn-id: http://core.svn.wordpress.org/trunk@33860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-03 18:17:24 +00:00
Sergey Biryukov f59f2a8e4f Restore `rel='nofollow'` for comment reply links to reduce extra crawling by search engines. 
This reverts [16230], which didn't have enough review at the time of commit.

props joostdevalk.
see #22889, #18547, #16881.
Built from https://develop.svn.wordpress.org/trunk@33047


git-svn-id: http://core.svn.wordpress.org/trunk@33018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-02 11:09:25 +00:00
Mark Jaquith cf38b016e8 Revert [33038] because of objections raised on #22889 and #31590 
Built from https://develop.svn.wordpress.org/trunk@33042


git-svn-id: http://core.svn.wordpress.org/trunk@33013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-02 00:47:24 +00:00
Mark Jaquith d51f1c1a0f Restore `$noreplytext` default value in `comment_form_title()` 
props ocean90
see #22889
Built from https://develop.svn.wordpress.org/trunk@33039


git-svn-id: http://core.svn.wordpress.org/trunk@33010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-01 21:51:25 +00:00
Mark Jaquith 9d11efe23c Say goodbye to ?replytocom=123 links and their URL pollution. 
* Comment reply links continue to use JS as before.
* ?replytocom=123 links are deprecated.

props joostdevalk
fixes #22889
Built from https://develop.svn.wordpress.org/trunk@33038


git-svn-id: http://core.svn.wordpress.org/trunk@33009 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-01 21:42:25 +00:00
Konstantin Obenland 898bb2ed34 Remove allowed tags from comment form. 
It can be confusing to users and for most it is not relevant.
Commenters comfortable with HTML will know which tags are likely
to be accepted.

Props krogsgard, rachelbaker.
Fixes #30157.


Built from https://develop.svn.wordpress.org/trunk@32858


git-svn-id: http://core.svn.wordpress.org/trunk@32829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 14:15:26 +00:00
Scott Taylor d71d2c062e In `get_comment_reply_link()`, when generating the reply link, add the `replytocom` query arg to the result of `get_permalink()` on the current `$post`, instead of the current global request URI. 
Props nazmul.hossain.nihal.
Fixes #31333.

Built from https://develop.svn.wordpress.org/trunk@32786


git-svn-id: http://core.svn.wordpress.org/trunk@32757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-16 00:19:25 +00:00
Andrew Nacin 7080c8e24b Update comment caches in WP_Comment_Query, rather than comments template. 
props dd32.
fixes #31081.

Built from https://develop.svn.wordpress.org/trunk@32769


git-svn-id: http://core.svn.wordpress.org/trunk@32740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 19:21:25 +00:00
Scott Taylor bd8fafea54 Use `void` instead of `null` where appropriate when pipe-delimiting `@return` types. If a `@return` only contains `void`, remove it. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32568


git-svn-id: http://core.svn.wordpress.org/trunk@32538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-24 05:40:25 +00:00
Scott Taylor 876918dc53 Add missing doc blocks to `comment-template.php`. 
See #32444.

Built from https://develop.svn.wordpress.org/trunk@32567


git-svn-id: http://core.svn.wordpress.org/trunk@32537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-24 05:19:24 +00:00
Sergey Biryukov 96f787260f In `comment_form()`, ensure that filtered arguments contain all required default values. 
props boonebgorges.
fixes #32312 for trunk.
Built from https://develop.svn.wordpress.org/trunk@32511


git-svn-id: http://core.svn.wordpress.org/trunk@32481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-19 01:04:25 +00:00
Sergey Biryukov ed0da72d97 Replace `echo __()` with `_e()`. 
props marsjaninzmarsa.
fixes #32239.
Built from https://develop.svn.wordpress.org/trunk@32333


git-svn-id: http://core.svn.wordpress.org/trunk@32304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-03 16:18:28 +00:00
Helen Hou-Sandí 3fdd3ba9b5 Don't add a class for comment authors who are members of the current site. 
Reverts [32245] and [31518]. We'll keep the whitespace and comment clarification, though.

see #24054.

Built from https://develop.svn.wordpress.org/trunk@32259


git-svn-id: http://core.svn.wordpress.org/trunk@32230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-21 23:36:25 +00:00
Helen Hou-Sandí f8c7817077 Comment: rename the `comment-author-is-site-member` class to `bysiteuser` for consistency. 
Final decision on keeping the class yet to be made.

props DrewAPicture.
see #24054.

Built from https://develop.svn.wordpress.org/trunk@32245


git-svn-id: http://core.svn.wordpress.org/trunk@32216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-21 14:20:25 +00:00
Drew Jaynes 88906c324b Remove backtick-escaping around a core function in the hook docs for the `comment_form_submit_field` filter. 
See [31699]. See #31888.

Built from https://develop.svn.wordpress.org/trunk@32037


git-svn-id: http://core.svn.wordpress.org/trunk@32016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-05 15:39:29 +00:00
Dominik Schilling 7de1a2e143 Comments: Move HTML tags for screen reader text into translatable strings. 
Placeholders aren't helpful and it's much easier to make a mistake if you're dealing with placeholders.
Introduced in [31388].

props pento.
fixes #26553.
Built from https://develop.svn.wordpress.org/trunk@31821


git-svn-id: http://core.svn.wordpress.org/trunk@31803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-18 21:52:27 +00:00
Drew Jaynes 110d60c6cf Add a changelog entry to the DocBlock for `comment_form()` for the `class_submit` argument added in 4.1. 
See [29809]. See #20446.

Built from https://develop.svn.wordpress.org/trunk@31803


git-svn-id: http://core.svn.wordpress.org/trunk@31785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-17 18:38:29 +00:00
Boone Gorges 7e7a0304d2 Improved customizability for the Submit button in `comment_form()`. 
The new 'submit_button' and 'submit_field' parameters for `comment_form()`
allow developers to modify the markup of the submit button and its wrapper.
These params are accompanied by targeted 'comment_form_submit_button' and
'comment_form_submit_field' filters on the concatenated markup.

Props coffee2code, morpheu5, DrewAPicture, boonebgorges.
Fixes #15015.
Built from https://develop.svn.wordpress.org/trunk@31699


git-svn-id: http://core.svn.wordpress.org/trunk@31680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-03-10 19:08:26 +00:00
Jeremy Felt 646e643e5d Add `comment-author-is-site-member` class to comment output for site members. 
Add a class to allow targeting of comments made by members of a site rather than users of the entire network.

Props Viper007Bond, MikeHansenMe.

Fixes #24054.

Built from https://develop.svn.wordpress.org/trunk@31518


git-svn-id: http://core.svn.wordpress.org/trunk@31499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-23 02:52:24 +00:00
Sergey Biryukov 612b9e8ffd Replace hardcoded usage of `comment-page` with the comment pagination base. 
props johnbillion, SergeyBiryukov, webord.
fixes #18084.
Built from https://develop.svn.wordpress.org/trunk@31459


git-svn-id: http://core.svn.wordpress.org/trunk@31440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-14 03:48:27 +00:00
Sergey Biryukov 7ff18dae4e Add `.comment-reply-login` class to `get_post_reply_link()`, for consistency with `get_comment_reply_link()`. 
props johnjamesjacoby.
fixes #31298.
Built from https://develop.svn.wordpress.org/trunk@31412


git-svn-id: http://core.svn.wordpress.org/trunk@31393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-11 16:11:28 +00:00
Sergey Biryukov 973d157615 Switch to a string placeholder, as `number_format_i18n()` returns a string. 
see #26553.
Built from https://develop.svn.wordpress.org/trunk@31402


git-svn-id: http://core.svn.wordpress.org/trunk@31383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 05:45:28 +00:00
Sergey Biryukov fdfd15aacc Use `_n()` in `comments_popup_link()` when setting the default string to display if there are more than one comment. 
see #26553.
Built from https://develop.svn.wordpress.org/trunk@31401


git-svn-id: http://core.svn.wordpress.org/trunk@31382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-10 02:51:28 +00:00
Aaron Jorbin c99149419d Add translator comments for new strings. 
These strings were added in [31388].

Props ocean90.
Fixes 26553.


Built from https://develop.svn.wordpress.org/trunk@31389


git-svn-id: http://core.svn.wordpress.org/trunk@31370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 20:15:27 +00:00
Aaron Jorbin 4f08e9d383 Use screen reader text instead of a title attribute in comments_popup_link 
To better understand screen reader text, check out https://make.wordpress.org/accessibility/2015/02/09/hiding-text-for-screen-readers-with-wordpress-core/

Screen Reader text improves the user experience for screen reader users. It provides additional context for links, document forms and other pieces of a page that may exist visually, but are lost when looking only at the html of a site.  This does change the output of comments_popup_link if you don't pass in values for $zero, $one, $more or $none. Theme authors can and should style <code>.screen-reader-text</code> in ways that are recommended in the above article to hide it visually.

Props joedolson
Fixes #26553




Built from https://develop.svn.wordpress.org/trunk@31388


git-svn-id: http://core.svn.wordpress.org/trunk@31369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-09 19:27:28 +00:00
Scott Taylor 5f9a800110 In `comment_form()`, add the HTML5 `required` attribute next to `aria-required` in fields that utilize it. 
Props MMN-o.
Fixes #24732.

Built from https://develop.svn.wordpress.org/trunk@31204


git-svn-id: http://core.svn.wordpress.org/trunk@31185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 15:56:23 +00:00
Sergey Biryukov 6e29458407 Remove a redundant inline comment with a typo. 
props nicnicnicdevos.
fixes #30956.
Built from https://develop.svn.wordpress.org/trunk@31103


git-svn-id: http://core.svn.wordpress.org/trunk@31084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 21:29:24 +00:00
Scott Taylor 60b0cd7943 The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 07:05:25 +00:00
Scott Taylor f5f3006981 Remove whitespace side effects from `comment_form()`. 
Props timersys.
Fixes #30500.

Built from https://develop.svn.wordpress.org/trunk@31036


git-svn-id: http://core.svn.wordpress.org/trunk@31017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-03 06:27:24 +00:00
Drew Jaynes ad297dab6d Correctly capitalize JavaScript throughout core docs. 
Fixes #30569.

Built from https://develop.svn.wordpress.org/trunk@30695


git-svn-id: http://core.svn.wordpress.org/trunk@30685 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-02 00:31:22 +00:00
Scott Taylor e619abda6e Improve various `@param` docs for `src/wp-includes/*`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30681


git-svn-id: http://core.svn.wordpress.org/trunk@30671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 01:34:24 +00:00
Drew Jaynes bffe95d34c Docs Formatting: Backtick-escape inline code for all remaining dynamic hook docs in wp-includes/*. 
Affects DocBlocks for the following hooks:
* `auth_post_meta_{$meta_key}`
* `term_links-$taxonomy`
* `customize_render_control_ . $this->id`
* `customize_render_panel_{$this->id}`
* `customize_render_section_{$this->id}`
* `customize_preview_{$this->id}`
* `customize_save_ . $this->id_data[ 'base' ]`
* `customize_update_ . $this->type`
* `customize_value_ . $this->id_data[ 'base' ]`
* `customize_sanitize_js_{$this->id}`
* `comment_form_field_{$name}`
* `comment_{$old_status}_to_{$new_status}`
* `comment_{$new_status}_{$comment->comment_type}`
* `extra_{$context}_headers`
* `get_template_part_{$slug}`
* `get_the_generator_{$type}`
* `get_{$adjacent}_post_join`
* `get_{$adjacent}_post_where`
* `get_{$adjacent}_post_sort`
* `{$adjacent}_post_rel_link`
* `{$adjacent}_post_link`
* `{$adjacent}_image_link`
* `blog_option_{$option}`
* `$permastructname . _rewrite_rules`
* `{$type}_template`
* `theme_mod_{$name}`
* `pre_set_theme_mod_$name`
* `current_theme_supports-{$feature}`
* `get_user_option_{$option}`
* `edit_user_{$field}`
* `pre_user_{$field}`
* `user_{$field}`

See #30552.

Built from https://develop.svn.wordpress.org/trunk@30656


git-svn-id: http://core.svn.wordpress.org/trunk@30646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-30 12:10:23 +00:00
Drew Jaynes 4432dc752b 4.1 Docs Audit: Various formatting fixes for inline documentation in class-wp-list-table.php and comment-template.php. 
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30610


git-svn-id: http://core.svn.wordpress.org/trunk@30600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-28 11:22:23 +00:00
Peter Westwood 6c40c6f2e2 Fix the passing of commenter cookie data to the comment API so that we don't try and fetch all unapproved comments for users with no-email address when we only have an author. 
Fixes #19623

Built from https://develop.svn.wordpress.org/trunk@30547


git-svn-id: http://core.svn.wordpress.org/trunk@30536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 10:51:22 +00:00
Drew Jaynes de809a5a86 Ensure inline code is markdown-escaped as such, HTML tags are removed from summaries, and that code snippets in descriptions are properly indented. 
Affects DocBlocks for the following core elements:
* Remove HTML tag from parameter description in `comment_form()`
* Remove HTML tag from a summary for the `comment_form_top` hook
* Markdown-indent a code snippet in the description for `get_linkobjectsbyname()`
* Markdown-indent a code snippet and format an unordered list in the description for `get_linkobjects()`
* Backtick-escape some inline code in the description for `clean_pre()`
* Remove HTML tag from the summary for the `rss_tag_pre` hook
* Various formatting fixes in the descriptions for `get_filesystem_method()` and `request_filesystem_credentials()`

Props rarst for the initial patch.
See #30473.

Built from https://develop.svn.wordpress.org/trunk@30538


git-svn-id: http://core.svn.wordpress.org/trunk@30527 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-24 05:19:23 +00:00
Drew Jaynes 39a44f62ad Update the changelogs for the comment hook parameters added in [30092]. 
Parameters were added to the `get_comment_author`, `comment_author`, `get_comment_author_email`, `author_email`, `comment_email`, `get_comment_author_link`, `get_comment_author_IP`, `get_comment_author_url`, `comment_url`, `get_comment_excerpt`, `comment_excerpt`, `get_comment_ID`, and `get_comment_type` filters.

Fixes #22380.

Built from https://develop.svn.wordpress.org/trunk@30111


git-svn-id: http://core.svn.wordpress.org/trunk@30111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-30 03:52:22 +00:00
Peter Westwood 664f19e28a Comment Template Tags: Improve the availability of context information in comment template tag filters. 
Fixes #22380 props momo360modena, tareq1988.

Built from https://develop.svn.wordpress.org/trunk@30092


git-svn-id: http://core.svn.wordpress.org/trunk@30092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-29 19:07:22 +00:00
Sergey Biryukov 0c2c7ad204 Add 'comment_reply_link_args' filter for get_comment_reply_link() arguments. 
props joedolson, aaroncampbell, DrewAPicture.
fixes #10569.
Built from https://develop.svn.wordpress.org/trunk@30039


git-svn-id: http://core.svn.wordpress.org/trunk@30039 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-27 11:45:18 +00:00
Boone Gorges 304802d70d Use the comment API rather than direct SQL queries in `comments_template()`. 
`comments_template()` is used by most themes to display a post's comments. It
shows all comments that have been approved, and also shows all pending comments
by the current visitor (as determined by the comment cookies). However, the
comments API previously had no way of querying for "all comments that are
either approved, or are unapproved but written by foo@example.com". The
workaround was a direct SQL query: uncached, not subject to the same filters as
other comment queries, and just generally icky.

The new `include_unapproved` parameter for `WP_Comment_Query` accepts an array
of user IDs or email addresses. Pending comments associated with users in this
array will be included in query results, regardless of the value of the 'status'
parameter. In `comments_template()`, we leap from direct SQL queries to
`get_comments()` plus `include_unapproved', striving to put right what once
went wrong.

Props boonebgorges, simonwheatley, hardy101, jesin.
Fixes #19623.
Built from https://develop.svn.wordpress.org/trunk@29965


git-svn-id: http://core.svn.wordpress.org/trunk@29712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-19 19:39:20 +00:00
Dominik Schilling bf16aac8e1 Comments: Don't print an empty HTML markup when `comment_reply_link()` returns no link. 
props obenland.
fixes #29895.
Built from https://develop.svn.wordpress.org/trunk@29908


git-svn-id: http://core.svn.wordpress.org/trunk@29662 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-15 21:56:19 +00:00
Sergey Biryukov 965b6d54b6 Add aria-describedby attributes to comment_form(). 
props joedolson, bramd.
fixes #24148.
Built from https://develop.svn.wordpress.org/trunk@29846


git-svn-id: http://core.svn.wordpress.org/trunk@29609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-06 22:11:15 +00:00
Sergey Biryukov 6d0f2dcf11 Make link construction in get_comment_reply_link() and get_post_reply_link() more readable. 
see #16433.
Built from https://develop.svn.wordpress.org/trunk@29823


git-svn-id: http://core.svn.wordpress.org/trunk@29589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-02 20:45:16 +00:00
Sergey Biryukov 70c88e59b1 Add an aria-label attribute with commenter's name to get_comment_reply_link(). 
props joedolson, merty, andrewryno.
fixes #16433.
Built from https://develop.svn.wordpress.org/trunk@29822


git-svn-id: http://core.svn.wordpress.org/trunk@29588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-02 20:41:16 +00:00
Sergey Biryukov 0797823c55 Add a class attribute for submit button in comment form. 
props bainternet.
fixes #20446.
Built from https://develop.svn.wordpress.org/trunk@29809


git-svn-id: http://core.svn.wordpress.org/trunk@29575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-02 01:44:15 +00:00
Scott Taylor 0005433983 Correct a few `@param` docs for `$walker`. 
Props dnaber-de.
Fixes #29011.

Built from https://develop.svn.wordpress.org/trunk@29293


git-svn-id: http://core.svn.wordpress.org/trunk@29075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-24 22:25:16 +00:00
Drew Jaynes c5a59037f1 Inline documentation cleanup for 4.0 audit. 
Various improvements:
* Adds `@see` reference for `wp_list_comments()` in 'wp_list_comments_args' filter docs, added in [28285]
* Various phpDoc tweaks for the 'run_wptexturize' filter docs, added in [28715]
* Sentence and wrapping changes for `is_https_url()`, added in [28894]
* Documents the `$args` parameter for `wp_dropdown_languages()`, added in [29007]
* Adds a period to the parameter description for `_update_posts_count_on_delete()`, added in [28835]
* Documents a global in `is_customize_preview()`, added in [28999]
* phpDoc tweaks, adds an access modifier for `wpdb::esc_like()`, added in [28711]

See #28885.

Built from https://develop.svn.wordpress.org/trunk@29163


git-svn-id: http://core.svn.wordpress.org/trunk@28947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 01:02:15 +00:00
Scott Taylor ef436cb6e0 Revert [28563]. See #18298. 
Built from https://develop.svn.wordpress.org/trunk@29044


git-svn-id: http://core.svn.wordpress.org/trunk@28832 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-09 18:07:16 +00:00
Drew Jaynes d4dd02b4ae Remove backticks on `$post` variables in some short parameter descriptions. 
See [28653], [28654].
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28976


git-svn-id: http://core.svn.wordpress.org/trunk@28765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-03 19:28:14 +00:00
Scott Taylor 21864a98d0 Add a function, `get_comments_number_text()`, that returns instead of echoing. `comments_number()` wraps it. 
Props kapeels, nbachiyski.
Fixes #10177.

Built from https://develop.svn.wordpress.org/trunk@28912


git-svn-id: http://core.svn.wordpress.org/trunk@28711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-29 23:13:15 +00:00
Scott Taylor 0ba605c55c Ensure that a `has_children` parameter is given to `Walker::start_el()`. 
Adds unit tests.

Props scribu, obenland.
Fixes #14041.

Built from https://develop.svn.wordpress.org/trunk@28824


git-svn-id: http://core.svn.wordpress.org/trunk@28628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 17:06:14 +00:00
Scott Taylor 919ff69120 In `comment_form()`, allow `name_submit` to be passed to change the `name` attribute of the submit button. 
Props obenland.
Fixes #22792.

Built from https://develop.svn.wordpress.org/trunk@28813


git-svn-id: http://core.svn.wordpress.org/trunk@28620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-24 00:10:15 +00:00
Drew Jaynes 3724252959 Ensure `$post_id` is documented as optional where applicable. 
See #28388.

Built from https://develop.svn.wordpress.org/trunk@28654


git-svn-id: http://core.svn.wordpress.org/trunk@28472 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-03 04:44:16 +00:00
Scott Taylor 2d6721dbc9 Fix an error caused by [28604] in `get_comments_number()` unit tests. 
Props SergeyBiryukov.
Fixes #26240.


Built from https://develop.svn.wordpress.org/trunk@28638


git-svn-id: http://core.svn.wordpress.org/trunk@28456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-30 19:47:14 +00:00
Dominik Schilling d40280d0db Pass `$post->ID` to `get_comments_number` filter. 
Also fixes indentation and a typo in corresponding filter docs.

see #26240.
Built from https://develop.svn.wordpress.org/trunk@28604


git-svn-id: http://core.svn.wordpress.org/trunk@28428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-28 22:36:15 +00:00
Drew Jaynes 6989c5ab46 Fix parameter description for the `$post_id` argument in `get_comments_number()` to note that it is optional. 
Also fixes the corresponding filter docs, as `$post_id`, not `$post` is passed to the filter.

See [27156]. Fixes #26240.

Built from https://develop.svn.wordpress.org/trunk@28602


git-svn-id: http://core.svn.wordpress.org/trunk@28427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-28 22:05:18 +00:00
Scott Taylor b75c79500b Replaces all uses of `TEMPLATEPATH` and `STYLESHEETPATH` in core with `get_template_directory()` and `get_stylesheet_directory()`. 
Add `@deprecated` annotations to `TEMPLATEPATH` and `STYLESHEETPATH` definitions.

Props obenland, aaroncampbell. 
Fixes #18298.

Built from https://develop.svn.wordpress.org/trunk@28563


git-svn-id: http://core.svn.wordpress.org/trunk@28389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 20:12:15 +00:00
Scott Taylor e8181b0934 Allow `get_comments_number()` to officially accept `$post` or `$post_id`. Adds unit tests. 
Props coffee2code, JanHenkG.
Fixes #26240.

Built from https://develop.svn.wordpress.org/trunk@28558


git-svn-id: http://core.svn.wordpress.org/trunk@28384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-23 17:44:14 +00:00
Scott Taylor dfa4de15fa Add missing access modifiers to methods/members in `Walker` and subclasses. Add a magic `__get()` method. 
See #27881, #22234.

Built from https://develop.svn.wordpress.org/trunk@28514


git-svn-id: http://core.svn.wordpress.org/trunk@28340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-19 06:00:15 +00:00
Scott Taylor 78b6f2761d Eliminate use of `extract()` in `get_comment_reply_link()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28431


git-svn-id: http://core.svn.wordpress.org/trunk@28258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 15:35:15 +00:00
Scott Taylor 7943f4715a Eliminate the use of `extract()` in `get_post_reply_link()`. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28429


git-svn-id: http://core.svn.wordpress.org/trunk@28256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 06:49:14 +00:00
Scott Taylor 0e2909ce89 Eliminate the use of `extract()` in `wp_list_comments()`. All unit tests pass. 
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28428


git-svn-id: http://core.svn.wordpress.org/trunk@28255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-15 06:43:15 +00:00
Scott Taylor de262f553c In `wp-includes/comment-template.php`, remove dead code: 
* In `get_comment_reply_link()`, `$link` is set twice before it is used.
* In `Walker_Comment::start_lvl()`, `case 'ul':` is unreachable unless placed before `default:`. 
* In `Walker_Comment::end_lvl()`, `case 'ul':` is unreachable unless placed before `default:`.
* In `comment_form()`, `$id` is conditionally set and never used. 

See #27882.


Built from https://develop.svn.wordpress.org/trunk@28323


git-svn-id: http://core.svn.wordpress.org/trunk@28151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 21:15:17 +00:00
Sergey Biryukov d70e8a38fa Add a filter for wp_list_comments() arguments. 
props greenshady, hlashbrooke.
fixes #19581.
Built from https://develop.svn.wordpress.org/trunk@28285


git-svn-id: http://core.svn.wordpress.org/trunk@28113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 11:58:14 +00:00
Drew Jaynes 5e51ea9940 Priority fixes for various existing hook documentation. 
Props kpdesign.
See #26869

Built from https://develop.svn.wordpress.org/trunk@28083


git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-12 00:01:15 +00:00
Drew Jaynes acf9fbc808 Remove a blank line and @global reference in the PHPDoc for `comment_author_email_link()`. 
Props norcross, ocean90.
Fixes #27655.

Built from https://develop.svn.wordpress.org/trunk@27943


git-svn-id: http://core.svn.wordpress.org/trunk@27773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-04 04:36:15 +00:00
Andrew Nacin 502ac958e5 Pass walker arguments to get_comment_link() so pagination works when wp_list_comments() is used outside the comment template. 
props SergeyBiryukov.
fixes #27007.

Built from https://develop.svn.wordpress.org/trunk@27799


git-svn-id: http://core.svn.wordpress.org/trunk@27634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-28 02:38:14 +00:00
Sergey Biryukov 8343fabff6 Avoid a notice in trackback_rdf() if user agent is not set. 
props joostdevalk.
fixes #27374.
Built from https://develop.svn.wordpress.org/trunk@27514


git-svn-id: http://core.svn.wordpress.org/trunk@27357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-12 12:54:15 +00:00
Andrew Nacin 1699153d26 Pass the comment object to the get_comment_date and get_comment_time. 
props SergeyBiryukov.
fixes #19849.

Built from https://develop.svn.wordpress.org/trunk@27283


git-svn-id: http://core.svn.wordpress.org/trunk@27139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-26 16:41:14 +00:00
Drew Jaynes cb8951b0b3 Remove all `@package` and `@subpackage` PHPDoc tags not at the file- or class-levels in core. 
See #27200.

Built from https://develop.svn.wordpress.org/trunk@27262


git-svn-id: http://core.svn.wordpress.org/trunk@27119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 17:14:14 +00:00
Drew Jaynes c8665c5973 Fix a typo in the PHPDoc for `comment_author_email_link()`. 
See #27083.

Built from https://develop.svn.wordpress.org/trunk@27157


git-svn-id: http://core.svn.wordpress.org/trunk@27023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-10 04:07:12 +00:00
Drew Jaynes 8eb2d3610b Inline documentation cleanup in wp-includes/comment-template.php. 
This cleanup follows [25567] and brings the docs in-line with standards that at the time had not yet been finalized.

These changes include
* Moving in-line `@see` tags to their own lines
* Using docs-specific variables in hook docs
* Fixing line-wrapping throughout
* Typos and punctuation
* Converting hash notation values to variables per the standard

Fixes #27083. See #20495.

Built from https://develop.svn.wordpress.org/trunk@27156


git-svn-id: http://core.svn.wordpress.org/trunk@27022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-10 03:20:12 +00:00
Drew Jaynes cd8cedc40d First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin. 
Props JustinSainton, SergeyBiryukov, DrewAPicture.
Fixes #26713.

Built from https://develop.svn.wordpress.org/trunk@26868


git-svn-id: http://core.svn.wordpress.org/trunk@26754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-24 18:57:12 +00:00
Andrew Nacin 808653e2a3 Add echo arguments to wp_list_comments() and Walker_Comment, allowing non-echo usage. 
props mikelittle.
fixes #10948.

Built from https://develop.svn.wordpress.org/trunk@26353


git-svn-id: http://core.svn.wordpress.org/trunk@26254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-24 14:59:10 +00:00
Andrew Nacin d0cfa40983 Add jshintrc to qunit. 
props jorbin.
see #25187.

Built from https://develop.svn.wordpress.org/trunk@25992


git-svn-id: http://core.svn.wordpress.org/trunk@25925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-30 14:39:10 +00:00
Drew Jaynes 15fb059069 Inline documentation for the Walker_Comment class in wp-includes/comment-template.php 
Fixes #25388.

Built from https://develop.svn.wordpress.org/trunk@25588


git-svn-id: http://core.svn.wordpress.org/trunk@25505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-23 23:29:11 +00:00
Drew Jaynes 681b1c35b5 Inline documentation for hooks in wp-includes/comment-template.php. 
Fixes #25396.

Built from https://develop.svn.wordpress.org/trunk@25584


git-svn-id: http://core.svn.wordpress.org/trunk@25501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-23 21:21:09 +00:00
Drew Jaynes 731db6bcb5 Inline documentation for `comment_form()` argument defaults missed in [25573]. 
See #25388.

Built from https://develop.svn.wordpress.org/trunk@25575


git-svn-id: http://core.svn.wordpress.org/trunk@25492 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-23 17:30:08 +00:00
Drew Jaynes fe40604971 Improve inline documentation of arguments for `comment_form()`. 
See #25388.

Built from https://develop.svn.wordpress.org/trunk@25573


git-svn-id: http://core.svn.wordpress.org/trunk@25490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-23 17:16:08 +00:00
Drew Jaynes e4987beba3 Inline documentation improvements for wp-includes/comment-template.php. 
Changes include:
- Existing phpdoc block improvements
- Inclusion of defaults for optional parameters
- Hash-notated argument arrays
- Removal of unnecessary or redundant tagging.

Also standardization of int|WP_Post function parameters.

These changes clear the way toward less redundancy for hook docs in a future ticket.

Still left: Fully documented arguments in `comment_form()` and a pass through Walker_Comment.

See #20495. See #25388.

Built from https://develop.svn.wordpress.org/trunk@25567


git-svn-id: http://core.svn.wordpress.org/trunk@25485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-23 04:16:08 +00:00
Dominik Schilling 8546983da6 Replace !$user_ID with !is_user_logged_in(). props garyc40. see #15508. 
Built from https://develop.svn.wordpress.org/trunk@25562


git-svn-id: http://core.svn.wordpress.org/trunk@25480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-22 10:16:09 +00:00
Scott Taylor 11db0d3b01 Add an `$args` parameter to `comment_text` and `get_comment_text` filters. Adds filter docs. Improve docblocks for `get_comment_text()` and `comment_text()`. 
Props simonwheatley, ericlewis, DrewAPicture.
Fixes #14856. 


Built from https://develop.svn.wordpress.org/trunk@25555


git-svn-id: http://core.svn.wordpress.org/trunk@25475 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-21 18:18:09 +00:00
Drew Jaynes 98d5c50e5f Clarify phpdoc for `get_comment_author_link()`. 
props nofearinc. Fixes #24508.

Built from https://develop.svn.wordpress.org/trunk@25494


git-svn-id: http://core.svn.wordpress.org/trunk@25415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-19 05:56:10 +00:00
Sergey Biryukov 7407bd1946 Inline documentation for get_comment_reply_link() and 'comment_reply_link' filter. 
props DrewAPicture.
fixes #25310.
Built from https://develop.svn.wordpress.org/trunk@25428


git-svn-id: http://core.svn.wordpress.org/trunk@25352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-13 19:20:09 +00:00
Sergey Biryukov 9e9b9b5508 Make sure $args is an array before treating it as such. fixes #25151 for trunk. 
Built from https://develop.svn.wordpress.org/trunk@25151


git-svn-id: http://core.svn.wordpress.org/trunk@25130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-28 05:28:09 +00:00
Andrew Nacin e01352fe2f Ensure a user exists in get_comment_author(). 
props azaozz.
see #24084.

Built from https://develop.svn.wordpress.org/trunk@25136


git-svn-id: http://core.svn.wordpress.org/trunk@25116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-27 13:17:09 +00:00
Andrew Nacin 71af3a2004 Remove pattern="" in the comment form (HTML5 mode) to avoid mistaken :invalid styles. 
This was originally included for Opera 10, but is not needed as of Opera 11, and current is Opera 15.

props jorbin, markjaquith.
fixes #24475.



git-svn-id: http://core.svn.wordpress.org/trunk@24573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-05 21:59:10 +00:00
Dominik Schilling f27e762085 Replace the `cite` element with a `b` element to markup the comment author in comment_html5(). 
In HTML5 the `cite` element isn't valid for just an author's name.
"The cite element represents the title of a work [..] A person's name is not the title of a work" (http://www.w3.org/TR/html5/text-level-semantics.html#the-cite-element)

fixed #24522.

git-svn-id: http://core.svn.wordpress.org/trunk@24539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-01 18:26:16 +00:00
Andrew Nacin ca1e73ca84 Comment form: Add HTML classes. 
* #respond gains .comment-respond
 * #reply-title gains .comment-reply-titlw
 * form gains .comment-form

props obenland.
see #23851.



git-svn-id: http://core.svn.wordpress.org/trunk@24525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-27 21:18:08 +00:00
Andrew Nacin 5969819038 `add_theme_support( 'html5', array( 'comment-list', 'search-form', 'comment-form' ) );' 
props obenland.
see #23850.



git-svn-id: http://core.svn.wordpress.org/trunk@24417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-06 15:31:34 +00:00
Sergey Biryukov 4b13a1ffa4 Fix E_STRICT notices in walkers. props dvarga. see #24356. 
git-svn-id: http://core.svn.wordpress.org/trunk@24377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-28 03:29:15 +00:00
Andrew Nacin 7cc15a2e7f Remove use of global $id from comment_form() and the media list table. see #24330. 
git-svn-id: http://core.svn.wordpress.org/trunk@24337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-23 18:40:16 +00:00
Sergey Biryukov 57c10eadbb Use ellipsis instead of three dots. props tjsingleton, jordie23, wojtek.szkutnik, DrewAPicture, SergeyBiryukov. see #8714. 
git-svn-id: http://core.svn.wordpress.org/trunk@24207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-08 21:27:31 +00:00
Andrew Nacin 92b4636e17 Required arguments can't follow optional arguments. 
Make required arguments optional in confirm_blog_signup().

Mark arguments as required in _future_post_hook(), the walker method display_element(), get_author_link() (deprecated), and the WP_Widget constructor.

props rlerdorf.
see #24210.



git-svn-id: http://core.svn.wordpress.org/trunk@24126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-29 13:26:31 +00:00
Sergey Biryukov 2c63da143b Fix inconsistent spacing in comment_form(). props sim, TravisHoffman. fixes #23878. 
git-svn-id: http://core.svn.wordpress.org/trunk@23932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-07 23:57:35 +00:00
Mark Jaquith b3f6427c6f Improve wp_list_comments() markup. 
* Whitespace cleanup
* Accepts format=html5 which uses some of the HTML5 elements
* Some helpful HTML comments to help untangle the HTML
* Other misc code cleanup

props lancewillett, obenland, georgestephanis. fixes #20088.

git-svn-id: http://core.svn.wordpress.org/trunk@23694 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-14 04:26:04 +00:00
Mark Jaquith a1e32d3217 Add the ability to use HTML5 input types in the comment form. 
props jorbin, georgestephanis, obenland. fixes #15080

git-svn-id: http://core.svn.wordpress.org/trunk@23689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-13 20:31:43 +00:00
Andrew Nacin f994ff39ac Add filters to comments_link_feed(), comment_link(), and get_comments_link(). esc_url() the echoed output of comments_link(). 
props MarcusPope.
fixes #19210.



git-svn-id: http://core.svn.wordpress.org/trunk@23624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-06 19:57:31 +00:00
Ryan Boren 3854fe2e0f Put required field indicators within labels. Update styling of bundled themes to accommodate. Props MikeHansenMe. fixes #21897 
git-svn-id: http://core.svn.wordpress.org/trunk@22123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-05 16:34:32 +00:00
Ryan Boren 359de78b7d Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865 
git-svn-id: http://core.svn.wordpress.org/trunk@22115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-04 18:26:25 +00:00
Ryan Boren faca571a3a Avoid 'Only variables should be assigned by reference' warning. Props wonderboymusic. see #21865 
git-svn-id: http://core.svn.wordpress.org/trunk@22114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-04 18:21:47 +00:00
Ryan Boren cfb35a9d85 Use get_post() instead of global $post. 
Make the $post argument to get_post() optional, defaulting to the current post in The Loop.

Props nacin
see #21309


git-svn-id: http://core.svn.wordpress.org/trunk@21735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-04 16:29:28 +00:00
ryan 7b49ad8493 Introduce get_edit_user_link(). Props scribu, georgestephanis, johnbillion. fixes #14787 see #20307 
git-svn-id: http://core.svn.wordpress.org/trunk@21364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-30 18:30:03 +00:00
ryan 50fc51d8d2 Don't attempt to define the COMMENTS_TEMPLATE constant twice. Props kitchin. fixes #21337 
git-svn-id: http://core.svn.wordpress.org/trunk@21330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-25 17:54:35 +00:00
ryan ef95736bce Set the global comment var before invoking callbacks in wp_list_comments(). Props sirzooro. fixes #21184 
git-svn-id: http://core.svn.wordpress.org/trunk@21324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-25 16:27:48 +00:00
ryan 01dd4131b8 Don't allow unfiltered HTML comments from a frame. Props nacin. fixes #20812 
git-svn-id: http://core.svn.wordpress.org/trunk@20974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-06-01 20:47:08 +00:00
nacin 5ab06c336e In comment_form(), pass the $post_id to comments_open(). props insertvisionhere. fixes #20572. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-30 01:47:22 +00:00
ryan de41bc288b Introduce WP_User::exists(). see #20372 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-04-06 19:18:45 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
ryan 83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-05 20:50:54 +00:00
ryan fd1393ab7a Clear strict notices for the walkers. fixes #19249 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19679 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-04 23:03:46 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-13 23:45:31 +00:00
nacin 30ff37104d Don't use $user_identity global. props duck_. fixes #19146. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-14 21:35:44 +00:00
duck_ e4ed63fc6f Fix typos in documentation (wp-includes/[a-h]). See #18560. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-03 16:02:41 +00:00
ryan 29592dafb6 Pass post id along to *comment_id_fields(). Props natecook. fixes #17193 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-05-05 19:33:47 +00:00
nacin e1eec3925a More @since. props SergeyBiryukov, fixes #15445. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@17071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-20 09:25:21 +00:00
westi e69d948ca4 Revert [16649] - The core output on this is for logged out users only - need to rework this if we want to move the output. See #14510 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-03 09:44:17 +00:00
ryan a031db170f Fix comment_notes_before. Props mrmist. fixes #14510 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16649 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-12-01 16:52:32 +00:00
nbachiyski 368eefd69c comments_number() doesn't need to call get_the_ID(), because get_comments_number() does it if post ID is missing 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-29 17:34:43 +00:00
scribu 41592d266b Remove nofollow on comment reply links. Fixes #10550 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-11-07 01:06:37 +00:00
nacin 0552424317 Revert submit_button() for wp-includes, setup-config, install, login, signup. see [16061], see #15064, fixes #15247. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-29 00:31:27 +00:00
markjaquith fc6e89da45 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 21:56:43 +00:00
nacin a07ec69bce Add a class to 'Your comment is awaiting moderation' in the comment walker and Twenty Ten's callback. fixes #15206. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@16028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-28 03:58:51 +00:00
nacin 76b4a3cac7 Pass comment ID from comment_text to get_comment_text. Also add the comment object as context to the filter. fixes #14261 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-25 03:11:01 +00:00
nacin 5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-09-07 11:21:11 +00:00
nacin 650f97e684 Adjustments to [15549]. See #11624. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-09-04 15:51:04 +00:00
scribu 950901ca92 Don't use the global anymore. Fixes #11624 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15549 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-08-28 11:57:28 +00:00
westi 64100e8783 Fix the theme compat file require paths to be fully absolute so they don't rely on a particular php path to work. Fixes #14315 for trunk props dougal. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-07-16 09:40:09 +00:00
nacin 69b10a2948 Restore trackback_rdf(). reverts [13991]. fixes #11139 for trunk. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-07-03 05:55:04 +00:00
dd32 a14d289755 Alot more tabs. Props jacobsantos & Viper007bond. See #14147 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-30 00:05:18 +00:00
nacin f60838c8f9 s/echos/echoes/ in phpdoc. props demetris, fixes #13742. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-06 05:16:32 +00:00
nacin 249a6cdd18 Use p instead of definition list for allowed tags in comment_form(). props demetris. Style the new markup in Twenty Ten. see #10910. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-16 06:38:58 +00:00
nacin a03dfef3fd Fix typos in phpdoc for comment_form(). props demetris, fixes #10910. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-10 08:47:13 +00:00
ryan 7b7243d94a Strip trailing whites. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-03 20:26:11 +00:00
nbachiyski 2a1d6e141b Take out the leading space from the translatable string 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-03 18:48:33 +00:00
ryan 172aa06718 Revert [14347] and [14372]. It broke more than we expected. Try again in 3.1. see #13051 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-03 18:16:22 +00:00
westi ae468d52ac First pass of compatibility code for old themes which relied on using templates from the default theme without expressly identifying it as the parent theme. 
Fixes #12425 and #13009.
The fallback to these template files is now depreceated and will be removed in a future version.


git-svn-id: http://svn.automattic.com/wordpress/trunk@14365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-03 09:57:24 +00:00
ryan 91354eefee Escape links by default. Props alexkingorg. see #13051 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-02 22:53:59 +00:00
westi 90873d5063 Revert [14268] - It is much better to use JavaScript for this kind of enhancement. Output buffering is too fragile. See #12564. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-28 07:17:20 +00:00
nacin b8b6090959 Add full HTML filter to comment_form(), along with an echo arg. props joostdevalk, fixes #12564. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-28 04:28:51 +00:00
nacin e9602ae765 Clarify language for non-publication of emails. props lloydbudd, fixes #13026. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-23 15:01:21 +00:00
nacin 6bad016e80 Switch to simpler language regarding publication of email addresses in comment_form() template. props bumbu, see #13026. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-18 04:49:19 +00:00
dd32 7058bb3db8 Respect the comment ID parameter in comment_excerpt(). Props tenpura. Fixes #12874 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14128 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-18 03:45:24 +00:00
nacin e8c8ef08f0 Move stray closing p tag out of a translation. props chrisbliss18, fixes #13036. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-16 22:27:37 +00:00
nacin 045c407a3c Remove tabindex from comment_form(). fixes #12963 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-16 18:29:39 +00:00
nacin c229cdcba7 Spacing/coding cleanup of comment_form(). see #13016. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-15 16:25:08 +00:00
nacin b8917ef747 Update the html comments in comment_form(). props iandstewart, fixes #13016. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-15 16:16:51 +00:00
ryan 687ce2919f Use WP_FALLBACK_THEME instead of default. Props MichaelH. see #12846 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-13 21:56:57 +00:00
nacin ccb93ac4c7 Add @since. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-11 15:23:20 +00:00
dd32 442d41291a Tweak new strings for better typography. Props demetris. Fixes #12962 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-11 10:41:54 +00:00
dd32 9cd8dd44c6 Introduce get_comment_id_fields() as a Getter for comment_id_fields(). Introduce a filter on the output to add extra fields. Props zoranzaric. Fixes #12893 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-11 08:56:18 +00:00
nacin 1a4a30fcf1 Deprecate trackback_rdf(). fixes #11139 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-04 10:04:56 +00:00
dd32 0025a953ac Reduce Code duplication. Rely on parent class to do the heavy lifting, just tack the comment addition on the end. See #8841 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-02 05:33:18 +00:00
dd32 364faf559e Move children of nested levels not shown to after the current element, not inside it like children. See #8841 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-02 05:13:57 +00:00
dd32 1d0b284a7c Fix out-of-order comments when comment nesting is reduced. Displays child comments on the same level after its "parent" in the case that the max_depth has been hit. See #8841 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-04-02 04:05:01 +00:00
nacin a7feaed0e6 Change @since 3.0 to @since 3.0.0. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-26 19:13:36 +00:00
nacin 8c8bf5039f Remove unnecessary ternary operators such as (expr) ? true : false. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-03-19 21:15:00 +00:00
dd32 cb8fd85d1e Prefer $comment::comment_post_ID over $post global. Fixes #12217 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-25 07:56:25 +00:00
nacin 8bcc5969dc Spelling and grammar fun. Fixes #11875 props cnorris23 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-24 20:13:23 +00:00
ryan dbfb51c6e0 Trim trailing whites 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-21 00:03:42 +00:00
dd32 679250491d Variable Cleanup, Unused variables, Typo'd variables, unused code blocks. Fixes #12299 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-20 02:01:46 +00:00
ryan a48e17cca1 Comment form output tweaks. Props beaulebens. see #10910 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-17 19:28:03 +00:00
ryan 88f317209e Add optional post ID arg to get_comments_link(). Props scribu. fixes #12249 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-16 17:54:19 +00:00
ryan b34fd9b448 Change comment_form() markup to match twentyten. Props beaulebens. see #10910 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13030 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-08 20:54:29 +00:00
ryan 4f4d2d446d Use comment_form instead of comments_form as the name of the hook. Props greenshady. see #10910 
git-svn-id: http://svn.automattic.com/wordpress/trunk@13028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-02-08 18:27:02 +00:00
ryan 699387f747 Remove trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-26 22:49:05 +00:00
ryan dd69637c65 Add optional comment ID argument to comment template functions. Props filosofo. fixes #12006 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-25 17:34:13 +00:00
ryan 44ba9a0ec0 Update @since. see #10910 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-23 18:13:31 +00:00
ryan 41eeb07634 comment_form(), first pass. Props beaulebens. see #10910 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-23 18:06:37 +00:00
ryan 94859834fc i18n fixes. Props nbachiyski. fixes #11954 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-21 21:37:43 +00:00
westi bf4a5241e1 Add missing version numbers to _deprecated_argument() calls. 
Remove deprecated argument from xfn_check() calls.
Pass version number to deprecated_file_included, deprecated_function_run and deprecated_argument_run actions.
Fixes #11386 props nacin.

git-svn-id: http://svn.automattic.com/wordpress/trunk@12680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-09 10:03:55 +00:00
westi f05ee1844f Switch to passing arrays instead of query strings to functions. Fixes #6647 props filosofo and hakre. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-08 08:34:39 +00:00
ryan ec8e347792 Introduce home_url(). Props Denis-de-Bernardy, hakre. see #9008 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-01-04 17:23:29 +00:00
westi 0163da57c4 Don't pass deprecated argument to comments_number(). 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-30 16:54:28 +00:00
westi ff7831207c Updates and improvements to _depreceated_argument. See #11386 props nacin. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-30 16:23:39 +00:00
westi 47a7b1b003 Fix typo in _deprecated_argument() and start using _deprecated_argument() in wp-includes files. See #11386 props nacin. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12537 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-24 11:12:04 +00:00
azaozz 72990cd094 Add another arg to 'get_comment_time' filter, props miqrogroove, fixes #11421 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-14 10:21:58 +00:00
markjaquith 182ec07a44 Strip HTML from comments_popup_link title attribute. props ewestp, xenlab. fixes #10997 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-12-10 09:13:11 +00:00
markjaquith 57b5a0cc30 Fix wp_list_comments() ol/ul/div logic oversight. props junsuijin. fixes #10742 
git-svn-id: http://svn.automattic.com/wordpress/trunk@12045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-10-15 21:47:35 +00:00
ryan 8e3808bce2 Remove trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-14 14:03:32 +00:00
azaozz 0c521408ba Pass Post ID to the get_comments_number filter, props sirzooro, fixes #10705 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11895 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-09-01 20:27:03 +00:00
ryan 91ef366300 Don't show comments template if post is empty 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-18 19:33:56 +00:00
ryan 8513b29792 Prophylactic escapes 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-08-18 16:05:07 +00:00
ryan af409e2dae esc_url() for () 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-20 01:41:05 +00:00
ryan 3e73668bca sanitize_comment_cookie() handles the attribute escaping, so remove the extra escaping and leave the phpdoc. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-20 01:22:25 +00:00
ryan 1466e9954b Escape , , and for use in attributes by default since so many themes don't escape them. Use wp_get_current_commenter() to get the raw values. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-20 01:11:14 +00:00
azaozz 8dff8f9f73 Properly escape comment_author_url when displaying, for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11721 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-07-18 23:21:50 +00:00
westi fc3b5ba6da Rename new function to sanitize_html_class() to hilight exactly what it is for, Fixes #8446. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-22 21:31:42 +00:00
westi 108f7c1063 Introduce sanitise_css_classname() and use it to give categories, tags, users etc meaningful classnames where possible. Falls back to the id if not. Fixes #8446. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-22 17:44:26 +00:00
markjaquith 3ebf837ced Deprecate sanitize_url() and clean_url() in favor of esc_url_raw() and esc_url() 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-18 16:00:33 +00:00
markjaquith 119b39cec2 deprecate wp_specialchars() in favor of esc_html(). Encode quotes for esc_html() as in esc_attr(), to improve plugin security. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-18 15:11:07 +00:00
ryan 1354d0660a Don't localize dates where not appropriate. Props Denis-de-Bernardy, hakre. fixes #9730 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-14 02:00:32 +00:00
ryan 75ec19a860 Notice fix. Props mrmist. fixes #8446 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-13 19:04:26 +00:00
ryan a0c7b65f7b Use IDs instead of slugs in CSS classes ro avoid invalid class names. Props hakre. fixes #8446 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-12 17:11:57 +00:00
westi a977c155bf Filter out blank urls for commentors. Fixes #5789. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-10 07:26:30 +00:00
westi e89d78ee08 Decode the commenters name why looking up un-moderated comments. Fixes #6992. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-06 20:24:57 +00:00
markjaquith 6c2ffddf31 _a(), _ea(), _xa(), attr() are now esc_attr__(), esc_attr_e(), esc_attr_x(), esc_attr() -- still short, but less cryptic. see #9650 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-05-05 19:43:53 +00:00
ryan 2d489767bb s/attribute_escape/attr/. see #9650 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-28 05:58:45 +00:00
ryan d90ba6085f Add comment-reply-login class. Props mattwalters. fixes #8633 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-22 21:27:07 +00:00
ryan a61bc0ec8a Trailing whitespace cleanup 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11013 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-20 18:18:39 +00:00
ryan 67533a8584 Add some CYA clean_url()s 
git-svn-id: http://svn.automattic.com/wordpress/trunk@11011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-20 17:46:46 +00:00
ryan 4754d22576 Use comments_open() and pings_open(). Props coffee2code. fixes #9557 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10982 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-17 07:02:55 +00:00
ryan 58aec06ad9 Add comment-body class. Props docwhat. fixes #9301 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-16 22:15:12 +00:00
ryan 75bbf754bd Translate defaults. Props nbachiyski. fixes #9548 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-16 18:51:50 +00:00
ryan fe648c9e20 Updates to wp_login_url() and wp_logout_url(). Use them in more places. Props wnorris. fixes #9536 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-14 18:31:49 +00:00
westi a6ed4323c5 Move byuser to a seperate array entry to ease filtering by plugins. Fixes #9465 for trunk props hakre. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10875 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-04-05 17:38:19 +00:00
ryan e8b6fe7347 Trim trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-03-18 02:43:45 +00:00
ryan cba3b3d41c get_comment_link filter. Props Viper007Bond. fixes #9327 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-03-13 21:58:18 +00:00
ryan db7e77a251 Order by comment_date_gmt 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-03-06 08:16:35 +00:00
ryan 27a7f46249 Allow comments_popup_link() for is_single and is_page. Props AaronCampbell, sivel. fixes #4832 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-03-04 20:26:56 +00:00
ryan cf3f91b0e6 Revert accidental bits. see #8708 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-20 20:55:57 +00:00
ryan ee73ce298c Use guid instead of link for atom comment IDs. fixes #8708 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-20 20:55:03 +00:00
azaozz 1c20ec7120 Add CSS class to "comment-reply-link", props yoavf, fixes #8836 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2009-01-10 10:21:28 +00:00
ryan 4fb1a0a76b Fix comment links when displaying first page of comments. Props johnconners. fixes #8583 for trunk 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-12 20:08:49 +00:00
ryan 8c1c46d5f0 Update func name. see #8550 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-10 21:13:32 +00:00
ryan e372e7f39a Change default add_below. see #8550 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-10 21:08:20 +00:00
ryan 7105e62a48 Post reply API updates. see #8550 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-10 21:06:13 +00:00
azaozz 1dca6a90ec Enable support for threaded comments and comment reply on index page, props yoavf, fixes #8550 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-10 11:49:37 +00:00
ryan e89192b1a8 Strip trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-09 18:03:31 +00:00
westi 7f357e7188 Link to comments on the page they are on. Fixes #8488 props johnconners. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-12-04 20:26:43 +00:00
azaozz d12e30a739 Fix [9854] for i18n, props filosofo 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-24 02:13:31 +00:00
azaozz 6efc35e1c9 I18n: fix get_comment_date and edit_comment_link in comment-template.php, props tai. Add class to "Says:", fixes #8142 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9854 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-24 01:36:23 +00:00
ryan 0339e5cd7a Revert [9773]. htmlspecialchars_decode() requires PHP 5.1. see #6992 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-21 00:57:31 +00:00
markjaquith a9d7f40d2e Add a "parent" class to comment LIs with children. props filosofo. fixes #8091 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-20 13:36:44 +00:00
markjaquith 30c3602b92 Improvements for get_comment_link() from Viper007Bond. fixes #8287 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-20 06:41:55 +00:00
markjaquith 93bc9521cd Handle blank display_name for commenters. props mrmist. fixes #7494 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-19 06:58:44 +00:00
markjaquith cad8e31e39 Show pending comments to users with quotes in their name. props regulatethis. fixes #6992 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-19 04:58:10 +00:00
markjaquith e3c5f05f3c A couple more hCard CSS classes for comments from wnorris. fixes #8264 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-18 22:06:51 +00:00
ryan 83dce74554 wp_list_comments() fixes when passing type. Props Viper007Bond. fixes #8168 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-13 20:36:36 +00:00
ryan 7effb8df55 Fix notice 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9540 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-06 01:58:33 +00:00
markjaquith 88bfbbd948 Massive get_comment_link() performance improvements for posts with a lot of comments. props Viper007Bond. fixes #7956 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9522 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-11-05 07:09:20 +00:00
markjaquith 698b1f1e4a Improvements to the Edit Comment screen 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-31 18:05:25 +00:00
ryan 5024fd6632 ['depth'] during the wp_list_comments should be ['max_depth']. Props ShaneF. fixes #8018 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-31 02:58:22 +00:00
ryan a5f00be14a Respect respond_id. props filosofo. fixes #8011 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-30 15:56:39 +00:00
ryan 25f4e26d33 Wrong view ryan 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-29 22:56:48 +00:00
westi 545c95e14b Make all comments classy. Fixes #8006 props filosofo. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-29 22:25:06 +00:00
ryan 6a3dd73a72 Obey comment_order if set. Defaul to asc if not set 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-28 16:41:47 +00:00
ryan 7f456fd864 Threaded comment fixes from filosofo. fixes #7980 
git-svn-id: http://svn.automattic.com/wordpress/trunk@9385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2008-10-28 16:17:48 +00:00