Commit Graph

188 Commits

Author SHA1 Message Date
Andrew Nacin c4f7821a16 Use current_user_can('manage_network_plugins') in validate_active_plugins() instead of is_super_admin().
props jdgrimes.
fixes #26068.

Built from https://develop.svn.wordpress.org/trunk@26590


git-svn-id: http://core.svn.wordpress.org/trunk@26480 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 21:12:10 +00:00
Dion Hulse 578469fb12 Add braces around a conditional hook. This wasn't causing an issue as `if ( conditional ) /* multiline comment */ command();` is perfectly OK, but left open doubt and potential future bugs. See #25229
Built from https://develop.svn.wordpress.org/trunk@26509


git-svn-id: http://core.svn.wordpress.org/trunk@26403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-01 23:13:09 +00:00
Dion Hulse f29b2e02ac Plugin Deletion: Properly clear the cache when multiple plugins are deleted. Props jdgrimes. Fixes #26065
Built from https://develop.svn.wordpress.org/trunk@26262


git-svn-id: http://core.svn.wordpress.org/trunk@26168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-19 04:08:09 +00:00
Andrew Nacin 70fd806759 Revert r25824:25875 from the core.svn.wordpress.org repository.
These commits were accidentally re-synced commits from develop.svn.wordpress.org due to a race condition. Thankfully, the history of this repository matters fairly little. It also happened only for trunk.


git-svn-id: http://core.svn.wordpress.org/trunk@25876 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 02:29:52 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Ryan Boren b87d4b77e5 Pinking shears
Built from https://develop.svn.wordpress.org/trunk@25880


git-svn-id: http://core.svn.wordpress.org/trunk@25792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 14:38:10 +00:00
Sergey Biryukov e6cef58106 Clean up the documentation for hooks in wp-admin/includes/plugin.php.
props DrewAPicture.
see #25229.
Built from https://develop.svn.wordpress.org/trunk@25482


git-svn-id: http://core.svn.wordpress.org/trunk@25403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-18 19:36:09 +00:00
Sergey Biryukov 31ddfcca58 Correct @since for hooks in wp-admin/includes/plugin.php. see #25229.
Built from https://develop.svn.wordpress.org/trunk@25477


git-svn-id: http://core.svn.wordpress.org/trunk@25398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-18 11:58:10 +00:00
Peter Westwood 8f621ffc78 Inline documentation for hooks in wp-admin/includes/plugin.php
See #25229 props dllh

Built from https://develop.svn.wordpress.org/trunk@25474


git-svn-id: http://core.svn.wordpress.org/trunk@25395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-18 07:38:12 +00:00
Dion Hulse 443aa35cfc Upgrader: Make clearing the Plugin and Theme update caches optional during install and upgrade proceedures. See #22704
Built from https://develop.svn.wordpress.org/trunk@25272


git-svn-id: http://core.svn.wordpress.org/trunk@25238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-06 01:33:09 +00:00
Dion Hulse 46daa240b9 Sanitize the plugin path in `_get_plugin_data_markup_translate()` to a WP_PLUGIN_DIR-relative path. The function is designed in mind for receiving relative paths, but may be used with a absolute path.
This change makes the function path-agnostic, and can accept either relative or absolute (converting to relative internally). Fixes #20813

Built from https://develop.svn.wordpress.org/trunk@25081


git-svn-id: http://core.svn.wordpress.org/trunk@25066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-22 04:03:09 +00:00
Andrew Nacin 55b3c67413 Revert [23394] until there is a consensus on target="_blank" (or not) for these external links. see #20839.
git-svn-id: http://core.svn.wordpress.org/trunk@24583 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-08 13:04:07 +00:00
Helen Hou-Sandí 1c816c795b Open external links to plugin homepages, plugin author homepages, and theme author homepages in a new window/tab. props SergeyBiryukov. fixes #20839.
git-svn-id: http://core.svn.wordpress.org/trunk@23394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:20:01 +00:00
Helen Hou-Sandí b1f1579604 its <=> it's in documentation, along with a rogue the, The, and looses. props trepmal. fixes #22665.
git-svn-id: http://core.svn.wordpress.org/trunk@23191 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-12-20 15:55:32 +00:00
Andrew Nacin 9fadd65859 HiDPI versions of the generic menu page icon. props empireoflight, lessbloat. see #21019.
git-svn-id: http://core.svn.wordpress.org/trunk@22393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 00:25:18 +00:00
Andrew Ozz b443373e8e Admin menu: add phpdoc/inline comments describing the usage of the param $icon_url in add_menu_page(), add string 'none' to be used when a menu icon is added from CSS, switch core items in the admin menu to use 'none', fixes #21349
git-svn-id: http://core.svn.wordpress.org/trunk@21877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-16 22:51:44 +00:00
Andrew Nacin 7fd32ab9fc Fold Privacy Settings into Reading Settings, moving blog_public (search engine/robots) to options-reading and removing options-privacy.
When blog_public only has two values (as judged by whether the blog_privacy_selector action is used), convert from radio buttons to a checkbox, and rename from 'Site Visibility' to a more specific 'Search Engine Visibility'.

The text and implementation may change a bit. see #16416.



git-svn-id: http://core.svn.wordpress.org/trunk@21838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-13 17:28:57 +00:00
Andrew Nacin 1080c1e4ee Use the key we found using array_search() to unset it from the array. props hakre. fixes #16562.
git-svn-id: http://core.svn.wordpress.org/trunk@21812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-11 02:12:34 +00:00
Ryan Boren c55cf716da Use set_url_scheme(). Props johnbillion, MarcusPope. see #19037 #20759
git-svn-id: http://core.svn.wordpress.org/trunk@21664 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-30 13:33:00 +00:00
nacin dcb200efc9 Fix order of @param's for deactivate_plugins(). props Viper007Bond, fixes #21269.
git-svn-id: http://core.svn.wordpress.org/trunk@21291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-20 15:09:40 +00:00
nacin efb07c689e Back compat for plugins looking for networkwide=1 during a plugin activation hook.
Proper way to detect this: An activation hook callback receives (bool) $network_wide as the first argument.

see #20995 for trunk.



git-svn-id: http://core.svn.wordpress.org/trunk@21104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-25 19:32:34 +00:00
nacin e098306abe Correct logic in deactivate_plugins() where network_wide = null. props SergeyBiryukov. fixes #20497.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-21 00:45:53 +00:00
nacin c23bf21079 Clean up plugins.php with regards to recently edited files, deactivations, and the network admin. see #20468, #20104.
* Limit recently_activated to the site dashboard, and properly remove bulk-activated plugins from the array.
 * Remove code used from before the network admin, such as the unused 'network' plugin_status.
 * Don't try to deactivate a plugin already deactivated.
 * Use more specific caps (manage_network_plugins) rather than is_super_admin().



git-svn-id: http://svn.automattic.com/wordpress/trunk@20525 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-19 03:41:29 +00:00
nacin 3184f9891a Clean up get_plugin_data() and _get_plugin_data_markup_translate(), and standardize sanitization. fixes #20266.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-20 23:04:59 +00:00
nacin 4a9e14a011 Allow bundled plugin headers to be translated. see #19597.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-21 15:26:08 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan 83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:50:54 +00:00
ryan 616c35e71c One newline is enough.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
ryan 340e93324c Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
git-svn-id: http://svn.automattic.com/wordpress/trunk@19596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-14 17:36:38 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
duck_ ba7651277e Revert r18887 due to back compat issues. Fixes #18914.
For example 'intval' couldn't be used as a sanitisation callback.


git-svn-id: http://svn.automattic.com/wordpress/trunk@18951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-12 16:35:33 +00:00
markjaquith bc3fc076e1 Pass both parameters to the sanitize_option_FOO callback set in register_setting(). props lumination. fixes #15335
git-svn-id: http://svn.automattic.com/wordpress/trunk@18887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 17:48:41 +00:00
nacin 9a023b8378 Document that add_submenu_page() might return false if ! current_user_can(). see #17677.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-03 23:30:46 +00:00
ryan 3fc5956921 s/seperator/separator/. Props brandonburke. fixes #17610
git-svn-id: http://svn.automattic.com/wordpress/trunk@18084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-31 19:58:36 +00:00
dd32 efa709d1b5 Move closedir() to better locations to prevent the need for error suppression, prevents suppressed Warnings/Notices to be thrown during Plugin Installation. Fixes #16547
git-svn-id: http://svn.automattic.com/wordpress/trunk@17617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-07 09:07:56 +00:00
nacin 49887cdd9a Offer the standard tags for the plugin name datapoint. props Kawauso, fixes #16241.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-15 07:26:45 +00:00
nacin 48c84b91de Remove a random nacin typo introduced in 3.0. see [12976], #16055.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17196 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-31 23:58:02 +00:00
ryan 587ea006b5 Translations in title attributes require esc_attr().
git-svn-id: http://svn.automattic.com/wordpress/trunk@17102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-21 17:17:58 +00:00
scribu 1474c1a64a Add @return to add_*menu_page() docs. Fixes #15747
git-svn-id: http://svn.automattic.com/wordpress/trunk@16831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 06:54:48 +00:00
nacin adbcaa8019 Fix menu_page_url() for submenu pages attached to custom menu pages. props duck_, see #14159.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 04:02:37 +00:00
nacin 99d02e7d54 Set AuthorName even when no translation or markup is processed. see #15662.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-06 21:18:18 +00:00
nacin ebcda1964d Add AuthorName to get_plugins() and use it when deleting a plugin. fixes #15662.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-06 20:49:54 +00:00
ryan 3f72e340d6 Update since phpdoc. Props demetris. fixes #15445
git-svn-id: http://svn.automattic.com/wordpress/trunk@16660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 19:24:38 +00:00
ryan 847499e531 Pinking shears
git-svn-id: http://svn.automattic.com/wordpress/trunk@16438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 18:47:34 +00:00
nacin 5f4a583fb1 Remove more create_function calls. props huichen, see #14424.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-11 22:50:36 +00:00
nacin 771de1c49e Kill a create_function by introducing is_plugin_inactive. see #14424.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-11 22:21:04 +00:00
westi 4215d8be2c Blankity Blank. Fixes #15380 props arena.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-10 20:54:56 +00:00
scribu f7ba3fd70d Prevent double inclusion of plugin when already activated on main site. See #14435
git-svn-id: http://svn.automattic.com/wordpress/trunk@16027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-27 23:54:43 +00:00
scribu 80ce121521 Don't call activation hooks when upgrading. Props joelhardi for initial patch. See #14915
git-svn-id: http://svn.automattic.com/wordpress/trunk@16012 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-27 13:40:14 +00:00
scribu 1482db4c2d Pass $network_wide flag to de/activation hooks. See #14170
git-svn-id: http://svn.automattic.com/wordpress/trunk@16011 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-27 13:20:53 +00:00