John Blackbourn
d0a32c5111
Docs: Various docblock corrections and improvements.
...
See #50768
Built from https://develop.svn.wordpress.org/trunk@48941
git-svn-id: http://core.svn.wordpress.org/trunk@48703 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-09-04 20:41:07 +00:00
Sergey Biryukov
aa69c25d5f
Coding Standards: Use strict comparison in some `wp-admin` files.
...
Props pikamander2, mukesh27, SergeyBiryukov.
Fixes #49239 .
Built from https://develop.svn.wordpress.org/trunk@47785
git-svn-id: http://core.svn.wordpress.org/trunk@47561 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-12 18:32:08 +00:00
Sergey Biryukov
5e6c949861
Coding Standards: Use Yoda conditions in some `wp-admin` files.
...
Props subrataemfluence, marcio-zebedeu, bookdude13, 1naveengiri, alishankhan.
Fixes #44365 , #48455 .
Built from https://develop.svn.wordpress.org/trunk@47218
git-svn-id: http://core.svn.wordpress.org/trunk@47018 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-09 16:53:06 +00:00
Sergey Biryukov
47ed56f38f
Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant.
...
This avoids the performance overhead of the function call every time `dirname( __FILE__ )` was used instead of `__DIR__`.
This commit also includes:
* Removing unnecessary parentheses from `include`/`require` statements. These are language constructs, not function calls.
* Replacing `include` statements for several files with `require_once`, for consistency:
* `wp-admin/admin-header.php`
* `wp-admin/admin-footer.php`
* `wp-includes/version.php`
Props ayeshrajans, desrosj, valentinbora, jrf, joostdevalk, netweb.
Fixes #48082 .
Built from https://develop.svn.wordpress.org/trunk@47198
git-svn-id: http://core.svn.wordpress.org/trunk@46998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-06 06:33:11 +00:00
Sergey Biryukov
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
Gary Pendergast
abcbee954f
Coding Standards: Fix instances of `WordPress.PHP.NoSilencedErrors.Discouraged`.
...
Noteable changes:
- The `magic_quotes_runtime` and `magic_quotes_sybase` settings were removed in PHP 5.4, so no longer need to be set.
- Some functions that use external libraries can generate errors that can't be tested for, so are globally allowed to silence errors.
- Quite a few functions would cause errors if `safe_mode` was set. This setting was removed in PHP 5.4.
- Only a handful of `header()` calls needed corresponding `headers_sent()` checks for unit tests to pass, but more may need to be added as the nightlies builds are tested.
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45611
git-svn-id: http://core.svn.wordpress.org/trunk@45422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 05:45:58 +00:00
Peter Wilson
e6ccdf161f
General: Further improve error messages following [42648].
...
Props kristastevens, melchoyce.
Fixes #38332 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42719
git-svn-id: http://core.svn.wordpress.org/trunk@42547 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-19 02:13:32 +00:00
Peter Wilson
0d39b35c11
General: Replace `Cheatin’ uh?` with friendlier error messages.
...
While intended as a playful error message, `Cheatin’ uh?` can be interpreted as insulting or accusatory in an already stressful situation. This replaces Cheatin’ with more meaningful error messages, depending on the error that occurs.
Props ElectricFeet, EricMeyer, karmatosed, dd32, BandonRandon, melchoyce for language; dmsnell for original patch; peterwilsoncc.
Fixes #38332 .
Built from https://develop.svn.wordpress.org/trunk@42648
git-svn-id: http://core.svn.wordpress.org/trunk@42477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-05 02:30:34 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Drew Jaynes
22adda2aa0
Hooks: Standardize naming of dynamic hooks to use interpolation vs concatenation.
...
Benefits gained in discoverability and self-documentation throughout core trump the negligible performance hit in using interpolation in hook names.
Props ramiy.
See #37748 .
Built from https://develop.svn.wordpress.org/trunk@38307
git-svn-id: http://core.svn.wordpress.org/trunk@38248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-08-22 18:25:31 +00:00
Dominik Schilling
25e66e4f1e
Text Changes: Unify permission error messages.
...
The new format looks like "Sorry, you are not allowed to <action>.". This provides a consistent experience for all error messages related to missing permissions. It also reduces the number of similar strings and allows translators to provide a consistent style in their language.
Props ramiy, Presskopp.
Fixes #34521 .
Built from https://develop.svn.wordpress.org/trunk@37914
git-svn-id: http://core.svn.wordpress.org/trunk@37855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-06-29 15:16:29 +00:00
Drew Jaynes
c3055cc190
Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP.
...
See #36913 .
Built from https://develop.svn.wordpress.org/trunk@37488
git-svn-id: http://core.svn.wordpress.org/trunk@37456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-05-22 18:01:30 +00:00
Sergey Biryukov
d95417a5e7
Provide more helful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/media-upload.php`.
...
props ericlewis, kraftbj, lukecarbis, mrmist.
fixes #33672 . see #14530 .
Built from https://develop.svn.wordpress.org/trunk@33853
git-svn-id: http://core.svn.wordpress.org/trunk@33821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-02 16:21:21 +00:00
Dion Hulse
121f83ab39
Remove an extra indent from most of media-new.php.
...
Built from https://develop.svn.wordpress.org/trunk@31328
git-svn-id: http://core.svn.wordpress.org/trunk@31309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-03 07:47:22 +00:00
Drew Jaynes
2faf449f51
Docs Formatting: Backtick-escape inline code for all dynamic hook docs in wp-admin/*.
...
Also includes some changes to move hook docs to directly precede hook lines. This is necessary to prevent DocBlock-matching confusion when core is parsed.
Affects DocBlocks for the following hooks:
* `wp_ajax_ . $_REQUEST['action']`
* `wp_ajax_nopriv_ . $_REQUEST['action']`
* `admin_footer- . $GLOBALS['hook_suffix']`
* `admin_head-$hook_suffix`
* `admin_post_nopriv_{$action}`
* `admin_post_{$action}`
* `load- . $page_hook`
* `load- . $plugin_page`
* `load-importer- . $importer`
* `load- . $pagenow`
* `admin_action_ . $_REQUEST['action']`
* `async_upload_{$type}`
* `add_meta_boxes_ . $post_type`
* `{$taxonomy}_pre_edit_form`
* `{$taxonomy}_term_edit_form_tag`
* `{$taxonomy}_edit_form_fields`
* `{$taxonomy}_edit_form`
* `after-{$taxonomy}-table`
* `{$taxonomy}_pre_add_form`
* `{$taxonomy}_term_new_form_tag`
* `{$taxonomy}_add_form_fields`
* `{$taxonomy}_add_form`
* `media_upload_$type`
* `media_upload_$tab`
* `install_plugins_pre_$tab`
* `install_plugins_$tab`
* `install_themes_pre_{$tab}`
* `install_themes_{$tab}`
* `update-core-custom_{$action}`
* `update-custom_{$action}`
* `user_{$name}_label`
See #30552 .
Built from https://develop.svn.wordpress.org/trunk@30649
git-svn-id: http://core.svn.wordpress.org/trunk@30639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-30 11:42:24 +00:00
John Blackbourn
d88ed475b0
Switch to a `403` response code in places where it is more appropriate than a `500` due to permissions errors.
...
Fixes #10551
Props nacin
Built from https://develop.svn.wordpress.org/trunk@30356
git-svn-id: http://core.svn.wordpress.org/trunk@30355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 06:16:22 +00:00
Drew Jaynes
097dc8ee15
Fix syntax for single- and multi-line comments in wp-admin-directory files.
...
See #28931 .
Built from https://develop.svn.wordpress.org/trunk@29206
git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 09:14:16 +00:00
Drew Jaynes
b3b3316102
Inline documentation for hooks in wp-admin/media-upload.php.
...
Props piontkowski for the initial patch.
Fixes #26075 .
Built from https://develop.svn.wordpress.org/trunk@26917
git-svn-id: http://core.svn.wordpress.org/trunk@26798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-08 04:00:11 +00:00
Drew Jaynes
f51b1f8def
Inline documentation for hooks in wp-admin/includes/media.php.
...
Props kpdesign, DrewAPicture.
Fixes #25375 .
Built from https://develop.svn.wordpress.org/trunk@26908
git-svn-id: http://core.svn.wordpress.org/trunk@26791 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-06 05:48:12 +00:00
Andrew Nacin
fd57b239d2
Don't rely on include_path to include files.
...
Always use dirname() or, once available, ABSPATH.
props ketwaroo, hakre.
fixes #17092 .
Built from https://develop.svn.wordpress.org/trunk@25616
git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Andrew Nacin
f6b9a928e5
Split media-new.php and media-upload.php into distinct files.
...
* media-new.php will remain the entry point for uploading isolated files, and for using the browser-based uploader (versus Plupload).
* media-upload.php is the legacy (pre-3.5) media uploader.
see #22083 .
git-svn-id: http://core.svn.wordpress.org/trunk@22751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-21 12:19:40 +00:00
Andrew Nacin
e3069d9d62
Re-enable a .wp-upload-form submit button whenever any file input in that form has a file selected, to minimize the potential for issues. props kovshenin. fixes #20855 . see [22459].
...
git-svn-id: http://core.svn.wordpress.org/trunk@22663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:07:04 +00:00
ryan
b49c243443
Restrict post IDs
...
git-svn-id: http://core.svn.wordpress.org/trunk@21048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-10 17:37:49 +00:00
ryan
6670a497dd
Clarify the uploading options in the media-new.php contextual help.
...
Props Ipstenu, DrewAPicture
fixes #19442
git-svn-id: http://core.svn.wordpress.org/trunk@20676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-01 22:23:15 +00:00
ryan
d3134e2688
Allow selecting custom header and background images from the media library. Props aaroncampbell, sabreuse, greuben. fixes #19840
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-05 00:20:28 +00:00
koopersmith
71eee3357d
Combine two strings. Cheatin', uh?
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-07 19:00:12 +00:00
ryan
e3b46b25d3
Lose EOF ?>. Clean up EOF newlines. fixes #12307
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan
6bba5a265b
Pinking shears
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 04:51:35 +00:00
nacin
c0dcf616c1
Help tweaks for comments, media, edit.php, update-core.php. props jane, see #19020 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 01:33:26 +00:00
ryan
efbbab1b3c
Help tabs. Props chexee. see #19020
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-24 00:21:39 +00:00
ryan
0e95236e14
Help tabs. Props chexee. see #19020
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 23:02:22 +00:00
azaozz
28ec7872a2
Make the Save All Changes initially hidden on Media -> Add New screen, improve the progress bar "progress" to 1px ticks, see #19190
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-15 21:22:27 +00:00
azaozz
a37b440bac
Bring back the multi-file/html uploader switching, see #19228
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-11 19:40:23 +00:00
azaozz
a31f0ad164
Uploader: update to 1.5.1.1, remove plupload.full.js (we cannot use it), rename the script handle in script-loader to avoid any confusion, fixes #19187
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-06 21:46:24 +00:00
nacin
bfb98c193e
s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020 , #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00
ryan
3ad1f67958
Use add_help_sidebar(). see #19020
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 03:12:37 +00:00
azaozz
d7a9037fec
Prevent the uploader getting stuck when deleting the only image from the gallery, props ocean90, fixes #15118
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18850 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-30 22:52:29 +00:00
azaozz
2605391379
Improve handling of plupload init and add a filter, stop including cookies in the init (not needed with plupload), see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-15 05:30:58 +00:00
azaozz
91a8720fff
Pluploader take 1, props jacobwg, see #18206
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18482 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-29 08:59:35 +00:00
nacin
9cb6e158fc
Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 15:24:49 +00:00
ryan
924f783fda
Add some nonce checks to the uploaders. Props duck_. For trunk.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17568 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-03-28 21:30:59 +00:00
nacin
a717edca97
Always exit after wp_redirect. props filosofo, fixes #15518 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-09 18:02:54 +00:00
ryan
fab93cc99f
Define IFRAME_REQUEST only if not inline. Props ocean90. fixes #15630
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-01 19:28:24 +00:00
westi
ee291ef5a5
Remove WP_SHOW_ADMIN_BAR and go off existing and new defines on page type. See #15315
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-06 09:41:03 +00:00
markjaquith
fc6e89da45
Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 21:56:43 +00:00
ryan
580bf5eead
Allow turning off the admin bar via WP_SHOW_ADMIN_BAR constant, no_admin_bar() function, or show_admin_bar filter. see #14772
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-18 17:58:36 +00:00
ryan
359e1620b2
Use admin_url() for the media-upload.php url. see #13685
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-08 14:02:16 +00:00
nacin
34c1fa6d0b
target=blank for help. props jorbin, see #13467
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15132 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-03 21:00:39 +00:00
ryan
f7428fc146
Help text cleanup. Props zeo. fixes #13467
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15126 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-03 13:37:51 +00:00
nacin
a51aba7dd9
Help fixes, props jane. fixes #13467 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@15103 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-06-02 05:54:14 +00:00