Commit Graph

87 Commits

Author SHA1 Message Date
Helen Hou-Sandí c4b561bb6c Use more generic, reusable CSS for the filter bar on Add Themes. This will allow us to reuse the UI in other places, such as the Media Library. props paulwilde. fixes #28794.
Built from https://develop.svn.wordpress.org/trunk@29217


git-svn-id: http://core.svn.wordpress.org/trunk@29001 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-18 03:40:16 +00:00
Helen Hou-Sandí b90b64bf9e More consistent icons in place of some buttons for the Customizer and theme install preview.
* Use a single close icon instead of a context-changing cancel/close button in the Customizer. In user testing, this small distinction in language was overlooked, and we use an AYS now instead. This also makes it consistent with the back arrow in Customizer panels.
* Use the same close icon as well as the previous/next arrows from the theme details browser in the theme install preview.

props celloexpressions. fixes #28655.

Built from https://develop.svn.wordpress.org/trunk@29031


git-svn-id: http://core.svn.wordpress.org/trunk@28819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-08 18:19:14 +00:00
Sergey Biryukov 4b7a9edd27 Reinstate 'install_themes_tabs' filter.
props ghost1227.
fixes #28578.
Built from https://develop.svn.wordpress.org/trunk@29002


git-svn-id: http://core.svn.wordpress.org/trunk@28790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-04 23:58:15 +00:00
Sergey Biryukov c453340a49 Update help text on Add Themes screen.
props thomasvanderbeek.
fixes #28132.
Built from https://develop.svn.wordpress.org/trunk@28473


git-svn-id: http://core.svn.wordpress.org/trunk@28300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-17 23:44:15 +00:00
Sergey Biryukov 28cafbb868 Add context for 'Previous' and 'Next' theme strings.
see #28120, for trunk.
Built from https://develop.svn.wordpress.org/trunk@28286


git-svn-id: http://core.svn.wordpress.org/trunk@28114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 12:20:14 +00:00
Andrew Nacin cd6b973b54 Use correct echoing context function. see #27889.
Built from https://develop.svn.wordpress.org/trunk@28160


git-svn-id: http://core.svn.wordpress.org/trunk@27991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-19 18:09:16 +00:00
Andrew Nacin 3a9851d0fa Context for 'Installed' and 'Already Installed' theme strings.
props SergeyBiryukov.
see #27889, for trunk.

Built from https://develop.svn.wordpress.org/trunk@28159


git-svn-id: http://core.svn.wordpress.org/trunk@27990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-19 18:08:17 +00:00
Andrew Nacin 9f81d0526e Theme Installer: Revert to proxying through PHP for WordPress.org API requests.
This is to ensure we have valid installation nonces, though we've run into this as a problem previously (see #27639, #27581, #27055).

A tad slower, but we gained speed in 3.9 by simplifying the request made to the API.

props ocean90.
fixes #27798.

Built from https://develop.svn.wordpress.org/trunk@28126


git-svn-id: http://core.svn.wordpress.org/trunk@27957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-15 01:16:14 +00:00
Andrew Nacin f911d99902 Theme installer: Improve route handling and make ?theme= work.
props matveb.
fixes #27708.

Built from https://develop.svn.wordpress.org/trunk@28123


git-svn-id: http://core.svn.wordpress.org/trunk@27954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 22:06:15 +00:00
Andrew Nacin cd5f8d517c Theme install: Set a timeout and error message for API responses.
props ocean90.
fixes #27708.

Built from https://develop.svn.wordpress.org/trunk@28105


git-svn-id: http://core.svn.wordpress.org/trunk@27936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-13 19:02:14 +00:00
Andrew Nacin e7fc009f7c Theme Installer: Combine 'Layout' and 'Columns' filters so 'Features' can span two columns.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@28037


git-svn-id: http://core.svn.wordpress.org/trunk@27867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 04:30:15 +00:00
Andrew Nacin 658032c9f9 Theme Installer: Disable prev/next buttons on first/last themes, add Esc handling, use IDs.
props adamsilverstein, DH-Shredder.
fixes #27521.

Built from https://develop.svn.wordpress.org/trunk@28033


git-svn-id: http://core.svn.wordpress.org/trunk@27863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-08 03:57:15 +00:00
Andrew Nacin 56c1deba7c Theme Installer: Handle currently installed themes, add search route, let prev/next refresh collections.
props matveb.
see #27055. fixes #27695.

Built from https://develop.svn.wordpress.org/trunk@28025


git-svn-id: http://core.svn.wordpress.org/trunk@27855 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 23:04:15 +00:00
Andrew Nacin f532f117e1 Theme Installer: Don't encode description entities/HTML.
props johnbillion.
fixes #27641.

Built from https://develop.svn.wordpress.org/trunk@27962


git-svn-id: http://core.svn.wordpress.org/trunk@27792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 20:30:15 +00:00
Andrew Nacin c5127a9232 Theme Installer: Better responsive styles for feature filters.
props matveb.
fixes #27661.

Built from https://develop.svn.wordpress.org/trunk@27959


git-svn-id: http://core.svn.wordpress.org/trunk@27789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-05 20:04:14 +00:00
Andrew Nacin be70db8c5f Theme Installer: Center spinner, remove plural string.
fixes #27581. see #27055.

Built from https://develop.svn.wordpress.org/trunk@27940


git-svn-id: http://core.svn.wordpress.org/trunk@27770 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-04 00:46:15 +00:00
Andrew Nacin 0163a95d79 Theme Installer: Fix sorting, counts, keyboard navigation; add prev/next to previews.
props matveb.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27937


git-svn-id: http://core.svn.wordpress.org/trunk@27767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 23:53:15 +00:00
Andrew Nacin d330c402c8 Theme Installer fixes:
* Better more filters section. props sonjanyc for some mockups.
 * Better handling of no results.
 * Use # for hrefs.

props matveb.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27896


git-svn-id: http://core.svn.wordpress.org/trunk@27727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 22:20:14 +00:00
Helen Hou-Sandí 3c72ba4282 Bring keyboard accessibility to the theme install screen and theme action buttons. props jorbin. see #27521.
Built from https://develop.svn.wordpress.org/trunk@27804


git-svn-id: http://core.svn.wordpress.org/trunk@27638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-28 03:16:15 +00:00
Andrew Nacin 0e36651b36 Add context to 'Browse' (themes). see #27055, #27453.
Built from https://develop.svn.wordpress.org/trunk@27646


git-svn-id: http://core.svn.wordpress.org/trunk@27489 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-21 00:20:15 +00:00
Andrew Nacin 3c15a9c9f2 Theme installer:
* Restore the feature filter.
 * Improve responsiveness.
 * Router updates, fixes.
 * Make "Upload Theme" button more consistent with the admin.
 * Avoid theme-count causing filters to jump.

props matveb.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27636


git-svn-id: http://core.svn.wordpress.org/trunk@27479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-20 04:20:15 +00:00
Andrew Nacin deb8779af5 More translation cleanups.
Affects widgets (see #27112), custom headers (see #21785), theme installer (see #27055, reverts [27614]), and some media stuff. Untranslates some complicated strings that need additional study.

see #27453.

Built from https://develop.svn.wordpress.org/trunk@27620


git-svn-id: http://core.svn.wordpress.org/trunk@27463 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 08:18:14 +00:00
Andrew Nacin d853e11960 Use an ellipsis instead of ...
see #27453, #27055.

Built from https://develop.svn.wordpress.org/trunk@27614


git-svn-id: http://core.svn.wordpress.org/trunk@27457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:55:14 +00:00
Andrew Nacin 722bdc353f Context for theme install strings. Untranslate an error message until it can be cleaned up.
see #27453, #27055.

Built from https://develop.svn.wordpress.org/trunk@27610


git-svn-id: http://core.svn.wordpress.org/trunk@27453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-19 05:42:15 +00:00
Andrew Nacin 9aca2a65f8 Bring the theme browsing experience from 3.8 to the theme installer. First pass.
props matveb with assists from me and gcorne.
see #27055.

Built from https://develop.svn.wordpress.org/trunk@27499


git-svn-id: http://core.svn.wordpress.org/trunk@27341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-11 07:47:15 +00:00
Andrew Nacin dce0b9adea Use SSL when linking to WordPress.org. see #27115.
Built from https://develop.svn.wordpress.org/trunk@27469


git-svn-id: http://core.svn.wordpress.org/trunk@27314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-08 04:14:15 +00:00
Andrew Nacin df48cebeb4 No-JavaScript and no-Customizer support for the new Themes screen.
JavaScript is rarely disabled, but graceful degradation is still important. For example, syntax errors can occur, usually with major WP updates that overhaul entire experiences and update external libraries combined with themes or plugins doing weird or old things. If this error is due to their current theme, a user needs to be able to access the themes screen to switch away from the theme. A more subtle issue could make things painful to diagnose.

This commit renders the grid in PHP (the template is duplicated, but it lightweight, fairly mundane, and easy to sync). On Backbone render, the grid is then re-rendered from JavaScript so searches can occur. Customize and Live Preview is disabled if JS fails to kick in. If JS is disabled, old-school "Preview" links are displayed.

No-Customizer support: The customizer is only supported when the browser supports postMessage (IE8+), and if the frontend is a different domain, CORS (IE10+). We use the .hide-if-no-customize class for this. Pre-customize "Preview" links should use .hide-if-customize.

The .load-customize class should be used to declare a link that opens the customizer. This enables customize-loader.js to intercept this link and load the customizer on top of the current window, making for a smoother experience.

fixes #25964.

Built from https://develop.svn.wordpress.org/trunk@26726


git-svn-id: http://core.svn.wordpress.org/trunk@26615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 16:11:10 +00:00
Andrew Ozz 8d6059b383 Remove all screen_icon() calls and deprecate the functions, props TobiasBg, fixes #26119
Built from https://develop.svn.wordpress.org/trunk@26518


git-svn-id: http://core.svn.wordpress.org/trunk@26411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:53:11 +00:00
Dion Hulse f581667614 Themes: Remove the Tabs from the header of the Add New Theme page. Fixes #26310
Built from https://develop.svn.wordpress.org/trunk@26466


git-svn-id: http://core.svn.wordpress.org/trunk@26364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-29 04:41:10 +00:00
Drew Jaynes 657824a133 Inline documentation for hooks in wp-admin/theme-install.php.
Props leewillis77 and kpdesign for the initial patches.
Fixes #25823.

Built from https://develop.svn.wordpress.org/trunk@26343


git-svn-id: http://core.svn.wordpress.org/trunk@26244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-23 22:37:10 +00:00
Andrew Nacin fd57b239d2 Don't rely on include_path to include files.
Always use dirname() or, once available, ABSPATH.

props ketwaroo, hakre.
fixes #17092.

Built from https://develop.svn.wordpress.org/trunk@25616


git-svn-id: http://core.svn.wordpress.org/trunk@25533 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 00:18:11 +00:00
Andrew Nacin 797ee34bc3 Remove /extend/ from URLs to wordpress.org/plugins, /themes, and /mobile, as those are all now top-level. see #24389.
git-svn-id: http://core.svn.wordpress.org/trunk@24320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:01:57 +00:00
Andrew Ozz af85f3afe2 Fix help text on the Install Themes screen, props SergeyBiryukov, fixes #20925
git-svn-id: http://core.svn.wordpress.org/trunk@21579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-22 02:28:30 +00:00
ryan 9b39ae6629 Theme help text updates. Consistently use Live Preview. Props SergeyBiryukov. fixes #20795
git-svn-id: http://core.svn.wordpress.org/trunk@20967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-01 13:13:32 +00:00
ryan c0339644ea Shears of vigorous pinking.
git-svn-id: http://core.svn.wordpress.org/trunk@20944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-27 16:25:43 +00:00
ryan fbe317f406 Contextual help updates for themes.php and theme-install.php. Props TomAuger. fixes #20515
git-svn-id: http://core.svn.wordpress.org/trunk@20736 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-07 17:26:16 +00:00
koopersmith c2fb0c425b Replace all instances of thickbox theme preview with the theme customizer. fixes #20404.
* Use theme customizer in theme install/update screens.
* Separate the customize loader from the customizer. Use wp_customize_loader() to include the loader script and markup.
* Deprecated: wp-admin/js/theme-preview.js is now no longer used by core.

git-svn-id: http://svn.automattic.com/wordpress/trunk@20419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-10 02:25:03 +00:00
ryan 723bb1a99c Infinite scroll for themes.php and theme-install.php. Bump per page limit for themes.php to 999. Props helenyhou, DH-Shredder. see #19815
git-svn-id: http://svn.automattic.com/wordpress/trunk@19887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-09 17:20:26 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan 8ace5a6b4c Use WP_Screen::add_help_tab(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 02:22:07 +00:00
nacin cece838d8f More s/add_help_sidebar/set_help_sidebar/. fixes #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 21:32:16 +00:00
ryan 366db8c10b Use add_help_sidebar(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 05:33:53 +00:00
azaozz 1cdec6ff6e Merge most admin css files, first run, see #18314
git-svn-id: http://svn.automattic.com/wordpress/trunk@18577 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-21 03:46:43 +00:00
markjaquith e67a3b2e32 Be less specific about theme and plugin repo licenses (as they can vary in specifics). They are all compatible with the license WordPress uses, which is what matters. fixes #16514
git-svn-id: http://svn.automattic.com/wordpress/trunk@18231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 16:35:32 +00:00
markjaquith 0e57bd3a37 Centralize pagination bound exceeding redirects for list tables. props garyc40. props johnjamesjacoby. fixes #16208
git-svn-id: http://svn.automattic.com/wordpress/trunk@17900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 06:09:42 +00:00
nacin 37075f7f71 Remove AJAX from list tables. first pass. see #16262.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-16 21:47:24 +00:00
markjaquith 8e2683d127 Add "paged param is greater than total pages" redirects to a few more screens. props greuben. fixes #16187
git-svn-id: http://svn.automattic.com/wordpress/trunk@17274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-13 00:03:38 +00:00
nacin cc08068dba Remove check_permissions() calls outside of AJAX context. Also only check for switch_themes in check_permissions() for the themes table. see #15326.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 08:43:22 +00:00
ryan 3949ce12d0 Pink trailing whites.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-13 21:21:50 +00:00
westi 46cd784f3c Restore some more cap checks for clarity. See #15326.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-07 21:06:19 +00:00