2e7e09d869
Bootstrap/Load: Add support for JSON requests to `wp_die()`.
...
In addition to AJAX and XML-RPC requests, `wp_die()` now handles JSON requests correctly, returning information in the expected content type.
Props spacedmonkey.
See #45933 , #44458 .
Built from https://develop.svn.wordpress.org/trunk@44625
git-svn-id: http://core.svn.wordpress.org/trunk@44456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 15:22:56 +00:00
30d5ca9172
Bootstrap/Load: Fix workaround to display admin link in PHP error template by introducing `$link_url` and `$link_text` arguments to `wp_die()`.
...
This changeset removes the hack that was used before to display more complex HTML markup than a simple message in the default PHP error template via `wp_die()`. By removing HTML markup from the arguments passed to `wp_die()` it furthermore paves the way for supporting other content types than the default.
The message and arguments can be modified with new `wp_php_error_message` and `wp_php_error_args` filters respectively.
Furthermore this changeset fixes a few issues of functions not existing which could potentially have caused fatal errors when executed early in the WordPress bootstrap process.
Props flixos90, spacedmonkey.
See #45933 , #44458 .
Built from https://develop.svn.wordpress.org/trunk@44624
git-svn-id: http://core.svn.wordpress.org/trunk@44455 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 15:21:50 +00:00
225f3055b8
Bootstrap/Load: Only pause extensions when they cause a crash on a protected endpoint.
...
This is a first step on pausing extensions less aggressively. If a plugin or theme only causes a crash in the frontend, there is no point in pausing it in the admin backend.
See #45940 , #44458 .
Built from https://develop.svn.wordpress.org/trunk@44623
git-svn-id: http://core.svn.wordpress.org/trunk@44454 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 14:05:00 +00:00
a6ec40d65d
Bootstrap/Load: Use `wp_load_translations_early()` when Translation API is not yet loaded.
...
Props spacedmonkey.
Fixes #45932 . See #44458 .
Built from https://develop.svn.wordpress.org/trunk@44622
git-svn-id: http://core.svn.wordpress.org/trunk@44453 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 13:34:52 +00:00
da760d1ecf
Taxonomy: Remove extra padding around buttons on term edit page.
...
Props monikarao, mukesh27, chetan200891.
See #9777 .
Fixes #45183 .
Built from https://develop.svn.wordpress.org/trunk@44621
git-svn-id: http://core.svn.wordpress.org/trunk@44452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 12:59:52 +00:00
077af6e47d
Docs: Improve the `sanitize_email` filter.
...
- Remove duplicate parameter names.
- Fix the wrong value being passed in the second parameter.
- Correct the type of the `$message` parameter.
Props ChriCo.
Fixes #45595 .
Built from https://develop.svn.wordpress.org/trunk@44620
git-svn-id: http://core.svn.wordpress.org/trunk@44451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 06:16:49 +00:00
8c702e04f3
Rewrite: Remove extra arguments being passed to `WP_Rewrite::iis7_url_rewrite_rules()`.
...
Props rafsuntaskin.
Fixes #44185 .
Built from https://develop.svn.wordpress.org/trunk@44619
git-svn-id: http://core.svn.wordpress.org/trunk@44450 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 06:10:50 +00:00
0bbb277ee4
Formatting: Add type checking to `_sanitize_text_fields()`.
...
When a non-string value is passed, return an empty string.
Props Mte90.
Fixes #41450 .
Built from https://develop.svn.wordpress.org/trunk@44618
git-svn-id: http://core.svn.wordpress.org/trunk@44449 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 06:05:49 +00:00
63cbfcbded
Plugin Editor: Disable the documentation look up button when no function is selected.
...
Props xkon.
Fixes #41143 .
Built from https://develop.svn.wordpress.org/trunk@44617
git-svn-id: http://core.svn.wordpress.org/trunk@44448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 06:01:50 +00:00
32ace06a39
Templates: Fix the return value of `get_the_author_posts_link()`.
...
When the `$authordata` global isn't defined, return an empty string, rather than `void`.
Props mukesh27, subrataemfluence.
Fixes #45597 .
Built from https://develop.svn.wordpress.org/trunk@44616
git-svn-id: http://core.svn.wordpress.org/trunk@44447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 05:54:49 +00:00
4fa5437fc1
Admin: Use `is_user_logged_in()` instead of `wp_validate_auth_cookie()` in `admin-post.php`.
...
This matches the authentication check in `admin-ajax.php`, and allows the authentication method to be filtered.
Props jmdodd.
Fixes #45475 .
Built from https://develop.svn.wordpress.org/trunk@44615
git-svn-id: http://core.svn.wordpress.org/trunk@44446 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 05:41:50 +00:00
5ed802faf4
Docs: Correct the docs for `POMO_Reader::setEndian()`.
...
The parameter type and name where the wrong way around.
Props ishitaka.
Fixes #45410 .
Built from https://develop.svn.wordpress.org/trunk@44614
git-svn-id: http://core.svn.wordpress.org/trunk@44445 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 05:36:48 +00:00
19642fd0c9
Docs: Correct the `@return` type of `get_theme_mod()`.
...
This now matches the type of the `$value` parameter of `set_theme_mod()`.
Props mensmaximus.
Fixes #45319 .
Built from https://develop.svn.wordpress.org/trunk@44613
git-svn-id: http://core.svn.wordpress.org/trunk@44444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 05:32:48 +00:00
97aef0e336
Docs: Remove duplicate docblocks for the `pre_user_login` and `link_category` filters.
...
Props coffee2code.
Fixes #45308 .
Built from https://develop.svn.wordpress.org/trunk@44612
git-svn-id: http://core.svn.wordpress.org/trunk@44443 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 05:29:49 +00:00
655d44ffe8
Users: Add extra checking to `wp_new_user_notification()`.
...
Prevent a notification from being sent when an unrecognised value is passed in the `$notify` parameter.
Props cthreelabs, 360zen.
Fixes #44293 .
Built from https://develop.svn.wordpress.org/trunk@44611
git-svn-id: http://core.svn.wordpress.org/trunk@44442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 04:27:50 +00:00
dd9442ae6c
Posts: Set a HTTP 403 error when an incorrect post preview nonce is sent.
...
Props graymouser.
Fixes #43570 .
Built from https://develop.svn.wordpress.org/trunk@44610
git-svn-id: http://core.svn.wordpress.org/trunk@44441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 03:54:50 +00:00
6f723ddf50
Docs: Add documentation for the `wp_maybe_auto_update` action.
...
Props MikeGillihan.
Fixes #43301 .
Built from https://develop.svn.wordpress.org/trunk@44609
git-svn-id: http://core.svn.wordpress.org/trunk@44440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 03:38:49 +00:00
f2d2126d0d
Admin Bar: Set the Admin Bar to not be showing on REST API requests.
...
Props ayeshrajans.
Fixes #45727 .
Built from https://develop.svn.wordpress.org/trunk@44608
git-svn-id: http://core.svn.wordpress.org/trunk@44439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-16 02:54:50 +00:00
4bb472ac32
Docs: Add missing documentation for `_WP_Dependency::set_translations()`.
...
Introduced in [43859].
Props stazdotio.
Fixes #45550 .
Built from https://develop.svn.wordpress.org/trunk@44607
git-svn-id: http://core.svn.wordpress.org/trunk@44438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 22:48:51 +00:00
50ddffbac3
Privacy: Use consistent variable naming when working with privacy requests.
...
Throughout the core privacy functions, `WP_User_Request` instances were stored in variables named both `$request`, and `$request_data`. This changes all occurrences of `$request_data` to `$request` for better consistency.
Props nateallen, bruceallen, garrett-eclipse.
Fixes #44708 .
Built from https://develop.svn.wordpress.org/trunk@44606
git-svn-id: http://core.svn.wordpress.org/trunk@44437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 22:35:52 +00:00
c062e39ac8
Docs: Tweak the docblock for `setup_userdata()`.
...
This is a followup to [44603]. The default value should be last, not somewhere in the middle.
Props swissspidy.
Fixes #44697 .
Built from https://develop.svn.wordpress.org/trunk@44605
git-svn-id: http://core.svn.wordpress.org/trunk@44436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 10:29:50 +00:00
f76f57e8ab
Admin: Use the correct CSS media query for the Help tab on small screens after [44588].
...
See #43221
Built from https://develop.svn.wordpress.org/trunk@44604
git-svn-id: http://core.svn.wordpress.org/trunk@44435 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 07:48:50 +00:00
e0c4e5b610
Users: Correct the default value in `setup_userdata()`.
...
The `$for_user_id` parameter is an `int`, not a `string`, so the default value should be `0`, rather than an empty string.
Props subrataemfluence.
Fixes #44697 .
Built from https://develop.svn.wordpress.org/trunk@44603
git-svn-id: http://core.svn.wordpress.org/trunk@44434 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 06:33:50 +00:00
8ddef3e98d
Users: Check that a valid user is passed to `get_password_reset_key()`.
...
Props edocev.
Fixes #44601 .
Built from https://develop.svn.wordpress.org/trunk@44602
git-svn-id: http://core.svn.wordpress.org/trunk@44433 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 06:27:49 +00:00
a5d8a6bde3
Docs: Fix the `WP_Object_Cache::get()` docblock.
...
The `$force` parameter is a `bool`, not a `string`. The matching `wp_cache_get()` docblock has the correct type.
Props subrataemfluence.
Fixes #44454 .
Built from https://develop.svn.wordpress.org/trunk@44601
git-svn-id: http://core.svn.wordpress.org/trunk@44432 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 06:18:51 +00:00
656d8edcaf
Docs: Add docblocks for `WP_Customize_Header_Image_Control` member variables.
...
Props subrataemfluence.
Fixes #44410 .
Built from https://develop.svn.wordpress.org/trunk@44600
git-svn-id: http://core.svn.wordpress.org/trunk@44431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 05:54:48 +00:00
e4b25f1be2
Build Tools: Don't send AppVeyor notifications on Slack on repeated successful builds.
...
See #44276 .
Built from https://develop.svn.wordpress.org/trunk@44599
git-svn-id: http://core.svn.wordpress.org/trunk@44430 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 05:49:49 +00:00
883ee72ed6
Coding Standards: Move an assignment out of a condition in `wp-admin/admin.php`.
...
Props subrataemfluence, jrf, pento.
Fixes #44363 .
Built from https://develop.svn.wordpress.org/trunk@44598
git-svn-id: http://core.svn.wordpress.org/trunk@44429 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 05:48:50 +00:00
120710d8f8
Coding Standards: Move assignments out of conditions in `wp-includes/user.php`.
...
Props subrataemfluence.
See #44315 .
Built from https://develop.svn.wordpress.org/trunk@44597
git-svn-id: http://core.svn.wordpress.org/trunk@44428 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 05:38:49 +00:00
db696999f1
Updates: Tweak the "before updating, please back up..." message.
...
Props chetan200891, sebastien@thivinfo.com .
See #43790 .
Built from https://develop.svn.wordpress.org/trunk@44596
git-svn-id: http://core.svn.wordpress.org/trunk@44427 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 05:20:50 +00:00
4de7979b25
Build Tools: Tweak AppVeyor settings.
...
- Set `grunt build` as the build script
- Disable testing and deployment options
- Customise the Slack integration message
- Only show the Slack message when the status changes
See #44276 .
Built from https://develop.svn.wordpress.org/trunk@44595
git-svn-id: http://core.svn.wordpress.org/trunk@44426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 04:51:52 +00:00
c009a1960a
Build Tools: Add AppVeyor integration.
...
AppVeyor allows us to test in a Windows environment. This first iteration tests that building works correctly.
Props netweb.
Fixes #44276 .
Built from https://develop.svn.wordpress.org/trunk@44594
git-svn-id: http://core.svn.wordpress.org/trunk@44425 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 04:21:50 +00:00
59fbee8544
Coding Standards: Assignments must be the first block of code on a line.
...
Props subrataemfluence.
Fixes #44225 .
Built from https://develop.svn.wordpress.org/trunk@44593
git-svn-id: http://core.svn.wordpress.org/trunk@44424 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 02:41:50 +00:00
34c4ce3c81
Docs: Update inaccurate `return` descriptions.
...
In the `@return` tag description for `get_post_modified_time()`, `get_the_time()`, and `get_post_time()`, the `$d` parameter is incorrectly referred to as `$id`.
Props behzod.
Fixes #45323 .
Built from https://develop.svn.wordpress.org/trunk@44592
git-svn-id: http://core.svn.wordpress.org/trunk@44423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 02:08:49 +00:00
bf43978730
Link Template: In `get_adjacent_post()`, move the sanitisation of `$excluded_terms` earlier.
...
This is a followup to [42828], ensuring that the `get_{$adjacent}_post_excluded_terms` filter is always passed an array, as expected.
Props soulseekah, zottto.
Fixes #43521 .
Built from https://develop.svn.wordpress.org/trunk@44591
git-svn-id: http://core.svn.wordpress.org/trunk@44422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 01:54:49 +00:00
6073c6e209
Docs: Update the `@since` version for the `doing_it_wrong_trigger_error` filter.
...
Fixes #34183 .
Built from https://develop.svn.wordpress.org/trunk@44590
git-svn-id: http://core.svn.wordpress.org/trunk@44421 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 00:52:50 +00:00
2f288c306c
Widgets: Remove unnecessary `sanitize_text_field()` calls in core widget `::form()` methods.
...
This sanitisation only needs to be run in `::update()` to correctly clean up the input.
Props welcher, greenshady.
Fixes #42461 .
Built from https://develop.svn.wordpress.org/trunk@44589
git-svn-id: http://core.svn.wordpress.org/trunk@44420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 00:43:49 +00:00
11e9c98d5b
Admin: Make the Help tab available on small screens.
...
Props jobthomas, xkon.
Fixes #43221 .
Built from https://develop.svn.wordpress.org/trunk@44588
git-svn-id: http://core.svn.wordpress.org/trunk@44419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-15 00:20:50 +00:00
d2695fe283
Query: Cache the result when `get_pages()` doesn't find anything in the database.
...
Props flixos90, soulseekah.
Fixes #43514 .
Built from https://develop.svn.wordpress.org/trunk@44587
git-svn-id: http://core.svn.wordpress.org/trunk@44418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 23:27:50 +00:00
56e77d8928
Docs: Improve the docblock of `wp_admin_bar_edit_menu()`.
...
What age were you when you learned that there's a `$user_id` global, as well as `$user_ID` global? I was today years old.
Props pento, mukesh27.
Fixes #43448 .
Built from https://develop.svn.wordpress.org/trunk@44586
git-svn-id: http://core.svn.wordpress.org/trunk@44417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 23:12:50 +00:00
767fb99e94
Docs: Improve documentation of the ``$wp_registered_sidebars` global.
...
Props mukesh27.
Fixes #43448 .
Built from https://develop.svn.wordpress.org/trunk@44585
git-svn-id: http://core.svn.wordpress.org/trunk@44416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 23:01:49 +00:00
a7d0293446
Tests: Add missing `parent::tearDown()`.
...
Also, remove a `tearDown()` method that was not serving any purpose.
Fixes #45931 .
Built from https://develop.svn.wordpress.org/trunk@44584
git-svn-id: http://core.svn.wordpress.org/trunk@44415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 21:34:55 +00:00
51f4314441
Customizer: Use the `sandbox` attribute to prevent top navigation from the preview.
...
Props valchovski.
Fixes #42341 .
Built from https://develop.svn.wordpress.org/trunk@44583
git-svn-id: http://core.svn.wordpress.org/trunk@44414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 07:25:50 +00:00
b083cc65aa
Customizer: Fix a coding standards issue introduced in [44580].
...
See #40020 .
Built from https://develop.svn.wordpress.org/trunk@44582
git-svn-id: http://core.svn.wordpress.org/trunk@44413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 07:23:50 +00:00
0390ddad6b
Docs: Improve docblocks for `_get_plugin_data_markup_translate()` and `_sort_uname_callback()`.
...
Props Jaydeep Rami.
Fixes #42228 .
Built from https://develop.svn.wordpress.org/trunk@44581
git-svn-id: http://core.svn.wordpress.org/trunk@44412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 06:54:49 +00:00
d8f4a04232
Customizer: Improve browser compatibility of the preview iframe.
...
When `home` and `siteurl` are different, the customizer preview iframe will be blank in Chrome and Safari, due to their `X-Frame-Options` implementation quirks.
Changing this to `SAMEORIGIN` and adding the `frame-ancestors` Content Security Policy gives the correct behaviour.
Props fullyint.
Fixes #40020 .
Built from https://develop.svn.wordpress.org/trunk@44580
git-svn-id: http://core.svn.wordpress.org/trunk@44411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 06:38:51 +00:00
10c66fb426
Formatting: Remove soft hyphens when sanitising titles.
...
Props andg.
Fixes #45378 .
Built from https://develop.svn.wordpress.org/trunk@44579
git-svn-id: http://core.svn.wordpress.org/trunk@44410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 05:39:51 +00:00
fcd66d09d9
Widgets: Don't log invalid HTML in the Text Widget.
...
[41215] supresses these irrelevant error messages from the front end, this removes them from the error log, too.
Props jeherve.
Fixes #43815 .
Built from https://develop.svn.wordpress.org/trunk@44578
git-svn-id: http://core.svn.wordpress.org/trunk@44409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 05:05:48 +00:00
5ed789dc63
Tests: Add missing `parent::setUp()` calls to all test classes.
...
Props johnbillion, birgire.
Fixes #37375 .
Built from https://develop.svn.wordpress.org/trunk@44577
git-svn-id: http://core.svn.wordpress.org/trunk@44408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 04:54:50 +00:00
0bbfe3b8e2
Blocks: Add a `$source_block` parameter to the `render_block_data` filter.
...
This contains a copy of the block, unmodified by other filter functions, so that plugins have a clean reference to work from, if they need.
Props dmsnell.
Fixes #45451 .
Built from https://develop.svn.wordpress.org/trunk@44576
git-svn-id: http://core.svn.wordpress.org/trunk@44407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-14 01:47:51 +00:00
1c59f76953
Accessibility: Exclude the Windows High Contrast mode transparent outline from the CSS transition after [44544].
...
See #41286 .
Built from https://develop.svn.wordpress.org/trunk@44575
git-svn-id: http://core.svn.wordpress.org/trunk@44406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 15:01:49 +00:00
7a617078fa
Coding Standards: Upgrade WPCS to 1.2.1.
...
This upgrade fixes quite a few false positives, as well as auto-fixing some indenting issues.
Fixes #45956 .
Built from https://develop.svn.wordpress.org/trunk@44574
git-svn-id: http://core.svn.wordpress.org/trunk@44405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:41:52 +00:00
8656a65e1e
Coding Standards: Fix and whitelist variable names.
...
From the `WordPress.NamingConventions.ValidVariableName` sniff, this commit fixes/whitelists all `NotSnakeCaseMemberVar`, `MemberNotSnakeCase`, and `StringNotSnakeCase` violations. It also fixes a handful of the `NotSnakeCase` violations.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44573
git-svn-id: http://core.svn.wordpress.org/trunk@44404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 06:06:48 +00:00
3a697f7f46
Coding Standards: Remove an unnecessary line whitelisting.
...
Props jrf.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44572
git-svn-id: http://core.svn.wordpress.org/trunk@44403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 04:53:51 +00:00
f72594974f
Coding Standards: Exclude some external files.
...
- `class-wp-block-parser.php` and `wp-includes/blocks/*` are imported from the Gutenberg plugin.
- `speed-trap-listener.php` is a third party library.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44571
git-svn-id: http://core.svn.wordpress.org/trunk@44402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 04:01:50 +00:00
57fcb7d8dd
Coding Standards: Fix an incorrect `phpcs:ignore` comment.
...
It's `phpcs:ignore`, not `wpcs:ignore`.
Props GaryJ.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44570
git-svn-id: http://core.svn.wordpress.org/trunk@44401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 03:49:49 +00:00
08e8270a48
Coding Standards: Extract `extract()` from the codebase.
...
Of the last four instances of `extract()` occurring, three of them are removed by this commit, and the fourth is appropriately documented.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44569
git-svn-id: http://core.svn.wordpress.org/trunk@44400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-12 03:20:48 +00:00
2785313bf2
REST API: Encourage proper usage of `register_rest_route()`.
...
Calling `register_rest_route()` too early in the loading process has the potential to cause some unintentional problems and pitfalls. Because `register_rest_route()` calls `rest_get_server()` (which creates the `WP_REST_Server` instance), calling the function directly and/or before `rest_api_init` should be discouraged.
For example, if `register_rest_route ()` is called on `init`, the REST API server instance is set up (and all functions added to `rest_api_init` and other related hooks are invoked), even though the current request may not be a REST request. Also, if `register_rest_route()` is called even earlier (say, in an `mu-plugin` file), required endpoints may be missing since normal plugins have not yet been loaded and have not had a chance to register their own action hooks.
This adds a `_doing_it_wrong()` notice the first time `register_rest_route()` is called before `rest_api_init` in a request to encourage best practices for registering REST API routes.
Props kraftbj, desrosj, timothyblynjacobs.
Fixes #45265 .
Built from https://develop.svn.wordpress.org/trunk@44568
git-svn-id: http://core.svn.wordpress.org/trunk@44399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 18:19:49 +00:00
298ef1992e
Menus: Make menu items not jump while dragging items.
...
Props alexvorn2, welcher, afercia.
Fixes #41160 .
Built from https://develop.svn.wordpress.org/trunk@44567
git-svn-id: http://core.svn.wordpress.org/trunk@44398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 13:56:49 +00:00
4f861b9548
Coding Standards: Fix the `Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace` violations.
...
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44566
git-svn-id: http://core.svn.wordpress.org/trunk@44397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 06:40:50 +00:00
6d5cd6842a
Coding Standards: Document intentional `case` block fall-throughs.
...
Fixes `PSR2.ControlStructures.SwitchDeclaration.TerminatingComment` violations.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44565
git-svn-id: http://core.svn.wordpress.org/trunk@44396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 06:26:50 +00:00
c00229969a
Coding Standards: Add exceptions for `WordPress.Files.FileName.NotHyphenatedLowercase`.
...
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44564
git-svn-id: http://core.svn.wordpress.org/trunk@44395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 06:17:50 +00:00
3cbd512161
Coding Standards: Ignore the violations of `Generic.NamingConventions.UpperCaseConstantName.ConstantNotUpperCase`.
...
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44563
git-svn-id: http://core.svn.wordpress.org/trunk@44394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 06:08:50 +00:00
c008959e9e
Coding Standards: Fix the minor `WordPress.WP.I18n` violations.
...
`WordPress.WP.I18n.MissingTranslatorsComment` is in progress in #44360 .
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44562
git-svn-id: http://core.svn.wordpress.org/trunk@44393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 06:04:49 +00:00
e05b19d248
Coding Standards: `template.php` isn't a template tag file.
...
`WordPress.Files.FileName.InvalidTemplateTagFileName` shouldn't apply to it.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44561
git-svn-id: http://core.svn.wordpress.org/trunk@44392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 05:00:50 +00:00
9e87cb7fa2
Coding Standards: Ignore the single WordPress.PHP.RestrictedPHPFunctions.create_function_create_function violation.
...
This is intentional, for older PHP support.
See #45934 .
Built from https://develop.svn.wordpress.org/trunk@44560
git-svn-id: http://core.svn.wordpress.org/trunk@44391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 03:45:48 +00:00
5afa0c9ee3
Coding Standards: Remove PHPCS 2.x `@codingStandardsIgnore*` ignore syntax.
...
Props netweb.
Fixes #42808 .
Built from https://develop.svn.wordpress.org/trunk@44559
git-svn-id: http://core.svn.wordpress.org/trunk@44390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 03:04:51 +00:00
3c0c01f348
Post WordPress 5.1 Beta 1 version bump.
...
Built from https://develop.svn.wordpress.org/trunk@44558
git-svn-id: http://core.svn.wordpress.org/trunk@44389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 00:59:50 +00:00
e11b64ddba
WordPress 5.1 Beta 1.
...
Built from https://develop.svn.wordpress.org/trunk@44557
git-svn-id: http://core.svn.wordpress.org/trunk@44388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-11 00:42:48 +00:00
8e623691c0
Emoji: Fix a code formatting error introduced in [44554].
...
See #45930 .
Built from https://develop.svn.wordpress.org/trunk@44556
git-svn-id: http://core.svn.wordpress.org/trunk@44387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 23:40:49 +00:00
203d686ec9
Blocks: Reverse the logic when checking the `pre_render_block` result.
...
We should be returning if the result isn't null, not when it is.
See #45451 .
Built from https://develop.svn.wordpress.org/trunk@44555
git-svn-id: http://core.svn.wordpress.org/trunk@44386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 23:31:50 +00:00
92146fe52b
Emoji: Improve performance when encoding or staticizing emoji.
...
Both `wp_encode_emoji()` and `wp_staticize_emoji()` perform a PHP version check when deciding how to apply their behaviour, but this check only needs to happen once, rather than every time in their internal looks.
Moving the check outside of the loop reduces processing time by 50%.
Props johnbillion.
Fixes #45930 .
Built from https://develop.svn.wordpress.org/trunk@44554
git-svn-id: http://core.svn.wordpress.org/trunk@44385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 23:20:52 +00:00
8e2f6a9923
Blocks: Add the `pre_render_block` and `render_block_data` filters.
...
At the start of `render_block()`, the `pre_render_block` filter allows the function to be short-circuited, and the `render_block_data` filter is applied to the `$block` parameter before it's processed.
Props kkarpieszuk, pento.
Fixes #45451 .
Built from https://develop.svn.wordpress.org/trunk@44553
git-svn-id: http://core.svn.wordpress.org/trunk@44384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 23:16:50 +00:00
b98affb210
Embeds: Remove Photobucket, FunnyOrDie from the list of oEmbed providers.
...
These services no longer support oEmbed.
Props skostadinov, notnownikki.
Fixes #45399 .
Built from https://develop.svn.wordpress.org/trunk@44552
git-svn-id: http://core.svn.wordpress.org/trunk@44383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 22:42:51 +00:00
9a9b5699fd
Accessibility: Improve text input in the Tags meta box when using Safari + Voiceover.
...
Props parbaugh, konainm, wbrubaker, pento, ryelle.
Fixes #44966 .
Built from https://develop.svn.wordpress.org/trunk@44551
git-svn-id: http://core.svn.wordpress.org/trunk@44382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 22:30:49 +00:00
d11928bc65
Docs: Add missing periods to `param` annotations for `flip()` in `WP_Image_Editor_GD`.
...
Props hitendra-chopda.
Fixes #45208 .
Built from https://develop.svn.wordpress.org/trunk@44550
git-svn-id: http://core.svn.wordpress.org/trunk@44381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 22:10:50 +00:00
64bbbda39e
Accessibility: Improve color contrast ratio in the Events and News dashboard widget.
...
Props boemedia, lucagrandicelli.
Fixes #45280 .
Built from https://develop.svn.wordpress.org/trunk@44549
git-svn-id: http://core.svn.wordpress.org/trunk@44380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 22:08:49 +00:00
3dcc536b80
Media: Correct `since` annotation for adding the `caption_id` attribute.
...
Introduced in [42704]
Fixes #34595 .
Built from https://develop.svn.wordpress.org/trunk@44548
git-svn-id: http://core.svn.wordpress.org/trunk@44379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 21:37:49 +00:00
be54938eef
General: Fix existing coding standard violations in bookmark tests, as outlined in [44546].
...
See #43977 .
Built from https://develop.svn.wordpress.org/trunk@44547
git-svn-id: http://core.svn.wordpress.org/trunk@44378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 21:17:51 +00:00
a71d208785
General: Fix problematic string to array parsing.
...
WordPress has historically often used code like `preg_split( '/[\s,]+/', $var )` to parse a string of comma-separated values into an array. However, this approach was causing an empty string to not be parsed into an empty array as expected, but rather into an array with the empty string as its sole element.
This was among other areas causing problems in the REST API where passing an empty request parameter could cause that request to fail because, instead of it being ignored, that parameter would be compared against the valid values for it, which typically do not include an empty string.
Props david.binda, sstoqnov.
Fixes #43977 .
Built from https://develop.svn.wordpress.org/trunk@44546
git-svn-id: http://core.svn.wordpress.org/trunk@44377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 21:06:49 +00:00
0b5beabd36
Accessibility: Remove negative tabindex from the login, install, and setup pages header.
...
Props bamadesigner, rishishah, jainnidhi.
Fixes #42632 .
Built from https://develop.svn.wordpress.org/trunk@44545
git-svn-id: http://core.svn.wordpress.org/trunk@44376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 17:21:52 +00:00
7481337591
Accessibility: Add focus styles for Windows High Contrast mode.
...
Introduces in core new focus styles dedicated to Windows High Contrast mode. The
new styles use a transparent CSS outline as already explored in the Block Editor.
This first part covers some of the main user interface controls like buttons, links,
and media views elements. Other parts will be addressed in the next future.
Fixes #41286 .
Built from https://develop.svn.wordpress.org/trunk@44544
git-svn-id: http://core.svn.wordpress.org/trunk@44375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 16:47:50 +00:00
c40ae024cd
Accessibility: Improve the way Safari and VoiceOver read out the screen reader text.
...
Sometimes, Safari and VoiceOver read out the text hidden with `screen-reader-text`
in a wrong order. While there's no known, full, solution, it is possible to make
them respect the correct order reliably at least within buttons.
Fixes #42006 .
Built from https://develop.svn.wordpress.org/trunk@44543
git-svn-id: http://core.svn.wordpress.org/trunk@44374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 16:31:49 +00:00
ae5c195d57
Media: Introduce the `has_post_thumbnail` filter.
...
Props rzen, desrosj.
Fixes #44859 .
Built from https://develop.svn.wordpress.org/trunk@44542
git-svn-id: http://core.svn.wordpress.org/trunk@44373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 15:28:50 +00:00
f251342de7
I18n: Add missing translator comments in `wp-admin/includes/class-wp-plugins-list-table.php`.
...
Fixes #45898 .
Built from https://develop.svn.wordpress.org/trunk@44541
git-svn-id: http://core.svn.wordpress.org/trunk@44372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 10:46:53 +00:00
ca36ed433b
Docs: Correct `since` annotation for `_wp_get_allowed_postdata()`.
...
This function was introduced in 5.0.1, not 4.9.9 as currently indicated. Introduced in [44047].
Built from https://develop.svn.wordpress.org/trunk@44540
git-svn-id: http://core.svn.wordpress.org/trunk@44371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 03:31:49 +00:00
2772e5ec06
Admin: Don't use the `keyup` event in addition to the `input` event.
...
The `keyup` event was used to provide support for IE8, where which doesn't support the `input` event. As we dropped IE8 support some time ago, this was simply adding unnecessary complexity and double-event triggers.
Props dlh, afercia.
Fixes #32882 .
Built from https://develop.svn.wordpress.org/trunk@44539
git-svn-id: http://core.svn.wordpress.org/trunk@44370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:57:50 +00:00
8eb90ac374
Docs: Restore `output` annotation in `tags-suggest.js`.
...
This was mistakenly removed in [44537].
See #38922 .
Built from https://develop.svn.wordpress.org/trunk@44538
git-svn-id: http://core.svn.wordpress.org/trunk@44369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:50:51 +00:00
6fbf4ceaea
REST API: Restore use of `wp_ajax_ajax_tag_search()` for tag search.
...
This solution does not work with custom taxonomies in the current state.
Reverts [42614,42619,42737].
Props danielbachhuber.
See #38922 .
Built from https://develop.svn.wordpress.org/trunk@44537
git-svn-id: http://core.svn.wordpress.org/trunk@44368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:37:51 +00:00
8441700842
Tests: Add support for a `WP_TESTS_SKIP_INSTALL` environment variable.
...
Defining `WP_TESTS_SKIP_INSTALL=1` when running tests will skip the install step. While this shouldn't be used for full test runs, it's useful for saving time when running small groups of tests.
Props soulseekah.
Fixes #43432 .
Built from https://develop.svn.wordpress.org/trunk@44536
git-svn-id: http://core.svn.wordpress.org/trunk@44367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:19:50 +00:00
7855451267
Privacy: Add unit tests for privacy erasure fulfillment notifications.
...
Adds appropriate unit tests for `_wp_privacy_send_erasure_fulfillment_notification()`.
Props birgire, desrosj.
Fixes #44234 .
Built from https://develop.svn.wordpress.org/trunk@44535
git-svn-id: http://core.svn.wordpress.org/trunk@44366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:07:49 +00:00
c219081ce7
Build/Tests: Allow running unit tests from `src`.
...
This is a partial recommit of [44509]: it allows running unit tests from `src` (which is useful), but doesn't make it the default (which Travis is having issues with).
See #45863 .
Built from https://develop.svn.wordpress.org/trunk@44534
git-svn-id: http://core.svn.wordpress.org/trunk@44365 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 02:04:50 +00:00
14c44ad703
Block Editor: Upgrade the `@wordpress/` packages.
...
This brings the block editor in core up to date with the Gutenberg 4.8 plugin release.
Props aduth, gziolo, youknowriad, mkaz, jorgefilipecosta, swissspidy, iseulde, soean, noisysocks, joen, brentswisher, dekervit, dimadin, zebulan, johnny5, nosolosw, netweb, ryelle, etoledom, mzorz, desrosj, mmtr86, tinkerbelly, ocean90, earnjam, ajitbohra, talldanwp, notnownikki, mcsf, afercia, adamsilverstein, gutendev, naoki0h, miyauchi, aldavigdis.
Fixes #45885 .
Built from https://develop.svn.wordpress.org/trunk@44533
git-svn-id: http://core.svn.wordpress.org/trunk@44364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:54:56 +00:00
da77cad30f
PHPCS: Fix formatting issues.
...
Fixes formatting issues introduced in [44528].
See #42017 .
Built from https://develop.svn.wordpress.org/trunk@44532
git-svn-id: http://core.svn.wordpress.org/trunk@44363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:52:52 +00:00
72098048c6
Docs: Update `since` annotation for `text-transform` support in `safecss_filter_attr()`.
...
Introduced in [42880].
Fixes #42729 .
Built from https://develop.svn.wordpress.org/trunk@44531
git-svn-id: http://core.svn.wordpress.org/trunk@44362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:43:49 +00:00
d83d8e1154
Docs: Update `since` annotation for `comments_list_table_query_args`.
...
Introduced in [42420].
Fixes #42997 .
Built from https://develop.svn.wordpress.org/trunk@44530
git-svn-id: http://core.svn.wordpress.org/trunk@44361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:40:51 +00:00
e69c1039eb
Build Tools: Copy unminified JS files to `src`.
...
This allows `SCRIPT_DEBUG` to be set to `true` when running from `src`.
Fixes #45869 .
Built from https://develop.svn.wordpress.org/trunk@44529
git-svn-id: http://core.svn.wordpress.org/trunk@44360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:39:50 +00:00
13c66b1b18
Media: Store audio creation date in meta.
...
In [41746], `wp_get_media_creation_timestamp()` was introduced to read the created timestamp for videos from `getID3` in meta whenever possible. This information is useful separately from the dates on the file itself.
This adds the same support audio files by utilizing `wp_get_media_creation_timestamp()` in `wp_read_audio_metadata()`.
Props blob folio, desrosj.
Fixes #42017 .
Built from https://develop.svn.wordpress.org/trunk@44528
git-svn-id: http://core.svn.wordpress.org/trunk@44359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-10 01:32:50 +00:00
cf1e3b0c40
Docs: Update `since` annotations `WP_Error::has_errors()`
...
Introduced in [42761].
Fixes #42742 .
Built from https://develop.svn.wordpress.org/trunk@44527
git-svn-id: http://core.svn.wordpress.org/trunk@44358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 22:42:51 +00:00
5bb4a5aa0e
Upgrade/Install: Add missing call to clear site meta cache in `populate_site_meta()`.
...
See #44896 .
Built from https://develop.svn.wordpress.org/trunk@44526
git-svn-id: http://core.svn.wordpress.org/trunk@44357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 21:29:50 +00:00
83603991c6
Bootstrap/Load: Fix missing object argument for singular capability checks and support capability tests overlooked in [44524].
...
See #44458 .
Built from https://develop.svn.wordpress.org/trunk@44525
git-svn-id: http://core.svn.wordpress.org/trunk@44356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 20:44:50 +00:00
1e4088fc98
Bootstrap/Load: Introduce fatal error recovery mechanism allowing users to still log in to their admin dashboard.
...
This changeset introduces a `WP_Shutdown_Handler` class that detects fatal errors and which extension (plugin or theme) causes them. Such an error is then recorded, and an error message is displayed. Subsequently, in certain protected areas, for example the admin, the broken extension will be paused, ensuring that the website is still usable in the respective area. The major benefit is that this mechanism allows site owners to still log in to their website, to fix the problem by either disabling the extension or solving the bug and then resuming the extension.
Extensions are only paused in certain designated areas. The frontend for example stays unaffected, as it is impossible to know what pausing the extension would cause to be missing, so it might be preferrable to clearly see that the website is temporarily not accessible instead.
The fatal error recovery is especially important in scope of encouraging the switch to a maintained PHP version, as not necessarily every WordPress extension is compatible with all PHP versions. If problems occur now, non-technical site owners that do not have immediate access to the codebase are not locked out of their site and can at least temporarily solve the problem quickly.
Websites that have custom requirements in that regard can implement their own shutdown handler by adding a `shutdown-handler.php` drop-in that returns the handler instance to use, which must be based on a class that inherits `WP_Shutdown_Handler`. That handler will then be used in place of the default one.
Websites that would like to modify specifically the error template displayed in the frontend can add a `php-error.php` drop-in that works similarly to the existing `db-error.php` drop-in.
Props afragen, bradleyt, flixos90, ocean90, schlessera, SergeyBiryukov, spacedmonkey.
Fixes #44458 .
Built from https://develop.svn.wordpress.org/trunk@44524
git-svn-id: http://core.svn.wordpress.org/trunk@44355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 20:05:49 +00:00
811be4779e
Taxonomy: Update `@since` annotations for `meta_box_sanitize_cb` arg.
...
Introduced in [42211].
Fixes #36514 .
Built from https://develop.svn.wordpress.org/trunk@44519
git-svn-id: http://core.svn.wordpress.org/trunk@44350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 15:11:48 +00:00
04dff0e2a9
Docs: Update `since` annotations for adding `LIKE` comparisons with meta keys.
...
Previously introduced in [42768].
Fixes #42409 .
Built from https://develop.svn.wordpress.org/trunk@44518
git-svn-id: http://core.svn.wordpress.org/trunk@44349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 14:55:49 +00:00
1224ebd0ac
Build/Test Tools: Update `.gitignore` to exclude `twentynineteen` and `twentysixteen`.
...
Brings the list of bundled themes in `.gitignore` up to date.
Fixes #45474 .
Built from https://develop.svn.wordpress.org/trunk@44517
git-svn-id: http://core.svn.wordpress.org/trunk@44348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 13:45:49 +00:00
9bcdc25145
Build/Test Tools: Fix coding standards issues after [44515] and [44514].
...
See #44494 , #43743 .
Built from https://develop.svn.wordpress.org/trunk@44516
git-svn-id: http://core.svn.wordpress.org/trunk@44347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 12:37:49 +00:00
8f5e0ae06c
Taxonomy: Display term list table in full width if there is no edit form.
...
Makes sure there is no empty space when a user can manage terms but lacks the capability to edit terms.
Props mathieuhays, marcwieland95.
Fixes #43743 .
Built from https://develop.svn.wordpress.org/trunk@44515
git-svn-id: http://core.svn.wordpress.org/trunk@44346 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 12:05:50 +00:00
a595f8a525
I18N: Add option to hide en_US locale in `wp_dropdown_languages()`.
...
Props danieltj for initial patch.
Fixes #44494 .
Built from https://develop.svn.wordpress.org/trunk@44514
git-svn-id: http://core.svn.wordpress.org/trunk@44345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 11:46:50 +00:00
d32d061a5e
Upgrade/Install: Prevent possible JavaScript error when updating translations.
...
Props Presskopp.
Fixes #39189 .
Built from https://develop.svn.wordpress.org/trunk@44513
git-svn-id: http://core.svn.wordpress.org/trunk@44344 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 11:26:50 +00:00
f57b25f447
Tests: Revert [44509].
...
This commit causes Travis to fail.
See #45863 .
Built from https://develop.svn.wordpress.org/trunk@44512
git-svn-id: http://core.svn.wordpress.org/trunk@44343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 11:14:51 +00:00
3b0b49f900
Embeds: Fix typo introduced in [44484].
...
Props JustinSainton.
Fixes #45036 .
Built from https://develop.svn.wordpress.org/trunk@44511
git-svn-id: http://core.svn.wordpress.org/trunk@44342 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:54:51 +00:00
f9208ac14e
Tests: Improve REST API tests for categories and tags.
...
Props birgire, SergeyBiryukov.
See #39122 .
Fixes #45077 .
Built from https://develop.svn.wordpress.org/trunk@44510
git-svn-id: http://core.svn.wordpress.org/trunk@44341 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:31:51 +00:00
0062616aa7
Build/Tests: Default to running unit tests from `src`.
...
This is the actual commit, unlike [44508], which was not.
Props atimmer.
See #44492 .
Fixes #45863 .
Built from https://develop.svn.wordpress.org/trunk@44509
git-svn-id: http://core.svn.wordpress.org/trunk@44340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:14:55 +00:00
e0caaf7628
Build/Tests: Default to running unit tests from `src`.
...
This commit also defaults WP-CLI commands to running against `src`, too.
Props atimmer, pento.
See #44492 .
Fixes #45863 .
Built from https://develop.svn.wordpress.org/trunk@44508
git-svn-id: http://core.svn.wordpress.org/trunk@44339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:10:51 +00:00
6503f77539
Build/Tools: Fix typo in `phpcs.xml.dist`.
...
See #44366 .
Built from https://develop.svn.wordpress.org/trunk@44507
git-svn-id: http://core.svn.wordpress.org/trunk@44338 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 10:02:53 +00:00
9f25ea37c7
Filesystem: Improve `wp_is_stream()` performance.
...
Instead of turning the return value of `stream_get_wrappers()` into a regex to match the scheme, we can instead extract the scheme and search the return value of `stream_get_wrappers()`.
Props schlessera, swissspidy.
Fixes #45553 .
Built from https://develop.svn.wordpress.org/trunk@44506
git-svn-id: http://core.svn.wordpress.org/trunk@44337 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 09:51:54 +00:00
184c501d5c
Cron: Fix undefined variable notice.
...
Restore `$gmt_time` variable removed in error from [44483].
Props afragen.
Fixes #45870 .
Built from https://develop.svn.wordpress.org/trunk@44505
git-svn-id: http://core.svn.wordpress.org/trunk@44336 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 08:37:51 +00:00
f88769fc3b
Block Editor: Obey the `AUTOSAVE_INTERVAL` constant.
...
Props youknowriad.
Fixes #45262 .
Built from https://develop.svn.wordpress.org/trunk@44504
git-svn-id: http://core.svn.wordpress.org/trunk@44335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:54:49 +00:00
68f2d8f0af
Docs: Correct the documentation for `wp_list_authors()`.
...
The `exclude_admin` argument defaults to `true`, not `false`.
Props haruharuharuby.
Fixes #45120 .
Built from https://develop.svn.wordpress.org/trunk@44503
git-svn-id: http://core.svn.wordpress.org/trunk@44334 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:52:50 +00:00
21ff86cf43
Comments: Add new tests missed in [44499].
...
Props dshanske, birgire.
Fixes #44033 .
Built from https://develop.svn.wordpress.org/trunk@44502
git-svn-id: http://core.svn.wordpress.org/trunk@44333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:20:50 +00:00
f9d879905d
Docs: Document the `$page_hook` action.
...
Props johnbillion.
Fixes #43643 .
Built from https://develop.svn.wordpress.org/trunk@44501
git-svn-id: http://core.svn.wordpress.org/trunk@44332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:14:51 +00:00
be127956e0
Bundled Themes: Run the `pingback_url` through `esc_url()`.
...
Twenties Ten through Seventeen have been updated to properly escape the pingback URL. Twenty Nineteen is already escaping the URL.
Props soulseekah, sharaz.
Fixes #43717 .
Built from https://develop.svn.wordpress.org/trunk@44500
git-svn-id: http://core.svn.wordpress.org/trunk@44331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:11:51 +00:00
eeac928d3b
Comments: Add a new `is_avatar_comment_type()` function.
...
This function splits the `get_avatar_comment_types` filter out of `get_avatar_data()`.
Props dshanske, birgire.
Fixes #44033 .
Built from https://develop.svn.wordpress.org/trunk@44499
git-svn-id: http://core.svn.wordpress.org/trunk@44330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 06:00:51 +00:00
05c1030151
Docs: Add docblocks to the members of `WP_Widget_Form_Customize_Control`.
...
Props subrataemfluence.
Fixes #44420 .
Built from https://develop.svn.wordpress.org/trunk@44498
git-svn-id: http://core.svn.wordpress.org/trunk@44329 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:49:49 +00:00
61dce1d422
Docs: Add docblocks for the PHPUnit factory objects.
...
Props andizer.
Fixes #44521 .
Built from https://develop.svn.wordpress.org/trunk@44497
git-svn-id: http://core.svn.wordpress.org/trunk@44328 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:44:49 +00:00
a583725622
Docs: Update Codex references to the `Template_Hierarchy` page.
...
https://codex.wordpress.org/Template_Hierarchy redirects to https://developer.wordpress.org/themes/basics/template-hierarchy/ , so we should link to the correct page.
Props kmeze, pento.
Fixes #45222 .
Built from https://develop.svn.wordpress.org/trunk@44496
git-svn-id: http://core.svn.wordpress.org/trunk@44327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:09:51 +00:00
e357f68667
Docs: Add `@see WP_Session_Tokens` to the `WP_User_Meta_Session_Tokens` docblock.
...
Props utsav72640.
Fixes #45499 .
Built from https://develop.svn.wordpress.org/trunk@44495
git-svn-id: http://core.svn.wordpress.org/trunk@44326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:04:50 +00:00
0b44fae46b
Privacy: Fix a code formatting error introduced in [44491].
...
See #44908 .
Built from https://develop.svn.wordpress.org/trunk@44494
git-svn-id: http://core.svn.wordpress.org/trunk@44325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 04:33:50 +00:00
47e29ccba9
Privacy: Tweak the wording of the success notice when updating the privacy policy page setting.
...
Props garrett-eclipse.
Fixes #44129 .
Built from https://develop.svn.wordpress.org/trunk@44493
git-svn-id: http://core.svn.wordpress.org/trunk@44324 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 04:19:49 +00:00
099238e3a3
Privacy: Always show the privacy policy guide.
...
Previously, the link to the privacy policy guide would only be displayed when a privacy policy page had been selected, but the guide is generally useful without that.
Props mukesh27, birgire.
Fixes #44871 .
Built from https://develop.svn.wordpress.org/trunk@44492
git-svn-id: http://core.svn.wordpress.org/trunk@44323 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 04:01:50 +00:00
53e40b7fda
Privacy: Remove some unnecessary parameters being passed to `wp_update_post()` by `wp_generate_user_request_key()`.
...
Props garrett-eclipse.
Fixes #44908 .
Built from https://develop.svn.wordpress.org/trunk@44491
git-svn-id: http://core.svn.wordpress.org/trunk@44322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 03:51:48 +00:00
f7d21862e8
Help/About: Add a `lang` attribute to the `<html>` tag in `readme.html`
...
Props audrasjb.
Fixes #44955 .
Built from https://develop.svn.wordpress.org/trunk@44490
git-svn-id: http://core.svn.wordpress.org/trunk@44321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 02:56:51 +00:00
19f9dd29e9
Login: Improve the error message when retrieving a lost password.
...
When an invalid username or email address is entered, the form now displays a better error message.
Props mrtortai, iamfriendly, TomHarrigan, afercia, pento.
Fixes #31788 .
Built from https://develop.svn.wordpress.org/trunk@44489
git-svn-id: http://core.svn.wordpress.org/trunk@44320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 02:06:50 +00:00
942f35446f
Cron API: Make wp-cron.php non-blocking where possible.
...
This should make cron spawning faster by ensuring requests to wp-cron.php return immediately regardless of transport method. It is enabled only on recent PHP versions with fastcgi, due to historical bugs and availability of `fastcgi_finish_request()`. This needs testing on a range of platforms, to help determine if it's safe to use in other contexts also.
Props vnsavage, johnbillion, jnylen0.
See #18738 , #41358
Built from https://develop.svn.wordpress.org/trunk@44488
git-svn-id: http://core.svn.wordpress.org/trunk@44319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 01:07:39 +00:00
fd7086bcdc
Docs: Update the `@since` tag for the `comment_status_links` filter.
...
Fixes #42379 .
Built from https://develop.svn.wordpress.org/trunk@44487
git-svn-id: http://core.svn.wordpress.org/trunk@44318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 01:06:48 +00:00
c6dea4c784
Embeds: Add Instagram TV support.
...
Props dannydehaan.
Fixes #44557 .
Built from https://develop.svn.wordpress.org/trunk@44486
git-svn-id: http://core.svn.wordpress.org/trunk@44317 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 00:24:50 +00:00
0888007275
Admin: Add a "Set up your homepage" link to the Welcome panel.
...
As many WordPress sites use a static homepage rather than a blog, this link gives a natural next step for new sites owners wanting to configure their site in this manner.
Props professor44, joyously, nielslange, mukesh27, melchoyce.
Fixes #45019 .
Built from https://develop.svn.wordpress.org/trunk@44485
git-svn-id: http://core.svn.wordpress.org/trunk@44316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 00:12:49 +00:00
64d846c7c2
Embeds: Polldaddy is now called Crowdsignal.
...
Crowdsignal adds an additional embed URL, survey.fm.
Props donncha.
Fixes #45036 .
Built from https://develop.svn.wordpress.org/trunk@44484
git-svn-id: http://core.svn.wordpress.org/trunk@44315 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 23:52:50 +00:00
bf3c97de77
Cron API: Add function and filter to return ready cron jobs.
...
Add the function `wp_get_ready_cron_jobs()` to return a modified version of the cron array limited to jobs ready to be run, ie with a timestamp of `time()` or earlier.
The new function includes the filter `pre_get_ready_cron_jobs` to allow for custom cron storage systems. This rounds out the functionality added in #32656 .
Props Pento for code review.
Fixes #45797 .
Built from https://develop.svn.wordpress.org/trunk@44483
git-svn-id: http://core.svn.wordpress.org/trunk@44314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 21:49:49 +00:00
cd7b916d55
REST API: Introduce `rest_post_search_query` filter.
...
This filter allows the query arguments to be manipulated for a post search query in the REST API.
Props Chouby, swissspidy.
Fixes #45454 .
Built from https://develop.svn.wordpress.org/trunk@44482
git-svn-id: http://core.svn.wordpress.org/trunk@44313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 21:45:48 +00:00
f510ab9e94
Media: improve the `human_readable_duration` function and tests.
...
Improve the `human_readable_duration` added in #39667 :
* Remove upper limit.
* More resilient handling: remove negative prefix, trim.
* Correct @since to 5.1.0.
* Adds more test cases and improve inline docs.
Props birgire.
Fixes #39667 .
Built from https://develop.svn.wordpress.org/trunk@44481
git-svn-id: http://core.svn.wordpress.org/trunk@44312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 19:56:48 +00:00
bdaf864ec9
Docs: Improve accuracy of `wp_list_sort()`’s `$list` parameter description.
...
Props manikmist09.
Fixes #45766 .
Built from https://develop.svn.wordpress.org/trunk@44480
git-svn-id: http://core.svn.wordpress.org/trunk@44311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 19:54:50 +00:00
58d5410ceb
Docs: Fix typos in Twenty Seventeen function descriptions.
...
Props faisal03, mukesh27.
Fixes #45466 .
Built from https://develop.svn.wordpress.org/trunk@44479
git-svn-id: http://core.svn.wordpress.org/trunk@44310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 19:22:49 +00:00
619285c34c
Tests: Add missing test cases for `is_serialized_string()`.
...
Also, reorganize these tests into their own class.
Props pbearne.
Fixes #42870 .
Built from https://develop.svn.wordpress.org/trunk@44478
git-svn-id: http://core.svn.wordpress.org/trunk@44309 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 19:05:49 +00:00
51155f3989
Docs: Specify missing `global` variables used in `wp_print_theme_file_tree()`.
...
The `$relative_file` and `$stylesheet` variables are used in the `wp_print_theme_file_tree()` function but were not noted within the inline documentation.
Props mukesh27, desrosj,
Fixes #43682 .
Built from https://develop.svn.wordpress.org/trunk@44477
git-svn-id: http://core.svn.wordpress.org/trunk@44308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 18:33:49 +00:00
e08a12d020
General: Make Update PHP notice link customizable.
...
After [42832], [42891] and [43006], this changeset refines the core notice informing about an outdated PHP version:
* The link to the Update PHP information page can now be adjusted using either a `WP_UPDATE_PHP_URL` environment variable, or a new `wp_update_php_url` filter.
* If that URL is different from the default one that points to https://wordpress.org/support/update-php/ or its localized equivalent, a note indicates that the linked resource has not been provided by WordPress itself, and the default URL is still linked to as an additional resource.
* The URL for the default information page has been updated to use the slug `update-php` instead of `upgrade-php`.
* `@since` annotations have been updated.
Going forward, admin areas that display information related to the PHP version should use the new function `wp_get_update_php_url()`.
Props afragen, fierevere, flixos90, markjaquith, miss_jwo, nerrad, pento, schlessera, SergeyBiryukov, spacedmonkey.
Fixes #45686 . See #41191 .
Built from https://develop.svn.wordpress.org/trunk@44476
git-svn-id: http://core.svn.wordpress.org/trunk@44307 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 17:27:50 +00:00
1f6da37438
Docs: Fix order of parameter type and variable name.
...
The order of the type and variable name in the `param` tags for the `wp_get_default_privacy_policy_content` filter is incorrectly reversed. This moves the two into the correct order.
Props ishitaka, mukesh27.
Fixes #45416 .
Built from https://develop.svn.wordpress.org/trunk@44475
git-svn-id: http://core.svn.wordpress.org/trunk@44306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 17:03:48 +00:00
f1ea8f222f
Widgets: Fix custom HTML widget editor content not updating after save.
...
An integer comparison is performed against `control.currentErrorAnnotations`, but `control.currentErrorAnnotations` is actually an array. This fixes that comparison so the content saves correctly.
Props barryceelen.
Fixes #43657 .
Built from https://develop.svn.wordpress.org/trunk@44474
git-svn-id: http://core.svn.wordpress.org/trunk@44305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 16:42:49 +00:00
0f3835d394
Users: Add the `pre_count_users` filter.
...
Props spacedmonkey.
Fixes #43693 .
Built from https://develop.svn.wordpress.org/trunk@44473
git-svn-id: http://core.svn.wordpress.org/trunk@44304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:49:50 +00:00
ea9286844f
Multisite: Introduce `ms-site.php` and `ms-network.php` files.
...
By providing distinct files for the site and network APIs, a better overview is provided. Prior to this change, the `ms-blogs.php` file had grown too big, mixing site APIs, network APIs and related legacy APIs that need to be maintained. Since multisite is often used in unexpected ways, backward-compatibility is ensured by including the two new files from `ms-blogs.php`, which previously contained all functions that have been moved to the new files.
This changeset does not contain any functional changes.
Fixes #40647 .
Built from https://develop.svn.wordpress.org/trunk@44472
git-svn-id: http://core.svn.wordpress.org/trunk@44303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:15:49 +00:00
8947acbf9b
Media: Add `$attr` to the `wp_get_attachment_link` filter.
...
Props danielbachhuber.
Fixes #40155 .
Built from https://develop.svn.wordpress.org/trunk@44471
git-svn-id: http://core.svn.wordpress.org/trunk@44302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:09:49 +00:00
e83f753246
Coding Standards: Fix an error introduced in [44465].
...
See #45748 .
Built from https://develop.svn.wordpress.org/trunk@44470
git-svn-id: http://core.svn.wordpress.org/trunk@44301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:03:50 +00:00
0b15142c0b
Multisite: Update `@since` tags for site management APIs.
...
Fixes #40364 . Fixes #41333 .
Built from https://develop.svn.wordpress.org/trunk@44469
git-svn-id: http://core.svn.wordpress.org/trunk@44300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 08:58:49 +00:00
321bdfbacf
Multisite: Move site-specific metadata integrations from the wrapper functions to the low-level Meta API functions.
...
This complements the work in [43729] and prepares site metadata for future REST API support.
Props spacedmonkey.
Fixes #45091 . See #44467 .
Built from https://develop.svn.wordpress.org/trunk@44468
git-svn-id: http://core.svn.wordpress.org/trunk@44299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 08:48:48 +00:00
035877708d
Multisite: Update `@since` tags for site meta introduction.
...
Fixes #37923 . Fixes #40229 .
Built from https://develop.svn.wordpress.org/trunk@44467
git-svn-id: http://core.svn.wordpress.org/trunk@44298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 08:18:50 +00:00
952c7253d3
Comments: Improve the Author box in the Edit Comment screen.
...
- Add a border below the heading, to match meta boxes.
- Remove the colons from the input labels.
- Tweak the padding and margins.
Props birgire, abdullahramzan, rhetorical, BODA1982, pento.
Fixes #43586 .
Built from https://develop.svn.wordpress.org/trunk@44466
git-svn-id: http://core.svn.wordpress.org/trunk@44297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:19:50 +00:00
8d2ee69f9d
Users: Use `email_exists()` in `send_confirmation_on_profile_email()`, instead of a manual query.
...
This gives us caching, and removes the use of the `$wpdb` global.
Props spacedmonkey, pento.
Fixes #45748 .
Built from https://develop.svn.wordpress.org/trunk@44465
git-svn-id: http://core.svn.wordpress.org/trunk@44296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:07:51 +00:00
fe837d19a7
Docs: Fix the `@param` type for `wp_make_plugin_file_tree()`.
...
`$plugin_editable_files` is an `array`, not a `string`.
Props subrataemfluence.
Fixes #45593 .
Built from https://develop.svn.wordpress.org/trunk@44464
git-svn-id: http://core.svn.wordpress.org/trunk@44295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:02:51 +00:00
5b3e08020b
Docs: Improve the `@global` tags in `wp-includes/option.php`.
...
Props upadalavipul.
Fixes #45581 .
Built from https://develop.svn.wordpress.org/trunk@44463
git-svn-id: http://core.svn.wordpress.org/trunk@44294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:00:50 +00:00
7d77a6eb04
Docs: Correct the parameters passed to the `twentyseventeen_custom_header_args` filter.
...
The documented `$default_text_color` parameter isn't passed, and the `$video` parameter is passed, but not documented.
Props mukesh27.
Fixes #44920 .
Built from https://develop.svn.wordpress.org/trunk@44462
git-svn-id: http://core.svn.wordpress.org/trunk@44293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:56:49 +00:00
54617423e7
Coding Standards: Improve the readability of `get_the_modified_author()`.
...
Props promz.
Fixes #44951 .
Built from https://develop.svn.wordpress.org/trunk@44461
git-svn-id: http://core.svn.wordpress.org/trunk@44292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:50:49 +00:00
12b800788e
Docs: Improve the `@return` description of `network_domain_check()`.
...
Props ishitaka, vaishalipanchal.
Fixes #45403 .
Built from https://develop.svn.wordpress.org/trunk@44460
git-svn-id: http://core.svn.wordpress.org/trunk@44291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:27:50 +00:00
3d918be94e
Docs: Add a missing `@global` to the `WP_Customize_Date_Time_Control::get_month_choices()` docblock.
...
Props utsav72640.
Fixes #45500 .
Built from https://develop.svn.wordpress.org/trunk@44459
git-svn-id: http://core.svn.wordpress.org/trunk@44290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:24:49 +00:00
f3656e2695
Docs: Add a reference to `WP_Customize_Control` from the `WP_Customize_Nav_Menu_Locations_Control` docblock.
...
`WP_Customize_Control` is the parent class of `WP_Customize_Nav_Menu_Locations_Control`.
Props utsav72640.
Fixes #45570 .
Built from https://develop.svn.wordpress.org/trunk@44458
git-svn-id: http://core.svn.wordpress.org/trunk@44289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:18:50 +00:00
2bbe0bd7e4
Docs: Fix the `@param` types for `comments_popup_link().
...
Props Mirucon.
Fixes #44841 .
Built from https://develop.svn.wordpress.org/trunk@44457
git-svn-id: http://core.svn.wordpress.org/trunk@44288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 04:50:51 +00:00
344348ba5b
Query: Fix some code formatting issues introduced in [44452].
...
See #38034 .
Built from https://develop.svn.wordpress.org/trunk@44456
git-svn-id: http://core.svn.wordpress.org/trunk@44287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 04:32:50 +00:00
363cfc4301
General: Replace "Happy blogging" with "Happy publishing".
...
As of this commit, WordPress is no longer a simple blogging platform. It's now a comprehensive publishing solution.
This also replaces a couple of other "blog" references that were missed previously.
Props igmoweb, Valer1e, audrasjb, pento.
Fixes #41000 .
Built from https://develop.svn.wordpress.org/trunk@44455
git-svn-id: http://core.svn.wordpress.org/trunk@44286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 04:30:50 +00:00
1b389ea861
Permalinks: Add a `pre_wp_unique_post_slug` filter.
...
Returning a non-`null` value on this fillter will cause `wp_unique_post_slug()` to return early with that value, skipping potentially expensive database queries on some sites.
Props coffee2code, javorszky, iCaleb.
Fixes #21112 .
Built from https://develop.svn.wordpress.org/trunk@44454
git-svn-id: http://core.svn.wordpress.org/trunk@44285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:47:49 +00:00
0049b17f8a
Bootstrap: Allow `WP_DEBUG_LOG` to override the `debug.log` location.
...
Setting `WP_DEBUG_LOG` to a file path will now cause the debug log to be written to that file, rather than the default `WP_CONTENT_DIR/debug.log`.
Props SergeyBiryukov, ethitter, sebastian.pisula, nacin.
Fixes #18391 .
Built from https://develop.svn.wordpress.org/trunk@44453
git-svn-id: http://core.svn.wordpress.org/trunk@44284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:42:48 +00:00
5950f27205
Query: Standardize treatment of 'orderby' values `post__in`, `post_parent__in`, and `post_name__in`.
...
Ordering by `post__in` was introduced in [21776], but the code assumed that
`post__in` would be a comma-separated string listing post IDs. When an array
of post IDs was passed to the `post__in` query var, 'orderby=post__in' was
not respected. This changeset changes this behavior by handling
'orderby=post__in' in the same way as most other values of 'orderby',
which ensures that arrays as well as strings can be properly parsed.
The same treatment is given to the similar `post_name__in` and
`post_parent__in` options of 'orderby', so that most query generation for
orderby clauses happens in the same place, instead of in special cases.
A slight change in the resulting SQL (related to the whitespace around
parentheses and commas) necessitates a change to an existing REST API test
that does a string comparison against the SQL query.
Props mgibbs189, kelvink.
Fixes #38034 .
Built from https://develop.svn.wordpress.org/trunk@44452
git-svn-id: http://core.svn.wordpress.org/trunk@44283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:33:49 +00:00
7f67e235a7
Install/Upgrade: Link to HelpHub instead of the Codex.
...
WordPress version links in the Codex (eg, https://codex.wordpress.org/Version_5.0 ) are redirected to their HelpHub equivalent.
Rather than relying on the redirect, Core and link directly to HelpHub.
Props swissspidy.
Fixes #45574 .
Built from https://develop.svn.wordpress.org/trunk@44451
git-svn-id: http://core.svn.wordpress.org/trunk@44282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:29:48 +00:00
308a544039
Docs: Update `@since` for `populate_site_meta()`.
...
Fixes #44896 .
Built from https://develop.svn.wordpress.org/trunk@44450
git-svn-id: http://core.svn.wordpress.org/trunk@44281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:18:50 +00:00
1d25a903c4
Docs: Update `@since` for `populate_network_meta()`.
...
Fixes #44895 .
Built from https://develop.svn.wordpress.org/trunk@44449
git-svn-id: http://core.svn.wordpress.org/trunk@44280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:17:49 +00:00
eee2e5f1d8
Docs: Update `@since` for the optional `$options` parameter to `populate_options()`.
...
Fixes #44893 .
Built from https://develop.svn.wordpress.org/trunk@44448
git-svn-id: http://core.svn.wordpress.org/trunk@44279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:15:49 +00:00
170b03ab19
Docs: Update `@since` for `is_taxonomy_viewable()`.
...
Props andizer.
Fixes #44466 .
Built from https://develop.svn.wordpress.org/trunk@44447
git-svn-id: http://core.svn.wordpress.org/trunk@44278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:11:50 +00:00
d5b7863fbf
REST API: Remove `permalink_structure` from the REST API settings endpoint.
...
This was ultimately fixed in #45017 , so is redunant.
Reverts [42142,42359,42540].
See #41014 .
Built from https://develop.svn.wordpress.org/trunk@44446
git-svn-id: http://core.svn.wordpress.org/trunk@44277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 02:51:50 +00:00
3068e8d4e2
Upload: Don't run some upload tests on multisite.
...
This moves several unit tests added in [44438] so they aren't run during multisite tests.
See #45615 .
Built from https://develop.svn.wordpress.org/trunk@44442
git-svn-id: http://core.svn.wordpress.org/trunk@44273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 21:42:50 +00:00
4a80373bdf
PHPCS: Fix formatting issues.
...
Fixes formatting issues introduced in [44438].
See #45615 .
Built from https://develop.svn.wordpress.org/trunk@44441
git-svn-id: http://core.svn.wordpress.org/trunk@44272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 21:09:49 +00:00
7bd6e079f5
Upload: Add test files for phpunit.
...
This is a follow up to [44438], which missed adding the test files.
See #45615 .
Built from https://develop.svn.wordpress.org/trunk@44439
git-svn-id: http://core.svn.wordpress.org/trunk@44270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 20:53:51 +00:00
ac1ff02815
Upload: Fix upload failures of common text file types.
...
This adds some special case handling in 'wp_check_filetype_and_ext()' that prevents some common file types from being blocked based on mismatched MIME checks, which were made more strict in WordPress 5.0.1.
Props Kloon, birgire, tellyworth, joemcgill.
See #45615 .
Built from https://develop.svn.wordpress.org/trunk@44438
git-svn-id: http://core.svn.wordpress.org/trunk@44269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 20:48:51 +00:00
f082806afa
Block Editor: Display notice to the user when JavaScript is disabled.
...
Currently, when viewing the block editor with JavaScript disabled, the user sees a blank admin page with the admin menu sidebar. This adds an admin notice informing the user that JavaScript is required for the new block editor.
Props mkaz, pento, azaozz, ocean90, desrosj.
Fixes #45453 .
Built from https://develop.svn.wordpress.org/trunk@44437
git-svn-id: http://core.svn.wordpress.org/trunk@44268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 20:40:50 +00:00
8917b0e89f
Default Themes: Bump the version numbers and release dates.
...
Update the theme versions and release dates for the default themes, in time for WordPress 5.0.3.
The POT file for Twenty Eleven has also been updated.
Props laurelfulford.
Fixes #45792 .
Built from https://develop.svn.wordpress.org/trunk@44435
git-svn-id: http://core.svn.wordpress.org/trunk@44266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 18:58:50 +00:00
1a622a8b81
Twenty Twelve: Correct `padding` rule precedence for Quote block.
...
Props superpoincare.
Fixes #45794 .
Built from https://develop.svn.wordpress.org/trunk@44432
git-svn-id: http://core.svn.wordpress.org/trunk@44263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 18:09:54 +00:00
0a66ea8149
Formatting: Remove unused global import for `$wp_filter` in `_restore_wpautop_hook()`.
...
See #45290 .
Built from https://develop.svn.wordpress.org/trunk@44431
git-svn-id: http://core.svn.wordpress.org/trunk@44262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 16:59:52 +00:00
6b2494ba10
Plugins: Use newer "Updating PHP" page URL in the notice displayed when a plugin requires a higher PHP version.
...
Props afragen.
Fixes #43986 . See #45686 .
Built from https://develop.svn.wordpress.org/trunk@44420
git-svn-id: http://core.svn.wordpress.org/trunk@44250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 15:35:49 +00:00
86e5a051db
I18n: Expose JSON translation file paths in `load_script_textdomain()`.
...
Removes `file_exist()` checks before calling `load_script_translations()` to let the determined paths be passed to `load_script_translations()` which provides its own file check and the possibility to filter the path.
Props swissspidy, johnbillion, ocean90.
See #45769 .
Built from https://develop.svn.wordpress.org/trunk@44418
git-svn-id: http://core.svn.wordpress.org/trunk@44248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 13:59:51 +00:00
9ac8b5b4f5
Importers: Use correct l10n variable in `wp.updates.installImporterError` and filesystem credentials dialog.
...
Missed in [40034].
Props afercia, abhayvishwakarma.
Fixes #45765 .
Built from https://develop.svn.wordpress.org/trunk@44417
git-svn-id: http://core.svn.wordpress.org/trunk@44247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 13:49:49 +00:00
efc9cbd553
Accessibility: Themes: use `aria-current` for the `Walker_Page` current link.
...
See [42808] for `Walker_Nav_Menu`.
The `aria-current` attribute is a simple, effective way to help assistive
technologies users orientate themselves within a list of items. Continues the
introduction in core of `aria-current` after [42440], [41683], [41359], and [41371].
Props chetan200891, wpzinc.
Fixes #43522 .
Built from https://develop.svn.wordpress.org/trunk@44416
git-svn-id: http://core.svn.wordpress.org/trunk@44246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 13:36:50 +00:00
49452cd73d
Pages, Post Types: Escape CSS classes in `Walker_Page::start_el()` after the `page_css_class` filter runs.
...
Don't add an empty `class` attribute if there are no classes, for consistency with `Walker_Nav_Menu::start_el()`.
Props abhijitrakas, mukesh27.
Fixes #44880 .
Built from https://develop.svn.wordpress.org/trunk@44415
git-svn-id: http://core.svn.wordpress.org/trunk@44245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 12:55:38 +00:00
d3e0f97705
Taxonomy: Escape CSS classes in `Walker_Category::start_el()` after the `category_css_class` filter runs.
...
Don't add an empty `class` attribute if there are no classes, for consistency with `Walker_Nav_Menu::start_el()`.
Props abhijitrakas, mukesh27.
See #44880 .
Built from https://develop.svn.wordpress.org/trunk@44414
git-svn-id: http://core.svn.wordpress.org/trunk@44244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 12:54:48 +00:00
a94d70b811
Taxonomy: Escape `feed_image` argument in `Walker_Category::start_el()`.
...
See [11838] for the instance in `wp_list_authors()`.
Props abhijitrakas.
See #44880 .
Built from https://develop.svn.wordpress.org/trunk@44413
git-svn-id: http://core.svn.wordpress.org/trunk@44243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 12:48:51 +00:00
9c08686353
Docs: Fix typo in the description of `status` parameter of `WP_Comment_Query`.
...
See #41338 .
Built from https://develop.svn.wordpress.org/trunk@44412
git-svn-id: http://core.svn.wordpress.org/trunk@44242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 11:38:50 +00:00
34fee908e3
Accessibility: Update since annotation for wp_link_pages().
...
Updates the since annotation for the `aria_current` argument introduced in #42440 .
Fixes #41859 .
Built from https://develop.svn.wordpress.org/trunk@44411
git-svn-id: http://core.svn.wordpress.org/trunk@44241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 08:02:48 +00:00
f21b9db825
Docs: Correct `@since` tag for `users_pre_query` filter added in [44373].
...
Revert unintended change to the `@since` tag for the `WP_User_Query` instance added to `found_users_query` filter in [43660].
See #44169 , #43679 .
Built from https://develop.svn.wordpress.org/trunk@44410
git-svn-id: http://core.svn.wordpress.org/trunk@44240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 07:56:50 +00:00
5781515e7d
Twenty Seventeen: Update `since` and `see` annotations for `twentyseventeen_unique_id()`.
...
Previously introduced in [43659].
See #44883 .
Built from https://develop.svn.wordpress.org/trunk@44408
git-svn-id: http://core.svn.wordpress.org/trunk@44238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-06 20:15:49 +00:00
33a71f04e2
General: Update `since` annotation for `wp_unique_id()`.
...
In [43658], `wp_unique_id()` was introduced. This updates the `since` annotation to be accurate.
See #44883 .
Built from https://develop.svn.wordpress.org/trunk@44406
git-svn-id: http://core.svn.wordpress.org/trunk@44236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-06 19:52:51 +00:00
49351e0578
I18N/Script Loader: Support text domains other than "messages".
...
The inline JavaScript added by `WP_Scripts::print_translations()` should check whether `locale_data.$text_domain` exists and fall back to `locale_data.messages` otherwise.
Props swissspidy.
See #45441 .
Built from https://develop.svn.wordpress.org/trunk@44403
git-svn-id: http://core.svn.wordpress.org/trunk@44233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-06 16:23:49 +00:00
1c4a23faad
Twenty Seventeen: Improve selectors for block editor custom colors.
...
Twenty Seventeen's original styles for the block editor custom colors had some issues: they weren't being applied to the button blocks due to lack of specificity, and when applied to paragraph blocks, there was no padding in the editor. This update makes sure the colors and related styles work as expected.
Fixes #45426 .
Built from https://develop.svn.wordpress.org/trunk@44402
git-svn-id: http://core.svn.wordpress.org/trunk@44232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-05 21:16:49 +00:00
41aaf1d772
Editor: Fix name of the new editor for inline comment.
...
In [44398], an inline comment was introduced that did not refer to the new editor as the Block Editor. This corrects that comment.
See #45788 .
Built from https://develop.svn.wordpress.org/trunk@44399
git-svn-id: http://core.svn.wordpress.org/trunk@44229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-05 03:48:50 +00:00
80503c5c0e
Editor: Allow the “Add Media” button tooltip to be translated in the Classic block.
...
In the Classic Editor, the “Add Media” button was outside of the TinyMCE editor. In the Block Editor, the “Add Media” button was moved into the TinyMCE toolbar in the Classic block, but the tooltip was not added to the list of translatable strings. This adds “Add Media” to that list.
The corresponding keyboard shortcut is also specified for the “Add Media” button.
Props afercia.
Fixes #45788 .
Built from https://develop.svn.wordpress.org/trunk@44398
git-svn-id: http://core.svn.wordpress.org/trunk@44228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-05 03:40:50 +00:00
Felix Arntz
Andrea Fercia
Gary Pendergast
desrosj
Boone Gorges
Pascal Birchler
Dominik Schilling
Peter Wilson
tellyworth
Adam Silverstein
Joe McGill
Sergey Biryukov
laurelfulford