43a7e695e9
Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
...
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
cc5ed3a485
Change all core API to expect unslashed rather than slashed arguments.
...
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.
Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.
Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.
Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.
Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.
Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.
Plugins should use wp_unslash() on data being passed to core API.
Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.
Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.
Remove many no longer necessary calls to $wpdb->escape() and esc_sql().
In wp_get_referer() and wp_get_original_referer(), return unslashed data.
Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.
Switch several queries over to prepare().
Expect something to break.
Props alexkingorg
see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
6cb5f510b8
Select "Attribute all posts to..." radio button automatically when selecting a username from the dropdown. fixes #23224 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-01 18:43:23 +00:00
ae48899878
i18n: Fix the usage of sprintf replacements in the user management admin page. See #22260 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-23 11:32:41 +00:00
e3d18dc0fc
Force the user to explicitly choose between content deletion and reassignment when deleting users. props Dan Rivera, Ben Brooks, GhostToast. fixes #20045 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-10 14:07:59 +00:00
84c3a86036
Hide the link manager from the UI on upgrade, if the site has no links. New DB option, link_manager_enabled.
...
Enforce this by denying the 'manage_links' capability, which hides the All Links, Add New Link, and Link Categories screens. Hide WP_Widget_Links and the UI for the default_link_category as well.
Convert all references to 'posts and links' when handling reassignment on user deletion to just 'posts'.
see #21307 .
git-svn-id: http://core.svn.wordpress.org/trunk@21501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-13 16:18:42 +00:00
7127ed1197
Move most instances of new WP_User to get_userdata(). see #21120 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-03 01:06:05 +00:00
3ebea2f218
Remove user/site suggestions (autocompletion) from search inputs, as the UX isn't proper.
...
* Removes all instances of site-search, so away it goes. Sidesteps a number of bugs with site-search.
* Renames user-search to user-suggest, which means it better describes the current behavior (autocompletion) while allowing for future behavior (instant search).
* Ties user suggestions to a single .wp-suggest-user class.
with help from markjaquith, helenyhou, wonderboymusic.
fixes #20835 .
git-svn-id: http://core.svn.wordpress.org/trunk@21003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-05 18:51:33 +00:00
4ffc5dd0f4
After adding a user, take them back to users.php with an 'Edit user' link in the message.
...
This removes the (possibly ineffective) search from the redirect, as well as the URL hash that will get covered up by the toolbar.
fixes #19470 . props merty and SergeyBiryukov for initial patches.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20631 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-27 23:13:39 +00:00
81407efd05
Clean up cap checks for autocompletes for sites and users in a network. see #19810 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-30 21:04:48 +00:00
2a8c7bbc7a
Autocomplete site names in Network Admin. More user completion areas. props Japh, DrewAPicture. see #19810 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-24 04:54:58 +00:00
9aa60c4066
Only allow _multisite_ super admins to demote themselves on a site. props linuxologos, see #19684 for trunk.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19640 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-30 23:13:48 +00:00
07ff8b216b
Use one space, not two, after trailing punctuation. fixes #19537
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
6bba5a265b
Pinking shears
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 04:51:35 +00:00
3d51303ca3
Help tweaks for users, tools. props jane, see #19020 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 01:17:14 +00:00
094ebdb120
Indent cleanup. see #19020
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 23:08:02 +00:00
c4b72bf705
Help tabs. Props Ipstenu. see #19020
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-23 23:06:52 +00:00
bfb98c193e
s/add_help_sidebar/set_help_sidebar/g and introduce screen->remove_help_tab($id) and screen->remove_help_tabs(). see #19020 , #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19119 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 20:14:10 +00:00
3ad1f67958
Use add_help_sidebar(). see #19020
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 03:12:37 +00:00
023143f7cd
Allow a super admin to demote themselves on a site to a role that does not contain the promote_users cap. props fonglh, fixes #18164 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-20 14:12:25 +00:00
795ca8d394
Revert [18861], [18862], [18864], [18874], [18879], and [18880]. see #18785 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-07 04:57:12 +00:00
bbafdfa0e5
Use add_option() method, introduce add_option_context() method for adding specific text above the screen options, see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-03 04:00:57 +00:00
3575537e5f
Add screen_options with contextual content, see #18690
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-02 06:59:36 +00:00
6c81d023bb
Add magic get/set/isset methods to WP_User to avoid data duplication. Standardize on WP_User::ID. Props scribu. see #15458
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@18504 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-04 03:09:27 +00:00
69b3acb8db
Remove non-functional vestigal code.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17977 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-20 06:02:03 +00:00
2207bfe689
Admin Header 2: The Return of 32px Icons. Props, iammattthomas. see #17324 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-12 00:22:22 +00:00
e5ec44416a
Remove favorite_actions() from h2s. Restore Add New buttons. see #17324
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17849 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-10 19:18:16 +00:00
8d87f5dcb4
Big UI style update. props koopersmith. see #17324
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17800 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 20:15:05 +00:00
9cb6e158fc
Switch from Panel/SubPanel to Screen in inline documentation and Codex links. props michaelh, fixes #17265 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-28 15:24:49 +00:00
8515d203d3
Singular and plural strings for bulk user delete. Props nacin. fixes #16360
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-21 16:48:12 +00:00
19afce5e23
Disallow and hide user removal (as opposed to deletion) for single site installs. Removal is a multisite concept. Props nacin. fixes #16501 for trunk
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17439 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-02-10 20:37:26 +00:00
ba47c80ef7
Add additional promote_users checks. Show Add existing button only for multisite. Don't show bulk actions if user can't promote users. Show add new user menu if user has create_users but not promote_users. Props nacin. fixes #16501 for trunk
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-02-09 17:30:26 +00:00
9400a59207
Don't redirect continually on empty search results pages. Fixes #16357 props garyc40
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17366 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-26 09:56:17 +00:00
011cc6550e
Add name to reassign user dropdown. Props nacin. fixes #16361
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17363 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-25 19:36:50 +00:00
b345e996c7
Pagination fixes. Props garyc40. fixes #16357
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-25 19:20:20 +00:00
e9d62d1f01
From post back to get. Props SergeyBiryukov. fixes #16335
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17345 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-22 01:31:21 +00:00
37075f7f71
Remove AJAX from list tables. first pass. see #16262 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17322 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-16 21:47:24 +00:00
9c1f2901cd
Revert [17275] and [17276]. The rabbit hole is too deep. see #16166 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-13 00:50:35 +00:00
c1c79447a3
Move wp_redirect calls to the end of the switch in users.php. Fix unrelated bug where the user's cap should be check, rather than their role's cap. see #16166 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-01-13 00:22:53 +00:00
ae4c6c70c0
Improve the button and header test to give a clearer picture between Adding New Users and Adding Exiting Users to a site. Fixes #14756
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-19 22:27:30 +00:00
567c9bc2a6
Use wp_dropdown_users() in the delete confirmation screen. Props duck_. See #15854
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17010 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 23:40:46 +00:00
cfe09b99e5
Introduce WP_List_Table::search_box(). See #15353
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@17006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 20:45:10 +00:00
cc08068dba
Remove check_permissions() calls outside of AJAX context. Also only check for switch_themes in check_permissions() for the themes table. see #15326 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 08:43:22 +00:00
1cd758dc89
Help text edits. props dougwrites, fixes #15346 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16980 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 06:37:03 +00:00
3f2c0aff8a
Don't show search box if there are no items available. See #15353
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-10 20:22:34 +00:00
d23cc6554f
Fix user search input name. Props nickmomrik.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-19 23:43:00 +00:00
d352c9064b
Add missing div. props PeteMall, fixes #15501 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-19 19:05:04 +00:00
5a6716b78a
Show Add New if user can promote.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-12 16:57:47 +00:00
5e90c5d1c3
Revert [16171] and [16172] - The class names were fine as they were and the MultiSite classes stand out more with the original naming.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-04 08:07:03 +00:00
3ded7f7c68
complete the renaming. props ocean90. See #14579
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@16172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-03 22:06:45 +00:00
Ryan Boren
Sergey Biryukov
Peter Westwood
Andrew Nacin
nacin
markjaquith
ryan
azaozz
koopersmith
westi
scribu