Commit Graph

43430 Commits

Author SHA1 Message Date
Sergey Biryukov b50e49f5c1 Accessibility: Taxonomy: Correct keyboard navigation for the Tags meta box in classic editor.
Props sabernhardt, almendron, jose64, alexstine, joedolson, ryokuhi.
Fixes #52408.
Built from https://develop.svn.wordpress.org/trunk@50363


git-svn-id: http://core.svn.wordpress.org/trunk@49974 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 20:04:07 +00:00
Sergey Biryukov e99d544215 Administration: Apply the `months_dropdown_results` filter separately from `pre_months_dropdown_query`.
Follow-up to [50163].

Props hellofromTonya.
Fixes #51660.
Built from https://develop.svn.wordpress.org/trunk@50362


git-svn-id: http://core.svn.wordpress.org/trunk@49973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 19:58:05 +00:00
Sergey Biryukov 070dcd980b Twenty Ten: Correct the fallback to the default header if the featured image width is narrower than the `twentyten_header_image_width` setting.
Follow-up to [45581].

Props sabernhardt, macmanx, audrasjb.
Fixes #52516.
Built from https://develop.svn.wordpress.org/trunk@50361


git-svn-id: http://core.svn.wordpress.org/trunk@49972 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 19:28:04 +00:00
Sergey Biryukov 9aaa579f0d Twenty Eleven: Correct the fallback to the default header if the featured image width is narrower than the `twentyeleven_header_image_width` setting.
Follow-up to [45581].

Props sabernhardt, macmanx, audrasjb.
See #52516.
Built from https://develop.svn.wordpress.org/trunk@50360


git-svn-id: http://core.svn.wordpress.org/trunk@49971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 19:26:06 +00:00
Sergey Biryukov 95094becee Twenty Twenty: Make sure the RTL list styles are preserved after `npm run build`.
Adjust the padding value for better consistency.

Props desrosj, sabernhardt, ryelle, mukesh27.
Fixes #52401.
Built from https://develop.svn.wordpress.org/trunk@50359


git-svn-id: http://core.svn.wordpress.org/trunk@49970 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 19:11:05 +00:00
ryelle 5f56591fe5 Bundled Themes: Fix alignment and styles for quote, verse, and code blocks.
Updates older themes to fix alignment, spacing, and font issues to better match the frontend display. Applies to themes: Twenty Eleven, Twenty Thirteen, Twenty Fourteen, Twenty Sixteen, Twenty Seventeen, and Twenty Twenty.

Props burnuser, talldanwp, cristinasoponar, poena, kjellr
Fixes #52009.


Built from https://develop.svn.wordpress.org/trunk@50358


git-svn-id: http://core.svn.wordpress.org/trunk@49969 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 18:59:04 +00:00
John Blackbourn 6cb1eaa583 Posts, Post Types: Update the styling of the legacy Links editing screen.
This brings its styling inline with other meta boxes in the admin area.

Props antonlukin, kburgoine, grzim, sabernhardt, pbiron, audrasjb

Fixes #48782

Built from https://develop.svn.wordpress.org/trunk@50357


git-svn-id: http://core.svn.wordpress.org/trunk@49968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 18:50:03 +00:00
Sergey Biryukov dbaee6b550 Filesystem API: Make sure to only call `fread()` on non-empty files in the PclZip library.
This avoids a fatal error on PHP 8 caused by passing a zero value to `fread()` as the `$length` argument, which must be greater than zero.

Props yakimun, fierevere, jrf, DavidAnderson, SergeyBiryukov.
Fixes #52018.
Built from https://develop.svn.wordpress.org/trunk@50355


git-svn-id: http://core.svn.wordpress.org/trunk@49966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 18:42:03 +00:00
John Blackbourn f955bcce54 Feeds: Fix the URL returned by `get_feed_link()` when pretty permalinks are not in use.
Props hauvong, peterwilsoncc, SergeyBiryukov

Fixes #51839

Built from https://develop.svn.wordpress.org/trunk@50354


git-svn-id: http://core.svn.wordpress.org/trunk@49965 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 17:34:04 +00:00
Sergey Biryukov ec94c354e2 XML-RPC: Pass the method arguments and the XML-RPC server instance to the `xmlrpc_call` action.
This provides better context and makes the action easier to use when the call passes specific content in the payload of the request.

Props dd32.
Fixes #52524.
Built from https://develop.svn.wordpress.org/trunk@50353


git-svn-id: http://core.svn.wordpress.org/trunk@49964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 17:03:05 +00:00
joedolson 7b5e14e987 Media: Associate upload errors and field with controls.
Adds an explicit relationship between the upload button and the maximum upload limit, moves focus to the error dismiss button if an error occurs, and adds a call to wp.a11y.speak to report the error after it occurs.

Props afercia, anevins, antpb, adamsilverstein, poena
Fixes #47120
Built from https://develop.svn.wordpress.org/trunk@50352


git-svn-id: http://core.svn.wordpress.org/trunk@49963 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 04:05:07 +00:00
Peter Wilson 147852757c Twenty Twenty-One: Display inline-images inline.
Remove `display: block` property from inline images and display them center aligned vertically.

Props jeroenrotty, melchoyce, mukesh27, paaljoachim, poena, talldanwp.
Fixes #52287.


Built from https://develop.svn.wordpress.org/trunk@50351


git-svn-id: http://core.svn.wordpress.org/trunk@49962 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-16 02:26:08 +00:00
Peter Wilson 49f0fc9e53 Twenty Twenty-One: Match bullets between editor and frontend.
Change bullet style on frontend nested unordered lists to `circle` to match the editor styles.

Props poena, mukesh27, mahfuz01, tejwanihemant.
Fixes #52412.


Built from https://develop.svn.wordpress.org/trunk@50350


git-svn-id: http://core.svn.wordpress.org/trunk@49961 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 23:52:04 +00:00
Peter Wilson 3ed24991ba Bundled Themes: Synchronise `.gitignore` with themes' svn ignore property.
Add `node_modules` directories within Twenty Twenty-One, Twenty Twenty and Twenty Nineteen to the `.gitignore` file.

Fixes #52502.

Built from https://develop.svn.wordpress.org/trunk@50349


git-svn-id: http://core.svn.wordpress.org/trunk@49960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 23:19:07 +00:00
Peter Wilson 8665ca27cc Twenty Twenty-One: Add CSS source map files to committed files.
Remove `*.css.map` files from the ignore properties of Twenty Twenty-One directories, add the unignored files.

Props poena, peterwilsoncc.
Fixes #52377.


Built from https://develop.svn.wordpress.org/trunk@50348


git-svn-id: http://core.svn.wordpress.org/trunk@49959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 23:11:07 +00:00
ryelle 0e7386521b Bundled Themes: Support font size option for code block.
Adds font-size support to Twenty Fourteen, Twenty Sixteen, and Twenty Seventeen.

Props poena, paaljoachim, peterwilsoncc.
Fixes #52431.


Built from https://develop.svn.wordpress.org/trunk@50347


git-svn-id: http://core.svn.wordpress.org/trunk@49958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 18:56:04 +00:00
ryelle ec38e1434a Twenty Thirteen: Fix alignment of child blocks within the Cover block.
Props kjellr, melchoyce.
Fixes #51224.


Built from https://develop.svn.wordpress.org/trunk@50346


git-svn-id: http://core.svn.wordpress.org/trunk@49957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 18:33:05 +00:00
Sergey Biryukov 18a16e0a91 Tests: Rename two classes in `phpunit/tests/http/` to match the function names.
See #51802.
Built from https://develop.svn.wordpress.org/trunk@50345


git-svn-id: http://core.svn.wordpress.org/trunk@49956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 14:07:06 +00:00
Sergey Biryukov 0bbe650e69 Tests: Add missing `@covers` tags for files in `phpunit/tests/http/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50344


git-svn-id: http://core.svn.wordpress.org/trunk@49955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 14:02:07 +00:00
youknowriad e276187b9a Block Editor: Update packages with bug fixes to be included in WP 5.7 beta 3.
The updated packages are:

@wordpress/block-directory: 1.18.6 -> 1.18.7
@wordpress/block-editor: 5.2.6 -> 5.2.7
@wordpress/block-library: 2.28.3 -> 2.28.4
@wordpress/edit-post: 3.26.6 -> 3.26.7
@wordpress/editor: 9.25.6 -> 9.25.7
@wordpress/format-library: 1.26.6 -> 1.26.7
@wordpress/reusable-blocks: 1.1.6 -> 1.1.7

Props isabel_brison.
Fixes #52525.

Built from https://develop.svn.wordpress.org/trunk@50343


git-svn-id: http://core.svn.wordpress.org/trunk@49954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-15 08:29:31 +00:00
Sergey Biryukov f1d362a2f3 Tests: Rename classes in `phpunit/tests/hooks/` per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327], [50291], [50292].
See #51802.
Built from https://develop.svn.wordpress.org/trunk@50342


git-svn-id: http://core.svn.wordpress.org/trunk@49953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-14 12:22:02 +00:00
Sergey Biryukov 2d9dc11508 Tests: Add missing `@covers` tags for files in `phpunit/tests/hooks/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50341


git-svn-id: http://core.svn.wordpress.org/trunk@49952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-14 12:11:08 +00:00
Dominik Schilling 4491708fd1 Docs: Improve parameter types for various URL functions and filters that also accept `null`.
See #51800.
Built from https://develop.svn.wordpress.org/trunk@50340


git-svn-id: http://core.svn.wordpress.org/trunk@49951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 15:16:08 +00:00
Sergey Biryukov 96edb89edb Tests: Add missing `@covers` tags for files in `phpunit/tests/general/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50339


git-svn-id: http://core.svn.wordpress.org/trunk@49950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 13:49:03 +00:00
Sergey Biryukov 8fdd713cb2 Tests: Simplify `@covers` tags in `editor/wpEditors.php` using `@coversDefaultClass` annotation.
Follow-up to [50288].

See #39265.
Built from https://develop.svn.wordpress.org/trunk@50338


git-svn-id: http://core.svn.wordpress.org/trunk@49949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 13:47:11 +00:00
Sergey Biryukov e56a6d1a71 Tests: Use `@ticket` annotation for ticket numbers, for clarity.
See #51802.
Built from https://develop.svn.wordpress.org/trunk@50337


git-svn-id: http://core.svn.wordpress.org/trunk@49948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-13 12:19:06 +00:00
gziolo fde749f4e4 Tests: Fix failing unit test for block settings
Follow-up to [50297].

Fixes #52512.



Built from https://develop.svn.wordpress.org/trunk@50300


git-svn-id: http://core.svn.wordpress.org/trunk@49945 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 16:41:03 +00:00
desrosj 00e80bf777 Build/Test Tools: Run xDebug tests on PHP 8.0.
The PHP 8 Docker container for the local WordPress environment now contains xDebug 3.x (the version required for running on PHP 8), so the `xdebug` test group can now be run.

See #50401, #51802.
Built from https://develop.svn.wordpress.org/trunk@50299


git-svn-id: http://core.svn.wordpress.org/trunk@49944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 16:38:04 +00:00
desrosj 741e056ed7 Build/Test Tools: Run automated testing when tags are created.
This expands the list of events that triggers automated testing to include tags.

It also refines the matched version ranges for several workflows.

See #50401.
Built from https://develop.svn.wordpress.org/trunk@50298


git-svn-id: http://core.svn.wordpress.org/trunk@49943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 16:03:10 +00:00
gziolo 135a35fd04 Blocks: Add missing apiVersion field when preparing server-registered blocks for the block editor
When working on changes to @wordpress/create-block tool (https://github.com/WordPress/gutenberg/pull/28883) to use register_block_type_from_metadata with block.json file in the templates for scaffolded blocks I run into this issue where apiVersion wasn't exposed from the server.

Fixes #52512.


Built from https://develop.svn.wordpress.org/trunk@50297


git-svn-id: http://core.svn.wordpress.org/trunk@49942 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 16:00:06 +00:00
Sergey Biryukov 463df820f8 Block Editor: Remove extra quotes from the default font stack for editor styles.
Follow-up to [50155].

Props dd32, Joen, kafleg.
Fixes #46169.
Built from https://develop.svn.wordpress.org/trunk@50295


git-svn-id: http://core.svn.wordpress.org/trunk@49940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 07:55:06 +00:00
Peter Wilson d0cf9db65c Site Health: Update `site-health` script dependencies.
Add `wp-hooks` and `wp-i18n` to Site Health JavaScript dependencies.

Props gmariani405, Clorith, mukesh27.
Fixes #52483.

Built from https://develop.svn.wordpress.org/trunk@50294


git-svn-id: http://core.svn.wordpress.org/trunk@49939 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 00:10:04 +00:00
Peter Wilson 95fb827816 Twenty Twenty-One: Correct accent marks in block pattern alt text.
Correct accents in "Roses Trémières" for block patterns and starter content.

Props audrasjb, geekzebre, kjellr, SergeyBiryukov.
Fixes #52500.


Built from https://develop.svn.wordpress.org/trunk@50293


git-svn-id: http://core.svn.wordpress.org/trunk@49938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-12 00:03:04 +00:00
Sergey Biryukov 29574d526d Tests: Rename some files and classes in `phpunit/tests/general/` per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327], [50291].

See #51802.
Built from https://develop.svn.wordpress.org/trunk@50292


git-svn-id: http://core.svn.wordpress.org/trunk@49937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 21:40:11 +00:00
Sergey Biryukov 2553af179d Tests: Rename some classes in `phpunit/tests/date/` per the naming conventions.
https://make.wordpress.org/core/handbook/testing/automated-testing/writing-phpunit-tests/#naming-and-organization

Follow-up to [47780], [48911], [49327].

See #51802.
Built from https://develop.svn.wordpress.org/trunk@50291


git-svn-id: http://core.svn.wordpress.org/trunk@49936 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 21:22:04 +00:00
Sergey Biryukov cfacfa87c4 Tests: Add missing `@covers` tags for files in `phpunit/tests/external-http/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50290


git-svn-id: http://core.svn.wordpress.org/trunk@49935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 20:57:08 +00:00
Sergey Biryukov eebc1705a8 Tests: Add missing `@covers` tags for files in `phpunit/tests/error-protection/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50289


git-svn-id: http://core.svn.wordpress.org/trunk@49934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 20:56:05 +00:00
Sergey Biryukov 9d739f6be3 Tests: Add missing `@covers` tags for files in `phpunit/tests/editor/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50288


git-svn-id: http://core.svn.wordpress.org/trunk@49933 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 20:54:16 +00:00
Sergey Biryukov 7034111a38 Tests: Add missing `@covers` tags for files in `phpunit/tests/dependencies/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50287


git-svn-id: http://core.svn.wordpress.org/trunk@49932 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 15:17:07 +00:00
Sergey Biryukov 262234df8d Tests: Add missing `@covers` tags for files in `phpunit/tests/db/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50286


git-svn-id: http://core.svn.wordpress.org/trunk@49931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-11 14:04:09 +00:00
desrosj 1cfa0a1370 Build/Test Tools: Install WordPress Importer plugin when installing the Docker-based local environment.
The WordPress Importer plugin is now downloaded to the `tests/phpunit/data/plugins` directory when running `npm run env:install`.

This ensures that the PHPUnit test suite will not fail when the plugin is missing.

This also introduces a new `WP_IMPORTER_REVISION` variable to the `.env` file, to control the SVN revision that is checked out.

Props johnbillion.
Fixes #49720.
Built from https://develop.svn.wordpress.org/trunk@50285


git-svn-id: http://core.svn.wordpress.org/trunk@49930 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 16:54:07 +00:00
Sergey Biryukov fc8e180035 Tests: Use `assertSame()` in some newly introduced tests.
This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using `assertSame()` should generally be preferred to `assertEquals()` where appropriate, to make the tests more reliable.

Follow-up to [49904], [49925], [49992], [50012], [50013], [50065], [50075], [50131], [50150], [50157].

See #38266, #52482.
Built from https://develop.svn.wordpress.org/trunk@50284


git-svn-id: http://core.svn.wordpress.org/trunk@49929 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 13:27:02 +00:00
Sergey Biryukov 24dbafaba5 Tests: Replace most instances of `assertEquals()` in `phpunit/includes/` with `assertSame()`.
Follow-up to [48937], [48939], [48940], [48944].

Props johnbillion, jrf, SergeyBiryukov.
See #38266, #52482.
Built from https://develop.svn.wordpress.org/trunk@50283


git-svn-id: http://core.svn.wordpress.org/trunk@49928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 13:25:09 +00:00
Peter Wilson 0f251cdd90 Canonical: Rename `wp_force_plain_ugly_permalink()` to match UI terminology.
Rename `wp_force_plain_ugly_permalink()` to `wp_force_plain_post_permalink()` to match terminology used in the WordPress dashboard.

Follow up to [50132].
Props SergeyBiryukov.
Fixes #5272.


Built from https://develop.svn.wordpress.org/trunk@50282


git-svn-id: http://core.svn.wordpress.org/trunk@49927 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-10 05:40:07 +00:00
desrosj 30da2b425d Post WordPress 5.7 Beta 2 version bump.
Built from https://develop.svn.wordpress.org/trunk@50281


git-svn-id: http://core.svn.wordpress.org/trunk@49926 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 20:40:04 +00:00
desrosj bcbad3aef8 WordPress 5.7 Beta 2.
Built from https://develop.svn.wordpress.org/trunk@50280


git-svn-id: http://core.svn.wordpress.org/trunk@49925 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 20:26:05 +00:00
Sergey Biryukov 38696a7290 Tests: Add missing `@covers` tags for files in `phpunit/tests/date/`.
Props patopaiar, jrf.
See #39265.
Built from https://develop.svn.wordpress.org/trunk@50279


git-svn-id: http://core.svn.wordpress.org/trunk@49924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 19:57:02 +00:00
ryelle 10d1280ff3 Administration: Update color contrast on UI elements.
The color palette changes in #49999 introduced some contrast issues on buttons, input elements, and links. This change ensures that all interactive elements have an appropriate contrast ratio.

Follow-up to [50025].
Props audrasjb, joedolson.
Fixes #52402.


Built from https://develop.svn.wordpress.org/trunk@50278


git-svn-id: http://core.svn.wordpress.org/trunk@49923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 19:47:03 +00:00
desrosj ac126c1062 Build/Test Tools: Synchronize `svn:ignore` with `.gitignore`.
Some files ignored within the `.gitignore` file were not included in the `svn:ignore` property.

This also removed `wp-config.php` and `wp-tests-config.php` from the `svn:ignore` property. It’s already specified in `svn:global-ignores`.

Props johnbillion.
Fixes #49784.
Built from https://develop.svn.wordpress.org/trunk@50277


git-svn-id: http://core.svn.wordpress.org/trunk@49922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 18:42:05 +00:00
Sergey Biryukov 7cae8b1c02 Tests: Correct the test for `NOT BETWEEN` comparison operator in `WP_Date_Query`.
Follow-up to [29793].

Props patopaiar, jrf.
See #39265, #51802.
Built from https://develop.svn.wordpress.org/trunk@50276


git-svn-id: http://core.svn.wordpress.org/trunk@49921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-02-09 18:10:04 +00:00