WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
25,313 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

91 Commits

Author SHA1 Message Date
Andrew Nacin 08db3b53c5 Explicitly assign menu term relationship rather than piggybacking on wp_insert_post() with the tax_input argument. 
That argument currently depends on user context (see #19373).

Adds unit test for properly updating orphaned menu items.

props danielbachhuber.
fixes #27113.

Built from https://develop.svn.wordpress.org/trunk@27556


git-svn-id: http://core.svn.wordpress.org/trunk@27399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-15 06:07:16 +00:00
Sergey Biryukov 19be701a86 Consistently return a WP_Error object in case of an error in wp_update_nav_menu_item(). 
props bootsz, ocean90.
fixes #21652.
Built from https://develop.svn.wordpress.org/trunk@27251


git-svn-id: http://core.svn.wordpress.org/trunk@27108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-25 00:51:13 +00:00
Andrew Nacin 635e50d9a1 Remove theme support for 'menus' in unregister_nav_menu() when there are no more menus. 
props kovshenin.
fixes #26900.

Built from https://develop.svn.wordpress.org/trunk@27220


git-svn-id: http://core.svn.wordpress.org/trunk@27077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-21 18:14:14 +00:00
Dominik Schilling 31d1f909a4 Nav Menu: Remove post/page items from the Nav Menu when the post/page is deleted. 
This was broken through a change in [25163]. `_menu_item_object` in wp_get_associated_nav_menu_items() is not relevant for post types.
Adds unit tests.

props UmeshSingla for initial patch.
fixes #26795.
Built from https://develop.svn.wordpress.org/trunk@27150


git-svn-id: http://core.svn.wordpress.org/trunk@27017 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-02-09 21:37:11 +00:00
Scott Taylor d7cc1f506a Introduce `wp_using_ext_object_cache()` - mimic `wp_suspend_cache_invalidation()` and discourage direct access to `$_wp_using_ext_object_cache`, cleaning up importing of globals in functions and provides function to modify that global. Loads the packaged object cache when an external cache hasn't been loaded or doesn't contain `wp_cache_init()`. 
Fixes #21401.


Built from https://develop.svn.wordpress.org/trunk@25289


git-svn-id: http://core.svn.wordpress.org/trunk@25253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-06 18:10:09 +00:00
Andrew Nacin 0d9fcbd841 Use get_nav_menu_locations() in wp_delete_nav_menu(). 
props nofearinc.
see #25064.

Built from https://develop.svn.wordpress.org/trunk@25196


git-svn-id: http://core.svn.wordpress.org/trunk@25168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-31 01:39:09 +00:00
Scott Taylor eeb3b15936 Pass the taxonomy around to relevant nav menu actions to avoid arbitrarily deleting all items with `menu-item-type` of `taxonomy`. Adds unit test for `wp_get_associated_nav_menu_items()`. 
Props garyc40, SergeyBiryukov.
Fixes #15264.


Built from https://develop.svn.wordpress.org/trunk@25163


git-svn-id: http://core.svn.wordpress.org/trunk@25142 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-29 16:45:10 +00:00
Mark Jaquith 92af914abe Keep the Nav Menu walker from blowing up the layout on empty-titled items. 
fixes #23254. props cais, SergeyBiryukov.

git-svn-id: http://core.svn.wordpress.org/trunk@24560 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-05 15:41:46 +00:00
Sergey Biryukov 4b174612ab Prevent menu items with '0' label from being removed on menu saving. props MikeHansenMe, kovshenin. fixes #23051. 
git-svn-id: http://core.svn.wordpress.org/trunk@24235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-05-10 18:03:09 +00:00
Sergey Biryukov 15e919bd24 Use correct variable. fixes #24014. see #23119. 
git-svn-id: http://core.svn.wordpress.org/trunk@23941 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-09 20:50:45 +00:00
Andrew Nacin 10d898ecbb Remove _wp_delete_nav_menu(). wp_delete_nav_menu() should instead remove the menu from theme locations, which was the only difference between the functions. see #23119. 
git-svn-id: http://core.svn.wordpress.org/trunk@23897 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-04 04:28:12 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Sergey Biryukov 87f2c02462 Ensure that get_nav_menu_locations() always returns an array. props JustinSainton for initial patch. fixes #23508. 
git-svn-id: http://core.svn.wordpress.org/trunk@23550 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 15:51:16 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Jon Cave ae96b842f9 Correctly associate new menu items with a menu when using wp_update_nav_menu_item() 
wp_update_nav_menu_item() must pass tax_input to wp_insert_post() when creating items
otherwise the menu-item relationship isn't made.

See #22189.


git-svn-id: http://core.svn.wordpress.org/trunk@22399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-06 14:46:56 +00:00
Andrew Nacin 0ae808509c Optimize wp_update_nav_menu_item() for high performance. Only query items for a menu when we need them. Update items after updating its meta so the meta cache can be leveraged. see #22189. 
git-svn-id: http://core.svn.wordpress.org/trunk@22235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-15 14:27:16 +00:00
Andrew Nacin 6c56e0573c Prime post term caches for nav menu items. Avoid doing so in frontend template functions as it remains unneeded there. see #22189. 
git-svn-id: http://core.svn.wordpress.org/trunk@22233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-10-15 14:17:50 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-13 23:45:31 +00:00
duck_ b225e5b626 Rescue those who created menu items before r18733. Trim menu item descriptions. See #16799. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-20 22:57:47 +00:00
duck_ bc3b3aed4d Make new nav menu items have a blank description and attr_title. See #16799. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-09-20 21:58:37 +00:00
nacin 61afb5def3 Check for WP_Error return values when using get_term_field() to set up nav menu items. fixes #17958 for trunk. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-07-11 19:03:04 +00:00
ryan 4bb54d8f68 Improvements to invalid menu item handling. Props ocean90. fixes #13958 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-11 15:52:15 +00:00
ryan 46f63a6b1e Pinking shears 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-11 15:44:06 +00:00
nacin d648585363 Mark menu items tied to invalid taxonomies and post types as invalid. props ocean90, see #13958. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@18260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-06-11 00:55:48 +00:00
nacin 148dac95df s/showposts/posts_per_page/ 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-10-13 05:25:00 +00:00
nacin 5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-09-07 11:21:11 +00:00
nacin 9f1d1ba7fa Add unregister_nav_menu(). props jorbin, fixes #14001 for 3.1. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15467 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-07-22 20:50:11 +00:00
nacin f98fc6e766 Add missing filter to wp_get_nav_menu_items(). props filosofo, fixes #13858. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-14 20:50:55 +00:00
nacin 48bc4e220c Revert [15219], [15250], some of [15249] for 3.0, revisit in 3.0.1. see #13822. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-14 19:52:30 +00:00
nacin 40e4de4ba8 Treat trash/untrash of posts associated with media items the same as other stati changes. props koopersmith, see #13822. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-14 08:33:48 +00:00
ryan 5ecd1f31f2 Trim trailing whitespace. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-11 20:19:35 +00:00
wpmuguru 9eaf91db65 hide unpublished items on frontend nav menus, props filosofo, fixes #13822 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-11 15:34:32 +00:00
nacin e13e6254dc Switch to current_theme_supports(menus) internally. Adding theme support for 'nav-menus' is deprecated in favor of register_nav_menu(s). fixes #13825. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-10 17:57:30 +00:00
ryan 17129fb62e Cut 'em out, move 'em on, trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-02 20:04:07 +00:00
ryan d4c5f9b0cd wp_get_nav_menus filter. Props filosofo. fixes #13702 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-02 16:31:42 +00:00
nacin a161f9bdcd Ensure we're only auto-adding root pages to menus. fixes #13447. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-02 15:08:03 +00:00
ryan 497f4dfee7 Nav menu API cleanups. Props filosofo. fixes #13696 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-02 13:43:46 +00:00
nacin cb88a1c972 Introduce has_nav_menu(). Returns boolean whether the theme's registered nav menu location has a menu assigned to it. props greenshady for the idea. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-06-01 16:40:14 +00:00
nacin 332bac61a1 Cleanups. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-31 16:11:20 +00:00
nacin 15a1a43cd1 New pending menu item behavior. props filosofo, see #13579. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@15008 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-27 22:22:09 +00:00
nacin da7b990fb5 Move the "Add Home Link" functionality to a checkbox on the View All tab of the Pages metabox. Also makes it work non-JS. props filosofo, fixes #13213. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14971 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-27 02:24:33 +00:00
ryan 65c6c9a3bd Make classes property for menus an array. Props filosofo. fixes #13551 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 15:41:21 +00:00
nacin 039ba88d09 Ensure auto-added pages are both published and sent to the end of the menu. Tiny enhancement and optimization to wp_update_nav_menu_item come with it. fixes #13447. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14937 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 06:59:14 +00:00
nacin c0289daf99 Don't store nonexistent (deleted) menus in the auto-add option. see #13447. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14934 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 05:11:46 +00:00
ryan 1a552dd029 Strip trailing whitespace 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-26 02:42:15 +00:00
nacin 913dd27ef5 Allow pages to be added automattically to menus. see #13447. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14878 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-25 13:49:56 +00:00
nacin 35a9bc1670 Properly format menu item title attributes and descriptions. props ryan, fixes #12864. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14826 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-23 22:56:51 +00:00
nacin 8d4a9a7568 Notice sanity check. fixes #13484, props etiger13. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14788 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-21 19:02:36 +00:00
ryan f1f5f4f8f7 Order menu tabs by name. Allow passing args to wp_get_nav_menus() which are passed on to get_terms(). Default orderby for wo_get_nav_menus() to none since most requests won't care about order. fixes #13334 
git-svn-id: http://svn.automattic.com/wordpress/trunk@14751 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2010-05-19 18:52:37 +00:00