Commit Graph

79 Commits

Author SHA1 Message Date
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Andrew Nacin 0d37467603 Move sanitization for the multisite illegal_names, limited_email_domains, and banned_email_domains options to sanitize_option(). props wonderboymusic. fixes #21552.
git-svn-id: http://core.svn.wordpress.org/trunk@21993 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-25 01:54:12 +00:00
ryan 7859542799 Remove obsolete help string. Props SergeyBiryukov. fixes #20909
git-svn-id: http://core.svn.wordpress.org/trunk@21051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-11 20:32:21 +00:00
nacin 2dd485a823 s/website/network/ on the network settings screen. props Ipstenu, fixes #20314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-11 20:45:03 +00:00
nacin 959160e789 Remove step="" from upload size inputs, as the step is enforced in the spec, rather than being a recommendation. finally fixes #17863.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-25 13:02:01 +00:00
nacin 35ba4853bf Adjust site upload space HTML5 type='number' validation. see #17863.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-16 04:16:21 +00:00
duck_ 81a7ad2c81 split was deprecated in PHP 5.3.0, so use explode instead. Props garyc40. Fixes #16325.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-09 21:20:51 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
ryan 8ace5a6b4c Use WP_Screen::add_help_tab(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19514 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-01 02:22:07 +00:00
nacin cece838d8f More s/add_help_sidebar/set_help_sidebar/. fixes #19020.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19122 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 21:32:16 +00:00
ryan 366db8c10b Use add_help_sidebar(). see #19020
git-svn-id: http://svn.automattic.com/wordpress/trunk@19114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 05:33:53 +00:00
nacin 4179013f06 Oops. see #17578.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 22:05:43 +00:00
nacin 5d33f15fb3 Kill the multisite mu_media_buttons option. see #17578.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-05 22:04:09 +00:00
ryan ed4c502e16 s/Settings/Network Settings/. Props wpmuguru. fixes #16027
git-svn-id: http://svn.automattic.com/wordpress/trunk@18842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-30 17:26:14 +00:00
nacin ae91e0dfcd Move network/settings.php POST handling out of network/edit.php. props PeteMall, see #18379.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-11 22:32:35 +00:00
ryan 18335b5516 Update some network admin help text. Props dougwrites. fixes #16988
git-svn-id: http://svn.automattic.com/wordpress/trunk@17921 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-13 19:25:38 +00:00
markjaquith 52eb3e668c s/Network Options/Settings/. props wpmuguru. Not a string change (already existed). fixes #16027
git-svn-id: http://svn.automattic.com/wordpress/trunk@17178 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-30 16:14:41 +00:00
nacin 0f2672e53d Move to what will be the new Network Admin Codex page URLs. see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17045 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-18 18:27:12 +00:00
nacin 9417d79543 Move to 'Documentation on XY' in the network admin. see #15314.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-16 07:07:42 +00:00
nbachiyski 442de36663 Add New string fixes. Fixes #15577
git-svn-id: http://svn.automattic.com/wordpress/trunk@16612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-29 16:54:06 +00:00
markjaquith 6482610f9a esc_textarea() and application for obvious textarea escaping. props alexkingorg. fixes #15454
git-svn-id: http://svn.automattic.com/wordpress/trunk@16431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-17 17:12:01 +00:00
nacin 07a19372f5 Remove unnecessary message in network/settings. see #14435
git-svn-id: http://svn.automattic.com/wordpress/trunk@16406 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-16 17:51:45 +00:00
nacin f269b75d7b Network admin multisite checks and docs. see #14435.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-10 14:27:15 +00:00
nacin a1c4c4789f Network Wide Settings -> Language Settings and kill the notice, which is implicit enough with the word 'Default.' see #14435.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-10 14:01:39 +00:00
nacin 27da8a122e Cast before implode. fixes #15167.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15868 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-20 14:22:47 +00:00
scribu 799baf139c Use submit_button() in more places. See #15064
git-svn-id: http://svn.automattic.com/wordpress/trunk@15830 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-17 18:24:34 +00:00
ryan 9c31fd7c70 First pass of user admin. Network admin and screen cleanups. see #14696
git-svn-id: http://svn.automattic.com/wordpress/trunk@15746 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-07 19:34:18 +00:00
ryan 21e3f0f7fa Network Admin, first pass. see #14435
git-svn-id: http://svn.automattic.com/wordpress/trunk@15481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-07-30 20:34:54 +00:00