Sergey Biryukov
7932193708
Coding Standards: Use strict comparison where static strings are involved.
...
This reduces the number of `WordPress.PHP.StrictComparisons.LooseComparison` issues in half, from 1897 to 890.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47808
git-svn-id: http://core.svn.wordpress.org/trunk@47584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-16 18:42:12 +00:00
Sergey Biryukov
38676936ba
Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved.
...
This reduces the number of `WordPress.PHP.StrictInArray.MissingTrueStrict` issues from 486 to 50.
Includes minor code layout fixes for better readability.
See #49542 .
Built from https://develop.svn.wordpress.org/trunk@47550
git-svn-id: http://core.svn.wordpress.org/trunk@47325 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-04-05 03:02:11 +00:00
Sergey Biryukov
e199663322
I18N: Capitalize translator comments consistently, add trailing punctuation.
...
Includes minor code layout fixes.
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45932
git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
Sergey Biryukov
83187125e4
Bundled Themes: Audit and update version numbers passed to `wp_enqueue_script()` to ensure proper cache busting.
...
Props dswebsme, ianbelanger, justinahinon.
Fixes #46981 .
Built from https://develop.svn.wordpress.org/trunk@45768
git-svn-id: http://core.svn.wordpress.org/trunk@45579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-08-08 01:29:58 +00:00
Gary Pendergast
c71bc1513e
Coding Standards: Add missing translator comments to the default themes.
...
All default themes now have translator comments for all strings with placeholders!
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45609
git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:10:00 +00:00
Gary Pendergast
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Sergey Biryukov
510feac5bb
Twenty Fourteen: Remove redundant `@access` and `@static` notations from classes.
...
Props birgire.
See #41452 , #42803 , #42505 .
Built from https://develop.svn.wordpress.org/trunk@42749
git-svn-id: http://core.svn.wordpress.org/trunk@42579 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-02-25 20:49:30 +00:00
Gary Pendergast
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Dominik Schilling
e5ea82d81a
Spelling: Standardize on "front end"/"back end" (noun) and "front-end"/"back-end" (adjective).
...
Props obrienlabs, thewanderingbrit.
Fixes #34887 .
Built from https://develop.svn.wordpress.org/trunk@36709
git-svn-id: http://core.svn.wordpress.org/trunk@36676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-02-25 12:53:27 +00:00
Lance Willett
17f69a89d4
Twenty Fourteen: fix escaping and minor code style issues. See #29127 .
...
Built from https://develop.svn.wordpress.org/trunk@31250
git-svn-id: http://core.svn.wordpress.org/trunk@31231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-20 19:03:23 +00:00
Dominik Schilling
61819a36ea
Customizer: Change instances of "Theme Customizer" to just "Customizer", as the Customizer isn't necessarily theme-specific.
...
Also capitalize "Customizer".
See also https://make.wordpress.org/core/2014/07/08/customizer-improvements-in-4-0/ .
props studionashvegas, tareq1988.
fixes #29947 .
Built from https://develop.svn.wordpress.org/trunk@29903
git-svn-id: http://core.svn.wordpress.org/trunk@29658 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 17:21:19 +00:00
Sergey Biryukov
b9357c40eb
Twenty Fourteen: Use correct check for the front page in Featured_Content::pre_get_posts().
...
props kwight.
fixes #29550 .
Built from https://develop.svn.wordpress.org/trunk@29719
git-svn-id: http://core.svn.wordpress.org/trunk@29493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-07 14:23:17 +00:00
Sergey Biryukov
b7c94cee0b
Twenty Fourteen: Remove unused variable after [27120].
...
props michalzuber.
fixes #28928 .
Built from https://develop.svn.wordpress.org/trunk@29210
git-svn-id: http://core.svn.wordpress.org/trunk@28994 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-17 19:09:14 +00:00
Lance Willett
f5fcb58404
Twenty Fourteen: optimize featured content lookup to reduce the number of queries for featured posts. Props Chouby and obenland, closes #26744 .
...
Built from https://develop.svn.wordpress.org/trunk@29174
git-svn-id: http://core.svn.wordpress.org/trunk@28958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-15 06:44:15 +00:00
Sergey Biryukov
7de1eac464
Twenty Fourteen: Bail early from Featured_Content::hide_featured_term() if term objects are unavailable.
...
fixes #28072 .
Built from https://develop.svn.wordpress.org/trunk@28536
git-svn-id: http://core.svn.wordpress.org/trunk@28362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-22 09:25:15 +00:00
Lance Willett
a46e7ca3dc
Twenty Fourteen: remove doc block comments for `@return void`. See #27098 , props philiparthurmoore.
...
Built from https://develop.svn.wordpress.org/trunk@27595
git-svn-id: http://core.svn.wordpress.org/trunk@27438 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-18 22:44:14 +00:00
Lance Willett
b6233e15a3
Twenty Fourteen: merge two similar strings in Customizer featured content help text. Props celloexpressions, fixes #26647 .
...
Built from https://develop.svn.wordpress.org/trunk@27573
git-svn-id: http://core.svn.wordpress.org/trunk@27416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-17 22:07:14 +00:00
Lance Willett
c2f46ac811
Twenty Fourteen: translate `featured` tag slug used to link to specific tags in Posts editor. See #26526 .
...
Built from https://develop.svn.wordpress.org/trunk@27122
git-svn-id: http://core.svn.wordpress.org/trunk@26989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 17:47:11 +00:00
Lance Willett
88a2fe2986
Twenty Fourteen: delete the `featured_content_ids` transient on theme switch to make sure child themes can override the Featured Content quantity value. Also remove quantity parameter so child themes can change the amount of featured posts with `$max_posts`.
...
Props obenland, see #26660 .
Built from https://develop.svn.wordpress.org/trunk@27120
git-svn-id: http://core.svn.wordpress.org/trunk@26987 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 17:39:13 +00:00
Lance Willett
31e9d97412
Twenty Fourteen: make sure `featured` tag is hidden on front-end views as expected. Add a check for the tag name in case we're using default values and the default ID of `0` does not match the term id of the `featured` tag.
...
Props obenland, fixes #26732 .
Built from https://develop.svn.wordpress.org/trunk@27118
git-svn-id: http://core.svn.wordpress.org/trunk@26985 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-07 17:17:13 +00:00
Lance Willett
e46662b6ae
Twenty Fourteen: update comment blocks to match inline docs standards. Props DrewAPicture, see #25837 .
...
Built from https://develop.svn.wordpress.org/trunk@26556
git-svn-id: http://core.svn.wordpress.org/trunk@26447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 17:06:11 +00:00
Lance Willett
1d0bce8013
Twenty Fourteen: update Customizer inline help text. Props siobhan, see #25837 .
...
Built from https://develop.svn.wordpress.org/trunk@26361
git-svn-id: http://core.svn.wordpress.org/trunk@26262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-24 16:57:10 +00:00
Lance Willett
8321cdd567
Twenty Fourteen: avoid premature creation of tags when using the tag suggestion for Featured Content. Props obenland, fixes #26080 .
...
Built from https://develop.svn.wordpress.org/trunk@26270
git-svn-id: http://core.svn.wordpress.org/trunk@26175 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-19 15:27:11 +00:00
Lance Willett
9e201fadff
Twenty Fourteen: updates all PHP files to meet new brace style in WP coding standards. Props rickalee for initial patch, fixes #26093 .
...
Built from https://develop.svn.wordpress.org/trunk@26260
git-svn-id: http://core.svn.wordpress.org/trunk@26166 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 23:11:10 +00:00
Sergey Biryukov
a110ab596f
Correctly capitalize WP_Query in Featured_Content::pre_get_posts() inline docs. see #26064 .
...
Built from https://develop.svn.wordpress.org/trunk@26257
git-svn-id: http://core.svn.wordpress.org/trunk@26163 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 22:24:11 +00:00
Lance Willett
9c93043286
Twenty Fourteen: correct `$query` usage in `Featured_Content::pre_get_posts()`, props SergeyBiryukov, fixes #26064 .
...
Built from https://develop.svn.wordpress.org/trunk@26255
git-svn-id: http://core.svn.wordpress.org/trunk@26161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-18 22:04:09 +00:00
Scott Taylor
005fe51131
Don't call is_home() before the query is run in Featured Content's pre_get_posts hook callback.
...
Built from https://develop.svn.wordpress.org/trunk@26189
git-svn-id: http://core.svn.wordpress.org/trunk@26097 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 02:37:10 +00:00
Lance Willett
5d32b45b79
Twenty Fourteen: use numbered placeholders for Customizer help text in case they get swapped during translation, props obenland. See #25837 .
...
Built from https://develop.svn.wordpress.org/trunk@26135
git-svn-id: http://core.svn.wordpress.org/trunk@26047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 19:02:09 +00:00
Lance Willett
cdc03fe491
Twenty Fourteen: add in more contextual help for setting up Featured Content, links to "featured" tag posts and "sticky" posts from inside the Customizer. See #25837 .
...
Built from https://develop.svn.wordpress.org/trunk@26101
git-svn-id: http://core.svn.wordpress.org/trunk@26016 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-12 17:13:09 +00:00
Sergey Biryukov
3b66710dae
Remove the code for increasing z-index for the tag suggestion script from Twenty Fourteen.
...
fixes #25867 .
Built from https://develop.svn.wordpress.org/trunk@26086
git-svn-id: http://core.svn.wordpress.org/trunk@26006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-11 17:43:09 +00:00
Sergey Biryukov
4517d7b729
Remove the code for setting ajaxurl from Twenty Fourteen.
...
props celloexpressions.
fixes #25866 .
Built from https://develop.svn.wordpress.org/trunk@26083
git-svn-id: http://core.svn.wordpress.org/trunk@26003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-11 15:51:10 +00:00
Lance Willett
dc80ae6691
Twenty Fourteen: improve Featured Content experience in the Customizer. Better preview and cache clearing, props obenland and rachelbaker. Fixes #25549 .
...
Built from https://develop.svn.wordpress.org/trunk@26079
git-svn-id: http://core.svn.wordpress.org/trunk@25999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-10 23:38:10 +00:00
Lance Willett
5420155231
Twenty Fourteen: move all controls for managing Featured Content to the Customizer. Also implement smart fallbacks to not using a custom tag with the "featured" tag and sticky posts. Props obenland and celloexpressions, see #25549 .
...
Built from https://develop.svn.wordpress.org/trunk@26037
git-svn-id: http://core.svn.wordpress.org/trunk@25966 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-07 20:25:09 +00:00
Lance Willett
6b6a2d4dc4
Twenty Fourteen: fix a typo introduced in r25808, props kovshenin. See #25549 .
...
Built from https://develop.svn.wordpress.org/trunk@25853
git-svn-id: http://core.svn.wordpress.org/trunk@25853 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:57:09 +00:00
Andrew Nacin
8ae8e01b67
Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
...
see #27704 .
Built from https://develop.svn.wordpress.org/trunk@25825
git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 22:53:14 +00:00
Lance Willett
80d7b26a8c
Twenty Fourteen: fix a typo introduced in r25808, props kovshenin. See #25549 .
...
Built from https://develop.svn.wordpress.org/trunk@25853
git-svn-id: http://core.svn.wordpress.org/trunk@25765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-21 16:31:12 +00:00
Lance Willett
38b333977e
Twenty Fourteen: cleanup, props iamtakashi. Fixes #25613 .
...
* With the ephemera widget in place, `content-recent-formatted-post.php` is unused, see #25028 .
* We're no longe filtering formatted posts from the main query, see #25330 .
* Fix a typo.
Built from https://develop.svn.wordpress.org/trunk@25814
git-svn-id: http://core.svn.wordpress.org/trunk@25726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 18:29:09 +00:00
Lance Willett
fafbee59f9
Twenty Fourteen: implement tag auto-complete for featured content settings, and uppercase `__CLASS__` for consistency. Props kovshenin, see #25549 .
...
Built from https://develop.svn.wordpress.org/trunk@25813
git-svn-id: http://core.svn.wordpress.org/trunk@25725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 18:27:09 +00:00
Lance Willett
34edaed317
Twenty Fourteen: first pass at implementing Featured Content settings, props obenland. See #25549 .
...
Built from https://develop.svn.wordpress.org/trunk@25808
git-svn-id: http://core.svn.wordpress.org/trunk@25720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 04:22:09 +00:00