Commit Graph

27831 Commits

Author SHA1 Message Date
Sergey Biryukov f1bcfd66d2 Tests: Use delta comparison in test_should_fall_back_to_last_post_modified() to avoid race conditions.
Merges [46981] to the 5.3 branch.
See #48957.
Built from https://develop.svn.wordpress.org/branches/5.3@46982


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 21:35:03 +00:00
Andrew Ozz 99c691c8e2 Upload: Fix the final file name collision test in `wp_unique_filename()` when uploading a file with upper case extension and limit it to run for each file in the directory + 1. Add a unit test to catch that in the future.
Props pbiron, azaozz.
Merges [46966] and [46976] to the 5.3 branch.
Fixes #48975.

Built from https://develop.svn.wordpress.org/branches/5.3@46980


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 21:20:03 +00:00
Andrew Ozz fd030a496f Upload:
- Fix PHP warnings in `wp_unique_filename()` when the destination directory is unreadable.
- Run the final name collision test only for files that are saved to the uploads directory.
- Update the unit tests to match.

Props eden159, audrasjb, azaozz.
Merges [46965] to the 5.3 branch.
Fixes #48960.
Built from https://develop.svn.wordpress.org/branches/5.3@46979


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46779 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 21:12:03 +00:00
Sergey Biryukov 7b21983b01 Administration: Fix the colors in all color schemes for the `.active` class for buttons.
Props ryelle, audrasjb.
Merges [46967] to the 5.3 branch.
Fixes #49003.
Built from https://develop.svn.wordpress.org/branches/5.3@46978


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 21:03:02 +00:00
Sergey Biryukov cd10cf0c79 Date/Time: Ensure that `get_feed_build_date()` correctly handles a modified post object with invalid date.
* Clarify in the documentation that the function returns `false` on failure.
* Consistently pass the return value through the `get_feed_build_date` filter.

Props Rarst, dd32, azaozz, tellyworth.
Merges [46974] and [46973] to the 5.3 branch.
Fixes #48957.
Built from https://develop.svn.wordpress.org/branches/5.3@46977


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 20:54:03 +00:00
Sergey Biryukov 6d7dca07b0 Date/Time: In `wp_insert_post()`, when checking the post date to set `future` or `publish` status, use a proper delta comparison.
[3525] allowed a difference up to 59 seconds between the post date/time and the current time to consider the post published instead of scheduled, but that didn't take start of a new minute into account.

Rapidly creating post fixtures in unit tests could encounter a one-second discrepancy between `current_time( 'mysql' )` and `gmdate( 'Y-m-d H:i:s' )`, returning values like `2019-12-16 23:43:00` vs. `2019-12-16 23:42:59`, respectively, and setting the post to a `future` status instead of `publish`.

[45851], while working as intended, made the issue somewhat more likely to occur.

This caused all sorts of occasional random failures in various tests on Travis, mostly on PHP 7.1.

Merges [46968] and [46969] to the 5.3 branch.
Fixes #48145.
Built from https://develop.svn.wordpress.org/branches/5.3@46975


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 20:47:06 +00:00
Sergey Biryukov 2c9cdc0550 Post WordPress 5.3.1 version bump.
Built from https://develop.svn.wordpress.org/branches/5.3@46956


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-13 00:17:03 +00:00
Sergey Biryukov 5bbd15d57f WordPress 5.3.1
Built from https://develop.svn.wordpress.org/branches/5.3@46920


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 20:24:04 +00:00
Sergey Biryukov 6b07ab9913 Bundled Themes: Bump version number and update changelog in Twenty Twenty for WordPress 5.3.1.
This bumps the Twenty Twenty version number to `1.1` and update the `readme.txt` changelog.

Props audrasjb, sinatrateam, SergeyBiryukov, ianbelanger.
Merges [46902] to the 5.3 branch.
Fixes #48944.
Built from https://develop.svn.wordpress.org/branches/5.3@46905


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46705 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 18:31:04 +00:00
whyisjake 20740afc8f Prevent stored XSS in the block editor.
Brings r46896 to the 5.3 branch.

Prevent escaped unicode characters become unescaped in unsafe HTML during JSON decoding.


Built from https://develop.svn.wordpress.org/branches/5.3@46900


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46700 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 18:14:06 +00:00
whyisjake 58f8f500d3 Update `wp_kses_bad_protocol()` to recognize `:` on uri attributes,
`wp_kses_bad_protocol()` makes sure to validate that uri attributes don’t contain invalid/or not allowed protocols. While this works fine in most cases, there’s a risk that by using the colon html5 named entity, one is able to bypass this function.

Brings r46895 to the 5.3 branch.

Props: xknown, nickdaugherty, peterwilsoncc.

Built from https://develop.svn.wordpress.org/branches/5.3@46899


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46699 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 18:13:03 +00:00
whyisjake 8221d6d320 Prevent stored XSS through wp_targeted_link_rel().
Brings r46894 to the 5.3 branch.

Props: vortfu, whyisjake, peterwilsoncc, xknown,  SergeyBiryukov, flaviozavan.

Built from https://develop.svn.wordpress.org/branches/5.3@46898


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46698 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 18:11:01 +00:00
whyisjake f0871560df Ensure that a user can publish_posts before making a post sticky.
Props: danielbachhuber, whyisjake, peterwilson, xknown.

Built from https://develop.svn.wordpress.org/branches/5.3@46897


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46697 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 18:09:02 +00:00
Sergey Biryukov d9238aa70b Help/About: Update the About page for 5.3.1.
Props audrasjb, melchoyce.
Fixes #48945.
Built from https://develop.svn.wordpress.org/branches/5.3@46892


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46692 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 16:59:05 +00:00
Sergey Biryukov f5aac93fa0 Post WordPress 5.3.1 RC2 version bump
Built from https://develop.svn.wordpress.org/branches/5.3@46890


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-12 00:00:03 +00:00
Sergey Biryukov 2910b5cfea WordPress 5.3.1 RC2
Built from https://develop.svn.wordpress.org/branches/5.3@46889


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46689 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 23:39:01 +00:00
Sergey Biryukov 409a89668a Upgrade/Install: Improve the appearance of language selection on install:
* Remove a stray chevron.
* Improve focus and hover styles.

Props garrett-eclipse, audrasjb.
Merges [46887] to the 5.3 branch.
Fixes #48927.
Built from https://develop.svn.wordpress.org/branches/5.3@46888


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46688 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 23:05:02 +00:00
Sergey Biryukov c7d610fb02 Comments: Avoid a PHP notice in `comment_form()` if the `email` field is not set.
Follow-up to [46090].

Props mat-lipe.
Merges [46885] to the 5.3 branch.
Fixes #48943.
Built from https://develop.svn.wordpress.org/branches/5.3@46886


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46686 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 22:16:03 +00:00
Andrew Ozz 9e38fc8259 Fixes in `admin-bar.js`:
- Silence errors when a node doesn't exist similarly to jQuery.
- Add "feature testing" and fallbacks for old browsers as this may run on the front-end.
- Improve inline docs.

Props dinhtungdu, azaozz.
Merges [46883] to the 5.3 branch.
Fixes #47069.


Built from https://develop.svn.wordpress.org/branches/5.3@46884


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 20:23:05 +00:00
Sergey Biryukov e4cf151207 Post WordPress 5.3.1 RC1 version bump
Built from https://develop.svn.wordpress.org/branches/5.3@46877


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46677 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-10 02:12:03 +00:00
Sergey Biryukov 17570cfbd8 WordPress 5.3.1 RC1
Built from https://develop.svn.wordpress.org/branches/5.3@46876


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46676 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-10 01:56:04 +00:00
Sergey Biryukov 6e0e255964 Coding Standards: Fix WPCS and JSHint issues in [46872].
Merges [46874] to the 5.3 branch.
See #47069.
Built from https://develop.svn.wordpress.org/branches/5.3@46875


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-10 01:38:02 +00:00
Andrew Ozz d73f11a4ce Fix the admin toolbar js when jQuery is not present and replace the jQuery based hoverIntent.js with a native implementation. Introduces the "hoverintent" (no dependencies) package.
Props dinhtungdu, audrasjb, azaozz.
Merges [46872] to the 5.3 branch.
Fixes #47069.
Built from https://develop.svn.wordpress.org/branches/5.3@46873


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46673 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-10 01:08:03 +00:00
Sergey Biryukov f5d738e01c Block Editor: Resolve `@wordpress/block-directory` to the expected version, 1.0.6.
Follow-up to [46860].

Props aduth, garrett-eclipse, audrasjb, azaozz.
Merges [46870] to the 5.3 branch.
Fixes #48884.
Built from https://develop.svn.wordpress.org/branches/5.3@46871


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 22:31:05 +00:00
Sergey Biryukov 3487611129 Menus: Avoid a PHP warning in `add_submenu_page()` when the same value is passed for both `$parent_slug` and `$menu_slug` parameters.
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Merges [46868] to the 5.3 branch.
Fixes #48599.
Built from https://develop.svn.wordpress.org/branches/5.3@46869


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 21:06:03 +00:00
Sergey Biryukov ecdd9d8390 Administration: Standardize form control height and alignment across the admin.
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.

Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Merges [46866] to the 5.3 branch.
Fixes #48420.
Built from https://develop.svn.wordpress.org/branches/5.3@46867


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46667 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 20:28:04 +00:00
Sergey Biryukov 1cdaf142f2 Date/Time: XML-RPC: Сalculate the proper offset for GMT in `wp.newPost`, `wp.editComment`, `mw.newPost`, `mw.editPost` when `post_date` or `comment_date` is set.
Previously, `post_date` or `comment_date` was assumed to be GMT, which is only true if the timezone string for the site matches GMT.

Add unit tests.

Props Rarst, smerriman, justdaiv, wonderboymusic, noyle.
Merges [46864] to the 5.3 branch.
Fixes #30429.
Built from https://develop.svn.wordpress.org/branches/5.3@46865


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 20:08:06 +00:00
Sergey Biryukov e5f1a70a87 Date/Time: When determining whether to decline the month name in `wp_maybe_decline_date()`, take word boundaries into account.
Add more unit tests.

Props Rarst, Clorith, timon33, Xendo, SergeyBiryukov.
Merges [46862] to the 5.3 branch.
Fixes #48606.
Built from https://develop.svn.wordpress.org/branches/5.3@46863


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 19:02:04 +00:00
Sergey Biryukov 44bff0da78 Block Editor: Bug fixes targeted for WordPress 5.3.1.
The list of included fixes:

- Edge scrolling issues https://github.com/WordPress/gutenberg/pull/17707
- Intermittent JavaScript issues https://github.com/WordPress/gutenberg/pull/18559
- Remove embed CollegeHumor https://github.com/WordPress/gutenberg/pull/18591 

Updated packages:

- @wordpress/block-directory@1.0.6
- @wordpress/block-editor@3.2.5
- @wordpress/block-library@2.9.6
- @wordpress/core-data@2.7.5
- @wordpress/edit-post@3.8.6
- @wordpress/editor@9.7.6
- @wordpress/format-library@1.9.5

Props youknowriad, ellatrix, epiqueras, audrasjb, gziolo, mcsf, kyliesabra.
Merges [46860] to the 5.3 branch.
Fixes #48884.
Built from https://develop.svn.wordpress.org/branches/5.3@46861


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46661 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 17:42:10 +00:00
Sergey Biryukov 01bd5c0eed Upgrade/Install: Update sodium_compat to v1.12.1.
This includes a speedup for signature verification on most platforms and bugfixes for 32-bit platforms.

Props paragoninitiativeenterprises, lukaswaudentio.
Merges [46858] to the 5.3 branch.
Fixes #48371.
Built from https://develop.svn.wordpress.org/branches/5.3@46859


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 16:46:03 +00:00
Sergey Biryukov d01a9c3c46 Media: Use consistent width for Scale and Crop inputs.
Follow-up to [46359].

Props sabernhardt, audrasjb.
Merges [46856] to the 5.3 branch.
Fixes #48907.
Built from https://develop.svn.wordpress.org/branches/5.3@46857


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46657 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 16:25:04 +00:00
Sergey Biryukov e3c254bf75 Bundled Themes: Misaligned input placeholder text Twenty Twenty.
This fixes placeholder misalignment in Firefox when a `height` is added as an inline style to the input field.

Props aljullu, subratamal, ianbelanger.
Merges [46851], [46854] to the 5.3 branch.
Fixes #48876.
Built from https://develop.svn.wordpress.org/branches/5.3@46855


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 16:20:03 +00:00
Sergey Biryukov ba1ec74fdc Help/About: Add a hover effect for links on About pages.
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.

Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Merges [46852] to the 5.3 branch.
Fixes #48582.
Built from https://develop.svn.wordpress.org/branches/5.3@46853


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 15:33:03 +00:00
Sergey Biryukov a590a590a3 Twenty Twenty: Remove redundant `echo` for `bloginfo()` call in `footer.php`.
Props acosmin.
Merges [46849] to the 5.3 branch.
Fixes #48918.
Built from https://develop.svn.wordpress.org/branches/5.3@46850


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 15:02:04 +00:00
Sergey Biryukov 06ebac2233 Twenty Twenty: Adds Customizer option to show or hide author bio.
This adds an option to the Customizer that allows you to turn the author bio on or off, sitewide.

Props williampatton, nielslange, acosmin, dlh, ianbelanger.
Merges [46813] to the 5.3 branch.
Fixes #48550.
Built from https://develop.svn.wordpress.org/branches/5.3@46848


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46648 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 14:41:04 +00:00
Sergey Biryukov 7e5d62f195 Twenty Twenty: Make checkbox in comment form larger.
This makes the checkbox in the comment form larger and more consistent with other checkboxes.

Props kharisblank, audrasjb, ianbelanger.
Merges [46844] to the 5.3 branch.
Fixes #48652.
Built from https://develop.svn.wordpress.org/branches/5.3@46847


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 14:32:03 +00:00
Sergey Biryukov 05b9f27d11 Administration: Correct checkbox width in list tables on smaller screens.
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.

Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Merges [46845] to the 5.3 branch.
Fixes #48815.
Built from https://develop.svn.wordpress.org/branches/5.3@46846


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 14:30:02 +00:00
Sergey Biryukov 9870e114af Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created.
This ensures that the actual UI controls state matches the visually conveyed state.

Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Merges [46842] to the 5.3 branch.
Fixes #48409.
Built from https://develop.svn.wordpress.org/branches/5.3@46843


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46643 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:51:02 +00:00
Sergey Biryukov ad8e49e8dd Twenty Twenty: Correct alignment for embedded Instagram posts.
Props SGr33n, audrasjb, nielslange, JarretC.
Merges [46840] to the 5.3 branch.
Fixes #48688.
Built from https://develop.svn.wordpress.org/branches/5.3@46841


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:41:00 +00:00
Sergey Biryukov 97b8443321 Users: Introduce `admin_email_remind_interval` filter for dismissing the admin email confirmation screen.
Props desrosj, birgire.
Merges [46838], [46837] to the 5.3 branch.
Fixes #48334.
Built from https://develop.svn.wordpress.org/branches/5.3@46839


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:30:03 +00:00
Sergey Biryukov 176a6206a3 Upload: fix `wp_unique_filename()` to prevent name collisions with existing or future image sub-size file names, and add unit tests.
Props Viper007Bond, pbiron, azaozz.
Merges [46822], [46835] to the 5.3 branch.
Fixes #42437.
Built from https://develop.svn.wordpress.org/branches/5.3@46836


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 12:21:03 +00:00
Sergey Biryukov d6875bc495 Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original.
Props azaozz.
Merges [46809] to the 5.3 branch.
Fixes #48736.
Built from https://develop.svn.wordpress.org/branches/5.3@46834


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 12:04:02 +00:00
Sergey Biryukov 33da7d7e7f Twenty Twenty: Pass `$post_meta` and `$location` values to `twentytwenty_start_of_post_meta_list` and `twentytwenty_end_of_post_meta_list` actions to provide better context.
Props msaari, SergeyBiryukov.
Merges [46832] to the 5.3 branch.
Fixes #48906.
Built from https://develop.svn.wordpress.org/branches/5.3@46833


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46633 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 11:51:05 +00:00
Sergey Biryukov bd3bd0c6ff Twenty Twenty: Replace Smooth Scroll JS implementation with `scroll-behavior` CSS property.
The JS implementation had multiple issues and did not work as expected.

This change includes an accessibility enhancement by using `prefers-reduced-motion: reduce` media query property for users that don't want motion effects. For further explanation on this media query, see MDN documentation: https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns

Props audrasjb, melchoyce, joostdevalk, Anlino, mauteri, sergiomdgomes, littlebigthing, williampatton, netweb, andraganescu, joyously, acosmin, mukesh27, hareesh-pillai.
Merges [46824] to the 5.3 branch.
Fixes #48763, #48551, #48866.
Built from https://develop.svn.wordpress.org/branches/5.3@46825


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-07 11:08:01 +00:00
Sergey Biryukov 4c4662e95c Accessibility: Administration: Correct active button color for the alternative color schemes.
Follow-up to [46815].

Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Merges [46817] to the 5.3 branch.
Fixes #48598.
Built from https://develop.svn.wordpress.org/branches/5.3@46818


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 22:14:04 +00:00
Sergey Biryukov 6cd7126ff2 Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.

Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Merges [46815] to the 5.3 branch.
Fixes #48585.
Built from https://develop.svn.wordpress.org/branches/5.3@46816


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46616 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 21:34:05 +00:00
Sergey Biryukov b7f33680dc Site Health: Add a test for PHP default timezone.
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.

WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.

Props Rarst, Clorith, TimothyBlynJacobs.
Merges [46797] to the 5.3 branch.
Fixes #48692.
Built from https://develop.svn.wordpress.org/branches/5.3@46798


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46598 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 15:57:05 +00:00
Sergey Biryukov 9156181d27 Date/Time: Make `get_permalink()` more resilient against PHP timezone changes.
Overriding default PHP timezone with `date_default_timezone_set()`, while not recommended, should not inadvertently result in changing existing permalinks.

Add a unit test.

Props Rarst, steevithak, archon810, maciejmackowiak, Ov3rfly, Cybr, hometowntrailers, scvleon, miette49.
Merges [46795] to the 5.3 branch.
Fixes #48623.
Built from https://develop.svn.wordpress.org/branches/5.3@46796


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 13:57:02 +00:00
Sergey Biryukov 2fed57f1b0 KSES: Add support for gradient backgrounds.
Props jorgefilipecosta.
Merges [46793] to the 5.3 branch.
Fixes #48376.
Built from https://develop.svn.wordpress.org/branches/5.3@46794


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 00:31:02 +00:00
Sergey Biryukov b06ee36d81 Users: Display admin email verification screen in user's locale instead of site locale.
Props sathyapulse, TimothyBlynJacobs.
Merges [46788] to the 5.3 branch.
Fixes #48313.
Built from https://develop.svn.wordpress.org/branches/5.3@46789


git-svn-id: http://core.svn.wordpress.org/branches/5.3@46589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 14:40:00 +00:00