f1ea8f222f
Widgets: Fix custom HTML widget editor content not updating after save.
...
An integer comparison is performed against `control.currentErrorAnnotations`, but `control.currentErrorAnnotations` is actually an array. This fixes that comparison so the content saves correctly.
Props barryceelen.
Fixes #43657 .
Built from https://develop.svn.wordpress.org/trunk@44474
git-svn-id: http://core.svn.wordpress.org/trunk@44305 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 16:42:49 +00:00
0f3835d394
Users: Add the `pre_count_users` filter.
...
Props spacedmonkey.
Fixes #43693 .
Built from https://develop.svn.wordpress.org/trunk@44473
git-svn-id: http://core.svn.wordpress.org/trunk@44304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:49:50 +00:00
ea9286844f
Multisite: Introduce `ms-site.php` and `ms-network.php` files.
...
By providing distinct files for the site and network APIs, a better overview is provided. Prior to this change, the `ms-blogs.php` file had grown too big, mixing site APIs, network APIs and related legacy APIs that need to be maintained. Since multisite is often used in unexpected ways, backward-compatibility is ensured by including the two new files from `ms-blogs.php`, which previously contained all functions that have been moved to the new files.
This changeset does not contain any functional changes.
Fixes #40647 .
Built from https://develop.svn.wordpress.org/trunk@44472
git-svn-id: http://core.svn.wordpress.org/trunk@44303 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:15:49 +00:00
8947acbf9b
Media: Add `$attr` to the `wp_get_attachment_link` filter.
...
Props danielbachhuber.
Fixes #40155 .
Built from https://develop.svn.wordpress.org/trunk@44471
git-svn-id: http://core.svn.wordpress.org/trunk@44302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:09:49 +00:00
e83f753246
Coding Standards: Fix an error introduced in [44465].
...
See #45748 .
Built from https://develop.svn.wordpress.org/trunk@44470
git-svn-id: http://core.svn.wordpress.org/trunk@44301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 09:03:50 +00:00
0b15142c0b
Multisite: Update `@since` tags for site management APIs.
...
Fixes #40364 . Fixes #41333 .
Built from https://develop.svn.wordpress.org/trunk@44469
git-svn-id: http://core.svn.wordpress.org/trunk@44300 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 08:58:49 +00:00
321bdfbacf
Multisite: Move site-specific metadata integrations from the wrapper functions to the low-level Meta API functions.
...
This complements the work in [43729] and prepares site metadata for future REST API support.
Props spacedmonkey.
Fixes #45091 . See #44467 .
Built from https://develop.svn.wordpress.org/trunk@44468
git-svn-id: http://core.svn.wordpress.org/trunk@44299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 08:48:48 +00:00
035877708d
Multisite: Update `@since` tags for site meta introduction.
...
Fixes #37923 . Fixes #40229 .
Built from https://develop.svn.wordpress.org/trunk@44467
git-svn-id: http://core.svn.wordpress.org/trunk@44298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 08:18:50 +00:00
952c7253d3
Comments: Improve the Author box in the Edit Comment screen.
...
- Add a border below the heading, to match meta boxes.
- Remove the colons from the input labels.
- Tweak the padding and margins.
Props birgire, abdullahramzan, rhetorical, BODA1982, pento.
Fixes #43586 .
Built from https://develop.svn.wordpress.org/trunk@44466
git-svn-id: http://core.svn.wordpress.org/trunk@44297 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:19:50 +00:00
8d2ee69f9d
Users: Use `email_exists()` in `send_confirmation_on_profile_email()`, instead of a manual query.
...
This gives us caching, and removes the use of the `$wpdb` global.
Props spacedmonkey, pento.
Fixes #45748 .
Built from https://develop.svn.wordpress.org/trunk@44465
git-svn-id: http://core.svn.wordpress.org/trunk@44296 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:07:51 +00:00
fe837d19a7
Docs: Fix the `@param` type for `wp_make_plugin_file_tree()`.
...
`$plugin_editable_files` is an `array`, not a `string`.
Props subrataemfluence.
Fixes #45593 .
Built from https://develop.svn.wordpress.org/trunk@44464
git-svn-id: http://core.svn.wordpress.org/trunk@44295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:02:51 +00:00
5b3e08020b
Docs: Improve the `@global` tags in `wp-includes/option.php`.
...
Props upadalavipul.
Fixes #45581 .
Built from https://develop.svn.wordpress.org/trunk@44463
git-svn-id: http://core.svn.wordpress.org/trunk@44294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 06:00:50 +00:00
7d77a6eb04
Docs: Correct the parameters passed to the `twentyseventeen_custom_header_args` filter.
...
The documented `$default_text_color` parameter isn't passed, and the `$video` parameter is passed, but not documented.
Props mukesh27.
Fixes #44920 .
Built from https://develop.svn.wordpress.org/trunk@44462
git-svn-id: http://core.svn.wordpress.org/trunk@44293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:56:49 +00:00
54617423e7
Coding Standards: Improve the readability of `get_the_modified_author()`.
...
Props promz.
Fixes #44951 .
Built from https://develop.svn.wordpress.org/trunk@44461
git-svn-id: http://core.svn.wordpress.org/trunk@44292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:50:49 +00:00
12b800788e
Docs: Improve the `@return` description of `network_domain_check()`.
...
Props ishitaka, vaishalipanchal.
Fixes #45403 .
Built from https://develop.svn.wordpress.org/trunk@44460
git-svn-id: http://core.svn.wordpress.org/trunk@44291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:27:50 +00:00
3d918be94e
Docs: Add a missing `@global` to the `WP_Customize_Date_Time_Control::get_month_choices()` docblock.
...
Props utsav72640.
Fixes #45500 .
Built from https://develop.svn.wordpress.org/trunk@44459
git-svn-id: http://core.svn.wordpress.org/trunk@44290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:24:49 +00:00
f3656e2695
Docs: Add a reference to `WP_Customize_Control` from the `WP_Customize_Nav_Menu_Locations_Control` docblock.
...
`WP_Customize_Control` is the parent class of `WP_Customize_Nav_Menu_Locations_Control`.
Props utsav72640.
Fixes #45570 .
Built from https://develop.svn.wordpress.org/trunk@44458
git-svn-id: http://core.svn.wordpress.org/trunk@44289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 05:18:50 +00:00
2bbe0bd7e4
Docs: Fix the `@param` types for `comments_popup_link().
...
Props Mirucon.
Fixes #44841 .
Built from https://develop.svn.wordpress.org/trunk@44457
git-svn-id: http://core.svn.wordpress.org/trunk@44288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 04:50:51 +00:00
344348ba5b
Query: Fix some code formatting issues introduced in [44452].
...
See #38034 .
Built from https://develop.svn.wordpress.org/trunk@44456
git-svn-id: http://core.svn.wordpress.org/trunk@44287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 04:32:50 +00:00
363cfc4301
General: Replace "Happy blogging" with "Happy publishing".
...
As of this commit, WordPress is no longer a simple blogging platform. It's now a comprehensive publishing solution.
This also replaces a couple of other "blog" references that were missed previously.
Props igmoweb, Valer1e, audrasjb, pento.
Fixes #41000 .
Built from https://develop.svn.wordpress.org/trunk@44455
git-svn-id: http://core.svn.wordpress.org/trunk@44286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 04:30:50 +00:00
1b389ea861
Permalinks: Add a `pre_wp_unique_post_slug` filter.
...
Returning a non-`null` value on this fillter will cause `wp_unique_post_slug()` to return early with that value, skipping potentially expensive database queries on some sites.
Props coffee2code, javorszky, iCaleb.
Fixes #21112 .
Built from https://develop.svn.wordpress.org/trunk@44454
git-svn-id: http://core.svn.wordpress.org/trunk@44285 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:47:49 +00:00
0049b17f8a
Bootstrap: Allow `WP_DEBUG_LOG` to override the `debug.log` location.
...
Setting `WP_DEBUG_LOG` to a file path will now cause the debug log to be written to that file, rather than the default `WP_CONTENT_DIR/debug.log`.
Props SergeyBiryukov, ethitter, sebastian.pisula, nacin.
Fixes #18391 .
Built from https://develop.svn.wordpress.org/trunk@44453
git-svn-id: http://core.svn.wordpress.org/trunk@44284 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:42:48 +00:00
5950f27205
Query: Standardize treatment of 'orderby' values `post__in`, `post_parent__in`, and `post_name__in`.
...
Ordering by `post__in` was introduced in [21776], but the code assumed that
`post__in` would be a comma-separated string listing post IDs. When an array
of post IDs was passed to the `post__in` query var, 'orderby=post__in' was
not respected. This changeset changes this behavior by handling
'orderby=post__in' in the same way as most other values of 'orderby',
which ensures that arrays as well as strings can be properly parsed.
The same treatment is given to the similar `post_name__in` and
`post_parent__in` options of 'orderby', so that most query generation for
orderby clauses happens in the same place, instead of in special cases.
A slight change in the resulting SQL (related to the whitespace around
parentheses and commas) necessitates a change to an existing REST API test
that does a string comparison against the SQL query.
Props mgibbs189, kelvink.
Fixes #38034 .
Built from https://develop.svn.wordpress.org/trunk@44452
git-svn-id: http://core.svn.wordpress.org/trunk@44283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:33:49 +00:00
7f67e235a7
Install/Upgrade: Link to HelpHub instead of the Codex.
...
WordPress version links in the Codex (eg, https://codex.wordpress.org/Version_5.0 ) are redirected to their HelpHub equivalent.
Rather than relying on the redirect, Core and link directly to HelpHub.
Props swissspidy.
Fixes #45574 .
Built from https://develop.svn.wordpress.org/trunk@44451
git-svn-id: http://core.svn.wordpress.org/trunk@44282 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:29:48 +00:00
308a544039
Docs: Update `@since` for `populate_site_meta()`.
...
Fixes #44896 .
Built from https://develop.svn.wordpress.org/trunk@44450
git-svn-id: http://core.svn.wordpress.org/trunk@44281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:18:50 +00:00
1d25a903c4
Docs: Update `@since` for `populate_network_meta()`.
...
Fixes #44895 .
Built from https://develop.svn.wordpress.org/trunk@44449
git-svn-id: http://core.svn.wordpress.org/trunk@44280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:17:49 +00:00
eee2e5f1d8
Docs: Update `@since` for the optional `$options` parameter to `populate_options()`.
...
Fixes #44893 .
Built from https://develop.svn.wordpress.org/trunk@44448
git-svn-id: http://core.svn.wordpress.org/trunk@44279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:15:49 +00:00
170b03ab19
Docs: Update `@since` for `is_taxonomy_viewable()`.
...
Props andizer.
Fixes #44466 .
Built from https://develop.svn.wordpress.org/trunk@44447
git-svn-id: http://core.svn.wordpress.org/trunk@44278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 03:11:50 +00:00
d5b7863fbf
REST API: Remove `permalink_structure` from the REST API settings endpoint.
...
This was ultimately fixed in #45017 , so is redunant.
Reverts [42142,42359,42540].
See #41014 .
Built from https://develop.svn.wordpress.org/trunk@44446
git-svn-id: http://core.svn.wordpress.org/trunk@44277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-08 02:51:50 +00:00
3068e8d4e2
Upload: Don't run some upload tests on multisite.
...
This moves several unit tests added in [44438] so they aren't run during multisite tests.
See #45615 .
Built from https://develop.svn.wordpress.org/trunk@44442
git-svn-id: http://core.svn.wordpress.org/trunk@44273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 21:42:50 +00:00
4a80373bdf
PHPCS: Fix formatting issues.
...
Fixes formatting issues introduced in [44438].
See #45615 .
Built from https://develop.svn.wordpress.org/trunk@44441
git-svn-id: http://core.svn.wordpress.org/trunk@44272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 21:09:49 +00:00
7bd6e079f5
Upload: Add test files for phpunit.
...
This is a follow up to [44438], which missed adding the test files.
See #45615 .
Built from https://develop.svn.wordpress.org/trunk@44439
git-svn-id: http://core.svn.wordpress.org/trunk@44270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 20:53:51 +00:00
ac1ff02815
Upload: Fix upload failures of common text file types.
...
This adds some special case handling in 'wp_check_filetype_and_ext()' that prevents some common file types from being blocked based on mismatched MIME checks, which were made more strict in WordPress 5.0.1.
Props Kloon, birgire, tellyworth, joemcgill.
See #45615 .
Built from https://develop.svn.wordpress.org/trunk@44438
git-svn-id: http://core.svn.wordpress.org/trunk@44269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 20:48:51 +00:00
f082806afa
Block Editor: Display notice to the user when JavaScript is disabled.
...
Currently, when viewing the block editor with JavaScript disabled, the user sees a blank admin page with the admin menu sidebar. This adds an admin notice informing the user that JavaScript is required for the new block editor.
Props mkaz, pento, azaozz, ocean90, desrosj.
Fixes #45453 .
Built from https://develop.svn.wordpress.org/trunk@44437
git-svn-id: http://core.svn.wordpress.org/trunk@44268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 20:40:50 +00:00
8917b0e89f
Default Themes: Bump the version numbers and release dates.
...
Update the theme versions and release dates for the default themes, in time for WordPress 5.0.3.
The POT file for Twenty Eleven has also been updated.
Props laurelfulford.
Fixes #45792 .
Built from https://develop.svn.wordpress.org/trunk@44435
git-svn-id: http://core.svn.wordpress.org/trunk@44266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 18:58:50 +00:00
1a622a8b81
Twenty Twelve: Correct `padding` rule precedence for Quote block.
...
Props superpoincare.
Fixes #45794 .
Built from https://develop.svn.wordpress.org/trunk@44432
git-svn-id: http://core.svn.wordpress.org/trunk@44263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 18:09:54 +00:00
0a66ea8149
Formatting: Remove unused global import for `$wp_filter` in `_restore_wpautop_hook()`.
...
See #45290 .
Built from https://develop.svn.wordpress.org/trunk@44431
git-svn-id: http://core.svn.wordpress.org/trunk@44262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 16:59:52 +00:00
6b2494ba10
Plugins: Use newer "Updating PHP" page URL in the notice displayed when a plugin requires a higher PHP version.
...
Props afragen.
Fixes #43986 . See #45686 .
Built from https://develop.svn.wordpress.org/trunk@44420
git-svn-id: http://core.svn.wordpress.org/trunk@44250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 15:35:49 +00:00
86e5a051db
I18n: Expose JSON translation file paths in `load_script_textdomain()`.
...
Removes `file_exist()` checks before calling `load_script_translations()` to let the determined paths be passed to `load_script_translations()` which provides its own file check and the possibility to filter the path.
Props swissspidy, johnbillion, ocean90.
See #45769 .
Built from https://develop.svn.wordpress.org/trunk@44418
git-svn-id: http://core.svn.wordpress.org/trunk@44248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 13:59:51 +00:00
9ac8b5b4f5
Importers: Use correct l10n variable in `wp.updates.installImporterError` and filesystem credentials dialog.
...
Missed in [40034].
Props afercia, abhayvishwakarma.
Fixes #45765 .
Built from https://develop.svn.wordpress.org/trunk@44417
git-svn-id: http://core.svn.wordpress.org/trunk@44247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 13:49:49 +00:00
efc9cbd553
Accessibility: Themes: use `aria-current` for the `Walker_Page` current link.
...
See [42808] for `Walker_Nav_Menu`.
The `aria-current` attribute is a simple, effective way to help assistive
technologies users orientate themselves within a list of items. Continues the
introduction in core of `aria-current` after [42440], [41683], [41359], and [41371].
Props chetan200891, wpzinc.
Fixes #43522 .
Built from https://develop.svn.wordpress.org/trunk@44416
git-svn-id: http://core.svn.wordpress.org/trunk@44246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 13:36:50 +00:00
49452cd73d
Pages, Post Types: Escape CSS classes in `Walker_Page::start_el()` after the `page_css_class` filter runs.
...
Don't add an empty `class` attribute if there are no classes, for consistency with `Walker_Nav_Menu::start_el()`.
Props abhijitrakas, mukesh27.
Fixes #44880 .
Built from https://develop.svn.wordpress.org/trunk@44415
git-svn-id: http://core.svn.wordpress.org/trunk@44245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 12:55:38 +00:00
d3e0f97705
Taxonomy: Escape CSS classes in `Walker_Category::start_el()` after the `category_css_class` filter runs.
...
Don't add an empty `class` attribute if there are no classes, for consistency with `Walker_Nav_Menu::start_el()`.
Props abhijitrakas, mukesh27.
See #44880 .
Built from https://develop.svn.wordpress.org/trunk@44414
git-svn-id: http://core.svn.wordpress.org/trunk@44244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 12:54:48 +00:00
a94d70b811
Taxonomy: Escape `feed_image` argument in `Walker_Category::start_el()`.
...
See [11838] for the instance in `wp_list_authors()`.
Props abhijitrakas.
See #44880 .
Built from https://develop.svn.wordpress.org/trunk@44413
git-svn-id: http://core.svn.wordpress.org/trunk@44243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 12:48:51 +00:00
9c08686353
Docs: Fix typo in the description of `status` parameter of `WP_Comment_Query`.
...
See #41338 .
Built from https://develop.svn.wordpress.org/trunk@44412
git-svn-id: http://core.svn.wordpress.org/trunk@44242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 11:38:50 +00:00
34fee908e3
Accessibility: Update since annotation for wp_link_pages().
...
Updates the since annotation for the `aria_current` argument introduced in #42440 .
Fixes #41859 .
Built from https://develop.svn.wordpress.org/trunk@44411
git-svn-id: http://core.svn.wordpress.org/trunk@44241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 08:02:48 +00:00
f21b9db825
Docs: Correct `@since` tag for `users_pre_query` filter added in [44373].
...
Revert unintended change to the `@since` tag for the `WP_User_Query` instance added to `found_users_query` filter in [43660].
See #44169 , #43679 .
Built from https://develop.svn.wordpress.org/trunk@44410
git-svn-id: http://core.svn.wordpress.org/trunk@44240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-07 07:56:50 +00:00
5781515e7d
Twenty Seventeen: Update `since` and `see` annotations for `twentyseventeen_unique_id()`.
...
Previously introduced in [43659].
See #44883 .
Built from https://develop.svn.wordpress.org/trunk@44408
git-svn-id: http://core.svn.wordpress.org/trunk@44238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-06 20:15:49 +00:00
33a71f04e2
General: Update `since` annotation for `wp_unique_id()`.
...
In [43658], `wp_unique_id()` was introduced. This updates the `since` annotation to be accurate.
See #44883 .
Built from https://develop.svn.wordpress.org/trunk@44406
git-svn-id: http://core.svn.wordpress.org/trunk@44236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-06 19:52:51 +00:00
49351e0578
I18N/Script Loader: Support text domains other than "messages".
...
The inline JavaScript added by `WP_Scripts::print_translations()` should check whether `locale_data.$text_domain` exists and fall back to `locale_data.messages` otherwise.
Props swissspidy.
See #45441 .
Built from https://develop.svn.wordpress.org/trunk@44403
git-svn-id: http://core.svn.wordpress.org/trunk@44233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-06 16:23:49 +00:00
desrosj
Gary Pendergast
Felix Arntz
Boone Gorges
Joe McGill
Sergey Biryukov
Dominik Schilling
Andrea Fercia