Andrew Nacin
12c4b9bae9
Do not unslash variables reset by wp_reset_vars(). Remove variables that have never been used in plugin-editor.php. see #21767 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-15 02:01:36 +00:00
Bot (Assets)
123ef6ad57
Compress scripts/styles: 3.6-alpha-23417.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:58:42 +00:00
Mark Jaquith
88f17f77c4
Refactor the Customizer accordion so that it can be used in other locations.
...
fixes #23449 . props lessbloat, aaroncampbell
git-svn-id: http://core.svn.wordpress.org/trunk@23417 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:58:04 +00:00
Ryan Boren
cc5ed3a485
Change all core API to expect unslashed rather than slashed arguments.
...
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.
Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.
Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.
Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.
Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.
Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.
Plugins should use wp_unslash() on data being passed to core API.
Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.
Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.
Remove many no longer necessary calls to $wpdb->escape() and esc_sql().
In wp_get_referer() and wp_get_original_referer(), return unslashed data.
Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.
Switch several queries over to prepare().
Expect something to break.
Props alexkingorg
see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Peter Westwood
ae974b8495
Revisions: Allow a plugin to force us to skip the don't save this revision because it hasn't changed code if it knows better.
...
See #7392 and #9843 . Also cleans up the whitespace.
git-svn-id: http://core.svn.wordpress.org/trunk@23415 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 16:45:43 +00:00
Peter Westwood
716d48e0cd
Revisions: Before saving a new post revision make sure that something has changed in the fields that we are revisioning.
...
Fixes : #7392 and #9843 props adamsilverstein.
git-svn-id: http://core.svn.wordpress.org/trunk@23414 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 11:36:32 +00:00
Sergey Biryukov
7a77f47f55
Use correct escaping function. fixes #23334 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 05:52:23 +00:00
Sergey Biryukov
08269aa6b0
Remove unused error string. props pavelevap. fixes #22107 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 05:36:28 +00:00
Sergey Biryukov
4e46d0045c
Use correct escaping function. props jkudish. fixes #20771 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 05:12:23 +00:00
Sergey Biryukov
3d3a2a7692
Return from image_downsize() earlier if a custom resize function is used. props anatolbroder. fixes #23392 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 04:30:55 +00:00
Helen Hou-Sandí
767f34de86
Restore the following:
...
* Box shadow for screen options/help tabs focus state.
* Text shadow on the about screen badge to match the text shadow in the graphic itself.
* Border for credits screen gravatars, in place of the previous box shadow.
props nacin. see #23415 .
git-svn-id: http://core.svn.wordpress.org/trunk@23409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 23:50:55 +00:00
Bot (Assets)
b05107c526
Compress scripts/styles: 3.6-alpha-23408.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 22:58:44 +00:00
Helen Hou-Sandí
32562f25e9
Begin simplifying some of the visual elements in the admin, starting with gradients. White space purposefully not currently altered. props lessbloat, melchoyce, aaroncampbell, sabreuse. see #23415 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 22:43:48 +00:00
Bot (Translations)
df360cef6b
POT, generated from r23404
...
git-svn-id: http://core.svn.wordpress.org/trunk@23405 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 22:19:39 +00:00
Peter Westwood
f8cc93b62e
Revisions: Pass the whole revision being filtered along with context about which side it is to the _wp_post_revision_field_$field filters.
...
Fixes #19932 props pollett, ethitter.
git-svn-id: http://core.svn.wordpress.org/trunk@23404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-13 21:42:03 +00:00
Bot (Assets)
fbfa656d6b
Compress scripts/styles: 3.6-alpha-23403. TinyMCE updated.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23403 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-12 22:58:43 +00:00
Andrew Ozz
19f2608e04
TinyMCE: include cd84a63d4a
to fix backspace and line breaks issues in WebKit, see #23337
...
git-svn-id: http://core.svn.wordpress.org/trunk@23402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-12 02:04:09 +00:00
Ryan Boren
353ef064ea
Use microtime() instead of incrementors for last_changed to to avoid race conditions with cache evictions.
...
Props westi
fixes #23448
git-svn-id: http://core.svn.wordpress.org/trunk@23401 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-11 18:08:14 +00:00
Bot (Assets)
7d2eeb5aed
Compress scripts/styles: 3.6-alpha-23400.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 22:58:42 +00:00
Mark Jaquith
c2f837a3b4
Allow Backround Image's "select a file" link to be activated by pressing return on the keyboard.
...
props adamsilverstein. fixes #22606
git-svn-id: http://core.svn.wordpress.org/trunk@23399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:51:19 +00:00
Mark Jaquith
6953fe2a25
Introduce wp_remove_object_terms() and wp_add_object_terms(). No more fetch-alter-update nonsense. Use wp_remove_object_terms() in a few places internally.
...
props simonwheatley, scribu, ericmann, maxcutler. fixes #15475
git-svn-id: http://core.svn.wordpress.org/trunk@23398 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:45:34 +00:00
Mark Jaquith
00dbfdf89e
Document the mysterious seventh parameter of add_meta_box().
...
props wonderboymusic, markjaquith. fixes #17515
git-svn-id: http://core.svn.wordpress.org/trunk@23397 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:37:34 +00:00
Mark Jaquith
ddd1b94184
Link post formats in posts list table. Use a dash for standard, like we do for absence of tags. see #16047 Next: use icons, not text descriptions.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:34:51 +00:00
Mark Jaquith
dab5a6ef7d
Fix some tabbing issues on the post editing screen. Add Media no longer skipped when going backwards from content. Save Draft no longer skipped when going forwards from content.
...
props adamsilverstein. fixes #23195 and #22933
git-svn-id: http://core.svn.wordpress.org/trunk@23395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 18:30:09 +00:00
Helen Hou-Sandí
1c816c795b
Open external links to plugin homepages, plugin author homepages, and theme author homepages in a new window/tab. props SergeyBiryukov. fixes #20839 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:20:01 +00:00
Mark Jaquith
da5c7a7c62
"Lookup" is a noun. "Look up" is the verb form. If you doubt me, you should have lookuped in a dictionary.
...
props johnbillion, SergeyBiryukov. fixes #22386
git-svn-id: http://core.svn.wordpress.org/trunk@23393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:19:04 +00:00
Mark Jaquith
2fb915f860
Display post formats in the posts list table.
...
props nacin, garyc40, DrewAPicture, wonderboymusic, aaroncampbell.
fixes #16047
git-svn-id: http://core.svn.wordpress.org/trunk@23392 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 16:10:05 +00:00
Andrew Nacin
b40f37808b
Add underscore and backbone to the do-not-deregister list of scripts.
...
props adamsilverstein.
see [23378]. see #22896 .
git-svn-id: http://core.svn.wordpress.org/trunk@23391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 05:11:27 +00:00
Mark Jaquith
3f6ffc4c76
Revert [23375] until we can get Media fixed to work with newer versions of Backbone. see #23262
...
git-svn-id: http://core.svn.wordpress.org/trunk@23390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-08 03:15:22 +00:00
Andrew Ozz
6985523d00
Heartbeat API: fix error in IE < 9, props SergeyBiryukov, don't attempt to bind events to cross-domain iframes, see #23216
...
git-svn-id: http://core.svn.wordpress.org/trunk@23389 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-06 07:10:04 +00:00
Sergey Biryukov
5f05d09dc2
Use a human-readable constant in wp_set_auth_cookie(). fixes #23372 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-06 03:44:43 +00:00
Sergey Biryukov
c569c15b6d
Correct the documentation for _publish_post_hook(). Remove unused global declaration. props roulandf. fixes #23376 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-05 15:45:37 +00:00
Bot (Assets)
b1adfbb54a
Compress scripts/styles: 3.6-alpha-23386.
...
git-svn-id: http://core.svn.wordpress.org/trunk@23386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-04 14:38:03 +00:00
Ryan Boren
0d54972fec
In wp_get_archives(), cache queries to individual cache buckets instead of storing them in one cached array. Use incrementor style passive cache invalidation.
...
fixes #23206
see #23173
git-svn-id: http://core.svn.wordpress.org/trunk@23385 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-04 13:54:15 +00:00
Ryan Boren
0f80568a7e
Use incrementors for cache invalidation in get_terms().
...
fixes #23326
see #23173
git-svn-id: http://core.svn.wordpress.org/trunk@23384 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-04 13:48:46 +00:00
Mark Jaquith
fe2dd7a2a3
Update Underscore to version 1.4.4. see #23262
...
git-svn-id: http://core.svn.wordpress.org/trunk@23383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-04 06:40:21 +00:00
Andrew Ozz
6c41e93fec
Heartbeat API: throttle down when the window looses focus or when the user is inactive, always send 'screen_id', change the interval settings to 'fast' (5sec), 'standard' (15sec) and 'slow' (60sec), the interval can be changed from PHP, see #23216
...
git-svn-id: http://core.svn.wordpress.org/trunk@23382 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-03 07:03:27 +00:00
Helen Hou-Sandí
f452214f24
Maintain theme screenshot aspect ratio on the update screen. props cochran. fixes #23164 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23381 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 17:02:01 +00:00
Andrew Nacin
55ba72f46e
Confirm a user exists before deleting them in wp_delete_user() and wpmu_delete_user(). props scribu, fixes #23067 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23380 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 04:41:02 +00:00
Sergey Biryukov
574eb39978
Mark the string for translation. see #22896 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23379 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 03:42:10 +00:00
Andrew Nacin
d2338eff1e
Do not allow accidental or negligent deregistering of critical scripts in the admin. (Defined for now as jQuery and jQuery UI.) Show minimal remorse if the correct hook is used. see #22896 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 03:01:20 +00:00
Andrew Nacin
dcb573103c
Stop recommending the init hook in the _doing_it_wrong() message for too-early scripts and styles. Instead, recommend the three _enqueue_scripts hooks. If they're noticing they are doing it wrong, let's push them to 100% correct, not partly correct.
...
see #22896 .
git-svn-id: http://core.svn.wordpress.org/trunk@23377 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 02:42:09 +00:00
Andrew Nacin
cbabdafbed
Update to Services_JSON 1.0.3. props bpetty. fixes #21568 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 02:09:01 +00:00
Andrew Nacin
60a4d36571
Update Backbone.js to 0.9.10. props aaronholbrook, fixes #23262 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 02:02:53 +00:00
Sergey Biryukov
2967871d34
Return WP_Error from wp_crop_image() if saving has failed. props macbrink. fixes #23325 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 02:01:59 +00:00
Andrew Nacin
2cb5fccd5c
Ensure we have a charset before calling mb_internal_encoding(), avoiding an unnecessary (if suppressed) warning. props dfavor. fixes #23093 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23373 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 02:01:29 +00:00
Andrew Nacin
91e3f2b866
Clean up rendering of the title column in the posts list table. Simplify branching. Use get_userdata() rather than get_user_by( 'id' ). Change string to '%s is currently editing'. see #23312 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@23372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:54:06 +00:00
Andrew Ozz
0674bbfa8a
Posts screen: show when a post is "locked", hide the checkbox, Quick Edit and Trash links, props dh-shredder, see #23312
...
git-svn-id: http://core.svn.wordpress.org/trunk@23371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:31:06 +00:00
Andrew Ozz
3911ebded5
New icons: make the .icon32 container larger to prevent clipping, see #23333
...
git-svn-id: http://core.svn.wordpress.org/trunk@23370 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 01:01:35 +00:00
Andrew Ozz
855e0d8f3a
New icons take one, props empireoflight, see #23333
...
git-svn-id: http://core.svn.wordpress.org/trunk@23369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-02 00:22:40 +00:00