Commit Graph

19540 Commits

Author SHA1 Message Date
Scott Taylor f4cc7b3de8 Feeds: add `CEST` to `$timezone` in `SimplePie_Parse_Date`.
Props swissspidy.
Fixes #32749.

Built from https://develop.svn.wordpress.org/trunk@35283


git-svn-id: http://core.svn.wordpress.org/trunk@35249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:57:24 +00:00
Scott Taylor b0561ed6e4 Dashboard: use the `create_posts` cap on the post type object when determining if the Quick Press widget can be displayed.
Props jim912, ocean90, chriscct7.
Fixes #25681.

Built from https://develop.svn.wordpress.org/trunk@35282


git-svn-id: http://core.svn.wordpress.org/trunk@35248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:49:24 +00:00
Scott Taylor f89b90a1c9 Theme Installer: toggle `iframe-ready` on the overlay to control the spinner animated GIF and high CPU usage.
Props afercia, adamsilverstein.
Fixes #33322.

Built from https://develop.svn.wordpress.org/trunk@35281


git-svn-id: http://core.svn.wordpress.org/trunk@35247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:36:25 +00:00
Scott Taylor 85a6189ad8 Users: when calling `wp_insert_user()` with an valid user ID, return `WP_Error` instead of arbitrarily updating user meta.
Adds unit test.

Props swissspidy, bilalcoder.
Fixes #28004.

Built from https://develop.svn.wordpress.org/trunk@35280


git-svn-id: http://core.svn.wordpress.org/trunk@35246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:28:24 +00:00
Scott Taylor 5d63788d9a XML-RPC: after [35095], change the name of the `xmlrpc_memory_limit` filter to `xmlrpc_chunk_parsing_size`.
Props ankit.gade.
Fixes #29957.

Built from https://develop.svn.wordpress.org/trunk@35279


git-svn-id: http://core.svn.wordpress.org/trunk@35245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 05:19:25 +00:00
Scott Taylor c5b6202dfa Widgets: revert [34376] and [34386] as pertains to the Categories widget supporting custom taxonomies.
Punting on 4th down.

See #21165.

Built from https://develop.svn.wordpress.org/trunk@35278


git-svn-id: http://core.svn.wordpress.org/trunk@35244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 04:57:25 +00:00
Scott Taylor 62d8b8c5bc List Tables: revert the majority of [34467]. This was almost universally abhorred (the JS that disabled the bulk dropdowns).
See #31634.

Built from https://develop.svn.wordpress.org/trunk@35277


git-svn-id: http://core.svn.wordpress.org/trunk@35243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 04:29:24 +00:00
Scott Taylor 89d1eb1e00 Formatting: when making unique filenames in `wp_unique_filename()` by adding an incrementing number, prefix it with a dash to disambiguate from files that end in numbers.
Updates unit tests.

Props mikejolley, tyxla.
Fixes #21453.

Built from https://develop.svn.wordpress.org/trunk@35276


git-svn-id: http://core.svn.wordpress.org/trunk@35242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 04:05:25 +00:00
Scott Taylor 4f16590e8e Customizer: when available, show the `description` when rendering the `dropdown-pages` Control.
Props downstairsdev, MikeHansenMe, _smartik_.
Fixes #31540.

Built from https://develop.svn.wordpress.org/trunk@35275


git-svn-id: http://core.svn.wordpress.org/trunk@35241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-20 03:48:26 +00:00
Drew Jaynes a92d4f6fcb Docs: Update the default scheme for `get_rest_url()` from 'json' to 'rest'.
Also adds 'rest' to the documented list of schemes for `home_url()`, `get_home_url()`, `set_url_scheme()`, and the `home_url` and `set_url_scheme` hooks.

Props rachelbaker.
Fixes #34300.

Built from https://develop.svn.wordpress.org/trunk@35274


git-svn-id: http://core.svn.wordpress.org/trunk@35240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 22:39:25 +00:00
Andrea Fercia e074209a3d Accessibility: Improve the headings hierarchy in the Add Themes screen.
Fixes #33819.
Built from https://develop.svn.wordpress.org/trunk@35273


git-svn-id: http://core.svn.wordpress.org/trunk@35239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 22:04:25 +00:00
Weston Ruter a89294dc49 Widgets: Modify unit test assertion to be compatible with `widget_nav_menu` option being filtered by plugin to return `ArrayIterator`.
Modifies assertion added in [35100].

See #26876.
See #32474.

Built from https://develop.svn.wordpress.org/trunk@35272


git-svn-id: http://core.svn.wordpress.org/trunk@35238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 21:27:26 +00:00
Drew Jaynes 9f0f213d5e Docs: Add a missing file header for wp-admin/includes/class-wp-site-icon.php.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35271


git-svn-id: http://core.svn.wordpress.org/trunk@35237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 20:09:26 +00:00
Drew Jaynes d5a15475d2 Tests: Add some more test coverage for `get_term_field()`.
See #33968.

Built from https://develop.svn.wordpress.org/trunk@35270


git-svn-id: http://core.svn.wordpress.org/trunk@35236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 03:29:24 +00:00
Boone Gorges 9cc7660c53 Don't store `data` as a property on `WP_Term` objects.
`wp_ajax_add_term()` fetches a term using `get_term()`, and passes the term to
`WP_Ajax_Response`, which expects each of the term's properties to be scalar.
Having `$data` as a `stdClass` (meant to mimic `WP_User::data`, populated by
a `get_row()` database query) violated this expectation, causing fatal string
conversion errors. As a workaround, `$term->data` is converted so that it is
no longer an actual property of the term object, but is assembled only when
requested in the magic `__get()` method.

Fixes #34348.
Built from https://develop.svn.wordpress.org/trunk@35269


git-svn-id: http://core.svn.wordpress.org/trunk@35235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 03:12:24 +00:00
Boone Gorges 2543ffbbae Bust object term cache in `wp_remove_object_terms()`.
Props tszming.
Fixes #34338.
Built from https://develop.svn.wordpress.org/trunk@35268


git-svn-id: http://core.svn.wordpress.org/trunk@35234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 01:53:24 +00:00
Dion Hulse 85258bb914 In `insert_with_markers()` restore the 4.3 behaviour of creating the file if it doesn't exist.
This change also makes it bail early (without writing) if the markers content is the same as the existing, and uses `ftell()` rather than `$bytes` for the location to truncate the file to - based on the file pointer being at the end of the written stream.

Props willmot tigertech kevinatelement
See #31767

Built from https://develop.svn.wordpress.org/trunk@35267


git-svn-id: http://core.svn.wordpress.org/trunk@35233 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-19 00:53:24 +00:00
Drew Jaynes fd9bcf111d Docs: Fix a typo in the `$blog_id` parameter name in the `rest_url` filter doc.
Props rachelbaker.
Fixes #34351.

Built from https://develop.svn.wordpress.org/trunk@35266


git-svn-id: http://core.svn.wordpress.org/trunk@35232 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 23:12:25 +00:00
Andrea Fercia 579246ab4a Multisite: Improve the Admin Bar parent menu items color on hover and focus.
Props Nikschavan for the initial patch.
Fixes #34040.
Built from https://develop.svn.wordpress.org/trunk@35265


git-svn-id: http://core.svn.wordpress.org/trunk@35231 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 16:22:24 +00:00
Drew Jaynes 2e11f8cc16 Taxonomy: Improve deprecated argument strings for the 'link' type in `get_categories()` and `wp_dropdown_categories()`.
Props swissspidy, gagan0123.
Fixes #34318.

Built from https://develop.svn.wordpress.org/trunk@35264


git-svn-id: http://core.svn.wordpress.org/trunk@35230 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 15:35:24 +00:00
Drew Jaynes b37bb95aad Administration: Introduce the `manage_posts_extra_tablenav` action, which fires inside the tablenav for the posts list table, and just outside the "actions" container.
Props hlashbrooke, wonderboymusic.
Fixes #30341.

Built from https://develop.svn.wordpress.org/trunk@35263


git-svn-id: http://core.svn.wordpress.org/trunk@35229 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 14:56:23 +00:00
Drew Jaynes 0aaa2900eb Docs: Add a version to the file header for wp-admin/includes/comment.php.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35262


git-svn-id: http://core.svn.wordpress.org/trunk@35228 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 14:34:25 +00:00
Ella Iseulde Van Dorpe 9845e08340 TinyMCE: Drag and drop link with image
Make sure images don't loose their link after drag and drop.

Fixes #28272.

Built from https://develop.svn.wordpress.org/trunk@35261


git-svn-id: http://core.svn.wordpress.org/trunk@35227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 11:05:23 +00:00
John Blackbourn 532e1fb856 Some cleanup that was missed in [35259].
See #33728, #24853

Built from https://develop.svn.wordpress.org/trunk@35260


git-svn-id: http://core.svn.wordpress.org/trunk@35226 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 06:26:24 +00:00
John Blackbourn 46a191dfcc Some rewrite endpoint tests in preparation for new endpoint masks. More to come.
See #33728, #24853

Built from https://develop.svn.wordpress.org/trunk@35259


git-svn-id: http://core.svn.wordpress.org/trunk@35225 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 06:24:24 +00:00
John Blackbourn 9564ccf373 Preserve the public and private query var properties on the global `WP` instance when using `WP_UnitTestCase::go_to()`. These properties apply to the application state, not the current request.
See #34346

Built from https://develop.svn.wordpress.org/trunk@35258


git-svn-id: http://core.svn.wordpress.org/trunk@35224 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 05:01:24 +00:00
John Blackbourn 53f5767ee1 Add `is_embed()` to `WP_UnitTestCase::assertQueryTrue()` and update the relevant embed tests.
See #32522

Built from https://develop.svn.wordpress.org/trunk@35257


git-svn-id: http://core.svn.wordpress.org/trunk@35223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 04:51:25 +00:00
John Blackbourn c01a64ad31 Move the `test_is_home_should_be_false_when_visiting_custom_endpoint_without_a_registered_query_var_and_page_on_front_is_set()` test into a more appropriate place.
See #25143

Built from https://develop.svn.wordpress.org/trunk@35256


git-svn-id: http://core.svn.wordpress.org/trunk@35222 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 01:35:24 +00:00
John Blackbourn 0b845bed03 Correct a test after r35253.
See #34272

Built from https://develop.svn.wordpress.org/trunk@35255


git-svn-id: http://core.svn.wordpress.org/trunk@35221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 00:56:24 +00:00
John Blackbourn 9da3b964fc Remove an IDE-specific rule in `.gitignore`. These should be managed in the user's `~/.gitignore_global` file.
Fixes #34345

Built from https://develop.svn.wordpress.org/trunk@35254


git-svn-id: http://core.svn.wordpress.org/trunk@35220 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-18 00:16:24 +00:00
Sergey Biryukov d76d340036 Embeds: After [35235], replace some missed `oembed` references with `embed`.
Props peterwilsoncc.
Fixes #34272.
Built from https://develop.svn.wordpress.org/trunk@35253


git-svn-id: http://core.svn.wordpress.org/trunk@35219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 23:26:47 +00:00
John Blackbourn 5576cd3978 Introduce `map_deep()`, a utility function that recursively maps a callable function to every item in an array or object. Works like `array_walk_recursive()` but works with objects too.
Updates `rawurlencode_deep()`, `urlencode_deep()`, and `stripslashes_deep()` to use `map_deep()`. Introduces `urldecode_deep()` for completeness.

Props wpmuguru, nbachiyski, boonebgorges, MikeHansenMe, chriscct7, realloc, johnbillion
Fixes #22300

Built from https://develop.svn.wordpress.org/trunk@35252


git-svn-id: http://core.svn.wordpress.org/trunk@35218 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 23:26:24 +00:00
Weston Ruter f676fdcee3 Customizer: Fix `margin-top` calculation for Themes section.
Ensure that the Themes section calculates its `margin-top` as a panel, since the section behaves as one. Fixes regression caused by [35231].

See #33567.


Built from https://develop.svn.wordpress.org/trunk@35251


git-svn-id: http://core.svn.wordpress.org/trunk@35217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 22:41:25 +00:00
Scott Taylor 443ce28304 Media: in `wp_get_attachment_image_sizes()`, ensure that `$img_width` exists when the image does not.
Props kraftbj.
See #33641.


Built from https://develop.svn.wordpress.org/trunk@35250


git-svn-id: http://core.svn.wordpress.org/trunk@35216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 22:12:24 +00:00
Scott Taylor c7b0db99a6 Unit Tests: better fixtures for `Tests_Meta_Slashes` and `Tests_WP_Customize_Section`.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35249


git-svn-id: http://core.svn.wordpress.org/trunk@35215 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 21:29:24 +00:00
Scott Taylor 11d1e8af8b Unit Tests: better fixtures for `Tests_User_WpSetCurrentUser`.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35248


git-svn-id: http://core.svn.wordpress.org/trunk@35214 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 21:19:24 +00:00
Scott Taylor 32bb609d88 Unit Tests: better fixtures for `Tests_User`.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35247


git-svn-id: http://core.svn.wordpress.org/trunk@35213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 21:15:25 +00:00
Scott Taylor a9134691d4 Unit Tests: better fixtures for `Tests_AdminBar`. Don't force-delete some posts: some filter callbacks are no-ops on Multisite if the post is vanquished.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35246


git-svn-id: http://core.svn.wordpress.org/trunk@35212 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 20:49:24 +00:00
Scott Taylor 4204afdd40 Unit Tests: better fixtures for `Tests_Admin_Includes_Post`.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35245


git-svn-id: http://core.svn.wordpress.org/trunk@35211 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 19:48:23 +00:00
Scott Taylor d54f567862 Unit Tests: `WP_UnitTest_Generator_Sequence` needs a static incrementer - otherwise, it assumes every test class is a reset, which it no longer is (it is now static).
While we're at it, remove unnecessary `tearDown()` code.

See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35244


git-svn-id: http://core.svn.wordpress.org/trunk@35210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 19:25:24 +00:00
Scott Taylor 7d7c85b83d Unit Tests: after [35242], declare some missing instance props on individual test classes.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35243


git-svn-id: http://core.svn.wordpress.org/trunk@35209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 18:30:24 +00:00
Scott Taylor 7f8dca02b7 Unit Tests: after [35225], make `factory` a method/getter on `WP_UnitTestCase` and add magic methods for BC for every plugin that is extending `WP_UnitTestCase` and accessing the `$factory` instance prop.
Props nerrad, wonderboymusic.
See #30017, #33968.


Built from https://develop.svn.wordpress.org/trunk@35242


git-svn-id: http://core.svn.wordpress.org/trunk@35208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 18:03:25 +00:00
Drew Jaynes 8a386cb24f Docs: Add missing file headers to the list table classes and adjust class DocBlocks accordingly.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35241


git-svn-id: http://core.svn.wordpress.org/trunk@35207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 15:13:25 +00:00
Drew Jaynes 767d091c74 Docs: Improve the hook doc for the `get_post_status` filter, introduced in [35233].
Also adds a missing parameter description for `$post`.

See #23458. See #32246.

Built from https://develop.svn.wordpress.org/trunk@35240


git-svn-id: http://core.svn.wordpress.org/trunk@35206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 14:24:25 +00:00
Ella Iseulde Van Dorpe 08f71faac3 JSHint after [35238]
Built from https://develop.svn.wordpress.org/trunk@35239


git-svn-id: http://core.svn.wordpress.org/trunk@35205 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 07:11:24 +00:00
Ella Iseulde Van Dorpe 47e364de42 Admin: fix repositioning notices
Fixes #34294.
Props afercia.

Built from https://develop.svn.wordpress.org/trunk@35238


git-svn-id: http://core.svn.wordpress.org/trunk@35204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 07:04:26 +00:00
Drew Jaynes 10d94ea673 Docs: Add a missing file header for wp-admin/includes/class-wp-list-table.php.
See #33701.

Built from https://develop.svn.wordpress.org/trunk@35237


git-svn-id: http://core.svn.wordpress.org/trunk@35203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 06:07:24 +00:00
Weston Ruter c7a951194d Customizer: Add unit test for `WP_Customize_Widgets::is_panel_active()`.
See #33052.

Built from https://develop.svn.wordpress.org/trunk@35236


git-svn-id: http://core.svn.wordpress.org/trunk@35202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 04:44:25 +00:00
Sergey Biryukov a908d2d4b1 Embeds: Rename files, functions, and hooks added in [34903] to make it more clear what is oEmbed-specific and what isn't.
See https://core.trac.wordpress.org/ticket/34272#comment:7 for full list of renamed functions and hooks.

Props swissspidy.
Fixes #34272.
Built from https://develop.svn.wordpress.org/trunk@35235


git-svn-id: http://core.svn.wordpress.org/trunk@35201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 01:21:25 +00:00
Sergey Biryukov 1157540283 Replace Quick Edit and Bulk Edit headings with `<legend>` elements.
Props afercia.
Fixes #34289.
Built from https://develop.svn.wordpress.org/trunk@35234


git-svn-id: http://core.svn.wordpress.org/trunk@35200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-10-17 00:45:25 +00:00