Commit Graph

30 Commits

Author SHA1 Message Date
Gary Pendergast 56c162fbc9 Coding Standards: Upgrade WPCS to 1.0.0
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.

This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script. 
- Auto-fixable coding standards issues will now cause Travis failures.

Fixes #44600.


Built from https://develop.svn.wordpress.org/trunk@43571


git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
Gary Pendergast aaf99e6913 Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.


Built from https://develop.svn.wordpress.org/trunk@42343


git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
Gary Pendergast a779284c00 General: Reformat inline `if ()` statements inside HTML tags.
This pattern occurs a handful of times across the codebase:

`<div class="foo<?php if ( $bar ) { echo ' baz'; } ?>">`

Unfortunately, it doesn't really play nicely with `phpcbf`, so all instances need to be removed in preperation for auto code formatting.

See #41057.


Built from https://develop.svn.wordpress.org/trunk@42217


git-svn-id: http://core.svn.wordpress.org/trunk@42046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-23 04:09:49 +00:00
Lance Willett dcf53d5bbb Twenty Eleven: fix escaping and minor code style issues. See #29127.
Built from https://develop.svn.wordpress.org/trunk@31265


git-svn-id: http://core.svn.wordpress.org/trunk@31246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-22 00:42:23 +00:00
Sergey Biryukov 75484f9c20 Bundled themes: Add an alt attribute with the site title for header images linked to the home page.
props rianrietveld.
fixes #15926.
Built from https://develop.svn.wordpress.org/trunk@29842


git-svn-id: http://core.svn.wordpress.org/trunk@29606 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-06 12:44:17 +00:00
Lance Willett 42d2f4fc21 Bundled themes: use correct logic in IE conditional comments in header template. Props mikemanger, fixes #28151.
Built from https://develop.svn.wordpress.org/trunk@28341


git-svn-id: http://core.svn.wordpress.org/trunk@28169 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-07 04:27:15 +00:00
Sergey Biryukov 2c97f4640b Prevent 'Page %s' from being added to page title on 404 error pages in bundled themes.
props psoluch, rob1n.
fixes #16468.
Built from https://develop.svn.wordpress.org/trunk@28250


git-svn-id: http://core.svn.wordpress.org/trunk@28078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-04 13:17:28 +00:00
Lance Willett 38fd43aa3a Twenty Eleven: only show secondary skip link on pages with secondary content, and remove duplicate title attribute in site title output. Props bcworkz, fixes #26950.
Built from https://develop.svn.wordpress.org/trunk@27569


git-svn-id: http://core.svn.wordpress.org/trunk@27412 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-17 21:50:14 +00:00
Andrew Nacin f5eb32ec6b Default themes: Don't use /** docblocks for simple multiline comments.
props DrewAPicture, ericlewis.
fixes #25256.

Built from https://develop.svn.wordpress.org/trunk@25746


git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
Lance Willett 25d1363a66 Twenty Eleven: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256.
Built from https://develop.svn.wordpress.org/trunk@25625


git-svn-id: http://core.svn.wordpress.org/trunk@25542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-25 16:50:11 +00:00
Lance Willett 399ab4bb59 Twenty Ten and Twenty Eleven: revert r23720 and r23721 (closes #23772) and r23718 and r23719 (closes #23774).
Unfortunately, it's too late for these improvements in older themes since it's very likely they'll adversely affect child themes.

git-svn-id: http://core.svn.wordpress.org/trunk@23778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-22 16:15:24 +00:00
Lance Willett dd99d5ce94 Twenty Eleven: use callback in functions.php to enqueue scripts and styles rather than putting them directly in header.php template file. Props obenland, see #23772.
git-svn-id: http://core.svn.wordpress.org/trunk@23720 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 18:24:04 +00:00
Lance Willett c6720facd9 Twenty Eleven: use a filter to modify the output of `wp_title()`. Props obenland, see #23774.
git-svn-id: http://core.svn.wordpress.org/trunk@23718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-15 18:15:58 +00:00
ryan 55958522c1 Back compat for bundled themes. Props nacin, SergeyBiryukov, kobenland. fixes #20768
git-svn-id: http://core.svn.wordpress.org/trunk@20983 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-04 14:43:19 +00:00
nacin 759f103994 Flexible heights for Twenty Eleven's custom headers. see #20448.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-15 19:53:10 +00:00
duck_ 4523ec1333 Fix typo and terminology in Twenty Eleven's header template. Props JarretC. Fixes #20442.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-14 19:02:04 +00:00
nacin e708aa28b2 Remove use of HEADER_IMAGE_WIDTH and HEADER_IMAGE_HEIGHT from twentyeleven/header.php. see #20265.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-20 20:46:46 +00:00
ryan 9f5c80eb92 Use one space, not two, after trailing punctuation. Prop Zeo. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-16 17:13:16 +00:00
azaozz d41f756348 TwentyEleven Theme H1 Priority, props iandstewart, fixes #17611
git-svn-id: http://svn.automattic.com/wordpress/trunk@18335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-23 23:03:46 +00:00
nacin 53cd4287e1 Twenty Eleven: escaping frenzy, hide authors if a single author blog. props DH-Shredder, props iandstewart, see #17385, fixes #17563.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-10 21:57:18 +00:00
iandstewart af7b7c70ab Twenty Eleven: miscellaneous bug fixes and improvements
* Only style images uploaded to the WordPress media library with border styles (and not placeholder images for content added by plugins)
* Prevent content added by plugins and long custom excerpts from overflowing the featured post slider
* Make sure small thumbnails will never appear in the Custom Header area
* Better indicate the current featured post with custom link color and cursor
* Add a class for text-only featured posts
* Style improvements for small screens


git-svn-id: http://svn.automattic.com/wordpress/trunk@18181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-07 21:28:56 +00:00
iandstewart 8a7dd1e31c Twenty Eleven: accessibility improvements and minor style fixes for galleries; See #17524
* Improved color contrast for light and dark color schemes
* Skip link for skipping directly to sidebar content
* Skip links visible on :focus
* Using a more semantic, general class name of .assistive-text instead of .section-heading and .screen-reader-text
* Focus styles for password inputs (and a minor style fix)


git-svn-id: http://svn.automattic.com/wordpress/trunk@18117 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-02 19:30:07 +00:00
nacin 7f98b9beaf Fix Twenty Eleven phpdoc subpackage names. props zeo, fixes #17444.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-18 19:06:09 +00:00
lancewillett ac33e2df00 Twenty Eleven updates and fixes, see #17198
* Add explanatory comments in all templates, following Twenty Ten's example
 * Stick with twentyeleven_ for prefixing filter names
 * Use post format content templates in search results
 * First pass at adding a template for adding a sidebar to pages
 * Add a featured post header to standard sticky posts
 * Style fixes: print media, comment styles for pages with sidebars, color of meta links on image post format

git-svn-id: http://svn.automattic.com/wordpress/trunk@17802 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-04 22:54:50 +00:00
iandstewart ff4d0e5249 Twenty Eleven: updated DocBlock comments following Twenty Ten's example; See #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-02 21:04:44 +00:00
lancewillett 62edbb753b Twenty Eleven: improve calls to get_header_image() - see #17240 and #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-29 22:22:19 +00:00
lancewillett 34cdfcdd41 Twenty Eleven: add additional conditional IDs for the html element, props iandstewart - see #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17718 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-26 18:54:03 +00:00
lancewillett 972a41501e Twenty Eleven: strip trailing spaces, props kawauso - see #17198
git-svn-id: http://svn.automattic.com/wordpress/trunk@17714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-26 18:34:52 +00:00
westi bfbc63f7a2 Fix html5 js link. See #17198 props Jayjdk
git-svn-id: http://svn.automattic.com/wordpress/trunk@17671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-21 07:28:08 +00:00
matt 7d581043df Importing Duster theme, first pass at a candidate for twentyeleven theme.
Nice to have, but optional, improvements it'd be nice to have:

* Ability to have random rotating headers. (Core improvement to custom header functionality.)
* Color and layout options.
* More post formats. (Currently supporst  Asides, Links, and Galleries.)
* CMS-style slider home page option.

Welcome, TwentyEleven née Duster. :) Track at #17198.

git-svn-id: http://svn.automattic.com/wordpress/trunk@17669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-20 21:46:33 +00:00