Gary Pendergast
f51aa3949c
Ensure post titles are correctly escaped on the Dashboard. Merge of [32175] to the 3.7 branch.
...
Props helen, ocean90, dd32, pento.
Built from https://develop.svn.wordpress.org/branches/3.7@32206
git-svn-id: http://core.svn.wordpress.org/branches/3.7@32179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 13:44:10 +00:00
Gary Pendergast
5236e251a3
Merge the query sanity checks from #21212 to the 3.7 branch.
...
Props pento, nacin, mdawaffe, DrewAPicture.
Built from https://develop.svn.wordpress.org/branches/3.7@32188
git-svn-id: http://core.svn.wordpress.org/branches/3.7@32161 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-20 11:52:10 +00:00
Andrew Nacin
1e3fb4d13c
Validate image data.
...
Merges [30458] to the 3.7 branch.
Built from https://develop.svn.wordpress.org/branches/3.7@30465
git-svn-id: http://core.svn.wordpress.org/branches/3.7@30456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-20 16:00:09 +00:00
Andrew Nacin
7331bf3e98
Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.
...
Merges [28113] to the 3.7 branch.
Reverts [27992] which did not fix it for authors and comment/ping status.
props dd32, DrewAPicture.
fixes #27792 .
Built from https://develop.svn.wordpress.org/branches/3.7@28115
git-svn-id: http://core.svn.wordpress.org/branches/3.7@27946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-14 08:13:10 +00:00
Andrew Nacin
9c1b1dd073
Recover auto-drafts lost via Quick Draft.
...
Merges [28075] from the 3.8 to the 3.7 branch. See [28074].
fixes #27734 .
Built from https://develop.svn.wordpress.org/branches/3.7@28077
git-svn-id: http://core.svn.wordpress.org/branches/3.7@27908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-11 17:29:10 +00:00
Andrew Nacin
1f7cf009b3
Ensure edit_post() promotes an auto-draft to draft. Fixes Quick Draft.
...
Merges [28073] from the 3.8 branch to the 3.7 branch.
props dd32.
see #27734 .
Built from https://develop.svn.wordpress.org/branches/3.7@28074
git-svn-id: http://core.svn.wordpress.org/branches/3.7@27905 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-11 04:38:11 +00:00
Andrew Nacin
e5ba4e75cb
Avoid stomping of bulk postdata inside the bulk_edit_posts() loop.
...
Merges [27990] to the 3.7 branch.
props kovshenin.
see [27964], see #27452 .
Built from https://develop.svn.wordpress.org/branches/3.7@27992
git-svn-id: http://core.svn.wordpress.org/branches/3.7@27822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-07 19:36:21 +00:00
Andrew Nacin
c322ca97ad
Better checks for contributors when saving posts.
...
Merges [27976] from the 3.8 branch to the 3.7 branch.
props dd32, kovshenin, plocha.
fixes #27452 .
Built from https://develop.svn.wordpress.org/branches/3.7@27977
git-svn-id: http://core.svn.wordpress.org/branches/3.7@27807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-06 22:17:10 +00:00
Andrew Nacin
d5744d72dc
Background Updates: Record plugin & theme update statistics like we do for core updates.
...
Pass plugin/theme update objects into the Background updater for consistency with core & translations.
Merges [27905] to the 3.7 branch.
props dd32.
fixes #27633 .
Built from https://develop.svn.wordpress.org/branches/3.7@27924
git-svn-id: http://core.svn.wordpress.org/branches/3.7@27754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-03 04:03:09 +00:00
Andrew Nacin
8d9c69ffc4
Core Updates: Fix a case where options (db_version specifically) can end up with stale values in the cache after a update is performed.
...
Merges [26448] and [26734] from 3.8 to the 3.7 branch.
props dd32.
fixes #26173 .
Built from https://develop.svn.wordpress.org/branches/3.7@27885
git-svn-id: http://core.svn.wordpress.org/branches/3.7@27716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 03:36:10 +00:00
Andrew Nacin
62f4a5b223
Updates: When a failed Background Update occurs, only show the failed update nag if the user hasn't yet updated if it was an early abort.
...
Merges [26186] from 3.8 to the 3.7 branch.
props SergeyBiryukov.
fixes #25887 .
Built from https://develop.svn.wordpress.org/branches/3.7@27884
git-svn-id: http://core.svn.wordpress.org/branches/3.7@27715 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 03:31:09 +00:00
Andrew Nacin
4aa0ca0aab
Core Upgrader success statistics: Pass the version of WordPress we're upgrading from, as well as the version being upgraded to.
...
Merges [26016] and [26017] from 3.8 to the 3.7 branch.
fixes #25772 .
Built from https://develop.svn.wordpress.org/branches/3.7@27883
git-svn-id: http://core.svn.wordpress.org/branches/3.7@27714 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 03:29:10 +00:00
Andrew Nacin
8930937bf0
When checking filesystem permissions for core updates, only check the permissions of the files which we need to alter.
...
Merges [26014] from 3.8 to the 3.7 branch.
fixes #25771 .
Built from https://develop.svn.wordpress.org/branches/3.7@27882
git-svn-id: http://core.svn.wordpress.org/branches/3.7@27713 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 03:09:10 +00:00
Andrew Nacin
fe261114bd
Background Updates: Fix a PHP fatal error which could be encountered on some systems when using FTP.
...
Merges [26148] from 3.8 to the 3.7 branch.
props dd32.
fixes #25817 .
Built from https://develop.svn.wordpress.org/branches/3.7@27881
git-svn-id: http://core.svn.wordpress.org/branches/3.7@27712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-01 02:58:10 +00:00
Dion Hulse
bd4a5ae14a
Background Updates: Spread them over the hour. Props Pento. Merges r26149 to the 3.7 branch. Fixes #25833 for 3.7.
...
Built from https://develop.svn.wordpress.org/branches/3.7@26450
git-svn-id: http://core.svn.wordpress.org/branches/3.7@26348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-28 02:35:11 +00:00
Andrew Nacin
7c591bacff
Use correct variable in WP_Automatic_Updater::send_email().
...
Merges [25977] to the 3.7 branch and adds an inline comment.
props pento.
see #25757 .
Built from https://develop.svn.wordpress.org/branches/3.7@25981
git-svn-id: http://core.svn.wordpress.org/branches/3.7@25920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-29 17:15:10 +00:00
Andrew Nacin
4006a8aa0a
When an HTTPS request to api.wordpress.org fails, try an insecure HTTP request and issue a warning.
...
Certain versions of cURL appear to claim OpenSSL support but fail to work. We need to not trap users on older versions while we work this out, and instead fall back to an insecure request.
Merges [25956] to the 3.7 branch.
fixes #25716 for the 3.7 branch.
Built from https://develop.svn.wordpress.org/branches/3.7@25957
git-svn-id: http://core.svn.wordpress.org/branches/3.7@25916 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-27 21:10:09 +00:00
Andrew Nacin
01023d9bfa
Avoid a notice for an undefined $checksums variable when updating from pre-3.7 to post-3.7.
...
Merges [25915] to the 3.7 branch.
props GaryJ.
fixes #25689 .
Built from https://develop.svn.wordpress.org/branches/3.7@25916
git-svn-id: http://core.svn.wordpress.org/branches/3.7@25879 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-25 20:17:09 +00:00
Andrew Nacin
a49c3f07c8
Add editimage.min.js to $_old_files. see #24999 . for the 3.7 branch.
...
Built from https://develop.svn.wordpress.org/branches/3.7@25898
git-svn-id: http://core.svn.wordpress.org/branches/3.7@25810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 19:29:10 +00:00
Andrew Nacin
36a4f54379
Confirm delete_site_option() exists before calling it during an update.
...
This function won't yet exist when updating from 2.7 [sic].
Merges [25893] to the 3.7 branch.
fixes #25682 .
Built from https://develop.svn.wordpress.org/branches/3.7@25894
git-svn-id: http://core.svn.wordpress.org/branches/3.7@25806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 18:21:10 +00:00
Andrew Nacin
a8bda30209
Remove debug code from WP_Automatic_Updater::send_email().
...
Merges [25891] to the 3.7 branch.
props markmcwilliams for initial patch.
fixes #25678 .
Built from https://develop.svn.wordpress.org/branches/3.7@25892
git-svn-id: http://core.svn.wordpress.org/branches/3.7@25804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-24 02:00:09 +00:00
Andrew Nacin
4152cb0b4b
Introduce a send_core_update_notification_email filter to control whether to send update notifications.
...
Merges [25882] to the 3.7 branch.
Currently, this is dependent on whether the automatic updater is enabled (generally). This is likely to be decoupled in a future release.
This refocuses the auto_core_update_send_email filter to specifically be for success/fail emails for auto updates, while the new filter is more general.
see #25603 .
Built from https://develop.svn.wordpress.org/branches/3.7@25885
git-svn-id: http://core.svn.wordpress.org/branches/3.7@25797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 19:54:10 +00:00
Ryan Boren
85447a0bf3
Pinking shears
...
Built from https://develop.svn.wordpress.org/branches/3.7@25881
git-svn-id: http://core.svn.wordpress.org/branches/3.7@25793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-23 14:40:10 +00:00
Andrew Nacin
a387c3bef9
Make some changes to the email templates to account for the fact that an auto update offer might not be to the latest version.
...
For example, 3.7.2 install is served a 3.7.3 update, but the current version is 3.8.1.
This commit also allows for core update notification emails to be sent even when we are unable to run an auto update due to filesystem configuration (VCS checkout or file permissions). But, since these emails go through WP_Automatic_Updater, they will not be sent if the updater is outright disabled.
fixes #25654 .
Built from https://develop.svn.wordpress.org/trunk@25873
git-svn-id: http://core.svn.wordpress.org/trunk@25785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 21:19:09 +00:00
Andrew Nacin
58c18f0c32
Show the nag we show for a stuck .maintenance file when an auto update failed.
...
see #25654 .
Built from https://develop.svn.wordpress.org/trunk@25872
git-svn-id: http://core.svn.wordpress.org/trunk@25784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 21:15:09 +00:00
Andrew Nacin
13dd29126a
"some files" instead of "certain files". Less stuffy.
...
props markjaquith.
see #25652 .
Built from https://develop.svn.wordpress.org/trunk@25871
git-svn-id: http://core.svn.wordpress.org/trunk@25783 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:41:10 +00:00
Andrew Nacin
fabf119cf3
New, better error message when we realize we won't be able to copy a file and continue with the update.
...
fixes #25652 .
Built from https://develop.svn.wordpress.org/trunk@25870
git-svn-id: http://core.svn.wordpress.org/trunk@25782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:21:10 +00:00
Andrew Nacin
d5fdd66f9d
Only enforce disk free space checks when doing background updates.
...
see #25652 .
Built from https://develop.svn.wordpress.org/trunk@25869
git-svn-id: http://core.svn.wordpress.org/trunk@25781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 18:18:09 +00:00
Andrew Nacin
74488bdcb0
Spell out duplicate hook locations.
...
props DrewAPicture.
fixes #25658 .
Built from https://develop.svn.wordpress.org/trunk@25868
git-svn-id: http://core.svn.wordpress.org/trunk@25780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:22:11 +00:00
Andrew Nacin
a160441c81
Updates: Disable maintenance mode once we've finished copying files, to minimize disruption.
...
props dd32.
fixes #25655 .
Built from https://develop.svn.wordpress.org/trunk@25866
git-svn-id: http://core.svn.wordpress.org/trunk@25778 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 17:20:10 +00:00
Andrew Nacin
097c0fd0b6
Updates: Saner stats and rollback handling. WP.org now collects basic stats on non-auto updates as they have been hugely informative.
...
props dd32 for initial patch.
fixes #25657 .
Built from https://develop.svn.wordpress.org/trunk@25863
git-svn-id: http://core.svn.wordpress.org/trunk@25775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 09:49:09 +00:00
Andrew Nacin
64bd5aa564
Move upgrader_process_complete for core to its proper place in Core_Upgrader.
...
This means it will be firing as a JS redirect is taking place if the update is from pre-3.4. Acceptable.
props dd32.
fixes #25659 .
Built from https://develop.svn.wordpress.org/trunk@25861
git-svn-id: http://core.svn.wordpress.org/trunk@25773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-22 04:37:09 +00:00
Andrew Nacin
5a0b227316
Rename the automatic_updates_send_email filter to auto_core_update_send_email. (Final name change.)
...
fixes #25653 . Also:
* Fully document all new hooks, methods, and classes in the upgrader.
* Rename 'language' to 'translation' inside the upgrader.
* Improve the readability of the crazy do-while loop in the is_vcs_checkout() method.
Built from https://develop.svn.wordpress.org/trunk@25859
git-svn-id: http://core.svn.wordpress.org/trunk@25771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-21 22:29:09 +00:00
Andrew Nacin
ee489a2e81
Commit [25823] should not have renamed AUTOMATIC_UPDATER_DISABLED to AUTOMATIC_UPDATES_DISABLED.
...
The proper constant is AUTOMATIC_UPDATER_DISABLED. Keep the filter in line with that too.
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25851
git-svn-id: http://core.svn.wordpress.org/trunk@25763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 21:24:10 +00:00
Andrew Nacin
c00bba9e8b
Use correct variable. fixes #10787 .
...
Built from https://develop.svn.wordpress.org/trunk@25843
git-svn-id: http://core.svn.wordpress.org/trunk@25755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 17:16:10 +00:00
Andrew Nacin
ee20af1fad
Notify administrators of successful, failed, and pending core updates.
...
Blocks future background updates after critical failures, but allow retries in certain situations. More in the ticket.
fixes #10787 .
Built from https://develop.svn.wordpress.org/trunk@25841
git-svn-id: http://core.svn.wordpress.org/trunk@25753 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 16:30:11 +00:00
Andrew Nacin
859da01c4a
Delete expired transients on database upgrades.
...
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.
props dartiss, pento.
fixes #20316 .
Built from https://develop.svn.wordpress.org/trunk@25838
git-svn-id: http://core.svn.wordpress.org/trunk@25750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 07:48:09 +00:00
Andrew Nacin
5f3e90a112
Introduce email templates for automatic background updates.
...
The four templates are:
1. We successfully updated their site. If any of their themes or plugins are out of date, it also mentions that. ('success')
2. We are not configured to update their site, so we notify them of the new release. ('notify')
3. We tried but failed to update their site. The error was early in the process, so no harm, no foul. This is the same as template #2 , plus one sentence. ('fail')
4. We tried to update their site, and failed while copying files. ('critical')
With assistance from markjaquith.
see #10787 .
Built from https://develop.svn.wordpress.org/trunk@25837
git-svn-id: http://core.svn.wordpress.org/trunk@25749 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-18 06:33:10 +00:00
Andrew Nacin
325ccd0a14
set_current_screen() is now unnecessary in Automatic_Upgrader_Skin, which is good because it breaks things in the network admin.
...
fixes #25622 .
Built from https://develop.svn.wordpress.org/trunk@25836
git-svn-id: http://core.svn.wordpress.org/trunk@25748 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 23:24:09 +00:00
Andrew Nacin
a65661abee
In automatic background updates, standardize on 'update'.
...
New, final filter names:
* auto_update_{$type} (plugin, theme, core, language)
* automatic_updates_is_vcs_checkout
* automatic_updates_disabled
New class name is WP_Automatic_Updater. Method names include update() and should_update().
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25835
git-svn-id: http://core.svn.wordpress.org/trunk@25747 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 23:21:10 +00:00
Dion Hulse
924e35d66a
Silence PHP warnings from disk_free_space(). disk_free_space() will produce a warning in error conditions in addition to returning false, this includes a case where the bytes free is greater than PHP_INT_MAX (which is a error condition we don't need to check).
...
See #25576 , #22704
Built from https://develop.svn.wordpress.org/trunk@25831
git-svn-id: http://core.svn.wordpress.org/trunk@25743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 18:40:10 +00:00
Dion Hulse
1c8d882e13
For Background updates, ensure that only one update process runs at the same time by using the options table as a lock.
...
This prevents multiple cron spawns and/or long-running updates from causing multiple update processes to spin up.
This also fixes a case where the upgrader might kick in for ( ! is_main_network() || ! is_main_site() ) in mulisite installs.
See #22704
Built from https://develop.svn.wordpress.org/trunk@25828
git-svn-id: http://core.svn.wordpress.org/trunk@25740 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 05:24:09 +00:00
Andrew Nacin
9432acde4e
Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone.
...
see #27704 .
Built from https://develop.svn.wordpress.org/trunk@25825
git-svn-id: http://core.svn.wordpress.org/trunk@25737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 04:02:09 +00:00
Andrew Nacin
191efaef61
Make WP_Automatic_Upgrader a proper object that gets instantiated. Renames nearly all of its methods.
...
Also renames wp_auto_updates_maybe_update() to wp_maybe_auto_update().
see #22704 .
Built from https://develop.svn.wordpress.org/trunk@25823
git-svn-id: http://core.svn.wordpress.org/trunk@25735 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 00:55:09 +00:00
Dion Hulse
640f73ecd2
Remove a duplicate semicolon that snuck in. Props JustinSainton. See #18200
...
Built from https://develop.svn.wordpress.org/trunk@25822
git-svn-id: http://core.svn.wordpress.org/trunk@25734 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-17 00:12:10 +00:00
Dion Hulse
376a0a55c7
Allow the WordPress.org Language update API to disallow automated background updates for a specific language pack. See #18200
...
Built from https://develop.svn.wordpress.org/trunk@25818
git-svn-id: http://core.svn.wordpress.org/trunk@25730 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 22:27:09 +00:00
Dion Hulse
ed07bab4b4
When a plugin enables Background Plugin updates, don't deactivate the plugin during update as we require a browser to reactivate it afterwards. See #22704
...
Built from https://develop.svn.wordpress.org/trunk@25817
git-svn-id: http://core.svn.wordpress.org/trunk@25729 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 19:48:10 +00:00
Andrew Nacin
bccefbbd83
Merge the should_auto_update() and can_auto_update() methods. see #22704 .
...
Built from https://develop.svn.wordpress.org/trunk@25815
git-svn-id: http://core.svn.wordpress.org/trunk@25727 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 19:35:09 +00:00
Dion Hulse
085f5c5fb9
Fix a issue where the translation name isn't showing up in the Background Update emails, caused by a PHP Warning/missing variable in [25806]. See #18200
...
Built from https://develop.svn.wordpress.org/trunk@25812
git-svn-id: http://core.svn.wordpress.org/trunk@25724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 17:07:08 +00:00
Dion Hulse
8c35982ae8
Avoid a few PHP Warnings when files don't exist and use a better method to locate the local filepath.
...
See #18201
Built from https://develop.svn.wordpress.org/trunk@25811
git-svn-id: http://core.svn.wordpress.org/trunk@25723 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-16 15:20:10 +00:00