Commit Graph

17655 Commits

Author SHA1 Message Date
Gary Pendergast a02b5cc2a8 Coding Standards: Mark the handful of hook names with uppercase characters or hyphens as ignored.
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45599


git-svn-id: http://core.svn.wordpress.org/trunk@45410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-05 01:45:56 +00:00
Sergey Biryukov 4af4c78a27 Text Changes: Use consistent question wording for plugin and theme deletion confirmations.
Props johnjamesjacoby, Presskopp.
Fixes #44878.
Built from https://develop.svn.wordpress.org/trunk@45597


git-svn-id: http://core.svn.wordpress.org/trunk@45408 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-04 09:56:57 +00:00
Gary Pendergast cf3fa9f7c8 Coding Standards: Fix the `Squiz.PHP.DisallowMultipleAssignments` violations in `wp-admin`.
See #47632.


Built from https://develop.svn.wordpress.org/trunk@45583


git-svn-id: http://core.svn.wordpress.org/trunk@45394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 12:52:01 +00:00
Gary Pendergast 55af0f0d0a Coding Standards: Fix/ignore the `WordPress.NamingConventions.ValidFunctionName` violations.
See #47632


Built from https://develop.svn.wordpress.org/trunk@45580


git-svn-id: http://core.svn.wordpress.org/trunk@45391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 08:01:57 +00:00
Gary Pendergast 072682b1ed Multisite: Use `size_format()` in `display_space_usage()`.
Deleted code is the best code.

Fixes #28239.


Built from https://develop.svn.wordpress.org/trunk@45579


git-svn-id: http://core.svn.wordpress.org/trunk@45390 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-01 03:47:56 +00:00
Sergey Biryukov 9d7bd11631 Docs: Correct `@since` for `admin/edit-comments.js`, introduced in [3736].
See #47581.
Built from https://develop.svn.wordpress.org/trunk@45567


git-svn-id: http://core.svn.wordpress.org/trunk@45378 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-26 18:19:52 +00:00
Andrew Ozz 05c9032a0b Editor: Fix undefined `$locked` var in edit-form-blocks.php when the `show_post_locked_dialog` filter is used to disable displaying of the dialog.
Props aprea.
Fixes #47604.
Built from https://develop.svn.wordpress.org/trunk@45564


git-svn-id: http://core.svn.wordpress.org/trunk@45375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-25 15:03:52 +00:00
Andrea Fercia ba24a8f6d3 Plugins: Fix the plugin details modal layout after [45520].
Props mukesh27, marybaum, audrasjb.
Fixes #47561.

Built from https://develop.svn.wordpress.org/trunk@45563


git-svn-id: http://core.svn.wordpress.org/trunk@45374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-25 14:11:55 +00:00
atimmer 225de4e6eb Docs: Improve JSDoc for `admin/edit-comments.js`.
Props manuelaugustin, diedeexterkate, thulshof, Xyfi, ireneyoast.
Fixes #47581.

Built from https://develop.svn.wordpress.org/trunk@45558


git-svn-id: http://core.svn.wordpress.org/trunk@45369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 14:45:51 +00:00
Adam Silverstein bcc4ecb1f6 Themes: improve search by trimming search string.
Fix an issue where searching installed themes for an empty string resulted in matching all themes.

Props afercia, desrosj, hesyifei, evalarumbe.
Fixes #39041.

Built from https://develop.svn.wordpress.org/trunk@45557


git-svn-id: http://core.svn.wordpress.org/trunk@45368 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 14:15:53 +00:00
Sergey Biryukov 89e7a75d96 Date/Time: Eliminate use of `date_default_timezone_set()` for determining DST status on General Options screen.
Time calculations should not need to rely on manipulating global PHP configuration state.

Props Rarst.
Fixes #46483.
Built from https://develop.svn.wordpress.org/trunk@45556


git-svn-id: http://core.svn.wordpress.org/trunk@45367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 14:11:53 +00:00
atimmer 8756207ef2 Comments: Open comment quick edit on double click.
In [42767] the quick edit button changed from a link to a button. This caused the jQuery code that selects on a link to no longer work. This commit restores the previous behavior.

Fixes #47572.
See #43382, #38677.

Built from https://develop.svn.wordpress.org/trunk@45553


git-svn-id: http://core.svn.wordpress.org/trunk@45364 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 10:06:51 +00:00
desrosj 470177a906 Help/About: Improve wording of PHP Error Protection section.
Props pedromendonca, garrett-eclipse.
See #47475.
Fixes #47538.
Built from https://develop.svn.wordpress.org/trunk@45551


git-svn-id: http://core.svn.wordpress.org/trunk@45362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-20 09:52:54 +00:00
Sergey Biryukov f0e9ffdebb Plugins: When validating plugin's WordPress and PHP requirements, check for `Requires at least` and `Requires PHP` headers in the plugin's main PHP file.
This allows for blocking plugin activation if it requires a higher version of PHP or WordPress, and does not have a `readme.txt` file.

If the headers are defined in both `readme.txt` and the main plugin file, precedence is given to the plugin file.

Props afragen, Otto42, Ipstenu.
Fixes #46938.
Built from https://develop.svn.wordpress.org/trunk@45546


git-svn-id: http://core.svn.wordpress.org/trunk@45357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-18 03:24:52 +00:00
Andrew Ozz 88ffa41ee3 Media: Ignore errors coming from `image_resize_dimensions()` when creating sub-sizes (for now). It returns `false` when the requested size is larger than the original image and should be skipped. This triggers new `WP_Error` in `WP_Image_Editor::resize()`.
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45543


git-svn-id: http://core.svn.wordpress.org/trunk@45354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-16 01:33:51 +00:00
Sergey Biryukov 4e4ef1170b I18N: Merge duplicate strings in notifications displayed when a new user has been created or added to the site.
Props ramiy.
Fixes #35746.
Built from https://develop.svn.wordpress.org/trunk@45542


git-svn-id: http://core.svn.wordpress.org/trunk@45353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 18:57:52 +00:00
Andrew Ozz da7839dc45 After [45538]: fix another WPCS "strict comparison" fix.
Props birgire.
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45540


git-svn-id: http://core.svn.wordpress.org/trunk@45351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 16:24:52 +00:00
Andrew Ozz 5987caeecc After [45538]: fix a WPCS fix and make couple of var names consistent.
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45539


git-svn-id: http://core.svn.wordpress.org/trunk@45350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 01:32:53 +00:00
Andrew Ozz 05302bd054 Save progress of intermediate image creation after upload. First run.
- Introduces `wp_get_missing_image_subsizes()` and `wp_update_image_subsizes()` to generate image sub-sizes that are missing or were not created after the upload.
- Adds a way to display errors that happened while creating sub-sizes.
- Introduces `wp_create_image_subsizes()` intended for use after an image was uploaded. It saves/updates the image metadata immediately after each sub-size is created. This fixes the (long standing) problem when some of the sub-size image files were created but there was a timeout or an error and the metadata was not saved. Until now such uploads were considered "failed" which usually resulted in the user trying to upload the same image again, creating even more "orphan" image files.

Note that the patch also includes some unrelated WPCS fixes.

Props mikeschroder, azaozz.
See #40439.
Built from https://develop.svn.wordpress.org/trunk@45538


git-svn-id: http://core.svn.wordpress.org/trunk@45349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-15 01:02:52 +00:00
Sergey Biryukov 0239fe6d10 Administration: Adjust code for "Manage widgets or menus" item on "Welcome to WordPress" panel to avoid an extra space after [42343].
Props Presskopp, davidbaumwald.
Fixes #47536.
Built from https://develop.svn.wordpress.org/trunk@45536


git-svn-id: http://core.svn.wordpress.org/trunk@45347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-14 00:29:52 +00:00
Andrew Ozz d38e15e59d Fix displaying of the "An updated version of WordPress is available." notice when running the latest nightly build. Note that it is still displayed when running a local build or from `/src`.
Props afragen, audrasjb, SergeyBiryukov.
Fixes #45202.
Built from https://develop.svn.wordpress.org/trunk@45532


git-svn-id: http://core.svn.wordpress.org/trunk@45343 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 16:43:53 +00:00
Andrew Ozz 727838a11b Add a Recovery Mode Exit button to the notice. This fixes it in responsive view.
Props desrosj, karmatosed, chetan200891, afercia, afragen, garrett-eclipse.
Fixes #47070.
Built from https://develop.svn.wordpress.org/trunk@45529


git-svn-id: http://core.svn.wordpress.org/trunk@45340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-13 16:00:52 +00:00
Andrea Fercia 340fd28d82 Accessibility: Improve focus management in the Media Views.
- keeps focus management only where necessary to avoid focus losses
- removes focus management where a specific user workflow was assumed
- makes the "Attachment Details" navigation buttons really disabled when there are no next or previous attachments
- adds inline comments to clarify all the usages of focus()

Fixes #43169.

Built from https://develop.svn.wordpress.org/trunk@45524


git-svn-id: http://core.svn.wordpress.org/trunk@45335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 21:03:52 +00:00
Andrea Fercia 9f579ea448 Administration: Improve the horizontal centering of the Site Health tabs.
Props dkarfa, davidbaumwald, Clorith, tinkerbelly, afercia.
Fixes #46881.

Built from https://develop.svn.wordpress.org/trunk@45522


git-svn-id: http://core.svn.wordpress.org/trunk@45333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:31:52 +00:00
Andrea Fercia 9f7f9d2d89 Administration: Fix the responsive layout after changes to the Screen Options and Help buttons position.
Fixes #45094.

Built from https://develop.svn.wordpress.org/trunk@45520


git-svn-id: http://core.svn.wordpress.org/trunk@45331 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-12 19:21:54 +00:00
Andrew Ozz d0c1b77cda Privacy tools:
- Move the (remaining) privacy tools related functions from `wp-admin/includes/file.php` to `wp-admin/includes/privacy-tools.php`.
- Move the `WP_User_Request` class to a separate file.

See #43895.
Built from https://develop.svn.wordpress.org/trunk@45519


git-svn-id: http://core.svn.wordpress.org/trunk@45330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 23:54:53 +00:00
Sergey Biryukov 3b69e493f6 I18N: Merge duplicate "authenticity could not be verified" strings, fix comma placement on About page.
Props pedromendonca, garrett-eclipse.
Fixes #47475.
Built from https://develop.svn.wordpress.org/trunk@45515


git-svn-id: http://core.svn.wordpress.org/trunk@45326 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 14:14:51 +00:00
Peter Wilson a5e57d7245 Site health: Introduce `view_site_health_checks` capability.
Introduces the faux primitive capability `view_site_health_checks` available to single site admins and multisite super-admin to view the site health page within the admin.

The capability is mapped to the `install_plugins` capability without being dependent on the file system being writable. This fixes a bug where the feature couldn't be used by sites unable to write to the file system or managed through version control.

The capability is granted on the `user_has_cap` filter.

Props birgire, Clorith, palmiak, peterwilsoncc, spacedmonkey.
Fixes #46957.


Built from https://develop.svn.wordpress.org/trunk@45507


git-svn-id: http://core.svn.wordpress.org/trunk@45318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-10 07:42:52 +00:00
John Blackbourn c9b51df3d0 I18N: Allow the length of automatically generated excerpts to be localized.
This introduces three new strings that can be used to control the maximum length of automatically generated excerpts for posts, comments, and draft post previews in the dashboard. Optionally combined with the existing word count type control this allows languages which include many multibyte characters to specify more appropriate maximum excerpt lengths.

Props miyauchi, birgire, johnbillion

Fixes #44541

Built from https://develop.svn.wordpress.org/trunk@45505


git-svn-id: http://core.svn.wordpress.org/trunk@45316 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 18:42:52 +00:00
Andrea Fercia 935c35fe34 Accessibility: Improve the Screen Options and Help buttons order.
- makes the buttons visual order match the DOM order
- also, restores the focus style on the "hero" primary button after [34948]

Props vrimill, mukesh27 for reporting and testing.
Fixes #45094.

Built from https://develop.svn.wordpress.org/trunk@45503


git-svn-id: http://core.svn.wordpress.org/trunk@45314 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:31:53 +00:00
Andrea Fercia be14c6e5c6 Administration: Improve the Screen Options and Help buttons focus style after [45501].
Amends [45501].
See #46749.

Built from https://develop.svn.wordpress.org/trunk@45502


git-svn-id: http://core.svn.wordpress.org/trunk@45313 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 16:07:52 +00:00
Andrea Fercia 17034e2a4e Administration: Remove extra border from the Screen Options and Help buttons.
The extra border was visible in the responsive view for smaller screens after [32844].

Props jitendrabanjara1991.
Fixes #46749.

Built from https://develop.svn.wordpress.org/trunk@45501


git-svn-id: http://core.svn.wordpress.org/trunk@45312 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 14:50:52 +00:00
Andrew Ozz 7cee029897 Privacy tools: remove some left-over code and fix inline comment.
See #43895.


Built from https://develop.svn.wordpress.org/trunk@45500


git-svn-id: http://core.svn.wordpress.org/trunk@45311 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-08 00:30:51 +00:00
Andrea Fercia 6a9bcaeaa9 Accessibility: Improve accessibility of all the media views form controls.
- changes the media views form controls to have explicitly associated labels with for/id attributes
- adds a few missing labels / aria-labels
- improves a few existing labels / aria-labels
- improves semantics in a few places, by adding visually hidden headings, fieldset + legend elements, aria-describedby attributes
- improves the image custom size input fields and their labelling
- adds `role="status"` to the "saved" indicator so that status messages are announced to assistive technologies
- swaps the columns source order in the image details template, to make visual and DOM order match
- swaps the "Replace" and "Back" buttons source order in the Replace Image view, to make visual and DOM order match
- gallery settings: move checkbox label to the right: checkboxes are supposed to have labels on the right
- merge similar strings, unified to "Drop files to upload" (removed "Drop files here", and "Drop files anywhere to upload")
- makes the "upload-ui" consistent across the media views
- hides the IE 11 "X" `::-ms-clear` button in the Insert from URL field, as it conflicts with the uploading spinner
- adds comments to all the media templates to clarify their usage
- slightly increases vertical spacing between form fields in the media sidebar
- removes some CSS selectors introduced as backwards compatibility for WordPress pre-4.4
- removes some CSS still targeting Internet Explorer 7 and 8

Fixes #47141.
Fixes #47122.

Built from https://develop.svn.wordpress.org/trunk@45499


git-svn-id: http://core.svn.wordpress.org/trunk@45310 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 20:45:02 +00:00
Andrea Fercia d5333b9593 Fix the media player controls bar width in the media views.
Props vaishalipanchal, chetan200891.
Fixes #47457.

Built from https://develop.svn.wordpress.org/trunk@45497


git-svn-id: http://core.svn.wordpress.org/trunk@45308 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-07 13:29:52 +00:00
Sergey Biryukov baa2cd69b8 Media: Restore correct arrow direction in RTL in Attachment Details modal.
Reverts [29264]. As we now have a build task to replace dashicons for RTL, the CSS rules no longer worked as expected and had the opposite effect.

Props ramiy, SergeyBiryukov.
Fixes #46289.
Built from https://develop.svn.wordpress.org/trunk@45495


git-svn-id: http://core.svn.wordpress.org/trunk@45306 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-06 01:25:52 +00:00
desrosj 4c0620bdf8 Privacy: Remove inline CSS within personal data request list tables.
The `.hidden` class can be used to show and hide UI elements instead.

Props birgire, pratikthink, garrett-eclipse.
Fixes #44839.
Built from https://develop.svn.wordpress.org/trunk@45490


git-svn-id: http://core.svn.wordpress.org/trunk@45301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-04 23:40:55 +00:00
Sergey Biryukov 32d761ce7d I18N: Merge duplicate "Status" and "Info" strings on Site Health screens.
Props ramiy.
Fixes #47227.
Built from https://develop.svn.wordpress.org/trunk@45488


git-svn-id: http://core.svn.wordpress.org/trunk@45299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-06-01 22:10:52 +00:00
Sergey Biryukov 13da094c39 Upgrade/Install: Correct operator precedence for an error code in `WP_Ajax_Upgrader_Skin::error()`.
Props jrf.
Fixes #47441.
Built from https://develop.svn.wordpress.org/trunk@45487


git-svn-id: http://core.svn.wordpress.org/trunk@45298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-31 14:14:52 +00:00
Sergey Biryukov 0d40c54f9b CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/media.css`.
Props ianbelanger, mukesh27, pbiron, afercia.
Fixes #46530. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45484


git-svn-id: http://core.svn.wordpress.org/trunk@45295 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:45:50 +00:00
Sergey Biryukov 412ffd0aaf Media: Move tag cloud styles that accidentally ended up in Media section after the reorganization in [16136] to a more appropriate place.
Remove styles for `wp-admin/update-core.php` accidentally duplicated in Media section as part of the same reorganization.

See #46530.
Built from https://develop.svn.wordpress.org/trunk@45483


git-svn-id: http://core.svn.wordpress.org/trunk@45294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 16:40:52 +00:00
desrosj 349d95f27a Docs: Add missing function documentation for `list_plugin_updates()`.
Introduced in [9543].

Props priyankkpatel, mukesh27.
Fixes #47424.
Built from https://develop.svn.wordpress.org/trunk@45480


git-svn-id: http://core.svn.wordpress.org/trunk@45291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 15:10:52 +00:00
Sergey Biryukov fdc6b9583b CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/revisions.css`.
Props ianbelanger, pbiron, afercia.
Fixes #46517. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45468


git-svn-id: http://core.svn.wordpress.org/trunk@45279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:16:52 +00:00
Sergey Biryukov ca6aa01705 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/list-tables.css`.
Props ianbelanger, pbiron, afercia.
Fixes #46515. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45467


git-svn-id: http://core.svn.wordpress.org/trunk@45278 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:15:52 +00:00
Sergey Biryukov afaeca95cf CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/login.css`.
Props ianbelanger, pbiron, afercia.
Fixes #46514. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45466


git-svn-id: http://core.svn.wordpress.org/trunk@45277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 12:09:52 +00:00
Sergey Biryukov 1899a99c35 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/install.css`.
Props ianbelanger, pbiron, afercia.
Fixes #46513. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45465


git-svn-id: http://core.svn.wordpress.org/trunk@45276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:53:53 +00:00
Sergey Biryukov 03814826b2 CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/forms.css`.
Props ianbelanger, pbiron, afercia.
Fixes #46512. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45464


git-svn-id: http://core.svn.wordpress.org/trunk@45275 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-30 11:49:53 +00:00
Andrea Fercia 41accccad6 Administration: Improve the Site Health tables layout for small screens.
Props immeet94, jankimoradiya, desrosj, shashank3105, chetan200891, Clorith, hedgefield.	
Fixes #46960.

Built from https://develop.svn.wordpress.org/trunk@45463


git-svn-id: http://core.svn.wordpress.org/trunk@45274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 18:22:51 +00:00
Sergey Biryukov 52d478cb0d CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/edit.css`.
Props ianbelanger, pbiron, afercia.
Fixes #46511. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45462


git-svn-id: http://core.svn.wordpress.org/trunk@45273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:05:53 +00:00
Sergey Biryukov ce25e2f34d CSS Coding Standards: Use unitless values for `line-height` in `wp-admin/css/dashboard.css`.
Props ianbelanger, pbiron, afercia.
Fixes #46510. See #44643.
Built from https://develop.svn.wordpress.org/trunk@45461


git-svn-id: http://core.svn.wordpress.org/trunk@45272 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-05-29 16:03:52 +00:00