Commit Graph

30500 Commits

Author SHA1 Message Date
Dominik Schilling efda1aeb3a Update PHPMailer to 5.2.10 from 5.2.7.
Includes two modifications for WordPress:
* Removes support for NTLM in `class-smtp.php` since the required client (`extras/ntlm_sasl_client.php`) is not distributed as part of WordPress.
* Requires `class-smtp.php` for backwards compatibility with direct (non-wp_mail()) uses of PHPMailer, as the autoloader isn't used. See [27385].

This also includes a change to our `MockMailer` for unit tests. It now overrides `postSend() instead of `send()`, and `preSend()`.
`preSend()` resets `$this->Encoding` because PHPMailer doesn't clean up after itself / presets all variables. This becomes an issue when `PHPMailer::createBody()` sets `$this->Encoding = 'quoted-printable'` (away from it's default of 8bit) when it encounters a line longer than 998 characters. `Tests_Comment::test_comment_field_lengths` is such a case.

props MattyRob, dd32.
fixes #28909.
Built from https://develop.svn.wordpress.org/trunk@33124


git-svn-id: http://core.svn.wordpress.org/trunk@33095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 17:16:25 +00:00
Aaron Jorbin 0ec584c51f Remove PHP4 constructors from Unit Tests
If you are subclassing these classes in your own tests, you'll need to update your code.

Props johnbillion
See #31982


Built from https://develop.svn.wordpress.org/trunk@33123


git-svn-id: http://core.svn.wordpress.org/trunk@33094 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 16:05:26 +00:00
Helen Hou-Sandí 30e478b1fb Move `get_default_comment_status()` to `wp-includes/comment.php` to sit alongside `get_comment_statuses()`.
props nacin.
see #31168.

Built from https://develop.svn.wordpress.org/trunk@33122


git-svn-id: http://core.svn.wordpress.org/trunk@33093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 15:44:28 +00:00
Sergey Biryukov 1276096e3a Menus: Restore visibility of up/down arrows for reordering menu items with JS disabled.
props afercia.
fixes #32916.
Built from https://develop.svn.wordpress.org/trunk@33121


git-svn-id: http://core.svn.wordpress.org/trunk@33092 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 06:48:24 +00:00
Weston Ruter 4f93c26f87 Customizer: Prevent preview from loading during QUnit tests and causing an XHR cross-domain error.
Fixes #32666.

Built from https://develop.svn.wordpress.org/trunk@33120


git-svn-id: http://core.svn.wordpress.org/trunk@33091 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 05:38:25 +00:00
John Blackbourn e2cbf49a2c Introduce unit tests for `sanitize_option()`.
Props MikeHansenMe, welcher, johnbillion
See #32351

Built from https://develop.svn.wordpress.org/trunk@33119


git-svn-id: http://core.svn.wordpress.org/trunk@33090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-08 00:06:25 +00:00
John Blackbourn bc745f81a9 Allow shortcode parameter names (attributes) to contain dashes.
Props aaroncampbell, tyxla, izem
Fixes #9405

Built from https://develop.svn.wordpress.org/trunk@33118


git-svn-id: http://core.svn.wordpress.org/trunk@33089 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 23:59:24 +00:00
Helen Hou-Sandí 9c3bc85649 Ensure error messages look like, well, errors.
props obenland, rachelbaker.
fixes #32475.

Built from https://develop.svn.wordpress.org/trunk@33117


git-svn-id: http://core.svn.wordpress.org/trunk@33088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 23:11:24 +00:00
Scott Taylor 6c90a44828 After [32980], update the docs to reflect that `display_name` is now included when searching for users in some scenarios.
Fixes #27304.

Built from https://develop.svn.wordpress.org/trunk@33116


git-svn-id: http://core.svn.wordpress.org/trunk@33087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 19:39:25 +00:00
Scott Taylor 6b034b67f5 In `wp_insert_user()`, comparing an email address against the user's old email address should not be case-sensitive.
Adds unit tests.

Props tyxla.
Fixes #32158.

Built from https://develop.svn.wordpress.org/trunk@33115


git-svn-id: http://core.svn.wordpress.org/trunk@33086 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 19:29:24 +00:00
Scott Taylor 0deed4b842 In `install_dashboard()` (`plugin-install`, FWIW), make sure `slug` is populated and degrease the unfortunate whitespace that was present.
Props tyxla.
Fixes #32889.

Built from https://develop.svn.wordpress.org/trunk@33114


git-svn-id: http://core.svn.wordpress.org/trunk@33085 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 19:19:24 +00:00
Konstantin Obenland 2cc8269741 Hide notices introduced in [30505] on about page.
See #19237.

Props jadpm.
Fixes #32625.


Built from https://develop.svn.wordpress.org/trunk@33113


git-svn-id: http://core.svn.wordpress.org/trunk@33084 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 18:47:25 +00:00
Konstantin Obenland 52c2567424 Menus: Respect context when linking to the Customizer.
`Manage in Customizer` will now link to menu locations or the menus panel in
the customizer, depending on whether the user is editing menus or managing
locations.

Props rabmalin for initial patch.
Fixes #32852.


Built from https://develop.svn.wordpress.org/trunk@33112


git-svn-id: http://core.svn.wordpress.org/trunk@33083 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 17:49:24 +00:00
Konstantin Obenland ee9cb55e1a Respect the special case of having only one theme.
If there is only one theme, the Pointer won't show and the overlay is active by
default. In that case the overlay covered submenu flyouts, after [33068].
Without the Pointer active, there is no need to bump the `z-index`, so it can
remain at 10.

Fixes #31544.


Built from https://develop.svn.wordpress.org/trunk@33111


git-svn-id: http://core.svn.wordpress.org/trunk@33082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 17:14:25 +00:00
Dominik Schilling 92fe9c9649 Transients: If `get_option( $transient_timeout )` returns false, don't bother trying to delete the transient in `get_transient()`.
props jamesgol, ericmann.
fixes #30380.
Built from https://develop.svn.wordpress.org/trunk@33110


git-svn-id: http://core.svn.wordpress.org/trunk@33081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 16:45:26 +00:00
Helen Hou-Sandí acad0e2008 Better styling for `.form-invalid` inputs.
props liljimmi.
fixes #32490.

Built from https://develop.svn.wordpress.org/trunk@33109


git-svn-id: http://core.svn.wordpress.org/trunk@33080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 16:41:25 +00:00
Dominik Schilling 7bbf64a2b9 Dashicons: Update to the latest files.
New icons:
* .dashicons-admin-customizer (f540)
* .dashicons-admin-multisite (f541)
* .dashicons-editor-table (f535)
* .dashicons-filter (f536)
* .dashicons-hidden (f530)
* .dashicons-image-filter (f533)
* .dashicons-image-rotate (f531)
* .dashicons-layout (f538)
* .dashicons-sticky (f537)
* .dashicons-thumbs-down (f542)
* .dashicons-thumbs-up (f529)
* .dashicons-unlock (f528)
* .dashicons-warning (f534)

Updated icons:
* .dashicons-plus (f132)
* .dashicons-yes (f147)

props liljimmi, melchoyce, empireoflight.
fixes #30902.
Built from https://develop.svn.wordpress.org/trunk@33108


git-svn-id: http://core.svn.wordpress.org/trunk@33079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 16:03:26 +00:00
Helen Hou-Sandí e5c6186dd4 Menu customizer: Ensure item type doesn't collide with the handle focus glow.
props andg, metodiew.
fixes #32813.

Built from https://develop.svn.wordpress.org/trunk@33107


git-svn-id: http://core.svn.wordpress.org/trunk@33078 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:52:25 +00:00
Helen Hou-Sandí 0b046085ae Show row actions on focus for the dashboard comment list.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@33106


git-svn-id: http://core.svn.wordpress.org/trunk@33077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:26:24 +00:00
Helen Hou-Sandí 958cde5134 List tables: Ensure special CSS for the title column gets applied.
This could have some side effects if a custom list table has a title column with a strong element inside that is not the post title, but that is fairly edge and we can address that if it comes up. Also moves the rules into `list-tables.css`.

see #25408.

Built from https://develop.svn.wordpress.org/trunk@33105


git-svn-id: http://core.svn.wordpress.org/trunk@33076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:21:25 +00:00
Helen Hou-Sandí 81c2f541b0 List tables: Add a fallback for the primary column.
Without a primary column defined, nothing shows in the responsive view at all, which is bad.

props mordauk.
see #25408.

Built from https://develop.svn.wordpress.org/trunk@33104


git-svn-id: http://core.svn.wordpress.org/trunk@33075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 15:12:27 +00:00
Dion Hulse ffb1de37ae Ensure that Custom Links in menu's are marked as current regardless of their scheme.
Props McGuive7, marsjaninzmarsa.
Fixes #32221

Built from https://develop.svn.wordpress.org/trunk@33103


git-svn-id: http://core.svn.wordpress.org/trunk@33074 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 09:57:26 +00:00
Boone Gorges 9e7a2f930e Use `assertEqualSets()` in `WP_Query::parse_tax_query()` tests.
Props ocean90.
See #32454.
Built from https://develop.svn.wordpress.org/trunk@33102


git-svn-id: http://core.svn.wordpress.org/trunk@33073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 00:58:24 +00:00
Helen Hou-Sandí df220685a0 List tables: Account for comments being reused on the post edit screen.
Adding the `.wp-list-table` class gets us a few responsive goodies for free. And now it won't show a strange button outline.

see #32395.

Built from https://develop.svn.wordpress.org/trunk@33101


git-svn-id: http://core.svn.wordpress.org/trunk@33072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 00:09:24 +00:00
Jeremy Felt c9027b00ba Assign proper active class when showing plugin updates in network admin
Previously, a plugin would trigger an active class if it was active on the network's main site.

Fixes #32901.

Built from https://develop.svn.wordpress.org/trunk@33100


git-svn-id: http://core.svn.wordpress.org/trunk@33071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-07 00:02:24 +00:00
Helen Hou-Sandí 2d6edf0fe8 List tables: Get rid of double borders for plugins and themes on narrow screens.
see #32395.

Built from https://develop.svn.wordpress.org/trunk@33099


git-svn-id: http://core.svn.wordpress.org/trunk@33070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 23:49:24 +00:00
Helen Hou-Sandí 6fff730706 List tables: Ensure the no items message appears on narrow screens.
fixes #32900. see #32395.

Built from https://develop.svn.wordpress.org/trunk@33098


git-svn-id: http://core.svn.wordpress.org/trunk@33069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 23:30:24 +00:00
Jeremy Felt 3faebf40a6 Remove unused `$current_site` global in MS Sites list table
Found itself unused after [32719].

See #32434.

Built from https://develop.svn.wordpress.org/trunk@33097


git-svn-id: http://core.svn.wordpress.org/trunk@33068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 22:51:25 +00:00
Konstantin Obenland c9a29b0123 Check for all required caps before (un)sticking a post.
In cases where a user has the `edit_others_posts` capability but not
`publish_posts`, it was possible for that user to unstick a post after editing,
since the input field was never made available in that context.

Props ericmann, chriscct7.
Fixes #24153.


Built from https://develop.svn.wordpress.org/trunk@33096


git-svn-id: http://core.svn.wordpress.org/trunk@33067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 22:41:25 +00:00
Boone Gorges 2096b451c7 In `WP_Query::parse_tax_query()`, allow taxonomy querystring to be formatted as an array.
Props Veraxus.
Fixes #32454.
Built from https://develop.svn.wordpress.org/trunk@33095


git-svn-id: http://core.svn.wordpress.org/trunk@33066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 20:37:24 +00:00
Weston Ruter a62cc940ea Customizer: Register controls and settings for `nav_menu_locations` even when there are no menus yet.
This change ensures that the first menu created can be assigned to a location without first saving and reloading the Customizer.

Props markoheijnen.
Fixes #32858.

Built from https://develop.svn.wordpress.org/trunk@33094


git-svn-id: http://core.svn.wordpress.org/trunk@33065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 19:13:25 +00:00
Lance Willett 7b7fe01f76 Twenty Fifteen: don't hyphenate input elements. Fixes #32880.
Built from https://develop.svn.wordpress.org/trunk@33093


git-svn-id: http://core.svn.wordpress.org/trunk@33064 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 18:03:25 +00:00
Konstantin Obenland ae2cafe1e1 Twenty Fifteen: Display sidebar background color with Header Image.
If the header image has a transparent background, the sidebar background color
should be visible. With the `background` shorthand it could never be over set
on the front-end however.

Props valendesigns.
Fixes #31460.


Built from https://develop.svn.wordpress.org/trunk@33092


git-svn-id: http://core.svn.wordpress.org/trunk@33063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 17:27:26 +00:00
Scott Taylor c65b89be19 In `wp.media.model.Attachments.filters.type()`, return `true` earlier if `type` isn't set.
Props vivekbhusal.
Fixes #32746.

Built from https://develop.svn.wordpress.org/trunk@33091


git-svn-id: http://core.svn.wordpress.org/trunk@33062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 15:34:26 +00:00
Sergey Biryukov fa1b659d29 Merge two `class` attributes in `WP_Customize_Media_Control::content_template()` and `wp_print_media_templates()`.
props nicholas_io.
fixes #32896.
Built from https://develop.svn.wordpress.org/trunk@33090


git-svn-id: http://core.svn.wordpress.org/trunk@33061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 14:19:26 +00:00
Weston Ruter a3c1814cc2 Customizer: Ensure that a newly-added nav menu item gets the Original link populated in its control.
Props valendesigns.
Fixes #32858.


Built from https://develop.svn.wordpress.org/trunk@33089


git-svn-id: http://core.svn.wordpress.org/trunk@33060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-06 05:53:26 +00:00
Andrew Ozz b2e725eb27 Fix opening closed widget areas when dragging a widget over them.
Props polevaultweb. Fixes #13524.
Built from https://develop.svn.wordpress.org/trunk@33088


git-svn-id: http://core.svn.wordpress.org/trunk@33059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-05 18:20:24 +00:00
Sergey Biryukov c543f98ee6 Plugins list table: Add an `aria-label` attribute with the plugin name to plugin action links to provide context for screen reader users.
props bramd, rianrietveld, afercia.
fixes #26167.
Built from https://develop.svn.wordpress.org/trunk@33087


git-svn-id: http://core.svn.wordpress.org/trunk@33058 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-05 15:03:25 +00:00
Konstantin Obenland 72ae151dfd Remove deprecated constructor notice.
Since Twenty Eleven can be used with WordPress releases prior to 4.3, it can't
contain calls to functions that were introduced after its initial release.

Props ocean90.
Fixes #32881.


Built from https://develop.svn.wordpress.org/trunk@33086


git-svn-id: http://core.svn.wordpress.org/trunk@33057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 20:43:25 +00:00
Konstantin Obenland cc43eae995 Deprecate PHP4 style contructor in Twenty Eleven's Ephemera widget.
See #31982.

Props Frank Klein.
Fixes #32881.


Built from https://develop.svn.wordpress.org/trunk@33085


git-svn-id: http://core.svn.wordpress.org/trunk@33056 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 20:29:23 +00:00
Konstantin Obenland 664b0373dc Site Icon: Switch to using H1 headings.
See #31650.

Props afercia.
Fixes #32885.


Built from https://develop.svn.wordpress.org/trunk@33084


git-svn-id: http://core.svn.wordpress.org/trunk@33055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 18:49:27 +00:00
Jeremy Felt eee4049c92 Usernames in multisite should be restricted to 60 characters or fewer.
Only 60 characters can be stored in the database for a username, which could cause lookup issues when attempting to use similar usernames of extreme length.

Props @DJPaul.
See #17904, Fixes #26784.

Built from https://develop.svn.wordpress.org/trunk@33083


git-svn-id: http://core.svn.wordpress.org/trunk@33054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 05:53:24 +00:00
Jeremy Felt 67142f5a2f Don't autocapitalize or autocorrect domain or path when adding a new site in iOS.
Props @ohryan.
Fixes #32646.

Built from https://develop.svn.wordpress.org/trunk@33082


git-svn-id: http://core.svn.wordpress.org/trunk@33053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 04:40:25 +00:00
Jeremy Felt 767ed1e9b1 Use the full site URL in `choose_primary_blog()` when a user is a member of only one site.
Aligns with the output used when a user is a member of multiple sites.

Fixes #32884.

Built from https://develop.svn.wordpress.org/trunk@33081


git-svn-id: http://core.svn.wordpress.org/trunk@33052 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 04:21:24 +00:00
Jeremy Felt 5ab785b054 Only output Save Changes in My Sites when a user is a member of more than one site.
The conditional also checks for the existence of filters that may otherwise alter the HTML in My Sites to include extra form inputs for these users. If a filter is in use, the Save Changes button will display.

Props @Oxymoron, @obenland.
Fixes #32645.

Built from https://develop.svn.wordpress.org/trunk@33080


git-svn-id: http://core.svn.wordpress.org/trunk@33051 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 04:01:26 +00:00
Sergey Biryukov ddff6fe471 Don't capitalize words in a sentence after comma.
props bjornjohansen, netweb.
fixes #31927.
Built from https://develop.svn.wordpress.org/trunk@33079


git-svn-id: http://core.svn.wordpress.org/trunk@33050 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-04 00:50:25 +00:00
Sergey Biryukov bcc1670ed6 Customizer: Remove HTML tags from two translatable strings.
props henrikakselsen.
fixes #32817.
Built from https://develop.svn.wordpress.org/trunk@33078


git-svn-id: http://core.svn.wordpress.org/trunk@33049 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 22:29:25 +00:00
Dominik Schilling 340f1e121e Customizer: Fix `tabindex` of reorder buttons for menu items with depth 1 and 10.
props celloexpressions.
fixes #32767.
Built from https://develop.svn.wordpress.org/trunk@33077


git-svn-id: http://core.svn.wordpress.org/trunk@33048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 22:21:24 +00:00
Sergey Biryukov b2299463b6 Plugins list table: Use case-insensitive sorting.
props GaryJ.
fixes #32735.
Built from https://develop.svn.wordpress.org/trunk@33076


git-svn-id: http://core.svn.wordpress.org/trunk@33047 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:53:25 +00:00
Konstantin Obenland cf22cd7d72 Site Icon: Remove date dropdown from media modal.
This also allows us to leverage the builtin `suggestedWidth` and
`suggestedHeight` parameters to convey the expected image size.

Props ocean90.
Fixes #32860.


Built from https://develop.svn.wordpress.org/trunk@33075


git-svn-id: http://core.svn.wordpress.org/trunk@33046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-07-03 21:28:24 +00:00