Commit Graph

138 Commits

Author SHA1 Message Date
Scott Taylor e87150fc06 Comments List Table: after [34179], scope the `<th>`s and `<td>`s as direct descendants of their parent row.
Fixes #33943.

Built from https://develop.svn.wordpress.org/trunk@34527


git-svn-id: http://core.svn.wordpress.org/trunk@34491 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-25 02:21:26 +00:00
Scott Taylor 44822831fe Comments List Table JS: move the dynamic count functions into closure scope so that `setCommentsList` AND `commentReply` can access them. Update counts when replying inline.
Fixes #33403.

Built from https://develop.svn.wordpress.org/trunk@34517


git-svn-id: http://core.svn.wordpress.org/trunk@34481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 20:16:49 +00:00
Scott Taylor 4671e03766 Comments List Table: include count for "All". Dynamically update.
Fixes #17275.

Built from https://develop.svn.wordpress.org/trunk@34506


git-svn-id: http://core.svn.wordpress.org/trunk@34470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 17:57:25 +00:00
Scott Taylor 5b9af35c4c Comments: update Comment counts dynamically in the Right Now widget based on moderation actions in the Activity widget.
Fixes #10422.

Built from https://develop.svn.wordpress.org/trunk@34500


git-svn-id: http://core.svn.wordpress.org/trunk@34464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-24 15:53:25 +00:00
Sergey Biryukov 80165bfc4a Comments: When setting the `colspan` value for inline edit/reply, make sure it's actually a table and the value is not empty.
Props afercia.
Fixes #33596.
Built from https://develop.svn.wordpress.org/trunk@34179


git-svn-id: http://core.svn.wordpress.org/trunk@34147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 13:44:34 +00:00
Scott Taylor 387f271ea5 After [34070], account for the new ID in Quick Edit JS.
Props afercia.
Fixes #33770.

Built from https://develop.svn.wordpress.org/trunk@34159


git-svn-id: http://core.svn.wordpress.org/trunk@34127 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-15 01:31:26 +00:00
Helen Hou-Sandí 7f772bdaff Comments: Fix inline edit/reply on small screens.
props ocean90, SergeyBiryukov.
fixes #33596.

Built from https://develop.svn.wordpress.org/trunk@34094


git-svn-id: http://core.svn.wordpress.org/trunk@34062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-13 12:47:27 +00:00
Scott Taylor bbbbf11961 After [33821], when dynamically updating the document title text of the Comments List Table page, operate only on the fragment that contains the comment count. This prevents us from including other numbers that may be present in the other title parts (site title, etc).
See #33414.

Built from https://develop.svn.wordpress.org/trunk@33982


git-svn-id: http://core.svn.wordpress.org/trunk@33951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-10 01:03:25 +00:00
Scott Taylor 7808d5d1fa Comments: dynamically update the document title text of the Comments List Table page when dynamically updating the number of comments awaiting moderation.
Fixes #33414. 

Built from https://develop.svn.wordpress.org/trunk@33821


git-svn-id: http://core.svn.wordpress.org/trunk@33789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-31 17:58:22 +00:00
Scott Taylor fa2d0a2d55 Comment List Tables:
* Toggle visibility of pending bubble when a comment is dynamically moderated
* Add a CSS class to the pending bubble to hide it / remove to show it

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33692


git-svn-id: http://core.svn.wordpress.org/trunk@33659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-21 17:26:26 +00:00
Scott Taylor d65112d382 After [33662], remove unused var.
See #11200.

Built from https://develop.svn.wordpress.org/trunk@33663


git-svn-id: http://core.svn.wordpress.org/trunk@33630 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 17:19:25 +00:00
Scott Taylor 20f6db2b18 Comment List Tables:
* Ensure that dynamic bubble counts are in sync by `comment_post_ID`
* Scope `:animated` to `#the-comment-list`

See #11200.


Built from https://develop.svn.wordpress.org/trunk@33662


git-svn-id: http://core.svn.wordpress.org/trunk@33629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 16:36:25 +00:00
Scott Taylor 0e4606c13e JSHint after [33655].
Built from https://develop.svn.wordpress.org/trunk@33660


git-svn-id: http://core.svn.wordpress.org/trunk@33627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 06:31:25 +00:00
Scott Taylor 2e2223ae74 Comments List Table:
* In a view that initially has comments, but they get removed due to user actions: show the `No Items` row instead of bombing out and showing nothing (which looks broken)
* To accomplish this, in `WP_Comments_List_Table::display()`: call `->display_rows_or_placeholder()` instead of `->display()`
* Listen for the end of row `.fadeOut()`s if necessary using jQuery Promises

Fixes #11200.

Built from https://develop.svn.wordpress.org/trunk@33657


git-svn-id: http://core.svn.wordpress.org/trunk@33624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 05:54:25 +00:00
Scott Taylor 657d0f6918 Comments List Table:
* Properly increment/decrement approved/pending bubbles in `response` column

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33656


git-svn-id: http://core.svn.wordpress.org/trunk@33623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 04:02:24 +00:00
Scott Taylor df618f3461 Comments List Table:
* Show count next to "Approved"
* Properly increment/decrement counts when row actions are clicked
* In `_wp_ajax_delete_comment_response()`, return the comment's `status` with the `supplemental` data
* Handle counts properly on each scenario of `undo`

See #11200.

Built from https://develop.svn.wordpress.org/trunk@33655


git-svn-id: http://core.svn.wordpress.org/trunk@33622 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-08-20 02:51:25 +00:00
Konstantin Obenland 4e7c057a5a Check that current changes can be lost before editing another comment.
When replying to or editing a comment, double-clicking another comment will
open it in quick edit and changes to the current comment are lost.

Props pareshradadiya, chriscct7.
Fixes #21845.


Built from https://develop.svn.wordpress.org/trunk@32857


git-svn-id: http://core.svn.wordpress.org/trunk@32828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-06-19 13:48:25 +00:00
Andrew Ozz fe427017a5 Fix comments postbox:
- Add comment button text.
- Positioning of the Author, Email, URL fields.
Fixes #32349.
Built from https://develop.svn.wordpress.org/trunk@32495


git-svn-id: http://core.svn.wordpress.org/trunk@32465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-05-12 01:22:25 +00:00
Helen Hou-Sandí 3ac1a19529 Spinners: Toggle a class instead of show/hide.
Toggling spinners also now uses visibility instead of display, so that the space is always reserved and nothing moves around unexpectedly.

props cdog, MikeHansenMe, valendesigns.
fixes #22839. see #31875, #30725.

Built from https://develop.svn.wordpress.org/trunk@31996


git-svn-id: http://core.svn.wordpress.org/trunk@31975 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-03 04:52:27 +00:00
Sergey Biryukov cd2e63700e Use a more specific selector for comment moderation hotkeys after [31513].
props afercia.
fixes #31545.
Built from https://develop.svn.wordpress.org/trunk@31929


git-svn-id: http://core.svn.wordpress.org/trunk@31908 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-30 13:54:26 +00:00
Scott Taylor 6ffa051689 Replace flagrant instances of `.html('')` with `.empty()`.
Props OriginalEXE, SergeyBiryukov.
Fixes #27034.

Built from https://develop.svn.wordpress.org/trunk@31690


git-svn-id: http://core.svn.wordpress.org/trunk@31671 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-09 19:44:26 +00:00
Helen Hou-Sandí b80c5d3e51 Comments: Simplify JS for inline edit and reply.
fixes #27533.

Built from https://develop.svn.wordpress.org/trunk@29662


git-svn-id: http://core.svn.wordpress.org/trunk@29436 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-02 03:57:18 +00:00
Scott Taylor 396e77b643 Use unobtrusive JS for Comment list table row actions.
Props aubreypwd.
Fixes #27533.

Built from https://develop.svn.wordpress.org/trunk@28810


git-svn-id: http://core.svn.wordpress.org/trunk@28618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-23 23:55:16 +00:00
Scott Taylor d4e46e3f8d Fix double avatars and JS errors when spamming/trashing comments.
Props avryl, SergeyBiryukov.
Fixes #27329.
 

Built from https://develop.svn.wordpress.org/trunk@27759


git-svn-id: http://core.svn.wordpress.org/trunk@27596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-26 23:14:15 +00:00
Andrew Nacin 6adabc6e4d Various JSHint fixes. see #26446.
Built from https://develop.svn.wordpress.org/trunk@27131


git-svn-id: http://core.svn.wordpress.org/trunk@26998 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-08 00:52:12 +00:00
Andrew Ozz 2a68f85fa1 Comment moderation shortcuts:
- Fix "toggle checkboxes" (shift+x).
- Add noDisable selector and use it to stop disabling the shortcuts when a select-comment checkbox is focused.
See #26755.
Built from https://develop.svn.wordpress.org/trunk@26889


git-svn-id: http://core.svn.wordpress.org/trunk@26772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-02 00:11:14 +00:00
Andrew Ozz fda55bd33b Comments moderation screen:
- Don't resize the textarea when replying to long comments.
- Limit the resizing of the textarea when quick-editing long comments to 500px.
Props SergeyBiryukov, fixes #25746.
Built from https://develop.svn.wordpress.org/trunk@26550


git-svn-id: http://core.svn.wordpress.org/trunk@26442 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-03 00:55:10 +00:00
Andrew Nacin d7423a466e Residual JSHint fixes in common.js and edit-comments.js.
see #25912, #25979.

Built from https://develop.svn.wordpress.org/trunk@26208


git-svn-id: http://core.svn.wordpress.org/trunk@26116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 06:37:09 +00:00
Andrew Nacin 97eff9117b JSHint: Make commentReply a declared global from elsewhere.
props adamsilverstein.
see #25979, [26156].

Built from https://develop.svn.wordpress.org/trunk@26157


git-svn-id: http://core.svn.wordpress.org/trunk@26068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 05:30:09 +00:00
Andrew Nacin 47559f45bf Avoid jshint errors in edit-comment.js.
props adamsilverstein.
fixes #25979.

Built from https://develop.svn.wordpress.org/trunk@26156


git-svn-id: http://core.svn.wordpress.org/trunk@26067 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-14 05:10:10 +00:00
Dominik Schilling c2739d12cc Trim leading whitespace from AJAX responses.
This fixes the warning "$(html) HTML strings must start with '<' character" by jQuery Migrate when adding nav menu items, post custom fields or comment replies.

fixes #23681.
Built from https://develop.svn.wordpress.org/trunk@25546


git-svn-id: http://core.svn.wordpress.org/trunk@25466 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-21 10:51:09 +00:00
Andrew Ozz cbd737470c Kill use of colons in class names, props SergeyBiryukov, fixes #21152
git-svn-id: http://core.svn.wordpress.org/trunk@22396 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-06 01:01:52 +00:00
Andrew Nacin 1acd8b556f New HiDPI spinner. Uses clean <span class="spinner"></span> markup.
Be on the lookout for weirdness.
props lessbloat. see #21456.



git-svn-id: http://core.svn.wordpress.org/trunk@22019 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-26 19:57:44 +00:00
Andrew Nacin 2710bcade1 Switch to .min for compressed JS and CSS files.
* This moves our "development" versions from .dev.js to .js (same for css).
 * The compressed version then moves from .js to .min.js (same for css).

By switching to the standard .min convention, it sets expectations for developers,
and works nicely with existing tools such as ack.

fixes #21633.



git-svn-id: http://core.svn.wordpress.org/trunk@21592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-23 00:04:18 +00:00
bumpbot 539bffd7fa Compress scripts/styles: 3.4-beta2-20536.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-19 14:58:27 +00:00
bumpbot 3bf6b4ab5a Compress scripts/styles: 3.4-alpha-20165.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20165 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-09 01:45:40 +00:00
bumpbot 570a54053f Compress scripts/styles: 3.4-alpha-19896.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19896 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-09 23:30:50 +00:00
bumpbot f9f2bb6bd9 Compress scripts/styles: 3.4-alpha-19805.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-01 14:43:00 +00:00
nacin 212e7bfc01 '3.4-alpha-19618'
git-svn-id: http://svn.automattic.com/wordpress/trunk@19618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-21 04:22:21 +00:00
duck_ 5e3fe22bac Allow "Approve and Reply" background-color animation to complete on the Dashboard. Props ocean90. Fixes #18349.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19298 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-15 17:57:53 +00:00
duck_ 7ba5b2f7a3 Stop an incorrect comment total being displayed when a trashed/spammed comment is deleted or restored. Fixes #19029.
Also only run getUpdate() when necessary and remove reference to non-existent "span.total-type-count".


git-svn-id: http://svn.automattic.com/wordpress/trunk@19068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-26 08:47:16 +00:00
azaozz d58e337d24 Use WP_Editor when editing or replying to comments, props ocean90, remove vendor specific selectors from editor-buttons.css, fixes #18348, see #17144
git-svn-id: http://svn.automattic.com/wordpress/trunk@18803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-28 21:07:08 +00:00
duck_ 6841d365e5 Don't hide the comment reply or quick edit row if an error is returned. Props ocean90. Fixes #18350.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18650 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-07 19:48:25 +00:00
azaozz 6041cd0410 Fix QTags.closeAllTags(), replace 'tb' with 'ed' in quicktags,js to make it clear it is the editor instance not the toolbar, small comments quick edit fixes, see #16695, fixes #15911
git-svn-id: http://svn.automattic.com/wordpress/trunk@18576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-20 19:55:51 +00:00
azaozz 042a03f384 Fix back-compat for quicktags, introduce QTags.addButton(), see #16695
git-svn-id: http://svn.automattic.com/wordpress/trunk@18511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-05 04:09:22 +00:00
azaozz 3713abe855 Remove debug remnants, props scribu, see #16695
git-svn-id: http://svn.automattic.com/wordpress/trunk@18499 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-03 10:36:18 +00:00
azaozz 230fb8f3e3 Refactor Quicktags, props garyc40, see #16695
git-svn-id: http://svn.automattic.com/wordpress/trunk@18497 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-03 10:11:12 +00:00
ryan 15a6a89eb0 Validation fixes. Props ocean90, xknown. fixes #17364
git-svn-id: http://svn.automattic.com/wordpress/trunk@18114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-02 17:05:55 +00:00
azaozz b6fff6534a Fix background color for approved comments, props DH-Shredder, fixes #17405
git-svn-id: http://svn.automattic.com/wordpress/trunk@18065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-28 02:30:04 +00:00
azaozz 65f9c441a7 Replace .attr() with .prop() as per jQuery 1.6.1. Also fixes couple places where the JS wasn't working because attr('some', '') does not remove the HTML property now, see #17311
git-svn-id: http://svn.automattic.com/wordpress/trunk@18027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-25 01:04:12 +00:00