f4f2116edd
Be sure to force-delete when cleaning up fixtures in `get_comment_link()` tests.
...
Introduced in [35857].
Mega-super-anti-props boonebgorges.
Built from https://develop.svn.wordpress.org/trunk@35858
git-svn-id: http://core.svn.wordpress.org/trunk@35822 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 02:47:25 +00:00
cef6eee086
Share fixtures in `get_comment_link()` tests.
...
See #30017 .
Built from https://develop.svn.wordpress.org/trunk@35857
git-svn-id: http://core.svn.wordpress.org/trunk@35821 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-11 02:27:27 +00:00
6fb81e3338
L10n: Use an absolute path for the `is_dir()` check when looking for installed translations.
...
Avoids warnings when `open_basedir` restrictions are in effect.
Props Profforg.
Fixes #34526 .
Built from https://develop.svn.wordpress.org/trunk@35856
git-svn-id: http://core.svn.wordpress.org/trunk@35820 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 23:09:27 +00:00
81b70b5af7
Updates screen: make the new strings introduced in [35854] translatable.
...
Props walbo.
Fixes #34763 .
Built from https://develop.svn.wordpress.org/trunk@35855
git-svn-id: http://core.svn.wordpress.org/trunk@35819 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 19:24:26 +00:00
984e1321ba
Accessibility: the iframes used for the update progress in the Updates screen need title attributes to describe their content.
...
Fixes #34763 .
Built from https://develop.svn.wordpress.org/trunk@35854
git-svn-id: http://core.svn.wordpress.org/trunk@35818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 17:21:29 +00:00
9dd574bd99
Comments: Comments don’t need no Post ID when created, so they don’t be needing one to be edited.
...
In `wp_update_comment()` only check if the given `comment_post_ID` is valid if it isn’t `0`. This allows comments that were created programmatically via `wp_insert_comment()` without the (optional) `comment_post_ID` parameter to be edited.
Props subharanjan for the initial patch.
Fixes #34954
Built from https://develop.svn.wordpress.org/trunk@35853
git-svn-id: http://core.svn.wordpress.org/trunk@35817 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 15:17:29 +00:00
812060f940
Improve handling for `WP_Error` objects in `get_the_terms()`.
...
`wp_get_object_terms()` can return a `WP_Error` object. As such, the
`get_the_terms()` cache wrapper should handle them properly. To wit:
* Don't try to map an error object to `get_term()`. Introduced in [35032].
* Don't cache an error object as taxonomy relationships. Introduced in at least [16487], maybe earlier.
Props stephenharris.
Fixes #34723 .
Built from https://develop.svn.wordpress.org/trunk@35850
git-svn-id: http://core.svn.wordpress.org/trunk@35814 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 03:35:27 +00:00
6fd3c9fc64
Comments: Commit tests missed in [35848].
...
See #28617
Built from https://develop.svn.wordpress.org/trunk@35849
git-svn-id: http://core.svn.wordpress.org/trunk@35813 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 03:16:25 +00:00
a027edc277
Comments: The year is 2003. Permalinks are a new thing and everyone's using Blogger. It's a time when opening a modal window in JavaScript to view a section of a website is not a completely weird thing, although many users get annoyed by it. b2 has recently become WordPress, and with it comes a bunch of functionality that will become stale over the next decade, remnants of simpler times.
...
Twelve years later, after no fewer than three themes have intentionally implemented popup comments in their functionality, before being abandoned for at least the last six years, we've reached a time where we can put this era behind us. A time when we can remove comment popup functionality from WordPress.
If this breaks the internet, I'll eat my hat.
Fixes #28617
Built from https://develop.svn.wordpress.org/trunk@35848
git-svn-id: http://core.svn.wordpress.org/trunk@35812 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-10 03:06:30 +00:00
8826804952
Formatting: Don't make links inside `<script>` and `<style>` tags clickable.
...
Fixes #30162
Props ninos-ego, adamsilverstein
Built from https://develop.svn.wordpress.org/trunk@35847
git-svn-id: http://core.svn.wordpress.org/trunk@35811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 23:55:32 +00:00
2ae5db3856
Accessibility: remove no-purpose title attributes from the login screen.
...
Also, it's hard to convey the ironic tone of the sentences used for these title attributes in languages other than English.
Fixes #34943 .
Built from https://develop.svn.wordpress.org/trunk@35846
git-svn-id: http://core.svn.wordpress.org/trunk@35810 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 22:20:29 +00:00
17061829e4
Docs: Better param descriptions and fix incorrect param name within REST API deprecated functions
...
`rest_handle_deprecated_function`: you get better parameter descriptions.
`rest_handle_deprecated_argument`: you get a corrected parameter name ($replacement->$message), appropriate i18n translation hints, and better parameter descriptions.
Props ocean90.
Fixes #34908
Built from https://develop.svn.wordpress.org/trunk@35845
git-svn-id: http://core.svn.wordpress.org/trunk@35809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 21:26:29 +00:00
a4cd391d50
Docs: Move the hook doc for the `view_mode_post_types` filter to directly precede the `apply_filters()` line.
...
See #32246 .
Built from https://develop.svn.wordpress.org/trunk@35844
git-svn-id: http://core.svn.wordpress.org/trunk@35808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-09 16:17:27 +00:00
7551362d57
About Page: Add release video and update post embed.
...
Props camikaos, siobhan, rosso99, wonderboymusic.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35839
git-svn-id: http://core.svn.wordpress.org/trunk@35803 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 23:23:26 +00:00
ba4a508daf
Install/Upgrade: Keep indexing bots away until a site is ready to be seen.
...
Built from https://develop.svn.wordpress.org/trunk@35837
git-svn-id: http://core.svn.wordpress.org/trunk@35801 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 21:56:27 +00:00
f642373090
About Page: use ReverbNation instead of Cloudup to avoid Ad Blocker cruff with tracking pixels. Adjust the layout accordingly, and improve the layout at smaller breakpoints.
...
Props melchoyce.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35834
git-svn-id: http://core.svn.wordpress.org/trunk@35798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 20:25:28 +00:00
dc7ff95661
About Page: Remove three superfluous parentheses.
...
Props jaspermdegroot.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35833
git-svn-id: http://core.svn.wordpress.org/trunk@35797 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 18:15:26 +00:00
d5475667b0
About Page: Use w.org CDN for images.
...
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35832
git-svn-id: http://core.svn.wordpress.org/trunk@35796 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 17:57:26 +00:00
d23bd49fdd
Administration: Adds a height to number inputs.
...
Number inputs didn't match the height of other form elements. Now they have a height of 28px and 40px on mobile. Both align with the sizes of other elements.
Props valendesigns.
Fixes #28984 .
Built from https://develop.svn.wordpress.org/trunk@35831
git-svn-id: http://core.svn.wordpress.org/trunk@35795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 16:07:25 +00:00
1b41572d4c
Bundled Themes: Update POT files.
...
See #34804 .
Built from https://develop.svn.wordpress.org/trunk@35829
git-svn-id: http://core.svn.wordpress.org/trunk@35793 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 15:18:28 +00:00
1b60538074
About Page: use the source of the Make/Core Embed response instead of discovering it (or reading from the cache) every time.
...
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35826
git-svn-id: http://core.svn.wordpress.org/trunk@35790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 03:38:24 +00:00
932195771f
About Page: use `srcset` for images, also known as Recursive Dogfooding.
...
Props joemcgill.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35825
git-svn-id: http://core.svn.wordpress.org/trunk@35789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-08 03:33:27 +00:00
b3a00ca1e9
About Page: Add Cloudup embed and cache the embeds as site transients.
...
Props wonderboymusic.
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35823
git-svn-id: http://core.svn.wordpress.org/trunk@35787 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 23:28:25 +00:00
55bb9a8c01
REST API: Make strings translatable in `register_rest_route`.
...
Adds i18n to the `doing_it_wrong()` messages for invalid parameters within `register_rest_route()`.
Props Latz,danielbachhuber.
Fixes #34902
Built from https://develop.svn.wordpress.org/trunk@35822
git-svn-id: http://core.svn.wordpress.org/trunk@35786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 22:40:27 +00:00
6f3da8d57b
Media: Don't generate responsive image attributes if `src` does not match ID in `wp-image-` class.
...
We rely on the `wp-image-` class to quickly find an attachment ID to add responsive image attributes.
To avoid incorrect images being displayed, do not add these attributes if the `src` does not match the
meta from the attachment ID in the class.
Props azaozz, kovshenin, joemcgill.
Fixes : #34898 .
Built from https://develop.svn.wordpress.org/trunk@35820
git-svn-id: http://core.svn.wordpress.org/trunk@35784 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 20:08:51 +00:00
3c0c5e6ad5
List Tables: Revert [34728] and [35482].
...
Part of [34728] was already reverted in [35682], but the default values still made it impossible to set a default ordering for custom post types.
See #25493 .
See #34825 .
Built from https://develop.svn.wordpress.org/trunk@35818
git-svn-id: http://core.svn.wordpress.org/trunk@35782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 19:16:26 +00:00
5031ca5c23
Prevent unnecessary $wpdb->update() when hierarchical post doesn't have children.
...
Props danielbachhuber.
Fixes #34896 .
Built from https://develop.svn.wordpress.org/trunk@35817
git-svn-id: http://core.svn.wordpress.org/trunk@35781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 17:47:25 +00:00
b6a14367e4
About: Update image of the Twenty Sixteen red color scheme so it matches the updated scheme color.
...
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35816
git-svn-id: http://core.svn.wordpress.org/trunk@35780 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 17:08:25 +00:00
331fdaf184
Docs: After [35314], fix the DocBlock for `url_shorten()`.
...
See #20166 .
Built from https://develop.svn.wordpress.org/trunk@35813
git-svn-id: http://core.svn.wordpress.org/trunk@35777 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 16:39:25 +00:00
ef223adbdb
About: Sync tagline from about page with credits and freedoms.
...
See #34663 .
Built from https://develop.svn.wordpress.org/trunk@35812
git-svn-id: http://core.svn.wordpress.org/trunk@35776 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 16:17:27 +00:00
657d3b50af
Make date format consistent across the admin
...
The 'date_format' and 'time_format' options shouldn't affect the backend.
See #30864
Built from https://develop.svn.wordpress.org/trunk@35811
git-svn-id: http://core.svn.wordpress.org/trunk@35775 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-07 04:26:27 +00:00
07339e61c0
Customizer: Apply `customize_dynamic_setting_class` and `customize_dynamic_setting_args` filters in calls to `WP_Customize_Manager::add_setting( $id, $args )`.
...
Ensure that plugin filters apply as expected for any settings registered statically without passing in an explicit class instance to `WP_Customize_Manager::add_setting()`.
Fixes #34597 .
Built from https://develop.svn.wordpress.org/trunk@35810
git-svn-id: http://core.svn.wordpress.org/trunk@35774 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 23:22:25 +00:00
699c377856
Meta Boxes: Preserve radio inputs' state when sorting metaboxes.
...
When sorting a metabox, a clone of that metabox is created as a drag/drop "helper".
Previously, any checked radio input in the original metabox would become unchecked, when its clone "helper" was inserted into the DOM
(since only one radio within a set of radios of the same name can be checked).
Continued use of the clone helper is important so that the element being dragged isn't subject to the click and other event handlers attached to the real metabox,
so we can't just switch to dragging around the real metabox. See, for example, comment:10:ticket:16972.
Preserve the radios' state via some name attribute trickery.
Fixes #16972
Built from https://develop.svn.wordpress.org/trunk@35809
git-svn-id: http://core.svn.wordpress.org/trunk@35773 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:23:49 +00:00
83795d99be
Plugins: Provide a link to searching the plugin directory when no search results are found.
...
Many new users do not know the difference between managing installed plugins and those found in the plugin directory. This helps with discoverability. The link is not provided in multisite installs because we assume that somebody with that kind of power in a network is experienced enough not to need it. This can always be reconsidered later.
props mordauk for the initial patch.
fixes #29865 .
Built from https://develop.svn.wordpress.org/trunk@35808
git-svn-id: http://core.svn.wordpress.org/trunk@35772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:23:25 +00:00
bba9132925
Twenty Eleven/Docs: Remove duplicate "can" from footer template.
...
See #34885 .
Built from https://develop.svn.wordpress.org/trunk@35807
git-svn-id: http://core.svn.wordpress.org/trunk@35771 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:12:25 +00:00
c512f8cbdd
Docs: clarify inline docs for hash_equals
...
Before the docs implied the complexity of the function was O(1) by using the term "constant time", now we use the more descriptive term "Timing attack safe".
Props AramZS.
Fixes #32778 .
Built from https://develop.svn.wordpress.org/trunk@35805
git-svn-id: http://core.svn.wordpress.org/trunk@35769 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:04:51 +00:00
d35bc1b936
Use `site_url()` when generating `WP_CONTENT_URL` so it correctly adjusts for pages served over HTTPS. This mainly only affects old plugins which still use `WP_CONTENT_URL` instead of the newer `plugins_url()` function.
...
Fixes #13941
Props micropat
Built from https://develop.svn.wordpress.org/trunk@35804
git-svn-id: http://core.svn.wordpress.org/trunk@35768 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:04:26 +00:00
4ace55b0dc
Docs: Add proper `@param` and `@return` tags for `capital_P_dangit()`.
...
Props timplunkett.
Fixes #34863 .
Built from https://develop.svn.wordpress.org/trunk@35803
git-svn-id: http://core.svn.wordpress.org/trunk@35767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:02:27 +00:00
8d220df08b
Bundled Themes: Bump version numbers in default themes.
...
Props davidakennedy.
Fixes #34804 .
Built from https://develop.svn.wordpress.org/trunk@35802
git-svn-id: http://core.svn.wordpress.org/trunk@35766 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:01:27 +00:00
bc7950519b
Notices: improve styling consistency of links within notices.
...
For accessibility, links inside lines or blocks of text should be always underlined.
Props walbo.
Fixes #34606 .
Built from https://develop.svn.wordpress.org/trunk@35801
git-svn-id: http://core.svn.wordpress.org/trunk@35765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 22:00:26 +00:00
0e8e5124c1
Posts: Don't modify post_name if it wasn't supplied to `wp_insert_post()`.
...
Previously when updating a post using wp_insert_post(), post_name was
regenerated based on post_title every time if post_name was not passed in
explicitly. This irons out the expectation that properties not passed into the
function should not be modified.
Props jason_the_adams.
Fixes #34865 .
Built from https://develop.svn.wordpress.org/trunk@35800
git-svn-id: http://core.svn.wordpress.org/trunk@35764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:58:25 +00:00
f522e69a57
Docs: Fix a typo in the `stylesheet_directory` filter docs.
...
Props ixkaito.
Fixes #34859 .
Built from https://develop.svn.wordpress.org/trunk@35799
git-svn-id: http://core.svn.wordpress.org/trunk@35763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:57:24 +00:00
84affbd3a9
Docs: Make "list table table tag" a bit more readable.
...
See: #34885 , r35796.
Built from https://develop.svn.wordpress.org/trunk@35797
git-svn-id: http://core.svn.wordpress.org/trunk@35761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:54:26 +00:00
919867b090
Docs: Remove some more dittography.
...
See #34885 , r35793.
Built from https://develop.svn.wordpress.org/trunk@35796
git-svn-id: http://core.svn.wordpress.org/trunk@35760 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:50:25 +00:00
59351cb62d
Toolbar: Allow adding `lang` and `dir` attributes to toolbar items.
...
This is useful from a multilingual and accessibility perspective.
Props Chouby, leemon.
Fixes #33513 .
Built from https://develop.svn.wordpress.org/trunk@35795
git-svn-id: http://core.svn.wordpress.org/trunk@35759 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:37:25 +00:00
714d5885d9
Te Docs: Fix te the misspelling.
...
Previously, [35793].
Fixes #34888 .
Built from https://develop.svn.wordpress.org/trunk@35794
git-svn-id: http://core.svn.wordpress.org/trunk@35758 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:32:25 +00:00
31f51e2cbb
The the Docs: Fix the the dittography
...
Sometimes, it's easy to to type the the same word twice, especially if if it's a simple word. We probably shouldn't do do do (do do do doo) it, though.
(I've excluded external libs from this change.)
Fixes #34885 .
Built from https://develop.svn.wordpress.org/trunk@35793
git-svn-id: http://core.svn.wordpress.org/trunk@35757 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:23:25 +00:00
894526c78d
Consider both home and site domains to be valid in `wp_validate_redirect()`.
...
Props layotte.
Fixes #34028 .
Built from https://develop.svn.wordpress.org/trunk@35792
git-svn-id: http://core.svn.wordpress.org/trunk@35756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:17:24 +00:00
5eae357697
Administration: Improve color contrast of 'Add New' buttons.
...
This also includes improved focus styles for 'Add New'.
fixes #34876 , #34864 .
Built from https://develop.svn.wordpress.org/trunk@35791
git-svn-id: http://core.svn.wordpress.org/trunk@35755 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 21:07:25 +00:00
714be37ea5
Show user_login in Dashboard user dropdowns.
...
User dropdowns in wp-admin have traditionally shown the users' display names.
However, this causes ambiguity when users share display names. To correct this,
we now show the unique user_login in parentheses after the display name.
The new `display_name_with_login` value for the `show` parameter of
`wp_dropdown_users()` enables this functionality. The default value of `show`
has not been changed, for backward compatibility, but all instances of
`wp_dropdown_users()` in core wp-admin have been switched.
This changeset also reduces some duplicated logic when assembling a user list
when `include_selected` is true.
Props krogsgard, boonebgorges.
Fixes #31251 .
Built from https://develop.svn.wordpress.org/trunk@35790
git-svn-id: http://core.svn.wordpress.org/trunk@35754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-12-06 20:57:26 +00:00
Boone Gorges
Dominik Schilling
Andrea Fercia
Rachel Baker
John Blackbourn
Drew Jaynes
Scott Taylor
Michael Arestad
Mike Schroder
Joe Hoyle
Mel Choyce
Pascal Birchler
Ella Iseulde Van Dorpe
Weston Ruter
Michael Adams
Helen Hou-Sandí
Nikolay Bachiyski
Eric Lewis
Konstantin Kovshenin
Jeremy Felt
Gary Pendergast
Aaron Campbell