Commit Graph

185 Commits

Author SHA1 Message Date
Helen Hou-Sandí d85f8fe326 Admin notices: Make (most) core notices dismissible.
These no longer return upon refreshing the page when JS is on and working, so users should be able to dismiss them. This is particularly important on the post edit screen when DFW is triggered, but pretty much all notices can be dismissed if needed. A post on Make/Core will follow with information on how this can be leveraged in plugins.

props valendesigns, afercia, paulwilde, adamsilverstein, helen.
fixes #31233. see #23367.

Built from https://develop.svn.wordpress.org/trunk@31973


git-svn-id: http://core.svn.wordpress.org/trunk@31952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-01 22:06:28 +00:00
Helen Hou-Sandí 007665e7be Admin menu: Revert [31720] for swipe open/closed.
This is problematic on any device that uses swipe for history navigation, particularly iOS. It's also quite unrefined from an interaction point of view and would not be material for this release either way.

see #31187.

Built from https://develop.svn.wordpress.org/trunk@31910


git-svn-id: http://core.svn.wordpress.org/trunk@31889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-27 17:48:30 +00:00
Andrew Ozz 321b551650 Fix focusing in the plugin and theme editors. Update the help.
Props afercia, Cheffheid. Fixes #31415.
Built from https://develop.svn.wordpress.org/trunk@31908


git-svn-id: http://core.svn.wordpress.org/trunk@31887 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-26 22:35:27 +00:00
Andrew Ozz 4eba346517 Allow swiping of the admin menu on touch devices.
Props iseulde, ninnypants. See #31187.
Built from https://develop.svn.wordpress.org/trunk@31720


git-svn-id: http://core.svn.wordpress.org/trunk@31701 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-11 16:29:26 +00:00
Jeremy Felt 0f34b98bcf Reveal row actions on focus in the network users list table.
In the future, we'll re-factor this selector pile in a way that makes things cleaner. See #25408.

Props afercia.

Fixes #31003.

Built from https://develop.svn.wordpress.org/trunk@31674


git-svn-id: http://core.svn.wordpress.org/trunk@31655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-03-08 02:27:27 +00:00
Sergey Biryukov 0231047071 Delegate `focusin` and `focusout` events for row actions to make sure the actions are always revealed on focus.
props afercia.
fixes #29765.
Built from https://develop.svn.wordpress.org/trunk@31509


git-svn-id: http://core.svn.wordpress.org/trunk@31490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-02-22 20:14:25 +00:00
Sergey Biryukov 19e51601ab Revert [31173] and target only taxonomy and link manager tables in keyboard focus code.
props afercia.
fixes #30980.
Built from https://develop.svn.wordpress.org/trunk@31177


git-svn-id: http://core.svn.wordpress.org/trunk@31158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 14:01:22 +00:00
Sergey Biryukov 3ac60370b8 Reveal row actions on focus on taxonomy screens.
props afercia.
fixes #30980.
Built from https://develop.svn.wordpress.org/trunk@31173


git-svn-id: http://core.svn.wordpress.org/trunk@31154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-13 07:02:22 +00:00
Andrew Ozz e0189c3686 Move the (recently added) `.notice` admin notices below the first H2, same as the `.updated` and `.error` notices. Props sippis, fixes #30885.
Built from https://develop.svn.wordpress.org/trunk@31023


git-svn-id: http://core.svn.wordpress.org/trunk@31004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-02 18:52:23 +00:00
Andrew Ozz ee67cd96be Improve the fix for menu shakiness when over-scrolling. Recalculate heights on editor auto-resize.
See #30692.
Built from https://develop.svn.wordpress.org/trunk@30852


git-svn-id: http://core.svn.wordpress.org/trunk@30842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-15 00:11:24 +00:00
Andrew Ozz 910bb84c89 Fix menu shakiness when over-scrolling in Chrome and Safari on MacOS.
See #30692.
Built from https://develop.svn.wordpress.org/trunk@30844


git-svn-id: http://core.svn.wordpress.org/trunk@30834 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-14 01:47:23 +00:00
Scott Taylor 097e4ede58 Add some inline JS docs for Customizer.
See #30469.

Built from https://develop.svn.wordpress.org/trunk@30738


git-svn-id: http://core.svn.wordpress.org/trunk@30728 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-12-04 02:04:22 +00:00
John Blackbourn afd0dd5ece Avoid adjusting the current submenu position when tabbing through the admin menu.
Fixes #30349
Props 5um17

Built from https://develop.svn.wordpress.org/trunk@30352


git-svn-id: http://core.svn.wordpress.org/trunk@30351 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-11-16 02:22:21 +00:00
Andrew Ozz ecdc8d3baf Admin menu:
- Fix scrolling the pinned menu with a mouse wheel.
- Fix pinning when the menu is only slightly taller than the viewport.
- Disable pinning on IE8, updating CSS top makes it jump when scrolling with a mouse wheel.
See #29806
Built from https://develop.svn.wordpress.org/trunk@29978


git-svn-id: http://core.svn.wordpress.org/trunk@29724 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-21 06:12:20 +00:00
Andrew Ozz f19ad10571 Admin menu:
- Fix pinning after resizing the window.
- Merge the two DOM ready callbacks in common.js
- Fix the submenus position adjustment on focus.
See #29806
Built from https://develop.svn.wordpress.org/trunk@29898


git-svn-id: http://core.svn.wordpress.org/trunk@29653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-15 06:05:18 +00:00
Andrew Ozz f98106769d Pin the admin menu on scrolling similarly to how the side metaboxes are pinned on the Edit Post screen, first run. See #29806.
Built from https://develop.svn.wordpress.org/trunk@29835


git-svn-id: http://core.svn.wordpress.org/trunk@29599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-10-05 03:09:20 +00:00
Andrew Ozz 0a4d4a3d93 Fix tapping on the menu in iOS and Android, fixes #29365 for trunk
Built from https://develop.svn.wordpress.org/trunk@29770


git-svn-id: http://core.svn.wordpress.org/trunk@29542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-09-26 23:02:16 +00:00
Dominik Schilling 27e564113d Admin Menu: Auto fold the menu at 960px.
This gives us some more room at the post edit screen.

props vinod dalvi for initial patch.
fixes #28592.
Built from https://develop.svn.wordpress.org/trunk@29518


git-svn-id: http://core.svn.wordpress.org/trunk@29294 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-08-17 14:15:17 +00:00
Helen Hou-Sandí 448275cce4 Media Grid: Remove fields from showing in the grid itself.
All details are still available within the modal, and less-distinguishable non-image files still show the filename along with the file type icon.

Reverts [29079], [29078], [29077], and [28995]. see #24716.

Built from https://develop.svn.wordpress.org/trunk@29280


git-svn-id: http://core.svn.wordpress.org/trunk@29062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-24 05:26:15 +00:00
Andrew Ozz 9175194785 Fix admin menu open/close issues on some mobile devices, props adamsilverstein, fixes #27980.
Built from https://develop.svn.wordpress.org/trunk@29247


git-svn-id: http://core.svn.wordpress.org/trunk@29031 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-19 18:55:16 +00:00
Scott Taylor ea42b8e48e Media Grid:
* Move the grid down via CSS transition when the Screen Options slide open.
* Remove some unused CSS for grid options.

See #24716.

Built from https://develop.svn.wordpress.org/trunk@29086


git-svn-id: http://core.svn.wordpress.org/trunk@28872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-11 05:34:14 +00:00
Scott Taylor b16d3bd6ad Media Grid: make registering Screen Options for non-list tables more generic.
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29079


git-svn-id: http://core.svn.wordpress.org/trunk@28865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 21:44:16 +00:00
Scott Taylor a9fb59151b Media Grid: Screen Options for grid have to play nice with Screen Options for list. This was fun.
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29078


git-svn-id: http://core.svn.wordpress.org/trunk@28864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 21:26:16 +00:00
Scott Taylor a89060013b Media Grid: Move toggling of visible fields to Screen Options. This moves us in a better direction... but this will probably need to be massaged again.
See #24716.

Built from https://develop.svn.wordpress.org/trunk@29077


git-svn-id: http://core.svn.wordpress.org/trunk@28863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-10 21:00:17 +00:00
Andrew Ozz 5e4a020ff8 Enhance the editor on the Add/Edit Post screens, first run. Props avril, see #28328.
Built from https://develop.svn.wordpress.org/trunk@29049


git-svn-id: http://core.svn.wordpress.org/trunk@28837 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-07-09 22:06:15 +00:00
Helen Hou-Sandí 831e5aa049 Don't switch contextual help tabs when tabbing around. props neil_pie. see #28209.
Built from https://develop.svn.wordpress.org/trunk@28869


git-svn-id: http://core.svn.wordpress.org/trunk@28669 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-06-27 19:10:16 +00:00
Andrew Nacin ce1ace6347 Fix flyout menus on most mobile devices.
props ocean90.
fixes #26482.

Built from https://develop.svn.wordpress.org/trunk@27775


git-svn-id: http://core.svn.wordpress.org/trunk@27612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-27 06:30:14 +00:00
Andrew Ozz 2f6d9d37cc Consolidate "close on Escape" in the media modal, DFW, wpLink and Thickbox. Props kovshenin, fixes #26854.
Built from https://develop.svn.wordpress.org/trunk@27080


git-svn-id: http://core.svn.wordpress.org/trunk@26953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-02-03 05:31:14 +00:00
Andrew Ozz 33c41db77a Improve keyboard accessibility for the admin menu when in responsive mode, props SergeyBiryukov, fixes #26639 for trunk.
Built from https://develop.svn.wordpress.org/trunk@27011


git-svn-id: http://core.svn.wordpress.org/trunk@26888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-22 20:08:11 +00:00
Andrew Ozz 2a68f85fa1 Comment moderation shortcuts:
- Fix "toggle checkboxes" (shift+x).
- Add noDisable selector and use it to stop disabling the shortcuts when a select-comment checkbox is focused.
See #26755.
Built from https://develop.svn.wordpress.org/trunk@26889


git-svn-id: http://core.svn.wordpress.org/trunk@26772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-01-02 00:11:14 +00:00
Andrew Ozz 95a02fbe43 Fake a "non-responsive" window width for IE < 9 when folding/unfolding the menu (old IE doesn't support @media), fixes #26458.
Built from https://develop.svn.wordpress.org/trunk@26785


git-svn-id: http://core.svn.wordpress.org/trunk@26672 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-07 18:46:11 +00:00
Andrew Ozz 2da2559d26 Responsive menu: fix calculation of the responsive trigger width from JS. It is affected by a vertical scrollbar width in some browsers. See #26458.
Built from https://develop.svn.wordpress.org/trunk@26743


git-svn-id: http://core.svn.wordpress.org/trunk@26632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-06 20:50:10 +00:00
Andrew Nacin e6f229c29b Pinking shears. see #26086 props atimmer.
Built from https://develop.svn.wordpress.org/trunk@26627


git-svn-id: http://core.svn.wordpress.org/trunk@26517 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-04 19:34:09 +00:00
Andrew Ozz 830bcf9957 Make the responsive menu usable with a mouse, fix non-folded and :focus styles, toggle the submenus on touchend/click. Fixes #26086.
Built from https://develop.svn.wordpress.org/trunk@26516


git-svn-id: http://core.svn.wordpress.org/trunk@26409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-12-02 03:19:11 +00:00
Andrew Ozz 758a07bfd3 Remove cloning of the search box with JS and move it to the bottom of the screen with CSS instead, see #26086
Built from https://develop.svn.wordpress.org/trunk@26421


git-svn-id: http://core.svn.wordpress.org/trunk@26321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 22:19:14 +00:00
Andrew Ozz b8984636c2 Clean up the sticky menu and responsive tweaks JS:
- More descriptive names.
- Share cached jQuery elements.
- Fix re-enabling of touch events on the admin menu.
- Fix disabling/enabling of UI Sortable.
Props tollmanz, props sanchothefat, see #26086, fixes #26088.
Built from https://develop.svn.wordpress.org/trunk@26402


git-svn-id: http://core.svn.wordpress.org/trunk@26302 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 08:57:10 +00:00
Andrew Nacin d7423a466e Residual JSHint fixes in common.js and edit-comments.js.
see #25912, #25979.

Built from https://develop.svn.wordpress.org/trunk@26208


git-svn-id: http://core.svn.wordpress.org/trunk@26116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-15 06:37:09 +00:00
Matt Thomas 2adf09fea9 Bring in the responsive component of MP6. See #25858.
* Makes the admin fully responsive down to 320px wide.
* Adds a touch-optimized main menu that can be opened and closed from the toolbar.
* Size and positioning adjustments to icons, buttons, and text elements for better touch usability.

A few changes since MP6:

* Removed jQuery mobile. This script was used to add swipe controls to open/close the sidebar menu. This feature was apparently buggy and due to the pending demise of jQuery mobile, it was removed.
* Removed use of Backbone.js. Adding Backbone.js to this script would add a dependency of Backbone.js for all of the admin. Additionally, it was used to add a menu item. Instead of doing that, it was added via the admin menu API. This also fixes a bad delay in the item showing in the menu.
* CSS layout is standardized. Comments have also been cleaned up.
* Jetpack and Akismet code is removed.
* RTL CSS is removed.
* JS passes hinting other than one small issue that will likely be removed when parts of the code are reviewed.

A number of areas for improvement remain; we're tracking these issues in the comments of #25858.

Props to tollmanz, tillkruess, helen, dd32, and apeatling.


Built from https://develop.svn.wordpress.org/trunk@26134


git-svn-id: http://core.svn.wordpress.org/trunk@26046 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 18:00:10 +00:00
Helen Hou-Sandí dcb1701e51 Merge the sticky menu component from MP6. The admin menu is now fixed if the viewport is large enough. props tollmanz, tillkruess, dd32. see #25858.
Built from https://develop.svn.wordpress.org/trunk@26125


git-svn-id: http://core.svn.wordpress.org/trunk@26037 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-13 04:30:10 +00:00
Andrew Nacin 72efe7c1ec Free common.js of JSHint errors.
props jorbin.
fixes #25912.

Built from https://develop.svn.wordpress.org/trunk@26112


git-svn-id: http://core.svn.wordpress.org/trunk@26024 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-12 23:56:09 +00:00
Andrew Nacin b6d680174d List tables: When executing a search, reset the Bulk Actions dropdown to avoid the search from failing.
props c3mdigital, vinod-dalvi.
fixes #25034.

Built from https://develop.svn.wordpress.org/trunk@25677


git-svn-id: http://core.svn.wordpress.org/trunk@25593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-03 01:09:10 +00:00
Helen Hou-Sandí 2e584b5e09 Allow all non-visible default row actions in the admin to be accessed via keyboard. fixes #21334.
Built from https://develop.svn.wordpress.org/trunk@25595


git-svn-id: http://core.svn.wordpress.org/trunk@25512 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-24 02:50:09 +00:00
Andrew Ozz cd4d1460c6 Fix folding/unfolding of the admin menu on new installs, props SergeyBiryukov, fixes #24921 for 3.6.1.
Built from https://develop.svn.wordpress.org/trunk@25186


git-svn-id: http://core.svn.wordpress.org/trunk@25158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-30 17:11:08 +00:00
Helen Hou-Sandí 94bacd5887 Make shift-click checkbox range selection work in both directions. props c3mdigital, SergeyBiryukov. fixes #23427.
Built from https://develop.svn.wordpress.org/trunk@25141


git-svn-id: http://core.svn.wordpress.org/trunk@25121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-08-27 20:50:10 +00:00
Andrew Ozz d3c4efc106 Collapse Menu: use jQuery normalized window width only for WebKit. Use window.innerWidth in Firefox, IE > 8, etc. so the window width in JS and for the @media rules match. Fixes #23817.
git-svn-id: http://core.svn.wordpress.org/trunk@24619 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-09 21:26:32 +00:00
Andrew Ozz 580b083e47 Post locks: don't check hidden checkboxes on bulk select/deselect, props dh-shredder, see #23312
git-svn-id: http://core.svn.wordpress.org/trunk@23485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-25 21:24:19 +00:00
Andrew Nacin e3069d9d62 Re-enable a .wp-upload-form submit button whenever any file input in that form has a file selected, to minimize the potential for issues. props kovshenin. fixes #20855. see [22459].
git-svn-id: http://core.svn.wordpress.org/trunk@22663 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-19 06:07:04 +00:00
Andrew Ozz 981419d292 Make the admin menu and toolbar work well on mobile devices (take 2), props georgestephanis, fixes #20614, fixes #22382
git-svn-id: http://core.svn.wordpress.org/trunk@22636 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-17 20:14:17 +00:00
Andrew Nacin b9b9ebeeae Forms with the class .wp-upload-form will now have their submit button disabled until a file is selected. props kovshenin, helenyhou, lessbloat, SergeyBiryukov, tommcfarlin. fixes #20855.
git-svn-id: http://core.svn.wordpress.org/trunk@22459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 23:54:03 +00:00
Andrew Ozz 5b8108a3fd Improve visible focus in the admin, props lessbloat, fixes #21324
git-svn-id: http://core.svn.wordpress.org/trunk@22268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-22 19:51:51 +00:00