Commit Graph

133 Commits

Author SHA1 Message Date
Scott Taylor 44e2d48a3c In `install_plugin_information()`, `$title` is set in a `foreach` loop and never used. This appears to be due to copy-pasting a previous `foreach` loop and not discarding these bits.
See #27882.


Built from https://develop.svn.wordpress.org/trunk@28301


git-svn-id: http://core.svn.wordpress.org/trunk@28129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-06 17:00:18 +00:00
Andrew Nacin 2bc282957c Translate a string added in 3.7.1 but never translated previously.
props SergeyBiryukov.
fixes #27819.

Built from https://develop.svn.wordpress.org/trunk@28145


git-svn-id: http://core.svn.wordpress.org/trunk@27976 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-16 00:38:14 +00:00
Drew Jaynes 5e51ea9940 Priority fixes for various existing hook documentation.
Props kpdesign.
See #26869

Built from https://develop.svn.wordpress.org/trunk@28083


git-svn-id: http://core.svn.wordpress.org/trunk@27914 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-04-12 00:01:15 +00:00
Andrew Nacin c08ff58b13 Plugin Installer: Disable 'Latest Version Installed' buttons.
props paulwilde.
see #26952.

Built from https://develop.svn.wordpress.org/trunk@27677


git-svn-id: http://core.svn.wordpress.org/trunk@27520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-24 03:41:15 +00:00
Andrew Ozz 513b6992e5 Restyle the plugin install details modal to match the rest of the admin. Props avryl and paulwilde for initial mockup, see #26952
Built from https://develop.svn.wordpress.org/trunk@27559


git-svn-id: http://core.svn.wordpress.org/trunk@27402 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-16 18:28:17 +00:00
Andrew Nacin 0c16c0477b Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc.
props Ipstenu, markjaquith.
see #27115.

Built from https://develop.svn.wordpress.org/trunk@27369


git-svn-id: http://core.svn.wordpress.org/trunk@27219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-03-03 02:34:27 +00:00
Dion Hulse 89dfee993d Replace the Star ratings in the dashboard with dashicons ratings.
This also moves the ratings to only displaying full, half, or empty stars (ie. 3.0, 3.5, 4.0, no 3.7 ratings - which are rounded).
Fixes #26170

Built from https://develop.svn.wordpress.org/trunk@26380


git-svn-id: http://core.svn.wordpress.org/trunk@26280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-11-26 02:25:21 +00:00
Andrew Nacin a8ef13972c When an HTTPS request to api.wordpress.org fails, try an insecure HTTP request and issue a warning.
Certain versions of cURL appear to claim OpenSSL support but fail to work. We need to not trap users on older versions while we work this out, and instead fall back to an insecure request.

see #25716 for trunk.

Built from https://develop.svn.wordpress.org/trunk@25956


git-svn-id: http://core.svn.wordpress.org/trunk@25915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-27 21:09:10 +00:00
Andrew Nacin 8392f942a4 Send current SSL status to the plugin information API endpoint so we can render screenshots over SSL if appropriate. fixes #11009.
Built from https://develop.svn.wordpress.org/trunk@25691


git-svn-id: http://core.svn.wordpress.org/trunk@25607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-05 10:59:12 +00:00
Drew Jaynes 11080f459c Inline documentation for hooks in wp-admin/includes/plugin-install.php.
Props naomicbush.
See #25229.

Built from https://develop.svn.wordpress.org/trunk@25511


git-svn-id: http://core.svn.wordpress.org/trunk@25431 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 02:22:10 +00:00
Dion Hulse 068df26686 Switch to using HTTPS connections for Plugin and Theme API requests when SSL is available. See #18577
Built from https://develop.svn.wordpress.org/trunk@25308


git-svn-id: http://core.svn.wordpress.org/trunk@25270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-09 07:54:11 +00:00
Sergey Biryukov 89aed6d7e8 Avoid 'Only variables should be passed by reference' notice on plugin search. props daankortenbach. fixes #25217.
Built from https://develop.svn.wordpress.org/trunk@25210


git-svn-id: http://core.svn.wordpress.org/trunk@25182 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-02 13:54:10 +00:00
Peter Westwood 398ce8ecdf Fix a strict standards error in the plugin search when search for an already installed plugin.
Fixes #24747 props SergeyBiryukov.


git-svn-id: http://core.svn.wordpress.org/trunk@24725 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-07-17 21:08:05 +00:00
Sergey Biryukov bb1e5b4d33 Use numbered placeholders. see #24389.
git-svn-id: http://core.svn.wordpress.org/trunk@24327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:26:36 +00:00
Andrew Nacin 797ee34bc3 Remove /extend/ from URLs to wordpress.org/plugins, /themes, and /mobile, as those are all now top-level. see #24389.
git-svn-id: http://core.svn.wordpress.org/trunk@24320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-05-22 21:01:57 +00:00
Ryan Boren 5f809d1d22 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes().
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 17:00:25 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-03-01 16:28:40 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments.
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-02-14 22:51:06 +00:00
Andrew Nacin b9b9ebeeae Forms with the class .wp-upload-form will now have their submit button disabled until a file is selected. props kovshenin, helenyhou, lessbloat, SergeyBiryukov, tommcfarlin. fixes #20855.
git-svn-id: http://core.svn.wordpress.org/trunk@22459 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-11-07 23:54:03 +00:00
Andrew Nacin fc5fb63599 Browse and install your wordpress.org plugin favorites from the plugin installer. props Otto42, Japh, DrewAPicture. fixes #22002.
git-svn-id: http://core.svn.wordpress.org/trunk@22026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 00:47:01 +00:00
Andrew Nacin 557d9313a7 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987.
git-svn-id: http://core.svn.wordpress.org/trunk@21996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-25 05:26:19 +00:00
Andrew Nacin c1b0670c2d Updates and fixes to the new button styles. By default, buttons are now the same size as they were in 3.4. Then there is a smaller button (designed for minor elements) and a larger button (designed for things like Publish and Save Changes). Better focus styles. props lessbloat. see #21598.
git-svn-id: http://core.svn.wordpress.org/trunk@21944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-21 19:34:23 +00:00
Daryl Koopersmith 67894a3407 New button styles.
Using the new buttons:

* Button classes are now stackable.
* All buttons should use a base class of "button".
* Buttons default to the gray style (formerly "button-secondary"). Buttons can add a style by adding additional classes. To make a primary button, add the "button-primary" class.
* Buttons can be rendered in various sizes. In addition to the default size, you can add "button-large", "button-small", or "button-tiny".

For backwards compatibility reasons, "button-primary" and "button-secondary" both work as standalone classes.

get_submit_button() has been adjusted to handle shorthand button classes (i.e. button classes can be passed without the "button-" prefix).

props lessbloat, helenyhou, trepmal, nacin. see #21598.



git-svn-id: http://core.svn.wordpress.org/trunk@21789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-08 04:58:34 +00:00
markjaquith 06bc3bf328 Autofocus the search box on the Theme and Plugin installation pages. Faster flow for people who know what they are looking for. props SergeyBiryukov. fixes #21080. see #21027.
git-svn-id: http://core.svn.wordpress.org/trunk@21143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-06-26 20:55:46 +00:00
ryan 1f3da6568d Update plugin install screens to use the new stars. Add stars-rtl.png. Remove star.png and gray-star.png and add to old files list.
Props helenyhou
Fixes #20626



git-svn-id: http://core.svn.wordpress.org/trunk@20754 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-09 16:27:24 +00:00
ryan 1a5249997e Friendlier strings with links to the support forums when experiencing problems talking to api.wordpress.org. fixes #20605
git-svn-id: http://core.svn.wordpress.org/trunk@20752 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-09 15:55:59 +00:00
nacin 886ee992be Replace commas with periods when converting ratings float values to strings, to avoid issues with localized decimal points.
In these cases, we want a period because it is going to be used by CSS.

props SergeyBiryukov.
fixes #19593.



git-svn-id: http://core.svn.wordpress.org/trunk@20675 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-05-01 22:09:55 +00:00
nacin 608b26589e Default to keyword searches for the plugin and theme installers in case no search type is posted back. fixes #19619.
props georgestephanis, SergeyBiryukov for initial patches.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-30 00:44:47 +00:00
nacin d17afd15a4 Reduce clutter and repetive functionality from the initial landing page for installing plugins and themes by removing the tag/author/term dropdown.
The tag cloud (plugins) and feature filter (themes) is sufficient for tag functionality. All three "search by" fields are already weighted for a standard keyword search through the WP.org API.

fixes #19619 for 3.4.



git-svn-id: http://svn.automattic.com/wordpress/trunk@20592 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-25 19:37:19 +00:00
nacin dad05727fc Check for the response property in tue update_plugins transient object. props ampt, fixes #20441.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20490 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-04-17 02:43:13 +00:00
nacin d7d0da4193 Use 'Keyword' instead of 'Term' in the search type selector in the plugin and theme installers. see #19619.
git-svn-id: http://svn.automattic.com/wordpress/trunk@20333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-30 21:17:22 +00:00
azaozz f3b63e4537 Set proper HTML5 input types in the admin, props georgestephanis, fixes #17863
git-svn-id: http://svn.automattic.com/wordpress/trunk@20168 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-10 01:23:48 +00:00
dd32 f60ca6da11 Better indentation. Props SergeyBiryukov. See #16580
git-svn-id: http://svn.automattic.com/wordpress/trunk@19710 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 09:18:56 +00:00
dd32 3928e40daf s/Faq/FAQ/ for Plugin Installer tabs, Gains Translation support for Tabs/Titles as well. Fixes #16580
git-svn-id: http://svn.automattic.com/wordpress/trunk@19708 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 05:39:49 +00:00
dd32 3686bc4b6e use maybe_unserialize() in update and API checks, Tighten up the checks on expected return data to avoid processing invalid responses after change. See #19617
git-svn-id: http://svn.automattic.com/wordpress/trunk@19707 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 03:48:05 +00:00
ryan 301b9aed41 Remove 'Recently Updated' from plugin installer. Props nacin. see #19573
git-svn-id: http://svn.automattic.com/wordpress/trunk@19627 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-22 21:21:57 +00:00
ryan 340e93324c Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433
git-svn-id: http://svn.automattic.com/wordpress/trunk@19596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-14 17:36:38 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin fff2457234 Remove cruft. see #19106.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 04:14:14 +00:00
markjaquith c59f813e32 Use %s instead of %d in plugin install notice strings. props johnbillion. fixes #19106
git-svn-id: http://svn.automattic.com/wordpress/trunk@19109 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-02 02:36:18 +00:00
nacin 43eae59235 Translated strings in attributes require esc_attr(). s/_e/esc_attr_e/g
git-svn-id: http://svn.automattic.com/wordpress/trunk@19028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-10-20 15:04:46 +00:00
duck_ a8c3f1145e s/overridding/overriding/. Props trepmal, see #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-05 19:25:55 +00:00
duck_ c1d1590171 Fix typos in documentation (wp-admin/). See #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18632 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-03 14:18:10 +00:00
nacin fdedc8a500 Check if property exists on plugins_api() returned object in install_plugin_information(). props hakre, fixes #18181.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18586 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-23 15:56:14 +00:00
nacin 3aff9d9464 Link tab=upload when referenced on 'Install Plugins.' fixes #18290.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-07-29 06:07:38 +00:00
dd32 6de00a0495 Add new star.gif replacement with a Grey background (& White counterpart). Props chexee for star icons. Fixes #17428
git-svn-id: http://svn.automattic.com/wordpress/trunk@18318 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-06-17 05:41:35 +00:00
nacin da2732c7de Use wp_remote_retrieve_* helper functions instead of the raw HTTP response array. props aaroncampbell, fixes #17416.
git-svn-id: http://svn.automattic.com/wordpress/trunk@17928 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-05-14 19:45:07 +00:00
nacin b8ce0261df More param fixes, props duck_. see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-18 19:12:48 +00:00
markjaquith fc6e89da45 Expand submit_button() capabilities. Replace all (or almost all) manual HTML instances in WP. props sbressler. see #15064
git-svn-id: http://svn.automattic.com/wordpress/trunk@16061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-28 21:56:43 +00:00
ryan 6b6c2583a4 Add plugin update notifications, plugin install, plugin update to the network admin screen. Props PeteMall. see #15129
git-svn-id: http://svn.automattic.com/wordpress/trunk@15867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-20 14:16:03 +00:00