Weston Ruter
fa460ab32f
Widgets: Allow relative/partial URLs in Image Widget's link field.
...
Props audrasjb.
Amends [41252].
See #41274 .
Fixes #42740 .
Built from https://develop.svn.wordpress.org/trunk@42533
git-svn-id: http://core.svn.wordpress.org/trunk@42362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-22 04:52:33 +00:00
Weston Ruter
11af5ae5cd
Code Editor: Disable `attr-value-double-quotes` HTMLHint rule since too strict for user input.
...
Using single-quoted attribute values is not in any way invalid HTML.
Amends [41376].
Props sasiddiqui.
See #12423 .
Fixes #42802 .
Built from https://develop.svn.wordpress.org/trunk@42531
git-svn-id: http://core.svn.wordpress.org/trunk@42360 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-21 08:01:31 +00:00
Pascal Birchler
5ecd978e74
Formatting: Fix typo in inline documentation of `_deep_replace()`.
...
Props ixkaito.
Fixes #43134 .
Built from https://develop.svn.wordpress.org/trunk@42530
git-svn-id: http://core.svn.wordpress.org/trunk@42359 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-20 13:32:32 +00:00
Andrew Ozz
365025fb62
Editor: change the test in `user_can_richedit()` to also detect when IE11 is in compatibility mode.
...
Props ndavison, azaozz.
Fixes #42503 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42529
git-svn-id: http://core.svn.wordpress.org/trunk@42358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-18 14:43:31 +00:00
atimmer
d268976255
Docs: Improve JSDoc for `password-strength-meter.js`.
...
Props herregroen, carolinegeven, ireneyoast, jjcomack.
Fixes #43066 .
Built from https://develop.svn.wordpress.org/trunk@42528
git-svn-id: http://core.svn.wordpress.org/trunk@42357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-18 13:39:33 +00:00
Dion Hulse
44c89cac5a
General: Allow `wp_list_pluck()` to operate on arrays of references without overwriting the referenced items.
...
Fixes #16895 .
Built from https://develop.svn.wordpress.org/trunk@42527
git-svn-id: http://core.svn.wordpress.org/trunk@42356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-18 05:18:31 +00:00
Dion Hulse
26a5d758d5
Tests: Remove redundant `assertEquals()` calls in listFilter tests.
...
As these tests are already validating that two arrays match, checking that the counts also match before is redundant and makes it harder to debug when the test fails.
See #16895
Built from https://develop.svn.wordpress.org/trunk@42526
git-svn-id: http://core.svn.wordpress.org/trunk@42355 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-18 05:15:34 +00:00
Sergey Biryukov
0eb2581c67
Media: In `_wp_handle_upload()`, check if the file was properly uploaded before checking its size.
...
Props achbed, dglingren.
Fixes #39522 .
Built from https://develop.svn.wordpress.org/trunk@42525
git-svn-id: http://core.svn.wordpress.org/trunk@42354 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-17 07:16:30 +00:00
Sergey Biryukov
3b73ac9eb3
Editor: Use explicit context instead of a trailing space for `Edit` string in TinyMCE plugins.
...
Props scottlee, ayubadiputra, NathanAtmoz.
Fixes #42543 .
Built from https://develop.svn.wordpress.org/trunk@42523
git-svn-id: http://core.svn.wordpress.org/trunk@42352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-17 06:28:30 +00:00
Weston Ruter
443594dd00
Widgets: Prevent `checkValidity` from running on a form when widget is first adding to sidebar.
...
Amends [41352].
See #23120 .
Fixes #43003 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42521
git-svn-id: http://core.svn.wordpress.org/trunk@42350 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-17 01:24:30 +00:00
Aaron Jorbin
8bd98be63d
BUILD/TEST TOOLS: Report Travis test results to make/hosting PHPUnit test results
...
Send the core test results to make/hosting in order to improve the alerting. See: https://github.com/WordPress/phpunit-test-reporter/issues/45
Fixes #43099
Props danielbachhuber
Built from https://develop.svn.wordpress.org/trunk@42492
git-svn-id: http://core.svn.wordpress.org/trunk@42321 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 20:29:31 +00:00
Andrea Fercia
fc51a83ed8
Plugins: Fix the plugin details modal "Close" button after [42443].
...
Props rinkuyadav999.
Fixes #43082 .
Built from https://develop.svn.wordpress.org/trunk@42491
git-svn-id: http://core.svn.wordpress.org/trunk@42320 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 17:15:32 +00:00
Pascal Birchler
e62806fcb8
Posts, Post Types: Add tests for `get_post_type_labels()`.
...
These were accidentally omitted in [38157].
See #38157 .
Built from https://develop.svn.wordpress.org/trunk@42490
git-svn-id: http://core.svn.wordpress.org/trunk@42319 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 08:33:30 +00:00
Dion Hulse
82054452d2
Build: Bump the version of node used on Travis to match WordPress.org.
...
Props netweb, dd32.
See #35105
Built from https://develop.svn.wordpress.org/trunk@42464
git-svn-id: http://core.svn.wordpress.org/trunk@42293 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 06:36:30 +00:00
Dion Hulse
88135346c6
Build: Bump grunt-sass to v2.0.0 from v1.2.1 for Node 8.x support.
...
Changes: https://github.com/sindresorhus/grunt-sass/compare/v1.2.1...v2.0.0
Props netweb.
See #35105 .
Fixes #43097 .
Built from https://develop.svn.wordpress.org/trunk@42463
git-svn-id: http://core.svn.wordpress.org/trunk@42292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 06:33:34 +00:00
Dion Hulse
3fe9cb61ee
External Libraries: Remove unnecessary / obsoleted MediaElement.js files.
...
Props joemcgill.
Fixes #42720 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42462
git-svn-id: http://core.svn.wordpress.org/trunk@42291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 06:28:43 +00:00
Dion Hulse
ceaaed6604
Build: Use Node 8.x for trunk.
...
Props netweb.
See #35105 .
Built from https://develop.svn.wordpress.org/trunk@42461
git-svn-id: http://core.svn.wordpress.org/trunk@42290 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 03:58:49 +00:00
Dion Hulse
406ec082cc
Build: Switch `package.json` to using tabs for indents.
...
Props netweb.
Fixes #43075 .
Built from https://develop.svn.wordpress.org/trunk@42460
git-svn-id: http://core.svn.wordpress.org/trunk@42289 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 03:55:49 +00:00
Sergey Biryukov
bee0136037
Plugins: Update review filter links in Details modal.
...
Props darko-a7, afercia.
Fixes #43016 . See #meta3379.
Built from https://develop.svn.wordpress.org/trunk@42459
git-svn-id: http://core.svn.wordpress.org/trunk@42288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-16 00:15:46 +00:00
Sergey Biryukov
589395347a
Widgets: When checking for errors in Custom HTML widget, pass correct value to `toggleClass()` for Save button.
...
`toggleClass()` expects a boolean as a second argument, not an integer.
Props iCaleb.
Fixes #42867 .
Built from https://develop.svn.wordpress.org/trunk@42457
git-svn-id: http://core.svn.wordpress.org/trunk@42286 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 23:47:47 +00:00
Sergey Biryukov
0d23b38fd3
Media: Add `small-audio.flac` for a unit test added in [42451].
...
See #42225 .
Built from https://develop.svn.wordpress.org/trunk@42453
git-svn-id: http://core.svn.wordpress.org/trunk@42283 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 22:33:47 +00:00
Sergey Biryukov
13e40181eb
Media: Add `flac` to the list of allowed file types.
...
Props blobfolio.
Fixes #42225 .
Built from https://develop.svn.wordpress.org/trunk@42451
git-svn-id: http://core.svn.wordpress.org/trunk@42281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 22:17:47 +00:00
Sergey Biryukov
35653f0432
Media: Bring consistency to `getimagesize()` error suppression.
...
Props chasewg, joemcgill, jeremyfelt.
Fixes #42480 .
Built from https://develop.svn.wordpress.org/trunk@42449
git-svn-id: http://core.svn.wordpress.org/trunk@42279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 19:44:47 +00:00
Sergey Biryukov
9cb44f5f2f
Themes: Improve line wrapping in feature filter on Theme Install screen and in the Customizer.
...
Props chetan200891 for initial patch.
Fixes #42871 .
Built from https://develop.svn.wordpress.org/trunk@42447
git-svn-id: http://core.svn.wordpress.org/trunk@42277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 19:27:53 +00:00
Andrew Ozz
1fb6a63449
TinyMCE: on the toolbar drop-downs apply overflow style on the actual element with text.
...
Props abdullahramzan, azaozz.
Fixes #43090 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42446
git-svn-id: http://core.svn.wordpress.org/trunk@42276 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-15 09:51:48 +00:00
Andrea Fercia
3fb8eee9fc
Accessibility: Media: Improve the usage of a few label elements in the media templates.
...
Label elements should only be used for labelable elements.
- `Uploaded By` and `Uploaded To` aren't form controls and shouldn't be associated with labels
- changes the labels for media source, alternate sources, poster image, and tracks to solve a layout issue and explicitly associate the labels to their form fields (previously, the labels were wrapping also the Remove buttons)
Props Presskopp, afercia.
Fixes #38759 , #40468 .
Built from https://develop.svn.wordpress.org/trunk@42444
git-svn-id: http://core.svn.wordpress.org/trunk@42274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-14 16:39:47 +00:00
Andrea Fercia
239da4c1e6
Plugins: Fix the plugin details modal in the install plugin search tab after [41356].
...
Fixes #43082
Built from https://develop.svn.wordpress.org/trunk@42443
git-svn-id: http://core.svn.wordpress.org/trunk@42273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-13 18:53:51 +00:00
Peter Wilson
a492541c35
Formatting: Do not run formatting and texturization on author bios.
...
Removes the formatting and texturization added to author bios in #40040 due to back-compatibility concerns.
Reverts [41172], [41173].
Props 0x6f0, rabmalin for review.
Fixes #42578 .
Built from https://develop.svn.wordpress.org/trunk@42441
git-svn-id: http://core.svn.wordpress.org/trunk@42271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-13 01:11:49 +00:00
Andrea Fercia
9c3344197d
Accessibility: use `aria-current` for the paginated post links output by `wp_link_pages()`.
...
Continues the introduction in core of the aria-current attribute after [41683], [41359], and [41371].
- changes the `wp_link_pages()` (see the `nextpage` quicktag) output to use an `aria-current` attribute on the current item
- adds `post-nav-links` and `post-page-numbers` CSS classes to help themes style these links
- updates the related tests
Props antonioeatgoat, alexstine.
Fixes #41859 .
Built from https://develop.svn.wordpress.org/trunk@42440
git-svn-id: http://core.svn.wordpress.org/trunk@42270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-12 20:17:51 +00:00
Sergey Biryukov
351d71d7ea
Twenty Seventeen: Remove unnecessary comment in `front-page.php`.
...
Props hardik-amipara, poena.
Fixes #42820 .
Built from https://develop.svn.wordpress.org/trunk@42437
git-svn-id: http://core.svn.wordpress.org/trunk@42267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-12 20:01:51 +00:00
atimmer
6310ad30d0
Docs: Improve JS Docs for `controllers/customize-image-cropper.js`.
...
Props manuelaugustin, bramheijmink, andizer, ireneyoast.
Fixes #43020 .
Built from https://develop.svn.wordpress.org/trunk@42435
git-svn-id: http://core.svn.wordpress.org/trunk@42265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-11 14:32:52 +00:00
Dion Hulse
1d59873ace
Upgrade: When deleting old files, if deletion fails attempt to empty the file instead.
...
Props joemcgill, dd32.
Fixes #42963 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42433
git-svn-id: http://core.svn.wordpress.org/trunk@42263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-10 06:10:47 +00:00
Dion Hulse
cdfa5adc43
Streams: When checking in `wp_is_stream()` escape the stream wrapper names for PCRE to avoid PHP warnings when invalid stream wrappers are registered.
...
Fixes #43054 .
Built from https://develop.svn.wordpress.org/trunk@42432
git-svn-id: http://core.svn.wordpress.org/trunk@42262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-10 02:50:46 +00:00
Mike Schroder
7bfc60864f
Media: Skip `test_remove_orientation_data_on_rotate` if missing deps.
...
The `test_remove_orientation_data_on_rotate()` test was failing on systems that did not have the `exif` extension available.
Skips test when the `exif_read_data()` function does not exist.
Props danielbachhuber, desrosj.
Fixes #42447 .
Built from https://develop.svn.wordpress.org/trunk@42431
git-svn-id: http://core.svn.wordpress.org/trunk@42261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-10 01:17:51 +00:00
Andrew Ozz
4a3faae0e8
Editor: ensure there is a selection before getting the caret position. Fixes a bug in Firefox when there is no selection for a hidden element.
...
Props johnschulz, azaozz.
Fixes #43012 for trunk.
Built from https://develop.svn.wordpress.org/trunk@42430
git-svn-id: http://core.svn.wordpress.org/trunk@42260 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-08 20:20:53 +00:00
Gary Pendergast
fbb1f9162b
Formatting: Fix capital_P_dangit() not capital P-ing, dangit.
...
Unfortunately, in my overzealous desire to fix all the un-capitalised Ps, [42343] capitalled some Ps that intentionally should not be capitals.
This commit fixes the incorrectly capitalling of Ps, as well as including unit tests and PHPCS instructions to ensure we never capitulate to capitalisationing them again.
Props superdav42.
Fixes #43040 .
Fixes #43041 .
Built from https://develop.svn.wordpress.org/trunk@42429
git-svn-id: http://core.svn.wordpress.org/trunk@42259 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-08 10:36:51 +00:00
atimmer
d1c58e7850
Docs: Improve JSDoc for `js/media-upload.js`.
...
Props terwdan, diedeexterkate, andizer, ireneyoast.
Fixes #42956 .
Built from https://develop.svn.wordpress.org/trunk@42426
git-svn-id: http://core.svn.wordpress.org/trunk@42257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-04 14:37:49 +00:00
Andrea Fercia
4e5215deec
Editor: Link suggestions: add fallback title for posts with no title.
...
Fixes #42664 .
Built from https://develop.svn.wordpress.org/trunk@42425
git-svn-id: http://core.svn.wordpress.org/trunk@42256 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-02 18:11:52 +00:00
Rachel Baker
502dcd51a4
General: Update copyright year to 2018 in license.txt.
...
Fixes #43007 .
Built from https://develop.svn.wordpress.org/trunk@42424
git-svn-id: http://core.svn.wordpress.org/trunk@42255 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-01 03:17:48 +00:00
Rachel Baker
2eca52eaa4
REST API: Adjust unit testes to expect a 401 status code in error responses from permission callbacks when user is not authenticated.
...
Missed in [42421].
Fixes #42828 .
Built from https://develop.svn.wordpress.org/trunk@42423
git-svn-id: http://core.svn.wordpress.org/trunk@42254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-01-01 02:31:46 +00:00
Rachel Baker
a787006298
REST API: Return the proper status code for failed permission callbacks in `WP_REST_Server->dispatch()`.
...
Use the `rest_authorization_required_code()` function to return a 401 status code when a permission callback fails due to a user not being logged in.
Props jaswrks.
Fixes #42828 .
Built from https://develop.svn.wordpress.org/trunk@42421
git-svn-id: http://core.svn.wordpress.org/trunk@42252 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-30 20:37:47 +00:00
Rachel Baker
386a5c397f
Comments: Introduce filter for the arguments for the comment query in the comments list table.
...
Add `comments_list_table_query_args` filter to the Comments List Table.
Props soulseekah, birgire.
Fixes #42997 .
Built from https://develop.svn.wordpress.org/trunk@42420
git-svn-id: http://core.svn.wordpress.org/trunk@42251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-29 18:21:52 +00:00
Dion Hulse
02d04f2b5c
WP: Don't attempt to convert multiple-nested arrays to a string in WP->parse_request().
...
See #14330 .
Fixes #42752 .
Built from https://develop.svn.wordpress.org/trunk@42419
git-svn-id: http://core.svn.wordpress.org/trunk@42250 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-22 03:18:47 +00:00
Boone Gorges
699025a785
Taxonomy: Restore deprecated argument to `term_description()` signature.
...
This ensures that the parameter can't be reused for something else
in the future.
Props jorbin.
Fixes #42605 .
Built from https://develop.svn.wordpress.org/trunk@42417
git-svn-id: http://core.svn.wordpress.org/trunk@42248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-22 02:48:51 +00:00
atimmer
02b86b8418
Docs: Improve JSDoc for `customize-preview-widgets.js`.
...
Props ireneyoast, andizer, robinvandervliet, boblinthorst.
Fixes #42954 .
Built from https://develop.svn.wordpress.org/trunk@42416
git-svn-id: http://core.svn.wordpress.org/trunk@42247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-21 15:12:49 +00:00
atimmer
f296e2cbbc
Docs: Improve JSDoc for `media/views/attachments.js`.
...
Props maartenleenders, herregroen, jipmoors, ireneyoast.
Fixes #42832 .
Built from https://develop.svn.wordpress.org/trunk@42415
git-svn-id: http://core.svn.wordpress.org/trunk@42246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-21 14:27:52 +00:00
Sergey Biryukov
7dfcb33d4d
Docs: Remove erroneous zero-width space before URL in `fetch_feed()` DocBlock.
...
Props coffee2code.
Fixes #42951 . See #meta3212.
Built from https://develop.svn.wordpress.org/trunk@42414
git-svn-id: http://core.svn.wordpress.org/trunk@42245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-21 02:40:54 +00:00
Dion Hulse
1caa918dbc
i18n: Don't use `esc_attr_e()` on a variable.
...
Props yoavf.
Fuxes #42935 .
Built from https://develop.svn.wordpress.org/trunk@42413
git-svn-id: http://core.svn.wordpress.org/trunk@42244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-20 05:35:50 +00:00
John Blackbourn
a5e2908bbd
Docs: Improve the function and parameter descriptions for `do_meta_boxes()`.
...
See #42505
Built from https://develop.svn.wordpress.org/trunk@42412
git-svn-id: http://core.svn.wordpress.org/trunk@42243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-19 15:03:52 +00:00
atimmer
f6a37e7d39
Docs: Remove `@summary` tags from JSDoc.
...
As decided in the JavaScript core chat. With a few reasons:
* It is visually cleaner when reading the source.
* This bring the JavaScript documentation closer to the PHP documentation.
The only disadvantage is that the JSDoc parser doesn't split out the summary and the description in the new format. We've decided to solve this when building the JavaScript documentation parser.
Props herregroen.
Fixes #42901 .
Built from https://develop.svn.wordpress.org/trunk@42411
git-svn-id: http://core.svn.wordpress.org/trunk@42240 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-12-18 14:14:53 +00:00