Commit Graph

80 Commits

Author SHA1 Message Date
nacin a530304b68 Revert [21287] until #21169 goes through. see #21321.
git-svn-id: http://core.svn.wordpress.org/trunk@21299 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-21 20:24:21 +00:00
nacin ff2d1c5195 Clarify the return value of has_filter() and has_action(). It returns a boolean if only the first argument is specified. If the second argument is specified, it returns false or an integer, which means it may return a non-boolean value that evaluates to false (so, 0), so you should take care to use the === operator.
Correct the function definition of remove_filter() and remove_action(), which 'accepted' an $accepted_args argument, but did not require or use it.

fixes #19417.



git-svn-id: http://core.svn.wordpress.org/trunk@21288 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-20 13:54:42 +00:00
nacin 70da9092d4 Remove unnecessary is_null() checks from the worker loops inside do_action(), apply_filters(), etc. fixes #21321. see #21169.
git-svn-id: http://core.svn.wordpress.org/trunk@21287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-20 05:25:37 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-08 17:01:11 +00:00
ryan 616c35e71c One newline is enough.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19684 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-01-05 20:10:39 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-12-13 23:45:31 +00:00
nacin 75c741cd8b Revert other stuffs from [19374].
git-svn-id: http://svn.automattic.com/wordpress/trunk@19376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 15:43:57 +00:00
nacin 5e69bd0caf Set $parent_file for post-new.php when show_in_menu is a file. Provides for correct top-level highlighting. $submenu_file remains set to expect a post-new.php menu. see #19125.
git-svn-id: http://svn.automattic.com/wordpress/trunk@19374 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-11-21 15:35:57 +00:00
duck_ 2f51b9be0d Fix typos in documentation (wp-includes/[i-z]). See #18560.
git-svn-id: http://svn.automattic.com/wordpress/trunk@18639 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-09-05 19:08:15 +00:00
ryan b136c576ed Grammar fix. Props lukeschlather, markmcwilliams. fixes #17315
git-svn-id: http://svn.automattic.com/wordpress/trunk@18507 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-08-04 16:03:53 +00:00
ryan 3e77cd18c9 Avoid array push/pops for empty filters and actions. fixes #17110
git-svn-id: http://svn.automattic.com/wordpress/trunk@17638 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2011-04-14 18:05:30 +00:00
nacin c9e1ab9bd9 _doing_it_wrong takes three arguments. fixes #15824.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-15 17:14:25 +00:00
westi 167df97e81 Switch to _doing_it_wrong(). See #15824
git-svn-id: http://svn.automattic.com/wordpress/trunk@16940 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-12-15 11:31:00 +00:00
markjaquith 14be097d5e Revert [15829] for now, consider better solution for 3.2. see #13550
git-svn-id: http://svn.automattic.com/wordpress/trunk@16575 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-24 20:25:26 +00:00
nacin f6d1e9c634 Only a static class method or function can be used in an uninstall hook. props scribu, fixes #13786.
git-svn-id: http://svn.automattic.com/wordpress/trunk@16339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-11-13 09:45:57 +00:00
scribu af29ce4440 Apply filter in plugin_basename(). Props vladimir_kolesnikov. Fixes #13550
git-svn-id: http://svn.automattic.com/wordpress/trunk@15829 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-10-17 13:47:40 +00:00
nacin 5a20c05d27 Phpdoc argument/@param cleanups. props duck_, see #14783.
git-svn-id: http://svn.automattic.com/wordpress/trunk@15590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-09-07 11:21:11 +00:00
ryan 1a552dd029 Strip trailing whitespace
git-svn-id: http://svn.automattic.com/wordpress/trunk@14924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-26 02:42:15 +00:00
westi 3a3cce834a Fix remaining notice when using closures. Fixes #10493 props scribu.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 13:41:02 +00:00
westi 86cb0aa6b9 Fix notices/usage of closures as action/filter handlers. Fixes #10493 based on patch from scribu.
git-svn-id: http://svn.automattic.com/wordpress/trunk@14690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-05-16 08:10:39 +00:00
westi c3a6bea231 Ensure that apply_filters_ref_array passes the result of the filter to the next filter. Fixes #12723 props scribue.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13906 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-31 21:39:18 +00:00
nacin a7feaed0e6 Change @since 3.0 to @since 3.0.0.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13827 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-26 19:13:36 +00:00
westi 5bce147d90 Introduce apply_filters_ref_array(). See #9886 props scribu.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-18 21:24:07 +00:00
westi c71c407fd2 Fix a possible undefined offset warning in do_action. Fixes #11241 props chrisbliss18.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13674 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-11 21:58:17 +00:00
nacin 8dee46ddf0 Fix typo in remove_all_filters() that prevented hooks from being removed by priority. fixes #12492, props chrisbliss18.
git-svn-id: http://svn.automattic.com/wordpress/trunk@13567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-03-03 06:41:19 +00:00
ryan 6da55f7792 Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@12733 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-15 22:11:12 +00:00
westi c30c392e91 Allow people to attach PHP 5.3 Closures to filters and actions. Fixes #10493 props scribu.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12641 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2010-01-07 08:27:02 +00:00
ryan 7b00fcb9f6 Improve do_action performance. Make an associative array. Props koopersmith. fixes #10561
git-svn-id: http://svn.automattic.com/wordpress/trunk@12464 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-12-21 08:47:34 +00:00
westi 42eb1ba7ca Improve _wp_filter_build_unique_id to give more consistent behaviour and make filter removal reliable for class based filters. Fixes #10535 props dd32.
git-svn-id: http://svn.automattic.com/wordpress/trunk@12090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-10-22 19:33:11 +00:00
westi 2562197d3b Correct phpDoc comment for add_filter. Fixes #10164 for trunk.
git-svn-id: http://svn.automattic.com/wordpress/trunk@11617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-06-20 18:14:46 +00:00
ryan 4e6f054b47 Menu fixes
git-svn-id: http://svn.automattic.com/wordpress/trunk@11565 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-06-15 00:22:53 +00:00
ryan 31f8459c24 Make sure filter IDs are unique. Props bkrausz, hakre. fixes #8723
git-svn-id: http://svn.automattic.com/wordpress/trunk@11409 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-05-20 16:59:01 +00:00
azaozz 4f250c27cf Remove slash from plugin_basename(), props alexrabe, fixes #9561
git-svn-id: http://svn.automattic.com/wordpress/trunk@11072 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-23 21:45:38 +00:00
azaozz 8682f79e6a Make plugin_dir() and plugin_basename() work for mu-plugins directory, props Denis-de-Bernardy, fixes #9561
git-svn-id: http://svn.automattic.com/wordpress/trunk@11069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-04-23 08:16:06 +00:00
markjaquith df58ca2a41 Introducing plugin_dir_path(__FILE__) and plugin_dir_url(__FILE__) ... simple API functions for determining the directory path/url of the current plugin file
git-svn-id: http://svn.automattic.com/wordpress/trunk@10765 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-03-10 19:50:55 +00:00
westi c9c4d306ef PHPdoc updates. See €8805 props jacobsantos.
git-svn-id: http://svn.automattic.com/wordpress/trunk@10411 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2009-01-22 21:17:52 +00:00
ryan 40c754df1d Unused var fixes. Props DD32. see #8220
git-svn-id: http://svn.automattic.com/wordpress/trunk@9716 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-15 18:10:35 +00:00
azaozz 1b84d8e087 Fix constant name in phpDoc, props alexrabe, fixes #8123
git-svn-id: http://svn.automattic.com/wordpress/trunk@9611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-11-11 12:43:04 +00:00
westi a0f339d3bf Notice fixes. See #7509 props DD32.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9177 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-10-14 21:08:28 +00:00
westi 0161953100 Fix Notice. When nothing exists for an action or filter.
git-svn-id: http://svn.automattic.com/wordpress/trunk@9000 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-09-27 09:53:43 +00:00
westi 9e89b4a99e phpDoc corrections for wp-includes. See #7550 props jacobsantos.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8782 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-30 21:23:43 +00:00
westi e462ca421d remove_all_{actions|filters}. Fixes #7216 props filosofo and santosj.
git-svn-id: http://svn.automattic.com/wordpress/trunk@8660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-17 11:15:38 +00:00
ryan 0f8d8597c3 Update since tags. Props santosj. fixes #5625
git-svn-id: http://svn.automattic.com/wordpress/trunk@8587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-08 04:15:03 +00:00
ryan d7cc99037f Plugin uninstall hooks from santosj. fixes #5625
git-svn-id: http://svn.automattic.com/wordpress/trunk@8585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-07 23:39:27 +00:00
markjaquith 74c46749cb Cast to array when using foreach(). Props santosj (and thanks for your perseverance!). fixes #2784
git-svn-id: http://svn.automattic.com/wordpress/trunk@8572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-08-06 20:31:54 +00:00
ryan 6c8d35de32 Allow wp-content to exist outside of webroot. Props sambauers. see #6938
git-svn-id: http://svn.automattic.com/wordpress/trunk@7999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-05-27 17:55:24 +00:00
ryan d88983793b Trailing whitespace cleanup
git-svn-id: http://svn.automattic.com/wordpress/trunk@6726 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-02-05 06:47:27 +00:00
ryan f8ab885ab0 Use PLUGINDIR in plugin_basename(). Props hansengel. fixes #5665
git-svn-id: http://svn.automattic.com/wordpress/trunk@6629 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-16 19:11:15 +00:00
ryan 479fc2e2b3 phpdoc tuneup from darkdragon. see #5611
git-svn-id: http://svn.automattic.com/wordpress/trunk@6585 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2008-01-09 17:48:00 +00:00
ryan 050ffefc43 Filter and action optimizations and phpdoc updates from darkdragon. fixes #5338
git-svn-id: http://svn.automattic.com/wordpress/trunk@6361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2007-12-06 05:56:38 +00:00