b80ce60f70
Coding Standards: Use pre-increment/decrement for stand-alone statements.
...
Note: This is enforced by WPCS 3.0.0:
1. There should be no space between an increment/decrement operator and the variable it applies to.
2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around.
References:
* [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#increment-decrement-operators WordPress PHP Coding Standards: Increment/decrement operators]
* [https://github.com/WordPress/WordPress-Coding-Standards/pull/2130 WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators]
Props jrf.
See #59161 , #58831 .
Built from https://develop.svn.wordpress.org/trunk@56549
git-svn-id: http://core.svn.wordpress.org/trunk@56061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-09-09 09:28:26 +00:00
803426a023
Coding Standards: Use strict comparison in bundled themes' PHP files.
...
This addresses all the remaining WPCS warnings in bundled themes.
Includes using the correct type when checking the number of comments, as `get_comments_number()` returns a numeric string, not an integer.
Follow-up to [41285], [44562], [47941].
Props aristath, poena, afercia, SergeyBiryukov.
See #56791 .
Built from https://develop.svn.wordpress.org/trunk@55420
git-svn-id: http://core.svn.wordpress.org/trunk@54953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-02-24 06:23:23 +00:00
a3a61c5a3e
General: Remove role="navigation" from nav elements.
...
Role="navigation" was required for assistive technology to recognize HTML5 element's native ARIA roles while HTML5 and ARIA were being introduced. With the deprecation of IE11, the role attribute is only required when mapping elements that don't have native role.
Props costdev, mukesh27.
Fixes #54054 .
Built from https://develop.svn.wordpress.org/trunk@51967
git-svn-id: http://core.svn.wordpress.org/trunk@51556 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-11-01 21:47:13 +00:00
a2d42351c5
Text Changes: Unify various "Back to..." vs. "Return to..." vs. "Go to..." strings.
...
Standardize on "Go to..." as a more appropriate option for most cases.
Props garrett-eclipse, kharisblank, audrasjb, ramiy, valentinbora.
Fixes #47235 .
Built from https://develop.svn.wordpress.org/trunk@49539
git-svn-id: http://core.svn.wordpress.org/trunk@49277 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-11-09 10:53:10 +00:00
1f85e7484f
Docs: Consistently use third-person singular verbs for various filter descriptions, per the documentation standards.
...
See #50768 .
Built from https://develop.svn.wordpress.org/trunk@48782
git-svn-id: http://core.svn.wordpress.org/trunk@48544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-08-11 00:34:08 +00:00
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
e199663322
I18N: Capitalize translator comments consistently, add trailing punctuation.
...
Includes minor code layout fixes.
See #44360 .
Built from https://develop.svn.wordpress.org/trunk@45932
git-svn-id: http://core.svn.wordpress.org/trunk@45743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-03 00:41:05 +00:00
c71bc1513e
Coding Standards: Add missing translator comments to the default themes.
...
All default themes now have translator comments for all strings with placeholders!
See #46732 .
Built from https://develop.svn.wordpress.org/trunk@45609
git-svn-id: http://core.svn.wordpress.org/trunk@45420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-07-09 01:10:00 +00:00
a583725622
Docs: Update Codex references to the `Template_Hierarchy` page.
...
https://codex.wordpress.org/Template_Hierarchy redirects to https://developer.wordpress.org/themes/basics/template-hierarchy/ , so we should link to the correct page.
Props kmeze, pento.
Fixes #45222 .
Built from https://develop.svn.wordpress.org/trunk@44496
git-svn-id: http://core.svn.wordpress.org/trunk@44327 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-09 05:09:51 +00:00
56c162fbc9
Coding Standards: Upgrade WPCS to 1.0.0
...
WPCS 1.0.0 includes a bunch of new auto-fixers, which drops the number of coding standards issues across WordPress significantly. Prior to running the auto-fixers, there were 15,312 issues detected. With this commit, we now drop to 4,769 issues.
This change includes three notable additions:
- Multiline function calls must now put each parameter on a new line.
- Auto-formatting files is now part of the `grunt precommit` script.
- Auto-fixable coding standards issues will now cause Travis failures.
Fixes #44600 .
Built from https://develop.svn.wordpress.org/trunk@43571
git-svn-id: http://core.svn.wordpress.org/trunk@43400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2018-08-17 01:51:36 +00:00
aaf99e6913
Code is Poetry.
...
WordPress' code just... wasn't.
This is now dealt with.
Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057 .
Built from https://develop.svn.wordpress.org/trunk@42343
git-svn-id: http://core.svn.wordpress.org/trunk@42172 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2017-11-30 23:11:00 +00:00
64fc7294b6
Use HTTPS URLs for codex.wordpress.org.
...
see #27115 .
Built from https://develop.svn.wordpress.org/trunk@32116
git-svn-id: http://core.svn.wordpress.org/trunk@32095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-04-12 21:29:32 +00:00
078de57052
Twenty Twelve: fix escaping and minor code style issues. See #29127 .
...
Built from https://develop.svn.wordpress.org/trunk@31261
git-svn-id: http://core.svn.wordpress.org/trunk@31242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-01-21 21:00:21 +00:00
fd16ae485b
Avoid a PHP notice in bundled themes if no images were found.
...
props nabil_kadimi.
fixes #28361 .
Built from https://develop.svn.wordpress.org/trunk@28585
git-svn-id: http://core.svn.wordpress.org/trunk@28410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2014-05-27 10:55:30 +00:00
f5eb32ec6b
Default themes: Don't use /** docblocks for simple multiline comments.
...
props DrewAPicture, ericlewis.
fixes #25256 .
Built from https://develop.svn.wordpress.org/trunk@25746
git-svn-id: http://core.svn.wordpress.org/trunk@25659 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-10-09 20:39:09 +00:00
4a9b21226c
Twenty Twelve: update code comments to reflect WP inline docs standards. Props DrewAPicture, see #25256 .
...
Built from https://develop.svn.wordpress.org/trunk@25521
git-svn-id: http://core.svn.wordpress.org/trunk@25441 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2013-09-20 19:24:09 +00:00
47cf131418
Twenty Twelve: remove invalid `pubdate` value from time elements. See #22095 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-10-11 23:39:24 +00:00
3d954a4b60
Add tag.php and category.php to Twenty Twelve. While by no means required, it pulls some extra logic out of archive.php, instead leveraging the template hierarchy so it is hopefully more understandable to users tweaking their themes. Use alternative control structure syntax in all templates. fixes #21951 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@22048 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-09-27 07:01:16 +00:00
f4116da75a
Twenty Twelve: add missing period in meta section of the 'image.php' template. Props viniciusmassuchetto, fixes #21695 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21634 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-28 01:15:13 +00:00
70ffe26854
Twenty Twelve: review and clean up end-of-element HTML comments. Props obenland for starter patch. Closes #21675 .
...
git-svn-id: http://core.svn.wordpress.org/trunk@21618 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-25 17:16:56 +00:00
1d9662043e
Twenty Twelve: CSS and markup improvements for better child theme support, part 3. See #21379 .
...
* Add classes like `.site` and `.site-content` in addition to the set of IDs already present, making things much better for child themes to have more than one generic element like `nav` inside the content container.
* Bump JS version after selector change.
* Move `image-attachment` to `post_class()` output
More exhaustive notes in the ticket on each id and class change.
git-svn-id: http://core.svn.wordpress.org/trunk@21404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-08-02 19:12:11 +00:00
741876a148
The Twenty Twelve for WordPress.
...
props drewstrojny, lancewillett.
also props corvannoorloos, jeffsebring, kobenland, iandstewart, mfields,
mtdesign, op12no2, philiparthurmoore, sixhours, mamaduka.
see #19978 .
git-svn-id: http://core.svn.wordpress.org/trunk@21261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-07-12 04:20:46 +00:00
edb6c96b9f
Remove Twenty Twelve from 3.4. see #19978 . see http://wp.me/pbNCB-yA .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-03-20 18:41:54 +00:00
9f74f12084
Twenty Twelve: remove test lines from r20003
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20004 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 03:14:00 +00:00
9a3c274cb9
Twenty Twelve: use the time element for image attachment views, and `esc_html()` for `get_the_date()` in the element's output. Props iandstewart, see #19978 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@20003 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-28 03:10:53 +00:00
02ea26c01f
Twenty Twelve: add ARIA role of "navigation" to the all nav elements. Props iandstewart, see #19978 .
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19960 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-21 06:34:36 +00:00
a577a1faf8
Initial import of the Twenty Twelve theme, by Drew Strojny. This time around we're trying something different than the previous twenty-something themes, a much more minimalist approach that affords easy use as a CMS in addition to being blog-forward. More information will be on wpdevel soon. Props drewstrojny and lancewillett.
...
git-svn-id: http://svn.automattic.com/wordpress/trunk@19842 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2012-02-06 22:23:41 +00:00
Sergey Biryukov
joedolson
Gary Pendergast
Dominik Schilling
Lance Willett
Andrew Nacin
lancewillett
nacin
matt