WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
43,163 Commits 50 Branches 749 Tags 981 MiB
Commit Graph

411 Commits

Author SHA1 Message Date
Dominik Schilling a5b8dca864 Database: Support backticks around field names when parsing a query for the field type. 
Avoids an undefined index PHP warning by `dbDelta()`.

Props davidmosterd, ocean90.
See #20263.
Built from https://develop.svn.wordpress.org/trunk@37538


git-svn-id: http://core.svn.wordpress.org/trunk@37506 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 18:12:28 +00:00
Dominik Schilling 00487d5762 Database: Remove debug comments in `dbDelta()`. 
Built from https://develop.svn.wordpress.org/trunk@37533


git-svn-id: http://core.svn.wordpress.org/trunk@37501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 15:04:28 +00:00
Dominik Schilling e5a87afb29 Database: Reduce the number of `strtolower()` calls in `dbDelta()`. 
Fixes #36919.
Built from https://develop.svn.wordpress.org/trunk@37532


git-svn-id: http://core.svn.wordpress.org/trunk@37500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 14:58:27 +00:00
Gary Pendergast 18ca26574b Database: `dbDelta()` will no longer try to downgrade the size of `TEXT` and `BLOB` columns. 
When upgrading to `utf8mb4`, `TEXT` fields will be upgraded to `MEDIUMTEXT` (and likewise for all other `*TEXT` and `*BLOB` fields). This is to allow for the additional space requirements of `utf8mb4`.

On the subsequent upgrade, after the `utf8mb4` upgrade, `dbDelta()` would try and downgrade the fields to their original size again. At best, this it a waste of time, at worst, this could truncate any data larger than the original size. There's no harm in leaving them at their original size, so let's do that.

Fixes #36748.


Built from https://develop.svn.wordpress.org/trunk@37525


git-svn-id: http://core.svn.wordpress.org/trunk@37493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-23 08:36:28 +00:00
Drew Jaynes c3055cc190 Docs: Standardize hook docs in wp-admin/* to use third-person singular verbs per the inline documentation standards for PHP. 
See #36913.

Built from https://develop.svn.wordpress.org/trunk@37488


git-svn-id: http://core.svn.wordpress.org/trunk@37456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-05-22 18:01:30 +00:00
Andrew Ozz 13c885bdce TinyMCE, inline link: 
- Remove unused user setting for wpLink.
- Remove redundant text and variable from wp_link_dialog().

Props afercia, azaozz.
See #33301.
Built from https://develop.svn.wordpress.org/trunk@36985


git-svn-id: http://core.svn.wordpress.org/trunk@36952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-14 01:39:26 +00:00
Drew Jaynes 56fb3cc08d Docs: Improve documentation for `upgrade_450()`, introduced in [36180]. 
See #27772, #35323. See #35986.

Built from https://develop.svn.wordpress.org/trunk@36825


git-svn-id: http://core.svn.wordpress.org/trunk@36792 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-03-03 09:01:26 +00:00
Dominik Schilling c38daf6a7e Upgrade: Bump db version for `upgrade_450()` in `upgrade_all()`. 
See #23358.
Built from https://develop.svn.wordpress.org/trunk@36686


git-svn-id: http://core.svn.wordpress.org/trunk@36653 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-02-24 16:34:25 +00:00
Dominik Schilling 86690daf0b Multisite: Switch to a usermeta key for email confirmation. 
To prevent inconsistent data across sites in a network the new email address is now stored in usermeta. Adds visual feedback for the case when an update has failed.
All existing options will be removed on a database upgrade.

Props MikeHansenMe, kovshenin, jeremyfelt, ocean90.
Fixes #23358.
Built from https://develop.svn.wordpress.org/trunk@36679


git-svn-id: http://core.svn.wordpress.org/trunk@36646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-02-24 15:34:28 +00:00
Eric Lewis 22467e840f Networks and sites: Replace "blog" usage with "site" in docs. 
Multisite functions use the term "blog" to refer to what we now call a "site," e.g. `get_current_blog_id()`. These functions are here to stay because of our commitment to backwards compatibility. What we can do is set the documentation straight.

See #35417.

Built from https://develop.svn.wordpress.org/trunk@36416


git-svn-id: http://core.svn.wordpress.org/trunk@36383 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-28 03:35:27 +00:00
Dion Hulse 06a3f799e7 Background Updates: Remove the 7am/7pm background update check. This check was made redundant by [28129] as background updates are now run after a version check takes place. 
See #27772, #35323.

Built from https://develop.svn.wordpress.org/trunk@36180


git-svn-id: http://core.svn.wordpress.org/trunk@36147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2016-01-06 06:12:26 +00:00
Drew Jaynes c9a11ae9f2 Docs: Mark the `upgrade_XX()` functions to be ignored from parsing for the Code Reference. 
There is no great value in generating reference pages for these funcitons as they explicitly serve a core-only purpose.

See #32246.

Built from https://develop.svn.wordpress.org/trunk@35966


git-svn-id: http://core.svn.wordpress.org/trunk@35931 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-12-16 17:59:27 +00:00
Boone Gorges f173cdfb18 On 4.4 upgrade, remove the unused 'add_users' cap from all roles. 
Fixes #16719.
Built from https://develop.svn.wordpress.org/trunk@35701


git-svn-id: http://core.svn.wordpress.org/trunk@35665 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-11-19 03:53:28 +00:00
Sergey Biryukov db8c89cccb Remove non-translatable HTML code from the first post content in `populate_network()` and `wp_install_defaults()`. 
Add translator comment.

Props ramiy.
Fixes #34619.
Built from https://develop.svn.wordpress.org/trunk@35614


git-svn-id: http://core.svn.wordpress.org/trunk@35578 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-11-11 20:55:26 +00:00
Gary Pendergast c39ae3e5e2 Upgrades: Add support for `FULLTEXT` indexes to `dbDelta()`. 
Props edirect24, mdawaffe, pento.

Fixes #14445.


Built from https://develop.svn.wordpress.org/trunk@35487


git-svn-id: http://core.svn.wordpress.org/trunk@35451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-11-01 23:10:25 +00:00
Drew Jaynes 217b661703 Docs: Add missing descriptions for the `$wpdb` global in DocBlocks all the places. 
See #32246.

Built from https://develop.svn.wordpress.org/trunk@35170


git-svn-id: http://core.svn.wordpress.org/trunk@35136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-14 23:44:25 +00:00
Sergey Biryukov 3c7b7f7133 After [34529], if a compatible `termmeta` table is found on database upgrade, convert it to `utf8mb4` collation. 
Props dboulet.
Fixes #34224.
Built from https://develop.svn.wordpress.org/trunk@34978


git-svn-id: http://core.svn.wordpress.org/trunk@34943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-09 02:07:25 +00:00
Jeremy Felt 9926983b66 Revert [34778], continue using `_site_option()` for the current network. 
The `_network_option()` parameter order will be changing to accept `$network_id` first. The `_site_option()` functions will remain in use throughout core as our way of retrieving a network option for the current network.

See #28290.

Built from https://develop.svn.wordpress.org/trunk@34912


git-svn-id: http://core.svn.wordpress.org/trunk@34877 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-07 17:11:25 +00:00
Jeremy Felt 54512d64cb MS: Use `*_network_option()` functions throughout core. 
Replaces all uses of `*_site_option()` with the corresponding "network" function.

This excludes one usage in `wp-admin/admin-footer.php` that needs more investigation.

Props spacedmonkey.
See #28290.

Built from https://develop.svn.wordpress.org/trunk@34778


git-svn-id: http://core.svn.wordpress.org/trunk@34743 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-10-02 19:08:26 +00:00
Boone Gorges 8b4a5d1ec0 Introduce metadata for taxonomy terms. 
Adds a new table to the database schema (`wp_termmeta`), and a set of
`*_term_meta()` API functions. `get_terms()` and `wp_get_object_terms()`
now also support 'meta_query' parameters, with syntax identical to other
uses of `WP_Meta_Query`.

When fetching terms via `get_terms()` or `wp_get_object_terms()`, metadata for
matched terms is preloaded into the cache by default. Disable this behavior
by setting the new `$update_term_meta_cache` paramater to `false`.

To maximize performance, within `WP_Query` loops, the termmeta cache is *not*
primed by default. Instead, we use a lazy-loading technique: metadata for all
terms belonging to posts in the loop is loaded into the cache the first time
that `get_term_meta()` is called within the loop.

Props boonebgorges, sirzooro.
See #10142.
Built from https://develop.svn.wordpress.org/trunk@34529


git-svn-id: http://core.svn.wordpress.org/trunk@34493 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-25 03:59:27 +00:00
Gary Pendergast 0d85038ce6 Schema: Increase the length of `wp_options.option_name`. 
It's pretty easy to run over the `option_name` length, which causes undefined behaviour when inserting and retrieving options. Increasing the length from `VARCHAR(64)` to `VARCHAR(191)` significantly reduces the risk of this occurring.

Because `option_name` has a `UNIQUE` index, we can only increase it to 191 characters, rather than 255. The index can only use a prefix of 191 characters, so will incorrectly restrict long different strings that have the same prefix, if we make the column longer.

Props scribu, OriginalEXE, khromov, MikeHansenMe, netweb, pento.

Fixes #13310.


Built from https://develop.svn.wordpress.org/trunk@34030


git-svn-id: http://core.svn.wordpress.org/trunk@33999 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-09-11 01:26:24 +00:00
Scott Taylor ef87172270 `foreach` is a statement, not a function. 
See #33491.

Built from https://develop.svn.wordpress.org/trunk@33734


git-svn-id: http://core.svn.wordpress.org/trunk@33702 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 20:28:22 +00:00
Dion Hulse 4f8ce1c232 Term Splitting: Switch to a faster cron unschedule process to benefit sites with thousands of affected jobs. Fix the cron hook name in the failsafe rescheduler. 
Props Otto42, dd32, peterwilsoncc
See #33423

Built from https://develop.svn.wordpress.org/trunk@33727


git-svn-id: http://core.svn.wordpress.org/trunk@33695 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-25 04:32:21 +00:00
Scott Taylor e9305edbce When createing "Sample Page" on install, comments should be `closed`. 
Props macmanx. 
Fixes #33490.

Built from https://develop.svn.wordpress.org/trunk@33693


git-svn-id: http://core.svn.wordpress.org/trunk@33660 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-21 17:42:25 +00:00
Dion Hulse 25c5d372d3 Term Splitting: Fix a reversal of parameters to wp_schedule_single_event() introduced in [33621]. 
The existing invalid cron entries will not be purged automatically (as the 'timestamp' is never matched) so we do this ourselves.

Props mechter for noticing!
See #30261.
Fixes #33423 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33646


git-svn-id: http://core.svn.wordpress.org/trunk@33613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-19 11:31:26 +00:00
Dominik Schilling 96a6f0ac1f Pinking shears. 
Built from https://develop.svn.wordpress.org/trunk@33627


git-svn-id: http://core.svn.wordpress.org/trunk@33594 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 21:39:25 +00:00
Boone Gorges dba7c50d29 Don't run term-splitting routine on new installations. 
Props pento.
Fixes #30261.
Built from https://develop.svn.wordpress.org/trunk@33621


git-svn-id: http://core.svn.wordpress.org/trunk@33588 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-17 14:29:25 +00:00
Boone Gorges 151d27369d Term splitting routine should be run in a separate process, triggered via wp-cron. 
[32814] introduced a routine to split shared terms, which was run during the
regular WP database upgrade. This turned out to be problematic because plugins
are not loaded during the db upgrade (due to `WP_INSTALLING`), with the result
that plugins were not able to hook into the 'split_shared_term' action during
the bulk split. We work around this limitation by moving the term splitting
routine to a separate process, triggered by a wp-cron hook.

Props boonebgorges, Chouby, peterwilsoncc, pento, dd32.
Fixes #30261.
Built from https://develop.svn.wordpress.org/trunk@33615


git-svn-id: http://core.svn.wordpress.org/trunk@33582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-14 03:59:26 +00:00
Andrew Ozz 3bfd096440 Fix paste typos in upgrade.php. 
Props tellyworth. Fixes #33206.
Built from https://develop.svn.wordpress.org/trunk@33609


git-svn-id: http://core.svn.wordpress.org/trunk@33576 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-11 23:44:24 +00:00
Dion Hulse e2b10dad49 Upgrade: Skip the sitecategories table when it doesn't exist (Global Terms is disabled). 
Props nofearinc, obenland, SergeyBiryukov, and pento.
Fixes #33206

Built from https://develop.svn.wordpress.org/trunk@33597


git-svn-id: http://core.svn.wordpress.org/trunk@33564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-08-09 02:22:26 +00:00
Drew Jaynes e4ecc7e5c4 Fix summaries and add missing `@global` descriptions to the `upgrade_430_fix_comments()` and `split_all_shared_terms()` functions added in 4.3. 
See [33020], [32643]. See #32891.

Built from https://develop.svn.wordpress.org/trunk@33212


git-svn-id: http://core.svn.wordpress.org/trunk@33184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-13 19:56:24 +00:00
Dion Hulse 36de491d68 Don't upgrade global tables to utf8mb4 when `wp_should_upgrade_global_tables()` says not to. 
Additionally fixes an incorrect conditional in [33057] which would result in the usermeta index being altered twice on Multisite updates.

See #32154

Built from https://develop.svn.wordpress.org/trunk@33058


git-svn-id: http://core.svn.wordpress.org/trunk@33029 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 05:44:24 +00:00
Dion Hulse d651de0dac Introduce `wp_should_upgrade_global_tables()` to determine if global tables should be upgraded automatically. Use it throughout the existing upgrade routines. 
Props johnjamesjacoby for initial patch
Fixes #32154 for trunk

Built from https://develop.svn.wordpress.org/trunk@33057


git-svn-id: http://core.svn.wordpress.org/trunk@33028 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 04:34:24 +00:00
Dion Hulse cbacb92dae Enable utf8mb4 for MySQL extension users. Previously utf8mb4 was limited to MySQLi users only unintentionally. 
This change does the following things
 * Allows utf8mb4 for the MySQL extension
 * Re-runs the utf8->utf8mb4 conversion for single sites, this will do nothing for tables already converted
 * Re-runs the utf8->utf8mb4 conversion for global tables in multisite when the environment supports utf8mb4
 * Removes upgrade_420() calling as upgrade_430() will perform those changes now instead

The index shortenings should have still taken place on utf8 sites previously, so there's no need to run those again. 

Props kovshenin, pento, dd32
Fixes #32127 for trunk.

Built from https://develop.svn.wordpress.org/trunk@33055


git-svn-id: http://core.svn.wordpress.org/trunk@33026 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-03 03:26:24 +00:00
Dion Hulse ebb6aa1d4a Split `upgrade_430()` into two so that `split_all_shared_terms()` runs when `upgrade_430_fix_comments()` bails early. 
See [32814], #30261, [32364], #32165

Built from https://develop.svn.wordpress.org/trunk@33020


git-svn-id: http://core.svn.wordpress.org/trunk@32991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-07-01 07:35:24 +00:00
Dion Hulse a21f890abb Remove a redundant index drop, it'll be dropped and re-created a few lines further down. 
Fixes a warning during updating from 4.0 or earlier.
Fixes #31388 for trunk

Built from https://develop.svn.wordpress.org/trunk@32852


git-svn-id: http://core.svn.wordpress.org/trunk@32823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-19 03:18:26 +00:00
Boone Gorges f62bf61b2c Bail out of 4.3 term splitting routine when no shared terms are found. 
Props dd32.
See #30261.
Built from https://develop.svn.wordpress.org/trunk@32819


git-svn-id: http://core.svn.wordpress.org/trunk@32790 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 11:40:24 +00:00
Boone Gorges 290044ef15 Split all shared taxonomy terms on upgrade to 4.3. 
Dear Shared Terms, Welcome to Splitsville. Population: You.

See #30261.
Built from https://develop.svn.wordpress.org/trunk@32814


git-svn-id: http://core.svn.wordpress.org/trunk@32785 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-17 01:53:26 +00:00
Andrew Nacin e7f618d86e Tweak the first post/page content to get with the times. 
props chriscct7.
fixes #22474.

Built from https://develop.svn.wordpress.org/trunk@32768


git-svn-id: http://core.svn.wordpress.org/trunk@32739 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-06-14 18:56:50 +00:00
Scott Taylor c6a4512b1b Add missing doc blocks to `wp-admin/includes/*`. 
Fix some egregious uses of tabbing.
Some functions can simply return `apply_filters(...)` instead of setting a variable that is immediately returned.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32654


git-svn-id: http://core.svn.wordpress.org/trunk@32624 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 20:17:26 +00:00
Scott Taylor 282e28ad81 Add `@global` annotations to (the rest of the?) `wp-admin/*` files. 
Does not include list table file changes.

See #32444.

Built from https://develop.svn.wordpress.org/trunk@32643


git-svn-id: http://core.svn.wordpress.org/trunk@32613 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-29 02:06:31 +00:00
Gary Pendergast 02621f2a14 Upgrades: If a table has already been converted to `utf8mb4`, there's no need to try and convert it again. 
Props gabrielperezs for the initial patch.

See #32310.


Built from https://develop.svn.wordpress.org/trunk@32456


git-svn-id: http://core.svn.wordpress.org/trunk@32426 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-08 12:22:25 +00:00
Michael Adams a3807c1d34 Upgrade: Since MySQL may auto-expand column widths when changing a column's character set, we must do our length-based comment checks prior to the character set changes. 
Props jorbin, et alii.

See #32165.

Built from https://develop.svn.wordpress.org/trunk@32440


git-svn-id: http://core.svn.wordpress.org/trunk@32410 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-07 01:11:29 +00:00
Michael Adams 26c3c6d9cb Upgrade: `$wpdb->get_col_length()` sanity check: bail on unexpected return value. 
See #32165.

Built from https://develop.svn.wordpress.org/trunk@32429


git-svn-id: http://core.svn.wordpress.org/trunk@32399 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 23:11:26 +00:00
Michael Adams 0640526e72 Upgrade: Ensure unintelligible DB schemas don't result in content loss. 
See #32165.

Built from https://develop.svn.wordpress.org/trunk@32417


git-svn-id: http://core.svn.wordpress.org/trunk@32387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 21:46:26 +00:00
Gary Pendergast 4e615fb9ff Fix an incorrect version number check in [32378]. 
See #32099.


Built from https://develop.svn.wordpress.org/trunk@32379


git-svn-id: http://core.svn.wordpress.org/trunk@32349 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 07:41:24 +00:00
Gary Pendergast 3a6e79c409 Upgrades: When converting to `utf8mb4`, we were trying to change the wrong index on `wp_signups`, causing the conversion to later fail. 
Props kovshenin, pento.

See #32099.


Built from https://develop.svn.wordpress.org/trunk@32378


git-svn-id: http://core.svn.wordpress.org/trunk@32348 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 07:34:24 +00:00
Gary Pendergast 364886a5be WPDB: When checking that a string can be sent to MySQL, we shouldn't use `mb_convert_encoding()`, as it behaves differently to MySQL's character encoding conversion. 
Props mdawaffe, pento, nbachiyski, jorbin, johnjamesjacoby, jeremyfelt.

See #32165.


Built from https://develop.svn.wordpress.org/trunk@32364


git-svn-id: http://core.svn.wordpress.org/trunk@32335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-05-06 03:00:25 +00:00
Gary Pendergast 44b56d9393 When deleting suspicious comments, do so permanently. 
Built from https://develop.svn.wordpress.org/trunk@32310


git-svn-id: http://core.svn.wordpress.org/trunk@32281 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-27 16:11:26 +00:00
Gary Pendergast b89fc65951 [32308] was for 4.3, not 4.2.1. 
Built from https://develop.svn.wordpress.org/trunk@32309


git-svn-id: http://core.svn.wordpress.org/trunk@32280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-27 16:08:27 +00:00
Gary Pendergast 51402dc520 When upgrading to 4.2.1, delete suspicious comments. 
Built from https://develop.svn.wordpress.org/trunk@32308


git-svn-id: http://core.svn.wordpress.org/trunk@32279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-27 16:04:25 +00:00
Gary Pendergast 0179958273 When `dbDelta()` is checking whether an index is defined in a `CREATE TABLE` statement, don't worry if MySQL has a subpart defined on an index, but the `CREATE TABLE` doesn't. 
Fixes #31869.


Built from https://develop.svn.wordpress.org/trunk@32108


git-svn-id: http://core.svn.wordpress.org/trunk@32087 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-11 10:40:31 +00:00
Sergey Biryukov 443760252b `wp_install_maybe_enable_pretty_permalinks()` should have a consistent `@return` value. 
props DrewAPicture.
fixes #6481. see #31888.
Built from https://develop.svn.wordpress.org/trunk@32027


git-svn-id: http://core.svn.wordpress.org/trunk@32006 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-04-05 14:49:53 +00:00
Gary Pendergast d7c6ac95bc Upgrades: wp_usermeta is a global table in multisite, so it should only be upgraded by the single site routines when we're not in a multisite install. 
See #21212


Built from https://develop.svn.wordpress.org/trunk@31358


git-svn-id: http://core.svn.wordpress.org/trunk@31339 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 13:41:22 +00:00
Gary Pendergast 7444799a82 Upgrades: When upgrading a table to utf8mb4, we should run the `ALTER TABLE` query, even if it doesn't have any text columns. This will update the table's default character set, so that any text columns added in the future will have the expected character set. 
See #21212 


Built from https://develop.svn.wordpress.org/trunk@31354


git-svn-id: http://core.svn.wordpress.org/trunk@31335 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 05:59:23 +00:00
Gary Pendergast 555a9f0912 Upgrades: When deciding if we can upgrade a table to utf8mb4, make sure we're checking the character set, not the collation. 
Bump the DB version as well, as the update in [31349] wouldn't have triggered for anyone who tried it.

See #21212


Built from https://develop.svn.wordpress.org/trunk@31351


git-svn-id: http://core.svn.wordpress.org/trunk@31332 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 05:26:21 +00:00
Gary Pendergast b2cf823105 WPDB: If a site is using the `utf8` charset, and their version of MySQL supports `utf8mb4`, auto-upgrade them to `utf8mb4`. 
This patch also resizes some indexes, to allow for the 767 byte index size limit in standard MySQL installs.

See #21212


Built from https://develop.svn.wordpress.org/trunk@31349


git-svn-id: http://core.svn.wordpress.org/trunk@31330 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-02-06 04:51:22 +00:00
Drew Jaynes d95586e943 Add missing summaries and descriptions for various functions in wp-admin/includes/upgrade.php. 
Also generally improve existing parameter, return, and other documentation in various function DocBlocks.

Props morganestes.
Fixes #30825.

Built from https://develop.svn.wordpress.org/trunk@31246


git-svn-id: http://core.svn.wordpress.org/trunk@31227 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-19 09:15:22 +00:00
Sergey Biryukov 768624cb99 Use the site's local time to create the first post during installation. 
props extendwings.
fixes #29296.
Built from https://develop.svn.wordpress.org/trunk@31225


git-svn-id: http://core.svn.wordpress.org/trunk@31206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-17 10:07:23 +00:00
Scott Taylor b8dd1f9c69 By initializing this array before a loop, Scrutinizer reports 0 (zero) "Coding Style" errors. 
There are plenty of other kinds of errors, but this label will be cleared out.

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31213


git-svn-id: http://core.svn.wordpress.org/trunk@31194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-16 19:13:23 +00:00
Dion Hulse af92025162 More concise documentation for wp_install_maybe_enable_pretty_permalinks() 
See #6481. Props ericlewis.

Built from https://develop.svn.wordpress.org/trunk@31160


git-svn-id: http://core.svn.wordpress.org/trunk@31141 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 04:33:23 +00:00
Dion Hulse a114d0929b The new wp_install_maybe_enable_pretty_permalinks() function doesn't need to be pluggable. 
See #6481. Props nacin, valendesigns

Built from https://develop.svn.wordpress.org/trunk@31159


git-svn-id: http://core.svn.wordpress.org/trunk@31140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-12 04:31:23 +00:00
Scott Taylor 60b0cd7943 The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words. 
This was a mess, is now standardized across the codebase, except for a few 3rd-party libs. 

See #30799.

Built from https://develop.svn.wordpress.org/trunk@31090


git-svn-id: http://core.svn.wordpress.org/trunk@31071 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 07:05:25 +00:00
Dion Hulse a4ed093250 Enable Pretty Permalinks for new sites during install if the server supports it. 
See #6481, Props valendesigns, DrewAPicture & ericlewis

Built from https://develop.svn.wordpress.org/trunk@31089


git-svn-id: http://core.svn.wordpress.org/trunk@31070 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2015-01-08 06:47:23 +00:00
Scott Taylor 5eb5afac34 For clarity, initialize some arrays that previously were only assigned via short circuit in loops. 
See #30799.

Built from https://develop.svn.wordpress.org/trunk@30982


git-svn-id: http://core.svn.wordpress.org/trunk@30968 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-20 22:47:22 +00:00
Andrew Nacin 1cf7a49ffd Adjust [29806] and revert [29807] to restore placeholder and email copy order. 
Avoids unnecessarily changing a (large, carefully formatted) translated string from 4.0.

fixes #21089.

Built from https://develop.svn.wordpress.org/trunk@30742


git-svn-id: http://core.svn.wordpress.org/trunk@30732 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-05 01:15:26 +00:00
Scott Taylor 2c32752abd Improve various `@param` docs for `src/wp-admin/*`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30680


git-svn-id: http://core.svn.wordpress.org/trunk@30670 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-12-01 01:00:22 +00:00
Scott Taylor 7d7a8aa0eb Correct all `@return unknown` instances. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30202


git-svn-id: http://core.svn.wordpress.org/trunk@30202 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 06:17:22 +00:00
Scott Taylor 5a3256c00b Fill in the `@param` types for the args for `make_site_theme_from_default()`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30195


git-svn-id: http://core.svn.wordpress.org/trunk@30195 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:43:21 +00:00
Scott Taylor ef944e8c19 Fill in the `@param` types for the args for `make_site_theme_from_oldschool()`, which is actually the name of a function? 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30194


git-svn-id: http://core.svn.wordpress.org/trunk@30194 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:41:23 +00:00
Scott Taylor 082a1d06ae Fill in the `@param` types for the args for `dbDelta()`. 
See #30224.

Built from https://develop.svn.wordpress.org/trunk@30193


git-svn-id: http://core.svn.wordpress.org/trunk@30193 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-03 05:40:22 +00:00
Boone Gorges e9f6ee53bb Fix database schema update introduced in [30121]. 
The index must be manually dropped before `dbDelta()` can add the new index
without throwing a notice.

Fixes #22023.
Built from https://develop.svn.wordpress.org/trunk@30134


git-svn-id: http://core.svn.wordpress.org/trunk@30134 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-11-01 01:11:22 +00:00
Boone Gorges 70631df84a Bump db_version and add upgrade routine for schema change in [30056]. 
Fixes #22023.
Built from https://develop.svn.wordpress.org/trunk@30121


git-svn-id: http://core.svn.wordpress.org/trunk@30121 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-31 16:03:22 +00:00
Sergey Biryukov 16a55620c3 Twenty Fifteen: Update some more bundled theme references after [29895]. 
see #29799.
Built from https://develop.svn.wordpress.org/trunk@29900


git-svn-id: http://core.svn.wordpress.org/trunk@29655 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-15 14:35:18 +00:00
Sergey Biryukov be631b3f1b Reorder placeholders for consistency. see [29806]. 
see #21089.
Built from https://develop.svn.wordpress.org/trunk@29807


git-svn-id: http://core.svn.wordpress.org/trunk@29573 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-02 01:38:15 +00:00
Scott Taylor 258496edb6 In the `wp_new_blog_notification()` email template, include the login url. 
Props obenland, georgestephanis.
Fixes #21089.

Built from https://develop.svn.wordpress.org/trunk@29806


git-svn-id: http://core.svn.wordpress.org/trunk@29572 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-10-02 01:28:16 +00:00
Dominik Schilling d544610681 Language packs: No WPLANG anymore. 
* The WPLANG constant is no longer needed. Remove define('WPLANG', ''); from wp-config-sample.php. Populate WPLANG option based on the WPLANG constant. When get_option('WPLANG') is an empty string it will override WPLANG.
* Introduce translations_api() which is available to communicate with the translation API. Move translation install related functions to a new file.
* Replace mu_dropdown_languages() with wp_dropdown_languages(). wp_dropdown_languages() is now populated by the translation API.
* Remove wp_install_load_language() and allow load_default_textdomain() to switch a core translation.

fixes #13069, #15677, #19760, #28730, #29281. 
Built from https://develop.svn.wordpress.org/trunk@29630


git-svn-id: http://core.svn.wordpress.org/trunk@29404 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-26 19:59:16 +00:00
Andrew Nacin 40258a41b8 Language chooser imporvements. 
* Use a translated 'Continue' string.
 * Go back to using a select element.
 * Only show a spinner when we're installing a language. 

see #28577.

Built from https://develop.svn.wordpress.org/trunk@29372


git-svn-id: http://core.svn.wordpress.org/trunk@29150 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-08-04 20:47:16 +00:00
John Blackbourn 4d53ee7d45 Add a `lang` attribute to each language listed on the language selector screen during installation. See #28858, #28577. 
Built from https://develop.svn.wordpress.org/trunk@29260


git-svn-id: http://core.svn.wordpress.org/trunk@29043 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-21 21:51:16 +00:00
Drew Jaynes 097dc8ee15 Fix syntax for single- and multi-line comments in wp-admin-directory files. 
See #28931.

Built from https://develop.svn.wordpress.org/trunk@29206


git-svn-id: http://core.svn.wordpress.org/trunk@28990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-17 09:14:16 +00:00
Drew Jaynes 204a4bc6bf Inline documentation cleanup for 4.0 audit. 
* phpDoc tweaks for `wp_get_available_translations_from_api()`, `wp_install_download_language_pack()`, and `wp_install_load_language()`, added in [29018]
 
See #28885.

Built from https://develop.svn.wordpress.org/trunk@29154


git-svn-id: http://core.svn.wordpress.org/trunk@28938 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-14 00:17:15 +00:00
Andrew Nacin e9d2d8ead9 Unload the current default textdomain in wp_install_load_language(). 
see #28577.

Built from https://develop.svn.wordpress.org/trunk@29059


git-svn-id: http://core.svn.wordpress.org/trunk@28847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-10 09:55:14 +00:00
John Blackbourn d237bc419d Narrower layout and loading spinner for the install screen language selector. See #28577 
Built from https://develop.svn.wordpress.org/trunk@29021


git-svn-id: http://core.svn.wordpress.org/trunk@28809 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-08 00:33:15 +00:00
John Blackbourn 64f686b4c8 Focus and blur styling (via JS) for the install screen language selector. Props jorbin. See #28577 
Built from https://develop.svn.wordpress.org/trunk@29020


git-svn-id: http://core.svn.wordpress.org/trunk@28808 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-08 00:30:14 +00:00
Andrew Nacin bc47136605 Language on install: Docs and naming cleanups. see #28577. 
Built from https://develop.svn.wordpress.org/trunk@29018


git-svn-id: http://core.svn.wordpress.org/trunk@28806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-07 21:49:15 +00:00
John Blackbourn ea46c7423a Correct the usage of the variable passed to `wp_install_download_language_pack()` and kill an unused local variable. Props michalzuber. Also avoid using the `$_REQUEST` superglobal in this function. See #28577. 
Built from https://develop.svn.wordpress.org/trunk@29016


git-svn-id: http://core.svn.wordpress.org/trunk@28804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-07 18:06:15 +00:00
Andrew Nacin 7a1351b411 Bring the language chooser to setup-config.php. 
see #28577.

Built from https://develop.svn.wordpress.org/trunk@29006


git-svn-id: http://core.svn.wordpress.org/trunk@28794 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-07-05 05:14:15 +00:00
Andrew Nacin c504fb41a1 Allow a language to be chosen before installing WordPress. First pass. 
* Checks WordPress.org for available languages.
* In get_locale(), starts using the WPLANG option that has existed in multisite since the MU days.
* Adds new argument to wp_install() for setting WPLANG.

see #28577. 

Built from https://develop.svn.wordpress.org/trunk@28774


git-svn-id: http://core.svn.wordpress.org/trunk@28587 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-18 19:58:15 +00:00
Scott Taylor 05eeb16e30 Replace all uses of `like_escape()` with `$wpdb->esc_like()`. 
Props miqrogroove.
See #10041.

Built from https://develop.svn.wordpress.org/trunk@28712


git-svn-id: http://core.svn.wordpress.org/trunk@28528 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-06-10 00:44:15 +00:00
Scott Taylor c2d44c5736 In `wp-admin/includes/upgrade.php`, remove dead code: 
* In `maybe_create_table()` and `maybe_add_column()`, the response of `$wpdb->query()` is set to a variable that is never used.
* In `make_db_current_silent()`, which is a wrapper for `dbDelta`, a variable is set that is not used. This function appears to be a copy-paste of `make_db_current()`'s `dbDelta()` call but is meant to return nothing, and still does not.  

See #27882.

Built from https://develop.svn.wordpress.org/trunk@28305


git-svn-id: http://core.svn.wordpress.org/trunk@28133 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-05-06 17:27:15 +00:00
Drew Jaynes f6df2c6921 Use the correct parameter variables in the hook docs for `wp_upgrade`. 
See #27700.

Built from https://develop.svn.wordpress.org/trunk@27998


git-svn-id: http://core.svn.wordpress.org/trunk@27828 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-07 20:13:15 +00:00
Drew Jaynes a11553eafe Inline documentation for remaining hooks in wp-admin/includes/upgrade.php. 
Props jackreichert, vancoder.
Fixes #27646.

Built from https://develop.svn.wordpress.org/trunk@27965


git-svn-id: http://core.svn.wordpress.org/trunk@27795 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-04-05 22:30:14 +00:00
Andrew Nacin 0c16c0477b Reference https://wordpress.org rather than http://wordpress.org in strings, links, comments, etc. 
props Ipstenu, markjaquith.
see #27115.

Built from https://develop.svn.wordpress.org/trunk@27369


git-svn-id: http://core.svn.wordpress.org/trunk@27219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-03-03 02:34:27 +00:00
Andrew Nacin d39d60e841 Add wp_install and wp_upgrade hooks to the respective functions. 
props Denis-de-Bernardy.
fixes #25762.

Built from https://develop.svn.wordpress.org/trunk@27045


git-svn-id: http://core.svn.wordpress.org/trunk@26919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2014-01-27 16:32:12 +00:00
Andrew Nacin 8b8c8e96e7 Deactivate MP6 on update to 3.8. 
If left on, it introduces a lot of weird issues not easily diagnosed. MP6 will be updated before release to prevent itself from functioning 3.8+, but this will cut down on support requests by people who update core but not MP6, which was a fairly popular plugin.

fixes #26334.

Built from https://develop.svn.wordpress.org/trunk@26692


git-svn-id: http://core.svn.wordpress.org/trunk@26582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-05 21:30:11 +00:00
Andrew Nacin a3fba0096d In dbDelta(), ensure we are not running CREATE TABLE queries for global tables we wish to not upgrade. 
props fliespl.
fixes #22134.

Built from https://develop.svn.wordpress.org/trunk@26566


git-svn-id: http://core.svn.wordpress.org/trunk@26457 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-12-03 17:44:10 +00:00
Scott Taylor da05f7435b For unit tests that call `wpmu_create_blog()`, Blog factory, or installation code that attempts to clear transients: suppress database errors on `setUp` and restore on `tearDown`. 
There are a few places in core that were preventing this from working by explicity setting `$wpdb->suppress_errors` to `false`. Instead, they should inherit the value that existed before errors were suppressed.

This allows Multisite unit tests to run without explosive database errors, and allows `$wpdb->suppress_errors` to be overridden all the way down the chain.

Fixes #26102.

Built from https://develop.svn.wordpress.org/trunk@26252


git-svn-id: http://core.svn.wordpress.org/trunk@26158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-18 20:45:11 +00:00
Sergey Biryukov 0df020b516 Remove unused global reference. props jeremyfelt. fixes #26103. 
Built from https://develop.svn.wordpress.org/trunk@26251


git-svn-id: http://core.svn.wordpress.org/trunk@26157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-18 20:19:09 +00:00
Dion Hulse a71cd00cdb Background Updates: Spread them over the hour. Props Pento. Fixes #25833 for trunk 
Built from https://develop.svn.wordpress.org/trunk@26149


git-svn-id: http://core.svn.wordpress.org/trunk@26060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-14 04:04:10 +00:00
Sergey Biryukov 74f77b85a6 Use get_current_site() instead of the $current_site global when possible. 
props jeremyfelt.
fixes #25158.
Built from https://develop.svn.wordpress.org/trunk@26120


git-svn-id: http://core.svn.wordpress.org/trunk@26032 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-13 03:23:10 +00:00
Sergey Biryukov 72d4b140fb Make Twenty Fourteen the default theme. props markmcwilliams. fixes #25702. 
Built from https://develop.svn.wordpress.org/trunk@26024


git-svn-id: http://core.svn.wordpress.org/trunk@25955 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-11-06 20:02:09 +00:00
Andrew Nacin 27d04f9e5e Delete expired transients on database upgrades. 
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.

Built from https://develop.svn.wordpress.org/trunk@25838


git-svn-id: http://core.svn.wordpress.org/trunk@25838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:55:02 +00:00
Andrew Nacin 8ae8e01b67 Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25825 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-24 22:53:14 +00:00
Andrew Nacin 859da01c4a Delete expired transients on database upgrades. 
Reverts [25416], which had all transients being cleared. This leaves much to be desired, but we don't want a core update to be blamed for breaking a site that incorrectly assumes transients aren't transient.

props dartiss, pento.
fixes #20316.

Built from https://develop.svn.wordpress.org/trunk@25838


git-svn-id: http://core.svn.wordpress.org/trunk@25750 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-18 07:48:09 +00:00
Andrew Nacin 9432acde4e Remove the old wp_auto_updates_maybe_update cron event. Schedule the new wp_maybe_auto_update event at 7 a.m. and 7 p.m. in the site's timezone. 
see #27704.

Built from https://develop.svn.wordpress.org/trunk@25825


git-svn-id: http://core.svn.wordpress.org/trunk@25737 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-10-17 04:02:09 +00:00
Andrew Nacin 6931079cec Multisite blogs table: Convert the archived field from enum to tinyint to match the other status fields. fixes #12832. 
Built from https://develop.svn.wordpress.org/trunk@25448


git-svn-id: http://core.svn.wordpress.org/trunk@25369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-09-15 23:12:11 +00:00
Andrew Nacin af70c14d6d Add signup_id primary key to $wpdb->signups, and add better indexes. 
props josephscott, pento, barry.
see #15004.

Built from https://develop.svn.wordpress.org/trunk@25179


git-svn-id: http://core.svn.wordpress.org/trunk@25151 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-08-30 04:30:08 +00:00
Andrew Nacin 7d53bd66ed Use maybe_unserialize() in upgrade.php's private get_option() function. This actually predates maybe_unserialize() ([2487], [3234]). props leewillis77. fixes #24365. 
git-svn-id: http://core.svn.wordpress.org/trunk@24625 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-10 04:01:20 +00:00
Andrew Nacin 7f396bfab0 Avoid possible array collision in dbDelta when recording index adds. props apimlott, wonderboymusic. fixes #21272. 
git-svn-id: http://core.svn.wordpress.org/trunk@24584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-07-08 13:54:19 +00:00
Andrew Nacin d80469f8a5 Fix storage of illegal_names. Add an upgrade routine to fix bad values. 
props SergeyBiryukov.
see #23418.
for trunk.



git-svn-id: http://core.svn.wordpress.org/trunk@24448 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-06-19 22:06:42 +00:00
Andrew Nacin e7b2915ecd dbDelta: When parsing out the DEFAULT value, avoid being too greedy. props hbanken, fixes #15948. 
git-svn-id: http://core.svn.wordpress.org/trunk@24065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-22 22:00:50 +00:00
Sergey Biryukov 97e19c7c3a Fix typo in upgrade_100(). props tivnet, bpetty. fixes #24020. 
git-svn-id: http://core.svn.wordpress.org/trunk@23949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-04-10 16:04:36 +00:00
Ryan Boren f3a83744e9 Use wp_unslash() instead of stripslashes() and stripslashes_deep(). Use wp_slash() instead of add_magic_quotes(). 
git-svn-id: http://core.svn.wordpress.org/trunk@23567 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 17:14:09 +00:00
Ryan Boren 43a7e695e9 Revert 23416, 23419, 23445 except for wp_reset_vars() changes. We are going a different direction with the slashing cleanup, so resetting to a clean slate. see #21767 
git-svn-id: http://core.svn.wordpress.org/trunk@23554 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-03-01 16:28:40 +00:00
Andrew Nacin afd9cbced9 Make Twenty Thirteen the default theme. 
Has the added benefit of ensuring the WordPress Beta Tester plugin allows updates of Twenty Thirteen.

props JustinSainton.
fixes #23573.



git-svn-id: http://core.svn.wordpress.org/trunk@23529 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-28 19:01:07 +00:00
Ryan Boren cc5ed3a485 Change all core API to expect unslashed rather than slashed arguments. 
The exceptions to this are update_post_meta() and add_post_meta() which are often used by plugins in POST handlers and will continue accepting slashed data for now.

Introduce wp_upate_post_meta() and wp_add_post_meta() as unslashed alternatives to update_post_meta() and add_post_meta(). These functions could become methods in WP_Post so don't use them too heavily yet.

Remove all escape() calls from wp_xmlrpc_server. Now that core expects unslashed data this is no longer needed.

Remove addslashes(), addslashes_gpc(), add_magic_quotes() calls on data being prepared for handoff to core functions that until now expected slashed data. Adding slashes in no longer necessary.

Introduce wp_unslash() and use to it remove slashes from GPCS data before using it in core API. Almost every instance of stripslashes() in core should now be wp_unslash(). In the future (a release or three) when GPCS is no longer slashed, wp_unslash() will stop stripping slashes and simply return what is passed. At this point wp_unslash() calls can be removed from core.

Introduce wp_slash() for slashing GPCS data. This will also turn into a noop once GPCS is no longer slashed. wp_slash() should almost never be used. It is mainly of use in unit tests.

Plugins should use wp_unslash() on data being passed to core API.

Plugins should no longer slash data being passed to core. So when you get_post() and then wp_insert_post() the post data from get_post() no longer needs addslashes(). Most plugins were not bothering with this. They will magically start doing the right thing. Unfortunately, those few souls who did it properly will now have to avoid calling addslashes() for 3.6 and newer.

Use wp_kses_post() and wp_kses_data(), which expect unslashed data, instead of wp_filter_post_kses() and wp_filter_kses(), which expect slashed data. Filters are no longer passed slashed data.

Remove many no longer necessary calls to $wpdb->escape() and esc_sql().

In wp_get_referer() and wp_get_original_referer(), return unslashed data.

Remove old stripslashes() calls from WP_Widget::update() handlers. These haven't been necessary since WP_Widget.

Switch several queries over to prepare().

Expect something to break.

Props alexkingorg
see #21767


git-svn-id: http://core.svn.wordpress.org/trunk@23416 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-02-14 22:51:06 +00:00
Peter Westwood f683fc7677 Tighten our braces. Fixes #23118 props evansolomon. 
git-svn-id: http://core.svn.wordpress.org/trunk@23265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2013-01-04 10:13:51 +00:00
Andrew Nacin a8d599eae5 Fix disabling of the link manager on upgrade from 3.4.2 when there are no links. 
In the 3.4 branch we bumped the DB version past the version used for disabling links in trunk, preventing it from running. In the future, we must avoid increasing branch DB version bumps to HEAD.

props SergeyBiryukov.
fixes #22626.



git-svn-id: http://core.svn.wordpress.org/trunk@22911 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-29 00:37:30 +00:00
Andrew Nacin a5c0829f35 Remove the post-format-standard term on upgrade if it exists in the database. fixes #20697. 
git-svn-id: http://core.svn.wordpress.org/trunk@22422 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-11-07 18:01:31 +00:00
Andrew Nacin 582d46c937 Make Twenty Twelve the default theme for new installs. props markoheijnen, SergeyBiryukov. see #21789. 
git-svn-id: http://core.svn.wordpress.org/trunk@22054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-27 07:47:51 +00:00
Andrew Nacin 557d9313a7 Introduce constants to allow for easier expression of time periods in seconds. Adds MINUTE_IN_SECONDS, HOUR_IN_SECONDS, DAY_IN_SECONDS, WEEK_IN_SECONDS, YEAR_IN_SECONDS. props nbachiyski, SergeyBiryukov. fixes #20987. 
git-svn-id: http://core.svn.wordpress.org/trunk@21996 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-25 05:26:19 +00:00
Andrew Nacin dc49f24a6c Remove ms-files.php rewriting from WordPress multisite. fixes #19235. 
Keep existing networks compatible with a ms_files_rewriting network option.



git-svn-id: http://core.svn.wordpress.org/trunk@21823 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-11 22:22:20 +00:00
Andrew Nacin 9d204841ee Remove AtomPub from core. 
* Will be replaced with http://wordpress.org/extend/plugins/atom-publishing-protocol/.
 * Introduces an action, xmlrpc_rsd_apis, to add APIs to xmlrpc.php?rsd.
 * Introduces support for 'error' being 403 and 50x in class-wp.php.
 * Removes 'Remote Publishing' from Writing Settings (see [21804]). Keeps the remote_publishing settings section.

DB version is bumped to generate the new wp-app rewrite rule and remove the old enable_app option.

props wonderboymusic.
fixes #21509.



git-svn-id: http://core.svn.wordpress.org/trunk@21818 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-11 20:11:39 +00:00
Andrew Nacin d6b2024a7d Remove old edit_*_per_page usermeta keys. 
These per-page values were when the post type or taxonomy name has a hyphen.
Previously, these were converted to underscores. This changed in [21322].

fixes #18958.



git-svn-id: http://core.svn.wordpress.org/trunk@21811 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-11 02:08:29 +00:00
Andrew Nacin 26dc1e74e5 Turn XML-RPC on and remove the option on the Writing Settings page. 
props markoheijnen for the initial patch.

Introduces a new filter, xmlrpc_enabled.

Respects any current callbacks registered to the pre_option_enable_xmlrpc
and option_enable_xmlrpc filters, for anyone forcing it off via code.

fixes #21509.



git-svn-id: http://core.svn.wordpress.org/trunk@21804 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-09-11 00:37:31 +00:00
Andrew Nacin e79a56793c Disable the Link Manager on any future upgrade if it is still enabled but there are no links. see #21307. 
git-svn-id: http://core.svn.wordpress.org/trunk@21536 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-16 23:08:07 +00:00
Andrew Nacin 84c3a86036 Hide the link manager from the UI on upgrade, if the site has no links. New DB option, link_manager_enabled. 
Enforce this by denying the 'manage_links' capability, which hides the All Links, Add New Link, and Link Categories screens. Hide WP_Widget_Links and the UI for the default_link_category as well.

Convert all references to 'posts and links' when handling reassignment on user deletion to just 'posts'.

see #21307.



git-svn-id: http://core.svn.wordpress.org/trunk@21501 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-13 16:18:42 +00:00
Andrew Nacin 720e09ff5b Stop adding default links and the 'Blogroll' link category on install. props wonderboymusic. see #21307. 
git-svn-id: http://core.svn.wordpress.org/trunk@21500 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-13 15:55:15 +00:00
nacin 7127ed1197 Move most instances of new WP_User to get_userdata(). see #21120. 
git-svn-id: http://core.svn.wordpress.org/trunk@21413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-08-03 01:06:05 +00:00
ryan fdae8f9b42 Fix some spelling errors. Props thee17. fixes #21191 
git-svn-id: http://core.svn.wordpress.org/trunk@21333 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-25 18:06:13 +00:00
markjaquith ecea277a8a Insert a proper line break (instead of an HTML line break) into the "first comment". props nacin. fixes #16712 
git-svn-id: http://core.svn.wordpress.org/trunk@21234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-07-09 03:19:02 +00:00
nacin c64ed056ac Do not force table names to be lowercase in dbDelta, as this breaks sites using capital letters in table prefixes. props netweblogic. fixes #19748. 
git-svn-id: http://core.svn.wordpress.org/trunk@20704 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-05-02 21:19:37 +00:00
nacin 0730535015 Introduce $wpdb->delete(). props justindgivens, scribu. fixes #18948. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20287 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-24 15:24:31 +00:00
nacin 2a6b9ea6db The allowed_themes rolling upgrade for individual sites should not add empty allowedthemes arrays. If there are no allowed themes, don't add an empty option. Move the network rolling upgrade to upgrade_network(). see #20146. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20148 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-08 03:22:39 +00:00
nacin 3985eae452 Don't autoload the uninstall_plugins option. fixes #16741. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-03-02 20:13:35 +00:00
duck_ a395e06896 Reduce references to the $wp_rewrite global because it's no longer used or a wrapper function can be used instead. Fixes #14546.#14546. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-28 20:29:33 +00:00
nacin b367a71d1a Do not save the last visited tab on the multisite Network Themes page and Site Themes tab. These are poor UX, see #18810 for plugins. Entering these screens will always default to 'all' themes view. see #20103. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@20022 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-28 20:13:21 +00:00
nacin aefde50081 Deprecate ancient "debugging" tools. 
* logIO() and the global $xmlrpc_logging in XML-RPC.
 * log_app() and the global $app_logging in APP.
 * debug_fwrite(), debug_fopen(), debug_fclose(), and $debug.
see #20051.



git-svn-id: http://svn.automattic.com/wordpress/trunk@19935 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-02-17 00:02:42 +00:00
ryan 5fd633b48b Drop the comment_approved index from the comments table. comment_approved_date_gmt is sufficient. fixes #19935 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19799 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-31 18:26:07 +00:00
ryan 0f80145c67 Drop the blog_id column from the options table during upgrade. Props barry. fixes #17188 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19798 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-31 17:45:22 +00:00
nacin 5d761c1cb6 Switch to Feedback, from Suggest Ideas, for a default link, based on 3.3 toolbar. see #19601. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19786 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-29 20:25:59 +00:00
nacin b905dc7122 Offer default links and applicable URLs for translation. Some of these are already translatable elsewhere. see #19601. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19781 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-29 05:14:59 +00:00
ryan e3b46b25d3 Lose EOF ?>. Clean up EOF newlines. fixes #12307 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19712 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-08 17:01:11 +00:00
nacin 277a8131d2 Use array_filter() to remove empty values from an array, not jankiness. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19691 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-05 21:22:44 +00:00
nacin c94b474b17 Update some old upgrade functions to use untrailingslashit(). 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19690 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-05 21:21:51 +00:00
ryan 83b131f8e3 User lowercase true, false, null instead of uppercase. Props c3mdigital, mfields. fixes #16302 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2012-01-05 20:50:54 +00:00
ryan 340e93324c Remove extraneous spaces. Props kenan3008, dimadin. fixes #19501 #19433 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19596 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-14 17:36:38 +00:00
ryan 07ff8b216b Use one space, not two, after trailing punctuation. fixes #19537 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19593 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-12-13 23:45:31 +00:00
ryan b6b8a588bb Initialize active_sitewide_plugins during network install and upgrade. fixes #19385 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19470 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-28 20:35:36 +00:00
nacin 28276e825c Move multisite-specific upgrade code from upgrade_330() to upgrade_network(). see #18693. 
git-svn-id: http://svn.automattic.com/wordpress/trunk@19469 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 2011-11-28 20:04:00 +00:00