0544629460
Posts, Post Types: Wrap text submitted via Quick Draft dashboard widget in the Paragraph block.
...
Props audrasjb, jeroenrotty.
Fixes #48120 .
Built from https://develop.svn.wordpress.org/trunk@47191
git-svn-id: http://core.svn.wordpress.org/trunk@46991 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 08:10:05 +00:00
44288356e2
Menus: Introduce `wp_nav_menu_item_custom_fields` action that fires just before the move buttons of a nav menu item in the menu editor.
...
Props MikeSchinkel, birgire, sebastian.pisula, desrosj, helgatheviking.
Fixes #47056 . See #38904 , #18584 .
Built from https://develop.svn.wordpress.org/trunk@47190
git-svn-id: http://core.svn.wordpress.org/trunk@46990 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 07:43:05 +00:00
84c43d1863
Docs: Correct type for `$item` and $args` parameters in `Walker_Nav_Menu_Checklist` and `Walker_Nav_Menu_Edit` to match the parent `Walker_Nav_Menu` class.
...
Follow-up to [38559], [45537].
See #24587 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@47189
git-svn-id: http://core.svn.wordpress.org/trunk@46989 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 07:25:05 +00:00
c32e05f308
Site Health: Improve focus style for accordion items on Site Health screens.
...
The new style is more consistent with other elements like `.wp-core-ui` buttons.
Props audrasjb, mensmaximus, afercia, melchoyce, Clorith.
Fixes #48578 .
Built from https://develop.svn.wordpress.org/trunk@47188
git-svn-id: http://core.svn.wordpress.org/trunk@46988 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-05 06:43:04 +00:00
be057c4a1c
Users: In `remove_user_from_blog()`:
...
* Change default value of the `$blog_id` parameter to match the documented type.
* Change the type of the `$reassign` parameter for consistency with `$user_id` and `$blog_id`.
* Add documentation for the return value.
See #49361 .
Built from https://develop.svn.wordpress.org/trunk@47173
git-svn-id: http://core.svn.wordpress.org/trunk@46973 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-04 19:36:04 +00:00
8163215dc4
Plugins: Remove obsolete `plugin_slugs` transient from `WP_Plugins_List_Table::prepare_items()`.
...
The transient is only used in the `wp_dashboard_plugins_output()` function, which is deprecated and unused since [40607].
The function itself also sets the same transient, so it can be removed from `WP_Plugins_List_Table`.
Props aftabmuni.
Fixes #49340 .
Built from https://develop.svn.wordpress.org/trunk@47167
git-svn-id: http://core.svn.wordpress.org/trunk@46967 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 15:50:04 +00:00
11fb46d4c6
Editor: Remove back-compat stub for Classic Editor's old distraction-free writing mode.
...
The original script was deprecated in [30338] and removed in [32677].
Props Presskopp, ketuchetan.
Fixes #39448 .
Built from https://develop.svn.wordpress.org/trunk@47164
git-svn-id: http://core.svn.wordpress.org/trunk@46964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 04:15:03 +00:00
c94722d9bc
Docs: Improve inline comments in `wp-admin/options.php` per the documentation standards.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47159
git-svn-id: http://core.svn.wordpress.org/trunk@46959 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-02 02:42:04 +00:00
a0f8b7003b
Administration: Include options page name in the "Options page not found" error message to provide better context for plugin developers.
...
Props tdlewis77, williampatton.
Fixes #42941 .
Built from https://develop.svn.wordpress.org/trunk@47158
git-svn-id: http://core.svn.wordpress.org/trunk@46958 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 22:42:06 +00:00
8e37999368
Docs: Correct DocBlock formatting for `register_setting()`.
...
Document the full list of whitelisted option key names.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47157
git-svn-id: http://core.svn.wordpress.org/trunk@46957 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 22:01:07 +00:00
deb1886078
Accessibility: Text Changes: Use sentence case for the word `Error` in various error messages, instead of all caps.
...
Using all caps should be avoided for better readability and because screen readers may pronounce all-caps words as abbreviations.
Props afercia, ryokuhi, sabernhardt, garrett-eclipse.
See #47656 , #43037 , #42945 .
Built from https://develop.svn.wordpress.org/trunk@47156
git-svn-id: http://core.svn.wordpress.org/trunk@46956 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 21:38:04 +00:00
2fe7c95153
Text Changes: Capitalize error messages consistently.
...
Props Presskopp.
Fixes #42945 .
Built from https://develop.svn.wordpress.org/trunk@47154
git-svn-id: http://core.svn.wordpress.org/trunk@46954 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:55:05 +00:00
12a6907123
Text Changes: Add missing periods to some error messages, for consistency.
...
Props Presskopp.
Fixes #42735 .
Built from https://develop.svn.wordpress.org/trunk@47153
git-svn-id: http://core.svn.wordpress.org/trunk@46953 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:32:05 +00:00
21548ad0de
Text Changes: Add missing periods to comment status update notices, for consistency.
...
Props Presskopp.
See #42735 .
Built from https://develop.svn.wordpress.org/trunk@47152
git-svn-id: http://core.svn.wordpress.org/trunk@46952 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 20:29:05 +00:00
f65bc1401a
Networks and Sites: Reduce `max-width` for user and site search inputs on Dashboard screen in Network Admin.
...
This ensures that the inputs don't push the buttons to the next line.
Props williampatton, bordoni.
Fixes #49043 .
Built from https://develop.svn.wordpress.org/trunk@47151
git-svn-id: http://core.svn.wordpress.org/trunk@46951 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 17:38:03 +00:00
06979c6597
Docs: Document the addition of `$json_report_pathname` parameter to the `wp_privacy_personal_data_export_file_created` action.
...
Follow-up to [47146].
Props xkon.
Fixes #49029 .
Built from https://develop.svn.wordpress.org/trunk@47150
git-svn-id: http://core.svn.wordpress.org/trunk@46950 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 04:17:05 +00:00
0aff1cf6bd
Site Health: Rename `WP_Site_Health::initialize()` introduced in [47063] to `::get_instance()`, for clarity and consistency with other core classes.
...
Use `WP_Site_Health::get_instance()` where it's needed, instead of creating multiple instances of the class.
Props afercia, xkon, Clorith, SergeyBiryukov.
See #47606 .
Built from https://develop.svn.wordpress.org/trunk@47149
git-svn-id: http://core.svn.wordpress.org/trunk@46949 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-02-01 00:39:09 +00:00
3cd1514b91
Privacy: Clarify bulk action labels for personal data export and removal requests.
...
Props garrett-eclipse, xkon, shariqkhan2012, websupporter, desrosj, JoshuaWold.
Fixes #44674 .
Built from https://develop.svn.wordpress.org/trunk@47148
git-svn-id: http://core.svn.wordpress.org/trunk@46948 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 03:43:05 +00:00
aef48b433b
Accessibility: Privacy: Improve the readability of the suggested text in Privacy Policy Guide.
...
Per WCAG 2.0 guidelines, big chunks of italic text should be avoided for better accessibility.
Props birgire, sabernhardt, xkon, garrett-eclipse, melchoyce, karmatosed, afercia, jepperask, SergeyBiryukov.
Fixes #44621 . See #47327 .
Built from https://develop.svn.wordpress.org/trunk@47147
git-svn-id: http://core.svn.wordpress.org/trunk@46947 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 03:25:05 +00:00
39cef6947a
Privacy: Introduce a JSON file into the personal data export.
...
The produced ZIP archive will now include an `export.json` file along with the current `index.html`.
Props xkon.
Fixes #49029 . See #46424 .
Built from https://develop.svn.wordpress.org/trunk@47146
git-svn-id: http://core.svn.wordpress.org/trunk@46946 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 01:36:05 +00:00
eafc40be6d
Privacy: Remove user's email address from personal data export filename.
...
Use `wp_unique_filename()` to avoid potential collisions instead.
Props xkon, garrett-eclipse, donmhico, Ov3rfly, Clorith, allendav.
Fixes #44197 .
Built from https://develop.svn.wordpress.org/trunk@47144
git-svn-id: http://core.svn.wordpress.org/trunk@46944 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 00:58:06 +00:00
4f67024da6
Administration: Add punctuation to "If you change this, we will send you an email" message on General Settings, Network Settings, and Profile screens.
...
Props kinjaldalwadi, donmhico.
Fixes #49235 .
Built from https://develop.svn.wordpress.org/trunk@47143
git-svn-id: http://core.svn.wordpress.org/trunk@46943 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-31 00:28:04 +00:00
d3c032bc35
Dashboard: Improve the appearance of "WordPress Events and News" dashboard widget for multi-day events.
...
If an upcoming event spans over several days, this information is now properly reflected in the widget.
Props imath, casiepa, iandunn, hareesh-pillai, melchoyce, mapk, desrosj, audrasjb, SergeyBiryukov.
Fixes #47798 .
Built from https://develop.svn.wordpress.org/trunk@47124
git-svn-id: http://core.svn.wordpress.org/trunk@46924 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 02:19:08 +00:00
b2ffea836b
Docs: Fix typos in `wp-admin/includes/class-pclzip.php`.
...
With the upstream library not updated in 10 years since the last time it was merged, it should be safe to treat it as "adopted" rather than external, and make these fixes.
Props passoniate, ottok.
Fixes #49163 . See #38464 .
Built from https://develop.svn.wordpress.org/trunk@47123
git-svn-id: http://core.svn.wordpress.org/trunk@46923 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:56:04 +00:00
001ffe81fb
Docs: Improve inline comments per the documentation standards.
...
Includes minor code layout fixes for better readability.
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47122
git-svn-id: http://core.svn.wordpress.org/trunk@46922 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:45:18 +00:00
395ee12145
Docs: Improve comments in `js/_enqueues/wp/revisions.js` per the documentation standards.
...
Props passoniate.
Fixes #49177 .
Built from https://develop.svn.wordpress.org/trunk@47120
git-svn-id: http://core.svn.wordpress.org/trunk@46920 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:37:04 +00:00
037a736757
Docs: Improve comments in some `wp-admin` files per the documentation standards.
...
Follow-up to [47084].
Props passoniate, apedog.
Fixes #49223 , #49227 .
Built from https://develop.svn.wordpress.org/trunk@47119
git-svn-id: http://core.svn.wordpress.org/trunk@46919 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-29 00:35:08 +00:00
e65032ff6b
Coding Standards: Use strict comparison in `wp-admin/user/admin.php`.
...
Apply the case-insensitive network-site comparisons added in [27725] for `wp-admin/network/admin.php` to `wp-admin/user/admin.php` too, for consistency.
Props rimadoshi.
Fixes #49300 .
Built from https://develop.svn.wordpress.org/trunk@47115
git-svn-id: http://core.svn.wordpress.org/trunk@46915 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-27 14:30:05 +00:00
b79e042b00
Docs: Remove extra trailing spaces from `wp_add_privacy_policy_content()` DocBlock to fix WPCS issues, apply minor formatting changes for consistency.
...
Follow-up to [47112].
See #49282 .
Built from https://develop.svn.wordpress.org/trunk@47113
git-svn-id: http://core.svn.wordpress.org/trunk@46913 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-27 01:06:04 +00:00
516629964c
Privacy: Cleanup `.wp-policy-help` CSS remnants and add back-compat when hiding the tutorial content before copying.
...
Props garrett-eclipse.
Fixes #49282 .
Built from https://develop.svn.wordpress.org/trunk@47112
git-svn-id: http://core.svn.wordpress.org/trunk@46912 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-26 23:02:03 +00:00
cfa3dc8ee8
Docs: Correct `@return` value for `parent_dropdown()`.
...
Follow-up to [47100].
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47102
git-svn-id: http://core.svn.wordpress.org/trunk@46902 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-22 00:33:04 +00:00
eb513c5ac8
Docs: Adjust `@return` value of `parent_dropdown()` for consistency with other dropdown functions.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47100
git-svn-id: http://core.svn.wordpress.org/trunk@46900 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-22 00:22:03 +00:00
381df97419
Docs: Correct `@return` value for `update_core()` and `Core_Upgrader::upgrade()`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47099
git-svn-id: http://core.svn.wordpress.org/trunk@46899 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-22 00:19:04 +00:00
60c651ad6a
I18N: Add missing placeholders to some translators comments in `wp-admin`.
...
Props ramiy.
Fixes #49248 .
Built from https://develop.svn.wordpress.org/trunk@47093
git-svn-id: http://core.svn.wordpress.org/trunk@46893 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-20 15:43:04 +00:00
c946a71d9d
I18N: Correct translator comment in `wp-admin/options-permalink.php`.
...
Props ramiy.
Fixes #49247 .
Built from https://develop.svn.wordpress.org/trunk@47092
git-svn-id: http://core.svn.wordpress.org/trunk@46892 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-20 15:10:04 +00:00
1adca958e3
I18N: Remove unnecessary HTML from "Active:" strings in `wp-admin/themes.php`.
...
Follow-up to [45435].
Props ramiy.
Fixes #49243 .
Built from https://develop.svn.wordpress.org/trunk@47090
git-svn-id: http://core.svn.wordpress.org/trunk@46890 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-20 14:27:04 +00:00
d5be8f0635
I18N: Correct translator comments in `WP_Users_List_Table::get_views()` to provide information about each placeholder.
...
Props ramiy.
Fixes #49242 .
Built from https://develop.svn.wordpress.org/trunk@47089
git-svn-id: http://core.svn.wordpress.org/trunk@46889 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-20 14:08:05 +00:00
2900bb8ea7
Docs: Update links to https://secure.php.net/ , they now redirect to https://www.php.net/ .
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47088
git-svn-id: http://core.svn.wordpress.org/trunk@46888 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-20 03:14:06 +00:00
89f5d3dd0c
Networks and Sites: Clarify the recommendation to remove the `www` prefix from the site domain before creating a network.
...
The `siteurl` option reference was not quite clear, and the string actually refers to the domain name, not the full URL.
Props kharisblank, tobifjellner, ramiy.
Fixes #49214 .
Built from https://develop.svn.wordpress.org/trunk@47085
git-svn-id: http://core.svn.wordpress.org/trunk@46885 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-18 01:15:04 +00:00
053a9cd5b8
Docs: Improve comments in some `wp-admin` files per the documentation standards.
...
Props passoniate.
Fixes #49215 , #49216 .
Built from https://develop.svn.wordpress.org/trunk@47084
git-svn-id: http://core.svn.wordpress.org/trunk@46884 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-18 00:54:04 +00:00
1cfc32af58
Coding Standards: Remove unnecessary `// phpcs:ignore` instances in `WP_Debug_Data`.
...
`WP_Theme::__get()` accepts `Name`, `Version`, and `Author` theme properties in lower case too.
Additionally, remove one short ternary instance, not allowed per the coding standards.
See #49222 .
Built from https://develop.svn.wordpress.org/trunk@47083
git-svn-id: http://core.svn.wordpress.org/trunk@46883 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-18 00:26:06 +00:00
0f47f2b9e5
Widgets: Remove extra padding from number inputs in Recent Posts and Recent Comments widgets.
...
Props marcio-zebedeu, audrasjb, SergeyBiryukov.
Fixes #49195 .
Built from https://develop.svn.wordpress.org/trunk@47082
git-svn-id: http://core.svn.wordpress.org/trunk@46882 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-17 13:57:03 +00:00
691adde1e6
Date/Time: Use `wp_date()` to display the correct time of the next DST transition in Timezone setting on General Settings screen.
...
Props Rarst, autotutorial.
Fixes #49038 .
Built from https://develop.svn.wordpress.org/trunk@47073
git-svn-id: http://core.svn.wordpress.org/trunk@46873 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-16 00:28:06 +00:00
3e68a63e6a
Editor: Correct vertical alignment for "Published on" month dropdown in Classic Editor.
...
Props pratik-jain, justinahinon, audrasjb.
Fixes #49115 .
Built from https://develop.svn.wordpress.org/trunk@47072
git-svn-id: http://core.svn.wordpress.org/trunk@46872 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-15 18:31:07 +00:00
57fbd3c847
File Editor: Remove extra padding on submit button for "Select plugin/theme to edit" dropdown on smaller screens.
...
Props passoniate.
Fixes #49197 .
Built from https://develop.svn.wordpress.org/trunk@47071
git-svn-id: http://core.svn.wordpress.org/trunk@46871 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-15 00:23:07 +00:00
569ff9dd27
Upgrade/Install: Correct vertical alignment for "Continue" button on language selection during the install process.
...
Props garrett-eclipse, audrasjb.
Fixes #49018 .
Built from https://develop.svn.wordpress.org/trunk@47070
git-svn-id: http://core.svn.wordpress.org/trunk@46870 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-14 01:11:03 +00:00
10ae398727
Site Health: Avoid "Undefined property" PHP notices in `wp_dashboard_site_health()` when the status result transient does not exist yet.
...
Props dlh for initial patch.
See #47606 .
Built from https://develop.svn.wordpress.org/trunk@47069
git-svn-id: http://core.svn.wordpress.org/trunk@46869 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-13 17:27:06 +00:00
f18b173674
Networks and Sites: Use `warning` styles for 'Caution' and 'Warning' messages during Multisite installation.
...
Props dlh.
Fixes #49186 .
Built from https://develop.svn.wordpress.org/trunk@47067
git-svn-id: http://core.svn.wordpress.org/trunk@46867 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-13 17:00:06 +00:00
fa2f6e0644
Docs: Improve documentation for `wp_save_image_file()` and related functions.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47065
git-svn-id: http://core.svn.wordpress.org/trunk@46865 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-12 16:56:05 +00:00
2c4480958b
Site Health: Introduce Site Health Status dashboard widget.
...
The widget informs administrators of any potential issues that should be addressed to improve the performance or security of their website, and directs them to the Site Health screen for more details.
Props Clorith, hedgefield, guddu1315.
See #47606 .
Built from https://develop.svn.wordpress.org/trunk@47063
git-svn-id: http://core.svn.wordpress.org/trunk@46863 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-12 13:33:05 +00:00
f8a5ae6b93
Upgrade/Install: Remove the suggestion for users to skip a minor update to keep their current translation.
...
With the introduction of asynchronous translation updates in WordPress 3.7+, the suggestion is no longer relevant.
Props casiepa, danieltj, tobifjellner, netweb.
Fixes #43242 .
Built from https://develop.svn.wordpress.org/trunk@47061
git-svn-id: http://core.svn.wordpress.org/trunk@46861 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-12 02:24:03 +00:00
dd4d98a368
Docs: In various `@return` tags, list the expected type first, instead of `false`.
...
Follow-up to [46696].
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@47060
git-svn-id: http://core.svn.wordpress.org/trunk@46860 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 18:32:05 +00:00
2294d65753
Docs: Synchronize `@return` descriptions for `::handle_row_actions()` methods in list tables.
...
Make sure `WP_Comments_List_Table::handle_row_actions()` and `WP_MS_Sites_List_Table::handle_row_actions()` return a string, for consistency with other classes.
See #49170 , #48303 .
Built from https://develop.svn.wordpress.org/trunk@47059
git-svn-id: http://core.svn.wordpress.org/trunk@46859 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 17:59:04 +00:00
d469aa8162
Docs: Correct `@return` description for `WP_List_Table::handle_row_actions()`.
...
Props pbiron.
Fixes #49170 .
Built from https://develop.svn.wordpress.org/trunk@47058
git-svn-id: http://core.svn.wordpress.org/trunk@46858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 17:57:03 +00:00
6a3deacf86
Docs: Correct `@return` type for `Theme_Upgrader::check_parent_theme_filter()`.
...
Props diddledan.
Fixes #48570 .
Built from https://develop.svn.wordpress.org/trunk@47057
git-svn-id: http://core.svn.wordpress.org/trunk@46857 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-11 02:46:05 +00:00
d3d630c98a
Site Health: Make sure the "Copied!" text is vertically centered to the "Copy site info to clipboard" button.
...
Props garrett-eclipse.
Fixes #49139 .
Built from https://develop.svn.wordpress.org/trunk@47047
git-svn-id: http://core.svn.wordpress.org/trunk@46847 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-07 00:09:04 +00:00
667f26b3af
I18N: Replace `php.ini`, `post_max_size`, and `upload_max_filesize` with placeholders in "File is empty" error message.
...
Props ramiy.
Fixes #48868 .
Built from https://develop.svn.wordpress.org/trunk@47043
git-svn-id: http://core.svn.wordpress.org/trunk@46843 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-06 16:16:03 +00:00
6a3a0b519c
Docs: Fix typo in `media_post_single_attachment_fields_to_edit()` description.
...
Props mukesh27.
Fixes #49131 .
Built from https://develop.svn.wordpress.org/trunk@47039
git-svn-id: http://core.svn.wordpress.org/trunk@46839 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-04 18:00:06 +00:00
8ec3da8a25
Site Health: Fix typo in a variable name in `js/_enqueues/admin/site-health.js`.
...
Props nickylimjj.
Fixes #49112 .
Built from https://develop.svn.wordpress.org/trunk@47031
git-svn-id: http://core.svn.wordpress.org/trunk@46831 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-01-02 12:11:02 +00:00
6357cae029
Docs: Fix typo in `_crop_image_resource()` DocBlock.
...
Props mukesh27.
Fixes #49103 .
Built from https://develop.svn.wordpress.org/trunk@47024
git-svn-id: http://core.svn.wordpress.org/trunk@46824 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-31 12:34:01 +00:00
7970e62c06
Coding Standards: Fix WPCS issue in [47015].
...
See #49082 .
Built from https://develop.svn.wordpress.org/trunk@47016
git-svn-id: http://core.svn.wordpress.org/trunk@46816 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-26 15:53:02 +00:00
7c2275dfe4
Docs: Fix typo in `wp_dashboard_cached_rss_widget()` documentation.
...
Props mukesh27.
Fixes #49082 .
Built from https://develop.svn.wordpress.org/trunk@47015
git-svn-id: http://core.svn.wordpress.org/trunk@46815 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-26 14:42:03 +00:00
bb70f4e530
Docs: Correct the note about the `CORE_UPGRADE_SKIP_NEW_BUNDLED` constant in `$_new_bundled_files` global description.
...
In order to tell WordPress not to install new bundled themes on update, `CORE_UPGRADE_SKIP_NEW_BUNDLED` should be set to `true`, as the name suggests, not `false`.
Follow-up to [39064].
Props tomgreer, knutsp, crdunst.
See #49056 .
Built from https://develop.svn.wordpress.org/trunk@47007
git-svn-id: http://core.svn.wordpress.org/trunk@46807 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-23 18:00:02 +00:00
246a035d99
Docs: Improve documentation for admin menu functions:
...
* `get_admin_page_parent()`
* `get_admin_page_title()`
* `get_plugin_page_hook()`
* `get_plugin_page_hookname()`
* `user_can_access_admin_page()`
Add missing descriptions and `@since` tags.
Props subrataemfluence, kennithnichol, stevenlinx, SergeyBiryukov.
Fixes #44253 , #49067 .
Built from https://develop.svn.wordpress.org/trunk@47006
git-svn-id: http://core.svn.wordpress.org/trunk@46806 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-23 14:36:04 +00:00
f501814eac
Upgrade/Install: When creating the `.htaccess` file in `insert_with_markers()`, make sure it has `0644` as a minimum set of permissions.
...
Props rcutmore, dd32, i3anaan.
Fixes #40572 .
Built from https://develop.svn.wordpress.org/trunk@47005
git-svn-id: http://core.svn.wordpress.org/trunk@46805 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-22 02:45:03 +00:00
4edec193bc
Users: When creating the first user on installation, populate the Website profile field with the site URL.
...
Skip setting the field if the user already exists, which is the case when the user tables are being shared among multiple sites.
Props EFAREM, eclare, darrenlambert, zachflauaus, viralsampat.
Fixes #35778 .
Built from https://develop.svn.wordpress.org/trunk@46989
git-svn-id: http://core.svn.wordpress.org/trunk@46789 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-18 02:26:03 +00:00
bbd898b1dd
Upgrade/Install: Remove unused global in `upgrade_430_fix_comments()`.
...
Props adnan.limdi.
Fixes #41970 .
Built from https://develop.svn.wordpress.org/trunk@46972
git-svn-id: http://core.svn.wordpress.org/trunk@46772 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 16:45:03 +00:00
c67c3ee6a0
Fix the colors in all color schemes for the `.active` class for buttons.
...
Props ryelle, audrasjb.
Fixes #49003 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46967
git-svn-id: http://core.svn.wordpress.org/trunk@46767 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-17 00:15:03 +00:00
8894c0f1a2
Coding Standards: Use strict comparison in `wp-admin/widgets.php`.
...
Props jenilk.
Fixes #49000 .
Built from https://develop.svn.wordpress.org/trunk@46964
git-svn-id: http://core.svn.wordpress.org/trunk@46764 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-16 12:55:03 +00:00
5b9fd2d7e7
Coding Standards: Use strict comparison in `wp-admin/includes/network.php`.
...
Props ataurr.
Fixes #48994 .
Built from https://develop.svn.wordpress.org/trunk@46963
git-svn-id: http://core.svn.wordpress.org/trunk@46763 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-16 12:37:06 +00:00
6d40400756
Coding Standards: Use strict comparison in `wp-admin/edit-tags.php`.
...
Props passoniate.
Fixes #48985 .
Built from https://develop.svn.wordpress.org/trunk@46962
git-svn-id: http://core.svn.wordpress.org/trunk@46762 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-15 10:46:02 +00:00
087282e810
Coding Standards: Use strict comparison in `wp-admin/term.php`.
...
Props vinita29.
Fixes #48983 .
Built from https://develop.svn.wordpress.org/trunk@46961
git-svn-id: http://core.svn.wordpress.org/trunk@46761 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-15 09:45:01 +00:00
0b8438a6d2
I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders.
...
Props ramiy.
Fixes #48863 .
Built from https://develop.svn.wordpress.org/trunk@46957
git-svn-id: http://core.svn.wordpress.org/trunk@46756 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-13 21:27:05 +00:00
db18e7d50b
Upgrade/Install: Improve the appearance of language selection on install:
...
* Remove a stray chevron.
* Improve focus and hover styles.
Props garrett-eclipse, audrasjb.
Fixes #48927 .
Built from https://develop.svn.wordpress.org/trunk@46887
git-svn-id: http://core.svn.wordpress.org/trunk@46687 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 23:03:03 +00:00
9b91ffde04
Docs: Improve documentation for `wp_dashboard_browser_nag()` and `dashboard_browser_nag_class()`.
...
Props grapplerulrich.
Fixes #48932 .
Built from https://develop.svn.wordpress.org/trunk@46880
git-svn-id: http://core.svn.wordpress.org/trunk@46680 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-11 10:59:05 +00:00
6ddf02b188
Menus: Avoid a PHP warning in `add_submenu_page()` when the same value is passed for both `$parent_slug` and `$menu_slug` parameters.
...
Props welcher, ispreview, ayeshrajans, NextScripts, adamsilverstein, garrett-eclipse, 123host.
Fixes #48599 .
Built from https://develop.svn.wordpress.org/trunk@46868
git-svn-id: http://core.svn.wordpress.org/trunk@46668 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 21:03:02 +00:00
a209908501
Administration: Standardize form control height and alignment across the admin.
...
This improves the appearance of various form controls in the admin and addresses some visual inconsistencies in WordPress 5.3.
Props afercia, audrasjb, jameskoster, GDragoN, azaozz, michaelarestad, murgroland, SamuelFernandez, chetan200891, veminom, dlh.
Fixes #48420 .
Built from https://develop.svn.wordpress.org/trunk@46866
git-svn-id: http://core.svn.wordpress.org/trunk@46666 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 20:26:03 +00:00
dd47d5aa81
Media: Use consistent width for Scale and Crop inputs.
...
Follow-up to [46359].
Props sabernhardt, audrasjb.
Fixes #48907 .
Built from https://develop.svn.wordpress.org/trunk@46856
git-svn-id: http://core.svn.wordpress.org/trunk@46656 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 16:23:02 +00:00
9648c368f0
Help/About: Add a hover effect for links on About pages.
...
* Add a color that passes WCAG color contrast criteria to every link.
* Add an underline for links in credits list only on hover/focus.
Props audrasjb, ixkaito, mukesh27, melchoyce, SergeyBiryukov.
Fixes #48582 .
Built from https://develop.svn.wordpress.org/trunk@46852
git-svn-id: http://core.svn.wordpress.org/trunk@46652 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 15:31:05 +00:00
dcf0cb68a2
Administration: Correct checkbox width in list tables on smaller screens.
...
Previously, checkboxes for pending comments were partially hidden due to an added `4px` border.
Props audrasjb, jeremyfelt, talldanwp, melchoyce, marcelo2605, waleedt93.
Fixes #48815 .
Built from https://develop.svn.wordpress.org/trunk@46845
git-svn-id: http://core.svn.wordpress.org/trunk@46645 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 14:26:02 +00:00
ac690426eb
Accessibility: Menus: Properly disable form controls on the Menus screen that cannot be used until at least one menu is created.
...
This ensures that the actual UI controls state matches the visually conveyed state.
Props afercia, audrasjb, dinhtungdu, sathyapulse, simonjanin, welcher, SergeyBiryukov.
Fixes #48409 .
Built from https://develop.svn.wordpress.org/trunk@46842
git-svn-id: http://core.svn.wordpress.org/trunk@46642 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-09 13:49:03 +00:00
d53103ed62
Docs: Further docblock corrections and improvements.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46826
git-svn-id: http://core.svn.wordpress.org/trunk@46626 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-07 13:23:01 +00:00
f93ee2ca76
Docs: Increase the specificity of various docblock parameter types and return types.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46823
git-svn-id: http://core.svn.wordpress.org/trunk@46623 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 22:43:04 +00:00
aa1fdcbd52
Docs: Correct various docblocks documentation.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46821
git-svn-id: http://core.svn.wordpress.org/trunk@46621 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 22:23:04 +00:00
7d84502589
Text Changes: Rename Comment Blacklist option to be more inclusive
...
This doesn't change the underlying option name as that would be a backcompat break, but it makes the UI a bit more inclusive.
Props dartiss, jeremyfelt, aaronjorbin.
Fixes #48900 .
Built from https://develop.svn.wordpress.org/trunk@46820
git-svn-id: http://core.svn.wordpress.org/trunk@46620 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-06 18:12:02 +00:00
2165eef44c
Accessibility: Administration: Correct active button color for the alternative color schemes.
...
Follow-up to [46815].
Props melchoyce, ryelle, larrach, audrasjb, studiotwee, afercia, azaozz.
Fixes #48598 .
Built from https://develop.svn.wordpress.org/trunk@46817
git-svn-id: http://core.svn.wordpress.org/trunk@46617 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 22:12:03 +00:00
20e18613d0
Accessibility: Administration: Apply a unified design to all secondary buttons across all color schemes.
...
This ensures that secondary buttons have an appropriate color contrast in the alternative color schemes.
Props melchoyce, ryelle, audrasjb, ate-up-with-motor, afercia, sabernhardt.
Fixes #48585 .
Built from https://develop.svn.wordpress.org/trunk@46815
git-svn-id: http://core.svn.wordpress.org/trunk@46615 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-05 21:32:03 +00:00
38ad319fdf
I18N: Change context for the "Add New" string on Themes screen for consistency with other similar strings.
...
Props ramiy.
Fixes #48875 .
Built from https://develop.svn.wordpress.org/trunk@46812
git-svn-id: http://core.svn.wordpress.org/trunk@46612 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-04 10:36:01 +00:00
a5e52e04ee
Docs: Move the canonical DocBlock for `handle_bulk_actions-{$screen}` action to `wp-admin/edit.php`.
...
* Document accepted values for the `$items` parameter.
* Use interpolated syntax for the filter name.
Props dilipbheda, johnbillion, SergeyBiryukov.
Fixes #48857 .
Built from https://develop.svn.wordpress.org/trunk@46811
git-svn-id: http://core.svn.wordpress.org/trunk@46611 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-03 13:58:05 +00:00
135e608b46
Upload: Exclude PNG images from scaling after uploading. Fixes a case where resizing a very large PNG may create a scaled image that has smaller dimensions but larger file size than the original.
...
Fixes #48736 .
Built from https://develop.svn.wordpress.org/trunk@46809
git-svn-id: http://core.svn.wordpress.org/trunk@46609 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-12-01 18:26:05 +00:00
0221a593b9
Administration: Correct font size for comment count in "At a Glance" dashboard widget on mobile.
...
Props donmhico, jeremyfelt.
Fixes #48799 .
Built from https://develop.svn.wordpress.org/trunk@46807
git-svn-id: http://core.svn.wordpress.org/trunk@46607 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-30 00:42:01 +00:00
1d1c74385f
REST API: Use strict `in_array()` checks for the list of usernames blacklisted via `illegal_user_logins` filter.
...
See #48839 .
Built from https://develop.svn.wordpress.org/trunk@46804
git-svn-id: http://core.svn.wordpress.org/trunk@46604 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 22:04:02 +00:00
2a0489ec49
Docs: Replace `@returns` tags in JS docs with `@return`.
...
Per the documentation standards, `@returns` is an unsupported synonym, `@return` should be used instead:
https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46800
git-svn-id: http://core.svn.wordpress.org/trunk@46600 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 18:01:03 +00:00
4a4afbd68c
Docs: Add missing full stops to `@returns` tags in JS docs, per the documentation standards.
...
Props shital-patel, kalpshit.
Fixes #48305 .
Built from https://develop.svn.wordpress.org/trunk@46799
git-svn-id: http://core.svn.wordpress.org/trunk@46599 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-29 16:56:02 +00:00
acd0a3ca99
Site Health: Add a test for PHP default timezone.
...
The test reports a failure if the default timezone was changed with `date_default_timezone_set()` to anything other than `UTC`.
WordPress historically uses `UTC` as the default timezone for calculating date and time offsets, overriding it is not recommended and can cause widespread and obscure issues.
Props Rarst, Clorith, TimothyBlynJacobs.
Fixes #48692 .
Built from https://develop.svn.wordpress.org/trunk@46797
git-svn-id: http://core.svn.wordpress.org/trunk@46597 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-28 15:48:03 +00:00
6f86cedb09
Menus: Improve the wording of instructions for dragging the items into the preferred order.
...
Props amolv, equin0x80, dlh.
Fixes #48184 .
Built from https://develop.svn.wordpress.org/trunk@46791
git-svn-id: http://core.svn.wordpress.org/trunk@46591 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 19:51:01 +00:00
d8b251f0af
Administration: Properly wrap long titles in list tables on smaller screens.
...
Props mukesh27, iihglobal, wpamitkumar.
Fixes #48805 .
Built from https://develop.svn.wordpress.org/trunk@46790
git-svn-id: http://core.svn.wordpress.org/trunk@46590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-27 16:52:02 +00:00
f4165a697d
Upgrade/Install: Provide a default label for "Continue" button in language selection form.
...
Prevents an empty continue button if a translation isn't yet available.
Props sathyapulse.
Fixes #48776 .
Built from https://develop.svn.wordpress.org/trunk@46784
git-svn-id: http://core.svn.wordpress.org/trunk@46584 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-26 15:19:04 +00:00
63fefb540a
Users: Use correct variable when displaying the Additional Capabilities list in user profile.
...
Addresses a regression in [45926].
Props wpgurudev, aravindajith, anantajitjg, davidbaumwald.
Fixes #48725 .
Built from https://develop.svn.wordpress.org/trunk@46782
git-svn-id: http://core.svn.wordpress.org/trunk@46582 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-25 14:01:03 +00:00
2a85fe21d8
Accessibility: Administration: Underline links on Dashboard that are located within a line of text and thus need to be underlined:
...
* "change your theme completely"
* Active theme in the "At a Glance" box
* "View all drafts" in the Quick Draft box
Split "Manage widgets or menus" into separate items for consistency with other links.
For better accessibility, links that are a part of other text should be underlined and not rely on color alone to be distinguished.
Per accessibility coding standards:
> When links can be identified as such by the context, for example because they’re part of a menu, or a set of links clearly identified as user interface controls, they don’t necessarily need to be underlined. In all the other cases, especially for links surrounded by other text (in a line or block of text), links need to be always underlined.
https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/#links-underline-or-no-underline
https://make.wordpress.org/accessibility/handbook/design/use-of-color/#not-by-color-alone
Props afercia, audrasjb, karmatosed.
Fixes #48406 .
Built from https://develop.svn.wordpress.org/trunk@46770
git-svn-id: http://core.svn.wordpress.org/trunk@46570 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-24 19:57:05 +00:00
c786eaa1df
Coding Standards: Fix WPCS issue in [46763].
...
See #48777 .
Built from https://develop.svn.wordpress.org/trunk@46764
git-svn-id: http://core.svn.wordpress.org/trunk@46564 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 19:21:03 +00:00
26a750e162
Docs: Add missing `@since` tags for functions in `wp-admin/includes/update.php`.
...
Props sathyapulse, zodiac1978.
Fixes #48777 .
Built from https://develop.svn.wordpress.org/trunk@46763
git-svn-id: http://core.svn.wordpress.org/trunk@46563 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-23 18:51:01 +00:00
56af5db74f
Editor: Improve the appearance of tag cloud in Tags meta box in classic editor.
...
Props sathyapulse, Spaceshipone, tmatsuur, audrasjb, afercia.
Fixes #48592 .
Built from https://develop.svn.wordpress.org/trunk@46758
git-svn-id: http://core.svn.wordpress.org/trunk@46558 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-22 00:04:02 +00:00
44d5372825
I18N: Correct translator comment for `By %s` string in Plugins list table.
...
Follow-up to [44541].
See #45898 .
Built from https://develop.svn.wordpress.org/trunk@46755
git-svn-id: http://core.svn.wordpress.org/trunk@46555 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-21 00:08:02 +00:00
71725aeb95
Accessibility: Add an `aria-current` attribute to the Media Library switch links.
...
The `aria-current` attribute is a simple, effective, way to help assistive technology users orientate themselves within a set of items.
Props mayanksonawat, afercia.
Fixes #48271 .
Built from https://develop.svn.wordpress.org/trunk@46746
git-svn-id: http://core.svn.wordpress.org/trunk@46546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 16:51:02 +00:00
eec579dd86
Widgets: Avoid to move focus to the Image Widget "Insert from URL" field.
...
Fixes a bug after [45499], where the backbone view element isn't the input field any longer. Also, managing focus programmatically is often an assumption on a specific user flow and should generally be avoided, see #43169 .
Props dufresnesteven.
See #43169 .
Fixes #48588 .
Built from https://develop.svn.wordpress.org/trunk@46745
git-svn-id: http://core.svn.wordpress.org/trunk@46545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 16:23:02 +00:00
306045277e
Administration: Switch `rgb()` CSS property for paused plugin error message in Plugins list table to `rgba()`.
...
While technically correct as is, the latter is more consistent with other admin styles and causes less confusion.
Props manikmist09.
Fixes #48629 .
Built from https://develop.svn.wordpress.org/trunk@46744
git-svn-id: http://core.svn.wordpress.org/trunk@46544 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-18 13:18:03 +00:00
5aa3a51264
Docs: Update broken source code link in `WP_Filesystem_SSH2` class.
...
Props mryoga, finchps.
Fixes #48467 .
Built from https://develop.svn.wordpress.org/trunk@46742
git-svn-id: http://core.svn.wordpress.org/trunk@46542 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 16:16:02 +00:00
418db0297e
Docs: Correct spelling of "subclass" and "overridden" in various docblocks and error messages.
...
Props garrett-eclipse.
Fixes #48676 .
Built from https://develop.svn.wordpress.org/trunk@46739
git-svn-id: http://core.svn.wordpress.org/trunk@46539 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-17 07:43:01 +00:00
927aa4b44c
Docs: Fix typo in `wp_credits_section_title()` description.
...
Switch descriptions for `wp_credits_section_title()` and `wp_credits_section_list()` to third-person singular verbs, per the documentation standards.
Props hareesh-pillai.
Fixes #48674 .
Built from https://develop.svn.wordpress.org/trunk@46738
git-svn-id: http://core.svn.wordpress.org/trunk@46538 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-16 21:04:01 +00:00
4ec53dc54c
Docs: Remove incorrect `@return` tags.
...
Props diddledan.
Fixes #48613 , #48614 .
Built from https://develop.svn.wordpress.org/trunk@46732
git-svn-id: http://core.svn.wordpress.org/trunk@46532 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-14 09:57:03 +00:00
6ceb0279af
Help/About: Move images to the CDN.
...
Props ryelle.
Fixes #47708 .
Built from https://develop.svn.wordpress.org/trunk@46724
git-svn-id: http://core.svn.wordpress.org/trunk@46524 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-12 18:30:03 +00:00
2265c36568
Help/About: Update the 5.3 About page.
...
* Remove extra padding on the Credits tab.
Previously [46556], [46572], [46616], [46705].
Props ryelle.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46709
git-svn-id: http://core.svn.wordpress.org/trunk@46509 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 20:45:04 +00:00
ba249d8951
Help/About: Update the 5.3 About page.
...
* Remove the SVG from the upper right corner.
* Make sure admin notices that should be hidden stay hidden.
* Address a11y issues with contrast.
* Fix an issue with the active nav tab hover.
* Prevent names on the credits from breaking out of the box.
* Update two strings with a more accurate information.
Previously [46556], [46572], [46616].
Props ryelle, afercia, audrasjb, francina, mapk, desrosj, YordanSoares, melchoyce, azaozz, johnbillion, davidbaumwald, luminuu, bwmarkle, la-geek, SergeyBiryukov.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46705
git-svn-id: http://core.svn.wordpress.org/trunk@46505 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 16:07:03 +00:00
3d623995a8
Docs: In various `@return` tags, list the expected type first, instead of `WP_Error`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46696
git-svn-id: http://core.svn.wordpress.org/trunk@46496 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 02:43:03 +00:00
82dfb2d151
Docs: Miscellaneous docblock corrections in `wp-admin/includes/plugin.php`.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46695
git-svn-id: http://core.svn.wordpress.org/trunk@46495 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-11 00:05:01 +00:00
2af39e45cb
Docs: Improve documentation for `deactivate_plugins()` and `activate_plugins()`.
...
Props marekdedic, spenserhale, SergeyBiryukov.
Fixes #48352 .
Built from https://develop.svn.wordpress.org/trunk@46694
git-svn-id: http://core.svn.wordpress.org/trunk@46494 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-10 23:05:03 +00:00
0e79d4d101
Coding Standards: Fix WPCS issue in [46684].
...
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46687
git-svn-id: http://core.svn.wordpress.org/trunk@46487 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 13:33:02 +00:00
1f816ad18d
Docs: Use the `{@see ...}` tag for the replacement in `@deprecated` tags, so that Developer Reference could automatically link to the replacement.
...
Props jrf.
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46685
git-svn-id: http://core.svn.wordpress.org/trunk@46485 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 13:05:02 +00:00
f60094679f
Coding Standards: Consistently use `do_action_deprecated()` and `apply_filters_deprecated()` for deprecated hooks.
...
Props jrf.
See #48255 .
Built from https://develop.svn.wordpress.org/trunk@46684
git-svn-id: http://core.svn.wordpress.org/trunk@46484 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 12:59:03 +00:00
ba21b391f6
Docs: Correct some inconsistencies in comments with Dashicon class references in `wp-admin/css/customize-widgets.css`.
...
Prepend all class name references with `dashicons-` for clarity.
Props 1naveengiri, marcio-zebedeu, hareesh-pillai, SergeyBiryukov.
Fixes #48417 .
Built from https://develop.svn.wordpress.org/trunk@46681
git-svn-id: http://core.svn.wordpress.org/trunk@46481 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-09 00:03:02 +00:00
15a4289c8d
Docs: Correct description for `$recursive` parameter of `::chmod()` and `::delete()` methods in `WP_Filesystem` implementations.
...
Props skithund.
Fixes #48422 .
Built from https://develop.svn.wordpress.org/trunk@46679
git-svn-id: http://core.svn.wordpress.org/trunk@46479 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-08 22:56:02 +00:00
60c2966222
Upload: When an image was scaled because it is larger than the big image threshold, use the originally uploaded image's dimensions in `wp_get_missing_image_subsizes()`. Fixes an edge case/inconsistent behaviour when a registered image sub-size is also larger than the big image threshold.
...
Props desrosj, azaozz.
Fixes #48518 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46677
git-svn-id: http://core.svn.wordpress.org/trunk@46477 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-07 18:51:02 +00:00
eda6a9e111
Docs: Docs on docs. Further improve documentation of known return types, plus other docs fixes.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46662
git-svn-id: http://core.svn.wordpress.org/trunk@46462 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 21:30:03 +00:00
f9e81c83d5
Media: Remove the variable number (from the big image threshold value) when generating file names for scaled images. This makes it easier to "calculate" the full size file name from the name of an intermediate size image.
...
Props ianmjones, azaozz.
Fixes #48453 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46658
git-svn-id: http://core.svn.wordpress.org/trunk@46458 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-05 20:53:03 +00:00
43ed67661a
Upload: Ensure the new image meta is always saved before starting post-processing of an uploaded image, even if there was an error while scaling or rotating it.
...
See #48472 .
Built from https://develop.svn.wordpress.org/trunk@46651
git-svn-id: http://core.svn.wordpress.org/trunk@46451 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 17:07:03 +00:00
8b76312eb3
Docs: Correct some array hash notations added in [46644].
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46647
git-svn-id: http://core.svn.wordpress.org/trunk@46447 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-04 09:37:02 +00:00
b3d6acd6a4
Docs: Fix some incorrect return tags in docblocks.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46644
git-svn-id: http://core.svn.wordpress.org/trunk@46444 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 22:23:01 +00:00
a87271af60
Login and Registration: Allow email logins to be more flexible.
...
Allows a login to have an apostorphe. Which would normally be created as a mistake, but this allows the login to happen.
Fixes #38744
Props wpkuf, desrosj, socalchristina, bibliofille, santilinwp, nsubugak, sncoker, cafenoirdesign, whyisjake.
Built from https://develop.svn.wordpress.org/trunk@46640
git-svn-id: http://core.svn.wordpress.org/trunk@46440 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 20:12:02 +00:00
583e49d95f
Customize: Formally deprecate unused Customizer classes.
...
The `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` PHP classes and `wp.customize.Menus.NewMenuControl` JS class were deprecated in 4.9 through [42034] with the intention of removing them in 5.0. Since more time has passed than originally intended, this change leaves `WP_Customize_New_Menu_Control` and `WP_Customize_New_Menu_Section` to prevent any potential backwards compatibility issues, and formally deprecates them. The `wp.customize.Menus.NewMenuControl` JS class is removed.
Props weston.ruter, matthias-reuter, jrf.
Fixes #42364 .
Built from https://develop.svn.wordpress.org/trunk@46637
git-svn-id: http://core.svn.wordpress.org/trunk@46437 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-03 16:48:00 +00:00
2651ff3ae8
Docs: Update URLs in some `@link` tags and switch them to HTTPS.
...
Props tsuyoring.
Fixes #48479 .
Built from https://develop.svn.wordpress.org/trunk@46626
git-svn-id: http://core.svn.wordpress.org/trunk@46423 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-11-01 14:57:02 +00:00
d1b23193dd
Docs: Correct some incorrect docblock tags.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46623
git-svn-id: http://core.svn.wordpress.org/trunk@46420 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-31 17:51:01 +00:00
3d76b537d6
Docs: Add `@since` tag for the `$context` parameter added to `wp_generate_attachment_metadata` filter in [46621].
...
See #48472 .
Built from https://develop.svn.wordpress.org/trunk@46622
git-svn-id: http://core.svn.wordpress.org/trunk@46419 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-31 00:13:01 +00:00
ed651b17a4
Upload:
...
- Run the `wp_generate_attachment_metadata` filter at the end in `wp_update_image_subsizes()` when new metadata was generated and additional image sub-sizes were created.
- Add another arg in the `wp_generate_attachment_metadata` filter for additional context.
- Fix inline docs and ensure the new image meta is always saved before starting post-processing.
Fixes #48472 for trunk.
Built from https://develop.svn.wordpress.org/trunk@46621
git-svn-id: http://core.svn.wordpress.org/trunk@46418 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-30 21:10:04 +00:00
0b94025ba9
Help/About: Update the 5.3 About page for RC3.
...
Previously [46556], [46572].
Props ryelle, SergeyBiryukov, afercia, desrosj, davidbaumwald, azaozz.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46616
git-svn-id: http://core.svn.wordpress.org/trunk@46413 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-29 20:10:04 +00:00
057f661ce3
Docs: Miscellaneous docblock corrections.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46610
git-svn-id: http://core.svn.wordpress.org/trunk@46407 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-28 19:48:01 +00:00
c8f91f77ac
Docs: Correct invalid hook docblocks.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46603
git-svn-id: http://core.svn.wordpress.org/trunk@46400 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-27 19:11:02 +00:00
9e2b6902b3
Docs: Update the docs for the error parameter that gets passed around during filesystem credential collection.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46597
git-svn-id: http://core.svn.wordpress.org/trunk@46394 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 23:16:04 +00:00
3caaa40fc6
Docs: Switch more docs over to typed array notation, plus some fixes.
...
See #48303 , #41756
Built from https://develop.svn.wordpress.org/trunk@46596
git-svn-id: http://core.svn.wordpress.org/trunk@46393 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 21:09:04 +00:00
7c2b9f2a2e
Docs: Miscellaneous docblock fixes and improvements.
...
See #48303
Built from https://develop.svn.wordpress.org/trunk@46594
git-svn-id: http://core.svn.wordpress.org/trunk@46391 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 20:43:04 +00:00
67ce1885db
Docs: Improve formatting of various `WP_Screen` DocBlocks.
...
See #48303 .
Built from https://develop.svn.wordpress.org/trunk@46591
git-svn-id: http://core.svn.wordpress.org/trunk@46388 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 00:36:05 +00:00
67c73ea3ea
Docs: Improve documentation for `WP_Screen::add_help_tab()`.
...
Props atachibana.
Fixes #48395 .
Built from https://develop.svn.wordpress.org/trunk@46590
git-svn-id: http://core.svn.wordpress.org/trunk@46387 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 00:34:07 +00:00
49007e52bc
Build/Test Tools: Add banner to RTL CSS and minified JS files.
...
Patches occasionally come in on generated files. We should be kind to new contributors and give them a hint that these files are auto-generated.
This is a follow-up to [41271], which added the banner to minified CSS files.
Fixes #48424 . See #30666 .
Built from https://develop.svn.wordpress.org/trunk@46589
git-svn-id: http://core.svn.wordpress.org/trunk@46386 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-26 00:17:07 +00:00
7e11e9d732
Posts, Post Types: Remove unintended change from [46578].
...
See #48384 .
Built from https://develop.svn.wordpress.org/trunk@46579
git-svn-id: http://core.svn.wordpress.org/trunk@46376 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 12:54:03 +00:00
0b83bffd45
Date/Time: Correct the logic in `WP_Posts_List_Table::column_date()` and `WP_Media_List_Table::column_date()` to check for a valid post timestamp.
...
Props Rarst.
Reviewed by azaozz, SergeyBiryukov.
See #48384 .
Built from https://develop.svn.wordpress.org/trunk@46578
git-svn-id: http://core.svn.wordpress.org/trunk@46375 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-25 12:51:03 +00:00
5b85aa1936
Accessibility: Restore the primary buttons original background color for alternate color schemes after [46241].
...
Props david.binda, audrasjb, azaozz.
See #34904 .
Fixes #48396 .
Built from https://develop.svn.wordpress.org/trunk@46575
git-svn-id: http://core.svn.wordpress.org/trunk@46372 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-23 20:57:05 +00:00
27994975f9
Help/About: Update the 5.3 About page for RC2.
...
This includes numerous improvements:
- Removes the jazzer name.
- Ensures `WordPress` is translatable for consistency with other occurrences in Core.
- Changes all instances of `Block Editor` to `block editor` to match the spelling best practices.
- Updates the PHP 7.4 compatibility section with more suitable text.
- Introduction in `credits.php`, `freedoms.php`, and `privacy.php` have been updated to be consistent with the About page.
- Fixes the `aria-current` attribute in tab navigation.
Reviewed by SergeyBiryukov, desrosj.
Props SergeyBiryukov, audrasjb, desrosj, ryelle, afercia.
See #47708 .
Built from https://develop.svn.wordpress.org/trunk@46572
git-svn-id: http://core.svn.wordpress.org/trunk@46369 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 19:19:07 +00:00
0609e04266
Administration: Relax the default value check for the `$position` argument added to `add_submenu_page()` and related functions in [46197].
...
Due to a confusion with `add_menu_page()`, which takes the `$icon_url` parameter, while `add_submenu_page()` does not, some plugins were passing in a string instead of integer as `$position`, causing backward compatibility issues.
A `_doing_it_wrong()` message is now added to alert developers of the wrong parameter type.
Props david.binda, desrosj, 123host, dennis_f, MattyRob.
Reviewed by desrosj.
Fixes #48249 .
Built from https://develop.svn.wordpress.org/trunk@46570
git-svn-id: http://core.svn.wordpress.org/trunk@46367 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-22 17:52:04 +00:00
e1560cd1e0
Media/Upload: When the users upload big images and WordPress creates a scaled image to use as the largest size, append `scaled-` to the file names of the scaled images to make them easier to recognize.
...
Props kraftbj, azaozz.
Fixes #48304 .
Built from https://develop.svn.wordpress.org/trunk@46565
git-svn-id: http://core.svn.wordpress.org/trunk@46362 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-21 21:43:04 +00:00
67104bb3f4
Administration: Revert changes to the admin menu styles for long line lengths.
...
This reverts [46555], [46453], and [46332].
See #42201
Built from https://develop.svn.wordpress.org/trunk@46561
git-svn-id: http://core.svn.wordpress.org/trunk@46358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-17 18:38:03 +00:00
1d6bd71ce4
Upgrade/Install: Use a unique error code when an update fails due to the PHP JSON extension missing.
...
This allows update failures caused when the native PHP JSON extension is missing to be distinguished from updates that fail because the site does not meet the minimum PHP requirements.
Follow up of [46455].
Reviewed by desrosj, jorbin, johnbillion.
Fixes #47699 .
Built from https://develop.svn.wordpress.org/trunk@46560
git-svn-id: http://core.svn.wordpress.org/trunk@46357 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-16 21:03:02 +00:00
44de60e8da
Script Loader: Partially revert [46550] as it brought in unrelated CSS changes.
...
[46550] was meant to revert [46440] but it also merged some unrelated CSS changes.
See #47069 .
Built from https://develop.svn.wordpress.org/trunk@46559
git-svn-id: http://core.svn.wordpress.org/trunk@46356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-16 17:49:03 +00:00
2ab1e4dcd8
Help/About: Let's tell the world about 5.3.
...
Props karmatosed, melchoyce, pierlo, ryelle, afercia, audrasjb, davidbaumwald
Thanks to everyone who provided feedback for this page for 5.3.
See #47708
Built from https://develop.svn.wordpress.org/trunk@46556
git-svn-id: http://core.svn.wordpress.org/trunk@46353 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-15 20:42:03 +00:00
7cdb93a374
Administration: Fix the appearance of update bubbles in submenus and when the admin menu is collapsed.
...
Props afercia, amolv, sabernhardt
Fixes #42201 , #48294
Built from https://develop.svn.wordpress.org/trunk@46555
git-svn-id: http://core.svn.wordpress.org/trunk@46352 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-15 19:39:01 +00:00
02810533c4
Accessibility: Script Loader: Remove jQuery as dependency of `admin-bar` after [46440].
...
A better approach needs to be explored, as there are valid concerns for potential conflicts between different jQuery versions added by themes or plugins.
See #47069 .
Built from https://develop.svn.wordpress.org/trunk@46550
git-svn-id: http://core.svn.wordpress.org/trunk@46347 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-15 17:23:04 +00:00
1940cf7d54
Media: Do not store error messages in the image meta. The initial idea was to (be able to) display these errors in the UI but it wasn't implemented as these errors are mostly helpful for low-level bedugging.
...
Fixes #40439 .
Built from https://develop.svn.wordpress.org/trunk@46507
git-svn-id: http://core.svn.wordpress.org/trunk@46304 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-14 20:05:01 +00:00
b0e0f69b2e
I18N: Don't capitalize "Extension" in `update_core()`, for consistency with other strings.
...
Follow-up to [46455].
See #47699 .
Built from https://develop.svn.wordpress.org/trunk@46464
git-svn-id: http://core.svn.wordpress.org/trunk@46262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-12 02:42:01 +00:00
e19329bad0
Docs: Add `requires_php` to the list of fields returned by `plugins_api()`.
...
Props ediamin.
Fixes #48291 .
Built from https://develop.svn.wordpress.org/trunk@46463
git-svn-id: http://core.svn.wordpress.org/trunk@46261 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-12 02:35:04 +00:00
ebd52ce048
Administration: Prevents horizontal scroll jumping around while admin menu is open.
...
This sets the `#adminmenuback` `position` CSS property to `fixed`.
Props promz, man4toman.
Fixes #47010 .
Built from https://develop.svn.wordpress.org/trunk@46460
git-svn-id: http://core.svn.wordpress.org/trunk@46258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-11 19:22:02 +00:00
66c8085fc4
Media: Update fallback previews to support `_wp_make_subsizes()`
...
Allows fallback previews (PDF by default, in core) to save image meta
after each size is generated to allow for resuming, and make sizes
immediately available.
Props azaozz, antpb, progremzion, mikeschroder.
See #48111 .
Built from https://develop.svn.wordpress.org/trunk@46459
git-svn-id: http://core.svn.wordpress.org/trunk@46257 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-11 07:54:03 +00:00
c6d3987b08
Upgrade/Install: Detect the presence of the native PHP JSON extension before updating.
...
The PHP native JSON extension has been bundled and compiled with PHP by default since version 5.2.0. Because the minimum version of PHP required by WordPress is now 5.6.20 (see #46594 and [45058]), the related polyfills and workarounds have been removed (see [46205-46206,46208]).
However, even though the JSON extension is now included in PHP by default, it is still possible to disable the extension in a custom configuration. This change will prevent sites from upgrading if the JSON extension is disabled to prevent compatibility issues.
Props jrf, jorbin, dd32, desrosj.
Fixes #47699 .
Built from https://develop.svn.wordpress.org/trunk@46455
git-svn-id: http://core.svn.wordpress.org/trunk@46253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-09 22:22:04 +00:00
ec02d199f4
Administration: Ensure visual consistency with large titles in the sidebar.
...
Custom posts, and other menu titles that are long aren't wrapping correctly.
Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb, afercia, amolv, iqbalbary, davidbaumwald.
Fixes #42201
Built from https://develop.svn.wordpress.org/trunk@46453
git-svn-id: http://core.svn.wordpress.org/trunk@46251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-09 04:58:02 +00:00
8d1e51e9c7
Docs: Add a `@since` note about new parameters with the spread operator added to function signatures.
...
Props jrf.
See #47678 .
Built from https://develop.svn.wordpress.org/trunk@46451
git-svn-id: http://core.svn.wordpress.org/trunk@46249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-09 04:28:02 +00:00
843c39b9bc
Themes: Properly align Close/Previous/Next icons in theme preview overlay.
...
Props chetan200891.
Fixes #48248 .
Built from https://develop.svn.wordpress.org/trunk@46444
git-svn-id: http://core.svn.wordpress.org/trunk@46242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-08 19:07:04 +00:00
93279742c1
Themes: Adjust CSS media query for theme overlay to match the breakpoint for a folded admin menu.
...
Props chetan200891.
Fixes #48250 .
Built from https://develop.svn.wordpress.org/trunk@46443
git-svn-id: http://core.svn.wordpress.org/trunk@46241 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-08 18:49:03 +00:00
477f0ffd71
Network Admin: Improve Site States in List Table rows.
...
This commit switches a comparison to a Yoda condition, performs a more strict `intval()` check on the value of the Site Status column, and prevents a specific Site State from appearing in List Table rows when filtering by that same Site State already (to match the behavior of other List Table State implementations.)
Fixes #37684 . Props pbiron.
Built from https://develop.svn.wordpress.org/trunk@46441
git-svn-id: http://core.svn.wordpress.org/trunk@46239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-08 17:46:02 +00:00
760a55b310
Docs: Add missing `@deprecated` tags in the file docblock of some deprecated files.
...
Props jrf.
Fixes #48254 .
Built from https://develop.svn.wordpress.org/trunk@46439
git-svn-id: http://core.svn.wordpress.org/trunk@46237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-08 17:19:04 +00:00
92f09c0496
Accessibility: Improve and modernize user interface controls: Revert the new links focus style.
...
Thew new dotted outline for the links focus style introduced in [46241] doesn't appear to be ready to guarantee a good indication of focus.
It was agreed to restore the previous links focus style and postpone exploration for a new style to the next release cycle.
Partially reverts [46241] and [46293].
See #34904 , #47153 .
Built from https://develop.svn.wordpress.org/trunk@46425
git-svn-id: http://core.svn.wordpress.org/trunk@46223 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-07 19:57:02 +00:00
3a27f92158
Accessibility: Improve and modernize user interface controls: Improve the buttons active CSS class.
...
- improves the buttons `.active` CSS class for buttons that need to be styled as "pressed"
- update the alternate color schemes `.active` CSS class accordingly
- improves a few icons colors in the alternate color schemes
See #34904 .
Built from https://develop.svn.wordpress.org/trunk@46423
git-svn-id: http://core.svn.wordpress.org/trunk@46221 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-07 18:47:05 +00:00
f793398e4f
Upload: Set custom header with the attachment ID for all uploads from `media_handle_upload()`. Let the REST API endpoint set it separately.
...
Props timothyblynjacobs.
Fixes #48200 .
Built from https://develop.svn.wordpress.org/trunk@46421
git-svn-id: http://core.svn.wordpress.org/trunk@46219 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-07 15:30:02 +00:00
e9065659f4
Accessibility: Improve and modernize user interface controls for better contrast: Further improvements to input heights and alignments.
...
- improves input fields height in the customizer
- improves input fields height for Internet Explorer 11
- improves input fields height in the Image Editor
- improves alignment of selects and buttons in the privacy policy pages
- makes the search themes fields font-size consistent
Props garrett-eclipse, afercia.
See #47477 .
Built from https://develop.svn.wordpress.org/trunk@46419
git-svn-id: http://core.svn.wordpress.org/trunk@46217 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-07 13:20:03 +00:00
1f3d583825
Accessibility: Media: Improve the search media field labelling.
...
Visible `<label>` elements benefit all users. The `placeholder` attribute should not be used as a replacement for visible labels.
Instead, it's supposed to be used only for a short hint to aid users with data entry e.g. a sample value or a brief description of the expected format.
Screen readers may not announce a `placeholder` attribute at all. Other users may suffer from the lack of a visible label and a placeholder used as replacement, for example:
- users with cognitive disabilities may have trouble remembering what the filled field does
- speech recognition users cannot see the name they can speak to set focus on the field
- low-vision users with high text-size may not be able to see the whole placeholder even when it's visible, if its value is clipped by the edge of the input
Props anevins, audrasjb, karmatosed, azaozz, SergeyBiryukov, afercia.
See #40331 .
Fixes #47138 .
Built from https://develop.svn.wordpress.org/trunk@46418
git-svn-id: http://core.svn.wordpress.org/trunk@46216 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-07 12:43:03 +00:00
ea5d76fbb2
Privacy: Ensure that sending email, and remove data follow the same user experience.
...
Both personal data request processes should follow the same convention.
Fixes : #43974 .
Props: garrett-eclipse, kjellr, Kerfred, birgire, marybaum, SergeyBiryukov.
Built from https://develop.svn.wordpress.org/trunk@46412
git-svn-id: http://core.svn.wordpress.org/trunk@46210 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-06 06:56:02 +00:00
4269998771
Administration: Add a max-width to the Privacy Policy Page dropdown.
...
If there's a page with an extra long title, the Privacy Policy page dropdown in Privacy Settings overflows the page width.
Fixes #47366
Props garrett-eclipse, SergeyBiryukov, mukesh27, desrosj, adhitya03, jalpa1984, nrqsnchz, paresh07.
Built from https://develop.svn.wordpress.org/trunk@46411
git-svn-id: http://core.svn.wordpress.org/trunk@46209 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-06 06:42:02 +00:00
554b60da76
Docs: Format comments in `wp-admin/includes/plugin.php` as per the documentation standards.
...
Props dkarfa.
Fixes #48191 .
Built from https://develop.svn.wordpress.org/trunk@46410
git-svn-id: http://core.svn.wordpress.org/trunk@46208 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-06 02:23:03 +00:00
ebd841790b
Build/Test: Update Grunt Uglify options
...
Follow up to [46408]
Sometimes you need to take documentation literally. And sometimes you need to take it seriously. Deprecations and replacements in uglify are a case where I took them literally and should have taken them seriously.
See #48203 .
Built from https://develop.svn.wordpress.org/trunk@46409
git-svn-id: http://core.svn.wordpress.org/trunk@46207 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 22:01:04 +00:00
0e21d32900
Build/Test: Bump devDependencies for WordPress 5.3
...
This upgrades a number of devDependencies. Some of these include changes to how the tasks are configured.
Uglify: There are deprecated options from 2.x to 4.x, see: https://github.com/gruntjs/grunt-contrib-uglify#options
Autoprefixer: Browserslist now warns when passing in the browser list, so that is put into package.json
As with most changes to uglify, this changes every minified JS file.
Fixes #48203 .
Built from https://develop.svn.wordpress.org/trunk@46408
git-svn-id: http://core.svn.wordpress.org/trunk@46206 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 19:49:10 +00:00
3520f5234b
Taxonomy: Prevent Parent Category dropdown and field descriptions on Categories and Edit Category screens from extending beyond the other fields.
...
Props garrett-eclipse, dkarfa.
Fixes #48188 .
Built from https://develop.svn.wordpress.org/trunk@46405
git-svn-id: http://core.svn.wordpress.org/trunk@46204 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 15:41:57 +00:00
a92b23ee61
Build/Test tools: Update grunt-contrib-imagemin and run it
...
Smaller images are good, so is not having npm vulnerabilities.
See #48203 .
Fixes #48206 .
Props whyisjake, netweb.
Built from https://develop.svn.wordpress.org/trunk@46404
git-svn-id: http://core.svn.wordpress.org/trunk@46203 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 14:20:59 +00:00
f1b5f2aa94
Site Health: Improve the wording for `UTF8MB4` test description.
...
Props garrett-eclipse, chetan200891, johnjamesjacoby, ayeshrajans.
Fixes #48044 .
Built from https://develop.svn.wordpress.org/trunk@46402
git-svn-id: http://core.svn.wordpress.org/trunk@46201 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 02:39:58 +00:00
2237306c2b
Customize: Remove duplicate `attr_title` assignment in `api.Menus.MenuItemControl.renderContent()`.
...
See #47838 .
Built from https://develop.svn.wordpress.org/trunk@46401
git-svn-id: http://core.svn.wordpress.org/trunk@46200 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 02:32:58 +00:00
f19ecd19de
Filesystem API: Use strict type check in the `in_array()` call for the `$skip_list` parameter in `copy_dir()` and `_copy_dir()`.
...
This ensures that parent folders with a numeric name are not accidentally skipped when only a subfolder is intended to be skipped.
Props codex-m.
Fixes #46581 .
Built from https://develop.svn.wordpress.org/trunk@46400
git-svn-id: http://core.svn.wordpress.org/trunk@46199 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 02:16:56 +00:00
30913bc9a2
Docs: Correct formatting of the `@return` value description in `_wp_handle_upload()`.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46399
git-svn-id: http://core.svn.wordpress.org/trunk@46198 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 02:09:57 +00:00
60617d471b
Docs: Add missing documentation for the first parameter of the `big_image_size_threshold` filter.
...
Props dkarfa, desrosj, earnjam.
Fixes #48214 .
Built from https://develop.svn.wordpress.org/trunk@46398
git-svn-id: http://core.svn.wordpress.org/trunk@46197 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-05 01:30:58 +00:00
d2a48496d2
Docs: Add missing description for `$comment` global.
...
Props immeet94, mukesh27.
Fixes #46928 . See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46391
git-svn-id: http://core.svn.wordpress.org/trunk@46190 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 22:19:57 +00:00
f34db2aa7e
I18N: Add missing comma in a translator comment.
...
See #47515 .
Built from https://develop.svn.wordpress.org/trunk@46390
git-svn-id: http://core.svn.wordpress.org/trunk@46189 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 22:09:57 +00:00
d38d1c2c35
I18N: Fix translator comment for a themes list table string with numbered placeholders.
...
Props garrett-eclipse.
Fixes #47515 .
Built from https://develop.svn.wordpress.org/trunk@46387
git-svn-id: http://core.svn.wordpress.org/trunk@46186 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 20:20:58 +00:00
6f38c7fb81
Docs: Convert 'Block Editor' to lowercase.
...
Props garrett-eclipse.
Fixes #45634 .
Built from https://develop.svn.wordpress.org/trunk@46386
git-svn-id: http://core.svn.wordpress.org/trunk@46185 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 20:12:58 +00:00
cd6110782e
Networks and Sites: Improve newly added strings for i18n.
...
* Remove unnecessary numbered placeholders.
* Add context to "All" and "Spam" status.
* Add translator comments.
Props pedromendonca.
Fixes #48210 .
Built from https://develop.svn.wordpress.org/trunk@46385
git-svn-id: http://core.svn.wordpress.org/trunk@46184 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 19:58:55 +00:00
143b5fd080
Networks and Sites: Fix issues processing additional fields displayed for the Sites list table.
...
This prevents a `The link you followed has expired.` error when using a filter and now uses `$_POST` instead of `$_GET` to capture all form values.
Props pbiron.
Fixes #45954 .
Built from https://develop.svn.wordpress.org/trunk@46384
git-svn-id: http://core.svn.wordpress.org/trunk@46183 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-04 14:32:56 +00:00
ff225c8bfc
Upload: Fix the method used to create image sub-sizes when uploading fails with a PHP fatal error. Use a custom header to send the new attachment post ID even in HTTP 500 responses instead of an upload reference sent by the client. Also add another cap check and remove the action when deleting an attachment post during a failed upload cleanup.
...
Props timothyblynjacobs, clorith, azaozz.
Fixes #48200 .
Built from https://develop.svn.wordpress.org/trunk@46382
git-svn-id: http://core.svn.wordpress.org/trunk@46181 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-03 21:02:00 +00:00
efa9da7446
Docs: Fix code example for removing internal pointers.
...
Props daleharrison, swissspidy, garrett-eclipse, luciano-croce, jrf, desrosj.
Fixes #45529 .
Built from https://develop.svn.wordpress.org/trunk@46381
git-svn-id: http://core.svn.wordpress.org/trunk@46180 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-03 20:39:58 +00:00
6a0f3ddae3
Menus: Fix typo in the class attribute for the hidden `title` field in `Walker_Nav_Menu_Checklist`.
...
Each item that `Walker_Nav_Menu_Checklist` displays is accompanied by several hidden `<input/>` fields that specify default values for each item when added to a menu. These values are passed in JavaScript to the AJAX call triggered when an item is added to a menu.
The hidden field for the title attribute field incorrectly had an underscore instead of a hyphen. Because of this, it was impossible to supply a default value for the Title Attribute field of a nav menu item.
Props yanngarcia, davidbaumwald.
See #47838 .
Built from https://develop.svn.wordpress.org/trunk@46380
git-svn-id: http://core.svn.wordpress.org/trunk@46179 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-03 20:03:56 +00:00
3e40f12574
Privacy: Remove unused `$wpdb` global in `WP_Privacy_Requests_Table::prepare_items()`.
...
Props david.binda.
Fixes #48178 .
Built from https://develop.svn.wordpress.org/trunk@46374
git-svn-id: http://core.svn.wordpress.org/trunk@46173 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-02 23:22:58 +00:00
4b939d5a93
Login and Registration: Hide the Edge browser "Reveal password" native button.
...
Props Clorith.
Fixes #42888 .
Built from https://develop.svn.wordpress.org/trunk@46372
git-svn-id: http://core.svn.wordpress.org/trunk@46171 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-01 18:01:01 +00:00
da00051294
Accessibility: Improve and modernize user interface controls for better contrast: Login screen improvements.
...
- allows the login input fields to better scale with text
- improves the input fields layout on Internet Explorer 11
- uses the new focus style on the "Show password" button
- adjusts the CSS for the interim login
See #47153 .
See #42888 .
Built from https://develop.svn.wordpress.org/trunk@46371
git-svn-id: http://core.svn.wordpress.org/trunk@46170 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-01 15:55:57 +00:00
44c3cefb24
Docs: Fix typo in `wp_get_missing_image_subsizes()` DocBlock.
...
Props david.binda.
Fixes #48179 .
Built from https://develop.svn.wordpress.org/trunk@46368
git-svn-id: http://core.svn.wordpress.org/trunk@46167 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-10-01 01:19:57 +00:00
f86d225d26
Accessibility: Improve and modernize user interface controls: Improve new styles for the color picker.
...
Props audrasjb, garrett-eclipse.
Fixes #48131 .
Built from https://develop.svn.wordpress.org/trunk@46360
git-svn-id: http://core.svn.wordpress.org/trunk@46159 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 18:05:59 +00:00
6531c237e7
Media: Prevents clipping of text when scaling image edit screen.
...
This reapplies [46354] clean as the previous commit had remnants of an unrelated patch.
Props sabernhardt, audrasjb, afercia.
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46359
git-svn-id: http://core.svn.wordpress.org/trunk@46158 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:56:57 +00:00
ae29987a17
Site Health: Improve the message displayed to sites not utilizing HTTPS.
...
The new message better illustrates that there are many potential benefits of using HTTPS, not just a few.
Props garrett-eclipse, dkarfa, ocean90, afragen, desrosj.
Fixes #48118 .
Built from https://develop.svn.wordpress.org/trunk@46358
git-svn-id: http://core.svn.wordpress.org/trunk@46157 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:54:58 +00:00
6566808e8a
Accessibility: Improve and modernize user interface controls: Improve the new form controls styles and heights.
...
Improves cross-browsers rendering and addresses most of the reported edge cases.
See #47477 .
Built from https://develop.svn.wordpress.org/trunk@46356
git-svn-id: http://core.svn.wordpress.org/trunk@46155 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:24:59 +00:00
247e7eb7d5
Media: Revert [46354] preventing bad clipping of text in image details page.
...
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46355
git-svn-id: http://core.svn.wordpress.org/trunk@46154 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 17:12:59 +00:00
7c8028febf
Media: Prevents clipping of text when scaling image edit screen.
...
Props sabernhardt, audrasjb, afercia.
See #47115 .
Built from https://develop.svn.wordpress.org/trunk@46354
git-svn-id: http://core.svn.wordpress.org/trunk@46153 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 16:34:58 +00:00
38e6958698
Media: Move `wp_get_original_image_path()` to `wp-content/post.php` to make it easier to access from plugins.
...
Props pbiron.
See #47873 .
Built from https://develop.svn.wordpress.org/trunk@46353
git-svn-id: http://core.svn.wordpress.org/trunk@46152 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 16:28:59 +00:00
20e781f44d
Accessibility: Improve and modernize user interface controls: Remove the CSS transform 1 pixel shift from the buttons active state.
...
Props Joen.
See #34904 .
Built from https://develop.svn.wordpress.org/trunk@46350
git-svn-id: http://core.svn.wordpress.org/trunk@46149 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 10:53:57 +00:00
8cb7c5c764
Upgrade/Install: Fix the Install Now button in the plugin overlay when running WordPress on a specific port.
...
Props garrett-eclipse, pierlo, afragen.
Fixes #48077 .
Built from https://develop.svn.wordpress.org/trunk@46348
git-svn-id: http://core.svn.wordpress.org/trunk@46147 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-30 00:05:57 +00:00
dfcdb40c8f
Accessibility: Improve and modernize user interface controls: Improve the radio buttons blue dot alignment.
...
Props desrosj, garrett-eclipse, afercia.
See #47498 .
Built from https://develop.svn.wordpress.org/trunk@46345
git-svn-id: http://core.svn.wordpress.org/trunk@46144 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 21:56:56 +00:00
8ef586a897
Accessibility: Improve and modernize user interface controls: Make the secondary buttons border blue.
...
Props drw158, youknowriad, kjellr, melchoyce, talldanwp, audrasjb.
See #34904 .
Built from https://develop.svn.wordpress.org/trunk@46344
git-svn-id: http://core.svn.wordpress.org/trunk@46143 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 21:53:57 +00:00
5f2c7142a1
Docs: Improve documentation for `::display()` methods in various list tables.
...
Props itowhid06.
Fixes #47947 .
Built from https://develop.svn.wordpress.org/trunk@46341
git-svn-id: http://core.svn.wordpress.org/trunk@46140 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-29 11:04:58 +00:00
55b1dc642e
Accessibility: After [46337]: make the select elements background white also on hover, active, and focus states.
...
See #47477 .
See #48128 .
Built from https://develop.svn.wordpress.org/trunk@46340
git-svn-id: http://core.svn.wordpress.org/trunk@46139 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:45:57 +00:00
7d769a9234
Accessibility: Improve and modernize user interface controls. Style the select elements disabled state.
...
Props adhitya03, MarcosAlexandre, kjellr.
See #47477 .
Fixes #48129 .
Built from https://develop.svn.wordpress.org/trunk@46339
git-svn-id: http://core.svn.wordpress.org/trunk@46138 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:35:59 +00:00
dd44ab5a58
Fix the context (right-click) menu when clicking the placeholder for the post title field on the classic Edit Post screen.
...
Props masummdar, audrasjb, afercia.
Fixes #47318 .
Built from https://develop.svn.wordpress.org/trunk@46338
git-svn-id: http://core.svn.wordpress.org/trunk@46137 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:20:57 +00:00
becc682bcf
Accessibility: Improve and modernize user interface controls. Make the select elements background white.
...
Props adhitya03.
See #47477 .
Fixes #48128 .
Built from https://develop.svn.wordpress.org/trunk@46337
git-svn-id: http://core.svn.wordpress.org/trunk@46136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-28 16:15:59 +00:00
07a753cb35
Docs: Add documentation for `WP_Comments_List_Table::display()`.
...
Props itowhid06, dinhtungdu.
Fixes #47929 .
Built from https://develop.svn.wordpress.org/trunk@46336
git-svn-id: http://core.svn.wordpress.org/trunk@46135 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-27 23:03:58 +00:00
b6f7c0cbc4
Administration: Ensure visual consistency with large titles in the sidebar.
...
Custom posts, and other menu titles that are long aren't wrapping correctly.
Props jagirbaheshwp, munyagu, harshbarach, hareesh-pillai, pratikkry, naveenkharwar, mukesh27, dushanthi, worldweb, audrasjb
Fixes #42201
Built from https://develop.svn.wordpress.org/trunk@46332
git-svn-id: http://core.svn.wordpress.org/trunk@46131 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 21:51:57 +00:00
66dd6814e7
Media: Restore the original Image Editor columns layout after [46326].
...
Fixes #47116 .
Built from https://develop.svn.wordpress.org/trunk@46331
git-svn-id: http://core.svn.wordpress.org/trunk@46130 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:37:57 +00:00
c034f5b4c3
Menus: Replace http with https in placeholders.
...
Encourage the use of https with the placeholder text in menus.
Fixes #46312
Props aksl95, audrasjb, celloexpressions, SergeyBiryukov, jorbin.
Built from https://develop.svn.wordpress.org/trunk@46330
git-svn-id: http://core.svn.wordpress.org/trunk@46129 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 20:32:55 +00:00
93dd6d907a
Accessibility: Media: Make the Image Editor buttons text visible.
...
User interface controls that use only icons aren't ideal for many users.
Universal icons are rare. Icons must communicate meaning but their actual meaning varies depending on many factors including the users cultural background.
Moreover, users with cognitive impairments and speech recognition users need interface controls with visible text to be able to operate them.
- shortens some of the buttons text to: Rotate left, Rotate right, Flip vertical, Flip horizontal
- moves the Undo and Redo buttons underneath the main buttons group
Props nrqsnchz, melchoyce, karmatosed, sabernhardt, mikeschroder.
Fixes #47116 .
Built from https://develop.svn.wordpress.org/trunk@46326
git-svn-id: http://core.svn.wordpress.org/trunk@46125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 17:16:57 +00:00
6e8f550770
General: Correct strict comparison in `WP_Links_List_Table::column_categories()` introduced in [46313].
...
`$cat_id` is a string, `$category` is an integer.
See #48142 .
Built from https://develop.svn.wordpress.org/trunk@46316
git-svn-id: http://core.svn.wordpress.org/trunk@46115 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 01:24:56 +00:00
148322a970
Docs: Improve documentation for `_post_states()` and `get_post_states()`.
...
Add documentation for `_media_states()`.
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46315
git-svn-id: http://core.svn.wordpress.org/trunk@46114 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 00:57:58 +00:00
a351243928
General: Further phpcs cleanup.
...
In [46312] and [46313] we attempted to do some phpcs cleanup. This commit cleans up three issues that were introduced in [46309].
Fixes #48142 .
Props: whyisjake, garrett-eclipse, desrosj
Built from https://develop.svn.wordpress.org/trunk@46314
git-svn-id: http://core.svn.wordpress.org/trunk@46113 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-26 00:37:58 +00:00
d53b773a47
General: Further phpcs cleanup.
...
In [46312] we attempted to do some `phpcs` cleanup. This commit cleans up three issues that were introduced in [46309].
Fixes #48142 .
Props whyisjake, garrett-eclipse.
Built from https://develop.svn.wordpress.org/trunk@46313
git-svn-id: http://core.svn.wordpress.org/trunk@46112 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 23:38:57 +00:00
38dc032e66
General: Linter cleanup
...
`phpcbf` was able to clean up a few files. Tests were breaking as a result of code formatting.
Fixes #48142
Props whyisjake
Built from https://develop.svn.wordpress.org/trunk@46312
git-svn-id: http://core.svn.wordpress.org/trunk@46111 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 22:53:58 +00:00
b4ab6b7e14
Menus: Duplicate Page Entry in View All Pages when generating a Menu
...
Simplifies the interface in menu creation.
Fixes [37782]
Props garrett-eclipse, mdgl, birgire, xkon, audrasjb, pento, girlieworks
Built from https://develop.svn.wordpress.org/trunk@46309
git-svn-id: http://core.svn.wordpress.org/trunk@46108 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 21:51:58 +00:00
f8a25a89c9
Accessibility: Implement the new focus styles on the login screen after [46247].
...
Props @kjellr.
See #47153 .
Built from https://develop.svn.wordpress.org/trunk@46293
git-svn-id: http://core.svn.wordpress.org/trunk@46105 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 16:40:00 +00:00
894e133d0c
Build/Test Tools: Introduce automated PHP compatibility checking.
...
This change introduces a new Composer script, `compat` that will scan the codebase for (detectable) potential PHP compatibility issues using the `PHP_CodeSniffer` and a custom ruleset based off of the `PHPCompayibilityWP` ruleset (`phpcompat.xml.dist`).
The command will be run as a separate job within each Travis build. While many compatibility issues and false positives have already been corrected in this commit and other Trac tickets, there are still some remaining. For that reason, the job is allowed to fail while the remainder of the potential compatibility issues are investigated and addressed. After those are resolved, the job should be set as required to pass to help prevent new compatibility issues from being introduced.
Props desrosj, jrf, all PHPCompatibilityWP and PHPCompatibility contributors.
Fixes #46152 .
Built from https://develop.svn.wordpress.org/trunk@46290
git-svn-id: http://core.svn.wordpress.org/trunk@46102 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-25 13:47:58 +00:00
c7f4cbc62c
Docs: Improve consistency in `@since` tags for parameters that were made optional.
...
See #47110 .
Built from https://develop.svn.wordpress.org/trunk@46288
git-svn-id: http://core.svn.wordpress.org/trunk@46100 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-24 12:54:57 +00:00
a943fd64bc
Coding Standards: Fix WPCS issue in [46283].
...
See #48110 .
Built from https://develop.svn.wordpress.org/trunk@46284
git-svn-id: http://core.svn.wordpress.org/trunk@46096 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 23:24:57 +00:00
75ca249558
Twenty Twenty: Rename widget areas to `sidebar-1` and `sidebar-2`.
...
This ensures that widgets are mapped correctly and is consistent with the previous default themes.
See https://github.com/WordPress/twentytwenty/issues/481 .
Reverts [46282].
Props ocean90, garrett-eclipse, desrosj, SergeyBiryukov.
See #48110 .
Built from https://develop.svn.wordpress.org/trunk@46283
git-svn-id: http://core.svn.wordpress.org/trunk@46095 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 23:17:58 +00:00
b95b6f2c73
Site Health: Move "The folder ... was detected as being under version control" message from failure to warning.
...
Props afragen, davidbaumwald.
Fixes #47982 .
Built from https://develop.svn.wordpress.org/trunk@46281
git-svn-id: http://core.svn.wordpress.org/trunk@46093 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 21:24:56 +00:00
098455b06f
Bundled Themes: Make Twenty Twenty the new default theme.
...
After being imported in [46271], Twenty Twenty can now be set as the default theme in WordPress.
See #48110 .
Props desrosj, ocean90.
Built from https://develop.svn.wordpress.org/trunk@46278
git-svn-id: http://core.svn.wordpress.org/trunk@46090 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 21:00:58 +00:00
c117b9957f
Site Health: Use `WP_Automatic_Updater::is_disabled()` to check whether automatic updates are disabled.
...
The previous check for `DISALLOW_FILE_MODS` and `AUTOMATIC_UPDATER_DISABLED` constants didn't always provide accurate results.
Props Clorith, kraftner, afragen.
Fixes #47869 .
Built from https://develop.svn.wordpress.org/trunk@46276
git-svn-id: http://core.svn.wordpress.org/trunk@46088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 20:52:56 +00:00
371f83cfd1
Site Health: Introduce `site_status_test_result` filter for the output of a finished Site Health test.
...
Props Clorith.
Fixes #47864 .
Built from https://develop.svn.wordpress.org/trunk@46269
git-svn-id: http://core.svn.wordpress.org/trunk@46081 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 20:04:58 +00:00
db5f9f7a3a
Site Health: Update PHP extension tests to reflect the current state of the Hosting Teams handbook recommendations.
...
Props Clorith, bronsonquick, jrf, johnbillion, galbaras, mikeschroder, jorbin.
Fixes #47454 .
Built from https://develop.svn.wordpress.org/trunk@46268
git-svn-id: http://core.svn.wordpress.org/trunk@46080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:50:56 +00:00
9510aaecde
Site Health: Improve wording for PHP update warning.
...
Props danieltj, garrett-eclipse, marybaum, afragen, chetan200891.
Fixes #47644 .
Built from https://develop.svn.wordpress.org/trunk@46267
git-svn-id: http://core.svn.wordpress.org/trunk@46079 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:39:58 +00:00
5955f0938b
Privacy: Introduce `wp_privacy_personal_data_email_to` and `wp_privacy_personal_data_email_subject` filters.
...
Pass email data to the `wp_privacy_personal_data_email_content` filter.
Props garrett-eclipse, thakkarhardik, birgire.
Fixes #46303 .
Built from https://develop.svn.wordpress.org/trunk@46265
git-svn-id: http://core.svn.wordpress.org/trunk@46077 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:25:57 +00:00
255b1d6e3f
Privacy: Show a success message for personal data erasure.
...
Props garrett-eclipse, allendav, birgire, JoshuaWold, karmatosed, pputzer.
Fixes #44135 .
Built from https://develop.svn.wordpress.org/trunk@46264
git-svn-id: http://core.svn.wordpress.org/trunk@46076 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:13:58 +00:00
f14fc1392c
Taxonomy: Redirect to the correct URL after deleting a taxonomy term attached to a post type other than Post.
...
Props donmhico, mukesh27
Fixes #47858
Built from https://develop.svn.wordpress.org/trunk@46263
git-svn-id: http://core.svn.wordpress.org/trunk@46075 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 19:10:58 +00:00
bcbedd7f55
Coding Standards: Fix a coding standards issue introduced in [46254].
...
See #37392 .
Built from https://develop.svn.wordpress.org/trunk@46261
git-svn-id: http://core.svn.wordpress.org/trunk@46073 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 18:35:00 +00:00
0d75495612
Login and Registration: Add a "Show password" button on the login page.
...
The ability for users to see the password they're typing improves usability and accessibility of the login users flow.
- brings the login screen in line with the same feature already used in the New User, Edit User, and Reset Password pages
- improves association of labels and input fields by using explicit association with `for` / `id` attributes
- slightly increases the "Remember me" label font size
Props johnbillion, Iceable, audrasjb, joyously, adamsilverstein, boemedia, DrewAPicture, shadyvb, birgire, peterwilsoncc, pento, anevins, davidbaumwald, whyisjake, afercia.
Fixes #42888 .
Built from https://develop.svn.wordpress.org/trunk@46256
git-svn-id: http://core.svn.wordpress.org/trunk@46068 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 18:06:57 +00:00
e5302dff26
Multisite/Sites: supplemental commit to r46251.
...
This commit adds the links to the list-table class itself (that were missed in r46251.)
See #37392 . Props pbiron, thomaswm.
Built from https://develop.svn.wordpress.org/trunk@46254
git-svn-id: http://core.svn.wordpress.org/trunk@46066 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:51:58 +00:00
22ae908ede
Editor: Add Nonce Endpoint
...
This is a follow up to #47843 , implementing a PHP endpoint and inline scripts
after the editor package updates. The action was originally added in
https://github.com/WordPress/gutenberg/pull/16683 .
Fixes #48076 .
Built from https://develop.svn.wordpress.org/trunk@46253
git-svn-id: http://core.svn.wordpress.org/trunk@46065 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:47:56 +00:00
b65ea119bb
Multisite/Sites: Add links to filter websites by status.
...
This commit brings the Network-Admin Sites list page up-to-speed with other similar list-table powered pages, by adding links to filter the results by Site Status.
Includes a single unit test for the newly introduced `wp_count_sites()` multisite function, named to match the `wp_count_` function pattern from other list tables.
Fixes #37392 . Props mnelson4, spacedmonkey, pbiron.
Built from https://develop.svn.wordpress.org/trunk@46251
git-svn-id: http://core.svn.wordpress.org/trunk@46063 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:35:59 +00:00
956725990f
Accessibility: Make sortable meta boxes non sortable when there are no locations they can be dragged to.
...
Depending on the amount of meta boxes and the layout settings under Screen Options, sortable meta boxes may not be actually sortable.
In these cases, jQuery UI sortable needs to be disabled and the user interface shouldn't use a CSS `cursor: move`.
The use of consistent and relevant cursors may be important for users who have a cognitive disability, since cursors give a visual clue as to an element's functionality. Using the move cursor for elements which cannot be moved may be confusing or counter-intuitive for users.
Props adamsilverstein, antpb, anevins.
Fixes #47131 .
Built from https://develop.svn.wordpress.org/trunk@46250
git-svn-id: http://core.svn.wordpress.org/trunk@46062 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 17:30:58 +00:00
6cb8e14790
Accessibility: Improve and modernize user interface controls. Sixth part: allow checkboxes and radio buttons to scale with text.
...
- uses a SVG icon for checkboxes
- uses CSS `rem` relative units
Props kjellr, afercia, audrasjb.
Fixes #47498 .
Built from https://develop.svn.wordpress.org/trunk@46248
git-svn-id: http://core.svn.wordpress.org/trunk@46060 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 16:51:57 +00:00
165ac34260
Accessibility: Improve and modernize user interface controls for better contrast. Fifth part: Common form controls.
...
Props anevins, melchoyce, audrasjb, kjellr.
Fixes #47153 .
Built from https://develop.svn.wordpress.org/trunk@46247
git-svn-id: http://core.svn.wordpress.org/trunk@46059 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 16:21:58 +00:00
46892ffb12
Media: Sets `post_id` optional in `media_sideload_image()` and `media_handle_sideload()`.
...
Props SergeyBiryukov, donmhico, mikeschroder, sebastian.pisula.
Fixes #43579 .
Built from https://develop.svn.wordpress.org/trunk@46245
git-svn-id: http://core.svn.wordpress.org/trunk@46057 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 16:03:56 +00:00
38be855367
Accessibility: Improve and modernize user interface controls. Third part: allow buttons and form controls to scale with text.
...
Props kjellr, abrightclearweb, audrasjb.
Fixes #47477 .
Built from https://develop.svn.wordpress.org/trunk@46243
git-svn-id: http://core.svn.wordpress.org/trunk@46055 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 15:27:57 +00:00
271f45072d
Accessibility: Improve and modernize user interface controls for better contrast. Second part: tables, meta boxes, and other user interface elements.
...
Introduces better contrast for borders of the following user interface elements:
- Tables
- Screen Options and Help
- Admin notices
- Welcome panel
- Meta boxes (post boxes)
- Cards
- Health Check accordions and headings
- Theme and Plugin upload forms
Props kjellr, melchoyce, karmatosed, audrasjb.
Fixes #48101 .
Built from https://develop.svn.wordpress.org/trunk@46242
git-svn-id: http://core.svn.wordpress.org/trunk@46054 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 15:10:59 +00:00
618883f6f4
Accessibility: Improve and modernize user interface controls for better contrast. First part: buttons and links.
...
- Introduces new styles for the buttons, with better contrast for borders and better focus style.
- Introduces a new focus style for links.
- The new styles improve consistency with the ones used in the new Block Editor (Gutenberg).
Props michaelarestad, truchot, mor10, kellychoffman, adamsoucie, paaljoachim, Joen, kjellr, melchoyce, karmatosed, audrasjb, afercia.
Fixes #34904 .
Built from https://develop.svn.wordpress.org/trunk@46241
git-svn-id: http://core.svn.wordpress.org/trunk@46053 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-09-23 14:43:58 +00:00
Sergey Biryukov
Andrew Ozz
John Blackbourn
Aaron Jorbin
Dominik Schilling
Andrea Fercia
whyisjake
desrosj
antpb
Mike Schroder
johnjamesjacoby
Ella Iseulde Van Dorpe