WordPress/wp-includes/IXR
hellofromTonya 2fa3d5a56f Code Modernization: Remove xml_set_object() in IXR_Message::parse().
The XML Parser extension still supports a quite dated mechanism for method based callbacks, where the object is first set via `xml_set_object()` and the callbacks are then set by passing only the name of the method to the relevant parameters on any of the `xml_set_*_handler()` functions.

{{{
xml_set_object( $parser, $my_obj );
xml_set_character_data_handler( $parser, 'method_name_on_my_obj' );
}}}

Passing proper callables to the `xml_set_*_handler()` functions has been supported for the longest time and is cross-version compatible. So the above code is 100% equivalent to:

{{{
xml_set_character_data_handler( $parser, [$my_obj, 'method_name_on_my_obj'] );
}}}

The mechanism of setting the callbacks with `xml_set_object()` has now been deprecated as of PHP 8.4, in favour of passing proper callables to the `xml_set_*_handler()` functions. This is also means that calling the `xml_set_object()` function is deprecated as well.

This commit fixes this deprecation for the `IXR_Message::parse()` method.

This change is safeguarded via the new`Tests_XMLRPC_Message::test_parse_sets_handlers()` test method.

Note: Though this is "officially" an external library, this package is no longer externally maintained. The code style of the fix in the source file is in line with the existing code style for the file.

Refs:
* https://wiki.php.net/rfc/deprecations_php_8_4#xml_set_object_and_xml_set_handler_with_string_method_names
* https://www.php.net/manual/en/function.xml-set-object.php
* https://www.php.net/manual/en/ref.xml.php

Follow-up to [15612], [1346].

Props jrf, hellofromTonya.
See #62061.
Built from https://develop.svn.wordpress.org/trunk@59056


git-svn-id: http://core.svn.wordpress.org/trunk@58452 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-09-18 18:04:14 +00:00
..
class-IXR-base64.php XML-RPC: break up `class-IXR.php` into individual class files. 2016-08-26 22:08:33 +00:00
class-IXR-client.php Code Modernization: Introduce the spread operator in `WP_HTTP_IXR_Client`. 2020-06-30 19:50:04 +00:00
class-IXR-clientmulticall.php Code Modernization: Introduce the spread operator in `WP_HTTP_IXR_Client`. 2020-06-30 19:50:04 +00:00
class-IXR-date.php Date/Time: Replace all instances of `date()` with `gmdate()`. 2019-05-26 00:12:54 +00:00
class-IXR-error.php XML-RPC: break up `class-IXR.php` into individual class files. 2016-08-26 22:08:33 +00:00
class-IXR-introspectionserver.php XML-RPC: break up `class-IXR.php` into individual class files. 2016-08-26 22:08:33 +00:00
class-IXR-message.php Code Modernization: Remove xml_set_object() in IXR_Message::parse(). 2024-09-18 18:04:14 +00:00
class-IXR-request.php XML-RPC: break up `class-IXR.php` into individual class files. 2016-08-26 22:08:33 +00:00
class-IXR-server.php XML-RPC: Set HTTP status code in accordance with the spec. 2021-05-24 02:18:58 +00:00
class-IXR-value.php XML-RPC: break up `class-IXR.php` into individual class files. 2016-08-26 22:08:33 +00:00