WordPress/wp-admin/includes
Felix Arntz 4e167c593d Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options.
It is recommended that for every option it is explicitly set whether to autoload it or not. This changeset updates relevant `update_option()` and `add_option()` calls.

Note that the `$autoload` parameter is only needed for `update_option()` if the option is potentially not present yet, i.e. the call will pass through to `add_option()`. Since WordPress core adds the majority of its options to the database during installation, only `update_option()` calls for dynamically added options need to be modified, which is what this changeset does.

As part of revisiting the autoload values for dynamically added WordPress core options, this changeset modifies some options to no longer be autoloaded, since they are only accessed in a few specific places that are not relevant for a regular request. These options are:
* `recently_activated`
* `_wp_suggested_policy_text_has_changed`
* `{upgradeLock}.lock`
* `dashboard_widget_options`
* `ftp_credentials`
* `adminhash`
* `nav_menu_options`
* `wp_force_deactivated_plugins`
* `delete_blog_hash`
* `allowedthemes`
* `{sessionId}_paused_extensions`
* `recovery_keys`
* `https_detection_errors`
* `fresh_site`

An upgrade routine is present as well that sets those options to no longer autoload for existing sites.

Props pbearne, flixos90, mukesh27, swissspidy, SergeyBiryukov, joemcgill, adamsilverstein.
Fixes #61103.

Built from https://develop.svn.wordpress.org/trunk@58975


git-svn-id: http://core.svn.wordpress.org/trunk@58371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2024-09-03 18:19:14 +00:00
..
admin-filters.php Script Loader: Replace hardcoded output of style tags with calls to `wp_add_inline_style`. 2023-09-25 17:06:34 +00:00
admin.php General: add nonce for block theme preview activation. 2023-07-11 05:03:23 +00:00
ajax-actions.php Options: Fix some default autoload values used in core. 2024-06-14 15:21:10 +00:00
bookmark.php Docs: Various improvements in Bookmark Administration API function descriptions, as per docblocks standards. 2023-05-03 10:03:21 +00:00
class-automatic-upgrader-skin.php Code Modernization: Replace usage of `strpos()` with `str_contains()`. 2023-06-22 14:36:26 +00:00
class-bulk-plugin-upgrader-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-bulk-theme-upgrader-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-bulk-upgrader-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-core-upgrader.php Upgrade/Install: Remove the download authenticity message from Core/Plugins/Themes updates. 2024-06-04 06:30:16 +00:00
class-custom-background.php Docs: Improve documentation for `Custom_Image_Header` and `Custom_Background` constructors. 2023-12-07 15:14:27 +00:00
class-custom-image-header.php Media: Accessibility: Copy attachment properties on site icon crop. 2024-03-02 20:15:13 +00:00
class-file-upload-upgrader.php Upload: Add links back to installer pages. 2024-03-07 05:58:15 +00:00
class-ftp-pure.php Docs: Update URLs in some `@link` tags and switch them to HTTPS. 2019-11-01 14:57:02 +00:00
class-ftp-sockets.php Administration: Replace contracted verb forms for better consistency. 2022-03-22 16:25:03 +00:00
class-ftp.php Filesystem API: Fix typo in `ftp_base::restore()`. 2024-02-12 12:07:10 +00:00
class-language-pack-upgrader-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-language-pack-upgrader.php I18N: Actually add all the files for [58061], not just the test fixtures. 2024-04-30 08:39:07 +00:00
class-pclzip.php Docs: Fix a few typos in `wp-admin/includes/class-pclzip.php`. 2024-03-31 05:52:15 +00:00
class-plugin-installer-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-plugin-upgrader-skin.php Docs: Use third-person singular verbs in various function descriptions, as per docblocks standards. 2023-06-14 06:34:27 +00:00
class-plugin-upgrader.php Plugin Dependencies: Remove auto-deactivation and bootstrapping logic. 2024-02-20 07:27:06 +00:00
class-theme-installer-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-theme-upgrader-skin.php Upgrade/Install: Improve localized strings related to plugin/theme installation and activation. 2024-02-26 20:35:08 +00:00
class-theme-upgrader.php Upgrade/Install: Check theme compatibility during bulk upgrades. 2024-01-08 23:19:16 +00:00
class-walker-category-checklist.php Bulk/Quick Edit: Remove duplicate HTML IDs from post list tables. 2024-08-13 23:37:16 +00:00
class-walker-nav-menu-checklist.php Coding Standards: Remove superfluous blank lines at the end of various classes. 2023-09-08 09:32:23 +00:00
class-walker-nav-menu-edit.php Coding Standards: Restore more descriptive variable names in a few class methods. 2023-09-14 12:46:20 +00:00
class-wp-ajax-upgrader-skin.php Code Modernization: Replace usage of `strpos()` with `str_contains()`. 2023-06-22 14:36:26 +00:00
class-wp-application-passwords-list-table.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-automatic-updater.php Upgrade/Install: Disable maintenance mode when core auto-update fails. 2024-06-18 14:41:05 +00:00
class-wp-comments-list-table.php Coding Standards: Bring some consistency to setting up comment moderation links. 2024-08-12 21:28:13 +00:00
class-wp-community-events.php Coding Standards: Include one space after `function` keyword for closures. 2023-09-12 15:23:18 +00:00
class-wp-debug-data.php WP_Debug_Data: Extract `wp-database` data into separate method. 2024-09-02 20:44:16 +00:00
class-wp-filesystem-base.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-filesystem-direct.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-filesystem-ftpext.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-filesystem-ftpsockets.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-filesystem-ssh2.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
class-wp-importer.php Coding Standards: Use strict comparison in `wp-admin/includes/class-wp-importer.php`. 2023-08-14 09:59:20 +00:00
class-wp-internal-pointers.php Docs: Use third-person singular verbs in various function descriptions, as per docblocks standards. 2023-06-14 12:57:20 +00:00
class-wp-links-list-table.php Docs: Add missing description for the `display_rows()` method in list table classes. 2024-07-17 15:43:15 +00:00
class-wp-list-table-compat.php Docs: Add missing descriptions for `_WP_List_Table_Compat` methods. 2020-11-14 16:54:08 +00:00
class-wp-list-table.php Docs: Add missing description for the `display_rows()` method in list table classes. 2024-07-17 15:43:15 +00:00
class-wp-media-list-table.php Docs: Add missing description for the `display_rows()` method in list table classes. 2024-07-17 15:43:15 +00:00
class-wp-ms-sites-list-table.php Docs: Add missing description for the `display_rows()` method in list table classes. 2024-07-17 15:43:15 +00:00
class-wp-ms-themes-list-table.php Docs: Add missing description for the `display_rows()` method in list table classes. 2024-07-17 15:43:15 +00:00
class-wp-ms-users-list-table.php Docs: Add missing description for the `display_rows()` method in list table classes. 2024-07-17 15:43:15 +00:00
class-wp-plugin-install-list-table.php Docs: Add missing description for the `display_rows()` method in list table classes. 2024-07-17 15:43:15 +00:00
class-wp-plugins-list-table.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
class-wp-post-comments-list-table.php Administration: Remove private delegation from list tables. 2022-10-04 03:47:15 +00:00
class-wp-posts-list-table.php Bulk/Quick Edit: Remove duplicate HTML IDs from post list tables. 2024-08-13 23:37:16 +00:00
class-wp-privacy-data-export-requests-list-table.php Privacy: Fix "Retry" action after a personal data export failure. 2022-03-10 19:22:01 +00:00
class-wp-privacy-data-removal-requests-list-table.php Coding Standards: Remove superfluous blank lines at the end of various classes. 2023-09-08 09:32:23 +00:00
class-wp-privacy-policy-content.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
class-wp-privacy-requests-table.php Administration: Switch order of label/checkbox in `WP_List_Table`. 2023-09-22 19:58:16 +00:00
class-wp-screen.php Docs: Add missing description for a few globals in the admin. 2024-06-15 12:34:13 +00:00
class-wp-site-health-auto-updates.php Site Health: Check if the directories are allowed when testing for a VCS checkout. 2024-08-21 22:23:16 +00:00
class-wp-site-health.php Site Health: Correct the check for disk space available to safely perform updates. 2024-08-19 15:21:14 +00:00
class-wp-site-icon.php Media: Accessibility: Copy attachment properties on site icon crop. 2024-03-02 20:15:13 +00:00
class-wp-terms-list-table.php Docs: Add missing description for a few globals in the admin. 2024-06-15 12:34:13 +00:00
class-wp-theme-install-list-table.php Docs: Add missing description for the `display_rows()` method in list table classes. 2024-07-17 15:43:15 +00:00
class-wp-themes-list-table.php Docs: Add missing description for the `display_rows()` method in list table classes. 2024-07-17 15:43:15 +00:00
class-wp-upgrader-skin.php Docs: Add missing documentation for various upgrade/install class methods. 2024-05-02 17:20:10 +00:00
class-wp-upgrader-skins.php Docs: Add missing `@deprecated` tags in the file docblock of some deprecated files. 2019-10-08 17:19:04 +00:00
class-wp-upgrader.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
class-wp-users-list-table.php Docs: Correct some typos in docblocks and inline comments. 2024-01-10 11:57:15 +00:00
comment.php Docs: Use third-person singular verbs for function descriptions in `wp-admin/includes/comment.php`, as per docblocks standards. 2022-07-20 22:15:10 +00:00
continents-cities.php I18N: Update list of continents and cities for the timezone selection. 2022-09-19 23:24:11 +00:00
credits.php General: Introduce `wp_get_wp_version()` to get unmodified version. 2024-07-27 00:27:16 +00:00
dashboard.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
deprecated.php Docs: Correct some typos in docblocks and inline comments. 2024-01-10 11:57:15 +00:00
edit-tag-messages.php Docs: Various inline documentation corrections and improvements. 2021-12-07 12:20:02 +00:00
export.php Code Modernization: Fix implicit nullable parameter type deprecation on PHP 8.4. 2024-04-15 20:03:09 +00:00
file.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
image-edit.php Media: Fix viewport scrolling and code style in image rotation. 2024-08-28 16:45:11 +00:00
image.php Media: Automatically convert HEIC images to JPEG 2024-08-05 04:13:15 +00:00
import.php General: Introduce `wp_get_wp_version()` to get unmodified version. 2024-07-27 00:27:16 +00:00
list-table.php Administration: Remove private delegation from list tables. 2022-10-04 03:47:15 +00:00
media.php Docs: Correct DocBlock formatting for `activate_tinymce_for_media_description`. 2024-06-09 22:53:14 +00:00
menu.php Docs: Replace incorrect `@private` tags. 2023-11-06 09:27:23 +00:00
meta-boxes.php I18N: Correctly output the `None` translatable strings. 2024-07-21 18:58:16 +00:00
misc.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
ms-admin-filters.php Networks and Sites: Officially remove global terms. 2022-09-20 02:51:09 +00:00
ms-deprecated.php Networks and Sites: Officially remove global terms. 2022-09-20 02:51:09 +00:00
ms.php Docs: Update a HelpHub link on Edit Site screen to avoid unnecessary redirection. 2024-05-11 14:47:06 +00:00
nav-menu.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
network.php Bootstrap/Load: Take the port number into consideration when determining whether a subdomain installation of Multisite is allowed. 2024-05-09 23:09:13 +00:00
noop.php Themes: Fix fatal error in `load-styles.php`. 2023-09-21 01:27:26 +00:00
options.php Site icon: Polish up Site Icon on the general settings screen. 2024-02-26 20:18:09 +00:00
plugin-install.php Docs: Remove unsupported values in `plugins_api()` DocBlocks. 2024-08-09 00:18:16 +00:00
plugin.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
post.php Docs: Correct comment formatting in `wp_autosave_post_revisioned_meta_fields()`. 2024-08-31 14:46:17 +00:00
privacy-tools.php Code Modernization: Replace usage of `strpos()` with `str_contains()`. 2023-06-22 14:36:26 +00:00
revision.php Docs: Various improvements and corrections to inline documentation. 2024-02-16 21:47:12 +00:00
schema.php Upgrade/Install: Use an empty string for the default “Post via email” password. 2024-08-23 23:17:13 +00:00
screen.php Docs: Add missing description for a few globals in the admin. 2024-06-15 12:34:13 +00:00
taxonomy.php Coding Standards: Use strict comparison in `wp-admin/includes/taxonomy.php`. 2023-03-10 07:04:20 +00:00
template.php Docs: Add missing description for a few globals in the admin. 2024-06-15 12:34:13 +00:00
theme-install.php Upgrade/Install: Improve localized strings related to plugin/theme installation and activation. 2024-02-26 20:35:08 +00:00
theme.php General: Introduce `wp_get_wp_version()` to get unmodified version. 2024-07-27 00:27:16 +00:00
translation-install.php General: Introduce `wp_get_wp_version()` to get unmodified version. 2024-07-27 00:27:16 +00:00
update-core.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
update.php General: Introduce `wp_get_wp_version()` to get unmodified version. 2024-07-27 00:27:16 +00:00
upgrade.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
user.php Docs: Improve some DocBlocks and inline comments per the documentation standards. 2023-11-17 13:29:26 +00:00
widgets.php Coding Standards: Use pre-increment/decrement for stand-alone statements. 2023-09-09 09:28:26 +00:00