WordPress/wp-includes
Boone Gorges 31ef230595 Ensure that non-default pagination values work in `wp_list_comments()`.
Prior to 4.4, it was possible to pass 'page' and 'per_page' values to
`wp_list_comments()` that do not match the corresponding global query vars.
This ability was lost in 4.4 with the refactor of how `comments_template()`
queries for comments; when the main comment query started fetching only the
comments that ought to appear on a page, instead of all of a post's comments,
it became impossible for the comment walker to select comments corresponding to
custom pagination parameters. See #8071.

We restore the previous behavior by (a) detecting when a 'page' or 'per_page'
parameter has been passed to `wp_list_comments()` that does not match the
corresponding query vars (so that the desired comments will not be found in
`$wp_query`), and if so, then (b) querying for all of the post's comments and
passing them to the comment walker for pagination, as was the case before 4.4.

Props boonebgorges, smerriman.
Fixes #35175.
Built from https://develop.svn.wordpress.org/trunk@36157


git-svn-id: http://core.svn.wordpress.org/trunk@36123 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2016-01-03 02:03:28 +00:00
..
ID3
SimplePie Feeds: add `CEST` to `$timezone` in `SimplePie_Parse_Date`. 2015-10-20 05:57:24 +00:00
Text Fix the `@author` doc param encoding in `Text/Diff/Engine/string` so the file is recognized as UTF-8, not ISO-8859-1. 2015-10-24 22:45:25 +00:00
certificates HTTP: Partially revert [34283] which removed the 1024bit certificates from our trust store. 2015-12-14 05:20:28 +00:00
css Media: Fix icons for HiDPI displays on the media modal after [32952]. 2015-12-30 18:32:29 +00:00
customize Customize: Ensure that "Change" button appears when there are only 2 themes. 2015-12-15 01:21:26 +00:00
fonts
images Embeds: Revert [35083], as the PNG files ended up not being used in [35466]. 2015-10-31 04:42:25 +00:00
js Admin: fix repositioning of notices when the first header is not an immediate children of `.wrap`. 2015-12-31 11:05:31 +00:00
pomo Merge the changes to GlotPress's POMO from upstream to WordPress's copy. 2015-11-20 04:34:25 +00:00
random_compat Update random_compat to latest master (~1.1.5) 2015-12-14 07:46:28 +00:00
rest-api REST API: Improve formatting of failed validation errors. 2015-12-12 18:23:28 +00:00
theme-compat Comments: The year is 2003. Permalinks are a new thing and everyone's using Blogger. It's a time when opening a modal window in JavaScript to view a section of a website is not a completely weird thing, although many users get annoyed by it. b2 has recently become WordPress, and with it comes a bunch of functionality that will become stale over the next decade, remnants of simpler times. 2015-12-10 03:06:30 +00:00
widgets Widgets: Remove extra quotes from widget title in `WP_Widget_RSS`, accidentally added in [33814]. 2015-12-16 22:35:27 +00:00
admin-bar.php Toolbar: In Comments link, replace title attribute containing the number of pending comments with a screen reader text. 2015-12-26 01:40:27 +00:00
atomlib.php
author-template.php Docs: Add missing parameter notations to the DocBlock for `get_author_posts_url()`. 2015-12-17 17:30:43 +00:00
bookmark-template.php
bookmark.php Docs: Add a missing notation for the `$bookmark_id` parameter in the DocBlock for `clean_bookmark_cache()`. 2015-12-18 23:01:28 +00:00
cache.php Docs: Miscellaneous docblock corrections. 2015-12-23 06:31:27 +00:00
canonical.php Docs: Add a missing summary, description, and `@since` version to the DocBlock for `wp_redirect_admin_locations()`. 2015-12-18 23:08:26 +00:00
capabilities.php When a post is scheduled for publication, treat it the same as a published post when calculating the capabilities required to edit or delete it. 2015-11-29 02:27:18 +00:00
category-template.php Docs: Improve readability of the default arguments of `wp_list_categories()`. 2015-12-31 11:30:27 +00:00
category.php Simplify the include graph after work to split out classes. 2015-11-20 07:24:30 +00:00
class-IXR.php XMLRPC: Revert [35509] which caused a change of behviour in at least one XMLRPC client. 2015-12-31 04:06:26 +00:00
class-feed.php
class-http.php Docs: Miscellaneous docblock code quality tweaks. 2015-12-23 07:53:26 +00:00
class-json.php The the Docs: Fix the the dittography 2015-12-06 21:23:25 +00:00
class-oembed.php Remove RDIO from oEmbed providers 2015-12-18 18:16:27 +00:00
class-phpass.php
class-phpmailer.php Upgrade PHPMailer from 5.2.10 to 5.2.14. 2015-12-24 01:59:26 +00:00
class-pop3.php
class-simplepie.php
class-smtp.php Upgrade PHPMailer from 5.2.10 to 5.2.14. 2015-12-24 01:59:26 +00:00
class-snoopy.php
class-walker-category-dropdown.php Docs: Document the `$id` parameter for `Walker_CategoryDropdown::start_el()`, which is implemented by `Walker` but unused in the subclass method. 2015-12-14 17:47:30 +00:00
class-walker-category.php Add `current-cat-ancestor` class to ancestor items in `wp_list_categories()`. 2015-12-18 18:38:25 +00:00
class-walker-comment.php Docs: Document the `$id` parameter for `Walker_Comment::start_el()`, which is implemented by `Walker` but unused in the subclass method. 2015-12-14 17:50:26 +00:00
class-walker-page-dropdown.php Docs: Add missing property and method summaries in DocBlocks for `Walker_PageDropdown`. 2015-12-16 16:36:28 +00:00
class-walker-page.php Docs: Miscellaneous docblock corrections. 2015-12-23 06:31:27 +00:00
class-wp-admin-bar.php Toolbar: Allow adding `lang` and `dir` attributes to toolbar items. 2015-12-06 21:37:25 +00:00
class-wp-ajax-response.php
class-wp-comment-query.php Ensure that order is specified when querying for comment descendants. 2015-12-03 15:50:27 +00:00
class-wp-comment.php
class-wp-customize-control.php Docs: Hash notate properties and defaults for the benefit of `$args` parameter documentation for `WP_Customize_Control::__construct()`. 2015-12-28 20:10:35 +00:00
class-wp-customize-manager.php I18N: Remove `<strong>` tags from translatable strings in `WP_Customize_Manager::register_controls()` and `WP_Customize_Header_Image_Control::render_content()`. 2015-12-14 12:54:27 +00:00
class-wp-customize-nav-menus.php Customizer: Use correct context and translator comments for menu location strings. 2015-11-20 17:46:25 +00:00
class-wp-customize-panel.php Customize: move `WP_Customize_Panel` subclass to `wp-includes/customize`, it loads in the exact same place. 2015-10-24 18:25:24 +00:00
class-wp-customize-section.php Customize: move `WP_Customize_Section` subclasses to `wp-includes/customize`, they load in the exact same place. 2015-10-24 18:21:25 +00:00
class-wp-customize-setting.php Customize: Ensure that a setting (especially a multidimensional one) can still be previewed when the post value to preview is set after `preview()` is invoked. 2015-11-21 02:52:27 +00:00
class-wp-customize-widgets.php The the Docs: Fix the the dittography 2015-12-06 21:23:25 +00:00
class-wp-editor.php Editor: remove the format_for_editor filter from `the_editor_content` after it runs as the next editor instance on the same page may not need it. 2015-12-22 22:39:31 +00:00
class-wp-embed.php Embeds: Remove the `allow_insecure_embeds` filter. 2015-11-19 05:02:27 +00:00
class-wp-error.php
class-wp-http-cookie.php
class-wp-http-curl.php Docs: Miscellaneous docblock corrections. 2015-12-23 06:31:27 +00:00
class-wp-http-encoding.php
class-wp-http-ixr-client.php
class-wp-http-proxy.php
class-wp-http-response.php
class-wp-http-streams.php Docs: Add missing parameter documentation for the `$args` parameter in the DocBlock for `WP_Http_Streams::test()`. 2015-12-14 23:54:26 +00:00
class-wp-image-editor-gd.php Media: add a new image size, `medium_large`. Bumps db version to add new options. 2015-10-31 20:50:25 +00:00
class-wp-image-editor-imagick.php Media: add a new image size, `medium_large`. Bumps db version to add new options. 2015-10-31 20:50:25 +00:00
class-wp-image-editor.php
class-wp-meta-query.php Docs: Add missing descriptions for the `$wpdb` global in DocBlocks all the places. 2015-10-14 23:44:25 +00:00
class-wp-network.php Multisite: Clarify documentation for `WP_Network::get_by_path()`. 2015-11-08 02:25:25 +00:00
class-wp-oembed-controller.php oEmbed: Drop the trailing slash from the namespace. 2015-11-17 11:27:29 +00:00
class-wp-post.php Docs: Add missing descriptions for the `$wpdb` global in DocBlocks all the places. 2015-10-14 23:44:25 +00:00
class-wp-rewrite.php Docs: Add missing parameter and return descriptions to the DocBlock for `WP_Rewrite::iis7_url_rewrite_rules()`. 2015-12-14 23:58:27 +00:00
class-wp-role.php Docs: Clarify documentation for `WP_Role::has_cap()` to more clearing indicate that the method checks for capabilities against the role rather than the user. 2015-12-14 20:05:27 +00:00
class-wp-roles.php Docs: Add missing descriptions for the `$wpdb` global in DocBlocks all the places. 2015-10-14 23:44:25 +00:00
class-wp-tax-query.php Correct some `@param` doc names in the `WP_Tax_Query` and `WP_User_Query` classes. 2015-12-14 02:50:27 +00:00
class-wp-term.php Make `get_term()` behave more consistently in the context of shared terms. 2015-11-05 16:45:25 +00:00
class-wp-theme.php Upgrade: New themes are not automatically installed on upgrade. This can still be explicitly asked for by defining `CORE_UPGRADE_SKIP_NEW_BUNDLED` as `false`. 2015-11-25 21:45:25 +00:00
class-wp-user-query.php Correct some `@param` doc names in the `WP_Tax_Query` and `WP_User_Query` classes. 2015-12-14 02:50:27 +00:00
class-wp-user.php Docs: Add variadic markers to the optional `$object_id` parameter notation for `WP_User::has_cap()`. 2015-12-16 05:32:28 +00:00
class-wp-walker.php Avoid a PHP notice when trying to access the `post_parent` property of hierarchical post type nav menu items. 2015-12-12 01:06:29 +00:00
class-wp-widget-factory.php
class-wp-widget.php Docs: Add missing summaries and `@since` versions to DocBlocks for the `_get_display_callback()`, `_get_update_callback()`, and `_get_form_callback()` methods in `WP_Widget`. 2015-12-16 05:39:25 +00:00
class-wp-xmlrpc-server.php Docs: Add a missing summary, `@since` version, and parameter descriptions to the DocBlock for `wp_xmlrpc_server::pingback_error()`. 2015-12-16 17:38:27 +00:00
class-wp.php Query: Remove `title` from the public query vars list. 2015-12-21 00:43:27 +00:00
class.wp-dependencies.php
class.wp-scripts.php Docs: Add missing DocBlocks, including summaries and `@since` versions, to the `__construct()` and `init()` methods in `WP_Scripts`. 2015-12-16 17:48:27 +00:00
class.wp-styles.php
comment-template.php Ensure that non-default pagination values work in `wp_list_comments()`. 2016-01-03 02:03:28 +00:00
comment.php Docs: Add null to `post_id` param type, fix syntax, and descriptions in the DocBlock for `wp_update_comment_count()`. 2015-12-31 19:21:28 +00:00
compat.php Docs: Add missing DocBlocks for `hash_hmac()` and `_hash_hmac()`. 2015-12-19 05:11:27 +00:00
cron.php Docs: Add a missing notation for the `$gmt_time` parameter in the DocBlock for `spawn_cron()`. 2015-12-19 08:20:27 +00:00
date.php Docs: Remove some more dittography. 2015-12-06 21:50:25 +00:00
default-constants.php Revert [35804]. This change has unintended side effects, notably that media URLs in the admin area now unexpectedly use the `https` scheme. A more comprehensive approach will be taken in 4.5. 2015-12-22 13:02:29 +00:00
default-filters.php Users: Allow to create users without sending an email to the new user. 2015-11-25 22:38:29 +00:00
default-widgets.php
deprecated.php Docs: Correct a funky docblock in `funky_javascript_fix()`. 2015-12-28 17:18:30 +00:00
embed-template.php Embeds: Change attachment metadata condition to prevent a warning in the embeds template. 2015-12-30 22:25:28 +00:00
embed.php Embeds: Don't show embed discovery link on a static front page. 2015-12-22 10:50:31 +00:00
feed-atom-comments.php Themes: Improve document title output. 2015-10-20 16:21:25 +00:00
feed-atom.php Feeds: `<comments>` is optional in RSS2, so don't include it when comments aren't present or open. Same for `<wfw:commentRss>` and `<slash:comments>` 2015-11-04 17:47:25 +00:00
feed-rdf.php Themes: Improve document title output. 2015-10-20 16:21:25 +00:00
feed-rss.php Themes: Improve document title output. 2015-10-20 16:21:25 +00:00
feed-rss2-comments.php Themes: Improve document title output. 2015-10-20 16:21:25 +00:00
feed-rss2.php Feeds: `<comments>` is optional in RSS2, so don't include it when comments aren't present or open. Same for `<wfw:commentRss>` and `<slash:comments>` 2015-11-04 17:47:25 +00:00
feed.php Use correct placeholders for translator comments added in [35303]. 2015-10-24 18:50:24 +00:00
formatting.php Comments: Don't nofollow links within the site. 2015-12-30 23:20:25 +00:00
functions.php Docs: Clarify that `wp_filter_object_list()` accepts `'not'` as its `$operator` parameter. 2015-12-26 00:37:26 +00:00
functions.wp-scripts.php Docs: Miscellaneous docblock code quality tweaks. 2015-12-23 07:53:26 +00:00
functions.wp-styles.php Docs: Miscellaneous docblock code quality tweaks. 2015-12-23 07:53:26 +00:00
general-template.php Docs: Improve documentation for `wp_admin_css_color()`. 2015-12-27 16:32:29 +00:00
http.php Docs: Fix copy/paste error in `wp_remote_retrieve_cookies()` description. 2015-12-18 17:23:29 +00:00
kses.php KSES: Allow the `reversed` attribute for `<ol>`. 2015-12-16 09:54:26 +00:00
l10n.php Docs: Add a missing notation for the `$context` parameter in the DocBlock for `_nx_noop()`. 2015-12-18 23:16:26 +00:00
link-template.php Canonical: Output correct canonical links for paged posts when not using pretty permalinks. 2015-12-26 04:28:26 +00:00
load.php Docs: Correct `wp_debug_mode()` description to clarify that `WP_DEBUG_DISPLAY` is true by default. 2015-12-12 01:49:26 +00:00
locale.php Docs: Add a missing summary to the DocBlock for `WP_Locale::rtl_src_admin_notice()`. 2015-12-16 18:08:26 +00:00
media-template.php Accessibility: add missing `alt` attributes to a gaggle of `<img>`s. 2015-11-07 16:12:27 +00:00
media.php Responsive images: fix the check whether the attachment meta matches the image src to work with http/https and CDNs. 2015-12-30 01:04:27 +00:00
meta.php After [35718], update the location of some files in `This filter is documented in` docs. 2015-11-22 03:51:28 +00:00
ms-blogs.php Ensure that the scheme used in the URL returned by `get_blogaddress_by_id()` always reflects the blog's URL, instead of using `http`. 2015-10-30 02:02:24 +00:00
ms-default-constants.php Docs: Add missing descriptions for the `$wpdb` global in DocBlocks all the places. 2015-10-14 23:44:25 +00:00
ms-default-filters.php
ms-deprecated.php Docs: Add missing descriptions for the `$wpdb` global in DocBlocks all the places. 2015-10-14 23:44:25 +00:00
ms-files.php
ms-functions.php Docs: Miscellaneous docblock corrections. 2015-12-23 06:31:27 +00:00
ms-load.php I18N: Move translatable Codex URLs to separate strings in `wp-includes/ms-load.php`. 2015-11-18 17:42:26 +00:00
ms-settings.php MS: Populate `public` on empty `$current_blog` during subdomain activation. 2015-12-06 18:24:26 +00:00
nav-menu-template.php Menus: Bring back line break between menu items. 2015-12-24 00:21:27 +00:00
nav-menu.php Nav Menus: Avoid a PHP Notice when a menu contains a now unregistered post type archive. 2015-12-26 04:05:25 +00:00
option.php Rename internal variable in `set_transient()`. 2015-10-29 11:52:28 +00:00
pluggable-deprecated.php
pluggable.php Docs: Fix typo in a comment in `wp_rand()`. 2015-12-26 11:07:28 +00:00
plugin.php Docs: `@see != @since`. 2015-12-23 07:13:26 +00:00
post-formats.php
post-template.php Themes: Add `singular` to the list of body classes when viewing a single post object. 2015-12-28 17:21:29 +00:00
post-thumbnail-template.php Docs: Adjust documentation for the `$size` parameter in `the_post_thumbnail_url()` to clarify the required order of width and height values when passing an array. 2015-10-12 17:00:26 +00:00
post.php Docs: Correct `get_page_uri()` description. 2016-01-01 18:29:27 +00:00
query.php Feeds: Comments on attachments display in the site-wide comments RSS feed. 2015-12-31 17:16:27 +00:00
registration-functions.php
registration.php
rest-api.php Docs: Correct `@return` type for `rest_parse_date()`. 2015-12-25 20:41:26 +00:00
revision.php Docs: Add a missing notation for the `$args` parameter in the DocBlock for `wp_get_post_revisions()`. 2015-12-16 23:18:26 +00:00
rewrite.php Simplify the include graph after work to split out classes. 2015-11-20 07:24:30 +00:00
rss-functions.php
rss.php
script-loader.php Bump the version of MediaElement in script-loader.php to match what we're shipping with. 2015-11-20 03:32:26 +00:00
session.php
shortcodes.php Shortcodes: `=` is a reserved character in shortcode names, mark it as such. 2015-12-26 04:46:28 +00:00
taxonomy.php Force non-public taxonomies to have a query_var of `false`. 2015-12-27 16:41:27 +00:00
template-loader.php Comments: The year is 2003. Permalinks are a new thing and everyone's using Blogger. It's a time when opening a modal window in JavaScript to view a section of a website is not a completely weird thing, although many users get annoyed by it. b2 has recently become WordPress, and with it comes a bunch of functionality that will become stale over the next decade, remnants of simpler times. 2015-12-10 03:06:30 +00:00
template.php Comments: The year is 2003. Permalinks are a new thing and everyone's using Blogger. It's a time when opening a modal window in JavaScript to view a section of a website is not a completely weird thing, although many users get annoyed by it. b2 has recently become WordPress, and with it comes a bunch of functionality that will become stale over the next decade, remnants of simpler times. 2015-12-10 03:06:30 +00:00
theme.php Docs: Document the default value for the `$validate` parameter in the `validate_current_theme` hook docs. 2015-12-16 20:10:25 +00:00
update.php Docs: Miscellaneous docblock code quality tweaks. 2015-12-23 07:53:26 +00:00
user.php Docs: Correct `@return` type for `count_user_posts()`. 2015-12-25 20:18:27 +00:00
vars.php
version.php Ensure that non-default pagination values work in `wp_list_comments()`. 2016-01-03 02:03:28 +00:00
widgets.php Widgets: Revert [34465], as it introduced a regression, making the `$index` argument of `dynamic_sidebar()` case-sensitive. 2015-12-31 03:13:26 +00:00
wlwmanifest.xml
wp-db.php Don't suppress error messages in database function calls. 2015-12-11 03:40:26 +00:00
wp-diff.php