WordPress/wp-includes
Gary Pendergast 3f847f8b6c Media: `media_handle_sideload()` expectes `wp_insert_attachment()` to return a `WP_Error`.
For `wp_insert_attachment()` to do that, we need to be setting the `$wp_error` parameter to true.

Props subrataemfluence, jirihon.
Fixes #44303.


Built from https://develop.svn.wordpress.org/trunk@44634


git-svn-id: http://core.svn.wordpress.org/trunk@44465 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2019-01-17 06:27:50 +00:00
..
ID3
IXR
Requests
SimplePie
Text
blocks Block Editor: Upgrade `@wordpress` packages to match version 4.7.1. 2018-12-19 03:16:48 +00:00
certificates
css Accessibility: Add focus styles for Windows High Contrast mode. 2019-01-10 16:47:50 +00:00
customize Docs: Add docblocks for `WP_Customize_Header_Image_Control` member variables. 2019-01-15 05:54:48 +00:00
fonts
images Build: Update images following [43684]. 2018-12-19 03:36:27 +00:00
js Customizer: Use the `sandbox` attribute to prevent top navigation from the preview. 2019-01-14 07:25:50 +00:00
pomo Docs: Correct the docs for `POMO_Reader::setEndian()`. 2019-01-16 05:36:48 +00:00
random_compat
rest-api General: Fix problematic string to array parsing. 2019-01-10 21:06:49 +00:00
theme-compat Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
widgets Widgets: Remove unnecessary `sanitize_text_field()` calls in core widget `::form()` methods. 2019-01-15 00:43:49 +00:00
admin-bar.php Admin Bar: Set the Admin Bar to not be showing on REST API requests. 2019-01-16 02:54:50 +00:00
atomlib.php
author-template.php Templates: Fix the return value of `get_the_author_posts_link()`. 2019-01-16 05:54:49 +00:00
blocks.php Blocks: Add a `$source_block` parameter to the `render_block_data` filter. 2019-01-14 01:47:51 +00:00
bookmark-template.php Docs: Remove duplicate docblocks for the `pre_user_login` and `link_category` filters. 2019-01-16 05:29:49 +00:00
bookmark.php General: Fix problematic string to array parsing. 2019-01-10 21:06:49 +00:00
cache.php Docs: Fix the `WP_Object_Cache::get()` docblock. 2019-01-15 06:18:51 +00:00
canonical.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
capabilities.php Bootstrap/Load: Introduce fatal error recovery mechanism allowing users to still log in to their admin dashboard. 2019-01-09 20:05:49 +00:00
category-template.php Coding Standards: Remove an unnecessary line whitelisting. 2019-01-12 04:53:51 +00:00
category.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
class-IXR.php
class-feed.php
class-http.php Docs: Update `since` annotation for new `$url` parameter for several HTTP related filters. 2019-01-04 21:58:51 +00:00
class-json.php Docs: Fix typo in `Services_JSON` DocBlocks. 2018-06-28 02:20:54 +00:00
class-oembed.php Embeds: Remove Photobucket, FunnyOrDie from the list of oEmbed providers. 2019-01-10 22:42:51 +00:00
class-phpass.php
class-phpmailer.php
class-pop3.php
class-requests.php
class-simplepie.php
class-smtp.php
class-snoopy.php
class-walker-category-dropdown.php
class-walker-category.php Taxonomy: Escape CSS classes in `Walker_Category::start_el()` after the `category_css_class` filter runs. 2019-01-07 12:54:48 +00:00
class-walker-comment.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
class-walker-nav-menu.php Docs: Correct and improve various inline documentation. 2018-03-25 19:35:29 +00:00
class-walker-page-dropdown.php Docs: Correctly specify the `$page` parameter of `list_pages` filter as a `WP_Post`. 2018-12-20 20:04:50 +00:00
class-walker-page.php Accessibility: Themes: use `aria-current` for the `Walker_Page` current link. 2019-01-07 13:36:50 +00:00
class-wp-admin-bar.php
class-wp-ajax-response.php
class-wp-block-parser.php Script Loader: Load unminified package vendor scripts when `SCRIPT_DEBUG` is set. 2019-01-04 20:27:49 +00:00
class-wp-block-type-registry.php Blocks: Introduce `WP_Block_Type` and `WP_Block_Type_Registry` classes. 2018-12-13 09:44:23 +00:00
class-wp-block-type.php REST API: Preserve unknown, respect `null` in server-side block rendering. 2018-12-17 18:00:52 +00:00
class-wp-comment-query.php Coding Standards: Fix and whitelist variable names. 2019-01-12 06:06:48 +00:00
class-wp-comment.php
class-wp-customize-control.php
class-wp-customize-manager.php Customizer: Improve browser compatibility of the preview iframe. 2019-01-14 06:38:51 +00:00
class-wp-customize-nav-menus.php Customizer: Remove a line of commented-out code in `WP_Customize_Nav_Menus::customize_register()`. 2018-12-19 07:23:47 +00:00
class-wp-customize-panel.php
class-wp-customize-section.php
class-wp-customize-setting.php
class-wp-customize-widgets.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
class-wp-dependency.php Docs: Add missing documentation for `_WP_Dependency::set_translations()`. 2019-01-15 22:48:51 +00:00
class-wp-editor.php Editor: Fix name of the new editor for inline comment. 2019-01-05 03:48:50 +00:00
class-wp-embed.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
class-wp-error.php Docs: Update `since` annotations `WP_Error::has_errors()` 2019-01-09 22:42:51 +00:00
class-wp-feed-cache-transient.php
class-wp-feed-cache.php
class-wp-hook.php
class-wp-http-cookie.php
class-wp-http-curl.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
class-wp-http-encoding.php
class-wp-http-ixr-client.php
class-wp-http-proxy.php
class-wp-http-requests-hooks.php
class-wp-http-requests-response.php
class-wp-http-response.php
class-wp-http-streams.php Docs: Update `since` annotation for new `$url` parameter for several HTTP related filters. 2019-01-04 21:58:51 +00:00
class-wp-image-editor-gd.php Docs: Add missing periods to `param` annotations for `flip()` in `WP_Image_Editor_GD`. 2019-01-10 22:10:50 +00:00
class-wp-image-editor-imagick.php
class-wp-image-editor.php
class-wp-list-util.php
class-wp-locale-switcher.php REST API: Render response in user locale with `?_locale=user`. 2018-12-14 01:32:39 +00:00
class-wp-locale.php Coding Standards: Fix the `Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace` violations. 2019-01-11 06:40:50 +00:00
class-wp-matchesmapregex.php
class-wp-meta-query.php Docs: Update `since` annotations for adding `LIKE` comparisons with meta keys. 2019-01-09 14:55:49 +00:00
class-wp-metadata-lazyloader.php Docs: Correct and improve various inline documentation. 2018-03-25 19:35:29 +00:00
class-wp-network-query.php PHP7.3 compatibility: Fix compact throwing notices. 2018-12-14 05:13:52 +00:00
class-wp-network.php
class-wp-oembed-controller.php Embeds: Filter HTML response in oEmbed proxy controller. 2018-12-14 03:20:37 +00:00
class-wp-paused-extensions-storage.php Bootstrap/Load: Introduce fatal error recovery mechanism allowing users to still log in to their admin dashboard. 2019-01-09 20:05:49 +00:00
class-wp-post-type.php
class-wp-post.php Docs: Update and correct various inline documentation. 2018-05-07 17:20:22 +00:00
class-wp-query.php Docs: Update `since` annotations for adding `LIKE` comparisons with meta keys. 2019-01-09 14:55:49 +00:00
class-wp-rewrite.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
class-wp-role.php
class-wp-roles.php
class-wp-session-tokens.php Docs: Correct and improve docblocks for user session management functionality. 2018-09-14 13:45:26 +00:00
class-wp-shutdown-handler.php Bootstrap/Load: Fix workaround to display admin link in PHP error template by introducing `$link_url` and `$link_text` arguments to `wp_die()`. 2019-01-16 15:21:50 +00:00
class-wp-simplepie-file.php
class-wp-simplepie-sanitize-kses.php
class-wp-site-query.php Multisite: Update `@since` tags for site meta introduction. 2019-01-08 08:18:50 +00:00
class-wp-site.php
class-wp-tax-query.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
class-wp-taxonomy.php Taxonomy: Update `@since` annotations for `meta_box_sanitize_cb` arg. 2019-01-09 15:11:48 +00:00
class-wp-term-query.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
class-wp-term.php
class-wp-text-diff-renderer-inline.php
class-wp-text-diff-renderer-table.php Coding Standards: Fix the `Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace` violations. 2019-01-11 06:40:50 +00:00
class-wp-theme.php Coding Standards: Fix the minor `WordPress.WP.I18n` violations. 2019-01-11 06:04:49 +00:00
class-wp-user-meta-session-tokens.php Docs: Add `@see WP_Session_Tokens` to the `WP_User_Meta_Session_Tokens` docblock. 2019-01-09 05:04:50 +00:00
class-wp-user-query.php Docs: Correct `@since` tag for `users_pre_query` filter added in [44373]. 2019-01-07 07:56:50 +00:00
class-wp-user.php Users: Add `LIMIT 1` to SQL query in `WP_User::get_data_by()`, as only one row is requested. 2018-09-23 15:33:24 +00:00
class-wp-walker.php
class-wp-widget-factory.php
class-wp-widget.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
class-wp-xmlrpc-server.php Coding Standards: Fix the `Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace` violations. 2019-01-11 06:40:50 +00:00
class-wp.php Multisite: Validate activation links. 2018-12-13 01:26:24 +00:00
class.wp-dependencies.php Docs: Document that the `$src` parameter of `WP_Dependencies::add()` can be boolean. 2018-09-28 21:51:24 +00:00
class.wp-scripts.php I18N/Script Loader: Support text domains other than "messages". 2019-01-06 16:23:49 +00:00
class.wp-styles.php Script/Style Dependencies: Simplify some logic in `WP_Styles::do_item()`. 2018-08-11 17:42:24 +00:00
comment-template.php Docs: Fix the `@param` types for `comments_popup_link(). 2019-01-08 04:50:51 +00:00
comment.php Update `since` annotation on `allow_empty_comment` hook. 2018-12-28 13:42:50 +00:00
compat.php General: In the `is_countable()` polyfill, if the provided object implements `SimpleXMLElement` or `ResourceBundle`, consider it countable. 2018-05-10 17:58:22 +00:00
cron.php Cron API: Add function and filter to return ready cron jobs. 2019-01-08 21:49:49 +00:00
date.php Docs: Correct and improve various inline documentation. 2018-03-25 19:35:29 +00:00
default-constants.php Bundled Themes: Make twentynineteen the default theme. 2018-12-14 02:49:38 +00:00
default-filters.php Styles: Add helper functions for loading block styles. 2018-12-14 03:36:38 +00:00
default-widgets.php
deprecated.php Administration: Change all the occurrences of "(opens in a new window)" to "(opens in a new tab)". 2018-05-05 09:45:22 +00:00
embed-template.php
embed.php Build tools: Allow building WordPress to `src`. 2018-12-24 13:29:50 +00:00
error-protection.php Bootstrap/Load: Introduce fatal error recovery mechanism allowing users to still log in to their admin dashboard. 2019-01-09 20:05:49 +00:00
feed-atom-comments.php Coding Standards: Upgrade WPCS to 1.2.1. 2019-01-12 06:41:52 +00:00
feed-atom.php Coding Standards: Upgrade WPCS to 1.2.1. 2019-01-12 06:41:52 +00:00
feed-rdf.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
feed-rss.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
feed-rss2-comments.php Coding Standards: Upgrade WPCS to 1.2.1. 2019-01-12 06:41:52 +00:00
feed-rss2.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
feed.php
formatting.php Docs: Improve the `sanitize_email` filter. 2019-01-16 06:16:49 +00:00
functions.php Plugins: Use centralized API to display information about updating PHP when a plugin requires a higher version. 2019-01-16 17:07:00 +00:00
functions.wp-scripts.php I18N: Make domain argument optional in `wp_set_script_translations()` / `WP_Scripts::set_translations()`. 2019-01-04 21:12:50 +00:00
functions.wp-styles.php Docs: Fix typo in `wp_add_inline_script()` and `wp_add_inline_style()` description. 2018-12-20 02:42:48 +00:00
general-template.php Docs: Update inaccurate `return` descriptions. 2019-01-15 02:08:49 +00:00
http.php HTTP: Don't treat `localhost` as same host by default. 2018-04-03 15:00:31 +00:00
kses.php Docs: Update `since` annotation for `text-transform` support in `safecss_filter_attr()`. 2019-01-10 01:43:49 +00:00
l10n.php I18N: Add option to hide en_US locale in `wp_dropdown_languages()`. 2019-01-09 11:46:50 +00:00
link-template.php Link Template: In `get_adjacent_post()`, move the sanitisation of `$excluded_terms` earlier. 2019-01-15 01:54:49 +00:00
load.php Coding Standards: Fix the `Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace` violations. 2019-01-11 06:40:50 +00:00
locale.php
media-template.php PHPCS: Fix errors 2018-12-11 04:45:23 +00:00
media.php Coding Standards: Fix the `Squiz.ControlStructures.ControlSignature.SpaceAfterCloseBrace` violations. 2019-01-11 06:40:50 +00:00
meta.php REST API: Move object type-specific metadata integrations from the wrapper functions to the low-level Meta API functions. 2018-12-12 03:02:24 +00:00
ms-blogs.php Multisite: Introduce `ms-site.php` and `ms-network.php` files. 2019-01-08 09:15:49 +00:00
ms-default-constants.php
ms-default-filters.php Multisite: Move site-specific metadata integrations from the wrapper functions to the low-level Meta API functions. 2019-01-08 08:48:48 +00:00
ms-deprecated.php Multisite: Update `@since` tags for site management APIs. 2019-01-08 08:58:49 +00:00
ms-files.php
ms-functions.php Multisite: Update `@since` tags for site management APIs. 2019-01-08 08:58:49 +00:00
ms-load.php Bootstrap/Load: Introduce fatal error recovery mechanism allowing users to still log in to their admin dashboard. 2019-01-09 20:05:49 +00:00
ms-network.php Multisite: Introduce `ms-site.php` and `ms-network.php` files. 2019-01-08 09:15:49 +00:00
ms-settings.php
ms-site.php Multisite: Introduce `ms-site.php` and `ms-network.php` files. 2019-01-08 09:15:49 +00:00
nav-menu-template.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
nav-menu.php Nav Menus: Fix a PHP 7.3 error when switching themes. 2018-12-14 05:16:52 +00:00
option.php Docs: Improve the `@global` tags in `wp-includes/option.php`. 2019-01-08 06:00:50 +00:00
pluggable-deprecated.php
pluggable.php Users: Add extra checking to `wp_new_user_notification()`. 2019-01-16 04:27:50 +00:00
plugin.php
post-formats.php Post Formats: Don't assign a variable inside `if` statement in `get_post_format()`. 2018-08-30 09:01:25 +00:00
post-template.php Media: Add `$attr` to the `wp_get_attachment_link` filter. 2019-01-08 09:09:49 +00:00
post-thumbnail-template.php Media: Introduce the `has_post_thumbnail` filter. 2019-01-10 15:28:50 +00:00
post.php Query: Cache the result when `get_pages()` doesn't find anything in the database. 2019-01-14 23:27:50 +00:00
query.php Coding Standards: Upgrade WPCS to 1.0.0 2018-08-17 01:51:36 +00:00
registration-functions.php
registration.php
rest-api.php REST API: Encourage proper usage of `register_rest_route()`. 2019-01-11 18:19:49 +00:00
revision.php Posts: Set a HTTP 403 error when an incorrect post preview nonce is sent. 2019-01-16 03:54:50 +00:00
rewrite.php
rss-functions.php
rss.php
script-loader.php Block Editor: Upgrade the `@wordpress/` packages. 2019-01-10 01:54:56 +00:00
session.php
shortcodes.php Docs: Correct parameter name in `strip_shortcodes_tagnames` filter DocBlock. 2018-08-02 15:13:27 +00:00
spl-autoload-compat.php
taxonomy.php Taxonomy: Update `@since` annotations for `meta_box_sanitize_cb` arg. 2019-01-09 15:11:48 +00:00
template-loader.php Bootstrap/Load: Introduce fatal error recovery mechanism allowing users to still log in to their admin dashboard. 2019-01-09 20:05:49 +00:00
template.php Coding Standards: Extract `extract()` from the codebase. 2019-01-12 03:20:48 +00:00
theme.php Docs: Correct the `@return` type of `get_theme_mod()`. 2019-01-16 05:32:48 +00:00
update.php Docs: Add documentation for the `wp_maybe_auto_update` action. 2019-01-16 03:38:49 +00:00
user.php Privacy: Use consistent variable naming when working with privacy requests. 2019-01-15 22:35:52 +00:00
vars.php
version.php Media: `media_handle_sideload()` expectes `wp_insert_attachment()` to return a `WP_Error`. 2019-01-17 06:27:50 +00:00
widgets.php Docs: Improve documentation of the ``$wp_registered_sidebars` global. 2019-01-14 23:01:49 +00:00
wlwmanifest.xml
wp-db.php Coding Standards: Ignore the violations of `Generic.NamingConventions.UpperCaseConstantName.ConstantNotUpperCase`. 2019-01-11 06:08:50 +00:00
wp-diff.php