WordPress-C
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
WordPress/wp-admin
History
Felix Arntz 4e167c593d Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 
It is recommended that for every option it is explicitly set whether to autoload it or not. This changeset updates relevant `update_option()` and `add_option()` calls.

Note that the `$autoload` parameter is only needed for `update_option()` if the option is potentially not present yet, i.e. the call will pass through to `add_option()`. Since WordPress core adds the majority of its options to the database during installation, only `update_option()` calls for dynamically added options need to be modified, which is what this changeset does.

As part of revisiting the autoload values for dynamically added WordPress core options, this changeset modifies some options to no longer be autoloaded, since they are only accessed in a few specific places that are not relevant for a regular request. These options are:
* `recently_activated`
* `_wp_suggested_policy_text_has_changed`
* `{upgradeLock}.lock`
* `dashboard_widget_options`
* `ftp_credentials`
* `adminhash`
* `nav_menu_options`
* `wp_force_deactivated_plugins`
* `delete_blog_hash`
* `allowedthemes`
* `{sessionId}_paused_extensions`
* `recovery_keys`
* `https_detection_errors`
* `fresh_site`

An upgrade routine is present as well that sets those options to no longer autoload for existing sites.

Props pbearne, flixos90, mukesh27, swissspidy, SergeyBiryukov, joemcgill, adamsilverstein.
Fixes #61103.

Built from https://develop.svn.wordpress.org/trunk@58975


git-svn-id: http://core.svn.wordpress.org/trunk@58371 1a063a9b-81f0-0310-95a4-ce76da25c4cd
 		2024-09-03 18:19:14 +00:00
..
css Toolbar: Use CSS variable for the admin bar height in `wp-admin/css/common.css`. 2024-08-24 00:05:12 +00:00
images Help/About: Update the About page for 6.6. 2024-06-25 13:59:14 +00:00
includes Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
js Plugins: Delay AJAX search until after 2 characters. 2024-08-30 22:17:16 +00:00
maint Code Modernization: Use `dirname()` with the `$levels` parameter. 2023-09-11 04:53:22 +00:00
network Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
user Multisite: Add missing "contribute.php" file to User Dashboard. 2024-05-08 17:04:13 +00:00
about.php Help/About: Update performance improvements string. 2024-07-04 04:20:19 +00:00
admin-ajax.php Docs: Update AJAX in Plugins HelpHub link to avoid unnecessary redirection. 2024-07-04 11:22:13 +00:00
admin-footer.php
…
admin-functions.php
…
admin-header.php Docs: Add missing description for a few globals in the admin. 2024-06-15 12:34:13 +00:00
admin-post.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
admin.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
async-upload.php Media: Follow the "proximity of controls" accessibility guidelines in the multi-file uploader. 2024-06-02 08:37:09 +00:00
authorize-application.php Administration: Use `wp_admin_notice()` in `/wp-admin/`. 2023-09-14 00:54:19 +00:00
comment.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
contribute.php Help/About: Update the About page for 6.5. 2024-02-26 23:51:12 +00:00
credits.php Help/About: Update the About page for 6.5. 2024-02-26 23:51:12 +00:00
custom-background.php
…
custom-header.php
…
customize.php Customize: Sanitize autofocus URL parameter as an array. 2024-07-24 16:23:17 +00:00
edit-comments.php Administration: Use `wp_admin_notice()` more in `wp-admin/`. 2023-09-17 15:33:17 +00:00
edit-form-advanced.php Docs: Add missing description for a few globals in the admin. 2024-06-15 12:34:13 +00:00
edit-form-blocks.php Editor: Fix preloaded REST API paths 2024-08-16 06:23:17 +00:00
edit-form-comment.php I18N: Mark screen reader strings as such with translator comments. 2023-02-07 17:10:21 +00:00
edit-link-form.php Administration: Use `wp_admin_notice()` for `.updated`. 2023-09-14 02:15:17 +00:00
edit-tag-form.php Taxonomy: Correct the check for error messages in `wp-admin/edit-tag-form.php`. 2024-08-20 17:50:16 +00:00
edit-tags.php Taxonomy: Correct the check for error messages in `wp-admin/edit-tag-form.php`. 2024-08-20 17:50:16 +00:00
edit.php Docs: Add missing description for a few globals in the admin. 2024-06-15 12:34:13 +00:00
erase-personal-data.php Help/About: Accessibility: Remove `target="_blank"` from data eraser links. 2024-04-17 20:21:15 +00:00
export-personal-data.php Help/About: Accessibility: Remove `target="_blank"` from data eraser links. 2024-04-17 20:21:15 +00:00
export.php Docs: Correct the placement of `@global` tags in various files. 2024-05-26 20:51:13 +00:00
freedoms.php Help/About: Update the About page for 6.5. 2024-02-26 23:51:12 +00:00
import.php Upgrade/Install: Improve localized strings related to plugin/theme installation and activation. 2024-02-26 20:35:08 +00:00
index.php Administration: Use `wp_admin_notice()` in `/wp-admin/`. 2023-09-14 00:54:19 +00:00
install-helper.php Docs: Fix typo and improve DocBlock formatting in `wp-admin/install-helper.php`. 2022-11-20 14:10:15 +00:00
install.php Upgrade/Install: Fix JavaScript localization on install page. 2024-01-15 18:57:14 +00:00
link-add.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
link-manager.php Administration: Use `wp_admin_notice()` for `.updated`. 2023-09-14 02:15:17 +00:00
link-parse-opml.php Code Modernization: Use wp_trigger_error() instead of trigger_error(). 2024-06-13 20:50:14 +00:00
link.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
load-scripts.php Script Loader: Refactor Etag generation for concatenated assets. 2024-08-25 23:48:13 +00:00
load-styles.php Script Loader: Refactor Etag generation for concatenated assets. 2024-08-25 23:48:13 +00:00
media-new.php Help/About: Use the new `/documentation/` URLs for HelpHub links in WordPress Admin. 2023-02-23 10:38:21 +00:00
media-upload.php Coding Standards: Remove superfluous blank lines at the end of various files. 2023-09-07 14:59:21 +00:00
media.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
menu-header.php Administration: A11y: Use `aria-haspopup` only if item has popup behavior. 2024-06-20 19:41:15 +00:00
menu.php Editor: Expose the Site Editor Patterns page for classic themes. 2024-06-02 08:17:17 +00:00
moderation.php
…
ms-admin.php
…
ms-delete-site.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
ms-edit.php
…
ms-options.php Networks and Sites: Exit after `wp_redirect()` in `wp-admin/ms-options.php`. 2024-06-22 11:47:16 +00:00
ms-sites.php
…
ms-themes.php
…
ms-upgrade-network.php
…
ms-users.php
…
my-sites.php Administration: Add improved context for `add new` links. 2023-09-05 19:26:26 +00:00
nav-menus.php Menus: Accessibility: Improve screen reader text for edit button. 2024-06-03 20:35:13 +00:00
network.php Docs: Update various HelpHub links to avoid unnecessary redirections. 2024-03-08 22:38:08 +00:00
options-discussion.php Help/About: Use the new `/documentation/` URLs for HelpHub links in WordPress Admin. 2023-02-23 10:38:21 +00:00
options-general.php Administration: Modernize Site Icon UI in settings, customizer. 2024-08-23 22:47:16 +00:00
options-head.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
options-media.php Help/About: Use the new `/documentation/` URLs for HelpHub links in WordPress Admin. 2023-02-23 10:38:21 +00:00
options-permalink.php Docs: Update various HelpHub links to avoid unnecessary redirections. 2024-03-08 22:38:08 +00:00
options-privacy.php Administration: Remove empty form `action` attributes. 2024-01-16 17:31:13 +00:00
options-reading.php Normalize UTF-8 charset slug detection. 2024-05-14 18:05:11 +00:00
options-writing.php Docs: Update various HelpHub links to avoid unnecessary redirections. 2024-03-08 22:38:08 +00:00
options.php Options, Meta APIs: Prevent mail options triggering a deprecation warning. 2024-09-02 00:13:16 +00:00
plugin-editor.php Docs: Update various HelpHub links to avoid unnecessary redirections. 2024-03-19 14:46:15 +00:00
plugin-install.php Plugin Dependencies: Remove auto-deactivation and bootstrapping logic. 2024-02-20 07:27:06 +00:00
plugins.php Options, Meta APIs: Explicitly pass `$autoload` parameter to when potentially adding new options. 2024-09-03 18:19:14 +00:00
post-new.php Docs: Add missing description for a few globals in the admin. 2024-06-15 12:34:13 +00:00
post.php Docs: Add missing description for a few globals in the admin. 2024-06-15 12:34:13 +00:00
press-this.php Upgrade/Install: Improve localized strings related to plugin/theme installation and activation. 2024-02-26 20:35:08 +00:00
privacy-policy-guide.php Text Changes: Update mentions of “web site” to “website” for consistency. 2023-11-22 17:44:24 +00:00
privacy.php Help/About: Update the About page for 6.5. 2024-02-26 23:51:12 +00:00
profile.php
…
revision.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
setup-config.php Database: Remove back-compat for database servers that don't support `utf8mb4`. 2024-04-04 15:13:14 +00:00
site-editor.php Editor: Fix preloaded REST API paths 2024-08-16 06:23:17 +00:00
site-health-info.php Site Health: Add fonts upload location to Site Health report. 2024-06-03 16:56:16 +00:00
site-health.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
term.php General: Replace all `esc_url_raw()` calls in core with `sanitize_url()`. 2022-06-01 18:14:10 +00:00
theme-editor.php General: Remove any usage of `wp_reset_vars()`. 2024-05-01 18:01:12 +00:00
theme-install.php Administration: A11y: Add visible labels in theme UI. 2024-06-13 13:57:10 +00:00
themes.php Administration: Replace contracted verb forms for better consistency. 2024-08-10 23:02:06 +00:00
tools.php Help/About: Use the new `/documentation/` URLs for HelpHub links in WordPress Admin. 2023-02-23 10:38:21 +00:00
update-core.php Docs: Update various HelpHub links to avoid unnecessary redirections. 2024-03-08 22:38:08 +00:00
update.php Uploads: Check for and verify ZIP archives. 2024-01-30 14:23:12 +00:00
upgrade-functions.php
…
upgrade.php Upgrade/Install: Add missing escaping function for `get_option( 'home' )` in `upgrade.php`. 2023-08-25 05:44:16 +00:00
upload.php Upload: Move an assignment in `wp-admin/upload.php` into a conditional branch. 2024-03-09 18:07:15 +00:00
user-edit.php Application Passwords: Open documentation link in same window. 2024-07-27 23:06:17 +00:00
user-new.php Users: Remove periods in checkbox labels for consistency. 2024-01-12 17:14:14 +00:00
users.php Coding Standards: Fix WPCS issue found after [58564]. 2024-06-25 13:54:14 +00:00
widgets-form-blocks.php Widgets: Add missing no JS notice in Widgets screen. 2023-09-25 00:00:17 +00:00
widgets-form.php Administration: Remove empty form `action` attributes. 2024-01-16 17:31:13 +00:00
widgets.php Administration: Replace contracted verb forms for better consistency. 2022-03-22 19:59:04 +00:00