WordPress/wp-admin/includes
Scott Taylor cd7c0f0b0d Introduce `wp_validate_action( $action = '' )`, a helper function that checks `$_REQUEST` for `action` and returns it, or empty string if not present. If `$action` is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types.
Implementing this removes 27 uses of direct superglobal access in the admin.

For more reading:
https://codeclimate.com/github/WordPress/WordPress/wp-admin/edit-comments.php

See #33837.

Built from https://develop.svn.wordpress.org/trunk@34059


git-svn-id: http://core.svn.wordpress.org/trunk@34027 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2015-09-11 21:08:26 +00:00
..
admin-filters.php Move media hooks out of `admin-filters.php` as sometimes editors are used on the front end. 2015-08-06 20:40:26 +00:00
admin.php Move ad hoc Options functions to `wp-admin/includes/options.php`: 2015-09-10 21:45:24 +00:00
ajax-actions.php Merge two permission error strings. 2015-09-06 06:42:26 +00:00
bookmark.php Provide more helpful feedback than just "Cheatin' uh?" for permission errors in `wp-admin/includes/bookmark.php`. 2015-09-03 08:59:24 +00:00
class-ftp-pure.php Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
class-ftp-sockets.php Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
class-ftp.php Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
class-pclzip.php Deprecate php4 style constructors 2015-06-28 15:27:24 +00:00
class-wp-comments-list-table.php Comments/PHP Notices: check that a parent comment exists before displaying an orphan's link to it in the admin. 2015-09-10 20:51:23 +00:00
class-wp-filesystem-base.php Add `@access` docs to `class-wp-filesystem-*` files. 2015-09-10 01:21:24 +00:00
class-wp-filesystem-direct.php Add `@access` docs to `class-wp-filesystem-*` files. 2015-09-10 01:21:24 +00:00
class-wp-filesystem-ftpext.php Add `@access` docs to `class-wp-filesystem-*` files. 2015-09-10 01:21:24 +00:00
class-wp-filesystem-ftpsockets.php Add `@access` docs to `class-wp-filesystem-*` files. 2015-09-10 01:21:24 +00:00
class-wp-filesystem-ssh2.php Add `@access` docs to `class-wp-filesystem-*` files. 2015-09-10 01:21:24 +00:00
class-wp-importer.php Remove unnecessary feedback message from `WP_Importer::is_user_over_quota()`. 2015-06-30 20:32:25 +00:00
class-wp-links-list-table.php List Tables: 2015-07-14 17:47:24 +00:00
class-wp-list-table.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
class-wp-media-list-table.php Favor using the consistent and agnostic string 'Attach' over 'Attach to a post' in the media list table. 2015-08-30 03:10:21 +00:00
class-wp-ms-sites-list-table.php Multisite: Remove duplicate span element output from row actions 2015-09-01 21:51:21 +00:00
class-wp-ms-themes-list-table.php Add missing summaries to new methods added to `WP_MS_Themes_List_Table` in 4.3. 2015-07-13 16:13:26 +00:00
class-wp-ms-users-list-table.php Bring network admin user searching to parity with single site user searching by wrapping search terms in asterisks. This means that searches don't require an exact match and therefore significantly reduces friction when searching for users on the network admin screens. 2015-08-29 00:19:24 +00:00
class-wp-plugin-install-list-table.php Add `@access` annotations to methods that have no doc block in `wp-admin/includes/*`. 2015-05-29 21:32:24 +00:00
class-wp-plugins-list-table.php Fix the DocBlock summary for `WP_Plugins_List_Table->get_primary_column_name()`, added in 4.3. 2015-07-13 17:46:26 +00:00
class-wp-posts-list-table.php In `WP_Posts_List_Table::column_date()`, the order of status and time should be switched. It doesn't make sense for phrases like "Last Modified" to occur AFTER the date. Should be before. 2015-09-10 17:43:24 +00:00
class-wp-press-this.php Round 2 of: We should use ellipses … / … instead of three dots/periods ... e.g Loading… not Loading... 2015-09-09 04:39:25 +00:00
class-wp-site-icon.php Site Icon: Minor cleanup for `WP_Site_Icon` after [33329]. 2015-07-27 16:09:25 +00:00
class-wp-terms-list-table.php Introduce `wp_validate_action( $action = '' )`, a helper function that checks `$_REQUEST` for `action` and returns it, or empty string if not present. If `$action` is passed, it checks to make sure they match before returning it, or an empty string. Strings are always returned to avoid returning multiple types. 2015-09-11 21:08:26 +00:00
class-wp-theme-install-list-table.php Customizer: Use a `<button>` for the collapse sidebar … button. 2015-07-10 21:22:26 +00:00
class-wp-themes-list-table.php Themes: Remove legacy theme preview. 2015-07-29 18:36:26 +00:00
class-wp-upgrader-skins.php Fix PHP notice after [33492] when updating themes. 2015-08-19 10:35:25 +00:00
class-wp-upgrader.php Docs: Fix a variety of inline documentation syntax issues and add some strategic spacing. 2015-08-21 04:13:24 +00:00
class-wp-users-list-table.php Drop the hyphen from e-mail and standardize on email. 2015-08-28 03:17:21 +00:00
comment.php Move `comment_footer_die()` from `wp-admin/comment.php` to `wp-admin/includes/comment.php`. 2015-09-10 21:29:24 +00:00
continents-cities.php
credits.php Move ad hoc functions from `wp-admin/credits.php` to `wp-admin/includes/credits.php`, which is only included by the former. 2015-09-11 04:55:26 +00:00
dashboard.php After [33961], pass `$comment` to `comment_class()` where possible to avoid extra cache/db lookups. 2015-09-11 06:12:24 +00:00
deprecated.php Docs: Standardize `@deprecated` tag formatting and add missing DocBlocks to deprecated functions in wp-admin/includes/deprecated.php. 2015-08-20 21:23:25 +00:00
export.php In `WP_User`, add `@property` docs for `description`, `first_name`, and `last_name`. `user_firstname` and `user_lastname` only exist for back-compat. 2015-09-09 01:13:24 +00:00
file.php Fix closing div in `wp_print_request_filesystem_credentials_modal()`. 2015-09-05 15:17:24 +00:00
image-edit.php For doc block types, favor `bool` over the few remaining `boolean`s 2015-06-27 01:03:25 +00:00
image.php In `wp_generate_attachment_metadata()`, also pass `$metadata` to the `intermediate_image_sizes_advanced` filter. 2015-09-10 18:04:24 +00:00
import.php Add (more) missing doc blocks to `wp-admin/includes/*`. 2015-05-29 21:17:27 +00:00
list-table.php Add `@access` annotations to methods that have no doc block in `wp-admin/includes/*`. 2015-05-29 21:32:24 +00:00
media.php In `wp_media_upload_handler()`, replace a lingering instance of `media_upload_gallery()` with `wp_iframe(...)` 2015-09-10 17:24:23 +00:00
menu.php Don't loosely compare functions that return `bool` against a literal `bool`. 2015-06-12 17:19:27 +00:00
meta-boxes.php Docs: Fix some minor inline documentation syntax issues in the hook docs for the `post_edit_category_parent_dropdown_args` filter, introduced in [33682]. 2015-08-21 04:54:26 +00:00
misc.php Introduce `wp_removable_query_args()`, which returns an array of single-use query variables which can be removed from a URL. 2015-09-02 11:29:23 +00:00
ms-admin-filters.php Cleanup `(ms-)?admin-filters.php` 2015-06-19 21:18:25 +00:00
ms-deprecated.php Docs: Standardize `@deprecated` tag formatting for deprecated functions in wp-admin/includes/ms-deprecated.php. 2015-08-20 22:26:24 +00:00
ms.php Require numeric IDs in user deletion functions. 2015-09-11 02:25:23 +00:00
nav-menu.php Merge two similar strings. 2015-09-10 10:59:27 +00:00
network.php Create `wp-admin/includes/network.php` via `svn cp` and only load it in `wp-admin/network.php`. Move the functions there. 2015-09-10 22:01:24 +00:00
noop.php Create a new file, `wp-admin/includes/noop.php`, which loads all of the noop functions for `load-script|styles.php` and is only loaded by those files. DRYs in the process. 2015-09-11 05:04:23 +00:00
options.php Move ad hoc Options functions to `wp-admin/includes/options.php`: 2015-09-10 21:45:24 +00:00
plugin-install.php `foreach` is a statement, not a function. 2015-08-25 20:28:22 +00:00
plugin.php Move `plugin_sandbox_scrape()` from `wp-admin/plugins.php` to `wp-admin/includes/plugin.php`. 2015-09-10 21:24:24 +00:00
post.php Move `redirect_post()` from `wp-admin/post.php` to `wp-admin/includes/post.php`. 2015-09-10 21:31:24 +00:00
revision.php Remove ambiguity in the time display format in core, switches to using 24hr notation where am/pm isn't specified. 2015-03-23 02:14:27 +00:00
schema.php Schema: Increase the length of `wp_options.option_name`. 2015-09-11 01:26:24 +00:00
screen.php Implement a priority system for Help Tabs to add them at specific positions. 2015-09-10 01:27:23 +00:00
taxonomy.php Correct a parameter name in the docs for `wp_insert_category()`. 2015-07-13 12:59:25 +00:00
template.php Docs: Add a changelog entry to the DocBlock for `touch_time()` to mention the shift from accessing the global `$comment` to using `get_comment()`. 2015-09-09 15:48:25 +00:00
theme-install.php Add doc blocks to functions that are missing them. 2015-05-31 03:18:25 +00:00
theme.php Bump H3 headings to H2 on Themes screen for better accessibility. 2015-08-31 03:51:21 +00:00
translation-install.php Add `@global` annotations to (the rest of the?) `wp-admin/*` files. 2015-05-29 02:06:31 +00:00
update-core.php Remove `wp-includes/comment-functions.php` from the `$_old_files` array. See [33750]. 2015-08-27 20:40:24 +00:00
update.php Add `'update_right_now_text'` filter for the text displayed in the 'At a Glance' dashboard widget. 2015-08-31 21:45:21 +00:00
upgrade.php Schema: Increase the length of `wp_options.option_name`. 2015-09-11 01:26:24 +00:00
user.php Require numeric IDs in user deletion functions. 2015-09-11 02:25:23 +00:00
widgets.php Move `wp_widgets_access_body_class()` (a hook callback) from `wp-admin/widgets.php` to `wp-admin/includes/widgets.php`. 2015-09-10 21:22:23 +00:00