WordPress/wp-includes/rest-api/endpoints
hellofromTonya 5584cf60c0 REST API: Remove 'Invalid user ID' error in WP_REST_Users_Controller::update_item().
Removes the `WP_Error` code for `'Invalid user ID.'`. Why?

tl;dr
This branch will never be entered as the `$user` will never be falsey.

Longer reasoning:

[39954] introduced `WP_REST_Users_Controller::get_user()` method to encapsulate getting the user and handling the `'Invalid user ID.'` `WP_Error`. It replaced `get_userdata()` in `WP_REST_Users_Controller::update_item()` but left the existing `'Invalid user ID.'` `WP_Error` introduced in [38832].

The code removed in this changeset will never be reached because `$user` will never be falsey. Rather, `WP_REST_Users_Controller::get_user()` will always return an instance of `WP_Error` or `WP_User`. 

Could the user's ID be falsey?
No. Why? `WP_REST_Users_Controller::get_user()` checks that the user exists, which checks if the ID is falsey.

Therefore, the code can safely be removed.

Follow-up to [39954], [38832].

Props jrf, costdev, hellofromTonya, SergeyBiryukov.
Fixes #56662.
Built from https://develop.svn.wordpress.org/trunk@55325


git-svn-id: http://core.svn.wordpress.org/trunk@54858 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2023-02-13 23:10:20 +00:00
..
class-wp-rest-application-passwords-controller.php Application Passwords: Allow a Super Admin to set an application password on a site they're not a member of. 2022-08-11 18:24:09 +00:00
class-wp-rest-attachments-controller.php Coding Standards: Always use parentheses when instantiating an object. 2022-11-29 15:51:14 +00:00
class-wp-rest-autosaves-controller.php Revisions: only create autosave when content changed. 2023-01-27 22:03:19 +00:00
class-wp-rest-block-directory-controller.php REST API: Avoid unnecessarily preparing item links. 2022-07-22 14:00:12 +00:00
class-wp-rest-block-pattern-categories-controller.php Editor: Allow block pattern categories to have descriptions. 2023-01-19 12:13:14 +00:00
class-wp-rest-block-patterns-controller.php Docs: Improve documentation for block pattern properties. 2023-02-01 15:02:14 +00:00
class-wp-rest-block-renderer-controller.php Docs: Document the globals used in some REST API methods. 2021-06-30 12:34:56 +00:00
class-wp-rest-block-types-controller.php Blocks: Allow arrays for deprecated asset types in block registration. 2022-10-24 14:16:12 +00:00
class-wp-rest-blocks-controller.php Docs: Miscellaneous docblock corrections in REST API and Sitemaps API. 2022-01-15 21:22:02 +00:00
class-wp-rest-comments-controller.php Coding Standards: Always use parentheses when instantiating an object. 2022-11-29 15:51:14 +00:00
class-wp-rest-controller.php Code Modernization: Rename parameters that use reserved keywords in `phpunit/tests/rest-api/rest-*-controller.php`. 2023-01-20 00:21:15 +00:00
class-wp-rest-edit-site-export-controller.php Theme: Use a better method to determine the theme name during export 2022-05-17 12:10:14 +00:00
class-wp-rest-global-styles-controller.php Editor: Add support for custom CSS in global styles. 2023-02-02 18:52:17 +00:00
class-wp-rest-menu-items-controller.php REST API: Avoid unnecessarily preparing item links. 2022-07-22 14:00:12 +00:00
class-wp-rest-menu-locations-controller.php REST API: Avoid unnecessarily preparing item links. 2022-07-22 14:00:12 +00:00
class-wp-rest-menus-controller.php REST API: Avoid unnecessarily preparing item links. 2022-07-22 14:00:12 +00:00
class-wp-rest-pattern-directory-controller.php Editor: Support the `block_types` and `viewport_width` props for remote patterns fetched from Pattern Directory. 2023-02-06 19:40:16 +00:00
class-wp-rest-plugins-controller.php Docs: Correct and improve the documented types for various functions and hooks. 2022-08-11 14:03:09 +00:00
class-wp-rest-post-statuses-controller.php REST API: Support custom namespaces for custom post types. 2021-10-31 23:16:58 +00:00
class-wp-rest-post-types-controller.php REST API: Fix check for has_archive inclusion. 2022-09-22 11:33:13 +00:00
class-wp-rest-posts-controller.php Query: Add a `search_columns` argument to control which fields are searched in a search query. 2023-02-07 08:55:18 +00:00
class-wp-rest-revisions-controller.php Code Modernization: Rename parameters that use reserved keywords in `phpunit/includes/class-wp-unittest-factory-for-attachment.php`. 2022-12-30 02:38:17 +00:00
class-wp-rest-search-controller.php Docs: Miscellaneous improvements and corrections to docblocks. 2023-02-07 21:21:18 +00:00
class-wp-rest-settings-controller.php REST API: Add support for settings to specify their own additionalProperties. 2022-09-11 23:30:10 +00:00
class-wp-rest-sidebars-controller.php Widgets: Preserve classic sidebars when switching to a block theme. 2023-02-03 00:15:21 +00:00
class-wp-rest-site-health-controller.php I18N: Always pass `$locale` to `load_textdomain()`. 2022-11-10 19:40:11 +00:00
class-wp-rest-taxonomies-controller.php Taxonomy: Correct an invalid `@param` tag. 2022-10-11 09:56:11 +00:00
class-wp-rest-templates-controller.php REST API: Support non-Latin characters in template route regex. 2023-02-07 23:47:23 +00:00
class-wp-rest-terms-controller.php Coding Standards: Always use parentheses when instantiating an object. 2022-11-29 15:51:14 +00:00
class-wp-rest-themes-controller.php REST API: Avoid unnecessarily preparing item links. 2022-07-22 14:00:12 +00:00
class-wp-rest-url-details-controller.php General: Replace all `esc_url_raw()` calls in core with `sanitize_url()`. 2022-06-01 18:14:10 +00:00
class-wp-rest-users-controller.php REST API: Remove 'Invalid user ID' error in WP_REST_Users_Controller::update_item(). 2023-02-13 23:10:20 +00:00
class-wp-rest-widget-types-controller.php Code Modernization: Rename parameters that use reserved keywords in `wp-includes/rest-api/endpoints/class-wp-rest-widget-types-controller.php`. 2022-12-14 14:28:12 +00:00
class-wp-rest-widgets-controller.php Code Modernization: Rename parameters that use reserved keywords in `wp-includes/rest-api/endpoints/class-wp-rest-widgets-controller.php`. 2022-12-14 14:31:11 +00:00