WordPress/wp-includes/sitemaps
hellofromTonya f2f05f8e04 Code Modernization: Fix parameter name mismatches for parent/child classes in `WP_Sitemaps_Provider::get_max_num_pages()`.
In each child class, renames the parameter to match the parent's method signature.
Why? PHP 8 introduces the ability to pass named arguments to function/method calls. This means the child and parent method signatures (i.e. parameter names) need to match.

Adds @since to clearly specify why the change happened.

Reassigns the generic parameter to the original parameter.
Why? Restoring the original name keeps the context intact within the method and makes the code more readable. An inline comment explains why this reassignment is made.

Note: Reassignment is done after the guard clause.
Why? To avoid unnecessary processing and memory should the method bail out.

Follow-up to [48072].

Props jrf, hellofromTonya, sergeybiryukov, azaozz, desrosj, johnbillion.
See #51553.
Built from https://develop.svn.wordpress.org/trunk@51788


git-svn-id: http://core.svn.wordpress.org/trunk@51395 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2021-09-09 19:42:56 +00:00
..
providers Code Modernization: Fix parameter name mismatches for parent/child classes in `WP_Sitemaps_Provider::get_max_num_pages()`. 2021-09-09 19:42:56 +00:00
class-wp-sitemaps-index.php Sitemaps: Rename 'sitemap' to 'provider' in `WP_Sitemaps_Registry` class. 2020-07-21 15:29:02 +00:00
class-wp-sitemaps-provider.php Code Modernization: Pass correct default value to `http_build_query()` in `WP_Sitemaps_Provider::get_sitemap_url()`. 2021-08-23 11:44:01 +00:00
class-wp-sitemaps-registry.php Sitemaps: Replace `wp_sitemaps_register_providers` filter with more suitable `wp_sitemaps_add_provider` filter. 2020-07-21 16:14:07 +00:00
class-wp-sitemaps-renderer.php Sitemaps: Pass full paths to `home_url()` calls. 2020-07-14 11:43:03 +00:00
class-wp-sitemaps-stylesheet.php Coding Standards: Add a space before `/` character in some self-closing HTML tags. 2021-03-20 18:30:08 +00:00
class-wp-sitemaps.php Docs: Various formatting improvements to inline docblocks. 2020-07-23 00:52:05 +00:00