WordPress/wp-admin
desrosj 89ddd19884 General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset.
As part of the continued effort to improve PHP compatibility, the following improvments are being made:

- Removing deprecated PHP `safe_mode` checks not found in bundled external libraries.
- Change the remaining `while` loops using `each()` to `foreach` loops.
- Prevent false positives from being flagged for the `sodium_compat` library being caused by loading this in a non-standard way.
- Add inline comments to not flag deprecated PHP directives in the getID3 library.

Props desrosj, earnjam, dryanpress.
See #49922.
Built from https://develop.svn.wordpress.org/trunk@47735


git-svn-id: http://core.svn.wordpress.org/trunk@47511 1a063a9b-81f0-0310-95a4-ce76da25c4cd
2020-05-01 19:07:09 +00:00
..
css Administration: Remove right padding on form tables on smaller screens so that the spacing is equal on both sides. 2020-04-25 12:27:11 +00:00
images Customize: Give the WordPress logo a white background for dark mode browsers. 2020-04-10 02:50:07 +00:00
includes General: Fix various issues flagged by the PHPCompatibilityWP PHPCS ruleset. 2020-05-01 19:07:09 +00:00
js Privacy: Add an indication when the Copy action in Privacy Policy Guide is complete. 2020-04-12 14:26:11 +00:00
maint Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
network Networks and Sites: Don't display an empty Menu Settings section in network admin if there are no items. 2020-04-23 18:58:05 +00:00
user Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
about.php Help/About: Revert [47699] from trunk. 2020-04-29 18:44:11 +00:00
admin-ajax.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
admin-footer.php Docs: Improve inline comments per the documentation standards. 2020-01-29 00:45:18 +00:00
admin-functions.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
admin-header.php Administration: Escape admin title on output after the `admin_title` filter runs, not before. 2020-03-20 02:20:08 +00:00
admin-post.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
admin.php Administration: Capitalize `Trash` consistently in various messages and comments. 2020-02-10 04:12:07 +00:00
async-upload.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
comment.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
credits.php Help/About: Improve accessibility of the 5.4 About page: 2020-03-27 23:41:06 +00:00
custom-background.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
custom-header.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
customize.php Administration: Escape admin title on output after the `admin_title` filter runs, not before. 2020-03-20 02:20:08 +00:00
edit-comments.php Coding Standards: Use Yoda conditions where appropriate. 2020-02-09 16:55:09 +00:00
edit-form-advanced.php Editor: Revert a fix for incorrect usage of ID attributes on custom fields. 2020-03-03 00:37:06 +00:00
edit-form-blocks.php Block Editor: Backport inclusion of new editor settings to the core. 2020-02-10 17:52:15 +00:00
edit-form-comment.php Editor: Revert a fix for incorrect usage of ID attributes on custom fields. 2020-03-03 00:37:06 +00:00
edit-link-form.php Editor: Revert a fix for incorrect usage of ID attributes on custom fields. 2020-03-03 00:37:06 +00:00
edit-tag-form.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
edit-tags.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
edit.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
erase-personal-data.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
export-personal-data.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
export.php Export: Use correct context for the `Posts` label on the Export screen. 2020-02-11 19:35:06 +00:00
freedoms.php Accessibility: Fix the headings hierarchy on the Freedoms page. 2020-04-09 16:09:11 +00:00
import.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
index.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
install-helper.php Coding Standards: Use Yoda conditions where appropriate. 2020-02-09 16:55:09 +00:00
install.php Docs: Add descriptions for some globals: 2020-02-10 03:30:06 +00:00
link-add.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
link-manager.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
link-parse-opml.php Docs: Use more specific types in parameter descriptions in place of `mixed`. 2020-03-01 10:38:07 +00:00
link.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
load-scripts.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
load-styles.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
media-new.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
media-upload.php Coding Standards: Use Yoda conditions in some `wp-admin` files. 2020-02-09 16:53:06 +00:00
media.php Coding Standards: Use Yoda conditions in some `wp-admin` files. 2020-02-09 16:53:06 +00:00
menu-header.php Docs: Improve inline comments per the documentation standards. 2020-01-29 00:45:18 +00:00
menu.php Users: Change "Your Profile" and "My Profile" links in admin menu and toolbar to just "Profile" for consistency. 2020-04-20 08:39:06 +00:00
moderation.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-admin.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-delete-site.php Coding Standards: Use Yoda conditions in some `wp-admin` files. 2020-02-09 16:53:06 +00:00
ms-edit.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-options.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-sites.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-themes.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-upgrade-network.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
ms-users.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
my-sites.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
nav-menus.php Menus: Remove unused commented out code in `wp-admin/nav-menus.php`. 2020-04-21 09:02:08 +00:00
network.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
options-discussion.php Comments: Clarify that "Comment Moderation" and "Comment Blocklist" options in Discussion Settings also apply to browser's user agent string for submitted comments. 2020-04-15 06:40:05 +00:00
options-general.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
options-head.php Administration: Replace legacy `updated` message type in `add_settings_error()` calls with `success`. 2019-08-16 00:39:55 +00:00
options-media.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
options-permalink.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
options-privacy.php Administration: Capitalize `Trash` consistently in various messages and comments. 2020-02-10 04:12:07 +00:00
options-reading.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
options-writing.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
options.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
plugin-editor.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
plugin-install.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
plugins.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
post-new.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
post.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
press-this.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
privacy-policy-guide.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
privacy.php Help/About: Improve accessibility of the 5.4 About page: 2020-03-27 23:41:06 +00:00
profile.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
revision.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
setup-config.php Upgrade/Install: Return a more appropriate HTTP response status code (`409 Conflict`) if the `wp-config.php` file already exists. 2020-03-21 15:44:15 +00:00
site-health-info.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
site-health.php Site Health: Remove paragraph tag from the actions container in issue template. 2020-03-30 01:25:11 +00:00
term.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
theme-editor.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
theme-install.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
themes.php Themes: Always list broken themes even if the user cannot take a corresponding action within the admin area. 2020-03-26 17:50:15 +00:00
tools.php Privacy: Fix the URLs and legacy redirects for the personal data export and erasure screens. 2020-03-03 00:50:06 +00:00
update-core.php Docs: Add descriptions for some globals: 2020-02-10 03:30:06 +00:00
update.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
upgrade-functions.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00
upgrade.php Docs: Add descriptions for some globals: 2020-02-10 03:30:06 +00:00
upload.php Coding Standards: Use strict type check for `in_array()` and `array_search()` where strings are involved. 2020-04-05 03:02:11 +00:00
user-edit.php Users: Change "Your Profile" and "My Profile" links in admin menu and toolbar to just "Profile" for consistency. 2020-04-20 08:39:06 +00:00
user-new.php Coding Standards: Remove some extra tabs in `wp-admin/user-new.php`. 2020-03-27 22:30:09 +00:00
users.php Coding Standards: Use strict type check for `in_array()` and `array_search()`. 2020-04-09 15:43:10 +00:00
widgets.php Code Modernization: Replace `dirname( __FILE__ )` calls with `__DIR__` magic constant. 2020-02-06 06:33:11 +00:00