Scott Taylor fd9abeb0f9 Eliminate use of extract() in post_tags_meta_box() and post_categories_meta_box(). ...

Both functions only need to read `taxonomy`, yet they extract every available variable from `$box['args']`. Even if those variables were useful, there is no attempt to pass them to anything, and scope in PHP does not allow them to be scooped up by inner functions without being passed directly.
	
See #22400.

Built from https://develop.svn.wordpress.org/trunk@28391


git-svn-id: http://core.svn.wordpress.org/trunk@28219 1a063a9b-81f0-0310-95a4-ce76da25c4cd

2014-05-13 05:48:17 +00:00

..

admin.php

Load the new admin and network admin mo files, if present. see #19852

2012-01-27 22:19:56 +00:00

ajax-actions.php

First pass at wpview logic for the [embed] shortcode. URLs on a their own line are parsed as well. The toolbar will appear with the "remove" button when the view is clicked. Edit has not been implemented yet.

2014-05-10 23:36:18 +00:00

bookmark.php

Inline documentation for hooks in wp-admin/includes/bookmark.php.

2013-10-07 02:19:09 +00:00

class-ftp-pure.php

First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.

2013-12-24 18:57:12 +00:00

class-ftp-sockets.php

First there were two, and now there are three -- in the @since versions that came before and that shall be. And so it will be, says nacin.

2013-12-24 18:57:12 +00:00

class-ftp.php

"LGPL License" is redundant.

2013-02-15 16:26:46 +00:00

class-pclzip.php

Associate subdirector of whitespace trims trailing whites with pinking shears.

2009-10-15 20:26:21 +00:00

class-wp-comments-list-table.php

Eliminate use of extract() in WP_Post_Comments_List_Table::display(). The method only needs to read singular from $this->_args. Extraction is unnecessary.

2014-05-13 05:04:14 +00:00

class-wp-filesystem-base.php

First pass at documenting the WP_Filesystem methods. This also introduces stubs of the methods into the base class which are documented, which subclasses can override, some methods were cleaned up at the same time.

2013-09-22 04:44:10 +00:00

class-wp-filesystem-direct.php

Filesystem: Fix getchmod() for direct and ssh2 transports, for directories.

2014-03-17 20:17:15 +00:00

class-wp-filesystem-ftpext.php

Being consistent is the gist, no single @since should have been missed.

2013-12-25 02:00:11 +00:00

class-wp-filesystem-ftpsockets.php

Being consistent is the gist, no single @since should have been missed.

2013-12-25 02:00:11 +00:00

class-wp-filesystem-ssh2.php

Filesystem: Fix getchmod() for direct and ssh2 transports, for directories.

2014-03-17 20:17:15 +00:00

class-wp-importer.php

Remove lingering instances of call time pass-by-reference, limited to instances of callable - use $this instead of &$this.

2013-09-05 16:34:09 +00:00

class-wp-links-list-table.php

Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712.

2014-01-24 19:06:15 +00:00

class-wp-list-table.php

Eliminate use of extract() in WP_List_Table::pagination():

2014-05-13 05:27:14 +00:00

class-wp-media-list-table.php

In WP_Media_List_Table, remove dead code:

2014-05-06 15:27:33 +00:00

class-wp-ms-sites-list-table.php

Remove all "valign" attributes from tables in wp-admin, props MikeHansenMe, Marventus. Fixes #22712.

2014-01-24 19:06:15 +00:00

class-wp-ms-themes-list-table.php

Inline documentation for hooks in wp-admin/includes/class-wp-ms-themes-list-table.php.

2014-02-04 08:25:13 +00:00

class-wp-ms-users-list-table.php

In WP_MS_Users_List_Table::get_views(), remove dead code:

2014-05-06 15:30:14 +00:00

class-wp-plugin-install-list-table.php

Eliminate use of extract() in WP_Plugin_Install_List_Table::get_table_classes(). It only needs to read plural, no need to extract.

2014-05-13 05:17:14 +00:00

class-wp-plugins-list-table.php

Avoid searching HTML tags when searching plugins and themes. Fixes #27136. Props enej.

2014-03-11 22:24:15 +00:00

class-wp-posts-list-table.php

Better checks for contributors when saving posts.

2014-04-05 21:19:14 +00:00

class-wp-terms-list-table.php

Eliminate use of extract() in WP_Terms_List_Table::display_rows_or_placeholder():

2014-05-13 05:37:14 +00:00

class-wp-theme-install-list-table.php

Use a consistent context to remove duplicate strings.

2014-05-06 12:34:14 +00:00

class-wp-themes-list-table.php

Avoid searching HTML tags when searching plugins and themes. Fixes #27136. Props enej.

2014-03-11 22:24:15 +00:00

class-wp-upgrader-skins.php

Inline documentation for hooks in wp-admin/includes/class-wp-upgrader-skins.php.

2014-04-08 06:26:16 +00:00

class-wp-upgrader.php

Use a time constant in get_theme_feature_list() and File_Upload_Upgrader.

2014-05-05 08:26:24 +00:00

class-wp-users-list-table.php

In WP_Users_List_Table::get_views(), $current_role is set and never used.

2014-05-06 15:33:15 +00:00

comment.php

Inline documentation for hooks in wp-admin/includes/comment.php.

2013-09-14 01:01:08 +00:00

continents-cities.php

Give continents-cities their own textdomain. Props nbachiyski, Denis-de-Bernardy . fixes #9794

2009-05-14 20:05:25 +00:00

dashboard.php

Remove a dead variable, $start, from wp_dashboard_recent_comments().

2014-05-06 03:35:14 +00:00

deprecated.php

Remove _relocate_children(), which has had no purpose for some time.

2014-02-25 17:10:14 +00:00

export.php

Inline documentation for hooks in wp-admin/includes/export.php.

2014-01-28 08:10:12 +00:00

file.php

Dead code in wp-admin/includes/file.php:

2014-05-06 04:22:14 +00:00

image-edit.php

Avoid a notice in wp_save_image() by checking $meta['sizes']['thumbnail'] for ! empty() before setting a variable to it.

2014-05-11 03:42:14 +00:00

image.php

In wp_read_image_metadata(), the values from exif_read_data() should only override values from iptcparse() that are empty.

2014-05-11 05:54:15 +00:00

import.php

Slight renaming in our callback in [27373]. see #14424.

2014-03-03 17:09:14 +00:00

list-table.php

Remove lingering instances of call time pass-by-reference, limited to instances of callable - use $this instead of &$this.

2013-09-05 16:34:09 +00:00

media.php

In media_upload_gallery_form()'s inline JavaScript, remove unnecessary comment tags.

2014-05-11 06:12:15 +00:00

menu.php

Remove some debug cruft accidentally committed in [27670].

2014-03-24 02:38:17 +00:00

meta-boxes.php

Eliminate use of extract() in post_tags_meta_box() and post_categories_meta_box().

2014-05-13 05:48:17 +00:00

misc.php

Minor phpDoc fixes for the got_rewrite, got_url_rewrite, and documentation_ignore_functions hooks.

2014-05-08 11:13:14 +00:00

ms-deprecated.php

Remove ms-files.php rewriting from WordPress multisite. fixes #19235.

2012-09-11 22:22:20 +00:00

ms.php

In update_option_new_admin_email(), $email is set and never used.

2014-05-06 16:48:14 +00:00

nav-menu.php

In wp-admin/includes/nav-menu.php, remove dead code:

2014-05-06 16:55:14 +00:00

plugin-install.php

In install_plugin_information(), $title is set in a foreach loop and never used. This appears to be due to copy-pasting a previous foreach loop and not discarding these bits.

2014-05-06 17:00:18 +00:00

plugin.php

Deprecate unused argument of delete_plugins(). Clarify @return value.

2014-05-05 10:24:15 +00:00

post.php

Use an interpolated hook name for edit_{$post_type}_per_page instead of $per_page and adjust docs accordingly.

2014-05-08 08:16:15 +00:00

revision.php

Remove unused variable setting for $revisions in wp_prepare_revisions_for_js().

2014-05-06 03:45:14 +00:00

schema.php

Move 'home' option to the top of populate_options().

2014-05-05 21:57:14 +00:00

screen.php

Use interpolation instead of concatenation for the manage_{$screen->id}_columns hook name.

2014-05-08 09:58:14 +00:00

taxonomy.php

Eliminate use of extract() in wp_insert_category(). Adds unit tests. All unit tests pass.

2014-05-13 03:27:13 +00:00

template.php

Fix feature pointer RTL placement.

2014-04-14 00:00:14 +00:00

theme-install.php

Bring the theme browsing experience from 3.8 to the theme installer. First pass.

2014-03-11 07:47:15 +00:00

theme.php

Use a time constant in get_theme_feature_list() and File_Upload_Upgrader.

2014-05-05 08:26:24 +00:00

update-core.php

Update $_old_files for 3.9. see #27775.

2014-04-12 18:27:17 +00:00

update.php

In wp-admin/includes/update.php, remove dead code:

2014-05-06 17:21:14 +00:00

upgrade.php

In wp-admin/includes/upgrade.php, remove dead code:

2014-05-06 17:27:15 +00:00

user.php

Remove lame debugging. see #23057.

2014-03-08 03:16:27 +00:00

widgets.php

Remove temporary hooks added in [26865].

2014-02-28 00:45:16 +00:00